- 15 Sep, 2020 12 commits
-
-
Caitlin Fischer authored
The keys are GOOGLE_WEB_PROPERTIES_FIRST_PARTY and GOOGLE_WEB_PROPERTIES_TRIGGER_FIRST_PARTY. The new keys will be used to limit the set of experiment IDs included in X-Client-Data headers sent in third-party contexts when the RestrictGoogleWebVisibility feature is enabled. Note that the feature is disabled by default. Also, update relevant code to consider IDs associated with the new FIRST_PARTY groups. To do this, GetVariationsVector() and GetVariationsString() were changed to accept collections of IDCollectionKeys. Bug: 1094303 Change-Id: If931d8281f5a687548427101e07f3b3075cd349b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367989Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#806803}
-
Xiaohan Wang authored
For non-official builds, typically Widevine signing certs are not available. This CL updates `enable_widevine_cdm_host_verification` so it's only set to true by default when `is_official_build` is true. For developers enabling `is_official_build` and `is_chrome_branded` locally without Widevine signing certs, the build may fail. In this case simply set `enable_widevine_cdm_host_verification` to false to suppress the error. Bug: 1127616 Change-Id: I4256f8c53d79907eec23782300e223b4edb89d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410311Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806802}
-
Andrew Xu authored
Currently the calculation of the bubble menu bounds fails to take the cached menu position into consideration while calculating the normal menu bounds does. This CL fixes the inconsistency. Bug: 1126244 Change-Id: I783b435c082e766000457cf014c40e0931b2bb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394727 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#806801}
-
Orin Jaworski authored
This CL adds a unit test to ensure AutocompleteResult properly attaches Pedals to matches. Bug: 1122622, 893183 Change-Id: I6deff6ae0260a8c286a9538c73f1b319a255ebd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407011Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#806800}
-
K. Moon authored
Calls LoadUrl() from PdfViewWebPlugin with the URL from the "stream-url" attribute. Combined with crrev.com/c/2330933 (WIP), this is sufficient to start testing URL loading locally. Logs NOTIMPLEMENTED() from PdfViewWebPlugin's DocumentLoadComplete() and DocumentLoadFailed(), to make the outcome of loading obvious. Bug: 1099022 Change-Id: I94084fe42151daf5e4084749eb6ba466e2a918df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411329Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#806799}
-
Ian Barkley-Yeung authored
Split the code that sends the JavaScript error reports out from CrashReportPrivateReportErrorFunction. Future updates mean this code will also be called from content/browser/webui/. This CL should be have no functional changes other than a few small bug fixes, namely: * Redaction should happen after removing the error message to ensure the string matching works as expected. * Properly convert line number and column number to strings. Bug: chromium:1121816 Change-Id: Ibf1636fc3d32323a7d0350ee3cb91b3d81259d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399577Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#806798}
-
Garrett Beaty authored
The chromium.goma.migration console was used for tracking the migration of chromium builders to the RBE backend. The migration was completed some time ago and so the manually curated console is an unnecessary touch point when removing or renaming builders. Change-Id: I41c1b9a3e418b371a71e2830accb6919f684e063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411328 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#806797}
-
evliu authored
This CL defines the SODA tests to be run in the internal SODA waterfall. Bug: 1124873 Change-Id: I57296bb239dba6c03ef0e231ed30e8d043a35e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406591Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#806796}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I88dc0aab84f7532ec8bb0a9abede98e82713e63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411277Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806795}
-
David Black authored
Currently we wait until persistence has been restored but we need to also wait until downloads have been restored. Bug: 1128090 Change-Id: Iec43f87b18267cc7913f2129a4e6bfb2fc8a5e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410842 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#806794}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I3a455297048e8356fb60d1b0a6c4fcce813c827f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411271Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806793}
-
Harald Alvestrand authored
The JS-visible state wasn't always in sync after stop(). Also fix tests: Stop checking for "stopped" attribute that has been removed from spec. Change awaiting to account for negotiationNeeded being fired from setLocalDescription/setRemoteDescription(answer). Change expectations to account for transceivers disappearing from view when finally stopped. Still some remaining issues. Bug: chromium:980879 Change-Id: I5d4cb5482187ab40140ef99ac46f39a2d1628b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375648Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#806792}
-
- 14 Sep, 2020 28 commits
-
-
Chris Mumford authored
This reverts commit c663b9ea. Reason for revert: Suspected to be exposing test failures in Accessibility tests in content_browsertests and storage_service_content_browsertests. See https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/15808. Note that the one accessibility CL (r806594) was reverted, which did not fix this failure. Original change's description: > [base] CHECK(str) in BasicStringPiece constructor > > This change adds a CHECK(str) into BasicStringPiece's constructor from > `const value_type* str`. This prepares the code base for switching to > std::string_view, since std::string_view(nullptr) would invoke undefined > behavior. > > Bug: 1049498 > Change-Id: Id5d832bc0586dc16a5e1045ba67602e4dc57317d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407712 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806581} TBR=dcheng@chromium.org,jdoerrie@chromium.org Change-Id: Ie734746c940bad086a189485d792ffd02a6b7a97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411430Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#806791}
-
Matt Jones authored
Bug: 1126872 Change-Id: I2f8696f6e57cc3be78fec1713707478a5ce4a1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406839 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#806790}
-
Takuto Ikuta authored
This reverts commit d2a879a0. Reason for revert: https://crbug.com/1127966#c29 Original change's description: > Roll luci_go to 18502e6a01811b0c2dd2a0250e81bd82e47d2c2d > > https://chromium.googlesource.com/infra/infra/+/18502e6a01811b0c2dd2a0250e81bd82e47d2c2d > > Bug: 1127205 > Change-Id: Ia58d7727f1b877bd4c48b62fa4c0872bd449be50 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409393 > Commit-Queue: Ye Kuang <yekuang@google.com> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806576} TBR=tikuta@chromium.org,jwata@google.com,yekuang@google.com Change-Id: I7edfe4c16543b70e2b3dd2fcbd9822c6ea7d6bf8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127205, 1127966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409881 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#806789}
-
Tomasz Wiszkowski authored
This change propagated suggestion subtypes to Java, enabling Clank to identify Trending Query suggestions. Bug: 1122669 Change-Id: Id6669bd9c9344e786836486fd5c66087bbc6f1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402135 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#806788}
-
Robbie McElrath authored
This CL modifies our copy of the AndroidX fragment library to include r.android.com/1302016, which prevents a problematic getActivity() call in DialogFragment.java. Bug: 1123216 Change-Id: I33ffcdc00b694ac5b521ba30014053d2acdbdfc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406600Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#806787}
-
Ryan Hansberry authored
BluetoothServerSocket is created on the main thread, but its public methods are used on a separate dedicated thread. mojo::Remote objects (namely, BluetoothServerSocket's |server_socket_|) must be bound on the same thread they are used on, to prevent deadlock. So, we hold onto this mojo::PendingRemote |pending_server_socket_| until Accept() is called, at which point |server_socket_| is bound with it (it is acceptable to pass a mojo::PendingRemote around multiple threads). bluetooth_server_socket_unittest.cc has been adjusted for this change. I have verified that the test fails if this fix is not present. Further, mojo::Remotes expect to be run on a SequencedTaskRunner. Tweak our ImplementationPlatform::CreateMultiThreadExecutor() impl to provide a SequencedTaskRunner to satisfy this requirement. Bug: 1126620 Change-Id: I5dbb11d0d97b8167f60acb08fc1ae962bdf17f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407296Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#806786}
-
Siyu An authored
Bug: 1112095 Change-Id: I7e4d41d8baaafb9d8b900690b5af7811d29615d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410307 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#806785}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/081bc32703b7..0acb5b50b342 2020-09-14 brianosman@google.com Allow casting to lower precision types in runtime effects 2020-09-14 kjlubick@google.com [fuzz] Make libfuzzer defines backwards compatible for roll 2020-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from b1f9041ffe31 to 069b8f699b59 (1 revision) 2020-09-14 egdaniel@google.com Force linux nvida vulkan to use dedicated image allocations. 2020-09-14 adlai@google.com Downgrade SkImage to GrImageContext 2020-09-14 ethannicholas@google.com SkSL optimization now happens in convertProgram rather than being a 2020-09-14 adlai@google.com Elevate caps methods to GrRecordingContext 2020-09-14 egdaniel@google.com Update GrVkRenderPasses to be created to support both input attachments and adv blend. 2020-09-14 mtklein@google.com bazel baby steps 2020-09-14 johnstiles@google.com Generate SkSL golden output files from test inputs during the build. 2020-09-14 johnstiles@google.com Enable the inlining pass during optimization. 2020-09-14 kjlubick@google.com [fuzz] Standardize, document, and backport fuzzing defines. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1127358 Tbr: scroggo@google.com Change-Id: I76d55b9b5b3c4a7ecd6eb65c6632bf5d902448f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410616Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806784}
-
Yulun Wu authored
There is a presubmit error for search_result_suggestion_chip_view.cc as it is missing an include. search_result_suggestion_chip_view.cc:204: Add #include <algorithm> for min [build/include_what_you_use] [4] Bug: 1128107 Change-Id: I167dfb004de9fa4844d5f8138f23b12e556cbee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410589 Auto-Submit: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806783}
-
Johann authored
Remove usage of DISALLOW_COPY_AND_ASSIGN from documentation. styleguide/c++/c++-dos-and-donts.md: 'DISALLOW_COPY_AND_ASSIGN` is deprecated. For a non-copyable/movable type, delete the copy operations (the move operations will be implicitly deleted); otherwise, declare either copy operations, move operations, or both (a non-declared pair will be implicitly deleted). Always declare or delete both construction and assignment, not just one (which can introduce subtle bugs). Change-Id: I2d2e0ecf95c3ef764dc90d49c674625c15432d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404905Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#806782}
-
Ken MacKay authored
Bug: internal b/160616014 Change-Id: If764ba82678059a21cda3d9ecd44c7dbe620fb92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410926 Auto-Submit: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806781}
-
Mohammad Refaat authored
This will be used by crash restoration logic to know which sessions to backup for restoration. Bug: 1126311 Change-Id: I064d1da30bfcfc368539240b7c9c9a2f65490d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399886Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#806780}
-
Yusuf Sengul authored
Bug: 1127549 Change-Id: Ie996c71a86bd6303f8e82c20086ad34711b89e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407074Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#806779}
-
Filip Gorski authored
Choosing to disable 3 tests failing on an assert, because an alternative is to revert a crash fix. This fails on assert which is compiled out. TBR=peconn@chromium.org Bug: 1128073 Change-Id: Icc5667f4ad1504c7776bc06af010e9f8d94b5a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410923Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#806778}
-
Nina Satragno authored
Add partial support to the largeBlobs CTAP2.1 command at the device level. In particular, implement chunking, reading and writing arbitrary blobs. The virtual authenticator command is also implemented in order to test the feature. Missing features are encrypting & compressing the blobs and pin token. Nothing is wired to the web yet. This is part of the large blob storage extension implementation. https://w3c.github.io/webauthn/#sctn-large-blob-extension Bug: 1114875 Change-Id: I2f85c0b0b17b2054ad5bc0af69432d1765b6f2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388992 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#806777}
-
Robert Sesek authored
This is needed to look up the Metal cache directory, which is used for graphics acceleration by various system frameworks. Bug: 1126350 Change-Id: I79e05c603859aa49082fbbbc09c1da9b4ae3a990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411151 Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#806776}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkProxyInputTest* Change-Id: I45813304a2c638cd13bb64a46e2fe14a23037783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406666 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#806775}
-
chrome://flagsRoman Arora authored
Bug: 1099917 Change-Id: I828357cb3123ffbf574b25756082b7f5f966f3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405532Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#806774}
-
Markus Handell authored
The sample callback was heavily convolved with lots of if:s and really hard to read with all special cases. This change cleans it up. Bug: 1127791 Change-Id: Id9cb4b4994288667d3fa22e5dfd4ade095853d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410400 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#806773}
-
David Bienvenu authored
A bit of cpp lint cleanup, no functional changes. Bug: 1010217 Change-Id: I7b713e20ae81a896537f0683b1ba31a8465c9d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408179Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806772}
-
Frédéric Wang authored
This is a refinement of [1] [2] [3] [4]: 1. MathML elements should not try to force NG layout when using a non-math display. 2. Really make ShouldForceNGLayout() override ShouldForceLegacyLayout() ([1] was only doing that for the inherited child context). 3. Make MathML elements class keep handling the case of a forced legacy layout, but only on non-math display values. Note that this check is not necessary in LayoutObjectFactory::CreateMath which is only called for math display values. 4. Allow to override the display of the <math> tag too (it's unclear why [3] had a special case and that does not match the spec). Ideally, 3. can be removed when we completely switch to NG layout for all displays. New tests are added to verify related crashes found by clusterfuzz and check overriding of the layout MathML elements with various display values. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2398702 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2397949 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1985766 [4] https://chromium-review.googlesource.com/c/chromium/src/+/1917207 Bug: 6606, 1127628, 1127407, 1127222 Change-Id: I62b0ef4de623f4eb93184a1cecce598905160dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409957 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#806771}
-
Toby Huang authored
After OOBE sign-in, FamilyUserMetricsProvider:: ProvideCurrentSessionData() sometimes gets called before the AccountManager has been initialized. Check for this scenario and return prematurely to avoid throwing a DCHECK. Bug: 1103077,1127838 Change-Id: I8cda0daccdfe3398e1891ecd4f4663ae71fea742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404409 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#806770}
-
Owen Min authored
Move all files from package org.chromium.policy to org.chromium.components.policy as other java code in //components. Change-Id: I1be82a80e38d7b2cdacddeedd3d1e9d6f8b9b556 Bug: 1127469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406526Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#806769}
-
Changwan Ryu authored
- There was no flake in the test history on FYI bot recently, - There is no stack trace available from the bot. - Not locally reproducible. Re-enable this test to get the stack traces and see if flakiness can still be reproduced. 50 times on emulator out of 50 trials Tested: passed AndroidScrollIntegrationTest#testTouchScrollCanBeAlteredByUi Bug: 813837 Change-Id: Ibb240d0720a223c20f8d815c0c0fa6d4246a7e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411147 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#806768}
-
Michael Hansen authored
Invalidate send and receive surfaces to make sure we start or stop advertising based on changes to screen lock state. Bug: b:166174379 Bug: 1119993 Change-Id: Ie7490d888b42e4c4aac783216b54490476f53aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392703 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#806767}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ide799d50c22a45123b3a15fd6cff731176da6cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410522Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#806766}
-
Keren Zhu authored
Add FeaturePromoSnoozeService that handles the dismiss and snooze of IPH bubble by the user. This service uses PrefService as the storage for snoozed IPH status. This service is a middleware between IPH frontend and backend. The frontend asks it for IPH display permission before asking the backend. The frontend should notify this service when the user clicks dismiss or snooze button on the IPH bubble. Note that in addition to snooze, this service handles dismiss. Otherwise, we will have to change backend to incorporate dismiss logic. Bug: 1121399 Change-Id: Ie0817a1ec15ff835344aa95dc17a27c0ae6f4338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398979Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Auto-Submit: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806765}
-
Kyle Milka authored
Bug: 1090917, 1022172 Change-Id: I109106e44ffddda58e1418cf438ab09eed20f038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324994 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#806764}
-