- 23 Jul, 2020 40 commits
-
-
Maksim Sisov authored
SurfaceHandle is of the same type as ozone now. Remove the USE_X11 section now. Change-Id: Ic69a251a5bc5214b3c00f39446d430e74253692d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315344Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#791238}
-
David Bienvenu authored
Also, change IsFullScreenWindowMode to not require the absence of WS_THICKFRAME when deciding if a window is full screen. This issue this fixes involves the glass_browser_frame_view when maximizing after going full screen - an extra 8 pixel bar gets drawn above a maximized window, and if there's another monitor above the one with chrome maximized, the bar gets drawn on the other monitor. Windows doc https://docs.microsoft.com/en-us/windows/win32/winmsg/window-styles claims that some styles can't be changed after the window is created, but also says that if you change frame styles, you need to call SetWindowPos with SWP_FRAMECHANGED, which we are doing. Not removing the WS_THICKFRAME style doesn't seem to have any visible effect on full screen windows. Bug: 1014720 Change-Id: Ibfbd480c603fd7c3aca74081201e99e59fbbbecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972258Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791237}
-
Francois Doray authored
Bug: 1075553 Change-Id: I9ac77c32e96dba8a4f56fda637a8b7d0313b83aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314456Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#791236}
-
Tina Wang authored
Previously “Autocomplete Searches and URLs” fails to work as intended after enabling “experimental settings > “Enable Sample Policies”. Bug: 1108313 Change-Id: I83d0d12d5e9f0017f2791a7bc3ba75abc476f3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315499Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791235}
-
Thomas Lukaszewicz authored
Updated Slider to be default constructable. Cleaned up some calling code. Bug: 1108460 Change-Id: I03b91286288322c2709e9ace2d0196dbc04ff230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313496Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#791234}
-
Friedrich Horschig authored
Since the button has no functionality yet, hide it by default. Advantages of hiding over removing the code: - it provides the correctly styled button for other experiments - we can keep the finished translation for now and can reenable it on short notice Bug: 1106277 Change-Id: Ic82ac97b6de43451b15202fbce1dd06d117ec18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312801 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#791233}
-
Torne (Richard Coles) authored
The version of dexdump in build-tools 30.0.1 includes more information than previous versions in its output, which has revealed that it doesn't encode its output as valid XML in all cases; Java strings with control characters or nulls end up emitted literally in the XML output, which breaks ElementTree's parser. b/161925303 has been filed internally to track fixing this in dexdump itself. Since we only need to be able to extract a few specific things from the dexdump output in our tooling, just replace invalid characters in the output with the Unicode replacement character (as Python does when using the 'replace' error handler in encoding) before parsing it. Bug: 1106471 Change-Id: Id1c3a40e5ce91125dbee9fdf1923383d02314f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314986Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#791232}
-
Ben Mason authored
TBR=cduvall@chromium.org Bug: 1108684 Change-Id: Ibbaaf0b555c01c2a55c8c6469dc10c8ebe5b9536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315836Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#791231}
-
Shuran Huang authored
Added a UseCounter that tracks when window.name that would have been cleared because of a top-level cross-browsing-instance navigation is accessed. The metric will be used to determine whether we can safely clear the window.name in such cases. Bug: 1090128 Change-Id: I9224ae9e542a55b5d4a2efe437037ad2ea115b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276250 Commit-Queue: Shuran Huang <shuuran@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#791230}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b8fe9093351f..446b974be827 2020-07-23 kjlubick@google.com Remove old devices.json and code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1097221 Tbr: robertphillips@google.com Change-Id: I822e006e5196a1956c9603077e1f90ead4c4013a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316243Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791229}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fbe60cdd. With Chromium commits locally applied on WPT: a02f2df5 "Implement Storage Access commands for TestDriver" 9c2ef271 "[COOP report] Add support for report-only" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-ui NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I533cf5c0f0c09ecad5479b9c2795c1fafef16b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315303Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791228}
-
Ken Rockot authored
This eliminates all but a few .typemap files for Blink-variant typemaps, replacing them with direct GN target settings instead. Bug: 1059389 Change-Id: Id8276f3256ac36e3f2bfc4ee02b0732064a727cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315439Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#791227}
-
sandromaggi authored
Bug: none Change-Id: I63f5c2f559ef0deb5169c64f6c99b24afab57393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315028 Auto-Submit: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791226}
-
Andrew Grieve authored
Should fix: ../../chrome/browser/safe_browsing/android/safe_browsing_bridge.cc -o obj/chrome/browser/safe_browsing/android/android/safe_browsing_bridge.o In file included from ../../chrome/browser/safe_browsing/android/safe_browsing_bridge.cc:7: ../../chrome/browser/profiles/profile_manager.h:28:10: fatal error: 'chrome/common/buildflags.h' file not found Bug: 1108424 Change-Id: Ib5a8787c60d6e3d8c166dcbcc4dedfecd4a1849c Fixes: 1108424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315498Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#791225}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/201d43aed5f5..df5ed61ddbca 2020-07-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from d92ddcef72ef to adf938680697 (9 revisions) 2020-07-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 11fa4d0d5694 to 3ee5f2f1d331 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I3799dc791660d8e404b373d5f06522b1fa9005d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316238Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/b7c467b6efa5..b6183ea36975 2020-07-23 wl@gnu.org * src/sfnt/sfwoff2.c (woff2_decompress): Fix compiler warning. 2020-07-16 david.turner.dev@gmail.com Add .clang-format file If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I536527e78796797ecf74c33292a2f0bb8a788421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316236Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#791223}
-
Danila Kuzmin authored
Battery warning message is shown after UPDATE_AVAILABLE stage on update screen iff the battery is DISCHARGING and is lower 50%. In this CL only placeholder for html part is provided. Bug: 1101783 Change-Id: I70376a668c1a905e5dbab6cda986f13029e8e71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285009 Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#791222}
-
Karel Král authored
Implement tracing of array types that are used as parameters of mojo autogenerated methods. Thus provide more debugging information. Refactor _WriteInputParamForTracing to avoid code repetition and make the code more readable. Bug: 1103623 Change-Id: I9b5feb8b79d1fd5026968d00a8926edc11b6a7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307829 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#791221}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595483644-6e8695d24392ae339c7de29c47d12948bf6cd425.profdata to chrome-mac-master-1595505150-b920bff7e4a91d427dfc50f17f264391e8fbe691.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id9efda58b4d59f0eb99784c4406e41a0d3cf1b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316247Reviewed-by:
-
Tomek Ponitka authored
Added a writeTexture function. Bug: dawn:483 Change-Id: I2276553daa0c8c1491c7aebfcc63b068bdc0e93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303394 Commit-Queue: Tomek Ponitka <tommek@google.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#791219}
-
Owen Min authored
When user sign in to the content area but not fully consented sync and force sign in is turned on, we shouldn't use the reauth workflow after password is typed. Using normal sign in workflow to show the sync confirmation dialog. Bug: 1101839 Change-Id: I3690e165727e15ce1cb54ae063b8e83e2575bcbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304534Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791218}
-
Tommy Martino authored
This CL introduces a new util method, RegisterEditMenuItem, for adding items to the global Edit Menu singleton. This is needed because the classes that add to the Edit Menu overwrite the contents of the custom actions in the singleton. I also found what I believe to be a small metrics logging error in LocationBarVC, and updated it to be consistent with OmniboxVC. Context: Fixing the overwrite behavior described above enables adding a new Edit Menu action to the content area. This refactor was split off from: https://chromium-review.googlesource.com/c/chromium/src/+/2285328 Bug: 1099268 Change-Id: Ia8fad48aad0d047551439faa95c39374a2a8e156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313477Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#791217}
-
Nico Weber authored
This is a reland of fc86bd6c We landed a workaround for the SDK bug, see https://crbug.com/1108561 Original change's description: > mac/arm: Update to Xcode 12 beta 3. > > Bug: 1098899 > Change-Id: I9423e63db7f55fe4c18271a26ff60cee6b802bc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314676 > Commit-Queue: Nico Weber <thakis@chromium.org> > Commit-Queue: Mark Mentovai <mark@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791026} TBR=mark Bug: 1098899 Change-Id: Idc42491929c5eb21a1f12c14ef3e9156fe6698e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315012Reviewed-by:
-
Maksim Ivanov authored
Add ability to wait for the given events into ExtensionForceInstallMixin: * the pref gets updated; * the extension's background page is loaded for the first time. Migrate the tests in challenge_response_auth_keys_loader_browsertest.cc onto ExtensionForceInstallMixin (instead of TestCertificateProviderExtensionLoginScreenMixin). Bug: 1090941 Change-Id: I2b71546564b99a682a74fef70abc243d3e198c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312640 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#791215}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d192a324..5cdec88a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I97c8cd553953bc933789bc5a4e3c337f37f82a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316140Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791214}
-
Igor Eremeev authored
- Fix address space leak in modern linker. If wanted address can no longer be mapped at (which is possible), linker falls back to usual aslr loading without sharing relro's. There was a missing call to munmap, so that this chunk of 192MB remained dangling. Legacy linker handles this correctly, see InternalElfLoader::ReserveAddressSpace at crazy_linker lib. - Fix needless call to GetRandomBaseLoadAddress in child processes. Method ensureInitializedLocked uses mInBrowserProcess to determine if it needs to generate an address for library loading. mInBrowserProcess is initialized with 'true', so we had a useless mmap of 192MB in every child process. Change-Id: I918e9a35bf5179a79a3676e4a50f3c6e7677933c Bug: 1108740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315019Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Auto-Submit: Igor Eremeev <myrth@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#791213}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iafb72e702abc732258a65ae8af19793670cf3c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316001Reviewed-by:
-
Francois Beaufort authored
This CL makes sure pan, tilt, and zoom can only be set when page is visible. When page is hidden, applyConstraints will reject with a SecurityError for pan, tilt, and zoom only. Spec: https://github.com/w3c/mediacapture-image/issues/236 Bug: 934063 Change-Id: I442985fabe7337093e336cfd804e405f4c965a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302691Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#791211}
-
Chris Thompson authored
This adds SCT auditing enable/disable interfaces to NetworkContext to control auditing behavior on a per-NetworkContext basis, and a new SCTReportingService to monitor changes to the Safe Browsing Extended Reporting status per-profile (to gate SCT audit collection to users opting in to Extended Reporting). The SCTReportingService also receives the notifications about new SCTAuditReports sent to the NetworkContextClient. As this makes entries in the SCTAuditingCache visible to the browser, this also adds end-to-end tests covering the cache behavior. Bug: 1082860 Change-Id: I98922bbdc359cc641b920185fd0b4ccd8aea9eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252569 Auto-Submit: Christopher Thompson <cthomp@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#791210}
-
arthursonzogni authored
Patch [3/N] modified blink windows's binding to call CheckCoopAccess() whenever a "CrossOrigin" attribute/methods was accessed. So far, so good. Nevertheless, some attributes are missing, because they have a custom implementation. CheckCoopAccess needs to be added manually for them. This patch fixes the accesses to "location". COOP access reporting: [1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 [4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120 [5/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309433 [6/N] https://chromium-review.googlesource.com/c/chromium/src/+/2308715 [7/N] this patch. Bug: chromium:1090273 Change-Id: I6509604950baf04e5a9b644981c58282ef5e7dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309697 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#791209}
-
Marc Treib authored
Bug: 1079297 Change-Id: I1cb15bd3e3b9cdafcc46bb8954f731fa8b35242b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300439 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#791208}
-
Sebastien Lalancette authored
This factory will be used by components to create UIAction instances and use these instances to populate the new Context Menus. The Factory's role is to decorate execution blocks with metrics collection along with providing consistent titles and images for these actions. Disclaimer about testing: UIAction does not expose the execution block. This means we cannot unit test UIAction instances' execution, we'll have to rely on EG tests for that. Bug: 1093302 Change-Id: I835bcceabeff53ecf65da54f6518eb1edd0d6d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303361Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#791207}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/06d53faa7b72..7f89cfd4944e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pmarko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pmarko@google.com Change-Id: I1e43b82d098dc5865d725303c5368399075d592c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315206Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791206}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3aaaa5dab3a102d55c46ae1e3d9cf44e809bc67c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316237Reviewed-by:
-
Rohit Rao authored
https://chromium-review.googlesource.com/c/chromium/src/+/2266476 modified this test to pass applicationActive:NO instead of YES. This invoked a different codepath in url_opener.mm that happens to always call |connectionInformation.startupParameters|. The test was only registering an expectation for this call when DCHECKs were enabled, causing a failure in Release builds. BUG=1102032 Change-Id: I30ea62892300cf9fa1cac453149acfa08ca1c159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315254Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#791204}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/af6416cd74c8..038b9b33775b 2020-07-23 kimanh@chromium.org Use setBreakpoint() only when creating a new breakpoint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1105172 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I92717ea57b2483cb209067fd1811c212a72c9824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315207Reviewed-by:
-
Mike Dougherty authored
[LocationBarViewController visitCopiedLink] should log "Mobile.OmniboxContextMenu.VisitCopiedLink" instead of "Mobile.OmniboxContextMenu.SearchCopiedImage" Fixed: 1108682 Change-Id: Icec446acb57d6821f51c181352c0399dca170701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315224 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#791202}
-
Guido Urdaneta authored
This CL makes CheckMediaAccessPermission pass the main RenderFrameHost of the embedder WebContents instead of the original RenderFrameHost. This makes it work similarly to RequestMediaAccessPermission(), which uses the embedder WebContents instead of the original WebContents, and fixes an issue with device enumerations when using ChromeOS logins, where the permission check always failed. Note that CheckMediaAccessPermission() originally used the embedder WebContents until the switch to RenderFrameHost in crrev.com/540967. Bug: 1086756 Change-Id: I5342c8d2617144caca7e451af0f12f31b5c6bb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294807Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f9803e14b0fb..33265b79e5b1 2020-07-23 eseckler@google.com ui: Clear traceProtoWriter between ADB recording sessions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0e98fdab9089973a6d1e35f44baaacb64f919417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315205Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 787b18d6. With Chromium commits locally applied on WPT: a02f2df5 "Implement Storage Access commands for TestDriver" 9c2ef271 "[COOP report] Add support for report-only" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I5cf73526e4d3b14b681eaac2d66f54ad5c3a241f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316036Reviewed-by:
-
