- 11 Dec, 2018 40 commits
-
-
David Lu authored
Bug: 896461 Change-Id: Ie34adadd37e87630816d5a776429c06e7d1ec204 Reviewed-on: https://chromium-review.googlesource.com/c/1370203Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: David Lu <davidluphd@google.com> Cr-Commit-Position: refs/heads/master@{#615659}
-
Justin Donnelly authored
Also fix an issue with the score boosting. Bug: 913299 Change-Id: Ia44b6e8658a37a75a1f64776306d764dc73d25ae Reviewed-on: https://chromium-review.googlesource.com/c/1370394Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#615658}
-
Justin DeWitt authored
This is a one-off solution just for Explore Sites. It does the following: * Changes the job ID for ExploreSitesBackgroundTask 100->101 * Deprecates job ID 100 * Cancels any tasks with job ID 100 when they are executed by JobScheduler * Forces ProGuard to keep the ExploreSitesBackgroundTask class name without obfuscation. Bug: 908476 Change-Id: Ib769e6678a82771a68dec86c04a73621f21fa9e1 Reviewed-on: https://chromium-review.googlesource.com/c/1370318 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#615657}
-
danakj authored
Have ChromeClient go directly to WebWidgetClient instead of through the WebFrameWidget. The WebFrameWidgetImpl would go either to the compositor (which always exists) or to WebWidgetClient. The latter path was dead. Similar in WebViewImpl. Then when ChromeClient (via plumbing..) would ping the compositor, it would callback to RenderWidget to say RequestScheduleAnimation() for single-thread-no-scheduler tests. This would redirect to WebWidgetClient (empty for RenderWidget) in order to pick up test overrides. Instead, ChromeClient goes to WebWidetClient which is RenderWidget (or test overrides). RenderWidget goes to the compositor. Then we don't need the callback from the compositor anymore, so remove it and change tests to watch ScheduleAnimation() as needed directly instead. WebLayerTreeView also has an equivalent of ScheduleAnimation() which would get to the test harness by round-tripping through cc. Instead of re-routing it, remove that API and have callers go through the WebWidgetClient to ScheduleAnimation(). R=dcheng@chromium.org TBR=dcheng for components/ Change-Id: I3c1a5a4c2c6dfc8008067891531b35e5d845b4ba Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1369032 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615656}
-
Rafael Cintron authored
Rendering/point-specific-shader-variables passes on local Windows machine as well as in the lab. Bug: 616335 Change-Id: I417062f16edefe784e2723e45919af1af6080ddb Reviewed-on: https://chromium-review.googlesource.com/c/1370585 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#615655}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/248debf55ad6..a719fc18a57d git log 248debf55ad6..a719fc18a57d --date=short --no-merges --format='%ad %ae %s' 2018-12-11 zoddicus@users.noreply.github.com Disable checking that AtomicStorage capability is present (#2193) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@a719fc18a57d The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I16cf9941ad804f855e242c81bd4e3a614f495f6e Reviewed-on: https://chromium-review.googlesource.com/c/1372468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615654}
-
Guido Urdaneta authored
Notifications from the OS can come on any thread, which may lead to crashes. Bug: 911311 Change-Id: Ibfd71bf572427e17e17d4fcda92690e8960fd571 Reviewed-on: https://chromium-review.googlesource.com/c/1371871 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#615653}
-
Ken Rockot authored
Adds a CHECK to SimpleWatcher's internal thread-safe Context state to investigate possible incorrect cross-thread bindings usage leading to double-free of a SimpleWatcher. This is highly speculative and might not lead anywhere. Bug: 896419 Change-Id: I33c937208152a9d5cc0fdfc7831935e1d3e3bb88 Reviewed-on: https://chromium-review.googlesource.com/c/1372269Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#615652}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f4f8cc56aacf..09163779000e git log f4f8cc56aacf..09163779000e --date=short --no-merges --format='%ad %ae %s' 2018-12-11 tsepez@chromium.org Remove cxfa_node_statics.cpp. Created with: gclient setdep -r src/third_party/pdfium@09163779000e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8c442896c1b9d43e5a6a8ff358b58ff9bc3ab7f6 Reviewed-on: https://chromium-review.googlesource.com/c/1372094Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1ec085624fc7..af97be96b474 git log 1ec085624fc7..af97be96b474 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 lalitm@google.com Merge "trace_processor: create StorageTable base class for all storage backed tables" Created with: gclient setdep -r src/third_party/perfetto@af97be96b474 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4167c3532ea0b4abd5cd7b6490572da26f9ed721 Reviewed-on: https://chromium-review.googlesource.com/c/1372095Reviewed-by:
-
Xianzhu Wang authored
Bug: 909750 Change-Id: I10ff2ec0f58cddfd16c28d47de153ce484a6833c Reviewed-on: https://chromium-review.googlesource.com/c/1370497Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615649}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3bdc3f5f9c0b..12659a46b9d9 git log 3bdc3f5f9c0b..12659a46b9d9 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f5c88e7e1c1a..be607ad63609 (1 commits) 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader afb8cd307bc5..a233ceaecd85 (1 commits) 2018-12-11 mtklein@google.com Try out clang-tidy, starting with bugprone-use-after-move 2018-12-11 reed@google.com Revert "Treat kWEBP encode with quality=100 as lossless" 2018-12-11 caryclark@skia.org bracket SkPath pathRefIsValid with define 2018-12-11 reed@google.com impl intercepts with fonts 2018-12-11 michaelludwig@google.com Consolidate stroke-rect ops and use GrFillRectOp instead of GrNonAA/AARectOp 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 7cfb50cd5f50..afb8cd307bc5 (1 commits) Created with: gclient setdep -r src/third_party/skia@12659a46b9d9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:913930 TBR=ethannicholas@chromium.org Change-Id: Ic3060e64bc1a7dfa8403d17decd7fc3cd341f804 Reviewed-on: https://chromium-review.googlesource.com/c/1372404Reviewed-by:
-
Stephen White authored
The plan is to move the actual test targets in Dawn to Dawn's src/test directory. This change makes Chrome temporarily point at some intermediate proxy targets, so we can move the real ones without breaking Chrome. Bug: dawn:61 Change-Id: I3c57af0dfbcff70b5acec30b69f2c013a7a9eb67 Reviewed-on: https://chromium-review.googlesource.com/c/1372320 Commit-Queue: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#615647}
-
Nektarios Paisios authored
Required by existing browser code which we should remove if we can. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I42312c4a21a80f95dd44179465f9689852fbd41c Reviewed-on: https://chromium-review.googlesource.com/c/1370494Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#615646}
-
Anna Malova authored
Introduce DynamicModuleCoordinator which is instantiated via DI only if Intent has correct dynamic module ComponentName. ActivityDelegate is responsible of notifying dynamic module on ActivityLifecycle events now. Bug: 904826 Change-Id: I2e73cdb296db9aab83031bd4c8bf99457bc8973f Reviewed-on: https://chromium-review.googlesource.com/c/1356961Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#615645}
-
Tomasz Wiszkowski authored
Test: wm density ### Change-Id: Ie8ef554ff8ff8f8f1d1828f6866a0d1868a2ac06 Bug: 871798 Reviewed-on: https://chromium-review.googlesource.com/c/1367872 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#615644}
-
Xianda Sun authored
V2 hit testing (viz hit testing using cc data) only submits regions with non-zero origins when the region is clipped by other layers. However, in these cases, if we offset hit test locations by the "clipped" region's origin, we will get wrong coordinates for the clipped frame. Since regions submitted by draw quad data provider can have the offset factor in the transform, we only disable the offsetting for v2 hit test in this patch. Bug: 908923 Change-Id: Ie501db968b94a831b33e27bc3a41d5f2fbc4e7a6 Reviewed-on: https://chromium-review.googlesource.com/c/1359324Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615643}
-
Luciano Pacheco authored
Users are now allowed to manage folders and files inside MyFiles in ChromeOS, this CL whitelist MyFiles in the same way it already does for Downloads. Bug: 913727, 873539 Change-Id: I828893021c26a99c12fab7509b603e2cf8603510 Reviewed-on: https://chromium-review.googlesource.com/c/1370161Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#615642}
-
Wez authored
These tests are already disabled under OS_WIN, so just add OS_FUCHSIA to the preprocessor condition. Bug: 829650, 913155 Change-Id: I6b323a1918e655d890715ae331fae4e612d5228c Reviewed-on: https://chromium-review.googlesource.com/c/1372323Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#615641}
-
Xi Han authored
Foces ServiceManager to register NetworkService as a in process service when running in the ServiceManager only mode. Bug: 846846 Change-Id: I9693bbcb3d0379fc293b2277d5dd513a03d3fe8c Reviewed-on: https://chromium-review.googlesource.com/c/1368455Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615640}
-
David Lu authored
Bug: 896461 Change-Id: I71075988265e989748673b511248db3be8e7806e Reviewed-on: https://chromium-review.googlesource.com/c/1366820Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/74c92bb22076..8435aca79e4d git log 74c92bb22076..8435aca79e4d --date=short --no-merges --format='%ad %ae %s' 2018-12-11 bsheedy@chromium.org [tracing] Check for both type and value presence Created with: gclient setdep -r src/third_party/catapult@8435aca79e4d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:906685 TBR=sullivan@chromium.org Change-Id: I6ba0a6ae9eae9106da018dd8e836d9016177952e Reviewed-on: https://chromium-review.googlesource.com/c/1372405Reviewed-by:
-
bsheedy authored
Adds support for the automated post-failure screenshots in instrumentation tests on Vega standalone headsets. The regular way of taking screenshots (equivalent to the power button + volume down approach) doesn't work on Vega, as it just captures a black screen with the VR overlay. Instead, use VrCore's RecorderService to take a screenshot on Vega. Bug: 913077 Change-Id: I0ddde9c32ba942f925d666aa5c30c598ce97c0a3 Reviewed-on: https://chromium-review.googlesource.com/c/1368694Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#615637}
-
Scott Violet authored
If an EventRewriter discards the event, callbacks should be run immediately. Without this, the callback never gets run. BUG=898658 TEST=covered by tests Change-Id: Ia2644890750fe328506d4fce3f575f327c06cd1f Reviewed-on: https://chromium-review.googlesource.com/c/1371216 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#615636}
-
Kai Ninomiya authored
Bug: 912842 Change-Id: I847e62edc50ccdf8d488843a8c4b7d04fd77b0c2 Reviewed-on: https://chromium-review.googlesource.com/c/1370499Reviewed-by:
-
Robert Sesek authored
The MachPortRelay and MachPortBroker were not set up in all the circumstances in which they were required. This also changes the base::MachPortBroker to log more descriptive failure messages. Change-Id: Id711b7a30acb31c2c3366d31f4d0b0bfb1a2815d Reviewed-on: https://chromium-review.googlesource.com/c/1371932Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#615634}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7025535b4bb4..ad858d1231e7 git log 7025535b4bb4..ad858d1231e7 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 kwiberg@webrtc.org Improve the audio codec factory documentation. 2018-12-11 crodbro@webrtc.org Reduce pacing buffer padding rate during pushback. Created with: gclient setdep -r src/third_party/webrtc@ad858d1231e7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I09983c8bcc97549c43937c9d4df44f50d70861a7 Reviewed-on: https://chromium-review.googlesource.com/c/1372092Reviewed-by:
-
Gabriel Marin authored
Add ProfileProvider to manage multiple metric collectors and register with the various Chromium triggers. Both the implementation and tests are mostly new. Added rules to compile the class and the associated unit tests, but the code will not be used in prod until a later CL that adds a perf events collector to replace PerfProvider. BUG=b:116527691 TEST=Unit tests pass Change-Id: Iac745beb5f80ccfb675de581e8ccb5b7304f6114 Reviewed-on: https://chromium-review.googlesource.com/c/1357639 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#615632}
-
Yannis Guyon authored
In target libwebp_advanced_api_fuzzer, restrict config.output.colorspace to MODE_RGBA, MODE_BGRA, MODE_rgbA and MODE_bgrA, the only supported modes when WEBP_REDUCE_CSP is defined, which is the case in chromium. BUG=chromium:912628 Change-Id: I5f08fc85ece0a4a5a4d402d3fc7c77f794404b1c Reviewed-on: https://chromium-review.googlesource.com/c/1368126Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Yannis Guyon <yguyon@google.com> Cr-Commit-Position: refs/heads/master@{#615631}
-
rbpotter authored
Fixing text being cut off in the "Options" section of Print Preview, if words exceed the allocated width. Also fixing "Change..." button text wrapping onto two lines rather than expanding the button horizontally, when text is very large. Bug: 909661 Change-Id: I9e9f62c8a7a23bbdb264f3ce8a1a49d77c75cdcd Reviewed-on: https://chromium-review.googlesource.com/c/1369034Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#615630}
-
Sidney San Martín authored
Bug: 893821 Change-Id: Ic2ff92577d35250fbe773ff6b80918da33d57155 Reviewed-on: https://chromium-review.googlesource.com/c/1365955Reviewed-by:
-
Ben Pastene authored
It's hard-coded to test-cmdline-file, and some tests appear to have their own location R=jbudorick Bug: 907899 Change-Id: I515bd8d2ff3d91a2f665754708bda94f6c0c19c4 Reviewed-on: https://chromium-review.googlesource.com/c/1357609Reviewed-by:
-
George Burgess IV authored
- Remove shenhan and yunlian (they're no longer on the team that maintains this, and there are now people on the team with sufficient context) - Add gbiv and manoj (two of said people ;) ) Bug: None Change-Id: I6dc1f65b9a0ab84818175a01396ed83a78a732f9 Reviewed-on: https://chromium-review.googlesource.com/c/1372273Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#615627}
-
Sergey Ulanov authored
Skia now contains SkFontMgr implementation for Fuchsia. Updated SkFontMgr::Factory() to use it and removed the old implementation from //skia/ext. The new implementation adds some features that were previously missing, particularly font collection and character matching. Bug: 900395 Change-Id: I545bb33b20d34e3ab02b04f6a1b705e5420d65d7 Reviewed-on: https://chromium-review.googlesource.com/c/1370500Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Yannis Guyon authored
WEBP_REDUCE_SIZE is defined in chromium, disabling WebPPictureCopy(), making WebPAnimEncoderNew() unavailable. Remove the fuzz target libwebp_anim_encoder_fuzzer because AnimEncoder is not used within chromium. Keep the file fuzz_webp_animencoder to run on oss-fuzz. BUG=chromium:912506 Change-Id: I9a981aca6b585896844428d6eb330707209496e5 Reviewed-on: https://chromium-review.googlesource.com/c/1368109Reviewed-by:
-
Lei Zhang authored
- PrintRenderFrameHelperTest.WindowPrintBeforePrintAfterPrint covers the regression in bug 912966 without Print Preview. - PrintRenderFrameHelperPreviewTest.WindowPrintBeforePrintAfterPrint covers the regression in bug 912966 with Print Preview. - PrintRenderFrameHelperPreviewTest.BasicBeforePrintAfterPrint is the equivalent to PrintRenderFrameHelperTest.BasicBeforePrintAfterPrint, but for Print Preview. - Merge common code to avoid repeats. BUG=912966 Change-Id: I80b0ef718e4f06e2e1bd858bd1c2a39028d4a6ec Reviewed-on: https://chromium-review.googlesource.com/c/1371211 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#615624}
-
Esmael El-Moslimany authored
Making cr-slider tabindex=0 when enabled so it can be focused using |slider.focus()|. When a control is selected in the image editor, the first control in the group is given focus (for example when clicking on the brightness/contrast button, the brightness slider should have focus. Added css variables to allow for a different color scheme for image editor sliders. Bug: 902873 Change-Id: I4cf9c5082f81c9a8b50529c4e7f59537c4e4cfa6 Reviewed-on: https://chromium-review.googlesource.com/c/1357652Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#615623}
-
gogerald authored
This CL depends on https://chromium-review.googlesource.com/c/chromium/src/+/1366696 Bug: 806868 Change-Id: I9b7093418ebf7d270a333deca572deea59166681 Reviewed-on: https://chromium-review.googlesource.com/c/1359552 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#615622}
-
Lei Zhang authored
- Deduplicate ClickMouseButton() code. - Add an accessor to print_render_thread(). - Mark function level constants as static. - Use std::make_unique() and default ctor/dtors. Change-Id: I545d69935324b9e8b7943132dc90f2c1334b9025 Reviewed-on: https://chromium-review.googlesource.com/c/1370468Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615621}
-
bsheedy authored
Regular roll to most current release version. TBR=vollick@chromium.org Change-Id: Ibeb523d0e0ecc80914e4e8e88ad3d01b52a03a05 Reviewed-on: https://chromium-review.googlesource.com/c/1371942Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#615620}
-
