- 16 Nov, 2018 29 commits
-
-
Eric Stevenson authored
This is part of a better scheme for calling Java->Native where all native methods are hidden behind interfaces, and exist within a single "GEN_JNI.java" generated file. See bug for more details. Bug: 898261 Change-Id: I1fd7a9f162cb2853a2dfcd62ffcdebe909cb40e1 Reviewed-on: https://chromium-review.googlesource.com/c/1315808 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#608614}
-
Chase Phillips authored
These metrics were added here: https://crrev.com/470373002 From a review of whether we use this today, these are no longer used/needed. Bug: 717812, 397552, 395799 Change-Id: I1b296832a7ed87fb9653be9eb83cc2b3eb8ef6b1 Reviewed-on: https://chromium-review.googlesource.com/c/1336429 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#608613}
-
Victor Costan authored
The new release changes how ALTER TABLE RENAME is implemented, and requires an update to WebSQL's SQLite authorizer. This CL includes the update, and extends the LayoutTest for the authorizer to cover the newly implemented column renaming functionality. An upgrade to SQLite 3.25.2 was previously landed as https://crrev.com/c/1266881 and reverted due to the crashes documented in https://crbug.com/897576. The 3.25.3 upgrade may fix the crash cause. This CL removes the patch that was previously known as 0007-fts3-Interior-node-corruption-detection.patch because 3.25.3 now includes an equivalent check. Bug: 892852 Change-Id: I3a129ddc8f72be29edf462ffec105d71cba559f6 Reviewed-on: https://chromium-review.googlesource.com/c/1319035 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#608612}
-
Jay Harris authored
Bug: 902280 Change-Id: I53e8152e1208a31bd4551c56da47489db92864af Reviewed-on: https://chromium-review.googlesource.com/c/1329707 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#608611}
-
Gabriel Charette authored
post_task.h is now preferred to creating special purposed base::Threads All this code needs is a SequencedTaskRunner which is allowed to perform file I/O. Furthermore, PlatformThread::Join() and hence Thread::Stop() will be marked as a blocking operation in https://chromium-review.googlesource.com/c/chromium/src/+/1324370 and this code was preventing that (even though in this case the Join() was mostly a fast operation as there were no tasks left by the time it was invoked). R=chiniforooshan@chromium.org Bug: 707362 Change-Id: Iec2f823e762cea2d1d1e775117fd95d871baa574 Reviewed-on: https://chromium-review.googlesource.com/c/1338178Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#608610}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2791be403817..1a5e3e8c2a99 git log 2791be403817..1a5e3e8c2a99 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 halcanary@google.com DEPS: update Harfbuzz to 2.1.1 Created with: gclient setdep -r src/third_party/skia@1a5e3e8c2a99 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I7dd10d010a4ea6fe605edd619b7de3fa430c5ea2 Reviewed-on: https://chromium-review.googlesource.com/c/1338397Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608609}
-
Wenzhao Zang authored
The screenshot can be found at https://drive.google.com/file/d/1zMTMCNiJQXcLzeL_sfZaWNMS-OJ5n7SM/view?usp=sharing Also include the hash in the CL. Bug: 877749 Change-Id: Ibf118e2c20f158cf2fd2c2cef955c9d04c205b86 Reviewed-on: https://chromium-review.googlesource.com/c/1333830Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#608608}
-
Kenneth Russell authored
Needed to be rerun after recent changes. Bug: 890539, 905459, 905889 Change-Id: I6258f331d0d2be44d000e792c5e2a571342bec26 Reviewed-on: https://chromium-review.googlesource.com/c/1338724Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608607}
-
Ella Ge authored
TBR=chrishtr@chromium.org Bug: 905860, 900602 Change-Id: I5d2a01010b4424ffa4312dfaf01e3ca0af24d182 Reviewed-on: https://chromium-review.googlesource.com/c/1338570Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608606}
-
Robert Kroeger authored
The canvas-teximage-after-multiple-drawimages.html webgl test is flaky on MacOS and Android qualcomm. Add test suppression. BUG=905682 TBR=kbr@chromium.org Change-Id: Id8fdb70f6dae6383c6d734916a3a724adbe00ea3 Reviewed-on: https://chromium-review.googlesource.com/c/1338560Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#608605}
-
Kenneth Russell authored
The test's JavaScript execution races with document parsing. Mark flaky until the test is fixed and rolled forward. Bug: 905682 Change-Id: I6602bd31bc7ad60ce848571126eaa47be34a804c Tbr: rjkroege@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1338619Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608604}
-
Scott Chen authored
Bug: 905503 Change-Id: Ic886e1b5946ffdbca69d5cb33f573d79437b84ae Reviewed-on: https://chromium-review.googlesource.com/c/1336752 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#608603}
-
Yutaka Hirano authored
Bug: 672740 Change-Id: I2246a0d840f8d62cfb1026d53195c78cd12f27d9 Reviewed-on: https://chromium-review.googlesource.com/c/1337223 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#608602}
-
Avi Drissman authored
They return ownership via raw pointer, and they're unneeded. Also remove AsUIImage as it has no callers. BUG=904645 Change-Id: I18497ae1e32ad36ec78cdcf3c5df07d0faf8af39 Reviewed-on: https://chromium-review.googlesource.com/c/1333876 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#608601}
-
Antonio Gomes authored
IdentityManager API provides a replacement to objects including SigninManager and PO2TS. Since its implementation wraps both objects, no functionality change is expected. Note: This CL can not eliminate the uses of PO2TS completely from ArcAndroidManagementChecker because it is still needed for creating another object, AndroidManagementClient. This object will be migrated on its own CL. BUG=905279 Change-Id: I57096d6ff829afdfb3f4d882e390b87e9391ab12 Reviewed-on: https://chromium-review.googlesource.com/c/1335908 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#608600}
-
John Abd-El-Malek authored
This is another regression from r579953. The problem is that NetworkDelegate::OnBeforeURLRequest is called on the initial request and every redirect, while URLLoaderThrottle::WillStartRequest is only called on the original request and not redirects. This cl doesn't fix the network service path, as we don't have a way to change the URL in a throttle on a redirect. It's meant to be as minimal to merge. Follow-up cls will add a test and fix this for network service path. Bug: 899268 Change-Id: I1948ee74a57e6a36cfda165abd924900b4b8b1c4 Reviewed-on: https://chromium-review.googlesource.com/c/1338567Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#608599}
-
Kent Tamura authored
Bug: 622551, 829697 Change-Id: I38cf0ac24b1d22c27feec6117cc44f909f50d006 Reviewed-on: https://chromium-review.googlesource.com/c/1337228Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#608598}
-
Chase Phillips authored
This is a reland of a CL that landed here: https://crrev.com/c/1303634 The CL was reverted here: https://crrev.com/c/1337609 The revert was due to a failure in the Deterministic Linux build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux/17798 That build failed because the Blink modules bindings targets were missing the IndexedDB Blink variant mojom headers files dependencies. This reland includes a fix for that issue. Here's the original commit message, which is still valid: The following structs were redundant with structs that Mojo auto-generates: - WebIDBCursorDirection - WebIDBDataLoss - WebIDBOperationType - WebIDBPutMode - WebIDBTaskType - WebIDBTransactionMode This CL updates those references to refer to the equivalent blink::mojom:: type, instead. References to kWebIDB* values are updated to point to the equivalent value in the associated Mojo enum type. Bug: 717812 Change-Id: Ic076c67a9a0292fc23cc23667fdd68892e5b0ef9 Reviewed-on: https://chromium-review.googlesource.com/c/1338379Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#608597}
-
Sunny Sachanandani authored
This is a reland of 1dfd4418 Original change's description: > Fix video quad rect and surface output rect > > Video surface output rect didn't take rotation into account so when > SurfaceAggregator would stretch content to fill bounds, it would end up > with the wrong scaling factors (squash in one dimension and expand in > another) since the surface quad's bounds (in the embedder) were rotated. > > To work around this (or by accident), VideoFrameResourceProvider was > passing the rotated size as the quad's rect which doesn't make sense > intuitively. This also worked by accident with DirectComposition > overlays because of applying another scaling which would fix the aspect > ratio again. > > This change makes it possible to use the |quad_to_target_transform| as > is, without having to apply an aspect ratio correcting scaling, and to > assume that the quad's rect is in the pre-transform space. > > Bug: 904035 > Change-Id: Ia55e44f1f2b49b8d368a97af54f3ce9d90a81234 > Reviewed-on: https://chromium-review.googlesource.com/c/1334971 > Reviewed-by: enne <enne@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608495} TBR=enne@chromium.org,kbr@chromium.org,liberato@chromium.org Bug: 904035 Change-Id: I278a0ea2c5507f01ea13b31d2090b5f99537c7c3 Reviewed-on: https://chromium-review.googlesource.com/c/1338418Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#608596}
-
Jesse McKenna authored
TaskScheduler: Clear PriorityQueue during SchedulerWorkerDelegate:: and SchedulerSingleThreadTaskRunnerManager::JoinForTesting Bug: 889029 Change-Id: I543909faf8b66abf9a3866bc5aea8cc89277c8bb Reviewed-on: https://chromium-review.googlesource.com/c/1338140 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#608595}
-
Mike Frysinger authored
This array has been alphabetically sorted except for the android2grd tool. Move that up to the first entry. Change-Id: I652dc13cbfb7cee7af14f64c17539388bdc606c9 Reviewed-on: https://chromium-review.googlesource.com/c/1338465Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#608594}
-
John Z Wu authored
CWVAutofillControllerDelegate can be notified of forms found on the page via a new delegate method. This can be used to better understand the forms on the page and measure the success of the feature. Bug: 905546 Change-Id: Ie9798387c678d6aac0ca10516331f7b1e6b8a5a1 Reviewed-on: https://chromium-review.googlesource.com/c/1337290Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#608593}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ec3b48cc9484..859e6809332f Created with: gclient setdep -r src-internal@859e6809332f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic6b569fa4c379b50507345477ac33331ec582c80 Reviewed-on: https://chromium-review.googlesource.com/c/1338539Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608592}
-
Yao Xiao authored
Also skip recording HTMLAnchorElementDownload UseCounter if it ends up navigating. In that case, NavigationDownload UseCounter will be recorded. Bug:539938 Change-Id: I0908d7f98650e8601dd95ba9e52233bb4d1f7a48 Reviewed-on: https://chromium-review.googlesource.com/c/1318170 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#608591}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a4b02559. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ic34dc28718638a07b48530c99c0b198e0ffe291e Reviewed-on: https://chromium-review.googlesource.com/c/1338336 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608590}
-
Kurt Horimoto authored
This will allow UIViewControllers presented on the BCVC to be presented non-modally, leaving the browser controls in the toolbars unaffected. Bug: 674649 Change-Id: Ib1c256965c4821074c544f5a87792203e2648208 Reviewed-on: https://chromium-review.googlesource.com/c/1334554 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#608589}
-
btolsch authored
According to the current fuzzer coverage report, there is currently no coverage of transport_parameters.cc. There is also an existing TODO for fuzzing this function. Bug: 900484 Change-Id: If62481651506a3143148f5302b709509e1bea7ea Reviewed-on: https://chromium-review.googlesource.com/c/1337523Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#608588}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9ba32715116d..66a44ccac54e git log 9ba32715116d..66a44ccac54e --date=short --no-merges --format='%ad %ae %s' 2018-11-15 fmayer@google.com Merge "profiling: Allow to profile all running processes." Created with: gclient setdep -r src/third_party/perfetto@66a44ccac54e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I5d172c86aa9b6a498f5660114a71c73f6fdf01c3 Reviewed-on: https://chromium-review.googlesource.com/c/1338395Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608587}
-
Simon Que authored
The bots occasionally reach 100% usage but most of the time are far below 100%. https://screenshot.googleplex.com/63y7ueSWyay.png We can increase to 20% and see the effect. BUG=855319 Change-Id: I0c2c234d8ef04dc29afce514a39f26856ab20fe2 Reviewed-on: https://chromium-review.googlesource.com/c/1337219Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
smut <smut@google.com> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#608586}
-
- 15 Nov, 2018 11 commits
-
-
Chase Phillips authored
This CL fixes building the following files directly: - obj/third_party/blink/renderer/bindings/modules/generated/event_modules_factory.o - obj/third_party/blink/renderer/bindings/modules/v8/bindings_modules_impl/v8_window_partial.o Marijn Kruisselbrink <mek@chromium.org> did the first version of this change over IM. Bug: 717812 Change-Id: I858af8d3be21aad31e6f00b4dcbfd3c3fd6ac010 Reviewed-on: https://chromium-review.googlesource.com/c/1338201 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#608585}
-
Abhishek Arya authored
Also, rename snappy_fuzzer to snappy_uncompress_fuzzer. R=mmoroz@chromium.org,pwnall@chromium.org Bug: 900481 Change-Id: I83fa8be129f34dc2cbed4a21492139cea32c2044 Reviewed-on: https://chromium-review.googlesource.com/c/1337811 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608584}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0462948c9cb9..302134240b5d git log 0462948c9cb9..302134240b5d --date=short --no-merges --format='%ad %ae %s' 2018-11-15 jeroendb@webrtc.org Adding more owners to p2p 2018-11-15 Peter) Slatala Pass the media transport from JsepTransportController to Call. 2018-11-15 sprang@webrtc.org Update FakeVp8Encoder to use GetEncoderInfo 2018-11-15 Peter) Slatala MediaTransportTests should use audio-only peer connection. Created with: gclient setdep -r src/third_party/webrtc@302134240b5d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I71718b7892e9f68bcc7770d72d3c936d3b1d126f Reviewed-on: https://chromium-review.googlesource.com/c/1338154Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608583}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2aa7e8cbc413..59f7623f1c0b git log 2aa7e8cbc413..59f7623f1c0b --date=short --no-merges --format='%ad %ae %s' 2018-11-15 thestig@chromium.org Avoid overloading in IFX_SeekableWriteStream. 2018-11-15 thestig@chromium.org Avoid overloading in IFX_SeekableReadStream. 2018-11-15 thestig@chromium.org Remove IFX_SeekableStream::Flush(). Created with: gclient setdep -r src/third_party/pdfium@59f7623f1c0b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0708999108aa7e7d2fc7f52526717333d082091e Reviewed-on: https://chromium-review.googlesource.com/c/1338150Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608582}
-
Steve Anton authored
RTCQuicStream needs to know if it is being closed by ContextDestroyed (which is only known from RTCIceTransport) to avoid rejected promises. Adding a CloseReason additionally moves all closing code to one method which makes it easier to reason about. Bug: 874296 Tbr: hbos@chromium.org Change-Id: I58afc7b56412c836b8d178868297c4fbf76320c1 Reviewed-on: https://chromium-review.googlesource.com/c/1334935 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#608581}
-
danakj authored
As pointed out in https://crrev.com/c/1336218 it's easy to miss the Start/Stop Compositor when changing the RenderWidget's swapped out state, and it looks like they are separate when not done with a single method call. For safety and clarity, move them into SetSwappedOut. R=piman@chromium.org Change-Id: Ic45d5d911255886835e283a5777a3923f63e1830 Bug: 896836 Reviewed-on: https://chromium-review.googlesource.com/c/1338492Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#608580}
-
Jonathan Backer authored
These resources are mostly scratch space. As per crbug.com/899940: - most of this is scratch space textures for intermediate results cached to avoid GPU memory churn - with the UI using OOP-R we don't go idle as often (e.g. cursor blink, throbber) - 15 seconds is a long time to keep it around (many of our regression tests don't run this long) Bug: 899940 Change-Id: Idc077c98551978afa97b18be3dd61784f8898806 Reviewed-on: https://chromium-review.googlesource.com/c/1320790Reviewed-by:
Brian Salomon <bsalomon@google.com> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#608579}
-
Eric Stevenson authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1332607, I added support for listing tests when multidex is enabled on KitKat and introduced a bug where we always use our custom TestRequestBuilder. Bug: 905230 Change-Id: Id0eb9f9b094fc9243a2baf68fe3647bcebf2075d Reviewed-on: https://chromium-review.googlesource.com/c/1338326Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#608578}
-
Patrick Monette authored
Change-Id: I5e0c0bb4da22fb851b9869e89fcd540ec4d4e6a5 Reviewed-on: https://chromium-review.googlesource.com/c/1313390 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#608577}
-
Ella Ge authored
TBR=szager@chromium.org Bug: 905827 Change-Id: I26b5110665125ff09a44deb33004966652db84c0 Reviewed-on: https://chromium-review.googlesource.com/c/1338125Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608576}
-
Pavel Feldman authored
This is an experimental feature that allows trusted remote debugging clients such as Carlo adjust the dock tile details. Change-Id: I7b263a14f1632d867c8bd3cffdd0527b3f3c96c9 Reviewed-on: https://chromium-review.googlesource.com/c/1337295 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608575}
-