GitLab

R=tsergeant@chromium.org
BUG=647028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2386533002
Cr-Commit-Position: refs/heads/master@{#422653}

The window manager should be doing it. To do otherwise means mus is
likely conflicting with the wm. Additionally changing the activation
as we were meant clients weren't getting notified and got out of sync
with mus.

BUG=652421
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2391853002
Cr-Commit-Position: refs/heads/master@{#422652}

When spoken-feedback is enabled, shell_surface's shadow_underlay will
fill the screen for active android windows. When in this mode, the
underlay will consume all events and play an earcon to indicate that
the event was located outside the android window.

BUG=649524
TEST=unit-test and tested on device

Review-Url: https://codereview.chromium.org/2361993003
Cr-Commit-Position: refs/heads/master@{#422651}

The performance timing spec has been clarified[1] to make getEntriesByType
case sensitive. This CL updates Blink to this new requirement.

[1] https://github.com/w3c/performance-timeline/issues/57

BUG=651507

Review-Url: https://codereview.chromium.org/2390733003
Cr-Commit-Position: refs/heads/master@{#422650}

This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier.

BUG=623989

Review-Url: https://codereview.chromium.org/2364233003
Cr-Commit-Position: refs/heads/master@{#422649}

This CL has no behavior changes.

BUG=563793

Review-Url: https://codereview.chromium.org/2386213002
Cr-Commit-Position: refs/heads/master@{#422648}

On WebVR pages loaded over insecure transport, show a small "Not secure"
warning overlay permanently, and a transient more verbose warning for
a short time on first entering the page.

It uses the information from bajones's "Expose secure origin state to
WebVR renderer" implementation.

The message strings were previously added to chrome/app/generated_resources.grd in https://codereview.chromium.org/2368443002/

BUG=389343,644492
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2363553003
Cr-Commit-Position: refs/heads/master@{#422647}

It wouldn't make much sense to have 'V8' prefix since V8 specific
conversions are encapsulated in the generated code.

BUG=569301

Review-Url: https://codereview.chromium.org/2383613003
Cr-Commit-Position: refs/heads/master@{#422646}

Review-Url: https://codereview.chromium.org/2391813002
Cr-Commit-Position: refs/heads/master@{#422645}

Context: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xGUEAYEB9dc

BUG=563793

Review-Url: https://codereview.chromium.org/2386203002
Cr-Commit-Position: refs/heads/master@{#422644}

Revert of VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1 (patchset #1 id:20001 of https://codereview.chromium.org/2384843002/ )

Reason for revert:
Ouch! Messages are called Stop, etc
but the mojom calls them StopCapture !
==> the new messages are not being
called :(
Reverting to reland soon.

Original issue's description:
> VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1
>
> This CL migrates the easy-to-migrate video_capture_messages from
> IPC to mojom. "Easy" refers to those messages whose data types are
> readily available.
>
> BUG=651897
> TEST=./out/gn/content_unittests --gtest_filter=*VideoCapture*,
> content_browsertests and video capture working as before.
>
> Committed: https://crrev.com/a2fc9a109f9280ca953e18a5f82c253ded6ddc26
> Cr-Commit-Position: refs/heads/master@{#422534}

TBR=rockot@chromium.org,tibell@chromium.org,chfremer@chromium.org,tsepez@chromium.org,avi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651897

Review-Url: https://codereview.chromium.org/2393483002
Cr-Commit-Position: refs/heads/master@{#422643}

relnote: change ExtractContentLengthFromHeaders to return false if content-length is missing. If the caller is tolerate to have content-length header missing, it should call ExtractContentLengthFromHeaders only when content-length header is present.

Merge internal change: 135027159

BUG=

Review-Url: https://codereview.chromium.org/2385323004
Cr-Commit-Position: refs/heads/master@{#422642}

We will eventually support detecting printers using mDNS and autodetect
USB devices.  This will take a little while to implement.  Providing a
fake in the meantime since the system is behind a flag.  The fake may be
useful for some tests in the future.

BUG=631352

Review-Url: https://codereview.chromium.org/2344393002
Cr-Commit-Position: refs/heads/master@{#422641}

BUG=649837

Review-Url: https://codereview.chromium.org/2384783003
Cr-Commit-Position: refs/heads/master@{#422640}

Return VisualVewport bounds in screen coordinates (DIP) in GpuBenchmarking::VisualViewportXXX method

because telemetry uses it to generate events that are in screen coordinates.

BUG=599656
TEST=run smoothness.top_25_smooth test locally and passed.

Review-Url: https://codereview.chromium.org/2373253004
Cr-Commit-Position: refs/heads/master@{#422639}

No more --gc-sections in debug mode for test targets either.

Re-enable instrumentation of globals in ASAN builds.

This is effectively a reland of r387491.

BUG=159801, 159847

Review-Url: https://codereview.chromium.org/2384953003
Cr-Commit-Position: refs/heads/master@{#422638}

Context: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xGUEAYEB9dc

This CL covers:

- third_party/WebKit/Source/modules/geolocation/
- third_party/WebKit/Source/modules/imagecapture/
- third_party/WebKit/Source/modules/mediacapturefromelement/
- third_party/WebKit/Source/modules/mediarecorder/

BUG=563793

Review-Url: https://codereview.chromium.org/2389843002
Cr-Commit-Position: refs/heads/master@{#422637}

BUG=

Review-Url: https://codereview.chromium.org/2386323002
Cr-Commit-Position: refs/heads/master@{#422636}

Instead of adding another map, I introduced AppWindowInfo which stores information about the arc windows w/o actual window.

Technically, we can move more from AppWindow, but we
can revisit it later if we want.

BUG=31836336
TEST=ChromeLauncherControllerOrientationTest.ArcOrientationLockBeforeWindowReady

Review-Url: https://codereview.chromium.org/2384773002
Cr-Commit-Position: refs/heads/master@{#422635}

BUG=642911

Review-Url: https://codereview.chromium.org/2302623002
Cr-Commit-Position: refs/heads/master@{#422634}

This CL has no behavior changes.

BUG=563793

Review-Url: https://codereview.chromium.org/2388193002
Cr-Commit-Position: refs/heads/master@{#422633}

Permissions are parsed in //extensions. Moving the manifset key to the
//extensions _manifest_features.json file would prevent app_shell from
warning about an unknown "permissions" key (if app_shell warnings were
printed).

BUG=652006
R=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2391763003
Cr-Commit-Position: refs/heads/master@{#422632}

Text::textLayoutObjectIsNeeded is an optimization which avoids
creating layout objects for whitespace text nodes. However
LayoutTreeBuilderTraversal::nextSiblingLayoutObject traverses all
siblings. For long lists of N space-separated siblings, this
degenerates into an N^2 DOM walk. Oops.

Text::textLayoutObjectIsNeeded already has a sibling limit; this
passes the limit through to
prevSiblingLayoutObject/nextSiblingLayoutObject.

BUG=650938

Review-Url: https://codereview.chromium.org/2379483002
Cr-Commit-Position: refs/heads/master@{#422631}

Currently we are writing out only chartjson results when a disabled
test is run but we still check for json results.

BUG=chromium:647714

Review-Url: https://codereview.chromium.org/2385183002
Cr-Commit-Position: refs/heads/master@{#422630}

For now mark all fast/block/basic tests with "Failure". This will be changed once
crrev.com/2389823003 is submitted.

BUG=635619

Review-Url: https://codereview.chromium.org/2392703002
Cr-Commit-Position: refs/heads/master@{#422629}

This CL fixes a vector indexing bug in SerializationUtilsTest.WriteReadTest
where the code was supposed to ensure that each MetricSample entry in the
vector returned by SerializationUtils::ReadAndTruncateMetricsFromFile is not
null, instead of just the first entry.

BUG=None
TEST=component_unittests

Review-Url: https://codereview.chromium.org/2388853002
Cr-Commit-Position: refs/heads/master@{#422628}

https://chromium.googlesource.com/skia.git/+log/7de577983581..2ebd0c80a2a9

$ git log 7de577983..2ebd0c80a --date=short --no-merges --format='%ad %ae %s'
2016-10-03 bsalomon Remove option to make GrCoordTransforms apply to device positions.
2016-10-03 reed Revert "Revert "Revert "replace SkXfermode obj with SkBlendMode enum in paints"""
2016-10-03 reed Revert of add cast for tostring (patchset #1 id:1 of https://codereview.chromium.org/2385353002/ )
2016-10-03 reed add cast for tostring to fix google3
2016-10-03 bsalomon Make GrResourceCache dynamically change between LRU and random replacement strategies.
2016-10-03 liyuqian Add GMs for Analytic Anti-Aliasing
2016-10-03 fmalita Avoid unneeded paint copies in SkDraw::drawBitmap
2016-10-03 egdaniel Remove unused resolve parameters for vulkan render passes
2016-10-03 brianosman Supply random dst color space to asFP in unit tests
2016-10-03 reed Revert "Revert "replace SkXfermode obj with SkBlendMode enum in paints""
2016-10-03 mtklein Just add the F16 bench from https://skia-review.googlesource.com/c/2860/
2016-10-03 bsalomon Move clip CTM application to SkRasterClip and SkClipStack
2016-10-03 kjlubick Add fuzz executable to GN
2016-10-03 brianosman Start supplying random color space xforms to FP tests

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=stephana@google.com

Review-Url: https://codereview.chromium.org/2387133003
Cr-Commit-Position: refs/heads/master@{#422627}

This patch unifies the two property tree state classes so just
PropertyTreeState is used. The majority of this patch is a mechanical
refactor.

There are three real changes in this patch:
1) GeometryPropertyTreeState has been replaced by PropertyTreeState.
2) Comments in ObjectPaintProperties.h have been updated.
3) ObjectPaintProperties's localBorderBoxProperties and
   contentsProperties have been refactored to both return a
   PropertyTreeStateWithOffset. This was needed because
   PropertyTreeState does not permit the reference out-param approach
   that was previously used for getContentsPropertyTreeState.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2390443002
Cr-Commit-Position: refs/heads/master@{#422626}

Imports in <body> cause undefined behavior: crbug.com/638074

We have a bunch of hacks to try to avoid doing things with an invalid DOM.
Instead of these hacks, sidestep the problem by moving the i18n import to
<head> (yeah, this probably breaks i18n-foo in <body>).

The code is less haphazard now, but still a minefield because:
* Basic and Advanced attempt to control the scroller simultaneously
* settings-main updates the overscroll with no regard for section transitions
* settings-main eagerly removes overscroll on "scroll" events, but can't
  differentiate between user scrolls and Basic/Advanced-initiated scrolls

BUG=637508,537359,589681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2259163002
Cr-Commit-Position: refs/heads/master@{#422625}

* Force the Custom Tab Intent to use the same package as Chrome
  when opening the media viewer.

* Open media downloads inside of the internal media viewer when
  opening the file in the notification or via the snackbar.

* Shuffle code around for creating media viewer Intents in the
  hopes of consolidating them in places that makes sense.

BUG=650448

Review-Url: https://codereview.chromium.org/2376893006
Cr-Commit-Position: refs/heads/master@{#422624}

Recently we see some changes in the pipeline start success rate.
However, we can only get this statistics indirectly through some other
UMAs. This CL adds a UMA directly for this.

Note that if the media pipeline is destroyed during the starting
process, this UMA will NOT be reported. This should be relatively rare.
Also, in this case, the result won't affect user experience anyways.

TEST=Manually tested to make sure the metric is reported.

Review-Url: https://codereview.chromium.org/2383493004
Cr-Commit-Position: refs/heads/master@{#422623}

We need to use last arrived script for ResourceScriptFile.
Otherwise _isDiverged check will always return true in case of:
eval("source1 //# sourceURL=foo.js")
eval("source2 //# sourceURL=foo.js")

BUG=617450,623150
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2384953002
Cr-Commit-Position: refs/heads/master@{#422622}

In cases of out-of-process iframes, RetargetingDetails doesn't currently
contain enough information to find the correct RenderFrameHost.
This CL adds the RenderProcessHost id in the RetargetingDetails struct
to allow consumers of it to correctly discover RenderFrameHost that
created the new WebContents.

BUG=649855

Review-Url: https://codereview.chromium.org/2385363002
Cr-Commit-Position: refs/heads/master@{#422621}

StringValue already accepts StringPiece as constructor.

Get/SetWithoutPathExpansion readily takes StringPiece, so don't
covert StringPiece -> std::string then back to StringPiece for these.

Searching token can be done within StringPieces, without needing
to create temporary strings.

BUG=None
Test=None, internal change.

Review-Url: https://codereview.chromium.org/2383013004
Cr-Commit-Position: refs/heads/master@{#422620}

R=vmpstr@chromium.org
BUG=646032
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2385253002
Cr-Commit-Position: refs/heads/master@{#422619}

BUG=563793

Review-Url: https://codereview.chromium.org/2388303002
Cr-Commit-Position: refs/heads/master@{#422618}

BUG=563793

Review-Url: https://codereview.chromium.org/2385213003
Cr-Commit-Position: refs/heads/master@{#422617}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/bd5814787caa..2363045762a7

$ git log bd5814787..236304576 --date=short --no-merges --format='%ad %ae %s'
2016-10-03 alexandermont Use enums for the InitiatorTitles in IRs instead of strings.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2388653003
Cr-Commit-Position: refs/heads/master@{#422616}

Adds OnChildWindowVisibilityChanged to ui::WindowObserver as well as making all visible functions take the 'visible' to match usage of aura.

OnChildWindowVisibilityChanged() is unfortunate given
OnWindowVisibilityChanged() is also sent, but it's the only way I can
match existing behavior. I came across this ordering dependency as
part of getting workspace tests running. It may be we end up adding a
LayoutManager to mus and pulling OnChildWindowVisibilityChanged into
it. But for now I'm going with just the OnChildWindowVisibilityChanged.

BUG=none
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2387013003
Cr-Commit-Position: refs/heads/master@{#422615}

SharedMemoryDataConsumerHandle::Context posts tasks while its lock_
locked. That means a lock held by the TaskRunner will be locked
after |lock_| is locked. On the other hand, the Context may be
destructed in the middle of TaskRunner destruction, which means we
cannot lock |lock_| in the Context destruction. Otherwise, a
lock-order-inversion problem will be introduced.

This CL stops locking |lock_| in the destructor. It is safe because
no one accesses to Content's member variables without a valid
scoped_refptr to the Context.

BUG=651747

Review-Url: https://codereview.chromium.org/2391513002
Cr-Commit-Position: refs/heads/master@{#422614}