- 23 Jun, 2020 40 commits
-
-
Patrick To authored
GraphicsDelegateWin creates GL resources in PreRender and deletes them in PostRender. If errors are generated in PreRender, PostRender still tries to delete them, which fires a DCHECK. This change returns false from PreRender if there are any errors in the GL context. In this case, the current overlay pose is ignored in VRBrowserRendererThreadWin. Bug: 1090957 Change-Id: I7aa4d3b1b0eb26ad571d9de396f3ef2a569c2382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259232 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#781572}
-
Bettina authored
Bug: 1097930 Change-Id: I14b0fa1d61abae81de7f07b3e750cc98a802f2ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258347Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#781571}
-
Ryan Keane authored
This CL adds a UKM and UMA metric to be logged when the Media Router Component Extension (the internal extension used to support cast scenarios) loads a file. This scenario is done as part of loading the cast sender SDK, and this change will be used to support a migration away from this hosting strategy for the SDK and an eventual migration away from the extension. Bug: 1084875, b/157107974 Change-Id: I5cba444a4534dcbdbd54a57408f3c4030f0aaff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249054 Commit-Queue: Ryan Keane <rwkeane@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#781570}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/089f7a6b11cd..07db5c8e7e39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC chanli@google.com,csharp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1087037,chromium:1098339 Tbr: chanli@google.com,csharp@google.com Change-Id: Iffaa0d4fcd1533bb7aab5a4038bbc9a6e1be8754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261472Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781569}
-
Robert Ogden authored
Adds variants of each of the prefetch successful enums with additional information about their attempt at doing a NoStatePrefetch. Bug: 1082505 Change-Id: Iba6fc4da7b49f3768ce421a3fd76a69f80023de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259515 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#781568}
-
Bettina authored
Safe Browsing service should observe changes in the enhanced protection pref. Bug: 1096644 Change-Id: I8fe0f6299ad1d3f12dbfdff1811284d39cb6c47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252573Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#781567}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: I5b601394626863ad9d007b2613448f4087bef383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261264Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#781566}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c65cebc2. With Chromium commits locally applied on WPT: c98dba7e "[COOP] access reporting. Improves tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I4998469b3b8ac57131081ebfbc9c0ea1c144a45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261513Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781565}
-
Toni Barzic authored
AppListPresetnerDelegateImpl adds a pre target event handler that dismisses the app list when the user clicks or taps outside the app list bounds. Certain areas of the shelf are excluded from handling, but they do not include shelf app buttons. This means that the app list hides when the user presses the mouse on a shelf app button, or shelf arrows. This breaks shelf interactions in HTML fullscreen mode, where the shelf is only shown with the app list. The app list gets hidden before the mouse is released, which also hides the shelf (note that auto-hide lock set by the AppListControllerImpl does not work in this case, as the shelf transitions to HIDDEN state when the app list is hidden). This prevents shelf app button clicks from getting handled - ShelfAppButton ignores click events if the shelf is not visible. In addition to breaking HTML fullscreen mode, hiding app list when the user starts interacting with a shelf app button creates other unexpected interactions. For example, dismissing app list when the user clicks a scrollable shelf arrow is not intuitive. Note that the app list will get hidden when an app gets launched from the shelf (if the user clicks a shelf app button). BUG=1097131, 1090713 Change-Id: I6b87b17eb9550840aeb0a2a0728baf9e49e96010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261260Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#781564}
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 842296 No-try: true Change-Id: If5e0dba3217bb3cee88b4994e5c3ac3a00e207a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260948Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#781563}
-
Evan Liu authored
Patchset 1 contains the reland without any changes. This CL integrates the WebRTC audio renderer with the live captioning pipeline, allowing the Chrome browser to automatically generate captions from the audio rendered by the WebRTCAudioRenderer. The high-level design document for the Live Caption feature can be found at: go/chrome-live-caption. Bug: 1093096 Change-Id: I84f31a42aecb511f8d1c188eed23dd738f2cb2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250707 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#781562}
-
Nina Satragno authored
This patch fixes a bug where platform authenticators are always sent MakeCredential requests with UV=discouraged regardless of relying party authenticator selection preference and authenticator support. Fixed: 1096764, 1091789 Change-Id: I37316f470332be3bae0cbb8e5d22f4c3e3ae7e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253124 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#781561}
-
Moe Ahmadi authored
Realbox themeing has been flagged by UX not ready for experimentation. Removing it from Finch (cr/317679487) and fieldtrial testing configs. Change-Id: Ib047590e8337c820a3847ed836a7cf556bcb7f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258073 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#781560}
-
Etienne Pierre-doray authored
Make NonEmptyPaint2 obsolete and update a few references to it. Also adds missing suffix to NonEmptyPaint3 to be on par with NonEmptyPaint2. Bug: 1091379 Change-Id: I06fca2955ab5a6c1c82e1743104b0df4f84fec45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240248Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#781559}
-
chrome://nearby-internalsJuliet Levesque authored
This will host the Nearby Internals UI for Chrome browser and ChromeOS where features such as logging displays will be placed to aid with debugging efforts. The page is guarded by the kNearbySharing feature flag. Bug: 1093634 Change-Id: Ic47f7d3800328a7bbf60947df34f7899cbae46db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236465Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/master@{#781558}
-
Ilya Sherman authored
The SettingsEnforcement trial has not been live for several years now, so drop the custom support for it. This allows API cleanup in many field trial files. R=asvitkine@chromium.org, gab@chromium.org TBR=boliu@chromium.org,rohitrao@chromium.org, Bug: 1098453 Change-Id: I14013871441a579cceca431dee8c9fa247bbbbd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251051Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#781557}
-
Ahmed Mehfooz authored
Bug: 1074109 Change-Id: I2aa038c6aa83d6dd37fc65e9d54995cf945aa220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258857Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#781556}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8ab3719fc486..10e4a44ce651 2020-06-23 brandon1.jones@intel.com Roll third_party/spirv-cross/ f9ae06512..2e7a56258 (1 commit) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ibaef8216ea7136deeee927d4bda97a8c32ef02aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261059Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781555}
-
Kyle Ju authored
This reverts commit 14dc6de7. Reason for revert: Export Notifier didn't experience any issues in the prod testing and comments were posted correctly here, https://chromium-review.googlesource.com/c/chromium/src/+/2241634. Original change's description: > Prod Testing - open a backdoor to dump all export_notifier comments to a dummy CL. > > It will read the comment history and dump all comments to https://chromium-review.googlesource.com/c/chromium/src/+/2241634/. Also tweak the Gerrit CL SHA so that the SHA is unique identified to each CL. > > Testing command: > third_party/blink/tools/wpt_export.py --credentials ~/.credentials --surface-failures-to-gerrit > > Output: > https://chromium-review.googlesource.com/c/chromium/src/+/2241634 > > Bug: 1027618 > Change-Id: I3a4932524488072cdbb820ccabdd4dd9a079cd3c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242001 > Commit-Queue: Kyle Ju <kyleju@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777952} Bug: 1027618 Change-Id: Iab53b6cbb2b6f57407c986983ce167cf02777379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261170Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#781554}
-
danakj authored
This drops one dependency from shell/browser/ to shell/browser/web_test by going directly to WebTestControlHost and having it register a WebContentsObserver to hear about new RenderFrames. This still has Shell using WebTestControlHost, but we're narrowing scope down to just that one class, at which point we can insert a delegate instead of the concrete type. We remove the WebTestControlHost::current_pid_ and the notification code around it, which is was partly tied to RenderFrame creation notification and was both wholly unnecessary as well as problematic or incorrect if the main frame moved to a new renderer process on navigation during a test. R=avi@chromium.org Bug: 866140, 1069111 Change-Id: I9e0622fa9ec73999bf59f2ab794acfd4684052d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247090 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781553}
-
Evan Stade authored
When enabled, and when third party cookies are being blocked, this will show an extra toggle in the page info bubble. Test: run_weblayer_shell example.com --args="--enable-features=\"ImprovedCookieControls\"" Bug: 1071775 Change-Id: Ib0a6d6a1c80cafa4b8aeeea19cb9919df55a7f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240011Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#781552}
-
Dale Curtis authored
API review has suggested this is not a modern approach, so add a canDecodeType() and require API users to provide an explicit mime type in order to get an ImageDecoder instance. Fixes https://github.com/dalecurtis/image-decoder-api/issues/1 Bug: 1073995 Change-Id: Ibae394d5d98d0b6011dfc7d360ed00273522c002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255672 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#781551}
-
Avi Drissman authored
Bug: none Change-Id: Ib8ee13da5ae9eea86f0ca22727acb07f883dd165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261263 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#781550}
-
Devlin Cronin authored
Most (though not all) support for the "action" key is complete. Promote it to Canary to enable easier testing for developers (so folks don't have to build Chromium from scratch). Bug: 893373 Change-Id: I671e87fbf55aa9f4e716e41277288261be7637b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258575Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781549}
-
Dominique Fauteux-Chapleau authored
The "if" removed in MaybeFinishConnectorRequest would prevent the auth request from completing since received_connector_responses_ is populated by tags in OnGetConnectorResponse. Since the auth request doesn't use tags, that map entry would stay empty and the request would be blocked from finishing. This CL also removes MaybeFinishRequest since it has no caller. Change-Id: Iae87f675bb8fb1690c34d3fececf1698a7e391e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261165Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#781548}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5d4e2463f77d73d8fdd46dbc0d876ea58e97e115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261097Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781547}
-
rajendrant authored
When LiteMode is enabled and https image compression experiment is active, this CL surfaces whether https images in the page got compressed to page info. The pageinfo screenshot is here https://storage.cloud.google.com/chromium-translation-screenshots/212a781d980587ffb65c0d71cc96ce0bdb3832bb TBR=twellington@chromium.org Bug: 1091856 Change-Id: I8cc52b253f037bebf444880cd62183bd1f27f61d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250541 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#781546}
-
Darwin Huang authored
Sqlite is using v3.32.1 now. Bug: 1087629 Change-Id: I504f751e8c361e081a8a969da0be09c138ab71c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261147 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781545}
-
Andrew Xu authored
This CL fixes two things: (1) We use a solid-color layer to draw hotseat background. However, Layer::SetBounds() does not mirror bounds under RTL. So we should do it manually. (2) View::SetBounds() mirrors bounds under RTL. So mirroring bounds manually in ShelfView's member function is unnecessary. Bug: 1094026 Change-Id: Iab5564b6687d7279733e5aa6d37fe41ef28cd15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261421Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781544}
-
Sebastien Marchand authored
Change-Id: Idea598dc21a96c4297841db2a733a2721f2d08e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261212 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#781543}
-
Connie Wan authored
See bug for screencast of issue. The issue only seems to be present on Mac, and I tested dragging on both Mac and Windows with this change. Bug: 1033534 Change-Id: I10553e4121f1e3566f66ffd215cfd276ac8ab801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261222Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#781542}
-
Xi Han authored
Bug: 1092931 Change-Id: I07e6f2b343ec368ce161a742f2b69548b44e2fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261359 Commit-Queue: Xi Han <hanxi@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#781541}
-
ckitagawa authored
In order to give a more seamless transition. This CL captures the scroll state of the page at time of recording. Then this can be used to replay the scroll position when loading the paint preview. This behavior can be disabled via PlayerManager if not desired. Bug: 1096598 Change-Id: I4dffa033e12d5cac9cbf521a330cefa9201b4ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250589 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#781540}
-
Victor Fei authored
The motivation behind this change is for ATs to be able to switch from an IA2 element to its corresponding UIA element. In order to achieve the above, this CL implemented the following: - IItemContainerProvider::FindItemByProperty for finding an UIA element through its unique id. https://docs.microsoft.com/en-us/windows/win32/api/uiautomationcore/nf-uiautomationcore-iitemcontainerprovider-finditembyproperty - A custom UIA property id that maps to an element's unique id. - Introduced ui::UiaRegistrarWin class for managing custom UIA property/event. AX-Relnotes: ATs will be able to lookup an UIA element from and IA2 element. Bug: 1084630 Change-Id: Ief9664ff04224972af6607304c6893c25772f95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242046Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#781539}
-
Roger Tawa authored
OnSecurityEventEnterpriseConnector policy. Before connectors the URL for reporting was hardcode to one value. Connectors adds the ability for the URL to change dynamically based on the connector chosen by the admin, as identified by the connector policy. Bug: 1069031 Change-Id: Ic59379283d7651be45d65f6f9785c43c0d43e1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251742 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#781538}
-
Robert Ogden authored
Bug: 1082505 Change-Id: I3c6fff27d5f2d8a418b0f6f79823fa88d1575f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261158 Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#781537}
-
K. Moon authored
Introduces a new directory for temporary code related to the PDF viewer's PPAPI migration. Code in this directory should abstract away usage of PPAPI, so it may easily be removed after the migration is done. Also moves the existing pdf/geometry_conversions.{cc, h} files, as an early example of the kind of code that should be in this directory. Bug: 10611824 Change-Id: I01372843f4149a607ef1b6dab80277986c177d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261413 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#781536}
-
Connie Wan authored
The issue was related to TabStrip::AddTabToGroup firing causing too much churn. I fixed it elsewhere, but I did clean up a spot in TabStrip::AddTabToGroup that was problematic memory-wise. I started writing a test in tab_group_editor_bubble_view_browsertest, but then I realized I'd have to change several things about the setup (add extra tabs, branch the logic so that it can collapse the group conditionally, modify all the tests, etc.). If there are any other thoughts on where to test this, I'd be happy to take a look! Bug: 1095801 Change-Id: I283970e6f2242ac387114eb303a8529bb2764593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261261Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781535}
-
David Van Cleve authored
In some circumstances, ProfileNetworkContextService can set the directories it populates in NetworkContextParams (for the cookie store, reporting store, and so on) to a nonexistent path. Currently, the Trust Tokens backing store doesn't attempt to create directories when nonexistent, causing some tests to fail flakily when sql::Database::Open hits a LOG(DFATAL) after attempting to open a database at a path with a nonexistent parent directory. (It's flaky because the failure races with other backing stores that do attempt to create the directory in this scenario.) This change hopefully resolves the failures, by making SQLiteTrustTokenPersister::CreateForFilePath create the given path's directory if it does not exist. R=mmenke Fixed: 1098019 Change-Id: Id075718035e1fd7e29cebc063d9126f1f33c4c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258685Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#781534}
-
Dana Fried authored
When the selected tab in a tab group changes, the length of the group underline may need to change. This was not happening, resulting in the attached bug. This CL refactors TabStrip::SetSelection() in a handful of small ways: - makes old selected tab and new selected tab explicit local variables - simplifies conditional logic slightly - makes an implicit assumption that new selected tab is valid explicit * there had been a check in one place for an invalid index * however, it just blindly dereferences it later in the function which would have caused a crash - when active tab changes, if either tab was in a group, recalculates group underline and highlight bounds via UpdateTabGroupVisuals() Fixed: 1098392 Change-Id: Ib4b41bd8ce3e7c601d0329cef9d96b8d5846d7b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261166 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#781533}
-