- 03 Jul, 2018 40 commits
- 
- 
Yoshifumi Inoue authoredThis patch changes "childNodes-reverse-iteration.html" to utilize w3c test harness for ease of maintenance. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1114673 Make Element#innerText specification compliant Bug: 859410 Change-Id: Ie4f834134639bd2b21838764c032183319d62a73 Reviewed-on: https://chromium-review.googlesource.com/1122073Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572111} 
- 
Luciano Pacheco authoredFully disabled now since it started failing on linux_chromium_rel_ng too. Tbr: pfeldman@chromium.org Bug: 859382 Change-Id: Ic5dc2df56629d32b4ac76b3a8f6607cfa32db92d Reviewed-on: https://chromium-review.googlesource.com/1124000Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#572110} 
- 
Wez authoredThis is a partial reland of b035cfda, which was reviewed on https://chromium-review.googlesource.com/1082980 TBR: gab, thakis Bug: 844016 Change-Id: I56847225b6eec13f182d03de5cf831b7c5362ad7 Reviewed-on: https://chromium-review.googlesource.com/1123888Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#572109} 
- 
Luciano Pacheco authoredTest has been marked as flaky by Try-Flakes for different builders. Tbr: nasko@chromium.org, alexmos@chromium.org Bug: 859487 Change-Id: I39a8fd525a91b8bf6b6e4ab1b1c5c56ee0e38756 Reviewed-on: https://chromium-review.googlesource.com/1123999Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#572108} 
- 
angle-chromium-autoroll authoredhttps://chromium.googlesource.com/angle/angle.git/+log/a72f400c5ff3..92da844eb754 git log a72f400c5ff3..92da844eb754 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 jgilbert@mozilla.com More includes missing from sources. Created with: gclient setdep -r src/third_party/angle@92da844eb754 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I2b2ce54510ea4002d4684fa1089b5e4a207cd78e Reviewed-on: https://chromium-review.googlesource.com/1123941Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572107} 
- 
depot-tools-chromium-autoroll authoredhttps://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/90cac980d26c..43033409f481 git log 90cac980d26c..43033409f481 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 tandrii@chromium.org bot_update: remove legacy Gerrit patch property support. 2018-07-03 ehmaldonado@chromium.org gclient setdep: Add support for CIPD versions 2018-07-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@43033409f481 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:858978 TBR=agable@chromium.org Change-Id: Ia92beb7992aba3123410dfa8ea295b95bec46f52 Reviewed-on: https://chromium-review.googlesource.com/1123940Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572106} 
- 
Hayato Ito authoredFormat renderer/core/dom/README.md by prettier. BUG: 742715 TBR=kochi NOTRY=true Change-Id: Ib67571d3490a64681ef32f2bfcc47578e7282012 Reviewed-on: https://chromium-review.googlesource.com/1123975 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#572105} 
- 
tzik authoredLifecycleObserver construction used to hit a CFI check failure under the Oilpan incremental marking. This CL adds a test to confirm it's fixed and it's not broken again. Bug: 854639 Change-Id: If2990658921168fe83053facbc3c780607bbff07 Reviewed-on: https://chromium-review.googlesource.com/1123661Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#572104} 
- 
tzik authoredThis CL fixes a CFI check failure on the Oilpan incremental marking. The initialization of ContextLifecycleObserver is done as: 1. Allocate sufficient memory for the instance 2. Call GCM constructor 3. Update the vptr to point LifecycleObserver's vtable 4. Call the body of LifecycleObserver constructor. 5. Update the vptr to point ContextLifecycleObserver's vtable 6. Call the body of ContextLifecycleObserver constructor. In the step 4, the constructor calls SetContext, which casts the instance from LO to CLO and stores it to LifecycleNotifier, and that causes Trace() or GetTraceDescriptor() call on CLO, rather than LO. Note that the instance is ready as an LO instance, but not ready as an CLO instance at the moment. While a virtual method of CLO is being dispatched, CFI checks if the vtable of the receiver is for CLO or its subclass, but that was not true as the vptr points LO's vtable until the step 5. After this CL, LO::Trace() or LO:GetTraceDescriptor() will be called in SetContext(), rather than CLO::Trace() or CLO::GetTraceDescriptor(), that should be ready to call before the step 5. Bug: 854639 Change-Id: Ib27f147099ccb416d5f357fccd401d003de2dcaa Reviewed-on: https://chromium-review.googlesource.com/1122140 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#572103} 
- 
skia-chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/54fd491d8bee..e01683e81de0 git log 54fd491d8bee..e01683e81de0 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e01683e81de0 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I8c9396838cdc2f3437ec467027932353b175ad9e Reviewed-on: https://chromium-review.googlesource.com/1123939Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572102} 
- 
Xianzhu Wang authoredThis CL doesn't actually remove the paint_offset parameter, but lets all objects use FragmentData::PaintOffset(), and checks if the new paint offset equals to the old paint offset. Also add workarounds for 2 existing bugs to make the new paint offset correct: - crbug.com/858843: Modify PaintPropertyTreeBuilder to workaround the bug to produce correct paint offset for floating objects in RTL container with scrollbar on the left. - crbug.com/856802: We have to generate paint offset of LayoutScrollbarPart during painting because of the bug. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id7c891ef05ec02ab93a17a3ddc6001e916ff2400 Reviewed-on: https://chromium-review.googlesource.com/1114297 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572101} 
- 
Emily Stark authoredThis CL deprecates UnsafelyTreatInsecureOriginAsSecure in favor of an equivalent policy named OverrideSecurityRestrictionsOnInsecureOrigin, which we think will be more clear to admins. Bug: 844885 Change-Id: I80fb2488b5495aff4f1b3308d96248fbe2221af9 Reviewed-on: https://chromium-review.googlesource.com/1107849 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#572100} 
- 
Ned Nguyen authoredBug:859524 Change-Id: I7152a82888004508b21ec9d5a2d020019782f33f This is blocked on catapult roll to roll https://chromium-review.googlesource.com/c/catapult/+/1122957 Change-Id: I7152a82888004508b21ec9d5a2d020019782f33f Reviewed-on: https://chromium-review.googlesource.com/1122960 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#572099} 
- 
catapult-chromium-autoroll authoredhttps://chromium.googlesource.com/catapult.git/+log/153acbd707c0..cbfa46069e2b git log 153acbd707c0..cbfa46069e2b --date=short --no-merges --format='%ad %ae %s' 2018-07-03 nednguyen@google.com Only output the total histogram format if there is at least a single page that succeed Created with: gclient setdep -r src/third_party/catapult@cbfa46069e2b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:859073 TBR=sullivan@chromium.org Change-Id: I36cf6a327e921f83587cd3188f85f7e9d83e5e2f Reviewed-on: https://chromium-review.googlesource.com/1123781Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572098} 
- 
Aaron Leventhal authoredThe layout bugs test runner uses an altered code path to post a11y notifications, that allows a listener to delete the very object that is firing the notifications. Do not attempt to further process a11y notifications for objects that are detached. Bug: 843960 Change-Id: I1e10ee014855c1d8f6fbf06c29c5a51c19fe1330 Reviewed-on: https://chromium-review.googlesource.com/1122714Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#572097} 
- 
John Budorick authoredBug: 857001 Change-Id: I24219576e71cf636da916ed5119c32c37d5e5394 Reviewed-on: https://chromium-review.googlesource.com/1123268 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#572096} 
- 
depot-tools-chromium-autoroll authoredhttps://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/605dd3126a6c..90cac980d26c git log 605dd3126a6c..90cac980d26c --date=short --no-merges --format='%ad %ae %s' 2018-07-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@90cac980d26c The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie97eede695215f4a8fca4aa631d80dd32f300b38 Reviewed-on: https://chromium-review.googlesource.com/1123779Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572095} 
- 
chrome-release-bot authored# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I58b05780e046fcda2cf44ee54c85fdfce6422989 Reviewed-on: https://chromium-review.googlesource.com/1123922Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#572094} 
- 
rajendrant authoredReport resource type in DidStartResponse. This will be used by MetricsRenderFrameObserver to distinguish frame requests. Bug: 836029 Change-Id: I9e5cc9ec220286dd15b110114c624c81afe60e13 Reviewed-on: https://chromium-review.googlesource.com/1123374 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#572093} 
- 
Takuto Ikuta authoredThis cl increases build parallelism for * android_arm64_dbg_recipe * android_clang_dbg_recipe These builders have slow compile step time like below builds. * android_arm64_dbg_recipe 5935s https://ci.chromium.org/b/8942150764225931712 5163s https://ci.chromium.org/b/8942367352394832112 4696s https://ci.chromium.org/b/8942146814412549072 * android_clang_dbg_recipe 4257s https://ci.chromium.org/b/8942150764225931424 4102s https://ci.chromium.org/b/8942346357249144704 3984s https://ci.chromium.org/b/8942146814412548848 Bug: 804251 Change-Id: I2daa9d8e86bbee4c990e3518a7c0300754d42859 Reviewed-on: https://chromium-review.googlesource.com/1122062 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#572092} 
- 
David Tseng authoredWe are typically extremely conservative when loading the built in tts engine. The only codepath we do this before was in TtsControllerImpl, in response to a speak call. This change enables loading immediately after the tts settings page registers js message handlers in C++, where a non-null profile is available. Test: on a fresh profile, navigate to settings -> accessibility -> tts -> Google tts engine settings. Verify all voices show up. Change-Id: Id2294f25f034da0a254d904c1325e0d8ba274d21 Reviewed-on: https://chromium-review.googlesource.com/1120948Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#572091} 
- 
Wez authoredThis reverts commit 5cab33d1. Reason for revert: Speculative revert for issue 857486 which coincides with this change affecting the crashing code path. Original change's description: > Omnibox UI Refresh: Implement popup open and close opacity animations. > > This eases in and out the Omnibox popup opacity over 82ms as it opens > and closes. This matches the animation spec provided by UX. > > Bug: 823535 > Change-Id: Ic2add1f57f63ae6d043812f2bd5a766f84d302c9 > Reviewed-on: https://chromium-review.googlesource.com/1081198 > Commit-Queue: Tommy Li <tommycli@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Ali Juma <ajuma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564295} TBR=pkasting@chromium.org,ajuma@chromium.org,tommycli@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 823535, 857486 Change-Id: Ic251311dda8d91dbfddcb9ae7daea86d2d88bb5f Reviewed-on: https://chromium-review.googlesource.com/1123719Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#572090} 
- 
skia-chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/ef21d7e47963..54fd491d8bee git log ef21d7e47963..54fd491d8bee --date=short --no-merges --format='%ad %ae %s' 2018-07-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@54fd491d8bee The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ib2812950757b9578eb13ff0c65f1bd3345332d88 Reviewed-on: https://chromium-review.googlesource.com/1123780Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572089} 
- 
Aleks Totic authoredBug: 740993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iec59abf8eef6091655001374be6795aeef87760f Reviewed-on: https://chromium-review.googlesource.com/1123166 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#572088} 
- 
Ryan Hamilton authoredMerge internal change: 202944507 Change-Id: I349cd2bdc9f075c8202c93f7319d3cf534e02971 Reviewed-on: https://chromium-review.googlesource.com/1122483 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#572087} 
- 
Xiaocheng Hu authoredThis reverts commit d1c99618. Reason for revert: Observed many crashes in M68 & M69. Not ready for shipping. Original change's description: > Remove cold mode idle time spellchecker flag > > As cold mode idle time spellchecker is shipped into M68 > and no regression is obversed, this patch removes the flag > from M69 as cleanup. > > Bug: 716642 > Change-Id: I8f850c52469590ee9d5e542c14f4dae842a6163a > Reviewed-on: https://chromium-review.googlesource.com/1072953 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561951} TBR=yosin@chromium.org,tkent@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 716642, 856376, 859056, 859443 Change-Id: I91426509a315a07bf4f548ebafe825c2ef856999 Reviewed-on: https://chromium-review.googlesource.com/1123120 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#572086} 
- 
Yoshifumi Inoue authoredThis patch changes "row-inner-text.html" to utilize w3c test harness for ease of maintenance. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1114673 Make Element#innerText specification compliant Bug: 859410 Change-Id: I2efbd96aca89a2c4e5b63d62dcc3dc2f2968d8e0 Reviewed-on: https://chromium-review.googlesource.com/1122138Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572085} 
- 
chcunningham authoredCq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8f1213c0111a204053680922a1c8b99f11222b2c Reviewed-on: https://chromium-review.googlesource.com/1103607 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#572084} 
- 
Luciano Pacheco authoredTest external/wpt/feature-policy/experimental-features/vertical-scroll-touch-block-manual.tentative.html has been marked as flaky by Try-Flakes, skipping until further investigation. Bug: 850964 Tbr: ekaramad@chromium.org Change-Id: I13ef5fd0520a2e04e1c7166fff2fd2a52a8d0add Reviewed-on: https://chromium-review.googlesource.com/1123739Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#572083} 
- 
Luciano Pacheco authoredThis reverts commit cf25f142. Reason for revert: crbug.com/859718 was a false alarm, failures was before merging the CL originally reverted. Original change's description: > Revert "Convert chrome/ tests using ViewsTestBase to ChromeViewsTestBase." > > This reverts commit ed47f31b. > > Reason for revert: All tests from TabTest reported flaky crbug.com/859718 > > Original change's description: > > Convert chrome/ tests using ViewsTestBase to ChromeViewsTestBase. > > > > This ensures these tests are testing the actual harmony/refresh behavior, and > > makes sure as people add more calls to ChromeLayoutProvider to the code they > > don't result in unexpected test crashes. > > > > Bug: none > > Change-Id: If21b7eec387dc47be448e2dbb2730ddacb7b51fe > > Reviewed-on: https://chromium-review.googlesource.com/1121787 > > Commit-Queue: Peter Kasting <pkasting@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#572008} > > TBR=pkasting@chromium.org,thestig@chromium.org > > Change-Id: Ib0d68d4aaff4a8617b95f4456eef0dad9f66e57b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: none > Reviewed-on: https://chromium-review.googlesource.com/1123839 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572070} TBR=pkasting@chromium.org,thestig@chromium.org,lucmult@chromium.org Change-Id: I7c738232c08a506baa0ebf43d1a4df87fa2ca2f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859718 Reviewed-on: https://chromium-review.googlesource.com/1123859Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#572082} 
- 
Ted Meyer authoredA histogram called Media.D3D11.WasVideoSupported is being added to track how many videos actually being played are capable of using the d3d11 decoder, or if they are not supported, then for what reason Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibb57f34644b66211afbf4bba4776124e8bafa6d3 Reviewed-on: https://chromium-review.googlesource.com/1117895 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#572081} 
- 
rbpotter authoredFix routing in bookmarks and history to work with Polymer2, where the race between iron-location and iron-query-params will cause queries from the URL to be lost. This causes MaterialBookmarksRouterTest and MaterialHistoryRoutingWithQueryParamTest to pass with Polymer2. Bug: 738611 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib5aad55c25f8f29b25cd56cd11f2d4110d5b9b48 Reviewed-on: https://chromium-review.googlesource.com/1121589Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#572080} 
- 
Xiaocheng Hu authoredCurrent NG hit test code decides whether a hit test location is clipped by rounded border by adding border radius to all four corners and then compare with the hit test location. This is wrong if the box is fragmented, where it may have only two or zero rounded corners. This patch changes HitTestClippedOutByBorder() to take the above into consideration. By utilizing |border_edges_|, it can generate the corrected rounded border to be hit tested. Test: This patch slightly modifies WPT hit-test-inline-fragmentation-with-border-radius.html as a workaround of some rounding issue, which is out of the scope of this patch. Bug: 855279, 859233 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1e3193f9fc2d5e52ff53d6cb2fcc2a0ae2b3aa43 Reviewed-on: https://chromium-review.googlesource.com/1123265Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#572079} 
- 
bsheedy authoredRe-enables VrShellTransitionTest#testWebXrReEntryFromVrBrowser since the flakiness that got it disabled should now be fixed. TBR=mthiesse@chromium.org Bug: 856546 Change-Id: I6aa101775e50e7c2ed605bc1c762fe6bd0e6ba58 Reviewed-on: https://chromium-review.googlesource.com/1123760Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#572078} 
- 
bsheedy authoredRoll the WebXR sample repo to pick up a framebuffer scale fix. TBR=bajones@chromium.org Bug: 853400 Change-Id: Ic6880944037ace9fed199e647c04708aec0851af Reviewed-on: https://chromium-review.googlesource.com/1123642Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#572077} 
- 
Tetsui Ohkubo authoredUnifiedSystemTray has to show number of disabled notifier sources under the do-not-disturb feature pod button. In order to implement this, first we had to make NotifierSettingsListener in ash::MessageCenterController to support multiple listeners. TEST=manual BUG=856931 Change-Id: If4186853a7ced96d726ccf9b5d40ca05f8268cb3 Reviewed-on: https://chromium-review.googlesource.com/1116635 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#572076} 
- 
Yutaka Hirano authoredThis is for further investigation of flakiness. Bug: 799516 Change-Id: Ie31837422a4e0b8ed5926f8e669911b50721e2c9 Reviewed-on: https://chromium-review.googlesource.com/1123659Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572075} 
- 
James Darpinian authoredA previous change removed the command buffer flush when destroying a transfer buffer: https://chromium-review.googlesource.com/c/chromium/src/+/1105466 If we want to free a transfer buffer promptly, we now need to flush separately, and we do. Unfortunately if no commands were issued between the call to DestroyTransferBuffer and the flush, the flush might not execute because the CommandBufferProxy would pass an outdated flush ID to GpuChannelHost::EnsureFlush. The fix is to inform the CommandBufferProxy about the new flush ID when it calls DestroyTransferBuffer. This should fix the memory regressions on the perf waterfall noted in bug 855402. Bug: 855402, 850271, 835353, 828363 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id125c5124b26763e692c1fe8067df28761fa6dab Reviewed-on: https://chromium-review.googlesource.com/1121590Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#572074} 
- 
Darren Shen authoredAfter https://crrev.com/c/1098753, "container" now means the parent (ash) container of the virtual keyboard. Thus, there's no more ambiguity between the keyboard "container" vs "contents" window, so we can just refer to the "contents" window as the "keyboard window". Bug: 849980 Change-Id: Iddaca77b8bf37559db75efdedc6a9276491c453d Reviewed-on: https://chromium-review.googlesource.com/1119610Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#572073} 
- 
Yutaka Hirano authoredIt seems the crash is a null access in a ResourceResponse assignment. This CL adds a CHECK for that. Bug: 570946 Change-Id: I8c7afe8f76499f80fe918cd6d6617ff2952a2e6f Reviewed-on: https://chromium-review.googlesource.com/1123662Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572072} 
 
-