GitLab

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8771065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113320 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to 113090 to see which ModelChangingSyncerCommand triggers
a perf regression.

BUG=97832
TEST=
TBR=tim

Review URL: http://codereview.chromium.org/8820019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113319 0039d316-1c4b-4281-b951-d872f2087c98

BUG=lint from review 8561031
TEST=none; this is a refactoring of existing unit tests.


Review URL: http://codereview.chromium.org/8824010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113318 0039d316-1c4b-4281-b951-d872f2087c98

Create a secondary file thread, FILE_USER_BLOCKING, for tasks requiring file IO which have user waiting for the results. Process appcache background tasks on that thread.

BUG=68894,78359
Review URL: http://codereview.chromium.org/8366020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113317 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=unit_tests


Review URL: http://codereview.chromium.org/8770035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113315 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105755
TEST=Verify that visual glitch is gone, see bug for details.
Review URL: http://codereview.chromium.org/8828011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113314 0039d316-1c4b-4281-b951-d872f2087c98

Eighteen is a composite number, its proper divisors being 1, 2, 3, 6 and 9. Three of these divisors (3, 6 and 9) add up to 18, hence 18 is a semiperfect number. Eighteen is the first inverted square-prime of the form p.q2.
It is a heptagonal number, and as the sum of the first three pentagonal numbers, it is a pentagonal pyramidal number. It is also the sum of the totient function for the first seven integers.
Eighteen is the second abundant number with the aliquot sum of 21 (117% in abundance) in the aliquot sequence (18, 21, 11, 1, 0) thus being the first composite number in the 11-aliquot tree. Eighteen is the aliquot sum of only one number the square 289.
In base 10 it is a Harshad number.
18, aside from 0, is the only number that equals twice the sum of its decimal digits.

The atomic number of argon
The 18-electron rule is a rule of thumb in transition metal chemistry for characterising and predicting the stability of metal complexes
The number of years in the Saros cycle of eclipses of the sun and moon

18:00, a time on the 24-hour clock corresponding to 6:00 PM.
A 2005 movie directed by Richard Bell and starring Brendan Fletcher and Alan Cumming.
Bobby Labonte's car number in the NASCAR Winston Cup Series when he won the 2000 Championship. This is J. J. Yeley's car number until the end of the 2007 Nextel Cup Season. Kyle Busch took the car number in 2008.
A 2002 album by electronic artist Moby.
The number of holes in a stipulated round of golf
The number of chapters into which James Joyce's epic novel Ulysses is divided
Russ Wheeler's car number in the film Days of Thunder
A slang term used in association football for the Penalty Area
The number of wheels on the most common type of North American tractor-trailer truck, which are hence often called 18-wheelers
The number of the French department Cher and the Turkish province Bitlis
DVD-18 is double-sided, double-layered DVD format
Android 18, a fictional character in the metaseries Dragon Ball.
The Hindu epic Mahabharata has eighteen sections, involves eighteen armies and is about a war fought over eighteen days
In some countries the number 18 means blood (relative)
In Chinese folklore, the Shaolin temple had a group of 18 bronze Monks. Initiates could only be considered full graduates of Shaolin martial arts if they could defeat them in combat.
In 1990 Megadeth released Hanger 18 as a single for the Rust in Piece Album.
Eighteen Eighteen, a South African Rap artist.
"I'm Eighteen", Alice Cooper's first Top Ten hit single, from their 1971 album Love It to Death.
Eighteen is also a surname, recorded in East Anglia in the 18th century [3]

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113313 0039d316-1c4b-4281-b951-d872f2087c98

After this patch, all the unit_tests should pass.

BUG=62897
TBR=aa
Review URL: http://codereview.chromium.org/8826010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113312 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8825009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113311 0039d316-1c4b-4281-b951-d872f2087c98

This can't be committed until webkit rolls past 101890.

BUG=64054
TEST=


Review URL: http://codereview.chromium.org/8789004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113310 0039d316-1c4b-4281-b951-d872f2087c98

interactive ui tests because aura is pure views and has no native view.

BUG=71144
TEST=more tests in interactive_ui_tests passes on aura


Review URL: http://codereview.chromium.org/8800011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113309 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104314
TEST=green builds


Review URL: http://codereview.chromium.org/8823013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113308 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105028
TEST=ReferrerPolicyTest.*


Review URL: http://codereview.chromium.org/8823008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113307 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to 113090 to see which ModelChangingSyncerCommand triggers
a perf regression.

BUG=97832
TEST=
TBR=tim

Review URL: http://codereview.chromium.org/8822018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113306 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113300 - Revert of 112134 of Revert 112130 - Close idle connections / SPDY sessions when needed.

Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit.

Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket. 

Fixed ASAN test failures by removing  .Times(1) and .Times(2)  from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is probably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan).


BUG=62364,92244, 105839
TEST=none


Review URL: http://codereview.chromium.org/8340012

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/8745007

TBR=willchan@chromium.org

Review URL: http://codereview.chromium.org/8803019

TBR=rtenneti@chromium.org
Review URL: http://codereview.chromium.org/8825014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113305 0039d316-1c4b-4281-b951-d872f2087c98

Disabling 2 tests on pyauto chromium vista bot only.  They seem fine on other
bots / setups.

R=frankf@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8771058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113304 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles
TBR=sky
Review URL: http://codereview.chromium.org/8771015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113303 0039d316-1c4b-4281-b951-d872f2087c98

I keep getting confused between things like AudioImpl and PPB_Audio_Impl. This uses _shared for the names, so now we have _impl, _proxy, and _shared which makes more sense.

I also removed the ppb_opengles2_impl file since it was just a forward to the shared version.

BUG=
TEST=

Review URL: http://codereview.chromium.org/8790004

TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/8824015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113302 0039d316-1c4b-4281-b951-d872f2087c98

Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit.

Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket. 

Fixed ASAN test failures by removing  .Times(1) and .Times(2)  from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is probably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan).


BUG=62364,92244, 105839
TEST=none


Review URL: http://codereview.chromium.org/8340012

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/8745007

TBR=willchan@chromium.org

Review URL: http://codereview.chromium.org/8803019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113300 0039d316-1c4b-4281-b951-d872f2087c98

This is temporary.  Until nduca has time to look at the failure.

BUG=106557
TEST=gpu win release green again
TBR=nduca
Review URL: http://codereview.chromium.org/8823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113299 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=GpuFeatureBrowsertest
R=jbates
Review URL: http://codereview.chromium.org/8816027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113298 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=DownloadProtectionServiceTest


Review URL: http://codereview.chromium.org/8803023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113297 0039d316-1c4b-4281-b951-d872f2087c98

Add ONC VPN support for OpenVPN and L2TP/IPsec VPNs

Also simplifies some of the parsing code, adds type validation, brings
the WiFi security parsing up to spec, and improves the unit tests for
wifi so that they all verify the property_map_ fields (the only ones
actually used to configure the network). Also fixed a general parser
problem where certificates wouldn't be parsed if network configs were.

BUG=chromium-os:23476
chromium-os:23477
TEST=manual import of ONC file with openvpn network, unit_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113120
Review URL: http://codereview.chromium.org/8821023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113296 0039d316-1c4b-4281-b951-d872f2087c98

or sent ping (like below):

t=1323200233634 [st=196851]     SPDY_SESSION_PING
                                --> type = "sent"
                                --> unique_id = 3
t=1323200233638 [st=196855]     SPDY_SESSION_PING
                                --> type = "received"
                                --> unique_id = 3
BUG=106499
R=willchan
TEST=spdy unit tests

Review URL: http://codereview.chromium.org/8824005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113295 0039d316-1c4b-4281-b951-d872f2087c98

Also, add padding around the tooltip text and disable the
border when shadows are enabled.

I'm also updating the existing shadow code in aura_shell to
clip corner images as needed when they're too large to fit
within the requested size.

BUG=106507
TEST=added


Review URL: http://codereview.chromium.org/8821028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113294 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106529
TEST=removed suppressions from mem/heap check tools


Review URL: http://codereview.chromium.org/8819029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113293 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org,csilv@chromium.org
BUG=92912
TEST=Drag a [removable] app over the trash in either LTR or RTL and be greeted
by a sweet trash can lid opening animation.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113167

Review URL: http://codereview.chromium.org/8786010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113292 0039d316-1c4b-4281-b951-d872f2087c98

Write the ActiveX control from an external script in all test documents.  This works around a "feature" of IE versions released between April, 2006 and April, 2008 that required the user to click on an ActiveX control to "activate" it.  See http://msdn.microsoft.com/en-us/library/ms537508.aspx.

I also added asserts for the copying of CFInstance and CFInstall so that the whole test aborts if the files can't be copied, since otherwise test results are bogus.

BUG=60987
TEST=no manual testing needed; chrome_frame_tests.exe will either become better or worse.

Review URL: http://codereview.chromium.org/8777002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113291 0039d316-1c4b-4281-b951-d872f2087c98

I keep getting confused between things like AudioImpl and PPB_Audio_Impl. This uses _shared for the names, so now we have _impl, _proxy, and _shared which makes more sense.

I also removed the ppb_opengles2_impl file since it was just a forward to the shared version.

BUG=
TEST=

Review URL: http://codereview.chromium.org/8790004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113290 0039d316-1c4b-4281-b951-d872f2087c98

failure.

BUG=none
TEST=none
R=oshima@chromium.org


Review URL: http://codereview.chromium.org/8820006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113289 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106157
TEST=browser_tests

Review URL: http://codereview.chromium.org/8790012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113288 0039d316-1c4b-4281-b951-d872f2087c98

HttpStreamFactoryImpl::Job::OnStreamReadyCallback.

As a side-effect of OnPipelineFeedback() calling OnPipelineHasCapacity() on all
of the pipelines, some requests are late-bound to existing pipelines with
capacity. However, those requests may have been in the process of establishing
new pipelines. By stealing those requests, the new pipelines become empty and
are deleted. Later iterations of the loop in OnPipelineFeedback() weren't
careful about checking to see if the pipeline was deleted before calling
OnPipelineHasCapacity() on it.

BUG=106313
TEST=net_unittests under valgrind


Review URL: http://codereview.chromium.org/8820005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113287 0039d316-1c4b-4281-b951-d872f2087c98

First in a series of patches to replace ModelType{Bit,}Set with
ModelEnumSet (which will then be renamed to ModelTypeSet).

BUG=79970
TEST=


Review URL: http://codereview.chromium.org/8772074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113286 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of the last view_messages.h include in chrome, other than tab_contents_views_mac.mm and render_view_host_delegate_helper.cc, both of which Avi is working on. I added a test method to fake a UpdateRect IPC message for the thumbnail test.

BUG=98716

Review URL: http://codereview.chromium.org/8819005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113285 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup the connection member of the engine object when destructing.
Properly unregister IMEs when unloading extensions.

BUG=chromium-os:21357,21514,21355
TEST=See bugs


Review URL: http://codereview.chromium.org/8761018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113284 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8801004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113283 0039d316-1c4b-4281-b951-d872f2087c98

DnsClient provides a generic DNS client that allows fetching resource records. 
DnsClient is very lightweight and does not support aggregation, queuing or 
prioritization of requests. 

This is the first CL in a series to merge AsyncHostResolver into 
HostResolverImpl. 

Also introduces general-purpose BigEndianReader/Writer. 

BUG=90881
TEST=./net_unittests


Review URL: http://codereview.chromium.org/8762001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113282 0039d316-1c4b-4281-b951-d872f2087c98

Pull the CrAppProtocol autorelease-pool handling down into 
MessagePumpCrApplication, which is selected at Create() if NSApp 
implements the right protocol. UsingCrApp() allows clients to 
confirm the correct setup (unfortunately, synchronizing NSApp 
initialization and MessagePump::Create() would be intrusive).

Also push CrAppProtocol and CrAppControlProtocol implementation into
BrowserCrApplication, and reparent that class from NSApplication.

Reparent ServiceCrApplication on NSApplication and rename.

Remove CrApplication registration from gpu, plugin, and renderer
mains.

Remove MockCrApp dependency from remoting sample code.

BUG=102224


Review URL: http://codereview.chromium.org/8771028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113281 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8817023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/8820022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113279 0039d316-1c4b-4281-b951-d872f2087c98