- 07 Dec, 2017 40 commits
-
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9d78afdd3d87..b5e2acc413ff $ git log 9d78afdd3..b5e2acc41 --date=short --no-merges --format='%ad %ae %s' 2017-12-07 rmistry Skip PostUploadHooks for all auto commit bots 2017-12-07 benjaminwagner Add Nexus7 CPU jobs. 2017-12-07 benjaminwagner Move PixelXL jobs to the Pixel. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I8d1a68a816c258c3d44be00b8652f0dcfea600e4 Reviewed-on: https://chromium-review.googlesource.com/814576Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522465}
-
Abhishek Arya authored
- Use absolute path to make filters work. - Fix description to account for fact that we just want developer to add GN configuration and we build the target for them. - Fix missing target in pdfium command line. - llvm directory can be cleared when target_os change, but cr_coverage_revision stays intact. So, check for coverage tool binaries, otherwise we will crash on file not found. R=mmoroz@chromium.org,liaoyuke@chromium.org Bug: Change-Id: I0ce23c09863323af2d03561a232cb9e614493506 Reviewed-on: https://chromium-review.googlesource.com/814495 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#522464}
-
Bruce Dawson authored
base_paths_win.cc needs the known folders GUIDs which are defined in KnownFolders.h. It was including shlobj.h which *usually* brings in this header file, but not always. The happy path is: shlobj.h includes shlobj_core.h which includes shlguid.h which includes KnownFolders.h However shlobj_core.h includes shlguid.h like this: #ifndef INITGUID #include <shlguid.h> #endif /* !INITGUID */ That's fine if shlguid.h is the only place that defines INITGUID, but it isn't. It doesn't even define it - it includes another file that does. That's terrible. So, if you include shlobj.h you may or may not get KnownFolders.h. This is sloppy on our part, and on Microsoft's. This was found while experimenting with different jumbo-build settings - FOLDERID_ApplicationShortcuts would not be defined if the wrong .cc files were included first. The investigation was done by compiling with /showIncludes to find out why KnownFolders.h was sometimes included, and then find out why it wasn't always. The bug in shlobj_core.h was reported here: https://developercommunity.visualstudio.com/content/problem/162527/shlguidh-is-incorrectly-included-by-shlobj-coreh.html Change-Id: I57f7894a7016704d15d5b02bbcf518b318263db2 Reviewed-on: https://chromium-review.googlesource.com/813017 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#522463}
-
Koji Ishii authored
This patch supports the CSS 'visibility' property in NGTextFragmentPainter, in the same manner as InlineTextBoxPainter. The logic for line break painting is copied, but to be verified when selection is supported in LayoutNGPaintFragments. Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2334fa2af6588257c77cdc26b0f58daf39d48b63 Reviewed-on: https://chromium-review.googlesource.com/810305Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#522462}
-
sczs authored
-Fades in the Contract ToolbarButton after the locationBarContainer has expanded. -Fades in the Toolbar Buttons (Back,Fwd,ToolsMenu,etc.) after the locationBarContainer has contracted. -Theres a delay to fade in the buttonsafter contraction/expansion, just like in the Old Animation. -Fades out the Toolbar Buttons (Back,Fwd,ToolsMenu,etc.) when the locationBarContainer expansion starts. Video: https://drive.google.com/open?id=1Re0-jdXUH11v-KccgKs2dEYX_fJ29Uud Bug: 784592 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I473daf54dffb14a4da24ed58983ef7ab8b4981aa Reviewed-on: https://chromium-review.googlesource.com/809706Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#522461}
-
Danyao Wang authored
This is step 3 to removing _lastRegisteredRequestURL from CRWWebController. This CL has no functional change. Bug: 789993,792515 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia415197025b4b3461fc807602e17063a753c39c1 Reviewed-on: https://chromium-review.googlesource.com/812446 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#522460}
-
Tao Bai authored
Reproduced the crash locally, but it needs a little bit more work to write a test, this patch has fix only, following up patch will add test. Bug: 792327 Change-Id: I76d8dbc51b84b0aca87f09e162fc97d870881ca9 Reviewed-on: https://chromium-review.googlesource.com/813195Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#522459}
-
Louis Romero authored
Bug: 776593 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I41d610437bbc4dda655b988d95c0491ea930871d Reviewed-on: https://chromium-review.googlesource.com/809707 Commit-Queue: Louis Romero <lpromero@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#522458}
-
Ross McIlroy authored
BUG=chromium:782089 Change-Id: Ib2062b2aca231aca5d84dc169821b10bf1a24bcb Reviewed-on: https://chromium-review.googlesource.com/803338Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#522457}
-
Alex Vallée authored
Change-Id: If511b749a2231c6e3c5f500ed574f2229d02e389 Reviewed-on: https://chromium-review.googlesource.com/812325Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alex Vallee <avallee@chromium.org> Cr-Commit-Position: refs/heads/master@{#522456}
-
Amirhossein Simjour authored
Vertical touch distance required to start scrolling is increased from 0.165 to 0.185, and horizontal distance is increased from 0.15 to 0.17. BUG=740001 Change-Id: I9ea9c16052e0ea490de7ecf92f164701554475a3 Reviewed-on: https://chromium-review.googlesource.com/811665Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#522455}
-
Hans Wennborg authored
Recent Clang versions started taking into account that enums are signed on Windows when emitting these warnings. NOTRY=true Bug: 792519 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0fe2646985282b759e3e261a09fa0f1380c98e61 Reviewed-on: https://chromium-review.googlesource.com/813182 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Michael Spang authored
../../chromecast/tracing/tracing_service_main.cc:96:28: error: [chromium-style] Overriding method must be marked with 'override' or 'final'. virtual ~TraceCopyTask() {} ^ override ../../chromecast/tracing/tracing_service_main.cc:96:3: error: [chromium-style] 'virtual' will be redundant; 'override' implies 'virtual'. virtual ~TraceCopyTask() {} ^~~~~~~~ ../../chromecast/tracing/tracing_service_main.cc:181:30: error: [chromium-style] Overriding method must be marked with 'override' or 'final'. virtual ~TraceConnection() {} ^ override ../../chromecast/tracing/tracing_service_main.cc:181:3: error: [chromium-style] 'virtual' will be redundant; 'override' implies 'virtual'. virtual ~TraceConnection() {} ^~~~~~~~ ../../chromecast/tracing/tracing_service_main.cc:339:29: error: [chromium-style] Overriding method must be marked with 'override' or 'final'. virtual ~TracingService() {} ^ override ../../chromecast/tracing/tracing_service_main.cc:339:3: error: [chromium-style] 'virtual' will be redundant; 'override' implies 'virtual'. virtual ~TracingService() {} ^~~~~~~~ 6 errors generated. BUG=b/31079742 Change-Id: I8cc22c845599662e9a6088328933e67cd4ebf490 Reviewed-on: https://chromium-review.googlesource.com/814218 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:Doug Steedman <dougsteed@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#522453}
-
Gauthier Ambard authored
The toolbar needs to update its UI when a snapshot for the side swipe is taken. Bug: 785756 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If1735fe80b575608ed625dda3525a51b1689ee49 Reviewed-on: https://chromium-review.googlesource.com/809155Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#522452}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/5dcbbfd1533b..d73ba12a934e $ git log 5dcbbfd15..d73ba12a9 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5ff0401422873a8d550c97bac0a3ce8c37ff7d06 Reviewed-on: https://chromium-review.googlesource.com/814274Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#522451}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/79bacdd9..744d799d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie4f0d628152e699829771955710ac682c15e9ed9 Reviewed-on: https://chromium-review.googlesource.com/814136Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#522450}
-
Aaron Leventhal authored
When a suggested search match in the omnibox popup has an immediate answer, add this to the friendly accessible screen reader label. For example, typing "weath" will produce something like: "Weather Answer 42 degrees" rather than just "Weather". Bug: 787858 Change-Id: I1a8db6d4c0a77c8f769138325c806cc2959df513 Reviewed-on: https://chromium-review.googlesource.com/809784Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#522449}
-
Yeol authored
TouchPoint radius of the ellipse should exactly equal to half the corresponding extent of the rectangle. assuming non-rotated touch geometry. Bug: 731725 Change-Id: Ibf19c867549f13676afbc6cd0d504850fb415159 Reviewed-on: https://chromium-review.googlesource.com/762827Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#522448}
-
Theresa Wellington authored
Show the Google G when the bottom sheet is opened and the url is cleared. This is hidden behind a flag. BUG=792244 Change-Id: I2768dc0aefce94890260e061baae6930d413415b Reviewed-on: https://chromium-review.googlesource.com/811688Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#522447}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/4f5e1d4ff3fa..9d78afdd3d87 $ git log 4f5e1d4ff..9d78afdd3 --date=short --no-merges --format='%ad %ae %s' 2017-12-07 borenet Revert "[infra] Move commands from isolates to gen_tasks.go" 2017-12-06 herb Fix buffer off-by-one error. 2017-12-07 borenet [infra] Move commands from isolates to gen_tasks.go 2017-12-07 rmistry Do not skip trybots for uploads by update-docs 2017-12-06 benjaminwagner Specify long build ID in Android dimensions. 2017-12-07 bsalomon Revert "Add define to use customize vulkan header." 2017-12-06 scroggo Update to the latest version of libjpeg-turbo Created with: roll-dep src/third_party/skia BUG=792316 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I6b3738c95a764c9efbaefee9a7895cd739a65211 Reviewed-on: https://chromium-review.googlesource.com/814276Reviewed-by:
-
Henrik Grunell authored
An attempt to reduce flakiness, based on that the AEC dump requires longer time before being closed than the input and output recordings due to IPC and more thread jumps. See also the added comment in the file for more info. Bug: 783790 Change-Id: I1f2cd838a749eb1ec76e6e32e283b26e89ff293e Reviewed-on: https://chromium-review.googlesource.com/813715 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#522445}
-
Mohamed Heikal authored
Calling Tab.loadUrl if mNativeTabAndroid is 0 would crash chrome. There has been a few crashes of the sort. This change would make chrome crash on the Java side rather than the native side so that the java stacktrace is visible in the crash. This is a temporary change and will be removed once we have more information or the bug is closed as WontFix. Bug: 662877 Change-Id: I0ad62c757d57c11bc405f6b22fad59f047aad527 Reviewed-on: https://chromium-review.googlesource.com/811987Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#522444}
-
Danyao Wang authored
This is step 3 to removing _lastRegisteredRequestURL from CRWWebController. Bug: 789993,792515 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib3ea5bb686a91e0d28cbb8ec7c1c860518c85090 Reviewed-on: https://chromium-review.googlesource.com/812407 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
-
Pete Williamson authored
Bug: 792290 Change-Id: I2321ae02cd36e54f372e22edd74db2253dbc6e9a Svelte is a term we use for android devices with <= 512MB memory. We used the OfflinePagesSvelte experiment originally to check if we should do background offlining on Svelte devices at all. We determined that we should, and eventually removed the flag in most places (but not here). This change removes the flag in the final place. There is a similarly named experimental flag for doing 'foreground' offlining on svelte devices - "OfflinePagesSvelteConcurrentLoading". We plan to enable it someday, but first we need to fix chromium so that we don't start an additional process. Chromium promises not to start more than two processes on android svelte devices. Change-Id: I2321ae02cd36e54f372e22edd74db2253dbc6e9a Reviewed-on: https://chromium-review.googlesource.com/813014Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#522442}
-
tzik authored
The DCHECK in WebTaskRunner::PostTask used to ensure that a same thread WTF::Function is posted to the original thread. However, after it is merged to base::OnceCallback, it wrongly rejects base::OnceCallback which may be passed through base::SingleThreadTaskRunner::PostTask. This CL removes the DCHECK to prevent the potential failure. The restriction itself is still checked by a callback wrapper made by WTF::Bind. Change-Id: I5b0cf0a6beb3b88a66a1ce89a8df466379cb9c74 Reviewed-on: https://chromium-review.googlesource.com/813574 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#522441}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/7b0be4ced5f3..bb6ecbad918e $ git log 7b0be4ced..bb6ecbad9 --date=short --no-merges --format='%ad %ae %s' 2017-12-07 dsinclair Fix nits from previous CL. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If3c609caec836e5571d6b04f5aa14ad2992ee488 Reviewed-on: https://chromium-review.googlesource.com/814275 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522440}
-
Peter Beverloo authored
Bug: 711529 Change-Id: Id64a48214d682f5feba6f6a5f301b394e4a6ce42 Reviewed-on: https://chromium-review.googlesource.com/806274Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#522439}
-
W. James MacLean authored
At present, the implementation of destroyImpl() in guest_view_iframe.js calls handleCallback() in the *middle* of the function, meaning remaining items in the action queue may complete before destroyImpl() finishes updating the state, leading to subsequent commands being dropped if functions like create/attach encounter the non-updated state. This fixes a regression introduced in https://chromium-review.googlesource.com/c/chromium/src/+/528392. It's not obvious if it introduced any failures, but the original CL bypassed browser tests as extensions/renderer/BUILD.gn was missing the relevant files (restored in https://chromium-review.googlesource.com/c/chromium/src/+/812109). Bug: Change-Id: I83db799b73174d3e996677333e01192bf5321460 Reviewed-on: https://chromium-review.googlesource.com/812005Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#522438}
-
Alexey Kozyatinskiy authored
TBR=dgozman@chromium.org Bug: chromium:655701 Change-Id: I11b1d7d75cc1149cccb97fcb1852ae881c26fd90 Reviewed-on: https://chromium-review.googlesource.com/814277Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#522437}
-
Ian Vollick authored
Renames some functions that are no longer trivial and removes some now redundant calls to SetVisible. Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3dda5dcb9a225077612050a368a154d95468f681 Reviewed-on: https://chromium-review.googlesource.com/809605 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#522436}
-
Dominic Battre authored
Executing the AnonymizerTool is an expensive operation and should not happen on the UI thread. This CL moves all existing calls on the UI thread to spearate worker TaskRunners. Bug: 787554 Change-Id: I3c096873f784cc2a9dd23f9dd538e2aebd075cd0 Reviewed-on: https://chromium-review.googlesource.com/787713 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Simon Que <sque@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#522435}
-
arthursonzogni authored
Before this patch, the navigation initiator/requestor was set too high in the stack to be reliable. There were pieces of code that were trying to guess what the initiator was (and it was wrong sometimes.) This CL wires this data from where is it available to where is is needed. We say that a request has no initiator when the navigation was not initiated from a document, but from the browser (omnibox, bookmarks, ...). Before this CL and without PlzNavigate, if there was no initiator, the initiator was set to request's url. Now, it doesn't. PlzNavigate and non-PlzNavigate initiators are now the same. It fixes a security issue with Cookies (issue 648608). A regression test is added Bug: 648608,625969 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ic23f20590a7cf422e08eefe354ff4057f016a987 Reviewed-on: https://chromium-review.googlesource.com/730729Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#522434}
-
Charles Harrison authored
I've noticed that these can be a bit slow, but the async traces make analysis pretty confusing, due to the linked bug. Bug: 783327 Change-Id: I4d46d715d08ed176bec85b0672b24aab2e2b0022 Reviewed-on: https://chromium-review.googlesource.com/810927Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#522433}
-
Biao She authored
Bug: 792600 Change-Id: I5b49dc226ca27cea0b686d3b118956b18d8ddbd4 Reviewed-on: https://chromium-review.googlesource.com/811837Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#522432}
-
Balazs Engedy authored
EarlyInterfaceRequestsFromNewDocumentDispatchedAfterNavigationFinished in RenderFrameHostImplBrowserTest previously assumed that an interface request issued right away by the newly committed document will be necessarily dispatched before DidStopLoading. This is incorrect: tiny testing documents with no subresources to load might stop loading and send FrameHostMsg_DidStopLoading shortly after the load committed, so RenderFrameHostImpl::OnDidStopLoading might end up being invoked before RemderFrameHostImpl::GetInterface is. TBR=nasko@chromium.org Bug: 792863, 729021 Change-Id: I6a631e7e996480fcfd148a54faa8a977386d9e03 Reviewed-on: https://chromium-review.googlesource.com/814096Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#522431}
-
Sylvain Defresne authored
The GetDefaultFactory return a factory that can create instance as the default factory does. It can be used by factories when default is to not create the instance for test BrowserStates. Bug: none Change-Id: I02192ff82e16748eb8f7b69a4c482b3589527b5b Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/811085Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#522430}
-
Anita Woodruff authored
- When run with --enable-blink-features=NotificationsWithMojo, notification-showing now goes through Mojo. - Tested manually that a notification with the expected origin and title displays when a non-persistent notification is shown. - All other notification data still needs to be hooked up. - Notification events are also not yet implemented, so this patch updates the virtual TestExpectations to skip these/expect timeouts. Bug: 595685 Change-Id: I3f74f0f434db1e639da1b753554e7c4776b58448 Reviewed-on: https://chromium-review.googlesource.com/788153 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#522429}
-
Marc Treib authored
With this, no checksum is required for config.js anymore, which fixes a race condition between serving the checksum and serving the contents themselves. It also lets us remove quite a lot of plumbing :) Bug: 792490, 791969 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I609ef274325bddb49bcbe6e90d58d35b7a385920 Reviewed-on: https://chromium-review.googlesource.com/811185 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#522428}
-
Juan Antonio Navarro Pérez authored
This reverts commit 57425308. Reason for revert: Speculative revert to fix issue 792868. Original change's description: > Add Chrome Policy Blacklist support for Network Service > > In this CL, we create a new implementation of NavigationThrottle, called > PolicyBlacklistNavigationThrottle in which we call into a > policy::URLBlacklistManager implementation during calls to WillStartRequest(). > If the requested URL is in the blocklist, we’d return CANCEL otherwise PROCEED. > > This CL also introduces a KeyedService for accessing the > policy::URLBlacklistManager. > > Bug: 756642 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation > Change-Id: I2d9ca0982e78b03be191b67e61eea14764150e68 > Reviewed-on: https://chromium-review.googlesource.com/745326 > Commit-Queue: Doug Turner <dougt@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522268} TBR=pastarmovj@chromium.org,nasko@chromium.org,jam@chromium.org,boliu@chromium.org,rockot@chromium.org,clamy@chromium.org,dougt@chromium.org,cjennyc28@gmail.com Change-Id: I09dad40ad0dffa4cf7accfc0cd2dbb722b1c651b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 756642, 792868 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/814394Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#522427}
-
Robert Sesek authored
- "ax_tree_error" - "ax_tree_update" - "bad_message_reason" - "font_key_name" - "input-event-filter-send-failure" - "mojo-message-error" - "ppapi_path" - "text-input-context-client" Bug: 598854 Change-Id: Ia5d033e828ffb4341d43085a906551bb1c354e62 Reviewed-on: https://chromium-review.googlesource.com/811896Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#522426}
-
