- 26 May, 2020 40 commits
-
-
Navid Zolghadr authored
This patch cleans up the early long press activation that so far can only be caused by a stylus button on CrOS with clear conditions. It adds the according checks to the logic to only run it for stylus pointers. So it should have no functional change. This helps to add a similar mechanism for touch pointers on Android in the later patches. Bug: 1086263 Change-Id: I0a4c5a802505ac22b6186b88d343143472850d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216310Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771870}
-
danakj authored
Pointer locking is a property of the widget, not a specific frame, nor the process. So we move it to the EventSender which is the per-widget web test javascript interface. This removes the last usage of TestRunnerForSpecificView, and we remove the class and all pointers to it. The pointer lock implementation is made a bit more clear and robust, tracking the state of pending locks/unlocks, as well as the final locked state. We use the default task runner, as these actions are tied to the widget and IPC, rather than to the requesting frame. R=avi@chromium.org TBR=dcheng Bug: 866140, 1069111 Change-Id: I90e6bfd336b4647fdead185012bf9b84b6617af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212928 Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771869}
-
haozhe authored
By adding a type check for the sample interpolation, we handle the InvalidtableInterpolation type. Bug: 1084688, 1086167 Change-Id: Ifd2d04bdd298d239813c9f87772efdfcba9b227c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210678Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#771868}
-
James Cook authored
SplitSettingsSync sometimes makes an untitled Play Store icon appear in the shelf due to app pin syncing code. This doesn't happen in production, but causes test failures in: ArcUserSessionServiceTest.FiresIntentOnSessionActiveTest AutotestPrivateApiTest.AutotestPrivate Pinned app sync isn't relevant to these tests, so skip it. Do this with a global because ChromeLauncherController initialization happens before the test runs SetUpOnMainThread(). Bug: 1085597 Change-Id: Iebd4e299872f1e79bdd388253256f1d7cec0dd23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212931 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#771867}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 1 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-11-22. TBR=chromium-metrics-reviews@google.com Change-Id: I919739afc43d4a2f4cbae9b28cc308a35bb5d1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212393Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#771866}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590494094-4933e9898781e7babab5bec8654610960e408cf7.profdata to chrome-win32-master-1590508570-0988b56e609cb55046e696ff8ca55766d5b1565c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I8a6462ffac6a46ea5602c57bc4d924e1bae0c865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216450Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771865}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590465515-28d774c5c7210687b1a5c5f3f06bd85a638d1e44.profdata to chrome-win64-master-1590508570-56b410f167fcfdeb6392e467837742983549ce30.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I268bcd3ab819f31efa46328e041d88318c61fe76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216451Reviewed-by:
-
Christian Biesinger authored
With a fixed-height single-line flex container, a stretched item should be considered to have a definite height and thus should have its aspect-ratio calculated from that: https://drafts.csswg.org/css-flexbox/#definite-sizes item 1 This patch limits this behavior to the CSS aspect-ratio property for now (as opposed to supporting it for everything with an aspect ratio, like images), to limit the behavior differences from pre-FlexNG Blink. Bug: 1083020 Change-Id: I2abe33d49a8727857a28e47ba6344ad3da860cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212984 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771863}
-
Nate Chapin authored
In cases where the LocalDOMWindow* is what we want, or where we just need to null-check the frame, use dom_window_ instead of frame_. All others now call GetFrame(). Bug: 1080735 Change-Id: Ib6b37e16f05d675e19212c38e474d5ad56e4c182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212782Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#771862}
-
Sophie Chang authored
Change-Id: I4e8a1ecf01a65a146ce4c35a16d277696cd1fb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216038 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#771861}
-
Jeff Yoon authored
MB configs for the beta/stable trybots for PGO. Missed tryserver definition. Bug: 1081356,1085606 Change-Id: Ib17b5cab291ac9cbf8769c3622cb2793a60e584e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214002 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#771860}
-
Scott Violet authored
As the renderer normally drives the offsets, once the renderer is hung that won't happen. BUG=1083513 TEST=still working out Change-Id: I866f6cedc28c5b617b74f070382a571c4b6897a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211066Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#771859}
-
Philip Rogers authored
This patch adds a feature flag for respecting the MacOS subpixel anti-aliasing setting (called "LCD text" in chromium). MacOS 10.14 (Mojave) disabled LCD text by default and, by respecting this setting, scrolling performance can be improved. This is because composited scrolling no longer needs to be avoided for the purposes of maintaining LCD text, which is lost in the common case where the scrolling contents layer is not fully opaque (see [1] for details of this). The MacOS setting for LCD text can be controlled with: defaults write -g CGFontRenderingFontSmoothingDisabled -bool true ("true" is default, "false" overrides this). This patch uses a private API, CGFontRenderingGetFontSmoothingDisabled, which is used by Safari (see: https://trac.webkit.org/changeset/239306/webkit). Enabling this feature will expose the differences of composited scrolling which include minor pixel differences, less-minor stacking differences (the fundamental compositing bug: crbug.com/370604), as well as a few bugs. These differences are already present on all devices with device pixel ratios >= 1.5 (50% of MacOS), as well as Android and ChromeOS platforms which force-enable prefer-compositing-to-lcd-text. The web_test changes can be seen in the Mac10.14 trybot results at https://crrev.com/c/2207413/1. These have been triaged and non-rebaseline differences have been broken out as bugs blocking crbug.com/1079418. This patch does not enable the feature by default but a followup will, which will include these baseline updates. We have UMA data from the PreferCompositingToLCDText experiment that should match the effect of this feature for users that have not enabled LCD text via the command line: Event.Latency.ScrollUpdate.Wheel.TimeToScrollUpdateSwapBegin4 95th: -5%, 99th: -12% EventLatency.GestureScrollUpdate.Wheel.TotalLatency 95th: -6%, 99th: -14% https://uma.googleplex.com/p/chrome/variations/?sid=a8cb2e0aa29593ad35baa33a2bee3f97 [1] Excellent explanation of why compositing forces greyscale AA: https://gankra.github.io/blah/text-hates-you/#subpixel-aa-isnt-composable Bug: 1079418 Change-Id: Ieca837912ec19f7a7b4378b989d86a4242108668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207413Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
David Lechner authored
The "type" option of the GATT Characteristic.WriteValue method was actually introduced in BlueZ v5.51 (as can be seen in the link below). https://github.com/bluez/bluez/commit/aa9f9b193c51d371b5d2a863f35a034ee0377b22 Change-Id: I0f7513582d91c98446d06148d1edbe9e2502ee44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214411Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#771857}
-
Adam Langley authored
These strings appear in log messages, so nicer to avoid raw binary. Change-Id: Ide8b6bcbd57b8cec5d123a974243e74b2b40e511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214461 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#771856}
-
Michael Thiessen authored
Changes the test runner to add a status report to each test, reporting the duration in ms of the test. I've chosen to account for the overhead of starting instrumentation, etc. by adding the overhead duration to the runtime of the first test in the batch. This means that one unlucky test in the batch will seem really slow from looking at reported durations, but means the overall duration for the batch will be correct. See bot results for android-marshmallow-arm64-rel, chrome_public_test_apk, org.chromium.components.external_intents.ExternalNavigationHandlerTest to see what this looks like in practice. Bug: 989569 Change-Id: I93aae5e52ea51bb635bb13ce6b6db6e4e8bb55ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212491 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#771855}
-
Leonard Grey authored
On 10.12, the window server is fine initiating a drag without this, so we end up with two drags starting. This actually doesn't fix the teleporting windows bug, but it can't help! Bug: 897274 Change-Id: I2e181659c504c90db0a0928747f5485419728fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207980Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590494094-23904e540b881376a708d1584e8efd523290bbdf.profdata to chrome-mac-master-1590508570-a99506fab2213a01c13861c108d98c27cee7cc0b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae36f2b55da219314881fe9359e0c11b6c02522f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216363Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0638b6b9527b..ba4e2b94289d 2020-05-26 msisov@igalia.com Type cast EGLNativeDisplayType to _XDisplay* in xcb and glx If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1084458 Tbr: ynovikov@google.com Change-Id: I7fe7d6417459eda95981c6818a318acd9f0bd359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216168Reviewed-by:
-
Peng Huang authored
Looks like the crash in https://crbug.com/1086428 is because GrContext is not initialized successfully, and then we are accessing the nullptr GrContext, and then segment fault happens. Fix the problem by making GetSharedContextState() return nullptr if GrContext cannot be initialized. Bug: 1086428 Change-Id: I288fc6832d6b0c838e16c119354e50db2ad2af80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214912 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771851}
-
jorgegil@google.com authored
Fixes issue where occlusion tracking could start sending updates before the surface state had been committed. In ARC, this meant that occlusion updates were sent before the surface bounds were first set, leading to incorrect "full occlusion (1.0f) updates". Bug: b:149229321 Test: exo_unittests Change-Id: Ia885a44cf38658cc82d87273f70395c8bc2fcf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212921 Commit-Queue: Jorge Gil <jorgegil@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#771850}
-
Yury Semikhatsky authored
This reverts commit c6d15649. Reason for revert: the problem with gmail offline service workers mentioned in the bug has been fixed by http://crrev.com/c/2213550 and http://crrev.com/c/2213783. Bug: 1085150 Original change's description: > Revert "[DevTools] Properly notify devtools agent host when service worker is destroyed" > > This reverts commit 1537d629. > > Reason for revert: potentially breaks gmail reloading when disabling offline mode with DevTools open. > > Bug: 1085150 > > Original change's description: > > [DevTools] Properly notify devtools agent host when service worker is destroyed > > > > ServiceWorkerDevToolsAgentHost now stores thread-safe reference to > > ServiceWorkerContextWrapper instead of ServiceWorkerContextCore that > > could be deleted asynchronously on the service worker core thread. > > > > WorkerDestroyed notification is now sent to the observers of > > ServiceWorkerDevToolsManager iff the worker version is both stopped > > and doomed. Each worker can be terminated (and restarted) multiple times > > and will result in a sequence of targetCrashed/targetReloadedAfterCrash > > events in the protocol but the instance of its > > ServiceWorkerDevToolsAgentHost will survive restarts and all connected > > sessions will be preserved. > > > > It fixes the events generated in the protocol for service workers from > > targetCreated, (detachedFromTarget, attachedToTarget, targetReloadedAfterCrash)* to > > targetCreated, (targetCrashed/targetReloadedAfterCrash)*, targetDestroyed > > and avoids inadvertent session terminations when workers are stopped and > > also spurious targetReloadedAfterCrash events. > > > > Bug: none > > Change-Id: I1125604d08b7842f7f8d74751091193b9af2cb59 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099590 > > Commit-Queue: Yury Semikhatsky <yurys@chromium.org> > > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#750975} > > TBR=dgozman@chromium.org,horo@chromium.org,caseq@chromium.org,yurys@chromium.org,einbinder@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: none > Change-Id: Ibba7ce840b8c8b73c32086d141005306591e21cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213448 > Reviewed-by: Yury Semikhatsky <yurys@chromium.org> > Commit-Queue: Yury Semikhatsky <yurys@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771365} TBR=dgozman@chromium.org,horo@chromium.org,caseq@chromium.org,yurys@chromium.org,einbinder@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1085150, none Change-Id: I7afbb1f53a4940f931ad0722b52da3b307223663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213817Reviewed-by:
Yury Semikhatsky <yurys@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#771849}
-
manuk authored
Follow up on crrev.com/c/2108780. Bug: 1062446 Change-Id: I742fdc3b8314bb717cde70e2d261b6fdb21b3936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213125Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#771848}
-
Bo Liu authored
The code is also incorrect as it skips checking other states. Bug: 1084500 Change-Id: I44ef55b2c47fca901e9c6f52e5cc07834aa858d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215405Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771847}
-
Andrew Grieve authored
It was getting the package name from --apk-under-test, but for smoke tests the apk-under-test != targetPackage. Bug: None Change-Id: I39989b3417d3cdc9320d0231c2b78a3dadb19744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216031 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#771846}
-
Gabriel Charette authored
This is preventing the migration of callers that use BrowserTaskTraits specific traits when invoking GetUIThreadTaskRunner() @ https://chromium-review.googlesource.com/c/chromium/src/+/2211138/8 R=altimin@chromium.org Bug: 1026641 Change-Id: I098daf92d861447049315332f42d2d53fae15d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212992Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#771845}
-
Liviu Tinta authored
The tests in pointer_lock_browsertest.cc were flaky for 3 reasons: - requestPointerLock being asynchronous - mouse events being asynchronous - native mouse events interfering with tests during execution All the above were addressed in prior CLs. Bug: 766450 Change-Id: Ic046bce6c81a9bcc8d1f78a5c56506ed959b45ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213202Reviewed-by:
-
Kush Sinha authored
Add metrics to identify the source of account additions and re-auth on Chrome OS. Bug: 1082780 Test: Manually Change-Id: I1f3df57f5b5ef3c731f75156e61992812c7f78b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214531 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#771843}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/7d2f8c57ee3e..b4a735cc1ada 2020-05-26 rharrison@google.com Rolling 4 dependencies and expectations (#1074) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I3bde52413d9ccaac13bc450cdba02570ed204dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216161Reviewed-by:
-
Jan Krcal authored
This CL breaks down previously reported failures per data type into particular call sites of ReportError(). Bug: 1080844 Change-Id: I9f30f6981a772b414926c97a2a5c499061565b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212276 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#771841}
-
Raphael Kubo da Costa authored
Follow-up to commit 701cae5d ("Introduce a function to format a DER-encoded SPKI for UI"). That is the format used by other files that include <certt.h>, and the pkg-config configuration already passes -I/path/to/nss to the compiler. This can potentially fix the non-sysroot build, as the NSS headers might be installed in e.g. /usr/include/nss3 rather than /usr/include/nss. Change-Id: I0461a7a7f8c93459f2281ea71c96434a74687ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214390 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#771840}
-
Victor Hugo Vianna Silva authored
This CL introduces the functionality for the cancel button in the new PasswordSaveUnsyncedCredentialsLocallyView. Clicking the button clears the unsynced credentials stored in ManagePasswordsState, closes the bubble and moves the password manager UI to the INACTIVE_STATE. Bug: 1060132 Change-Id: Ide4dac9bf653671f43c67ba9fd92d3feead4b2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216210 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771839}
-
Tomas Popela authored
The main reason for the flag is so called dialog hell, when you try to share the screen on Wayland through PipeWire. To address it we've created two changes, that are currently under review[0][1]. Once that's done the flag could be removed. [0] - https://webrtc-review.googlesource.com/c/src/+/160649 [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1942327 Bug: 682122 Change-Id: Ida77d4c8c16250201ae2b9f27e687325f4fcdd46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214885 Auto-Submit: Tomáš Popela <tomas.popela@gmail.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Sadrul Habib Chowdhury authored
When wheel-events are dispatched to the renderer to perform a scroll, it can start a compositor-driven animation to perform the scroll. The animation can continue even after the event-dispatch completes. As a result, for a synthesized scroll, when the request for WaitForInputProcessed() returns to the browser, not all of the desired scrolls may have taken effect. To fix this, introduce a notification API in LayerTreeHost for when any ongoing scroll animation ends. Use this API to ensure all scroll-animations drive by the compositor are complete before returning from a WaitForInputProcessed() request. BUG=1085891 Change-Id: Ie4d67df69786cd30da7d830fa3f952967f1399be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213401Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#771837}
-
Fredrik Söderqvist authored
With the current setup, SVGEnumerationBase is where the actual enumeration is stored, while SVGEnumeration<Enum> is a layer added to provide some type-safety. With the current implementation of this, we require a Clone() implementation in the "type-safe accessor(s)" to produce a copy of a specific derived class. This is a circular self-dependency though (add a specific vtable so that we can produce instances with that specific vtable) since all the actual data that needs to cloned exists in the SVGEnumerationBase class. Hence we can move the Clone() implementation up the class hierarchy and strip SVGEnumeration of anything that would end producing a specific vtable for it. This essentially leaves SVGEnumeration as thin shim for enumeration <-> (ordinal) value mapping. Because there (after some preparatory CLs) are very few accesses left that are done via the "type-safe accessor", just merge it into SVGEnumerationBase and drop the "Base" suffix. This weakens the type- safety guarantees a little bit in theory, but in practice the majority of all enumeration accesses are done via SVGAnimatedEnumeration - which retains the enumeration type binding. This gets rid of all the virtually (no pun intended) identical Clone() implementations of the various SVGEnumeration<Enum> instantiations. Change-Id: I9790fc153bf819a7c9623ff01e287c3c70ec27ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204181 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771836}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4b342721d088..b9e90b03da08 2020-05-26 tvanderlippe@chromium.org Typecheck sdk/LayerTreeBase.js with TypeScript 2020-05-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-05-26 patrick.brosset@microsoft.com DevTools: Introducing a new e2e test for the Changes panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1079076,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5cfa58abc25d016faaca6e492dfe078cd883a270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216153Reviewed-by:
-
Timothy Gu authored
They will be used to test the font fallback behavior of emojis. Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.10-blink-rel;luci.chromium.try:mac10.11-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:mac10.14-blink-rel;luci.chromium.try:mac10.15-blink-rel;luci.chromium.try:win7-blink-rel;luci.chromium.try:win10-blink-rel Bug: 767754 Change-Id: I8be099e5e73edb364a3e4f6deb4ba1c93991b0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209991Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771834}
-
Maksim Sisov authored
Bug: 1085806 Change-Id: I23b46e0ba663a9eef7539050ce8c6998fa3fb70c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214898 Auto-Submit: Maksim Sisov <msisov@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Tina Wang authored
- This CL patches https://chromium-review.googlesource.com/c/experimental/chromium/src/+/2194583 from experimental branch. - Put the change behind a flag. Bug: 1082044 Change-Id: I9a7cb72f529d10558e0bc7cd3da5c2e7877f9676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211082 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#771832}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/31001a610da6..c33eeab2ca42 2020-05-26 jianjun.zhu@intel.com Fix an incorrect use of iterator. 2020-05-26 courtneyfe@chromium.org Add INSTANTIATE_TEST_SUITE_P as needed. 2020-05-26 philipp.hancke@googlemail.com build: remove WEBRTC_CODEC_RED If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9ce0e1b851452b6ddbd0757ae75b2514449b2a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216160Reviewed-by:
-
