GitLab

This change decreases our APK size by 67,065 bytes.

R=newt@chromium.org
TBR=tedchoc@chromium.org
BUG=407781

Review URL: https://codereview.chromium.org/889683002

Cr-Commit-Position: refs/heads/master@{#313764}

This fixes the linux_chromium_chromeos_ozone_rel_ng bot:

../../content/common/gpu/media/rendering_helper.cc:105:31: error: [chromium-style] Overriding method must be marked with 'override' or 'final'.
  virtual ~StubOzoneDelegate() {}
                              ^
                               override

TBR=posciak (red build)
NOTRY=true
BUG=none
TEST=linux_chromium_chromeos_ozone_rel_ng trybot

Review URL: https://codereview.chromium.org/875573004

Cr-Commit-Position: refs/heads/master@{#313763}

BUG=449748

Review URL: https://codereview.chromium.org/869073004

Cr-Commit-Position: refs/heads/master@{#313762}

When rendering in Ganesh with MSAA enabled, request that skia flush each
canvas after drawing a tile. This will cause the MSAA render targets
to be resolved to the shared texture which CC subsequently draws.

BUG=

Review URL: https://codereview.chromium.org/885883002

Cr-Commit-Position: refs/heads/master@{#313761}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5d8388b..5444393

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/880983004

Cr-Commit-Position: refs/heads/master@{#313760}

This moves the "trusted plugin" code so that all the NaCl
renderer-side code is in the same place, under
components/nacl/renderer/.  I've used the "renderer/plugin/" subdir so
that this legacy code is distinguished from the newer code that's
directly under "renderer/".

This will make further incremental cleanups easier: It will enable
closer integration between renderer/* and renderer/plugin/*.  Rather
than indirecting through PPB_NaCl_Private/PPP_PexeStreamHandler, it
would be reasonable for the two sides to share pointers to C++
objects.  Doing that will be more acceptable when the two sides live
in the same directory.

 * chrome/chrome_tests.gypi: Declaring a runtime dependency isn't
   necessary since the trusted plugin isn't a separate DSO/DLL these
   days.

 * .gitignore: Remove reference to ppGoogleNaClPluginChrome.xml, which
   no longer exists.

 * module_ppapi.h: Added an #include guard.

BUG=239656
TEST=trybots

Review URL: https://codereview.chromium.org/876483002

Cr-Commit-Position: refs/heads/master@{#313759}

BUG=453313
TBR=huangs@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/884013004

Cr-Commit-Position: refs/heads/master@{#313758}

r2029: mac: Followup to ZERO_AR_DATE, touch the -o archive, rather than expecting only one

TBR=thakis@chromium.org
BUG=342974,451499

Review URL: https://codereview.chromium.org/887753002

Cr-Commit-Position: refs/heads/master@{#313757}

Simple test that uploads and draws a texture on an offscreen surface.
The upload/draw code is run multiple times, timings are collected and the
average elapsed milliseconds are printed out using the perf_test framework.

The test target has not been added to the perf tests the are automatically run yet
and has to be manually run.

BUG=423481

Review URL: https://codereview.chromium.org/871093002

Cr-Commit-Position: refs/heads/master@{#313756}

BUG=453485
TBR=rouslan@chromium.org

Review URL: https://codereview.chromium.org/871193007

Cr-Commit-Position: refs/heads/master@{#313755}

* In order to sort out dependencies between initialization of components, I am doing work only when I have a valid GCM connection going (this means all the infrastructure is up and running).
* I am also making sure that time to next token reporting is always between 0 and 12 hours.

BUG=453018

Review URL: https://codereview.chromium.org/885753002

Cr-Commit-Position: refs/heads/master@{#313754}

BUG=440579
TBR=thakis

Review URL: https://codereview.chromium.org/867483008

Cr-Commit-Position: refs/heads/master@{#313753}

Enhance the audio player tests to cover multiple loops over the data and
odd sizes of data.

R=ckehoe@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/886593005

Cr-Commit-Position: refs/heads/master@{#313752}

We are removing SkProxyCanvas, which is a subset of SkNWayCanvas.

BUG=skia:3279

Review URL: https://codereview.chromium.org/876933005

Cr-Commit-Position: refs/heads/master@{#313751}

BUG=

Review URL: https://codereview.chromium.org/887453002

Cr-Commit-Position: refs/heads/master@{#313750}

This CL also includes a small refactoring of the desktop- vs. app-remoting split.

BUG=432361

Review URL: https://codereview.chromium.org/875583002

Cr-Commit-Position: refs/heads/master@{#313749}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e9d57a2..7020f55

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/892483002

Cr-Commit-Position: refs/heads/master@{#313748}

Review URL: https://codereview.chromium.org/850853002

Cr-Commit-Position: refs/heads/master@{#313747}

On Android, instead of calling StartRepeatedVariationsSeedFetch()
in chrome_browser_main.cc, this changes the code to instead have
that be called by the first call to OnAppEnterForeground().

This will allow (in a future change) to have the caller of
OnAppEnterForeground() to first set the restrict mode param,
before fetching gets initialized. (Otherwise, fetching was
being initialized too early before the param could be set.)

BUG=452605

Review URL: https://codereview.chromium.org/880263005

Cr-Commit-Position: refs/heads/master@{#313746}

R=dgozman
TBR=nasko

BUG=451004

Review URL: https://codereview.chromium.org/884873004

Cr-Commit-Position: refs/heads/master@{#313745}

The mac toolbar redesign has been implemented to the point where this test can
be cross-platform.  Move it to be so.

BUG=429810
BUG=422381

TBR=sky@chromium.org (moving a file)

Review URL: https://codereview.chromium.org/884473006

Cr-Commit-Position: refs/heads/master@{#313744}

BUG=448790
TBR=phajdan

Review URL: https://codereview.chromium.org/882823006

Cr-Commit-Position: refs/heads/master@{#313743}

Also try to fix old entries when possible and play nice with older
versions

BUG=450589
R=mkwst@chromium.org,marja@chromium.org,atwilson@chromium.org

Review URL: https://codereview.chromium.org/869613006

Cr-Commit-Position: refs/heads/master@{#313742}

libvpx/VP8 currently allows resizing upward but will crash on codec
teardown in that case; these tests ensure we don't regress when we
remove the workarounds in VideoEncoderVpx.

BUG=134202

Review URL: https://codereview.chromium.org/866533004

Cr-Commit-Position: refs/heads/master@{#313741}

TopSites prepopulated pages are not injected by the embedder via the
TopSitesFactory. The method TopSites::GetPrepopulatedSites() now does return
the sites favicon, thumbnail and color in addition to the URL and title.

TopSitesImplTest now can inject prepopulated pages to the TopSitesImpl thus
enabling the test TopSitesImplTest.BlacklistingWithPrepopulated on Android.

Change TopSites so that it does not inherit from content::NotificationObserver
as it does not need to listen to notification and move the inheritance to
TopSitesImpl (until the code is changed to use observer pattern instead of
notifications).

Remove dependency of TopSitesBackend on content::BrowserThread by injecting a
base::SingleThreadedTaskRunner reference to the corresponding thread via the
TopSitesImpl::Init() method.

Introduce //components/test/data/history and move pristine SQL files used by
the different unit tests there, helping remove dependency of the unit tests
on //chrome.

Move top_sites.{cc,h}, top_sites_database.{cc,h} into
//components/history/core/browser.

BUG=380144, 380157
TBR=sky, dgozman, samarth

Review URL: https://codereview.chromium.org/870063002

Cr-Commit-Position: refs/heads/master@{#313740}

This patch should make the main thread more responsive when the user
is interacting with the device while the page is loading.

Sherrifs if you see an uptick in blink layout test flakes this patch
might be to blame.

I tried to reproduce the flakes I saw in the try runs locally.
With the exception of fast/loader/subframe-removes-itself.html
I was not able to reproduce a flake, however judging by the flakiness
dashboard, that test is already slightly flaky.

BUG=391005

Review URL: https://codereview.chromium.org/882073002

Cr-Commit-Position: refs/heads/master@{#313739}

This is a follow-up fix for:
https://crrev.com/90b41f569db5cff7a8b8d170b81516dd006f57ba

R=wfh@chromium.org
BUG=438157

Review URL: https://codereview.chromium.org/890643002

Cr-Commit-Position: refs/heads/master@{#313738}

Android 5.x does not allow running the gdb executable in
/data/local/tmp. For gdb to be executable by the package
it need to be located in /data/data/{PACKAGE-NAME} which is
allowed to run the exucutable.

BUG=453379

Review URL: https://codereview.chromium.org/884993003

Cr-Commit-Position: refs/heads/master@{#313737}

Review URL: https://codereview.chromium.org/886483005

Cr-Commit-Position: refs/heads/master@{#313736}

Instead of logging full exception we log only message.

R=vabr@chromium.org
BUG=435249

Review URL: https://codereview.chromium.org/889453006

Cr-Commit-Position: refs/heads/master@{#313735}

-[TabView drawRect:] was called repeatedly to unnecessarily update the glow
that is not changing or should not have changed.

1. Selected tabs don't have glow, so don't redraw on mouseMoved.

2. When dragging an unselected tab, the mouse point relative to the tab view
does not change, so no need to redraw the glow.

3. When a dragged unselected tab slides behind another tab, let the dragged tab
keep the glow instead of the tab in front of it (this is a behavior change).
I think this is the more correct behavior, and we never have to redraw tabs
while dragging.

BUG=452925

Review URL: https://codereview.chromium.org/882193003

Cr-Commit-Position: refs/heads/master@{#313734}

When removing copy requests from a LayerImpl to fulfill the request,
this changes the RenderSurfaceLayerList that CalculateDrawProperties
would output. In particular, the layer would no longer keep itself as a
render target.

Since we fail to do this, the layer becomes !HasCopyRequest(), but keeps
itself as a target in the RenderSurfaceLayerList. Then when we go to
draw again (due to an animation or the like?) we skip appending the
layer's RenderPass since the subtree is hidden, but the layer is still
in the RenderSurfaceLayerList because we didn't recompute draw properties
and the layer copy request was keeping the hidden layer in the list.

This cognitive dissonance causes us to use a null RenderPass as
the target_render_pass in CalculateRenderPasses, which causes a crash as
soon as the (hidden) layer tries to append quads to the null surface.

R=vmpstr, weiliangc@chromium.org
BUG=439649

Review URL: https://codereview.chromium.org/883123003

Cr-Commit-Position: refs/heads/master@{#313733}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c7f8106..e9d57a2

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/891473003

Cr-Commit-Position: refs/heads/master@{#313732}

Move the "is popup showing" logic to the platform-agnostic
ExtensionActionViewController. This lets us:
- Have a slimmer platform delegate.
- Implement OnPopupShown/Closed pressed-state logic on mac.
- Add cross-platform popup browsertests.

BUG=429810
BUG=422381

TBR=sky@chromium.org (micro changes to page_action_image_view)

Review URL: https://codereview.chromium.org/869873008

Cr-Commit-Position: refs/heads/master@{#313731}

Since the toolbar frame now includes the proper padding,
icons are a little too eager to show after adjusting the
chevron.  Make them a bit more shy again (hide them if they
have >= 3px not displayed when adjusting the toolbar).

BUG=452475

Review URL: https://codereview.chromium.org/881573004

Cr-Commit-Position: refs/heads/master@{#313730}

Update HTMLViewer for de-clienting of Shell.

Update ServiceRegistryTest.java for de-clienting of MathCalculator.

NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/883843002

Cr-Commit-Position: refs/heads/master@{#313729}

This removes CrMallocErrorBreak, since in 64-bit mode, Libc's malloc already
makes this case fatal.

BUG=453141
R=mark@chromium.org

Review URL: https://codereview.chromium.org/889583003

Cr-Commit-Position: refs/heads/master@{#313728}

BUG=433787

Review URL: https://codereview.chromium.org/869073003

Cr-Commit-Position: refs/heads/master@{#313727}

Chrome OS needs a dependency on //components/onc

BUG=453451
TEST=compiles
NOTRY=true

Review URL: https://codereview.chromium.org/880393004

Cr-Commit-Position: refs/heads/master@{#313726}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/402448d..5d8388b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/890533003

Cr-Commit-Position: refs/heads/master@{#313725}