GitLab

Following https://codereview.chromium.org/171383002/ BisonCSSParser::parseMediaQueryList is no longer used. This CL removes that unused code.

BUG=

Review URL: https://codereview.chromium.org/201573006

git-svn-id: svn://svn.chromium.org/blink/trunk@169808 bbb929c8-8fbe-4397-9dbb-9b2b20218538

That CL caused a bunch of crashes (see referenced bug). This CL contains a
manual partial revert of that CL, which will hopefully fix the crashes.

TBR=eseidel@chromium.org
BUG=355262

Review URL: https://codereview.chromium.org/209473002

git-svn-id: svn://svn.chromium.org/blink/trunk@169807 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=japhet

BUG=355274

Review URL: https://codereview.chromium.org/208393009

git-svn-id: svn://svn.chromium.org/blink/trunk@169806 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We already had code to handle this case, which is shared
by editing as well as HTMLElement::setInnerText.
However that code (replaceChildrenWithText) appears to
be both wrong and unsafe (modifies existing text nodes
without checking if they're shared or not), so I chose
not to re-use it for now.

This was originally committed as:
https://src.chromium.org/viewvc/blink?view=rev&revision=169394
using replaceChildrenWithText, but was rolled out for
breaking a zillion tests. This version does not use
replaceChildrenWithText.
BUG=352836
R=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/200763006

git-svn-id: svn://svn.chromium.org/blink/trunk@169805 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/206413004

git-svn-id: svn://svn.chromium.org/blink/trunk@169804 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per the specification, the iframe's name should be an empty string if unset:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-name

Instead, Chromium was using the iframe's id as window name if the name was
unset. This change makes us behave like Firefox 27 and IE 11, verified using:
http://jsfiddle.net/xf5H7/9/

This CL sets the name attribute iframe in a lot of layout tests so that
testRunner.dumpChildFramesAsText() keeps printing the same result.

R=arv@chromium.org, tkent@chromium.org
BUG=347169
TEST=fast/frames/iframe-no-name.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168553

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168801

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169304

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169683

Review URL: https://codereview.chromium.org/187103002

git-svn-id: svn://svn.chromium.org/blink/trunk@169803 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following the review of https://codereview.chromium.org/209443002/ , I've changed the unitTable access method to be a static CSSPrimitiveValue::fromName method.

BUG=

Review URL: https://codereview.chromium.org/209443003

git-svn-id: svn://svn.chromium.org/blink/trunk@169802 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since MediaQueryExp::create returns a nullptr when the input string is not a valid media feature,
I've renamed it to createIfValid.

BUG=

Review URL: https://codereview.chromium.org/209443002

git-svn-id: svn://svn.chromium.org/blink/trunk@169801 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Expand use of WidthCache to apply to all complex text width queries.
It'll still bail out for queries where the GlyphOverflow bounds are
needed.

BUG=347186
R=dominik.rottsches@intel.com

Review URL: https://codereview.chromium.org/206793005

git-svn-id: svn://svn.chromium.org/blink/trunk@169800 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We were blocking tag, id and class from matching when put before :host, but were
not correctly stopping things like :first-child:host or *:host.

Instead of trying to black list selectors we need to whitelist :host and
:ancestor as being special.

It turns out we did have test coverage for this, but the expected results were
all wrong so it printed PASS even though we were failing what the test was
supposed to be testing.

BUG=355149, 355158

Review URL: https://codereview.chromium.org/208933006

git-svn-id: svn://svn.chromium.org/blink/trunk@169799 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CSS2.1 is now clear about what to do if the collapsed margins are
greater than the offset required to clear a float.

"Computing the clearance of an element on which 'clear' is set is done
by first determining the hypothetical position of the element's top
border edge. This position is where the actual top border edge would
have been if the element's 'clear' property had been 'none'. If this
hypothetical position of the element's top border edge is not past
the relevant floats, then clearance [..] is set to the greater of:
The amount necessary to place the border edge of the block even with
the bottom outer edge of the lowest float that is to be cleared. [or]
The amount necessary to place the top border edge of the block at
its hypothetical position."

http://www.w3.org/TR/CSS2/visuren.html#clearance


BUG=

Review URL: https://codereview.chromium.org/195743002

git-svn-id: svn://svn.chromium.org/blink/trunk@169798 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is done in order to get the origin and WebFrame needed to create the
CDM. This is now similar to how WebMediaPlayer is created. This change adds
a Page supplement for MediaKeys to enable this.

BUG=250049, 353324
TEST=EME content tests pass (plus disabled ECK browser tests now pass)

Review URL: https://codereview.chromium.org/195053004

git-svn-id: svn://svn.chromium.org/blink/trunk@169797 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=308704
TEST=new test runs

Review URL: https://codereview.chromium.org/203323006

git-svn-id: svn://svn.chromium.org/blink/trunk@169796 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Notry because we don't have an XP trybot.
NOTRY=TRUE
BUG=354849

Review URL: https://codereview.chromium.org/208313005

git-svn-id: svn://svn.chromium.org/blink/trunk@169795 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove a lot of dead code from AXNodeObject. The following virtual function is
no longer used:
virtual void accessibilityText(Vector<AccessibilityText>&);

BUG=352771
R=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/202953005

git-svn-id: svn://svn.chromium.org/blink/trunk@169794 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Like with classes, even if local TargetedStyleRecalc is not
supported for an attribute selector, this also causes style
invalidation tree walks rather than
setting style recalc dirty bits directly.


BUG=339729,352300

Review URL: https://codereview.chromium.org/208323003

git-svn-id: svn://svn.chromium.org/blink/trunk@169793 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/205193002

git-svn-id: svn://svn.chromium.org/blink/trunk@169792 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools: reset inspector agents before frame view is reset, but after the rest of the frame interations.

BUG=352702,312393,344623

Review URL: https://codereview.chromium.org/204543004

git-svn-id: svn://svn.chromium.org/blink/trunk@169791 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderBlockFlow::marginBeforeEstimateForChild() was checking the wrong
margin when detecting quirky children. The performance test added by
this patch times out without the change in this CL - obviously a
pathological case!

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169269

Review URL: https://codereview.chromium.org/190913003

git-svn-id: svn://svn.chromium.org/blink/trunk@169790 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make corresponding fix to StyleInvalidator to not break invalidations in
which the document element itself needed invalidation.

Review URL: https://codereview.chromium.org/201443011

git-svn-id: svn://svn.chromium.org/blink/trunk@169788 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since the bits are actually stored in NodeRareData anyway, we should
just use those same bits for ShadowRoot and get rid of all this code
duplication.

Review URL: https://codereview.chromium.org/208933003

git-svn-id: svn://svn.chromium.org/blink/trunk@169787 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Set the cache dirty in RenderLayer::styleChanged and recompute
the rect during computeCompositingRequirements.

Also, get rid of absoluteBoundingBox from RenderLayer. The only
caller can use the new cached value since it always happens after
computeCompositingRequirements.

The unfortunate thing is that if a RenderLayer is modified, we
need to recompute the absolute bounds for all its descendant layers.

This saves ~3% of the computeCompositingRequirements time on the
tip of tree version of https://github.com/abarth/app-widgets/blob/master/demo.html.

The version checked into the key_silk_cases pageset doesn't show
the perf win because it doesn't have many RenderLayers outside
of the drawer being dragged.

The bigger win will come from the following patch that adds/removes
layers to the RenderGeometryMap lazily. Right now that's 10-20% of
the computeCompositingRequirements time in this demo.

Review URL: https://codereview.chromium.org/208313004

git-svn-id: svn://svn.chromium.org/blink/trunk@169786 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove unnecessary precompiler conditional statements from the font
platform code that always evaluate to true or are no longer needed.

R=dglazkov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/209083003

git-svn-id: svn://svn.chromium.org/blink/trunk@169785 bbb929c8-8fbe-4397-9dbb-9b2b20218538

First if the grid auto flow property is different to none, the grid is
marked as dirty when a new child is added. Because of if it contains
auto-placed items, they might need to be re-positioned.

Then if the new item has definite positions and auto flow is none, the
grid will grow as required and place the new item without being marked
as dirty.

The test was not working properly, as it was adding the PASS messages
as auto-placed grid items which was marking the grid as dirty and force
a re-calculation of the position.

Moving the results of the test to a different div make the test fails
without this patch. Test expectation was updated accordingly.

BUG=248151
TEST=fast/css-grid-layout/grid-item-addition-auto-placement-update.html

Review URL: https://codereview.chromium.org/198703004

git-svn-id: svn://svn.chromium.org/blink/trunk@169784 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=352300

Review URL: https://codereview.chromium.org/209153002

git-svn-id: svn://svn.chromium.org/blink/trunk@169783 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change tells the HTML parser know that lifecycle callbacks,
that is triggered through Microtask checkpoint, can create resources that
blocks scripts.

It also streamlines the unblock notification from Document to the parser
into didLoadAllScriptBlockingResources(). Now both didRemoveAllPendingStylesheets()
and didLoadAllImports() checks resource readiness and invokes the unified notification.

TEST=custom-element-style-block.html
BUG=346408
R=dglazkov@chromium.org, dominicc@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169577

Review URL: https://codereview.chromium.org/202813002

git-svn-id: svn://svn.chromium.org/blink/trunk@169782 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Audio stream
KeyId: "1234567890123456"
Key:   0x303062F16814D27B68EF122AFCE4AE0A

Video stream
KeyId: "0123456789012345"
Key:   0x7A7A62F16814D27B68EF122AFCE4AE0A

BUG=308704
NOTRY=true

Review URL: https://codereview.chromium.org/208623009

git-svn-id: svn://svn.chromium.org/blink/trunk@169781 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Avoid using getPresentationAttribute in ReferenceFilterBuilder because it is deprecated, instead use getPropertyValue. This is the last internal use of getPresentationAttribute so a follow-up patch can remove it.

Review URL: https://codereview.chromium.org/201463003

git-svn-id: svn://svn.chromium.org/blink/trunk@169780 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that we no longer have HFONT references in FontPlatformDataWin we
can remove a bunch of defines and includes.

R=schenney@chromium.org

Review URL: https://codereview.chromium.org/200693004

git-svn-id: svn://svn.chromium.org/blink/trunk@169779 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/204353005

git-svn-id: svn://svn.chromium.org/blink/trunk@169778 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When we use checkLayout() on a grid item, the results (PASS or FAIL
messages) are added as new auto-placed items in the grid. This causes
that the grid is marked as dirty which could hide bugs in the tests.

Modify the related layout tests to use a different container for the
test results. Updated expectations accordingly.

There is one test missing
"grid-item-addition-auto-placement-update.html". Which will be modified
in the patch to fix the bug in RenderGrid::addChild() (see
https://codereview.chromium.org/198703004/).

Review URL: https://codereview.chromium.org/208133003

git-svn-id: svn://svn.chromium.org/blink/trunk@169777 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, we only set a scroll parent for 
"localRootForOwningLayer".I.e., the highest
GraphicsLayer in the CLM-managed hierarchy, excluding
the squashing containment layer. But for "scroll
buddies", we need the scroll child to be the very top
of the hierarchy.

We also need to ensure that scroll buddies are not
prevented from squashing together because of the
additional "I've got a scroll parent" compositing
reason.

This cl also disables chicken-egg asserts that trip
w/ universal accelerated overflow scroll and changes
how we compute composited bounds for squashed layers
(we currently pull the bounds from the clipper, but
it picks the wrong "clipping root" in this case).

With this CL, universal accelerated overflow scrolling
and squashing work nearly perfectly modulo known hit
testing bugs (which can prevent touch scrolling) and
repaint issues (separate issue reported here
https://code.google.com/p/chromium/issues/detail?id=351790).

BUG=328156

Review URL: https://codereview.chromium.org/131543013

git-svn-id: svn://svn.chromium.org/blink/trunk@169776 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The animate() method on Element is severely under tested. This patch makes
use of the existing animation interpolation tests to also test element.animate().
Just over 50% of the tests pass, the failures are being checked in as expected
failures for now as it is representative of the current state of element.animate().

BUG=352472

Review URL: https://codereview.chromium.org/203723005

git-svn-id: svn://svn.chromium.org/blink/trunk@169775 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- added HashSet holding SVGFontFaceElement and cleared after document's style recalc is finished, and

- made widthIterator return default value when SVGFontFaceElement is not in document.

BUG=352178
TEST=fast/dom/remove-svg-font-face-element-crash.xhtml

Review URL: https://codereview.chromium.org/198783006

git-svn-id: svn://svn.chromium.org/blink/trunk@169774 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds logic to SourceBuffer::setTimestampOffset() to reject
invalid values. A LayoutTest to verify proper behavior for a variety of
values was also added.

BUG=353245
TEST=LayoutTests/http/tests/media/media-source/mediasource-timestamp-offset.html

Review URL: https://codereview.chromium.org/202423002

git-svn-id: svn://svn.chromium.org/blink/trunk@169773 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts r258671 (commit 04d85dfa329176dc489bdcf9d2654f38e72a484e) as it broke android.

BUG=355167
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/209303002

git-svn-id: svn://svn.chromium.org/blink/trunk@169771 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This maintains the invariant that microtask work (e.g. Mutation Observer callbacks) always occur on an empty page script stack.

Previously, it was possible for a microtask to fire before the outer script had exited on document.write('<script>') or showModalDialog, etc..

R=adamk@chromium.org, adamk
BUG=352181

Review URL: https://codereview.chromium.org/184043002

git-svn-id: svn://svn.chromium.org/blink/trunk@169770 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a speculative revert to address reported crashes in the wild.

> [HTML Import] Let script block by pending resources created by lifecycle callback
> 
> This change tells the HTML parser know that lifecycle callbacks,
> that is triggered through Microtask checkpoint, can create resources that
> blocks scripts.
> 
> It also streamlines the unblock notification from Document to the parser
> into didLoadAllScriptBlockingResources(). Now both didRemoveAllPendingStylesheets()
> and didLoadAllImports() checks resource readiness and invokes the unified notification.
> 
> TEST=custom-element-style-block.html
> BUG=346408
> R=dglazkov@chromium.org, dominicc@chromium.org
> 
> Review URL: https://codereview.chromium.org/202813002

TBR=morrita@chromium.org

Review URL: https://codereview.chromium.org/201673005

git-svn-id: svn://svn.chromium.org/blink/trunk@169769 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Verify that a very large shape-margin value combined with a very small
shape-outside image defines a shape that matches the shape-outside
element's margin-box.

This is a merge of http://trac.webkit.org/changeset/166019 by
Hans Muller <hmuller@adobe.com>.

BUG=354917

Review URL: https://codereview.chromium.org/208423003

git-svn-id: svn://svn.chromium.org/blink/trunk@169768 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There's no need to constantly recompute this data. It's
already determined by the style information, so we might as
well just compute it once during style recalc.

Note: We're still computing all the direct compositing
reasons during style recalc (via updateLayerCompositingState in RenderLayer::styleChanged), but now we skip recomputing
the style determined reasons again when updating layout
and compositing. ASSERTs verify that we get the same answer
as before.

This CL reduces the amount of time spent in the compositing
update for dragging the drawer in the Polymer calculator by
3%.

Review URL: https://codereview.chromium.org/207513002

git-svn-id: svn://svn.chromium.org/blink/trunk@169766 bbb929c8-8fbe-4397-9dbb-9b2b20218538