- 26 Jul, 2019 40 commits
-
-
Antoine Labour authored
👋 Change-Id: Idc9b82f97846f1b38bb4dfd7006ceb635a45e8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721455 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:Bill Budge <bbudge@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#681490}
-
Peter Boström authored
This prevents the NativeViewHost from rendering into the WebView border. Bug: None Change-Id: Ib48d3335205357320a369a9da53c227897b3b1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720741 Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#681489}
-
Yves Arrouye authored
Bug: None Test: Manual Change-Id: I7a6102d6f1105dafab4799b121c78e7a565ad7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721023Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Yves Arrouye <drcrash@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#681488}
-
Matthew Cary authored
Uses base::UnsafeSharedMemoryRegion instead of the legacy base::SharedMemory in the buffer manager and associated uses. No functional change. Note this CL clarifies the use of the readonly flag used when passing buffer cross-process: it does not set the permission of the shared region (which is sent writable/unsafe), but is only used for the mapping. Bug: 849207 Change-Id: I6592aff747dd8c975b6491b8c04abb5ad1846f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697641Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#681487}
-
Luum Habtemariam authored
Bug: none Test: na Change-Id: I09a09bcc6bc63be671a19b375c0c5afc4ba0f46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717744Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#681486}
-
Patrick Monette authored
Since the old blacklist is not currently in use, this now has been recording the value zero for a few major versions. Bug: 986926 Change-Id: I2f976c6bd9089a3926b78934577194075346ab32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719003Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#681485}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: If86e70b1e44963c66b98a225c3ac8ab277adc142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700856Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681484}
-
Maks Orlovich authored
The code for reading entries' keys has trusted that the supposed-to-be on-disk nul termination was there, which is a mistake since sometimes files get corrupted ...And also because in some cases we've failed to write it out. So fix both. This has mostly stopped being an active issue since May when our Windows build has switched to libc++, as that fixes up nuls on std::string copy (Microsoft's version doesn't), but it seems worth fixing regardless for other embedders and good hygiene. Bug: 973943 Change-Id: I86c6e44471447671004efd37aeecd760b3972183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718844Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#681483}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ic29adb553986138929c755ed797dc8aef131ce94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700962Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681482}
-
siyua authored
If the icon is in toolbar page action icon container, the ink drop bound should not follow the omnibox page action icon size. Instead, it should be like other toolbar buttons. Uploaded screenshot in bug comment 23 Bug: 932818 Change-Id: I8cdb74b168f3977aff2506c6ae673006b595325b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716385Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#681481}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Icc9b523bd9a8350da6d57711ef92c5a71b430add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700834Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681480}
-
Hiroki Nakagawa authored
This was used for on-the-main-thread shared worker script loading that was already removed. Bug: 538751, 987850 Change-Id: Ib02dce284d570e2fd54c79b34fe94d1af51d0757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718945 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#681479}
-
Axel Antoine authored
The MaxResampleTime used to compute the cutoff prediction delta is always retrieved from the mouse_predictor_. This CL fixes the behavior by using the right predictor stored in the pointer_id_predictor_map when computing cutoff for touch/pointer events. Bug: 986963 Change-Id: I36b72d0e3f8cd76fd293ff3b37ec637701271e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715098Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Axel Antoine <axantoine@google.com> Cr-Commit-Position: refs/heads/master@{#681478}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8a18e30c0ce..52b21525450c Created with: gclient setdep -r src-internal@52b21525450c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:b/134015500,chromium:947794,chromium:None,chromium:None,chromium:790419,chromium:790403,chromium:790439,chromium:790442,chromium:None Change-Id: Idaf0f356bfaa89bd7cf2d4e20101b100dd5939a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721034Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681477}
-
Hiroki Nakagawa authored
Off-the-main-thread shared worker script loading was enabled by default in M76. The legacy on-the-main-thread shared worker script loading is no longer necessary. This CL removes it. This CL removes code wrapped with the runtime flag in a mechanical way. After this CL, I'll do more structural changes, for example, remove ServiceWorkerNetworkProviderForSharedWorker. Bug: 987850 Change-Id: I388a22fdd3a7b14f6d3f70c8e74108920025676c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718471 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#681476}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/22762d94d758..d595819730e1 git log 22762d94d758..d595819730e1 --date=short --no-merges --format='%ad %ae %s' 2019-07-26 fqj@chromium.org cros deploy: change working directory to alternative root for restorecon 2019-07-26 mikenichols@chromium.org chromeos_config: Add new kernelnext boards to CQ Created with: gclient setdep -r src/third_party/chromite@d595819730e1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8ae7a1641b6d9bf45ed2a910bc7a520858b243be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721001Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681475}
-
Vlad Tsyrklevich authored
Merge the malloc/PartitionAlloc field trial to reflect a similar merging upstream into a single experiment. This makes it easier to measure the combined memory/perf regression of GWP-ASan for malloc and PartitionAlloc and eliminates platform-specific field trials. Change-Id: I89eebfb75366bdef5b8775d0135f9875fdc62438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719990 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#681474}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ib2fadafcd894a24642ae02093f0deb3908108fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700932Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681473}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/59192a0d66a7..14963cef70cc git log 59192a0d66a7..14963cef70cc --date=short --no-merges --format='%ad %ae %s' 2019-07-26 michaelludwig@google.com Use SkColorChannel in SkDisplacementMapEffect 2019-07-26 fmalita@chromium.org [skottie,skshaper] Plumb an optional SkFontMgr in SkShaper/SkottieShaper 2019-07-26 egdaniel@google.com Don't release VkCommandPools already released secondaryCB's resources. 2019-07-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-26 mtklein@google.com add a fast subset option and --dry-run 2019-07-26 reed@google.com add gm for tricky arc 2019-07-26 halcanary@google.com experimental/editor: fix Movement::kUp, Movement::kDown 2019-07-26 bsalomon@google.com Make GrColorTypeBytesPerPixel return size_t. 2019-07-26 bsalomon@google.com Test GrGpu::transferPixelsTo for more color types. 2019-07-26 mtklein@google.com tweak how we avoid rewriting vulkan includes 2019-07-26 nifong@google.com Format skpbench.cpp with tools/rewrite_includes.py 2019-07-26 halcanary@google.com experimental/editor: fix home, end 2019-07-26 michaelludwig@google.com Move SkColorChannel into SkColor 2019-07-26 halcanary@google.com experimental/editor: fix resize 2019-07-26 csmartdalton@google.com Disable msaa ccpr on PowerVR again 2019-07-26 nifong@google.com Extend skpbench to play multi frame files. 2019-07-26 egdaniel@google.com Reland "Move ExternalFormat and Type to FormatInfo." 2019-07-26 reed@google.com add bots to opt-in to loopers (deprecated) 2019-07-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-07-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 557e3853da56..fab397e5acde (5 commits) 2019-07-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-26 brianosman@google.com Windows-on-ARM testing fixes 2019-07-25 bsalomon@google.com Remove old constructor for GrVkImageInfo. 2019-07-25 brianosman@google.com Particles: Merge spawn & update into one code string with two functions 2019-07-25 bsalomon@google.com Fix build flags in GrMtlCaps::supportedReadPixelsColorType 2019-07-25 rmistry@google.com [perf_skottiewasm_lottieweb] Start tracking timings of drawn frames and count aborted frames 2019-07-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-25 brianosman@google.com Particles: Use list of lines for multi-line string serialization 2019-07-25 mtklein@google.com rewrite *.gn and #includes on CheckGeneratedFiles bot 2019-07-25 reed@google.com Return translate info from looper, rather than moding a canvas 2019-07-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-25 brianosman@google.com Major rewrite of the particle system based on the SkSL interpreter 2019-07-25 aparchur@google.com Change the visibility of skottie::PropertyHandle constructor to public. 2019-07-25 egdaniel@google.com Revert "Move ExternalFormat and Type to FormatInfo." 2019-07-25 bsalomon@google.com Fix two issues in transfer to test 2019-07-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-25 egdaniel@google.com Move ExternalFormat and Type to FormatInfo. 2019-07-25 fmalita@chromium.org [skottie] Cleanup: track animator scoping in AnimationBuilder 2019-07-25 rmistry@google.com Add presubmit prompt during upload if public API change does not include release file change 2019-07-25 rmistry@google.com [perf_skottiewasm_lottieweb] Script to parse and combine skottie/lottieweb perf CSVs 2019-07-25 mtklein@google.com clean up SK_SUPPORT_LEGACY_A8_MASKBLITTER 2019-07-25 hcm@google.com Introduce crowdsourced release notes file 2019-07-25 mtklein@google.com re-run tools/rewrite_includes.py 2019-07-25 benjaminwagner@google.com Reland "[infra] Upgrade Win10 in Skolo. Use new Win dimension values." 2019-07-25 robertphillips@google.com Delete GrBackendSurface's GrPixelConfig 2019-07-25 halcanary@google.com SkMetaData: remove unused features 2019-07-25 brianosman@google.com Skip non-D3D11 test contexts on Windows-on-ARM bots 2019-07-25 ethannicholas@google.com Child fragment processors are now written as separate functions 2019-07-25 brianosman@google.com Interpreter: Add radians and normalize builtins 2019-07-25 brianosman@google.com Don't test MSAA on Pixel2XL Vulkan Perf bots 2019-07-25 benjaminwagner@google.com Revert "[infra] Upgrade Win10 in Skolo. Use new Win dimension values." 2019-07-25 borenet@google.com [infra] Fix DEPS to use full commit hashes 2019-07-25 borenet@google.com [infra] gen_tasks_logic followup 2019-07-25 benjaminwagner@google.com [infra] Upgrade Win10 in Skolo. Use new Win dimension values. 2019-07-25 hcm@google.com Update Skia milestone to 78 Created with: gclient setdep -r src/third_party/skia@14963cef70cc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: chromium:None Change-Id: I9cf5bbef7808293374d888c533e47698bb70dba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721183Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681472}
-
Nico Weber authored
It's currently a no-op in clang-cl, and if it weren't we wouldn't want it. I'll try to completely remove msvc_use_absolute_paths in a follow-up. Bug: none Change-Id: Idedf8d7c294c27d647606d4e435dba9eb9d5aded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721630 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#681471}
-
Michael van Ouwerkerk authored
In a separate histogram, log for ack messages. Bug: 976311 Change-Id: I005db143425dfcb78d8200bdf413bd8f3c9c5172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718324 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Auto-Submit: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#681470}
-
Peter Kotwicz authored
This CL: - Handles onActivityResult() being called after onNewIntent() and before onResume() - Changes SplashActivityTest#testDeepLink() to reflect what actually occurs BUG=978716 Change-Id: I3b5265368a32eb0b94fdc78e905285258666b72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717877 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#681469}
-
Dirk Pranke authored
We are adding a variant of run_web_tests that the GPU team will use to run a subset of the WPT tests that will only ever work on bots with actual GPU cards. In order for this to work, we will always skip (WontFix) the tests in the main run_web_tests runs, but we will run the tests separately. In order to do that, we need a way to bypass the default expectations (i.e., skip the lines that will be in NeverFixTests). This CL adds a --no-default-expectations arg to run_web_tests to do so. R=rmhasan@google.com, kainino@chromium.org BUG=984815 Change-Id: Ia855f70c0f8cdf3b272f700e7e08349b8c5b1694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710888Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#681468}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 85259937. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" f050694a "Restrict Shape Detection API to Secure Contexts" 14d3a4a1 "Sort tracks by id in MediaStreamAudioSourceNode" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I38b6d01dd7eac5ad9abdc2db573f81f2de363154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721569Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681467}
-
Eric Stevenson authored
This CL changes static methods to not pass a jcaller object to the native side. This isn't necessary because there is no Java object instance for static methods and it was actually just passing a jclass as a jobject which was always unused. The @JCaller annotation is also removed. It isn't strictly necessary anymore and is often used incorrectly (i.e. using @JCaller and adding an unused param on the native side). All Java and native definitions and uses are also updated to reflect the changed logic. Tbr: agrieve@chromium.org # Large mechanical refactor. Bug: 986930 Change-Id: I2ef62d189dad484779524d0d5edadeaf51204395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719427 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#681466}
-
Madeleine Barowsky authored
This changes the memory accounting by aliasing the planar textures to their Skia counterparts to prevent double counting. When running a trace (chrome://tracing), this change shows dumps for each plane backing a YUV image as subcategories plane_0, plane_1, etc. Bug: 919296 Change-Id: I3717d0d9f10b8339bb5b0d0854fe21402db96326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716060 Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Auto-Submit: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#681465}
-
Nicolás Peña Moreno authored
Bug: 965505 Change-Id: I1463f4b029e57f5293dc8dbe62462db7d241bf45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721022Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#681464}
-
Findit authored
This reverts commit add19d06. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 681434 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2FkZDE5ZDA2YjQ3YzgxNTFkYWM2YWFiMzU4NWU1NTJhMDQ3ZDE4OWIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/mac-archive-rel/2785 Sample Failed Step: compile Original change's description: > mac and ios: Turn linker warnings into errors. > > Bug: 747727 > Change-Id: I33f44e3f4011873e193088796483ecdc48f7f05e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720610 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681434} Change-Id: Icb3d15c4d46a3b4bbadf2f867fc3d542a375044e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 747727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720743 Cr-Commit-Position: refs/heads/master@{#681463}
-
Kevin McNee authored
GesturePinchUpdates are currently blocking even though they are always handled on the compositor. The only case where we inspect the ack of a GesturePinchUpdate event is for touchpad pinch, but in this case, the browser creates a synthetic wheel event and sends that. So it's only the wheel event that needs to block. Bug: 787924 Change-Id: I1f5e25289eb8bde2264cec851df880baf31dcab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717693Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#681462}
-
Max Moroz authored
Bug: 539572 Change-Id: I6c3bfd3e8d3d5776eb9037e315a56d3c4a59651b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717019Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#681461}
-
Patrick Monette authored
Ready for round 2. We're now aware of the side-effect of turning this process mitigation for TSF IMEs (sets immersive mode) and we're ok with it. Bug: 557798 Change-Id: I2f2dbb3e6182f4d9cf05e1f97424a3959fde920b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721458Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#681460}
-
Ahmed Fakhry authored
Windows placed in inactive virtual desks will be considered hidden by the occlusion tracker. This currently end up in a call to RenderWidgetHostViewAura::Hide() which unnecessarily hides the aura::Window. This causes issues when reflecting that window in the desks mini_views. This CL keeps the aura::Window visible, while updating only the occlusion state. BUG=866622 TEST=Added a new test. Change-Id: I7f71cfa072240264fea2e4934f2c7350f66a74c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711113Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#681459}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e5bc2758b312..e2a6c7b2edba git log e5bc2758b312..e2a6c7b2edba --date=short --no-merges --format='%ad %ae %s' 2019-07-26 tsepez@chromium.org Weakly cache CPDF_IccProfile in CPDF_DocPageData 2019-07-26 tsepez@chromium.org Remove UnownedPtr<>s to CPDF_Object subclasses. Created with: gclient setdep -r src/third_party/pdfium@e2a6c7b2edba The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ide77e1f79754b5220768aa3dabe2bfcc1311c3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721182Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681458}
-
Matthew Cary authored
Change-Id: I31efe81b4623e4a4e8c15b7594137aad03a237e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697622Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#681457}
-
Abhishek Bhardwaj authored
This change ensures that the attempt to unmount crostini's sshfs completes before the device is allowed to suspend. Previously, the device may suspend while the unmount attempt is ongoing. BUG=968060 TEST=Manually test that sshfs is unmounted and device is allowed to \ suspend. Change-Id: Ifd480c2bf6ad90cb1962786e34b2cc359f1e10f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719777 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Auto-Submit: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#681456}
-
Tibor Goldschwendt authored
Move the resources for the internal bluetooth about pages out of the browser_resources.grd and into a newly created GRD file. Add grit target for the new GRD file. This CL prepares moving the resulting PAK file into the dev UI DFM on Android. Bug: 955494 Change-Id: I3a12c92d977c39ca65b61b6c6022c5f229cc9434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709999 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#681455}
-
Sofiya Semenova authored
Bug: 972128 Change-Id: I517faf278f4f92e55daa973966bac9ca0ff920f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688355 Commit-Queue: Sofiya Semenova <sofiyase@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#681454}
-
Steven Bennetts authored
Bug: 987923 Change-Id: Iff95482d23ae0f9851b55a69d15679da17387297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721018 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#681453}
-
Daniel Clark authored
An <input type='search'> should have LocalizedControlType of "search box" per https://w3c.github.io/html-aam/#el-input-search and https://www.w3.org/TR/core-aam-1.1/#role-map-searchbox Currently its LocalizedControlType is "edit". This change updates it to "search box" by changing AXNodeObject::NativeRoleIgnoringAria() to check for input type='search' and use ax::mojom::Role::kSearchBox for it (instead of ax::mojom::Role::kTextField as was used before). The UIA_LocalizedControlTypePropertyId case of AXPlatformNodeWin::GetPropertyValue is changed to check for the kSearchBox role and return the correct string rather than falling back to the value provided by Windows' UIA implementation. Additionally, AXPlatformNodeWin::UIAAriaRole() is updated such that <input type='search'/> has the AriaRole of searchbox rather than textbox. Bug: 986554 Change-Id: I268c6c0d1bc3d136e3d533a90d5f2a0436945789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713867 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#681452}
-
Ken Rockot authored
ServiceFactory is relatively simple helper API for Mojo consumers to handle service interface requests, typically in a sandboxed service process. This is used here to reduce error-prone and inconvenient boilerplate around out-of-process service launching in Content and its embedders. Bug: 977637 Change-Id: Iae3dcd1335280fc2ec96014d7009ce5183060638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717474 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#681451}
-