- 23 Jun, 2020 40 commits
-
-
Maks Orlovich authored
Experiment showed not using the heuristic prevents accumulating too many files and performs well Bug: 1075545, 1073514 Change-Id: I7cb374e7f3283ea809f1bf7635f1ade91009742b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255651Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#781309}
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. Currently, IdentityServicesProvider gives |Profile#getLastUsedRegularProfile| param to the native. By this CL, sync classes pass |Profile#getLastUsedRegularProfile| to the IdentityServicesProvider to be used by native. Note: This CL is only clean-up and does not change code behaviour. Bug: 1041781, 1075562 Change-Id: Ib987c4b1e57c6490cd3b844dd9786a3b8459fe17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253749Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#781308}
-
Sebastien Marchand authored
Bug: 1061899 Change-Id: Iae643053601f2d9553212418deb72adb08d19b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240043 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#781307}
-
Patrick Brosset authored
Users can configure settings in chromium for the fonts they prefer. These settings are set in the page frame that the DevTools overlay creates for itself. This change just adds a missing setting for fixed size fonts. Additionally, this fixes a bug whereby the font-family defined in the grid overlay for line number labels was not applying correctly. Before: https://i.imgur.com/kox646s.jpg After: https://i.imgur.com/4AOLmiY.jpg Bug: 1096542 Change-Id: I727932184f5ddd04336539d1849d8233103a6933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251086Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#781306}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d69e945fe7dd..2841ab4841b1 2020-06-23 sigurds@chromium.org Update protocol for HeavyAds 2020-06-23 wolfi@chromium.org [Issues] Change style of 'issues infobar' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1095617,chromium:1096973 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I630b117571bbeed9d8445c45718ed31448464f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260512Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781305}
-
Makoto Shimazu authored
It's one of the health check metrics. Let's add one more year. Bug: 1077803 Change-Id: Id6ce1775917a07e4fe64c74e754135a6d9843817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259419 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#781304}
-
Stephen Nusko authored
android go webview This test flakes 19% of the time due to a timeout. See bug for details. Bug: 1098223 Change-Id: I5e65949433a4deddb020ffa3f73af220d78d6235 No-Try: True TBR: johnchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260556Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#781303}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ea15439b6b92..d8ac1d219713 2020-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from e20ac35adbfd to 839704450200 (3 revisions) 2020-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 71c1a611fdbb to 76ddcca9f3a4 (5 revisions) 2020-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ae1007957f09 to 9167e1e22a46 (1 revision) 2020-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from d4b9f576ebb4 to 36b5bb701da9 (1 revision) 2020-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 977b7ccbacc1 to 0f4d5f74f199 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ideb126604017be9b301fe049015a987f1f289a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260115Reviewed-by:
-
clamy authored
This CL adds a check in NavigationRequest::OnWillProcessResponseProcessed to return early if the call to ReadyToCommit leads to the deletion of the NavigationRequest. Bug: 1090543 Change-Id: Ida21db80caef1772f2f21c5d2449d3efe4dd1bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254119Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781301}
-
Maria Petrisor authored
Add the new method chrome.platformKeys.getKeyPairBySpki() that, similarly to chrome.platformKeys.getKeyPair() returns subtleCrypto objects for a private and a public key. The key pair already exists on the device, and getKeyPairBySpki() receives a public_key_spki_der as input to identify which key pair to return. The already existing API function getKeyPair() receives a certificate, extracting the public_key_spki_der from it and returning the key pair based on that spki. In our use case (the Imprivata extension) we don't have access to a certificate in order for us to use getKeyPair(). A key pair is needed in Imprivata for sending authorization requests (signing data in the request with the private key) to the Imprivata server, which verifies our authorization request using the public key. Bug: 1073466 Change-Id: I44ef0335ede498b0e5f4878554050999dbbeda85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190675 Commit-Queue: Maria Petrisor <mpetrisor@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#781300}
-
Maria Petrisor authored
Grant permissions to the Imprivata login screen to use chrome.platformKeys and chrome.enterprise.platformkeys (_permission_features.json). The Imprivata in-session extension does not need to be added here since it already has access to them as a regular extension. The login screen also needs to be able to sign with the private key obtained from chrome.platformKeys.getKeyPairBySpki() multiple times. Thus we add an allowlist to SignTask (extension_platform_keys_service.cc) in order to approve multiple sign operations in the Imprivata login screen. The Imprivata in-session extension will be covered by the KeyPermissions user policy. Bug: 1073466, 1065112 Change-Id: Iaf9bb6f1522706b76406c43604097f74dbcf1326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193615 Commit-Queue: Maria Petrisor <mpetrisor@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9ca5e5ee..bbe343d8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I40878d1fa9de379a83d5763b8a0631cea95ef923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260414Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781298}
-
chrome://managementDominique Fauteux-Chapleau authored
Context for those string changes can be found in the bug. After this change the page will look like http://screen/TMKxaozRA7m.png when every Connector is enabled. Bug: 1092559 Change-Id: I955dd062d464641add5fd332766f94fbe54b28c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254459 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#781297}
-
Rob Buis authored
These tests add children to mspace, but mspace does not allow children. Nevertheless the internal framework, using Element.getBoundingClientRect, assert based on these disallowed children which get bounding boxes that are empty rects. To fix this, special case mspace and only check size and that the children are empty and positioned at (0, 0). Bug: 6606 Change-Id: Ic78720547f7e4909cf63ceeb92b3bfbf22d7e15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256212 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#781296}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3d01eda10798..47124be594aa 2020-06-23 khokhlov@google.com [Telemetry] More performance mode control If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1096589 Tbr: nuskos@google.com Change-Id: I7ff37395c5ca0c28c458fd18a4e2452d39d66a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260116Reviewed-by:
-
Jan Wilken Dörrie authored
This change implements the range overloads for the alg.copy algorithms std::copy, std::copy_n, std::copy_if and std::copy_backward. Bug: 1071094 Change-Id: I26f746acc594761f0a1ae1c21ea858f0b1c0c0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257914 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#781294}
-
Victor Hugo Vianna Silva authored
Mock: https://screenshot.googleplex.com/opD1RHQ3qmN Implementation: https://storage.cloud.google.com/chromium-translation-screenshots/34c070526b05e911eec3972b16c715c065ac4d96 Bug: 1049141 Change-Id: Ie93f72ec1d6d95c8f517fc2aad75873652bacddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257421 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#781293}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 59b5b97b. With Chromium commits locally applied on WPT: ee0c101e "[COOP] access reporting toward the opener." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I1efe228060818d7980d2611b8212e65a926c55cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260392Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781292}
-
Victor Hugo Vianna Silva authored
PasswordsListHandler contains a cr-toast-manager. PasswordsSection and PasswordsDeviceSection both embed PasswordsListHandler. This means when one navigates from one page to the other, Chrome attempts to create two instances of cr-toast-manager, which is supposed to be a singleton. This causes error messages to be displayed on Dev Tools. This CL replaces the toast manager with a <cr-toast>, solving the problem. We also use the occasion to fix the arity of the callback passed to the requestPlaintextPassword() call in the file. Fixed: 1096040 Change-Id: I07159913b6a8492118f1eefa09faae6d26874ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254281 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Mohamed Amir Yosef authored
This CL implements the agreed upon proposal in this doc https://docs.google.com/document/d/1ZJnlpeqdhd_a-ypovOmHLrIPYbbdlK8h3OIggGuj5G4/edit?usp=sharing By making sure the following fields are preserved when updating password in MultiStorePasswordSaveManager date_created date_synced times_used moving_blocked_for_list times_used is incremented upon update. Bug: 1012203 Change-Id: Ife4731381f317efddab032fe416d835c0ec86228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257932 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592887944-a5350dcd6f0f1194a03615a841b47284864b512a.profdata to chrome-win32-master-1592902529-27c1b0c2ad05930b1841cdb3fc1b8d5f930926e0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3585a2cde606a1b11641e5d67693ecb42da6e340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259480Reviewed-by:
-
Olya Kalitova authored
Add PluginVmRequiredFreeDiskSpace user policy that allows admins to specify free disk space required to start Plugin VM installation. Bug: b/157584005 Test: browser_tests --gtest_filter="*PolicyToPref*" Change-Id: Iebebf216904d8df5b1d23bdcc5654d40869f0817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256226 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781288}
-
Vasilii Sukhanov authored
ManagePasswordsUIController Bug: 1049200 Change-Id: I980f4bde45a75e0706489bff24d00a1cb78c0677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257858 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Andrey Zaytsev authored
Final state: https://screenshot.googleplex.com/xh54f8vfpEL.png Bug: 1070620 Change-Id: Ib1ac093b2a303530ab404cb0ab1cb0cfe4fdfd55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254118 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#781286}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592891992-572d12f4a11aaaeb26a619bef233d3655144eb8a.profdata to chrome-win64-master-1592902529-d2a08100040b803a390f39eecb31cf1400764c19.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: If417ea05b7926592359f011b6f3514ac24523b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260114Reviewed-by:
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/2eba343b51..10cb35e459 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/2eba343b51..10cb35e459 Bug: None Change-Id: I71dc1be758e46f2ca522308fd57cd6349540bac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259856Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#781284}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7acac32cb402..d69e945fe7dd 2020-06-23 szuend@chromium.org Fix stylelint-config-standard issues in security/mainView.css 2020-06-23 szuend@chromium.org Fix stylelint-config-standard issues in security/sidebar.css 2020-06-23 bmeurer@chromium.org [third_party] Roll wasmparser 2.2.5 2020-06-23 mathias@chromium.org Add stylelint-config-standard dependency 2020-06-23 szuend@chromium.org Fix stylelint-config-standard issues in security/lockIcon.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1071432,chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0d5773ea1d6202b3d10ce13286dbe8cffa36eec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259481Reviewed-by:
-
Omid Tourzan authored
Update the background to use semantic color. This doesn't change the currently supported light color scheme but makes it compatible to some of the texts (like banner and dialog) that use semantic colors, so they will be visible when testing dark color scheme. Also updating the file label color to semantic one for the same purpose. Bug: 1096951 Change-Id: I8d891181784b0bdac4c9430355738281d4938296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251642 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#781282}
-
Andrew Walbran authored
This matches the threshold applied on other platforms in ValueToButton. Also set the touched state for all non-zero values, and fix a typo in the comments. BUG=1073130 Change-Id: Ied8db827b098c95b6a697f1df8a940de1a501166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245484Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Andrew Walbran <qwandor@google.com> Cr-Commit-Position: refs/heads/master@{#781281}
-
Yoshifumi Inoue authored
This patch changes |NGBlockLayoutAlgorithm::Layout()| to calculate baseline offset for empty line then set it |NGPhysicalBoxFragment| to allow flex layout algorithm to use valid baseline offset, e.g. "align-items: baseline" CSS property. This patch also introduces |LayoutBlock::BaselineForEmptyLine()| to share baseline offset calculation with legacy latyout. Note: The test[1][2] verify this change. [1] third_party/blink/web_tests/css3/flexbox/baseline-for-empty-line.html [2] third_party/blink/web_tests/inline-block/contenteditable-baseline.html Bug: 707656 Change-Id: I2a19fb3e457925c03b34ee509b80ba15dff523b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259675 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781280}
-
Bartek Nowierski authored
Bug: 1073933 Change-Id: Ie039b080b8c76fa29dfd5b52f5f1135ed53a40b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259535 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Mohammed Abdon authored
Install extension, Sets the change-password page to an embedded test server, then simulates submitting a password-change form to that server, and redirects to URL to simulate what happens in IdPs page. Bug: 1080626 Change-Id: I18db071dc318d0910f7b41da97c34b79c72c3d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255471 Commit-Queue: Mohammed Abdon <mohammedabdon@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I85ed36c1dd1805d66a2c473ab4598e3d1a06e5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259144Reviewed-by:
-
Nohemi Fernandez authored
Feature ClearSyncedData has been enabled by default. Clean up code. Bug: 1005509 Change-Id: I8eaea684e754afda13bcde2134e4fa5e2434c9ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260193 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#781276}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iab08bacb8fb8e05871268751f5611b08ab4d6a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259731Reviewed-by:
-
Henrique Ferreiro authored
Ozone's cursor factories load and cache Chrome provided image assets when a default platform cursor isn't available. This CL moves that responsibility to CursorLoader, which was already doing this for image cursors loaded through that class. Additionally, apply the proper scaling to the fallback cursors. Now, CursorFactory will only handle the creation of image cursors and loading of default platform cursors (e.g. X11 cursors). This also reduces their dependency on //ui/base/cursor, a step into moving ownership of CursorFactory to CursorLoader. Bug: 1029142, 1054278 Change-Id: Ic4387deabf3a628133fc3db3af3860b3a08872ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252342 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Scott Violet authored
BUG=none TEST=none Change-Id: If82677ec23c81f8051a86a9286c6b64e34d7a22d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255309 Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
-
Bartek Nowierski authored
The latest rewrite attempt revealed a couple more classes of compiler errors, that would be hard to handle automatically in the rewriter. Bug: 1069567 Change-Id: I844bd3f6bd8e562b8869702bfc55002557254580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255920 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Vidhan authored
boxes This CL introduces the functionality for detecting and filling of the <select> fields, having options consisting of the phone country code along with an additional text. Also, sending votes for the server classification. Bug: 1081219 Change-Id: I00ee0125d457abadf4f59fb16b3850e27274006b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198785Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#781271}
-
Stepan Khapugin authored
The bug is happening because we call -[UIApplication requestSceneSessionRefresh:] in non-scene lifecycle, therefore the passed argument is nil, which hits an assert in iOS. Bug: 1097916 Change-Id: I7872ad45dcce89e8c6750bb7c0f60036154e8b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260232 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#781270}
-
