- 05 Aug, 2020 40 commits
-
-
Maksim Sadym authored
Bug: 1113202 Change-Id: I63ad3e451b5421b2d4398731405d6b151e558506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339354Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#795213}
-
Jeffrey Kardatzke authored
This adds a flag, which defaults to enabled, which causes the H264Decoder to assume that a DecoderBuffer contains a complete picture and will output the frame to the accelerator after processing the DecoderBuffer, rather than waiting for a signal of EOS/AUD or the next picture in the bitstream. The flag is temporary so we can verify if this breaks anything. BUG=chromium:1105268 TEST=Verified decode latency is reduced with chrome tracing in apprtc Change-Id: I864337be34634960eacdeaa26d2811d21b8e142d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335338 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#795212}
-
Sammie Quon authored
When the feature is turned on, replaces the two screenshot related tools in the palette bubble. This uses the existing palette tool histogram recording. Removes some unused functions. Screenshot in linked bug. Test: manual Change-Id: I145dd875fac579955b17531c63b5bed2d2e48305 Fixed: 1113014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333824 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#795211}
-
Avi Drissman authored
https://crrev.com/c/2337734 was landed without the promised fixups because of user error. These are the fixes that were promised. Bug: 1112998 Tbr: ellyjones@chromium.org Change-Id: I3442658b2016e0b772a2201d1ded10c7da383a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339720Reviewed-by:
-
Emily Stark authored
When gfx::MultiAnimation exceeds its cycle time and isn't running continuously, it calls Stop(), but doesn't first call AnimationProgressed(). This means that the final animation state might not be reached, i.e. AnimationProgressed() is not guaranteed to run with a current value of 1.0. I've fixed that quirk in this CL by calling AnimationProgressed() before stopping the animation. This allows me to delete some code that was hacking around this quirk in the omnibox simplified domain field trial implementation. OmniboxViewViews::ElideAnimation was forcing the final frame to run by calling AnimationProgressed() from AnimationEnded(). This hack was causing a DCHECK failure when the simplified domain elision animation was cancelled after the underlying RenderText text contents changed. In other words, because ElideAnimation::Stop() really meant "run the final frame and then stop", there was no safe way to cancel the animation when its state had become stale. Now, with this MultiAnimation fix, MultiAnimation ensures that the final frame runs before the animation finishes, and ElideAnimation::Stop() just stops the animation without running any frames. Bug: 1103738 Change-Id: Idbf55bc2f326d3eaa9bf97a288e3ab467097953e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330613 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#795209}
-
David Bertoni authored
The Event Page-based versions of these tests aren't flaky. Bug: 1111337, 1111536 Change-Id: I8201a26f74d0990d47591a370b9c9ac6c2de6bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339701 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#795208}
-
Kyle Horimoto authored
This includes: (1) Adding to BetterTogetherDeviceMetadata Proto. (2) Adding to Mojo type. (3) Adding to C++ RemoteDevice and RemoteDeviceRef classes. (4) Updating tests. Note that this field is not yet set during enrollment; a follow-up CL will do this. Bug: 1106937 Change-Id: I859efa86a7a57cff6eea185e2945a9201d14d508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318685 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#795207}
-
James Long authored
A shortcut has been added to check/uncheck nodes in the filter on double-click in the visualization. The behavior is the same as clicking the button manually on the node details panel. Bug: 1106106 Change-Id: Idd08b152d956216c250657d0062c920507297f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333446 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#795206}
-
Lukasz Anforowicz authored
This CL breaks down a single boolean expression into separate, explicit if statements. This helps to improve the readability of the function and add more comments that target individual if statements (i.e. parts of the old boolean expression). This CL has no intended behavior changes. Bug: 1107269 Change-Id: Id309497e480d2ff278f0e381902b2626963094a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336504 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#795205}
-
Tibor Goldschwendt authored
The share button is not sent for doodles that should not be shared. Fixed: 1113160 Bug: 162949376 Change-Id: I833d6c536cc46fa9fa1db04149a45077a08809d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339759 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795204}
-
Devlin authored
This reverts commit 50136be2. Reason for revert: This also fails consistently on Linux Trusty: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/14445 Sample failure: [ RUN ] CpuAffinityTest.SetThreadCpuAffinityMode ../../base/cpu_affinity_posix_unittest.cc:114: Failure Value of: SetThreadCpuAffinityMode(thread_id, CpuAffinityMode::kLittleCoresOnly) Actual: false Expected: true Stack trace: #0 0x55b884c793f3 base::CpuAffinityTest_SetThreadCpuAffinityMode_Test::TestBody() ../../base/cpu_affinity_posix_unittest.cc:119: Failure Value of: SetThreadCpuAffinityMode(thread_id, CpuAffinityMode::kDefault) Actual: false Expected: true Stack trace: #0 0x55b884c797da base::CpuAffinityTest_SetThreadCpuAffinityMode_Test::TestBody() Original change's description: > Reland "base: Add API to restrict thread affinity to little cores on Android" > > This is a reland of 027aa92e > > Relanding but disabling test on CrOS devices (some of our CrOS devices > seem to have asymmetric CPUs that aren't covered by the test). > > Original change's description: > > base: Add API to restrict thread affinity to little cores on Android > > > > Adds functions that facilitate setting the CPU affinity of a given > > thread or process to all little cores on the system. > > > > We intend to use this API to run a power experiment. > > > > Bug: 1111789 > > Change-Id: I6c3d32c2338e9f00464e8b6a8c96af93658a3ae2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335176 > > Commit-Queue: Eric Seckler <eseckler@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#794998} > > TBR: dcheng@chromium.org > Bug: 1111789 > Change-Id: I59315ec0e9a1727986278a04fa5bde409143dfb5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339416 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Auto-Submit: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795126} TBR=dcheng@chromium.org,skyostil@chromium.org,eseckler@chromium.org Change-Id: I3be932b56d8b42e10a7179e5310d041c1b687c28 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339395Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795203}
-
Scott Violet authored
This moves some duplicate code to CoreFaviconService where it can be shared. BUG=1076463 TEST=none Change-Id: I0f6a26221acf189e57cd12a16d2624bd598917b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339388 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#795202}
-
Adam Langley authored
The caBLEv2 authenticator will need to use the network in the future. In order to avoid a dependency cycle from //chrome/browser to the feature module, and back to //chrome/browser (for getting the system network context), this change injects the Mojo object into the module. This involves moving the wrapper class (CableAuthenticatorModuleProvider.java) into chrome/browser/webauthn. BUG=1002262 Change-Id: I0240d3b05e1d51f7fe492eea5ad4e64af4111356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330930 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#795201}
-
Devlin Cronin authored
TBR=rogerta@chromium.org Bug: 1113127 Change-Id: I646148022f66e257186bceac2eb38843221b99bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339933Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795200}
-
Becca Hughes authored
We don't have search available for now. Change-Id: I7c363ead61f46af56c03d7f73f1f25e436517d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339283Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
Regan Hsu authored
The CL that previously addressed this problem only allowed pressing the toggle button to enable/disable reverse scrolling, when the entire row can be clicked in order to enable/disable reverse scrolling (except for the learn more link). Fixed: 1109966 Change-Id: Ica6eb360f2ac22770ff130f57b4cae5e58df2000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339603Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795198}
-
Xi Han authored
Extend the following histograms: - Memory.BackgroundTask.Browser.PrivateSwapFootprint.* - Memory.BackgroundTask.Browser.SharedMemoryFootprint.* - Memory.BackgroundTask.OfflinePrefetch.Browser.PrivateSwapFootprint.* - Memory.BackgroundTask.OfflinePrefetch.Browser.ResidentSet.* - Memory.BackgroundTask.OfflinePrefetch.Browser.SharedMemoryFootprint.* Bug: 1112399, 1112400, 1112401, 1112402, 1112403 Change-Id: Ifd0c20215f60fe76a092458e28f7cb02f1d71a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339758Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795197}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e7b08e4876fb..4c97814f3adc 2020-08-05 brianosman@google.com Fix SKP serialization when SK_DISABLE_EFFECT_SERIALIZATION is defined 2020-08-05 scroggo@google.com Reland "Add an SkImageGenerator that uses NDK APIs" 2020-08-05 jmbetancourt@google.com get rid of unused include 2020-08-05 robertphillips@google.com Simplify GrSmallPathRenderer::visitProxies 2020-08-05 mtklein@google.com remove overdrawcolorfilter_runtime 2020-08-05 adlai@google.com Remove staging API for SkImage::makeWithFilter 2020-08-05 adlai@google.com Migrate MakeFromAdoptedTexture to GrRecordingContext 2020-08-05 mtklein@google.com add a global may-we-JIT flag 2020-08-05 egdaniel@google.com Don't allow transferring between special queues in vulkan in surface flush. 2020-08-05 johnstiles@google.com Fix out-of-bounds array access discovered by fuzzer. 2020-08-05 nifong@google.com Publish version 0.17.3 2020-08-05 scroggo@google.com Revert "Add an SkImageGenerator that uses NDK APIs" 2020-08-05 bungeman@google.com Use SkUniqueCFRef with CTTypesetterCreateLine 2020-08-05 scroggo@google.com Add an SkImageGenerator that uses NDK APIs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108040 Tbr: herb@google.com Change-Id: Iead65fcd7be9143871ca224de4c3207347268cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339653Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795196}
-
Michael Moss authored
3d8daa2 Fix sym-upload-v2 whitespace in filenames. BUG=1021742 R=mark@chromium.org, nbilling@google.com Change-Id: Iafb23a63ee968024c6de7d5b636724384a6664af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339549 Commit-Queue: Michael Moss <mmoss@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Michael Moss <mmoss@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#795195}
-
wutao authored
Bug: b/162891584 Test: manual Change-Id: I912e7942787b0d2994e85a1570eb5bb1a0171578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337681Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795194}
-
Olivier Yiptong authored
Rename font icon name so it matches go/icons#icon=font_download Bug: 1112552 Change-Id: I7f3e5d9e70cc67e8fbf7ebfc037a3bea359ac31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339823Reviewed-by:
-
Adlai Holler authored
This is part of a larger effort, started in Chrome CL 2297920, to separate GPU-backed GrDirectContexts from DDL-backed GrRecordingContexts and remove the ambiguous GrContext class. Bug: skia:104662 Change-Id: I02b437b5925a4b6098c9bb720eb891ca3bb1c1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335812Reviewed-by:
Robert Phillips <robertphillips@google.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Adlai Holler <adlai@google.com> Cr-Commit-Position: refs/heads/master@{#795192}
-
Andrew Shulaev authored
This is needed in order to enable support for extension-based typed tracing events. For more information, see https://perfetto.dev/docs/design-docs/extensions Change-Id: I43bd82ee1c94cf7ae5be0a1fd7db4104cf8ece6a Bug: 161696674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332180Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Andrew Shulaev <ddrone@google.com> Cr-Commit-Position: refs/heads/master@{#795191}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bd6505349012..fb9c1110ef14 2020-08-05 bpastene@chromium.org Revert "ResultDB reporting for bot-triggered builds" 2020-08-05 nguyenmh@google.com Add a newline between commit messages If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1113350 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I12a0093612a0a27fb801b9959fc03ca0e1be2a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339545Reviewed-by:
-
Chris Harrelson authored
The first intended use-case of this is use in the CompositingAssignments update step for overlap testing. Bug: 1100711 Change-Id: I75e69d0633187fdc80eec71a74811453c6875cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339384Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795189}
-
Bruce Dawson authored
PEImage and PeImageReader are similar classes with slightly different behaviors. This change updates the comments to clarify how they differ. Change-Id: Id09868324b93d5a44731f778fb3f7684ca77736f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336303Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#795188}
-
Devlin Cronin authored
Test flakes on TSan. TBR=rogerta@chromium.org Bug: 1113376 Change-Id: I6f0b868e85c86c7994ae8e3eedb67869cb165c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340101Reviewed-by:
-
Peter Wen authored
Use consistent output dir detection from constants. See build/android/list_java_targets.py as an example. Bug: 1092528 Change-Id: I6392293a2b036ae419e1dc062e8c6f573fb7640d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339763 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#795186}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2914c6e6. With Chromium commits locally applied on WPT: dfdc7fe9 "[WPT] Errors caught/reported for importScripts()" 27a0731b "Origin isolation: add WPTs for contentDocument/frameElement" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I42b165b6e527a04854b0e257043c76a3c7ab3438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339222Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795185}
-
James Long authored
As part of UX discussions, the filter list is now a list of nodes that can be used in the filter. Whether a node is actually in the filter or not is toggled by its checkbox. "Select all" and "Deselect all" buttons have been added to make checkbox manipulation easier. A node enters the filter list through the filter input or the node details panel. It always enters in the checked state. A node exits the filter list through the user manually clicking the x beside it. Once in the filter list, the node's filter visibility can be toggled by a checkbox beside it or through the node details panel. Checkbox information is also encoded in the URL. Bug: 1111836 Change-Id: If92d64a9bdcfc93d6b86d1a335b795a5ab628c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333066 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
-
Gabriel Marin authored
Many times, high data cache miss rates and data TLB miss rates have root causes far removed from the function where the miss is actually occurring. Having callstacks, helps us understand data access and allocation patterns with poor locality. To set sampling intervals, I followed the pattern used for cycles flat vs. callgraph, where the latter has a 4x larger sampling interval. For DTLB miss cycles, we are currently collecting about 2x more samples per report than for other events, so I increased the sampling interval by 2 * 4 = 8. For LLC misses, we are collecting about 2x less samples per report than for other events, so I increased the sampling interval by 2.5x, more than 4 / 2, to be a bit conservative. Also increased samping interval for iTLB misses by 1.5x, as they are at the upper end of acceptable samples / report. BUG=b:162350244 Change-Id: Idd7d29d2e7535f3ddf99470d1980da14fccdcff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339827Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#795183}
-
Chris Hamilton authored
This defines a handful of MultiToken<> variants (and their mojom traits) that will be used in renderer code, as well as in renderer to browser IPC. BUG=1085129, 1096617 Change-Id: I548ecfe2824d2a8e78c0af8a197abebf2ab6fc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337104 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#795182}
-
James Cook authored
Fix a couple instances of "master". As of this CL, the following terms no longer appear in //ash -- master, slave, white_?list, black_?list. Bug: 1097644 Change-Id: I02f59e12cf587c97c7c12f88f00fac2a468e3cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339926 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795181}
-
dpapad authored
Suspecting that the test was flaking because of https://crbug.com/1111525, which is now fixed. Bug: 1111530 Change-Id: I5e68c2fc23155ad3eac608fa5d1b167720b665c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339814 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#795180}
-
Xianzhu Wang authored
Original patch: crrev.com/c/2319538 First reland: crrev.com/c/2333648 Changes in this patch (https://chromium-review.googlesource.com/c/chromium/src/+/2336301/1..10) 1. Fixed use-after-free of ContainingBlockScope. Similar to the first revert, the issue was because it was allocated in PaintInvalidatorContext which is in a vector replacing the real stack. ContainingBlockScope::outer_ might point to an invalid address if the vector was reallocated. Now use std::unique_ptr<ContainingBlockScope> in PaintInvalidatorContext. This increases the cost a bit but not much because ContainingBlockScope is created for LayoutBlockFlow with inline children only. 2. Rebased on crrev.com/c/2335647 which avoids memory regression caused by the original CL, and enables LayoutShiftTracker to use more accurate previous rects for shifted boxes. 3. Simplify LayoutShiftTracker::ReattachHook[::Scope]. Bug: 1108622 Change-Id: I7b4a85675483f7006ade8925c159a7882f08ec27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336301Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795179}
-
Rainhard Findling authored
* The C++ side of the Chrome cleaner child immediately condenses the received states to the ones that are relevant for the child. This reduces complexity on the JS side and simplifies recording metrics. Bug: 1087263 Change-Id: I4e2f8400be863c7a7c0c83e35ce2ba4856372c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328665Reviewed-by:
-
Roger Tawa authored
Bug: 1113367 Change-Id: If85efce44c5b84c41949c80534dc6a40d418016d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339548Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596635955-2b1d31dacdbaf52cf854414e21cd977f1d32db43.profdata to chrome-win32-master-1596643173-1c5e3b62f80a4dd3f16924cb334ea677bc923f5e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I13d20081550abb91d26374dded504b023ff97b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339541Reviewed-by:
-
Noah Rose Ledesma authored
In order for the global media controls dialog to display the currently used audio device in the UI the renderer needs to report what device is in use. Currently, MediaWebContentsObserver will receive messages when the output device is switched. However, the device id reported by the renderer is hashed so that it may be only used on one origin. This change has the MediaWebContentsObserver translate the device ID before passing it off to the MediaSessionControllersManager. Bug: 1111432 Change-Id: I11d161ff5f89525b4c465f01a779bdd30e31c823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331330 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fa9a15cb008b..fe8e758b920c 2020-08-05 thestig@chromium.org Rewrite OS_LINUX define. 2020-08-05 thestig@chromium.org Rewrite is_linux GN flag. 2020-08-05 tsepez@chromium.org Rename CXFA_NodeHelper to CFXJSE_NodeHelper and move to fxjs/ 2020-08-05 thestig@chromium.org Roll tools/clang/ 6cbea33c9..1078c4141 (10 commits) 2020-08-04 thestig@chromium.org Use |kAA| instead of "AA" string. 2020-08-04 thestig@chromium.org Remove some dead CPDF_FormControl code. 2020-08-04 thestig@chromium.org Roll third_party/zlib/ f87c8e288..7492de9a5 (3 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110266 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I857a1b9d415c8bd425194f933c82e65081afe49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338923Reviewed-by:
-
