- 29 Jan, 2019 40 commits
-
-
Yutaka Hirano authored
Bug: 894819 Change-Id: I9d1af51eff828564aa748742355e84695b6a1de7 Reviewed-on: https://chromium-review.googlesource.com/c/1442340 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#626944}
-
Stephane Zermatten authored
Before this patch, buttons were always displayed on prompt. That was incomplete: it did not allow reproducing the behavior we currently have between scripts where button appear as a result of DOM changes. With this patch, prompt button reproduce the between-script behavior, allowing buttons to be shown only conditionally. Bug: 122825639 Change-Id: I53eee48156cac1f2e5f1b81dd86a48bb25566a0c Reviewed-on: https://chromium-review.googlesource.com/c/1437084 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#626943}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7d49c734..4a58fb5f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7df0d92af7aaa3c854d36960d95b4c4df43037f8 Reviewed-on: https://chromium-review.googlesource.com/c/1442171Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626942}
-
Makoto Shimazu authored
Bug: 894819 Change-Id: Iae4624aeddfe755ce7fd34ce797d89fc0dfad039 Reviewed-on: https://chromium-review.googlesource.com/c/1428626 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#626941}
-
tzik authored
This test has been disabled for rebaselining for a V8 change. Bug: v8:8124 Change-Id: Ica0becc9069be89a723b7a26a3d5aafd4fd1a415 Reviewed-on: https://chromium-review.googlesource.com/c/1441972Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#626940}
-
Lei Zhang authored
Change-Id: I64b2f250e6d7573a9b3a5145d1a4f4f530b813a3 Reviewed-on: https://chromium-review.googlesource.com/c/1441958Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#626939}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I041eaaba3eb8fe88f0e5513761f1d0d069ba32e6 Reviewed-on: https://chromium-review.googlesource.com/c/1442453Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626938}
-
Stephane Zermatten authored
Before this patch, there were cases where the controller would enter graceful shutdown because of a script, with a successful message, and then notice an error, and change that message to an error. The error was usually caused by DidStartNavigation noticing an unexpected navigation event, triggered by an action run at the end of the last script. This patch attempts to avoid such case by: - only checking for unexpected navigation events in the PROMPT state. This specifically excludes the STOPPED and RUNNING states. - not reporting errors or accepting script updates (OnGetScript) in the STOPPED state - stopping script checks when entering the fatal error state Bug: 806868 Change-Id: I408d2652257d9524740e44c79b7fa5201ef7cc17 Reviewed-on: https://chromium-review.googlesource.com/c/1436047 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
In the previous change, I forgot to add DISALLOW_COPY_AND_ASSIGN macro to the SharedCorsOriginAccessList. Bug: N/A Change-Id: Ib23a0d04392c76eca5865632e616ff3aaf3b671e Reviewed-on: https://chromium-review.googlesource.com/c/1438779Reviewed-by:
-
Hirokazu Honda authored
crrev.com/c/1437036 makes GbmWrapper create GbmPixmap which has one file descriptor for each plane. This CL follows the change in chrome os capture stack. Bug: 911370 Test: capture_unittests Change-Id: Ia498f36d9f4edd074cba4dc8ea5bc863364297c1 Reviewed-on: https://chromium-review.googlesource.com/c/1438858 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#626935}
-
Mohamed Amir Yosef authored
This CL updates ShouldGetAllDataForDebuggingWithHiddenPassword test in PasswordSyncBridgeTest to make sure it doesn't pass if the bridge returns an empty batch. Bug: 902349 Change-Id: I089c2e6a7be3487c9b19d39896fcea5503ab74f6 Reviewed-on: https://chromium-review.googlesource.com/c/1439539Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#626934}
-
David Staessens authored
This CL moves code to load and manage test image files to a dedicated class. Image metadata (such as image size, checksum,...) is stored in json files accompanying the test files, so it doesn't need to be hardcoded in every test anymore. TEST=ran image_processor_test on nocturne BUG=925223 Change-Id: I94d827be438e691f8c18307227bcd86a767e24a5 Reviewed-on: https://chromium-review.googlesource.com/c/1436278 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#626933}
-
Michael Giuffrida authored
Use EXTERNAL_POLICY[_DOWNLOAD] for the manifest locations so Chrome apps are allowed to install. Bug: 925419 Change-Id: Ie65c76a28d8ebe5c63ee4d54cd2449b8759f9e18 Reviewed-on: https://chromium-review.googlesource.com/c/1437543 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#626932}
-
Tanya Gupta authored
Previously the only requirements for whether to display the option was that the feature was enabled and the user was not currently on an incognito web page. This CL adds the following requirements: - The sync type SEND_TAB_TO_SELF must be enabled. - The number of devices the user uses with sync must be >= 2. - The user must currently be on an HTTP or HTTPS page. - The user is not on an Android native page. - Active tab is not in inCognito mode Bug: 921767 Change-Id: Ifab23067d34b97f5ef1026bf906a8b6fc656176f Reviewed-on: https://chromium-review.googlesource.com/c/1399446 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#626931}
-
Makoto Shimazu authored
Previously it's marked as flaky on Linux, Windows, Mac10.10/11/12. However, even in other platforms the test looks failing sometimes, so probably it's caused by some timing issues and just fortunately it happens less frequently in some platforms. This patch marges the TestExpectations entries for the test into one entry. Flakiness dashboard for reference: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fcss%2Fvendor-imports%2Fmozilla%2Fmozilla-central-reftests%2Fflexbox%2Fflexbox-intrinsic-ratio-003v.html TBR=cbiesinger@chromium.org No-Try: true Bug: 898186,919736,879336,878316,813602 Change-Id: Id184bf7dd4d66e96b41e2872574ea10ceb9fbd46 Reviewed-on: https://chromium-review.googlesource.com/c/1442393 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1441657. This enables the queue when onmessage is assigned to. It adheres to the specification at https://w3c.github.io/ServiceWorker/#dom-serviceworkercontainer-onmessage: "The first time the context object’s onmessage IDL attribute is set, its client message queue must be enabled." This makes the test cases about "setting onmessage" in the WPT postmessage-to-client-message-queue.https.html pass, but the test file will still time out until startMessages() is implemented. Bug: 915685 Change-Id: I4c4930b48df68ee351676e5c3edfb28969fe3610 Reviewed-on: https://chromium-review.googlesource.com/c/1441734 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#626929}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8922ac230f33..4b2e00f4d180 git log 8922ac230f33..4b2e00f4d180 --date=short --no-merges --format='%ad %ae %s' 2019-01-29 jmadill@chromium.org Suppress EmptyBuffer test on Android GLES. 2019-01-29 jmadill@chromium.org Vulkan: Use glslang's internal BUILD.gn. Created with: gclient setdep -r src/third_party/angle@4b2e00f4d180 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I954ab10a52c3bfe23656f30241e7407d98ee59c0 Reviewed-on: https://chromium-review.googlesource.com/c/1441536Reviewed-by:
-
Hirokazu Honda authored
Original change's description: > Revert "ozone: Remove mesa i965 same-fd workaround restriction" > > This reverts commit 46eb9e27. > > Reason for revert: causing tast failures on amd64-generic VM bot > > See https://bugs.chromium.org/p/chromium/issues/detail?id=923061#c2 > > Original change's description: > > ozone: Remove mesa i965 same-fd workaround restriction > > > > NOTE: This is based on crrev.com/c/549576. > > > > After Mesa same-fd for eglCreateImageKHR restriction was relaxed in > > crrev.com/c/378198/, it is now possible to remove the workaround in chromium. > > > > The changes are as follows: > > 1. ClientNativePixmapDmaBuf can map multiple plane using multiple FDs. > > 2. GLImageNativePixmap can create EGLImage using multiple FDs. > > 3. GbmBuffer/GbmPixmap manages multiple FDs. > > > > BUG=642410, 911370 > > TEST=VDA unittest and VEA unittest > > TEST=Playback with Chrome ARC++ and ARC++ DRM L1 on kevin, hana, eve > > TEST=Playback with Chrome on peach_pit and nyan_big > > > > Change-Id: I23848b8bcd0e240307633a5201b4b8e58b374282 > > Reviewed-on: https://chromium-review.googlesource.com/c/1362777 > > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > > Reviewed-by: Pawel Osciak <posciak@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#623686} > > TBR=rjkroege@chromium.org,posciak@chromium.org,dcheng@chromium.org,dcastagna@chromium.org,hiroh@chromium.org > > Change-Id: Ie9620b2022ec37ca5e55613d4fbe63247d357862 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 642410, 911370, 923061 > Reviewed-on: https://chromium-review.googlesource.com/c/1418124 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#623761} TBR=rjkroege@chromium.org,posciak@chromium.org,dcheng@chromium.org,dcastagna@chromium.org,bpastene@chromium.org,hiroh@chromium.org Bug: 642410, 911370, 923061 Change-Id: I2dff0f134380be418d21ac7dc90e49f802f11b90 Reviewed-on: https://chromium-review.googlesource.com/c/1437036Reviewed-by:
-
Matt Falkenhagen authored
The spec has a concept of execution ready, defined (for documents) to be when a Document is created and assigned to a Window: https://html.spec.whatwg.org/multipage/webappapis.html#concept-environment-execution-ready-flag Clients that are not execution ready should never be exposed to JavaScript as a Client object. In particular, Clients API like clients.get() and clients.openWindow() should not resolve to a non-execution-ready client. Before this CL, we considered a client to be execution ready upon navigation commit. This was too early, as the document might not yet be created. There are two motivations for fixing this timing: 1. (https://crbug.com/915685) Client.postMessage() is supposed to queue the message until the Document reached DOMContentLoaded. It's difficult to implement that correctly if postMessage can be posted on a non-execution ready client, since by the time the message arrives, we might look at the Document and see it is not parsing (HasFinishedParsing() returns true), therefore conclude it reached DOMContentLoaded. In fact, the Document might have just been created and not started parsing yet. 2. (https://crbug.com/924959) It's incorrect to expose Clients that are sandboxed to a unique origin via CSP HTTP response header. By waiting until Document creation, we can detect this sandboxing and not resolve the client. This CL splits the concept of "execution ready" into "execution ready" as in the spec, and "response committed" as in commit navigation. This unblocks, but does not fix, the bugs listed above. Bug: 924958, 924959, 915685 Change-Id: Ic4b515aa24057cce3d5961a88ca0de0b789390dd Reviewed-on: https://chromium-review.googlesource.com/c/1438678Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#626926}
-
Vikas Soni authored
Supress Pixel_BackgroundImage test which is flaky on Nexus 5X(android-marshmallow-arm64-rel trybot). Bug: 883500 Change-Id: I54412764b19e8cea273f98594cc8c6ad2ba1507b Reviewed-on: https://chromium-review.googlesource.com/c/1441312 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#626925}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=benwells@chromium.org Bug: 925652 Change-Id: Ibebae3e41aeb0549156b1aace0aa7197e821fe62 Reviewed-on: https://chromium-review.googlesource.com/c/1438317 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d8a90f9be1f0..70041cf243b8 git log d8a90f9be1f0..70041cf243b8 --date=short --no-merges --format='%ad %ae %s' 2019-01-29 halcanary@google.com third_party/icu: move file list to icu.gni 2019-01-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f2110ca4..1fbbe6ad (417 commits) 2019-01-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bfdb95a639b9..ec061ddc31ca (1 commits) 2019-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4c94788c9c85..0f073667daf0 (2 commits) 2019-01-28 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-28 brianosman@google.com Update color space API in examples 2019-01-28 kjlubick@google.com Adjust variable names from paint to font 2019-01-28 reed@google.com Some clangtidy fixes 2019-01-28 jvanverth@google.com Switch sk_app to use native window creation on MacOS. 2019-01-28 brianosman@google.com Switch nanobench to SkJSONWriter 2019-01-28 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 314ad8112fb9..bfdb95a639b9 (1 commits) Created with: gclient setdep -r src/third_party/skia@70041cf243b8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I29bbdd72452c03f7f3526b385beaeb358a1dfb17 Reviewed-on: https://chromium-review.googlesource.com/c/1441292Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 835717 Change-Id: I8b2d7808b8e5cd2c4353735f5a14958e0e263d92 Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1442041Reviewed-by:
-
Yoichi Osato authored
ComputeSelectionStatus was called also at dirty layout only for test purpose. However we should call it only at clean layout. This patch DCHECKs the condition and brushes up the test not to do so. Bug: 708452 Change-Id: If19ff331b4945a6506719b0154378960d50b8f1f Reviewed-on: https://chromium-review.googlesource.com/c/1441732Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#626921}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/79ff8bead909..74e95fff4a11 git log 79ff8bead909..74e95fff4a11 --date=short --no-merges --format='%ad %ae %s' 2019-01-29 bryan.bernhart@intel.com Memory manager: buffer uploads (D3D) - Part 1 Created with: gclient setdep -r src/third_party/dawn@74e95fff4a11 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If4757539655480607a9a3f6b17332ab33bc9194f Reviewed-on: https://chromium-review.googlesource.com/c/1441538Reviewed-by:
-
Xianzhu Wang authored
This reverts commit d855623a. Reason for revert: Need to think more about paint order of overlay scrollbars. Original change's description: > [CI/PE] Simplify overlay scrollbar painting > > The bug describes how the old code worked and how it caused bugs. > > The new code paints normal scrollbars in the background paint phase, > and overlay scrollbars in the foreground paint phase, eliminating > the second paint pass. > > This changes z-ordering of overlay scrollbars in some cases, but > the new behavior is consistent with composited and non-composited > layers, and in CompositeAfterPaint. The new behavior is that the > overlay scrollbars appear on top of the scrolling contents, but below > the outline phase of the current stacking context and other stacked > contents with higher z-ordering. The new behavior is the same as the > previous behavior when the scrolling block is composited. > > Bug: 918155 > > Change-Id: I3144af2a2e00e03cb370f4245353c13afe6b5ede > Reviewed-on: https://chromium-review.googlesource.com/c/1391676 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619485} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 918155, 924852 Change-Id: Id375f6b24e476a2e4b7038745c096246c1770579 Reviewed-on: https://chromium-review.googlesource.com/c/1441963 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#626919}
-
Matt Falkenhagen authored
This introduces the enabling/disabling mechanism for the client message queue as described in: https://w3c.github.io/ServiceWorker/#dfn-client-message-queue The client message queue should be disabled until one of the following occurs: * DOMContentLoaded is fired[1] * startMessages() is called (not yet implemented) * onmessage is assigned to (not yet implemented) This CL enables the queue on DOMContentLoaded. This makes partially makes the WPT test postmessage-to-client-message-queue.https.html pass. The test case "Messages from ServiceWorker to Client only received after DOMContentLoaded event." passes. But the test file still times out because the other triggers are not implemented. It will also be flaky until bug 924958 is fixed. [1] At https://html.spec.whatwg.org/multipage/parsing.html#the-end: 1. Fire an event named DOMContentLoaded at the Document object, with its bubbles attribute initialized to true. 2. Enable the client message queue of the ServiceWorkerContainer object whose associated service worker client is the Document object's relevant settings object. Bug: 915685 Change-Id: Ifcd84687f70f98f1558b35b0e3044a7c4662a567 Reviewed-on: https://chromium-review.googlesource.com/c/1441657 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
We are planning to deprecate all Web MIDI uses on insecure origins. This patch starts showing a deprecation warning on non-sysex uses to say we will prompt for permission from M75, and it results in disabling all Web MIDI uses on insecure origins. Bug: 662000, 924471 Change-Id: If8163830984f5e95f6defeb97bd769942c6e08b4 Reviewed-on: https://chromium-review.googlesource.com/c/1425058 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#626917}
-
John Abd-El-Malek authored
The test in src/content isn't sufficient, since Chrome adds a bunch of code. Also fix the thread profiler asserting. Bug: 925436 Change-Id: I84e7b9594238d81be4a8fabfab6e7c6fcd7b9f6d Reviewed-on: https://chromium-review.googlesource.com/c/1437197 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#626916}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/edb4ccca4f09..950cb58638ea Created with: gclient setdep -r src-internal@950cb58638ea The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id6836e38a1b0dd072424782ea35f74095eb1b2cd Reviewed-on: https://chromium-review.googlesource.com/c/1441539Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626915}
-
Dominik Röttsches authored
This reverts commit 1841a794. Reason for revert: HarfBuzz roll which caused test failures has already been reverted. https://chromium-review.googlesource.com/c/chromium/src/+/1439970 Original change's description: > Mark several text layout tests as failing on Mac > > fast/text/atsui-spacing-features.html > fast/text/emphasis-complex.html > fast/text/international/hebrew-vowels.html > svg/text/combining-character-queries.html > svg/text/ligature-queries.html > svg/text/surrogate-pair-queries.html > > TBR=drott@chromium.org > > Bug: 925866 > Change-Id: Iafb0f31852b96c46a725e404e85debd875d96ed5 > Reviewed-on: https://chromium-review.googlesource.com/c/1440021 > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626634} TBR=drott@chromium.org,mcnee@chromium.org Change-Id: Icb43a6d325a0b2a63f9e61d2e1a451960aaa3d6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 925866 Reviewed-on: https://chromium-review.googlesource.com/c/1442251Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#626914}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3f812d07b2aa..b69515579db8 git log 3f812d07b2aa..b69515579db8 --date=short --no-merges --format='%ad %ae %s' 2019-01-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@b69515579db8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I3fb9dfb590f212a267f55e9ba02124a36e7688ad Reviewed-on: https://chromium-review.googlesource.com/c/1441354Reviewed-by:
-
Fergus Dall authored
Currently, if the user creates addition non-default containers and then uninstalls crostini, and apps in those non-default containers will continue to show up in the app launcher. This CL changes this behaviour to remove all apps associated with the default VM instead. Change-Id: Ieaa1ea6c434480cd5a2e4dfe7b05eb497ffc9917 Bug: 921163 Reviewed-on: https://chromium-review.googlesource.com/c/1429359Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#626912}
-
Alexey Baskakov authored
- Rename Init as Start. - Rename CreateSubsystems as Init. As a result, Init is truely the first thing that must be called before using the instance. Bug: 920062 Change-Id: I5606250f10c3d249a994f19b71682a8d95e44be0 Reviewed-on: https://chromium-review.googlesource.com/c/1442072Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#626911}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/966762d3..7d49c734 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I758b06b81d1524575e7c50c965374e828b77108b Reviewed-on: https://chromium-review.googlesource.com/c/1441957Reviewed-by:
-
Xianzhu Wang authored
This fixes crashes (due to duplicated DrawingDisplayItem ids) of overlay layout tests in CompositeAfterPaint mode. Sample errors: https://test-results.appspot.com/data/layout_results/linux_layout_tests_composite_after_paint/761/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html Test: compositing/visibility/overlays*.html in CompositeAfterPaint mode. Bug: 524134 Change-Id: I206e191bd01768388f1192846d7370abe5f652ed Reviewed-on: https://chromium-review.googlesource.com/c/1440524Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#626909}
-
Giovanni Ortuño Urquidi authored
No behavioural change; just refactor the code to use async/await. Bug: 908288 Change-Id: I533c05538e25fa5e4176a7373706dd479c6009b1 Reviewed-on: https://chromium-review.googlesource.com/c/1379594 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#626908}
-
chrome://app-iconReka Norman authored
This CL changes the app management page to load its app icons from chrome://app-icon instead of chrome://extension-icon. It also fixes a bug which prevents the default icon from loading in some cases where the icon can't be found. The chrome://app-icon url currently doesn't work for some Chrome system apps (e.g. Web Store, Audio Player), so this will require further investigation. Bug: 906508 Change-Id: Ib350bf2490193fd17c807d2677f05355eefeb6bf Reviewed-on: https://chromium-review.googlesource.com/c/1428620 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#626907}
-
Xiaoqian Dai authored
It can improve the fps of overview window dragging about 4~5fps. Bug: 925131, 925122 Change-Id: Ia76d1baf2e8a35f5dd53e1ec7bb325ab4f6c45eb Reviewed-on: https://chromium-review.googlesource.com/c/1439930 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#626906}
-
Alexey Baskakov authored
Split up creation and start-up of all WebAppProvider subsystems. A separate end-end construction and init phase allow us to write better integration tests (override selected subsystems with mocks before Init). In the future, we want to defer Init until WebAppProvider::OnRegistryReady moment to prevent init races. Bug: 920062 Change-Id: Id77676dbeca2449a5148d7c00b1b08a886e1e8b8 Reviewed-on: https://chromium-review.googlesource.com/c/1429323 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
