- 18 Jun, 2018 40 commits
-
-
Sadrul Habib Chowdhury authored
rendering benchmark is the new benchmark we are going to focus on, and smoothness benchmark is going to be removed. So update cluster telemetry to run the rendering benchmark instead. BUG=760553 Change-Id: Ief60f9e12d2b0ad3776fe1d2beffd999e4784f51 Reviewed-on: https://chromium-review.googlesource.com/1103852Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#568025}
-
Eliot Courtney authored
AFBC for modeset buffers doesn't work correctly, as we can't fill them with valid AFBC contents. For now, don't use AFBC for modeset buffers. Remove this after we make ozone/drm capable of creating valid AFBC modeset buffers (tracked by crbug.com/852675). Bug: 852675, 853328, b/109782243 Test: External monitor works on Kevin Change-Id: I902f2615aa78e34251381f87e25c5e76f39b94b5 Reviewed-on: https://chromium-review.googlesource.com/1100666 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#568024}
-
Gyuyoung Kim authored
This reverts commit cdd97e24. After perf-bot reported a regression in timeToFirstMeaningfulPaint, timeToFirstContentfulPaint, and timeToFirstPaint on android nexus5, the original CL was reverted. However, the regression looks reasonable because ReleaseMemory could be called before FCP and FMP came on low-end devices if the website needs to use much memory. I guess that the regression caused because the test website(edition.cnn.com) was consuming too much memory on the mobile device. Bug: 850977, 851868 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icc8e5f24c114947fe8d186f699d0457ea82b7416 Reviewed-on: https://chromium-review.googlesource.com/1096921Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#568023}
-
yoshiki iguchi authored
Previously, only the snooze setting hides the buttons and disables swipe. This CL makes the inline setting do so. This is consistent with Android. Bug: b/110329209 Test: manual (check the buttons are invisible and swipe is prohibited). Change-Id: Ie177b445653eb74c9c01816fa0a09991875419dd Reviewed-on: https://chromium-review.googlesource.com/1102437Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#568022}
-
Henrik Grunell authored
This enables the feature with the same name. Bug: 830624, 826664 Change-Id: I156e197bc4a5f0a322747ad13def5ef361d3b173 Reviewed-on: https://chromium-review.googlesource.com/1014083 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#568021}
-
Rohit Rao authored
This method was incorrectly invoking an EarlGrey method that scrolled to the bottom of the view, not the top. BUG=853330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic5bfe4be02594828c4c12a45e3dab78a51641cac Reviewed-on: https://chromium-review.googlesource.com/1104382Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#568020}
-
Fredrik Söderquist authored
Looks like the last caller was removed in https://codereview.chromium.org/2287433003 . Change-Id: I2664063bab31fe4983be65cb5c21039a90b73920 Reviewed-on: https://chromium-review.googlesource.com/1104342Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568019}
-
Nico Weber authored
The framework depends on libfoo.dylib, and when we symbolize this dependency, we use dirname(libfoo.dylib) -> '' as @loader_path, turning the rpath @loader_path/. into the absolute path /. Call realname() on the file before calling dirname to fix this, and to fix a second (latent) bug where the rpaths should be relative to the symlink targets, not to symlinks. (I think this was always broken, but harmless before I made GetSharedLibraryDependenciesMac() error out on resolving failures, and harmless in practice since the framework itself symbolized itself and its deps fine, just resolving the deps of the deps would silently fail before I made it fail loudly.) Bug: 853716 Change-Id: I519f786f785bcae8b5d64edc8ff1a883edba5c72 Reviewed-on: https://chromium-review.googlesource.com/1104393Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#568018}
-
Jérôme Lebel authored
Adding coordinator and an empty view controller for the Google services settings. This work is related Unity. Screenshots: https://drive.google.com/open?id=175ZmSyXJQsz_EJMezwu0WhnUuGJM-xxZ https://drive.google.com/open?id=1kHqvfmCxoN6IsDfsj9TR0VxdqzoBff-M Mock: https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g3b9ec33d4d_17_39 Test target added with: crrev.com/i/640917 Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7eb7ff3018a5bcef75e6c7ffddf79497a8a2fa38 Reviewed-on: https://chromium-review.googlesource.com/1096599Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568017}
-
Emily Hanley authored
NOTRY=true TBR=charliea@chromium.org Bug: 853763 Change-Id: I5e9b428c9f7b86160f391a8d0d74ed0434427af0 Reviewed-on: https://chromium-review.googlesource.com/1104316Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#568016}
-
Kevin Bailey authored
We missed a place where an inset needed to be tweaked for tab switch suggestions. Also, it was choosing the wrong image for rich + tab switch suggestion. Bug: 780835 Change-Id: I2f74618584480d9857a5e5c5e7c82636735d7c6b Reviewed-on: https://chromium-review.googlesource.com/1102913Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#568015}
-
Ben Wagner authored
The related Skia change has landed, enable the fix and rebaseline. BUG=skia:8042 Change-Id: Ia32cf8ec51e07202680388e3863e509979a76378 Reviewed-on: https://chromium-review.googlesource.com/1102484Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568014}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0242b59c0aaf..1bb47df4fc8e git log 0242b59c0aaf..1bb47df4fc8e --date=short --no-merges --format='%ad %ae %s' 2018-06-18 caryclark@skia.org fast path for pathops 2018-06-18 caryclark@skia.org remove SK_MaxSizeT from docs Created with: gclient setdep -r src/third_party/skia@1bb47df4fc8e The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Ie4e22cb8df55fe7ef97317d781be660e5b756cf1 Reviewed-on: https://chromium-review.googlesource.com/1104437Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568013}
-
Philip Rogers authored
In [1] we found tests were being run with BlinkGenPropertyTrees enabled but without use_layer_lists. This issue is difficult to debug and will hit other developers. This patch adds a DCHECK that use_layer_lists is enabled. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1083012 Bug: 836902 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0c9cc1393100a66528abae84842e2164fb4ad107 Reviewed-on: https://chromium-review.googlesource.com/1102562Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568012}
-
clamy authored
This CL is part of a serie of CLs to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: I28d733a8f7fd7935b2cae8f7bea7d96be5370e00 Reviewed-on: https://chromium-review.googlesource.com/1102500 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#568011}
-
Marc Treib authored
It's mostly failing on "Win7 Tests (dbg)(1)" TBR=rockot@chromium.org Bug: 853733 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I667d434cc382d96a6e5ab37b9697f40e4506a690 Reviewed-on: https://chromium-review.googlesource.com/1104435Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568010}
-
Adam Rice authored
CallExtraOrCrash is a function to call into V8 Extras and crash if it fails. Unfortunately, calling into V8 Extras can fail under normal conditions such as stack overflow and Worker destruction, causing a lot of unnecessary crashes. Remove CallExtraOrCrash. This is a stopgap change designed to be mergable to version 68. It avoids major code restructuring but as a result lacks robust encapsulation. The general strategy is to pass a boolean pointer to functions in ReadableStreamOperations that call into V8 Extras. If the internal call fails, the boolean is set to true, and the call returns a default value. BodyStreamBuffer keeps the boolean as member variable. Once a call to a V8 extra function fails, the boolean is set and no more calls will be made. This is to avoid us taking action based on information that is incorrect. For Tee() and the from-stream version of the BodyStreamBuffer constructor, we use an ExceptionState object instead. In these cases, it is straightforward to pass through ExceptionState object from the Blink bindings. This allows the failure to be propagated safely back to Javascript. Conversely, DefaultReaderRead() has been switched from using ExceptionState to using an error-signalling bool. This is because its callers do not have access to a real ExceptionState object. Previously callers used a NonThrowableExceptionState, but this was not suitable as DefaultReaderRead() can throw. BodyStreamBuffer mostly wraps access to ReadableStreamOperations, so some degree of encapsulation has been retained. 7 new layout tests exercise each of the deterministically reachable crashes, using stack overflows. Because they depend on stack layout and whether DCHECKs are enabled, they only hit the crashes in particular environments. Bug: 829790, 849312 Change-Id: I47481b33a47b418dc6916e3b4311e60b5fd89e3d Reviewed-on: https://chromium-review.googlesource.com/1097047 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#568009}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ae92f3c98fbe..15590d1a9bee git log ae92f3c98fbe..15590d1a9bee --date=short --no-merges --format='%ad %ae %s' 2018-06-18 yueherngl@google.com nami: mark paladin as important (not experiment) 2018-06-18 yueherngl@google.com dragonegg: add new paladin Created with: gclient setdep -r src/third_party/chromite@15590d1a9bee The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=chrome-os-gardeners@chromium.org Change-Id: Ie533bcbdb822b30e8848b47897cfe2dd3c795a0a Reviewed-on: https://chromium-review.googlesource.com/1104397Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568008}
-
Christian Dullweber authored
Make BrowsingDataCookieHelper compatible with the network service by converting it to use CookieManager. Bug: 843995 Change-Id: I92db772d7ab63ca51fbaabd618f6b4d77fd784b3 Reviewed-on: https://chromium-review.googlesource.com/1101022 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#568007}
-
Rune Lillesveen authored
We incorrectly did an override with kForce for ::first-letter recalc when we were already recalculating style for re-attachment (kReattach). This caused crashes in FirstLetterPseudoElement::DidRecalcStyle. Bug: 853621, 853476, 853471, 853470, 853433, 853411 Change-Id: Id34e6bdbaaeb3b4933a3e963b68f0bffcda0e40e Reviewed-on: https://chromium-review.googlesource.com/1104176 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#568006}
-
Justin Donnelly authored
These features (tab switch suggestions, new answer layout and rich entities) all work without the MD Refresh UI, but the layout looks weird. It's not something we'd want to launch. So this change disables them if the MD Refresh UI is not also enabled. The intent in taking this approach (vs. just enabling the correct combination of flags manually or via experiment config) is two-fold: 1. Ensure that when we start experiments on these, if the MD Refresh UI is turned off, these features will automatically be turned off as well for users in the experimental group. 2. Prevent people from enabling the new features without MD Refresh and then filing bugs for a configuration that we don't intend to support. Change-Id: Ie29ba598ae04a4d5e14437d0dd8d5e189815ef40 Reviewed-on: https://chromium-review.googlesource.com/1103152Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#568005}
-
Egor Pasko authored
The http://crbug.com/747130 is fixed, hence URLLoaderInterceptor should work for frame requests - remove the obsolete comment. Also fix a typo in a comment nearby. Seems like a typo to sincerely yours, non-native speaker. Bug: 747130 Change-Id: I7d88a09ce459d69348c3751fae845b5152324dff Reviewed-on: https://chromium-review.googlesource.com/1104431Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#568004}
-
Ella Ge authored
This CL adds scroll predictor in compositor thread under flag kResamplingScrollEvents. design doc: https://docs.google.com/document/d/1g6eGYdLZKznF3sCiktc5BbAPeiudWk8xTzx3qdrxowI/edit# Bug: 836352 Change-Id: Iecfad7ad75dd4b871426e00a2f2d542996544b07 Reviewed-on: https://chromium-review.googlesource.com/919662 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568003}
-
Dave Tapuska authored
Add the ability to fetch the stale while revalidate field out of the cache control header. BUG=348877 Change-Id: I7e6132b71c10c462019687a150e259e02fe9c332 Reviewed-on: https://chromium-review.googlesource.com/1101242 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#568002}
-
Balazs Engedy authored
Bug: 847985 Change-Id: Ibc8ac6cda1aaf9bfb519ba44a4ef748cc3891e1f Reviewed-on: https://chromium-review.googlesource.com/1101681Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568001}
-
David Roger authored
This CL converts almost all the remaining code to use AccountConsistencyModeManager. There are a few calls left in tests and debugging code, which will be converted in a follow-up CL. TBR=stevenjb Bug: 777774 Change-Id: Ic2da79f6b332880e2143425c91ab50322b9d542f Reviewed-on: https://chromium-review.googlesource.com/1099069 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#568000}
-
Emily Hanley authored
TBR=charliea@chromium.org NOTRY=true Bug: 853738 Change-Id: I9939821fddae4cdbba93d89fc47a089fbefee842 Reviewed-on: https://chromium-review.googlesource.com/1104307Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#567999}
-
Hans Wennborg authored
Bug: none Change-Id: I3622122b52039f04028627505ca432b154cad4da Reviewed-on: https://chromium-review.googlesource.com/1104345 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#567998}
-
Moe Ahmadi authored
After crrev.com/c/1078871 that updated FormSuggestionView and FormSuggestionLabel to use AutoLayout, the Google Pay logo stopped animating. This CL fixes that regression and also changes the code slightly so that the subviews are more lazily created. Bug: 852890 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5388a3c4a7df2819e14b5772368e07f16c98564e Reviewed-on: https://chromium-review.googlesource.com/1101543 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567997}
-
Josh Karlin authored
Bug: 853283 Change-Id: I67cd9784a6b4fb7fa3b6279c590b9e4f42ba2e0f Reviewed-on: https://chromium-review.googlesource.com/1104383Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567996}
-
Francois Doray authored
This CL adds a function that determines if a state transition is valid in TabLifecycleUnit. This will help us ensure that things work properly as we add more possible state transitions (e.g. periodic unfreeze). Bug: 775644 Change-Id: I89e90021415f68edbed1aca1d6f0052057cd44e9 Reviewed-on: https://chromium-review.googlesource.com/1097550Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#567995}
-
Dominic Farolino authored
This CL removes layout tests for deprecated console methods as well as removes expectation files for failing console WPTs that assert the non-existence of these methods. These need removed so that the v8 auto-roll with the removed console methods don't fail the chromium layout tests. Also this CL removes the test expectations for console WPTs that assert the non-existence of these deprecated methods, but marks the tests as skipped for now, until the v8 changes are in chromium. R=kozyatinskiy@chromium.org Bug: 706804 Change-Id: If11e0c6a26d6ccc29474fb0148900d034cd40b86 Reviewed-on: https://chromium-review.googlesource.com/1103937Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#567994}
-
Takuto Ikuta authored
Recently, I saw some tests has large shard duration. http://shortn/_XYVwYNWZJb This CL increases the number of shard so that tests in CQ has 15 minutes average shard duration. Change-Id: If4011de7a6c3c6f98e98bc70ba2fa9a87aca8f90 Reviewed-on: https://chromium-review.googlesource.com/1104277Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#567993}
-
Mustaq Ahmed authored
Bug: 802291 Change-Id: I2b8e7ee5cd61cc31e07bd7d2ed6da69a43743b80 Reviewed-on: https://chromium-review.googlesource.com/1097796Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#567992}
-
Marc Treib authored
It's too slow and times out. TBR=fukino@chromium.org Bug: 851988 Change-Id: I868d846e3fae5f7dd16b2a2c7203602008221396 Reviewed-on: https://chromium-review.googlesource.com/1104424Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#567991}
-
Douglas Creager authored
This updates the Reporting implementation to include the naming changes in https://github.com/WICG/reporting/issues/72. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2446a8baaf512760949ac5bcaae56088def7d600 Reviewed-on: https://chromium-review.googlesource.com/1073060 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#567990}
-
Daniel Nicoara authored
The curent implementation tries to order one window in a list of potentially unordered windows. The window list is not always ordered since we never order hidden windows. Use stable_sort to order all windows by ID. Between windows with the same ID, promote the window currently becoming visible. BUG=NONE TEST=Verified on device and wrote unittests to cover window ordering. Change-Id: I52a760a6fbb84752a523c89ba39963f443ab4712 Reviewed-on: https://chromium-review.googlesource.com/1103296Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#567989}
-
Bence Béky authored
Bug: 807724 Change-Id: I018eb874f2e9097dba9d8acdf58d6a18c569cc9d Reviewed-on: https://chromium-review.googlesource.com/1100354Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#567988}
-
Jared Saul authored
(Also alphabetized the autofill category) Change-Id: I18f03d1404c166ce5d46c8abd7db935aff360615 Reviewed-on: https://chromium-review.googlesource.com/1103587 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#567987}
-
Marc Treib authored
TBR=minch@chromium.org NOTRY=true Bug: 838756 Change-Id: I3cf207f31b7063f64c87d7cc0d8a93e6299ed5cd Reviewed-on: https://chromium-review.googlesource.com/1104418Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#567986}
-