GitLab

This CL updates the a11y popup type for the media toolbar button to fix
an issue where JAWS would tell the user to use arrow keys instead of
the tab key.

Bug: 1022971
Change-Id: I6523bdd9380ec61cfbb05a86923c654877e818e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906636
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714669}

Bug: 927411
Change-Id: Ia2fabf76ef8faa3b8d875b8625572c81eef20946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911488
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714668}

Bug: 1020450
Change-Id: Ic865cbaf3c38b39c1dc840510fb5ad5190deb7fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898808
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714667}

This reverts commit 85bd68c7.

Reason for revert: for transitions from Child to Regular account, and
from Regular to Child account all secondary accounts are going to be
removed from Chrome OS Account Manager (so we don't need to remove the
accounts from ARC).

Original change's description:
> Disallow secondary accounts in ARC for Child users
>
> Project Beaker on Chrome OS is going to allow child users the addition
> of secondary accounts, but it's going to be limited to web only.
>
> - If user has transitioned from child account to regular -
> TriggerAccountsPushToArc will add accounts to ARC on startup.
> - If user has transitioned from regular account to child -
> HandleSupervisionTransition will remove all secondary accounts from
> ARC.
>
> Update is going to be executed on startup, since to transition to
> another type, user need to sign-out and sign-in again (I think).
>
> ARC CL: http://ag/9615344
>
> Bug: 1017160
> Change-Id: I323a18aca9c9f63e6a3869d9b9dd4dd34432c31c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876089
> Reviewed-by: Mattias Nissler <mnissler@chromium.org>
> Reviewed-by: Yury Khmel <khmel@chromium.org>
> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711171}

Bug: 1017160
Change-Id: Ie44780d372a2c4b9a85327e93be29a2ede0ad9e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904073Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714666}

Fix a typo when setting the property to control whether the dialog's cancel
button should be disabled. This lead to the cancel button being disabled in
certain states where it should have been enabled instead.

Bug: 974046
Change-Id: I1ad70ce61e68f45d1998b9837b02137256c2d2aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900571
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714665}

Currently, AutocompleteResult doesn't really support the no-default-match
case. The first match is set to be the default match, even if none of the
matches are |allowed_to_be_default_match|.

This is problematic, because there's three known cases where there's
genuinely no default match:
 - NTP ZeroSuggest
 - Enterprise policy where there's no default search provider
 - ChromeOS launcher

ChromeOS launcher already supports the no-default-match case properly.
The other two are subtly broken.

This CL does two things:
 - It updates AutocompleteResult to set default_match() == end() when
   there's no valid default match.
 - It updates a bunch of logic OmniboxPopupModel (runs on Views and iOS)
   to support the no-default-match case.

Bug: 1016845, 363656
Change-Id: Ib684efba92b05cb677bdabf9265e35e2bfbeab56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906882
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714664}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ia561e98b6a504e25237453cd3ac210721c2fa64d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912921Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714663}

Change-Id: Iba6f775a30f9325f1704a52cce3a5d2cf5202395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912625
Auto-Submit: Dana Fried <dfried@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714662}

The module system added a suffix to libraries to better identify them as
partitions.  VR's factory needs to be updated to work with this
convention.

There is an open bug tracking moving VR to be opened by the module
system.  Once that's done, this issue can't happen again.

Bug: 1023634
Change-Id: I690fd1cc14e957818571a1b0384186d807d3d0f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912633Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714661}

This CL adds a "global_media_controls" entry to WATCHLISTS and adds me
to it.

Change-Id: I1aa99dae305adacdde76d4f6f02a524af4641ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907422Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714660}

This CL moved kVizForWebView from android_webview:: to viz so it can be
reachable in renderers code to support viz for webview.

Bug: 805739
Change-Id: If89de11e2efa2acc49fc1920b2c240f08bcebd15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911389Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714659}

This change adds a throttle observer that activates when
an ARC window is added to the PipContainer, and deactivates when
an ARC window is removed. This has the effect of unthrottling
ARC when an ARC PIP window is visible.

unthrottled when a YouTube app PIP window is visible.

Bug: b:142365466
Test: Unit tests; build/flash/run and check that container is
Change-Id: I496e5a6ba67e433891e98601cec50f7079addd13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902523
Commit-Queue: Willie Koomson <wvk@google.com>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714658}

There was multi-platform fallout from making activation less aggressive
in r701411 so that when a session is restored on Mac with windows in
multiple spaces, the system won't switch spaces as those windows are
created and activated.

This rolls back all of the cross-platform changes from r701411 and
r710397, replacing them with behind one tweak to skip activating windows
after restoring their tabs, currently guarded to macOS-only.

Bug: 1019048, 1018885
Change-Id: Id45d2029cf8a5f2af08e7ec3aba911ff2b664a10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910282Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714657}

This reverts commit 5d7b5565.

Reason for revert: This CL causes a failure in the sync integration
 test TwoClientSendTabToSelfSyncTest.SendTabToSelfReceivingDisabled.

Original change's description:
> Add UnidoOnSignIn to fieldtrial_testing_config.json
> 
> - Disabled ClickToCall/SharedClipboard SyncTurnedOff browser test when
>   UnidoOnSignIn is on as it no longer applies
> - Disabled Sharing registration when device is in local sync mode if
>   deriving VAPID key as derived key is not availalbe in local sync mode
> - Add DeviceInfo to allowed type in transport mode in
>   sync_integration_tests when UnidoOnSignIn is on
> 
> Bug: 1009516
> Change-Id: I59a48d6feb2aee941ae6adb867c3a72c1ce70f98
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905946
> Commit-Queue: Alex Chau <alexchau@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#714467}

TBR=mvanouwerkerk@chromium.org,holte@chromium.org,mastiz@chromium.org,alexchau@chromium.org

Change-Id: Ib58259d22a2792a225dc21ba7e8aa542a2a8669d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1009516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913106Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714656}

This reverts commit ceb2e12c.

Reason for revert: Suspect this CL broke the biuld: https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel/6885

Original change's description:
> Implement PermissionWizard checker
> 
> This adds a PermissionWizard::Delegate implementation which runs the
> Me2Me or IT2Me binary with a command-line for checking permissions.
> 
> This can be used to create a PermissionWizard which checks the
> permissions on either the ME2ME or IT2ME host.
> 
> Bug: 1015201
> Change-Id: I24f24e5b1928608bbf310b33a6802db86c9f80bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903934
> Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#714621}

TBR=lambroslambrou@chromium.org,garykac@chromium.org

Change-Id: I95b8aafdd23cb0b551f476f0bc93bde6e16c41cc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1015201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912881Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714655}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a9e0cc38..edafde28

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I756e53793f3f8d925b18090e3317d5d07119b12d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913099Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714654}

Change-Id: If5571ec114544bd69bef816b53e138ae6b5709b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900509Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: David Vallet <dvallet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714653}

Bug: 1003532
Change-Id: Ia6da252f2eae264c383c154e722591e4e3567582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824130
Commit-Queue: Haiyang Pan <hypan@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714652}

93f8aa8df989 posix: fix parameter name in signals test
a8d66ae7839a linux: don't set ptracer if yama doesn't exist

Change-Id: I1786c96dff5a0768dda8a7c32b274f3189e525bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906899
Commit-Queue: Mark Mentovai <mark@chromium.org>
Auto-Submit: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714651}

https://skia.googlesource.com/skia.git/+log/7cb52cb5e67c..581108137b46

git log 7cb52cb5e67c..581108137b46 --date=short --no-merges --format='%ad %ae %s'
2019-11-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-12 csmartdalton@google.com Add 'numRasterSamples' and 'isMixedSampled' to GrProgramInfo
2019-11-12 ccross@android.com [SkQP/Android] Replace -Weverything with -Wextra
2019-11-12 robertphillips@google.com Use a priori knowledge about the number of stencil bits in Dawn, Metal and Vulkan backends

Created with:
  gclient setdep -r src/third_party/skia@581108137b46

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC halcanary@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=halcanary@google.com

Bug: chromium:b/143713277
Change-Id: I1535fd13099cb00e843c84632c1610f71609d673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912685Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714650}

The cr-network-list-item already has an attribute show-buttons but does
not have an aria-role set. This change exposes the role top-level
attribute with the value of "button" when show-buttons is true. When
showButtons is false, the role is set to ''.

Fixed: 1007452
Change-Id: I20f076e54c857d55bd8fd2763fb9f02d51498c92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911481Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#714649}

No change to logic.

This only adds copyright headers to existing XML files. These files were
committed without copyright headers, but there's no reason they should
not have them.

Fixed: 1023573
Test: N/A
Change-Id: I7af8539a877784b8205ff56ce3ccfc5bc0c7a9e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910860
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714648}

This cl is an android only change which allows service worker based
payment handlers on Android to declare their supported delegations
during registration.

The payment sheet is also changed to adaptively show/hide shipping/contact
details section depending on whether or not the user selected payment handler
will provide shipping address/payer's contact information. Whenever multiple
payment handlers exist, payment handlers which provide merchant requested
information are sorted before the rest.

With this change skipping the payment sheet to the payment handler
window when shipping/contact details are requested will be possible
as long as the payment handler can provide this information.

Bug: 984694
Change-Id: I5693a7bd60d7a65b0f9ff5d1c0734867240b57fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902077Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714647}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d565d557945e..119ab23ab620


Created with:
  gclient setdep -r src-internal@119ab23ab620

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:984162,chromium:1004848,chromium:1018879,chromium:None,chromium:None
Change-Id: I8392ef4c764779c03f3df2ecb65ce0643188de6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912919Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714646}

This CL removes the background-color added for date/month/time controls in order to continue
using the highlight and highlightext colors to match the active selection background
and foreground colors (specified in input_multiple_fields.css?l=54).

Bug: 1021328
Change-Id: Ic064697f14f508e3336b41c2c4801122d0175ede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907595
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714645}

Bug: 1017141, 1023530
Change-Id: Ie5868b781a929d09987edcdd6ca3e140b14d9946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912651Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714644}

This test is failing when checking whether an item was selected on
tablets. Restricting to phones only.

BUG=966644
TBR=mdjones@chromium.org

Change-Id: I56be49800d1381db7b17670d73f389405341e89e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912085Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714643}

This allows us to:
1) Remove getAppMenuHandler from ToolbarManager
2) Move ToolbarButtonIPHController to be owned by RootUICoordinator as
well
3) More safely inject ToolbarManager to CustomTabToolbarCoordinator;
previously, this had an implicit ordering dependency
4) In a follow-up, move feature-specific IPH out of ToolbarManager

Bug: 865801
Change-Id: I72e5476477b4f3897962bb71e37b802f7809b0ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874569Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714642}

We had turned it off because the tests were leaking memory.  They are
not leaking anymore so I am turning them back on.

Bug: 969160
Change-Id: I9b61f4f4f71010778e95b54a18881147c9eaf777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900435
Commit-Queue: James Hollyer <jameshollyer@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714641}

This is in preparation of migrating to Polymer3.

Bug: 1022215
Change-Id: Iee652ed3477175346f99c7a490d1637e754644ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907413Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714640}

Also rename WizardController::ForceOfficialBuildForTesting() to
ForceBrandedBuildForTesting().

"Branded" controls Google Chrome vs. Chromium.
"Official" controls compiler optimizations.

This doesn't change behavior, just makes tests clearer.

Bug: none
Change-Id: Ibbd6561a8970366aa38288da510e9636e5d69fc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912657
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714639}

This change does the following:

- Allow disambiguation of which APK(s) should be used for decoding by
  adding an APK directory override argument to stack.py. The alternate
  directory is also handy if using bundles, where the APK files need to
  be generated from an .aab file.

- Augment Clank binary wrapper scripts with a "stack" command,
  effectively acting as a stack.py wrapper that points stack decoding at
  only the relevant APK files (as opposed to a typical stack.py
  invocation, forced to look at out/../apks/, which may contain many
  APKs).

- For lines in the trace that already have symbols, but cannot be
  decoded by the script (ie. lines from on-device Android runtime
  libraries), don't print <UNKNOWN> - fall back to the symbol given in
  logcat instead.

Bug: 1015159
Change-Id: Ib65b82f3a6d85e79f61c8381b3aa1828f7214a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903926Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714638}

Change-Id: I4b585e3498b97709277928dc1b91ede72e7fa61e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906339Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714637}

If an executable is run with "-d" and either the flag --fuchsia-out-dir
or the GN arg default_fuchsia_build_dir_for_installation are set,
the runner script will publish to the Fuchsia output directory's
Amber repository and rely on an existing instance of "fx serve" for
delivering the package to the target.

Encapsulates Amber repo interactions into a new abstract class, AmberRepo.
Adds two concrete classes, one for ephemeral repos (used by emulator runs),
and one for external repos (used for publishing to devices or persistent
Fuchsia AEMU instances.)

Bug: 1022002
Change-Id: Ieb330dd8cd92239c1c5341741ef559483af3285b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907488
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714636}

This CL started out as a re-implementation of
WebPluginContainerTest.PluginDocumentPluginIsFocused to work without
BrowserPlugin, but in the process I realized that we had regressed
the behaviour that was originally fixed in
https://codereview.chromium.org/1389093002.

That regression is also fixed in this CL.

Bug: 1019360, 536637, 1022469
Change-Id: I25bbe47fb602b8a3ef5d9be931e7d5fe486c4008
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903653
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714635}

Because now we can support that adding pause action for the key and
pointer source type, https://chromium-review.googlesource.com/c/
chromium/src/+/1900650, we should check all the pause duration in every
tick and get the maximum value and sleep for the maximum amount of
the pause value at the end of every tick.

Bug: 1020674
Change-Id: I25f992731cd1d982d5fedcf657e72aa3e7ecd7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910816Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714634}

https://webrtc.googlesource.com/src.git/+log/2bd2d85f65e8..dcc910a2095d

git log 2bd2d85f65e8..dcc910a2095d --date=short --no-merges --format='%ad %ae %s'
2019-11-12 srte@webrtc.org Adds simulated TCP message route for testing.
2019-11-12 titovartem@webrtc.org Add ability to specify custom video source for PC framework.
2019-11-12 ilnik@webrtc.org Revert "Reset RtpFrameReferenceFinder on long pause"
2019-11-12 thaloun@chromium.org Don't leak device moniker when BindToStorage fails.

Created with:
  gclient setdep -r src/third_party/webrtc@dcc910a2095d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:b/143372501
Change-Id: Id599398aa3d94b407a555bc6ca3f091ee9b81cb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912686Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#714633}

This reverts commit fc5589ac.

Reason for revert: compile failures on fuschia-x64-dbg
https://cr-buildbucket.appspot.com/build/8896967608768520752

Original change's description:
> [Fuchsia] Send Chrome a11y updates to Fuchsia SemanticsManager
> 
> This change adds functionality to the Accessibility Bridge:
> * Listens for change in AccessibilityMode from Fuchsia
> * Gets the semantic tree from Chrome accessibility and sends it to the
> SemanticsManager
> * Sends live updates when nodes are added, updated or removed
> 
> To send updates, this change includes the following:
> * Creates a ViewRefPair and registers it with the SemanticsManager
> * Initialize an AccessibilityBridge
> * Listen for changes in the Chrome Accessibility tree, serializes them
> to Fuchsia data structures and sends that data to the Fuchsia
> SemanticsManager
> 
> Testing: Added AccessibilityBridge browsertests.
> 
> Bug: 973095
> Change-Id: I89658288b846b6b9ce84a04e49434ec266b84dfc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787171
> Commit-Queue: Sharon Yang <yangsharon@chromium.org>
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#714588}

TBR=dtseng@chromium.org,kmarshall@chromium.org,yangsharon@chromium.org

Change-Id: If2774f0bc5d9a27dc8ba5af3ee00c608e0f6b786
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 973095
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913211Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714632}

This has been dead code since the LUCI migration.

Bug: 1002702
Change-Id: I6410a979d121bfec9867d3663000d65c86e2329a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909274Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714631}

- Return nullptr key when local sync is enabled and avoid DCHECK

Bug: 1023827
Change-Id: I73fac96233ff0b17611b8d0ffb150d9977417d50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911218
Commit-Queue: Alex Chau <alexchau@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714630}