- 17 Jan, 2020 40 commits
-
-
Kent Tamura authored
* FileInputType::SetValue() |input.value =""| triggered style recalc because style recalc triggered UpdateFromElement(). However, we don't need style recalc in this case and we need to do just paint invalidation. * UpdateFromElement() just does paint invalidation. The function is called from - HTMLFormControlElement::AttachLayoutTree() - HTMLFormControlElement::DidRecalcStyle() For both of them, paint invalidation by UpdateFromElement() is redundant. So we can remove UpdateFromElement(). This CL has no behavior changes. Bug: 1040828 Change-Id: I3e180de69cef7eef20d1944283938deec8de9685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006436Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#732784}
-
Miyoung Shin authored
Move FrameMsg_CopyImageAt and FrameMsg_SaveImageAt to a LocalFrame, remove from WebLocalFrame interface and move to a mojo implementation on the LocalFrame class, and add plumbing for test. Bug: 1040124 Change-Id: I1fbde485f4aa1d7104a9839b833617853d46a473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994852 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#732783}
-
Yutaka Hirano authored
We need to enter a scope before creating an error object. Bug: 1011392 Change-Id: I7b01d7f9cfa75efb19837387c105e6acd4322a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007089 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#732782}
-
Ehimare Okoyomon authored
Exposed this feature flag that makes it easier for users to enable and manage third party cookie blocking in android. Bug: 1040091 Change-Id: Icc58f7afb6c4c60c78d7963b44d2cbf7e93ba189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002618 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#732781}
-
Kent Tamura authored
to RangeInputType. This CL has no behavior changes. Bug: 1040828 Change-Id: I6d4ba4faf0467da4db268ebd4cc4d37a992c973b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006897Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#732780}
-
Rakesh Soma authored
Bug: 1039931 Change-Id: I6203d7692903bf83825a4d27c1b490ccada24efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990452 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#732779}
-
Ehimare Okoyomon authored
session Previously, there was text in the site description that said "Current incognito session" when a site exception rule only applied for the active incognito session and looked like this: https://screenshot.googleplex.com/nqaVgnmQ7ac.png Now, instead, for this type of site exception there is a tooltip with the incognito icon, and when you hover over it, there is an explanation string of what the icon means: https://screenshot.googleplex.com/hy8E1SCws6J.png Bug: 1030274 Change-Id: I6d23af1a9e0b8ca376326aeb97cc524c4f0b7df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948889Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#732778}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b446206d9331..b39daad9ba0c git log b446206d9331..b39daad9ba0c --date=short --first-parent --format='%ad %ae %s' 2020-01-17 bmeurer@chromium.org Roll upstream changes. 2020-01-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@b39daad9ba0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6a83b68ac62634d8f5d1ba88cef976d7a8a89610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006726Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732777}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2182260bce54..8dd28cd4db8d Created with: gclient setdep -r src-internal@8dd28cd4db8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iab7e0411bee9471842d08b1e471dd57f18468bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006723Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732776}
-
Matthias Körber authored
Currently, the '0'/'1' digits are not used in generated password to avoid visual confusion with letters like 'l','I' and 'O'. With this change, the digits are added to the numeric alphabet if the generated password does not contain lower and upper case letters. Bug: 1038659 Change-Id: I25552b85592b8a3f2e286b9c30652db6664eff00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985768 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#732775}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/90449951..47cbd1fb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id70902da5a85540046a13e24a1fb3fa29edef415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006170Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732774}
-
Matthias Körber authored
Change-Id: Ifb1e8828002230bdad4a41d4657b8656a1617120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003318Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#732773}
-
http://localhost`Mike West authored
We should have removed this code when we landed https://chromium-review.googlesource.com/c/chromium/src/+/598068/. Bug: 691930 Change-Id: I018f284eb3f78ff6b7c0d042c704a84385fb754a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002584Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#732772}
-
Kent Tamura authored
This is a reland of 3c4c13ac The difference from the original CL: - Replace LayoutObject::UpdateFromElement() call with HTMLFormControlElement::UpdateFromElement() in HTMLFormControlElement::DidRecalcStyle() too. Original change's description: > Move LayoutMenuList::DidUpdateActiveOption() to HTMLSelectElement > > Also, > - Remove LayoutMenuList::DidSelectOption(). > - Add HTMLFormControlElement::UpdateFromElement() to add > DidUpdateMenuListActiveOption() to each of > LayoutMenuList::UpdateFromElement() calls. > > This CL is a preparation to build a LayoutNG counterpart of LayoutMenuList. > This CL has no behavior changes. > > Bug: 1040828 > Change-Id: If7917af101119a830e899a50711a6c1491e22eb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003164 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732313} Bug: 1040828 Change-Id: Ibba19df1c4f9a402c057bbf4548b18f1fdeb44f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006271Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#732771}
-
Ioana Pandele authored
This reverts commit ca83da12. Reason for revert: Tests are now failing consistently. Original change's description: > [Android] Fix password generation integration tests > > The manual generation tests were broken because the tab view in the keyboard > accessory could not be found. This CL changes the matcher used. > > All tests used to depend on server predictions for filling, which marked > the field as eligible for generation or not. This broke when the predictions > where not as expected. > > Bug: 1010540, 1010344 > > Change-Id: I8ca5392d80b81a67d414eec33cc7a7a2e282d725 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995273 > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732423} TBR=fhorschig@chromium.org,ioanap@chromium.org Change-Id: Ifd9d62d8e29b6327bab291972a1b986260c7586f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010540, 1010344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006551Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#732770}
-
Yoshifumi Inoue authored
This patch changes |LayoutText::DetachAbstractInlineTextBoxesIfNeeded()| to use |NGPaintFragment::InlineFragmentsFor()| instead of |NGInlineCursor|, because |DetachAbstractInlineTextBoxesIfNeeded()| is called after containg block flow of |LayoutText| changed, e.g. removing, moving, spliting, etc. Note: This is experimatal patch because we don't know exact reproduce case. Note: |NGInlineCursor::MoveTo(LayoutObject)| requires root paint fragment computed from specified layout object. Bug: 1040938 Change-Id: I7624a19e66f449182309a29ab0fc4748839d69b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006837 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#732769}
-
Oleg Davydov authored
Add burunduk@ to OWNERS in the following directories: * content_verifier in extensions/browser/ * forced_extensions in chrome/browser/extensions/ Change-Id: I31359a569e0169eb9819945c405f8678a01bca64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003853Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732768}
-
Alex Keng authored
This CL fixes <select>'s hover color in high contrast mode (forced_colors.css) per the design. The test select-multiple-appearance-basic.html is modified to test the scenario of focused+selected+hovered. 3 more tests are added to test 1)focused+unselected+hovered, 2)unfocused+selected+hovered, 3)unfocused+unselected+hovered. Change-Id: I2fafe1447290a4783fd3a393f1b0046e143ad9ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995505 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#732767}
-
nancy authored
This CL is used to integrate Extension apps's context menus for app list to AppService: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/extension_app_context_menu.cc?l=71 https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/extension_app_context_menu.cc?l=162 BUG=1038487 Change-Id: Ieb1eacc74a7c28c498a503e1fa89f91c868e9323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004908 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#732766}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/91096f77a581..6d6e911b50e1 git log 91096f77a581..6d6e911b50e1 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 fancl@chromium.org Reduce min_num_instances of sheriff-config 2020-01-17 dberris@chromium.org Remove dispatch.yaml 2020-01-17 dberris@chromium.org Add commas between distinct strings 2020-01-17 fancl@chromium.org Fix query by subscriptions 2020-01-17 bsheedy@chromium.org Fix minidump symbolize spam 2020-01-17 zhizhouy@google.com Use python 2 for trace2html Created with: gclient setdep -r src/third_party/catapult@6d6e911b50e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1039776,chromium:1040775,chromium:1042949,chromium:953181 Tbr: rmhasan@google.com Change-Id: I2dc3f9402d0aa1087238b67e85528518edce4f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006712Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732765}
-
Josh Simmons authored
This UI is shown only when PerformanceHintsObserver is enabled. It is currently disabled by default. Bug: 1030813 Change-Id: I7f84e319871d5eb31c46faa8e0fc4255e87b5ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992263 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#732764}
-
Rachel Sugrono authored
Add two non-consecutive files to check-select (aka multi- select). Quick View should open in check-select mode with the first file being opened. Left/right arrow keys should show the next selection in check-select. Bug: 1038799 Change-Id: I1164a19391920b9cc08d0f622d1c2a14c006b8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006901 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732763}
-
Jan Wilken Dörrie authored
This reverts commit 07b113c5. Reason for revert: Breaks create_tarball step on Deterministic Linux builders: https://crbug.com/1043039 Original change's description: > [Reland] WebUI: Stop auto-generating Polymer 3 version of cr-splitter. > > The Polymer 2 version is not used anymore, therefore no auto-generation > is necessary and the v3 version can be directly checked in. > > Fixed: 1042545 > Change-Id: Ia0267cef30dcf1eb08677d369fd3f8ded21c679f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006421 > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732725} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: I59eb715d4f775f98fb9a71d37889bbefbe3d86f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006349Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#732762}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3ed344dd784e..b0ada80356ca git log 3ed344dd784e..b0ada80356ca --date=short --first-parent --format='%ad %ae %s' 2020-01-17 cepheus@frii.com HLSL: Fix #1974: ignore input primitives on non-entry-point functions. Created with: gclient setdep -r src/third_party/glslang/src@b0ada80356ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I94005182ab630196e10f9ce416f0559d3a58eef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006718Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732761}
-
Adam Rice authored
Add an API to receive datagrams from a QuicTransport connection. Bug: 1011392 Change-Id: I8d730f858dcf5127f186c6d58816f43a4b7c731b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006279Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#732760}
-
David Munro authored
Bug: chromium:914515 Test: CQ Change-Id: Ibfacf91020b5bd80c905967accb24c438c0293b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006838 Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#732759}
-
David Munro authored
Users can opt to back up their existing container before attempting the upgrade and are prompted to restore if the upgrade fails. Almost all of this is by nverne@, I just fixed a use-after-free and am relanding it while he's OOO. Bug: 1024693 Test: Unit tests under ASAN, browser tests, manual tests. Change-Id: I5d366732e36157b98178aa97cefc84a35f713bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985621Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#732758}
-
Patrick Rohr authored
InitSharedInstanceWithPakFileRegion() takes ownership of the passed file and assigns it to a static instance variable. This means that the next time base::File(pake_fd) is called on line 250, the file descriptor already has an owner (and a FdEntry respectively) and android_fdsan_exchange_owner_tag fails (in order to prevent a double close. See bionic/libc/bionic/fdsan.cpp for further information). Duplicating the file descriptor before calling InitSharedInstanceWithPakFileRegion should prevent this problem. Test: Tested on device. Casting a few times back to back does not trigger the error, while without the fix the error is thrown right away. Bug: b/142898745 Change-Id: I153ed21eaaa5280d63a296d272cd4f7b46d67859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003321Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Patrick Rohr <prohr@google.com> Cr-Commit-Position: refs/heads/master@{#732757}
-
Christoph Schwering authored
Autofill uses AutofillClock and AutofillTickClock to allow for manipulating the clock for testing purposes. This presubmit script warns about usage of base::Time::Now() and base::TimeTicks::Now(). Bug: 1009364 Change-Id: I314303fde19edfc623cba96a01ed3a5e00c6815e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007048Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#732756}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3f0bc2c1766a..e4ddaa949540 git log 3f0bc2c1766a..e4ddaa949540 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 112d1736..f1e98807 (732519:732621) 2020-01-16 steveanton@webrtc.org Explicitly wait for ICE to complete in VerifyBestConnection 2020-01-16 steveanton@webrtc.org Explicitly wait for ICE state to transition to 'completed' in VerifyIceStates Created with: gclient setdep -r src/third_party/webrtc@e4ddaa949540 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2edfa1c0873993a6bec84cc60a01afc25c2528b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006815Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732755}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/41f6150edb16..9819e9ed7b10 git log 41f6150edb16..9819e9ed7b10 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 sugoi@google.com GL_EXT_read_format_bgra support 2020-01-17 sugoi@google.com GL_EXT_float_blend support Created with: gclient setdep -r src/third_party/angle@9819e9ed7b10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jonahr@google.com Change-Id: I79e0563b296310097c58258d1ef66e3c29df9b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006814Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732754}
-
Theodore Olsauskas-Warren authored
Original mocks for the new Security Page as part of friendly settings introduced usage of heading styles that did not have a precedent within settings. This CL changes the Security Page to align with existing usage patterns. Bug: 1032584 Change-Id: Iaf50a6713bb2465332e2ef10fdd5247b26815036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002515Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#732753}
-
Jan Wilken Dörrie authored
TBR=sigurds Bug: 1042689 Change-Id: Ied0c235d3922cd7b355bcdb24b8bb4fbb38d5954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003856 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#732752}
-
Rachel Sugrono authored
Add two non-consecutive files to check-select (aka multi- select). Quick View should open in check-select mode with the first file being opened. Up/down arrow keys should show the next selection in check-select. Bug: 1038799 Change-Id: Ib6c6288aaeeb10a82e7264336bb25a79d5b7d5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006844Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732751}
-
Austin Tankiang authored
The paper ripples were set to 150% width in order to speed them up, but this causes issues in RTL, so remove it. Bug: 977996 Change-Id: Iab53d635e9feaec323cea9e9addd11c6a182119f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006893Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#732750}
-
Wei Wang authored
This patch makes the order of the registrations returned by getRegistrations() be sorted by registration ID, which fixes the flaky test of getregistrations.https.html. Related Github issue is in https://github.com/w3c/ServiceWorker/issues/1465 Bug: 925740 Change-Id: Iaa5716eec886232df61bd23487fbae5c63413e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984900Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Wei4 Wang <wei4.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#732749}
-
David Staessens authored
The V4L2 encode accelerator currently has its own routines and thread to manage polling the V4L2 device. This CL changes the encoder to make use of the V4L2 device poller that was introduced recently. TEST=./video_encode_accelerator_unittest on hana BUG=None Change-Id: I7fb003ab3850c4a72b299a682a9a7f971777aa34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994545Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#732748}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/32e07f0513b0..2182260bce54 Created with: gclient setdep -r src-internal@2182260bce54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1034629,chromium:1042660,chromium:1042741,chromium:981067 Tbr: jbudorick@google.com Change-Id: I5c7c1a6bc7df46ddfbd964e654151e1a2aab7820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006623Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732747}
-
Caleb Rouleau authored
This is necessary for Pinpoint, which still uses these isolates. This is a fix after https://chromium-review.googlesource.com/c/chromium/src/+/2003767 landed. See the bug for details. TBR=bsheedy@chromium.org Bug: 1042778 Change-Id: Iff81712f2e3f6d26171064922056361e9fc7b4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006391Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#732746}
-
rbpotter authored
This fixes a Polymer timing issue where setting the margins in the margin-control-container was causing the observer in margins-settings that updated the UI to not fire. Also moving the margins setter in pages_per_sheet to margins for consistency. Bug: 1041378 Change-Id: I83bebfefe8fb306bc332844e5a146271a7ac2b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000523Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#732745}
-