GitLab

Other attributes have already been using V8's named property interceptor.
Window is only an exception.  Let's use it for Window, too.

This CL intentionally changes the look-up behavior.
Sample code:
  iframe = document.createElement('iframe');
  iframe.name = 'alert';
  document.body.appendChild(iframe);
Before:
  window.alert => iframe with the name 'alert'
After:
  window.alert => built-in alert function

According to the spec, (non-named, regular) attributes/methods must have priority over named properties.

See "The named property visibility algorithm" at
http://heycam.github.io/webidl/#indexed-and-named-properties
The order of look-up for non-[OverrideBuiltins] interfaces (including Window) must be:
  1. Own properties.
  2. Properties from the prototype chain.
  3. Named properties.

The Intent-to-Implement-and-Ship is here:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/jlmsE3fDCNg

BUG=43394,516274

Review URL: https://codereview.chromium.org/1121703002

git-svn-id: svn://svn.chromium.org/blink/trunk@201225 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=johnme
BUG=

Review URL: https://codereview.chromium.org/1311673008

git-svn-id: svn://svn.chromium.org/blink/trunk@201224 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a fix for the data race in GCInfoAtBase::index.
The GCInfo is defined as static local and this causes race while
allocating new objects. This CL reduces the initialization time by
using function pointer to get the class name instead of string parsing.

BUG=524237

Review URL: https://codereview.chromium.org/1312963002

git-svn-id: svn://svn.chromium.org/blink/trunk@201223 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201181

BUG=518347
TBR=kojii@chromium.org

Review URL: https://codereview.chromium.org/1320633003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201222 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, SegmentedSubstring::{m_length,m_data} was declared public.
This CL makes them private and adds public accessors to them.

BUG=None
TESTS=Refactoring only. Shouldn't change any behaviour.

Review URL: https://codereview.chromium.org/1317693006

git-svn-id: svn://svn.chromium.org/blink/trunk@201221 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |firstEditablePositionAfterPositionInRoot()| as pair of
|lastEditablePositionBeforePositionInRoot()| to make debugging easier for
improving code health.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1316063002

git-svn-id: svn://svn.chromium.org/blink/trunk@201220 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before the CL[1], Chromium could pass an existing WebServiceWorkerRegistration
to ServiceWorkerRegistration, so ServiceWorkerRegistration needed to confirm
whether its ownership was passed. After the CL, Chromium always passes ownership
and ServiceWorkerRegistration does not have to worry about it.

This CL removes codes for the case that ownership is not passed from Chromium.

[1] https://codereview.chromium.org/1307133003/

BUG=523904

Review URL: https://codereview.chromium.org/1317473002

git-svn-id: svn://svn.chromium.org/blink/trunk@201219 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reland of move javaEnabled setting. (patchset #1 id:1 of https://codereview.chromium.org/1318703002/ )

Reason for revert:
Relanding because this had no impact. The bug disappeared and re-appeared regardless of this CL.

Original issue's description:
> Revert of Remove javaEnabled setting. (patchset #1 id:1 of https://codereview.chromium.org/1306403003/ )
> 
> Reason for revert:
> Reverting to see whether this fixes the compilation.
> 
> Original issue's description:
> > Remove javaEnabled setting.
> > 
> > As of M45, NPAPI support is (almost) completely gone, so Java will never
> > be supported anyway.
> > 
> > BUG=none
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201211
> 
> TBR=haraken@chromium.org,dcheng@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=none
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201217

TBR=haraken@chromium.org,dcheng@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1319673003

git-svn-id: svn://svn.chromium.org/blink/trunk@201218 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Remove javaEnabled setting. (patchset #1 id:1 of https://codereview.chromium.org/1306403003/ )

Reason for revert:
Reverting to see whether this fixes the compilation.

Original issue's description:
> Remove javaEnabled setting.
> 
> As of M45, NPAPI support is (almost) completely gone, so Java will never
> be supported anyway.
> 
> BUG=none
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201211

TBR=haraken@chromium.org,dcheng@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1318703002

git-svn-id: svn://svn.chromium.org/blink/trunk@201217 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves global function |isInline()| defined in
"EditingUtilities.{cpp,h}" to "IndentOutdentCommand.cpp" to reduce number of
global functions for improving code health since |isInline()| is used only in
"IndentOutdentCommand.cpp".

BUG=n/a
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1315073002

git-svn-id: svn://svn.chromium.org/blink/trunk@201216 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch replaces forward class declarations |VisibleSelection| to include
directive of "VisibleSelection.h" as preparation of introducing
|VisibleSelectionTemplate<Strategy>|, like |PositionAlgorithm<Strategy>|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1314843003

git-svn-id: svn://svn.chromium.org/blink/trunk@201215 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CompositedDeprecatedPaintLayerMapping contains logic to suppress
redundant changes to layers while composited animations are running. The
order of operations (composted animations are updated after layers)
meant that a compositing update that resulted in the cancelling of compositor
animations would still suppress these values.

BUG=501297

Review URL: https://codereview.chromium.org/1319653002

git-svn-id: svn://svn.chromium.org/blink/trunk@201214 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use EditingStrategy as template parameter to lastEditablePositionBeforePositionInRootAlgorithm template function

This patch changes template parameter of
|lastEditablePositionBeforePositionInRootAlgorithm()| to |EditingStrategy| or
|EditingInComposedTreeStrategy| instead of |Position| or |PositionInComposedTre|
to match other implementation of editing template functions for improving
readability.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1304353003

git-svn-id: svn://svn.chromium.org/blink/trunk@201213 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The pre-allocation of the StringBuilder is redundant if the range is
empty, hence avoid.

While here, simplify empty string builder testing also.

R=yosin
BUG=

Review URL: https://codereview.chromium.org/1317593003

git-svn-id: svn://svn.chromium.org/blink/trunk@201212 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As of M45, NPAPI support is (almost) completely gone, so Java will never
be supported anyway.

BUG=none

Review URL: https://codereview.chromium.org/1306403003

git-svn-id: svn://svn.chromium.org/blink/trunk@201211 bbb929c8-8fbe-4397-9dbb-9b2b20218538

An accessor function called frameLoaderClientImpl(), added in
https://codereview.chromium.org/1314703003/, was actually not necessary.

BUG=509911
R=haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1313083005

git-svn-id: svn://svn.chromium.org/blink/trunk@201210 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The PerfBot is not happy. http://build.chromium.org/p/chromium/buildstatus?builder=Linux%20x64&number=8587

PERF_REGRESS: chrome-bss/bss (1.93%), chrome-bss/bss (1.93%)
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux-64&tests=sizes&rev=345536


> [bindings] Compact ConstantConfiguration by using |union|
> 
> This patch uses |union| to store the constant values to reduce space required.
> 
> This patch saves about ~4 Kbytes of in |.data.rel.ro.local| with component build on linux platform.
> Also the size of V8DOMConfiguration::ConstantConfiguration is down to 24 bytes from
> 40 bytes on 64bit linux build.
> 
> BUG=469961
> 
> Review URL: https://codereview.chromium.org/1310443005

TBR=vivek.vg@samsung.com

Review URL: https://codereview.chromium.org/1314133002

git-svn-id: svn://svn.chromium.org/blink/trunk@201209 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This allows caching of styles that may be affected by LayoutThemes as
the data is now available even when cached.

Now with shiny new layout tests to make sure http://crbug/517567 doesn't 
happen again

BUG=259995

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199708

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200094

Review URL: https://codereview.chromium.org/1251523003

git-svn-id: svn://svn.chromium.org/blink/trunk@201208 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch is inspired by http://crrev.com/1257203002, which makes printer for
|WTFString| in GTest.

This patch re-introduces printers for Node, Position and PositionAnchorType in
GTest rather than printing address of pointer by fixing ODR violation for
improving test authoring experience.

In http://crrev.com/1095913003, we introduced |Node| and |Position| printers for
GTest in "CoreTestHelpers.h". However, due by ODR violation, these printers
aren't used in GTest, since some test files uses |Node| as parameters for
GTest macros without including "CoreTestHelpers.h".

Note: ODR stands for One Definition Rule.

See details explanation in http://crrev.com/1257203002.

BUG=514330
TEST=webkit_unit_tests --gtest_fitler=EditingUtilitiesTest.*,VisibleUnitsTest.*

Review URL: https://codereview.chromium.org/1313283002

git-svn-id: svn://svn.chromium.org/blink/trunk@201207 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Get rid of unused member function toNormalizedRange() from FrameSelection and VisibleSelection classes

This patch gets rid of unused member function |toNormalizedRange()| from
|FrameSelection| and |VisibleSelection| classes with re-formatting an associated
comment for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1315513005

git-svn-id: svn://svn.chromium.org/blink/trunk@201206 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1315783003

git-svn-id: svn://svn.chromium.org/blink/trunk@201205 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1306413003

git-svn-id: svn://svn.chromium.org/blink/trunk@201204 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1310643003

git-svn-id: svn://svn.chromium.org/blink/trunk@201203 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The purpose of the transparency clip is to give Skia raster hints so that
a transparent layer can be sized according to the bounding box of contents
being composited. The clip itself should be no-op, but will actually cause
anti-alias artifact for transformed contents.

Removing the transparency clip and use compositing bound will allow Skia
to take account of anti-aliasing to properly size the transparent layer.

BUG=524859

Review URL: https://codereview.chromium.org/1311633004

git-svn-id: svn://svn.chromium.org/blink/trunk@201202 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |enclosingNodeOfType()| as a
preparation of introducing composed tree version of |enclosingBlock()| for
templatizing |VisiblePosition| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=webkit_unit_tests --gtest_fitler=EditingUtilitiesTest.enclosingNodeOfType

Review URL: https://codereview.chromium.org/1309903003

git-svn-id: svn://svn.chromium.org/blink/trunk@201201 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Supporting deprecated Dictionary enables us to do step-by-step refactoring.

Note for tests:
Since Dictionary instances cannot outlive an event loop, DictionaryTest
stores its properties intead of instances itself. Added
getDictionaryMemberProperties() to retrieve these properties.

BUG=524357

Review URL: https://codereview.chromium.org/1316833003

git-svn-id: svn://svn.chromium.org/blink/trunk@201199 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove the failure expectation for
fast/css/word-spacing-characters-complex-text.html on Linux, since it is
no longer failing.

BUG=419769

Review URL: https://codereview.chromium.org/1312873003

git-svn-id: svn://svn.chromium.org/blink/trunk@201198 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This file does not use RetainPtr.

Review URL: https://codereview.chromium.org/1309283002

git-svn-id: svn://svn.chromium.org/blink/trunk@201197 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since 'all' is a CSS property (a shorthand for almost every other
property), we shouldn't need special logic to handle it during
parsing. For efficiency, it is still special-cased when we compute
which transitions to start.

Review URL: https://codereview.chromium.org/1308073007

git-svn-id: svn://svn.chromium.org/blink/trunk@201196 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This file does not use RetainPtr.

Review URL: https://codereview.chromium.org/1313733002

git-svn-id: svn://svn.chromium.org/blink/trunk@201195 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebInputEventConversionTest.ElasticOverscrollWithPageReload was failing:
[ RUN      ] WebInputEventConversionTest.ElasticOverscrollWithPageReload
Check failed: url_to_reponse_info_.find(url) == url_to_reponse_info_.end().

BUG=521229

Review URL: https://codereview.chromium.org/1302313008

git-svn-id: svn://svn.chromium.org/blink/trunk@201194 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch uses |union| to store the constant values to reduce space required.

This patch saves about ~4 Kbytes of in |.data.rel.ro.local| with component build on linux platform.
Also the size of V8DOMConfiguration::ConstantConfiguration is down to 24 bytes from
40 bytes on 64bit linux build.

BUG=469961

Review URL: https://codereview.chromium.org/1310443005

git-svn-id: svn://svn.chromium.org/blink/trunk@201193 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We currently scale x/y coordinate of svg path using the same
scale factor for hit-test. It has the problem that when x/y
values have different magnitudes, e.g. when x has huge value
and y has small value, scaling down x and y using the same
scale factor will clamp the y values and make it lose the
resolution for hit-test. Scaling x/y separately can fix the
problem.

BUG=379320

Review URL: https://codereview.chromium.org/1300783005

git-svn-id: svn://svn.chromium.org/blink/trunk@201192 bbb929c8-8fbe-4397-9dbb-9b2b20218538

in WebEmbeddedWorkerImpl and WebSharedWorkerImpl.


Those member variables are instantiated with WebLocalFrame::create(),
and it actually creates a WebLocalFrameImpl instance.

On Oilpan build, WebLocalFrameImpl has a self-referential persistent to
keep itself alive, and it will be cleared on call of
WebLocalFrameImpl::close().

In those two classes, m_mainFrame->close() is called in destructors, so
the self referential persistent is cleared in destruction on Oilpan build.
Beside it, on both non-Oilpan build and Oilpan build, m_mainFrame is
also cleared and should be released.


BUG=509911

Review URL: https://codereview.chromium.org/1308313002

git-svn-id: svn://svn.chromium.org/blink/trunk@201191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Simplify StyleSectionModel.isPropertyOverloaded method. It does not
  require a second parameter any more.
- As a side effect of previous bullet, fix a bug and add a test.
- Centralize all logic of computing used properties in a single place.

BUG=496263
R=pfeldman

Review URL: https://codereview.chromium.org/1320543002

git-svn-id: svn://svn.chromium.org/blink/trunk@201190 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently we have a hit-testing fallback that if nothing is hit,
consider the root layer (document element) is hit. The fallback is
only for main document, but not iframe. It is not unreasonable that
if the hit point is within the iframe's bound, it should be considered
to hit the iframe's document if it does not hit any other element.
This CL does this modification to the fallback rule.

BUG=508474

Review URL: https://codereview.chromium.org/1289753006

git-svn-id: svn://svn.chromium.org/blink/trunk@201188 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=502118, 503170

Review URL: https://codereview.chromium.org/1301833003

git-svn-id: svn://svn.chromium.org/blink/trunk@201187 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes |VisibleUnitsTest.localCaretRectOfPosition| to check
results of |localCaretRectOfPosition()| aren't empty for improving detection
of regression.

This is a follow-up patch for http://crrev.com/1317503002, which introduces
composed tree version of | localCaretRectOfPosition()|.

BUG=513568
TEST=webkit_unit_tests --gtest_filter=VisibleUnitsTest.localCaretRectOfPosition

Review URL: https://codereview.chromium.org/1319623004

git-svn-id: svn://svn.chromium.org/blink/trunk@201186 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We must apply color animations to both the visited and unvisited
computed style colors when inside links as the animation must apply
in either case.

BUG=506898

Review URL: https://codereview.chromium.org/1312983003

git-svn-id: svn://svn.chromium.org/blink/trunk@201185 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Author shadow roots used to show in inspector as
"#shadow-root", but with this CL it will be shown
as "#shadow-root (open)" or "#shadow-root (closed)"
respectively.

BUG=516969
TEST=pass all layout tests

Review URL: https://codereview.chromium.org/1309403002

git-svn-id: svn://svn.chromium.org/blink/trunk@201184 bbb929c8-8fbe-4397-9dbb-9b2b20218538