Commits · 3a035998dfcdcb0856f3b7b8e87b3bba0f1ab0be · eriksson monteiro / tangled

11 May, 2018 40 commits

Slightly simplify fuzzer_test by using gn's new-ish not_needed() function. · 3a035998

Nico Weber authored May 11, 2018

No intended behavior change.

Bug: none
Change-Id: I1191d7dd55108a4ae9fdab19ee299bf6c6c08ec2
Reviewed-on: https://chromium-review.googlesource.com/1055749Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557981}

3a035998

Improve Context Menu EarlGrey tests to reduce flakiness. · ec12fa5b

Mike Dougherty authored May 11, 2018

Bug: 817810
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0b8847322c6cae9d53421a7778b1852e8a1a0a43
Reviewed-on: https://chromium-review.googlesource.com/1055802
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557980}

ec12fa5b

Re-enable EulaTest.LoadOffline · b0841754

Xiyuan Xia authored May 11, 2018

Bug: 817995
Change-Id: I305739b830ad9c628f6adc88ca930adccc4bfeea
Reviewed-on: https://chromium-review.googlesource.com/1054219Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557979}

b0841754

[Picture-in-Picture] Fire enter/leave events for native video controls. · 43b2d267

François Beaufort authored May 11, 2018

This makes sure enterpictureinpicture and leavepictureinpicture events
are fired when user enters and leaves Picture-in-Picture from native
video controls.

Bug: 806249
Change-Id: I8d8717ce6fa97c3882913e73d8599cede6ec92dc
Reviewed-on: https://chromium-review.googlesource.com/1029951
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557978}

43b2d267

Update Viz Filters for Mac · 217626a0

jonross authored May 11, 2018

There had ben a series of Mac testing failures tracked by issue 817827, 817830.

These have been fixed, so re-enabling the tests.

TBR=fsamuel@chromium.org
TEST=viz_browser_tests, viz_content_browsertests

Bug: 760181
Change-Id: I4df4a3cdb659a4226dcd9b2a3e174bf41e064052
Reviewed-on: https://chromium-review.googlesource.com/1055664Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557977}

217626a0

[Password Manager] Inline the Export Passwords feature in the MD settings · 32bbd5cf

Christos Froussios authored May 11, 2018

The feature is now fully rolled out.

Bug: 838789
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icdd315779899230fe78b7d90a17680736722a2ea
Reviewed-on: https://chromium-review.googlesource.com/1047867
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557976}

32bbd5cf

Move //net/spdy/chromium to //net/spdy. · 94658bfc

Bence Béky authored May 11, 2018

This change was made possible by https://crrev.com/c/1028984, which left
chromium as the only directory in //net/spdy.

This change is not git cl formatted, and presubmit checks are skipped
(there are pre-existing presubmit errors), because this is only a move.

NOPRESUBMIT=true

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I670e6e7204870a78d738b7e2fe18569b6c8f0264
Reviewed-on: https://chromium-review.googlesource.com/1054470Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557975}

94658bfc

Updates Daum search_url and suggest_url. · a1aa8b05

bill.2714 authored May 11, 2018

This CL updates Daum related url to the newest.
'search_url' adds 'w' and 'DA' param to recognize this url is from chrome omnibox.
This will be used for handling abuse control, redirect issues and
serving extra options for users from chrome omnibox.
'search_url' deletes 'ie' param which no longer valid.
The domain for 'suggest_url' has changed and older url no longer valid, updated to the newest.

R=pkasting@chromium.org, vasilii@chromium.org

Change-Id: Ib60e54b5e29c0d84493174fc43e4c4efb84f0363
Reviewed-on: https://chromium-review.googlesource.com/1025544
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557974}

a1aa8b05

[Presentation API] Remove content::PresentationInfo. · e2084383

mark a. foltz authored May 11, 2018

Replaces usages of content::PresentationInfo with blink::mojom::PresentationInfo.
There should be no change in behavior.

The presentation ID length check in the typemap is moved to PresentationServiceImpl.
Presentation IDs are always generated by the browser and a too-long ID is a bug.

Bug: 817903
Change-Id: I6518abbab6d8b6f24925f1fb649a150b08221622
Reviewed-on: https://chromium-review.googlesource.com/1026987Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557973}

e2084383

Fix home launcher flaky test · e09fad69

Weidong Guo authored May 11, 2018

AppListPresenterDelegateHomeLauncherTest.BackgroundOpacity and
BackgroundBlur are flaky because IsBackgroundBlurEnabled() saves
feature flag in static variable.

Changes:
Remove static variable.

BUG=842027

Change-Id: I26c056ee72bac8490ca8a7b0b2555b90594b4980
Reviewed-on: https://chromium-review.googlesource.com/1055793Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557972}

e09fad69

Update rtanalytics-light component to 4.0 · 3aee88a0

Luke Sorenson authored May 11, 2018

Made a non-backwards non-forwards compatible change to the component
by deploying the shim executable with the component, rather than as
part of the CrOS image.

Bug: b:78120236
Change-Id: I0e4cf4ab87cebd777549d0c1daaa29187b3b58b2
Reviewed-on: https://chromium-review.googlesource.com/1015703
Commit-Queue: Luke Sorenson <lasoren@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557971}

3aee88a0

Revert "Reland "Reland "Cancel parallel download request if server doesn't send partial response""" · 1259cf84

Min Qin authored May 11, 2018

This reverts commit 6682345b.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "Reland "Cancel parallel download request if server doesn't send partial response""
> 
> This reverts commit e127247e.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > Revert "Reland "Cancel parallel download request if server doesn't send partial response""
> > 
> > This reverts commit 05267e5e.
> > 
> > Reason for revert: <INSERT REASONING HERE>
> > 
> > Original change's description:
> > > Reland "Cancel parallel download request if server doesn't send partial response"
> > > 
> > > This reverts commit 13077433.
> > > 
> > > Reason for revert: <INSERT REASONING HERE>
> > > 
> > > Original change's description:
> > > > Revert "Cancel parallel download request if server doesn't send partial response"
> > > > 
> > > > This reverts commit 189d1033.
> > > > 
> > > > Reason for revert: "ParallelDownloadTest.NoPartialResponse" is flaky. See https://crbug.com/841666.
> > > > 
> > > > Original change's description:
> > > > > Cancel parallel download request if server doesn't send partial response
> > > > > 
> > > > > If the server doesn't support partial responses, Chrome should cancel
> > > > > parallel download requests.
> > > > > These requests result in the wrong write offset and makes the file larger
> > > > > than the original
> > > > > 
> > > > > BUG=838627
> > > > > 
> > > > > Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba
> > > > > Reviewed-on: https://chromium-review.googlesource.com/1048130
> > > > > Commit-Queue: Min Qin <qinmin@chromium.org>
> > > > > Reviewed-by: Xing Liu <xingliu@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#557252}
> > > > 
> > > > TBR=qinmin@chromium.org,xingliu@chromium.org
> > > > 
> > > > Change-Id: I995c3c48fe39c535275a353130b10204009c5e30
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: 838627, 841666
> > > > Reviewed-on: https://chromium-review.googlesource.com/1053470
> > > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> > > > Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#557489}
> > > 
> > > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org
> > > 
> > > Change-Id: I47a2d4131efa8b863d9868eeca74e99d7beeaa8e
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 838627, 841666
> > > Reviewed-on: https://chromium-review.googlesource.com/1054887
> > > Reviewed-by: Min Qin <qinmin@chromium.org>
> > > Commit-Queue: Min Qin <qinmin@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#557734}
> > 
> > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org
> > 
> > Change-Id: I7a618b9533229ea1bb97ff65470e9c60fe580a49
> > No-Try: true
> > Bug: 838627, 841666
> > Reviewed-on: https://chromium-review.googlesource.com/1053729
> > Reviewed-by: Max Morin <maxmorin@chromium.org>
> > Commit-Queue: Max Morin <maxmorin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#557834}
> 
> TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org,maxmorin@chromium.org
> 
> Change-Id: I4a0d7eb869a61e38d01424427976121fe7f13384
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 838627, 841666
> Reviewed-on: https://chromium-review.googlesource.com/1055710
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Commit-Queue: Min Qin <qinmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557969}

TBR=qinmin@chromium.org,xingliu@chromium.org

Change-Id: I6081079beaca50c3c9dc0fae53f665c68cd97eda
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 838627, 841666
Reviewed-on: https://chromium-review.googlesource.com/1055482Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557970}

1259cf84

Reland "Reland "Cancel parallel download request if server doesn't send partial response"" · 6682345b

Min Qin authored May 11, 2018

This reverts commit e127247e.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Reland "Cancel parallel download request if server doesn't send partial response""
> 
> This reverts commit 05267e5e.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > Reland "Cancel parallel download request if server doesn't send partial response"
> > 
> > This reverts commit 13077433.
> > 
> > Reason for revert: <INSERT REASONING HERE>
> > 
> > Original change's description:
> > > Revert "Cancel parallel download request if server doesn't send partial response"
> > > 
> > > This reverts commit 189d1033.
> > > 
> > > Reason for revert: "ParallelDownloadTest.NoPartialResponse" is flaky. See https://crbug.com/841666.
> > > 
> > > Original change's description:
> > > > Cancel parallel download request if server doesn't send partial response
> > > > 
> > > > If the server doesn't support partial responses, Chrome should cancel
> > > > parallel download requests.
> > > > These requests result in the wrong write offset and makes the file larger
> > > > than the original
> > > > 
> > > > BUG=838627
> > > > 
> > > > Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba
> > > > Reviewed-on: https://chromium-review.googlesource.com/1048130
> > > > Commit-Queue: Min Qin <qinmin@chromium.org>
> > > > Reviewed-by: Xing Liu <xingliu@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#557252}
> > > 
> > > TBR=qinmin@chromium.org,xingliu@chromium.org
> > > 
> > > Change-Id: I995c3c48fe39c535275a353130b10204009c5e30
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 838627, 841666
> > > Reviewed-on: https://chromium-review.googlesource.com/1053470
> > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> > > Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#557489}
> > 
> > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org
> > 
> > Change-Id: I47a2d4131efa8b863d9868eeca74e99d7beeaa8e
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 838627, 841666
> > Reviewed-on: https://chromium-review.googlesource.com/1054887
> > Reviewed-by: Min Qin <qinmin@chromium.org>
> > Commit-Queue: Min Qin <qinmin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#557734}
> 
> TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org
> 
> Change-Id: I7a618b9533229ea1bb97ff65470e9c60fe580a49
> No-Try: true
> Bug: 838627, 841666
> Reviewed-on: https://chromium-review.googlesource.com/1053729
> Reviewed-by: Max Morin <maxmorin@chromium.org>
> Commit-Queue: Max Morin <maxmorin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557834}

TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org,maxmorin@chromium.org

Change-Id: I4a0d7eb869a61e38d01424427976121fe7f13384
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 838627, 841666
Reviewed-on: https://chromium-review.googlesource.com/1055710Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557969}

6682345b

Move kChromeVoxExtensionId from chrome/common/extensions/ to... · ba355f65

David Bertoni authored May 11, 2018

Move kChromeVoxExtensionId from chrome/common/extensions/ to extensions/common/ so it's available there.

The constant will be needed for https://chromium-review.googlesource.com/c/chromium/src/+/993753.

Bug: 821858
Change-Id: I5caf0ee476c67c5fea276bcc92f7207a8fe24c18
Reviewed-on: https://chromium-review.googlesource.com/1050733Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557968}

ba355f65

Don't restrict creation of ChannelIDService to only when features::kChannelID is enabled · 141dfc70

Nick Harper authored May 11, 2018

This is a revert of http://crrev.com/1e5757d just for the two files here.

Bug: 841685
Change-Id: I4d6b211d45e2b2104b440daa8c8f6715fb6c5ab2
Reviewed-on: https://chromium-review.googlesource.com/1055678Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557967}

141dfc70

Implement a pref mode for the recurrent error message · c657d45e

Emily Stark authored May 11, 2018

When a certificate error recurs multiple times within a browsing session, we add
a special message to the interstitial. This CL adds a Finch-controlled mode
where the count of certificate errors is stored in a pref instead of in memory,
so that we can trigger the recurrent error message when an error recurs within a
certain period of time (even spanning browsing sessions). We might want to roll
out this pref mode on certain platforms (like Android) where browsing sessions
might be significantly shorter than desktop.

Bug: 839969
Change-Id: I04f1af1aa30043821859f4459602627b9ba7af77
Reviewed-on: https://chromium-review.googlesource.com/1053563
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557966}

c657d45e

Roll src/third_party/pdfium/ 5e0b271b6..ddfa51770 (1 commit) · 87d1292f

pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com authored May 11, 2018

https://pdfium.googlesource.com/pdfium.git/+log/5e0b271b6935..ddfa5177021f

$ git log 5e0b271b6..ddfa51770 --date=short --no-merges --format='%ad %ae %s'
2018-05-11 tsepez Use more smart pointer types in CPDF_DIBSource.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I384b93f8a78de43c7f16f9ecda2ba3c8eb981255
Reviewed-on: https://chromium-review.googlesource.com/1055671
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557965}

87d1292f

[vr] Add ability to close tab in tabs view · 8f0ec23f

Tibor Goldschwendt authored May 11, 2018

Adds a button to close tab and plumbing to send the close request to
Java.

Bug: 838937
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I45d6d8c3c66674bc472a17335a6e02195f8a23b8
Reviewed-on: https://chromium-review.googlesource.com/1050794
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557964}

8f0ec23f

Initialize ResourceError::extended_error_code_ to zero · 1c4d0048

Johannes Henkel authored May 11, 2018

Not all constructors write this field, so defaulting to zero
may some day help avoid grief from uninitialized values or
undefined behavior.

Change-Id: I478ecbc346a78d68721e3731f9cec9aad77919fa
Reviewed-on: https://chromium-review.googlesource.com/1054611
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557963}

1c4d0048

[PRESUBMIT] Adjust MessageLoop::QuitWhenIdleClosure presubmit · 574b31d7

Gabriel Charette authored May 11, 2018

to encompass in-progress API move to MessageLoopCurrent

R=dpranke@chromium.org

Bug: 825327
Change-Id: I962ba3c652fa0ca38e69e6bf830d3846b28a3f8f
Reviewed-on: https://chromium-review.googlesource.com/1055729Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557962}

574b31d7

[Chromecast][Bluetooth] Unset services discovered on disconnect · 56e71abb

Bailey Forrest authored May 11, 2018

BUG=internal b/79494936
TEST=cast_bluetooth_unittests. Manual

Change-Id: I8b541dbbb8e9a20d72b5ec940a73827b5dbc51ef
Reviewed-on: https://chromium-review.googlesource.com/1053589Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Bailey Forrest <bcf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557961}

56e71abb

Remove the DispatchSafetyNetCheckOffThread feature. · 2e9b8ae6

Varun Khaneja authored May 11, 2018

It is not required anymore since now we make the call to GmsCore
in the SBUtilThread now. See: https://crrev.com/i/604955

TODO(vakh): Remove the Finch config. See http://cl/196164835

Bug: 839190
Change-Id: I51b24395e647f4c1063f2e16c28202270464fe8b
Reviewed-on: https://chromium-review.googlesource.com/1050804
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557960}

2e9b8ae6

Update MockPeerConnectionImpl::SetBitrate for webrtc api change. · 4f1e97b9

Niels Möller authored May 11, 2018

See https://webrtc-review.googlesource.com/74020

Bug: None
Change-Id: I9f785c3ea49f744d75cd6d931d95240f1c0abf78
Reviewed-on: https://chromium-review.googlesource.com/1054293Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557959}

4f1e97b9

Don't suppress Showpress after a GFC followed by Tap down suppression · 76b93d2d

Sahel Sharify authored May 11, 2018

Showpress should get forwarded after a GFC followed by Tap down suppression.

Bug: 842221
Change-Id: I60beaf3296557ec8c3d3d25b627f272b82114eed
Reviewed-on: https://chromium-review.googlesource.com/1055653Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557958}

76b93d2d

Roll src/third_party/angle/ 8073a9511..586620825 (2 commits) · abd7806b

angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com authored May 11, 2018

https://chromium.googlesource.com/angle/angle.git/+log/8073a9511a1e..586620825ed1

$ git log 8073a9511..586620825 --date=short --no-merges --format='%ad %ae %s'
2018-05-10 geofflang Pass a gl::Context to ShaderImpl methods.
2018-05-07 geofflang GL: Refactor TextureGL to not hold renderer objects.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Ie86209d62e2fb9cf8f3e134dcc5532c67f262afe
Reviewed-on: https://chromium-review.googlesource.com/1055667Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557957}

abd7806b

Disabling 4 flaky tests on TSAN · f8365bdf

Tommy Martino authored May 11, 2018

Tests:
SitePerProcessHitTestBrowserTest.SurfaceHitTestPointerEventsNone
SitePerProcessHitTestBrowserTest.CreateContextMenuTest
SitePerProcessHighDPIHitTestBrowserTest.HitTestWatermark
SitePerProcessHitTestBrowserTest.InputEventRouterWheelCoalesceTest

Bug: 833380
Change-Id: Ifb7a45569f1be2636dc3f7d79bffa4bfdaf2dce8

TBR=kenrb@chromium.org

Change-Id: Ifb7a45569f1be2636dc3f7d79bffa4bfdaf2dce8
Reviewed-on: https://chromium-review.googlesource.com/1055663Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557956}

f8365bdf

Add GPU FYI Android dEQP Vk bots · de4c73a8

Yuly Novikov authored May 11, 2018

Bug: 839893
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8861024bb7cadc741ca8f1b366a95472d125ed90
Reviewed-on: https://chromium-review.googlesource.com/1055107Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557955}

de4c73a8

IntersectionGeometry correctly clip fixed position elements in OOPIFs · f9673ee3

Ken Buchanan authored May 11, 2018

IntersectionGeometry::ClipToRoot() incorrectly clips elements with
position:fixed when the element is in an iframe and root layer
scrolling is enabled.

This patch corrects the problem by mapping the intersection_rect_ all
the way to the out-of-process root viewport.

Bug: 840821
Change-Id: Ia418f3da3950b6ed29a0ecd85601c2cd358456fe
Reviewed-on: https://chromium-review.googlesource.com/1053840
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557954}

f9673ee3

Refresh Rect bounds when WindowCoordinate < 0 · 4abbf57b

Amirhossein Simjour authored May 11, 2018

When the View is partially outside of the Window, the rectangle
bounds should be recalculated with the assumption that the View
is started from the edges.
This will make sure that Autofill popup shows up on top/bottom
of the correct input field, when input fields doesn't fit inside
the Window.

Bug: 828759
Change-Id: I253fc9febe93e90058f95923a18cdfe5363d2186
Reviewed-on: https://chromium-review.googlesource.com/1044529Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557953}

4abbf57b

Roll src/third_party/catapult/ c458fd696..b6e96e16f (1 commit) · 0361c3ce

catapult-chromium-autoroll authored May 11, 2018

https://chromium.googlesource.com/catapult.git/+log/c458fd6963db..b6e96e16f364

$ git log c458fd696..b6e96e16f --date=short --no-merges --format='%ad %ae %s'
2018-05-10 kraynov Introduce sequence_manager tracing category.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:783309


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ia4ece1ea1f68336f2e18d6f05800735a6ae8846b
Reviewed-on: https://chromium-review.googlesource.com/1055669
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557952}

0361c3ce

Roll src/third_party/skia/ 244f754cd..103d6f616 (5 commits; 1 trivial rolls) · 2615fd17

skia-chromium-autoroll authored May 11, 2018

https://skia.googlesource.com/skia.git/+log/244f754cdd6b..103d6f616b40

$ git log 244f754cd..103d6f616 --date=short --no-merges --format='%ad %ae %s'
2018-05-11 bsalomon Define ~GrContextThreadSafeProxy in GrContext.cpp
2018-05-11 jvanverth Shadow fixes to avoid popping.
2018-05-10 csmartdalton ccpr: Bugfix for cropped paths
2018-05-11 bsalomon Make GrCaps and GrShaderCaps private.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I2421ddc5fbe23d9cb6b1b0cf9945e3be191f2469
Reviewed-on: https://chromium-review.googlesource.com/1055601Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557951}

2615fd17

Bundle component image resources in //ios/web_view. · 07faa0fc

John Z Wu authored May 11, 2018

//ios/web_view will provide images related to autofill like cvc hint
images for unmasking credit cards.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaf83a9e24148cbc7588427e14d0bc0ec86aab616
Reviewed-on: https://chromium-review.googlesource.com/1048847
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557950}

07faa0fc

Win Native Notifications: Fix window activation (2nd attempt). · da40ea37

Finnur Thorarinsson authored May 11, 2018

This fixes the issue with window activation not functioning correctly
when notifications are activated while Chrome is running but in the
background.

Bug: 837796, 734095
Change-Id: I69f5c358ba55fa997e1c3859d653638131f1394c
Reviewed-on: https://chromium-review.googlesource.com/1051708
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557949}

da40ea37

cc_blink: Remove ownership of cc::Layer from WebLayer. · 25f03011

danakj authored May 11, 2018

This is a precursor to deleting WebLayer. It makes WebLayer hold a raw
cc::Layer* pointer, forcing each owner of a WebLayer to also own a
scoped_refptr<cc::Layer>. Then we can remove the unique_ptr<WebLayer>s
in the future.

R=pdr@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If0f3f68a4fb741acea33b81a1b468a6a3d0a93ad
Reviewed-on: https://chromium-review.googlesource.com/1054589Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557948}

25f03011

Special casing windows for VR orientation device · d2d58cb0

Anna Offenwanger authored May 11, 2018

Chrome for windows does not support the relative orientation sensor, so
if we are on windows, use the absolute sensor.

Bug: 820308
Change-Id: I3630ae8417839d94bedf8901b4f1509ed8e071d0
Reviewed-on: https://chromium-review.googlesource.com/1050372
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557947}

d2d58cb0

cc_blink: Remove WebImageLayer and WebLayerImplFixedBounds · c654ee39

danakj authored May 11, 2018

Move the functionality of WebLayerImplFixedBounds directly to
GraphicsLayer. When SetContentsToImage() is called, it stores
the size of the image. Then when UpdateContentRect() occurs,
the image_layer_ (which is the contents layer) is resized
always to match the image, and transformed to fill the
content_rect.

The PaintArtifactCompositor was mutating the contents layer
bounds which would break this path, but it didn't intend
to do so for layers it doesn't control. So we move bounds
setting out of PaintArtifactCompositor for foreign layers,
and set the bounds and DrawsContent(true) at the sites where
the ForeignLayerDisplayItem is created when appropriate (ie
for each case except for GraphicsLayer::ContentsLayer()).

With the removal of WebLayerImplFixedBounds there are no
tests left in cc_blink_unittests, so we remove the test
suite.

R=trchen@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2fee4f382eb450af4646a087a08806798a975dd7
Reviewed-on: https://chromium-review.googlesource.com/1053765Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557946}

c654ee39

Autoplay: Force enable on desktop for Web Audio · 70f5eed3

Becca Hughes authored May 11, 2018

Force enable on desktop for Web Audio.

BUG=841933

Change-Id: I29a5257973c777c84c046576518e970d7cb0d2ba
Reviewed-on: https://chromium-review.googlesource.com/1054433
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557945}

70f5eed3

Settings: Make error style reusable · 1d6bd985

Bailey Berro authored May 11, 2018

- Moves CSS for error messages from the cups printers page to the settings
shared style so that it can be reused by other error messages.
- Switches Printers Page from using a custom message to using a cr_toast.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I979499a8762e2405497a2ef9f090246c775c5269
Reviewed-on: https://chromium-review.googlesource.com/996618Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557944}

1d6bd985

Use Skia's new simplified read/write pixels code paths · 6d0559c0

Brian Salomon authored May 11, 2018

Bug: 826819
Change-Id: Ia6eaca75fe43f9d9ec94f8fe644a44e8e7436675
Reviewed-on: https://chromium-review.googlesource.com/1054520Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557943}

6d0559c0

Network Error Logging: Update field trial to include NEL · 27b6403d

Douglas Creager authored May 11, 2018

Bug: 799253
Change-Id: Id1fceef526edee6f239c0d7ca0ed8e091b4c638f
Reviewed-on: https://chromium-review.googlesource.com/1052888Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Douglas Creager <dcreager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557942}

27b6403d