- 28 Sep, 2020 40 commits
-
-
Curt Clemens authored
Adds strings to ash/ash_strings.grd and uses them in the NearbyShareVisibilityFeaturePodController. Change-Id: I112c8a413bb8deffc038e9272ecbebd7f53ddc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401842 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#811285}
-
Alice Wang authored
This CL sets line height of the bottom sheet subtitle and incognito message to 20sp, according to UI mock and chrome UI spec on Android. Screenshots: https://crbug.com/1132215/#c4 Bug: 1132215 Change-Id: I7f632f2d8906a8cdbf4e4b1965a667ef38d35860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435187 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811284}
-
Jazz Xu authored
Bug: 1132904 Change-Id: If39e460248f4358002f1d05c76a32a24d3a0d154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435747Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811283}
-
Keren Zhu authored
* Change title and body text alignment to left. * Change font size to - with title: title 18pt, body 13pt, button 13pt - w/o title: body 14pt, button 13pt This change will apply to all IPH bubbles, i.e. both snooze and non-snooze bubbles. spec: go/desktop-iph-snooze-ux-spec Bug: 1121399 Change-Id: Idee04707d42d57b9f65cb99b36a29fa19a99318b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425194Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811282}
-
Francois Doray authored
Change description: ------------------- This CL changes the intensive wake up throttling policy so that it does not affect the execution of timers with nesting level < 5 : In a Window whose top Window has been hidden for 5 minutes and which is not opted out from intensive wake up throttling, a timer task can run: - on a 1-second aligned wake up if: - the task's nesting level is < 5, or, - the Window is same-origin with the top Window and at least 1 minute has elapsed since the last timer with nesting level >= 5 has run in any Window in the tree that is same-origin with the top Window - on a 1-minute aligned wake up, otherwise. Rationale: ---------- Unfortunately, limiting all timers to 1 wake up per minute caused breakages on some sites. After reaching out to site owners, we established that opting out timer tasks with nesting level < 5 prevents these breakages. Local tests suggest that most timers tasks have a nesting level >= 5. Therefore, we don't expect that this policy change will have a significant impact on power usage. Timers with nesting level >= 5 can run on a 1-second aligned wake up if there hasn't been a wake up in the last minute, because we don't want to penalize pages that have their own logic to ensure that the wake up rate is below 1 per minute. For example, a repeating timer with a 90 seconds timeout should not be affected by intensive throttling. Discussion: ----------- https://groups.google.com/a/chromium.org/g/scheduler-dev/c/EWKYCZlWjpc Bug: 1075553 Change-Id: I90d553608b9e3e64a9e6456112d5f4454d51bf1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417293Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#811281}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009280800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/W-Axu-xOAC73R6IETvUzr5ssqwyUgIQVQPtCBDfKISUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/159851982,b/161406194 Tbr: media-app@grotations.appspotmail.com Change-Id: Ief0718dce2eb40392f58fb007ca7f94cef12264e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435489Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811280}
-
Sadrul Habib Chowdhury authored
Emit a trace-event for devtools when a frame is dropped. This trace-event will be used to show the dropped frames in the devtools timeline. The |id| of the LayerTreeHostImpl is required for these trace events, so the id is plumbed through CompositorFrameReportingController to the CompositorFrameReporter during creation from LayerTreeHostImpl. BUG=1075865 Change-Id: I300d5384af6aa8ed68a56c77bac5c77f3eac8d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169848 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#811279}
-
Lei Zhang authored
Wrap |kMenuButtonDetails| in a getter function so it is initialized on first use. Also wrap it in a base::NoDestructor to prevent static destruction. Bug: 537099 Change-Id: Ia50bed6c089ee554bd0fe59677bda19280883362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429872 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#811278}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b6103ff5f992..08ae7cea30d2 2020-09-28 nisse@webrtc.org Reland "Delete the non-const version of the EncodedImage::data() method." 2020-09-28 tommi@webrtc.org Remove asyncinvoker from PeerConnection. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I29c7b64fb48ef8204c70152cf269d1901f2a29e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435490Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811277}
-
Chris Sharp authored
supported It isn't clear when this behavior was actually supported for these OS, so I picked 73 because that is when the description was updated. Also update DnsOverHttpsMode and DnsOverHttpsTemplates to list android as supported since 85. BYPASS_POLICY_COMPATIBILITY_CHECK=These platforms were already supported, this is just updating documentation. Change-Id: Id45b0819e38c46ca17bc3f78ce8724ef5f5f2065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401060 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#811276}
-
Mila Green authored
Bug: 1114719 Change-Id: I0fffe541f385079b8f34cb197c228545cfff77ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429583Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#811275}
-
Demetrios Papadopoulos authored
Fixed: 1132421 Change-Id: I7d3e3261fcd35a27bc0da0338a5c1182adca7378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431574 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#811274}
-
Tanmoy Mollik authored
This cl adds render tests for different types of sync errors in SyncErrorCardPreference. Bug: 1107420 Change-Id: I3ebc308932eadb677310ea041559bb54bbb1765c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353255 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811273}
-
Colin Blundell authored
As part of bringing up ad blocking in WebLayer, we will need to componentize the ads blocked infobar. This CL takes an initial preparatory step by changing the dependence on the //chrome-level InfoBarService to be a dependence on the //components-level ContentInfoBarManager. No actual functionality needs to be changed, as the former is a subclass of the latter. Bug: 1116095 Change-Id: Iab5920f285cfd5a3e4fa61e314e166192e4462d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429953Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#811272}
-
Garrett Beaty authored
Change-Id: I026f760b9d605d1ea29bd2a87b44990f5758a5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432139Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#811271}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/145f115c5496..306fc502cf96 2020-09-28 cwallez@chromium.org Use typed integers for the Fence FenceAPISerial 2020-09-28 cwallez@chromium.org Use typed integers for the Buffer MapRequestID If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4e8238f44655cbed855d15e6be8ae8bb3ebd7b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435488Reviewed-by:
-
Dominic Farolino authored
This CL associates RenderFrameProxy with AgentSchedulingGroup. It is a prerequisite for making AgentSchedulingGroup a fully-fledged RouteProvider and AssociatedInterfaceProvider. See: https://docs.google.com/document/d/1hnOeki8nNwZfVYi4vbid4kn12T7XS361uL0Zbb7ilSA/edit R=haraken@chromium.org, kouhei@chromium.org, talp@chromium.org Bug: 1111231, 1132901 Change-Id: Icb50fd9d11e7c53459172be86ca7834cad1a522f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432866 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Bug: 1121927 Change-Id: I5abc297d2d5573d2e6dd8a887e29b9efbd573f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422465Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#811268}
-
Adrian McCarthy authored
* De-emphasize Sheriff-O'-Matic * Add bug search link for sheriff handoffs * Sheriff is the Lexan notetaker. Change-Id: I58da53452bce1d59204bcebe473866a10e2043f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423750 Commit-Queue: Adrian McCarthy <amccarth@google.com> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#811267}
-
Gayane Petrosyan authored
TBR=estark@chromium.org Bug: 1132860 Change-Id: Ibfa8c6c05d63dd868b2b6f310079ed60226bfa87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434099Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#811266}
-
Eric Willigers authored
We update behavior to match spec change https://github.com/w3c/web-share/pull/113 If a share() call is in progress and share() is called again, the new share request fails immediately. WebShare for ChromeOS and Windows will only ever have this new behavior. WebShare for Android (already shipped) would previously spin up multiple shares simultaneously. Spec: https://w3c.github.io/web-share/#share-method Note: we no longer have an Android post Lollipop MR1 test for user cancellation of the dialog - the existing test simply issues a second share request. Bug: 1002337 Change-Id: I1bef4923cb048a28f882f9dac889c841f1fc8265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425933Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#811265}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 40d727bf. With Chromium commits locally applied on WPT: 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." 9a583fa4 "Increase timeout of Content-Security-Policy WP test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ib7f62e7743459b1613c696dfed364f7c3761eb0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435659Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811264}
-
Koji Ishii authored
Following up r811190 crrev.com/c/2433926 that enabled DCHECK in |Self| for block fragmentation, this patch enables the same DCHECK for |SelfAndContents|. This DCHECK was added recently, at r811125 <crrev.com/c/2428530>. Bug: 1132619 Change-Id: I45855e1d421cad90db135256745f9b92ab7621dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432148 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#811263}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ea1181f182dc..def823dfb288 2020-09-26 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-26 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-25 saklein@chromium.org BuildTargetUnitTest: Only use package atoms, not cpf. 2020-09-25 saklein@chromium.org api/validate: Add require_each validator. 2020-09-25 saklein@chromium.org api: refresh proto & fix payload unittests 2020-09-25 saklein@chromium.org api/controller: Remove redundant python version checks. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I06b168ba3a11c18b9315b3ac2d33249d1ca0ca23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435633Reviewed-by:
-
Javier Ernesto Flores Robles authored
Inject Android affiliation information and add Android credentials to the credential provider extension. Bug: 1090776 Change-Id: I2eea32a569203076214c8fa0a2ee70581bade3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424201 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#811261}
-
Alex Rudenko authored
The test has been implemented in [1] and now, when DevTools rolled, it can be enabled. [1]: crrev.com/c/2400478 Bug: 1109224 Change-Id: I43e4dffbf7d50eae856b5c78290768079094ab69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435188Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#811260}
-
Mitsuru Oshima authored
Bug: None Change-Id: I793a6870e81b2f5f50bc8341f45f30829dc40260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433585 Auto-Submit: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#811259}
-
Gayane Petrosyan authored
This reverts commit 3a4677f6. Reason for revert: bot failures due to crash at blink::AnimationWorkletGlobalScopeTest::RunScriptAndGetBoolean() see https://crbug.com/chromium/1132893 Original change's description: > Introduce ScriptEvaluationResult > > This CL introduces ScriptEvaluationResult with clearer uniform > semantics that covers both classic and module script evaluation. > ScriptEvaluationResult has ResultType enum class, to explicitly > distinguish cases where normal exceptions are thrown (kException) > from cases where not (kNotRun and kAborted). > > This CL merges ClassicEvaluationResult and ModuleEvaluationResult > into ScriptEvaluationResult. > > This maps: > - ClassicEvaluationResult::IsEmpty() > => ScriptEvaluationResult::GetResultType() != kSuccess > - ModuleEvaluationResult::IsSuccess() / IsException() > => ScriptEvaluationResult::GetResultType() == kSuccess / != kSuccess > > To keep the invariant of kSuccess <=> non-empty v8::Value, > this CL makes ModuleRecord::Evaluate() to return > ScriptEvaluationResult with a non-empty value > on successful evaluation + top-level await is not enabled, > while previously it returned ModuleEvaluationResult::Empty(). > This value is not used, and thus this change doesn't change > the behavior. > > Bug: 1111134, 1129743 > Change-Id: I350860171a3c3b63517641dfb9555b8788386438 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417789 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811244} TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,nhiroki@chromium.org,cbruni@chromium.org,dom@chromium.org Change-Id: Iaaca1345213b1f3e4fc8ec703257217998ec0826 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111134 Bug: 1129743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435918Reviewed-by:
-
Torne (Richard Coles) authored
When using a subdirectory of the Android cache dir (e.g. in WebView), explicitly create the directory in PathUtils instead of relying on any user of the directory creating it implicitly. Set the directory mode to 02700 which is what it currently gets set to when created implicitly. Fixed: 963640 Change-Id: I8e1c140241d6a2decfcd27186b767ef05e7a4320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432447Reviewed-by:
Anna Malova <amalova@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#811257}
-
Titouan Rigoudy authored
For subresource URL requests, the renderer URLLoader uses its factory's parameters to determine the client security state of the request initiator. Navigations however use a central URLLoaderFactory in the browser process. This change introduces a new trusted parameter in ResourceRequest specifying the client security state applying to the current request, if not was set in the factory parameters. Regarding //services/network and BUILD.gn changes in particular: A lot of these changes stem from the introduction of ClientSecurityState as a new dependency of url_loader.mojom and URLRequest's typemap, ResourceRequest. This breaks the existing layering scheme: mojom:url_loader_base -> cpp:cpp_base Because suddenly cpp:cpp_base must depend on mojom:url_loader_base for client_security_state.mojom.h. We break the cycle by extracting the dependency of mojom:url_loader_base from cpp:cpp_base into its own build target: cpp:cpp_base -> mojom:url_loader_base -> cpp:cross_origin_embedder_policy Bug: chromium:1124346 Change-Id: Ie42d604b628a147a3963df0b20cc88b8b61bf98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401523 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#811256}
-
Aga Wronska authored
The feature has been disabled in Chrome OS < M87 with Finch kill-switch and in this cl we apply the same change in Chromium repo. Bug: 1132862 Change-Id: I7c3446b6a6d7e4d06cdf2df5f12d6cf9eec4dc24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435721Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Auto-Submit: Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#811255}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ad6aeace6eee..59d660c075bd 2020-09-28 ethannicholas@google.com Revert "Revert "moved SkSL BoolLiteral data into IRNode"" 2020-09-28 johnstiles@google.com Update OutParams unit test to demonstrate SkSL failure. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I58a2d4c4e667f379a145bd2816313123aa079d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435628Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/667efcdc..685e35de Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1efc2ba62f0ebbb7588a76c4e37787ea0c8d4800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435658Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811253}
-
Gayane Petrosyan authored
This reverts commit b8368dd1. Reason for revert: CreateSignedInProfile test causes failures on multiple bots Bug: 1132882 Original change's description: > [Profile creation] Show sync confirmation and finish the flow > > This CL proceeds with the happy path of the signed-in profile creation > flow: > 1) After a successful sign-in, the current WebUI for sync confirmation > gets displayed; > 2) After choosing whether to sync, the flow is finished by opening a > browser window for the new profile. > > Error handling and restyling the confirmation page is left for follow-up > CLs. > > Bug: 1126913 > Change-Id: I17b43fe4ec0c0e0f2f9725b1df8e8e59d2c35f3d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421592 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811140} TBR=droger@chromium.org,jkrcal@chromium.org Change-Id: I89cf0130e744a1feee9649df1895839e0fe4b314 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435330 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
-
Mikel Astiz authored
This should make tests slightly faster in general, but in particular they may help on Mac where the wait contributes to flakes. Change-Id: I7b8711676123a7fd1ce58505dffbd29f4043b482 Bug: 1131588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434329 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ba3d5932bb28..58ceb60bf6b1 2020-09-28 tvanderlippe@chromium.org Move compiler options into tsconfig.base.json 2020-09-28 bmeurer@chromium.org Improve error reporting for the language plugins. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1132281 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I99168aaa966b0e9f201a9c4913a5b555b592887e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435621Reviewed-by:
-
arthursonzogni authored
Since: https://chromium-review.googlesource.com/c/chromium/src/+/2428976 the "receive" timeout is now infinite. It means all the tests in property.https.html will either all succeed or if one of them fails, it will timeout. This patch split the test in order to get individual results. This allow us to prevent individual regression. Bug: 1090273 Change-Id: I5629e4130dbabde44755468bc7b28ea0d0e802f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435638Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811249}
-
Chunbo Hua authored
Bug: 1129754 Change-Id: I6e9c50880541095008f8b71d25455e9a59128f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397669Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> Cr-Commit-Position: refs/heads/master@{#811248}
-
Andrew Grieve authored
Noticed this in binary size review as having a lot of nested classes. Also removes most explicit null checks in favor of implicit ones. Bug: None Change-Id: I9777788512371b497c4236f16073a2b342e1acb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419121Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#811247}
-
cfredric authored
This reverts commit 35a98eb4. Reason for revert: HIDDevice is a "leaf" API, so we should instrument via navigator.hid.getDevices() instead. Original change's description: > Instrument access to HIDDevice and HIDReportItem fields. > > This cl causes the bindings generator to automatically collect UKM when > these attributes are accessed. This will be used to analyze how much > entropy leaked by this API can be used for cross-site tracking. > > Change-Id: I25fddca92048669e25674070b0f619368270346c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424073 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Chris Fredrickson <cfredric@google.com> > Cr-Commit-Position: refs/heads/master@{#809753} Change-Id: I48f17cb23f3ba7fe7d31be78d6549127f6186fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432666 Auto-Submit: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#811246}
-
