- 23 Jan, 2019 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a824c339c217..3eabfafdae1e git log a824c339c217..3eabfafdae1e --date=short --no-merges --format='%ad %ae %s' 2019-01-23 lalitm@google.com Merge "trace_processor: add support for polled oom_score_adj" 2019-01-23 treehugger-gerrit@google.com Merge "profiling: Log on pipeline stall." Created with: gclient setdep -r src/third_party/perfetto@3eabfafdae1e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I1bda3ef94d7f99044c6e5f7116410da7a27d5539 Reviewed-on: https://chromium-review.googlesource.com/c/1431455Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625392}
-
Xiaohui Chen authored
Bug: None Test: locally build and run Change-Id: Ifdb6e31b926da18c6da47e7a2a5540f58e9fa9a9 Reviewed-on: https://chromium-review.googlesource.com/c/1423620Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#625391}
-
Dan Beam authored
FireWebUIListener(name, ...) is essentially an alias for: CallJavascriptFunction("cr.webUIListenerCallback", base::Value(name), ...); Using it reduces the amount of times we paste "cr.webUIListenerCallback" and generally reduces the amount of parallel paths for notifying running web UI pages. R=aee@chromium.org BUG=none Change-Id: Id3ee2622949c0fd1bba9705655de4cb0faf386f4 Reviewed-on: https://chromium-review.googlesource.com/c/1431293Reviewed-by:Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625390}
-
Nicolas Pena authored
This CL resets the pending pointerdown information in InteractiveDetector when a pointerCancel or pointerCausedUaAction are detected because those indicate that scrolls have happened. This CL also changes the UMA and UKM metrics affected by this change by adding a 2 at the end of the histogram names. Bug: 924278 Change-Id: I4b42e9478c74d9ba42b77170800b6267151c91e8 Reviewed-on: https://chromium-review.googlesource.com/c/1427924 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#625389}
-
Lei Zhang authored
The PrinterQuery being passed in is never nullptr, since the caller is written as: printer_query->SetSettings(..., printer_query). Change-Id: I97bdd100743e35b967de8b34df6bbfed2bb80216 Reviewed-on: https://chromium-review.googlesource.com/c/1428406Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#625388}
-
Alexei Svitkine authored
This test is flaky on platforms that where Sleep(delta) isn't guaranteed to be in TimeTicks (e.g. on Mac, it's in base::Time). Use base::test::ScopedTaskEnvironment::MainThreadType::MOCK_TIME instead. Also, cleans up some APIs and adds a comment to the Sleep() API. Bug: 915672 Change-Id: Ib539c0d06a217dfdb9ee6f7411e885d6975438a9 Reviewed-on: https://chromium-review.googlesource.com/c/1427927 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#625387}
-
Dan Beam authored
Pretty much everything should use --cr-link-color, which magically changes based on light/dark mode. There was also just a ton of duplicated a[href] rules, which I instead added to shared_style.html (and verified each place I deleted from used include="shared-style"). Screenshots: https://imgur.com/a/kaT6MJc R=dpapad@chromium.org BUG=883049 Change-Id: I00440e1bcfaae21b31763f51d65385729ba7fab9 Reviewed-on: https://chromium-review.googlesource.com/c/1429379 Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625386}
-
Mitsuru Oshima authored
Bug: 924322 Test: None Change-Id: Ief0e8239031f82984c48f08dbf332584f67c5b48 Reviewed-on: https://chromium-review.googlesource.com/c/1428839Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#625385}
-
Reid Kleckner authored
This reverts commit 5a0921ab. Reason for revert: Seems to cause ThirdPartyConflictsManagerTest.InitializeUpdaters to fail in official builds. Original change's description: > Get the CertificateInfo of the current exe from ModuleDatabase > > The ThirdPartyConflictsManager needs the CertificateInfo of the current > executable to identify third-party DLLs. It used to create it itself, > but that information is already available from the ModuleDatabase. > > Bug: 921746 > Change-Id: I3d57d289f17bac563fed498e59f48c3bbc9f4f64 > Reviewed-on: https://chromium-review.googlesource.com/c/1426061 > Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624901} TBR=pmonette@chromium.org,sebmarchand@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 921746, 852295 Change-Id: I74a40d6c9af0c41c487e6201581230d537c56daa Reviewed-on: https://chromium-review.googlesource.com/c/1432233Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#625384}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f7971436824d..695e7cf35258 git log f7971436824d..695e7cf35258 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@695e7cf35258 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I02676c5883f16255d66f67f76a39ceb0711992c8 Reviewed-on: https://chromium-review.googlesource.com/c/1431454Reviewed-by:
-
Matthew Jones authored
Bug: 901952 Change-Id: If2338a9904c0d0ff5f831769d1549001adcb0b3b Reviewed-on: https://chromium-review.googlesource.com/c/1431112 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#625382}
-
Lakshmi Kumar Dabbiru authored
As per UX review Screenshots with change - https://screenshot.googleplex.com/is30KnFrqJv - https://screenshot.googleplex.com/X9RqOSW4PVz Bug: 913646 Change-Id: I052ede08da6aaf7d994e48e69f502e182f71a878 Reviewed-on: https://chromium-review.googlesource.com/c/1427979Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Cr-Commit-Position: refs/heads/master@{#625381}
-
Elly Fong-Jones authored
This change: 1) Marks uses of launch_data_t as deprecated with no replacement (so ignored); 2) Marks uses of the NSObject accessibility API as deprecated to be replaced (per bug 921109) 3) Replaces one use of CWInterface with a corresponding use of CWWiFiClient, and marks another as ignored for now; 4) Replaces some LaunchServices invocations with their new equivalents; 5) Marks GTM to ignore deprecation warnings, since the GTM dependency will go away soon anyway; 6) Fixes how blink refers to NSCalendarIdentifierGregorian; 7) Replaces some uses of NSRunAlertPanel with explicit constructions of NSAlert; 8) Bumps the deployment target to 10.10 An earlier version of this change attempted to incrementally upgrade, but many of the replacement APIs are themselves only @available on 10.10, so it proved to be significantly uglier. Bug: 841631 Change-Id: Ic6e96efbb84ba0a077eda3528b452137d64f5f02 Reviewed-on: https://chromium-review.googlesource.com/c/1407177 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625380}
-
Jordan Rupprecht authored
Clang built from trunk now implements _xgetbv, causing errors as it is now redefined. Modeled after https://crrev.com/c/1414858 which is a similar fix to v8. TEST=built locally with clang from trunk Change-Id: Ie1c242ae6b9ae34b695a512991e90a74dfafdedc Reviewed-on: https://chromium-review.googlesource.com/c/1431352Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jordan Rupprecht <rupprecht@google.com> Cr-Commit-Position: refs/heads/master@{#625379}
-
Sam Maier authored
Change-Id: Idc5b8baf277b02a4adf0ff4835f45ea0a7b0f513 Reviewed-on: https://chromium-review.googlesource.com/c/1431233Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#625378}
-
Xing Liu authored
This CL extends expiry of several metrics related to download and media. Useful for implementing new feature: Android.DownloadManager.ViewRetentionTime.Video Android.DownloadManager.ViewRetentionTime.Audio Download.DeleteRetentionTime.Video Download.DeleteRetentionTime.Audio Important system health metrics: Download.ParallelDownloadAddStreamSuccess Download.ParallelDownloadRequestCount Bug: 918380,918378 Change-Id: Id597b9a8ae3ed72f1c0b0cd95ef36df4b5467d8d Reviewed-on: https://chromium-review.googlesource.com/c/1428741Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#625377}
-
Nate Fischer authored
This adds proper logic to run_cts.py to auto-determine the device architecture, and to throw an error if the device architecture is not supported. This also adds unit tests (and configures them to run on presubmit). Although this is not a significant improvement (we still only support "arm64"), this gives fast, clear feedback when the device is unsupported (e.g., emulators), and the logic should generalize as we support more architectures. This also adds logging (which will be visible with --verbose, to aid debugging). This does minor refactoring in the script, to plumb arch where it's used instead of reassigning to args.arch (which should help with testability in the future). R=aluo@chromium.org Bug: 922854 Test: vpython android_webview/tools/run_cts_test.py Test: android_webview/tools/run_cts.py (script still runs) Change-Id: I6528ab836f30b5885ede59853acaeee69de26fa2 Reviewed-on: https://chromium-review.googlesource.com/c/1419840 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625376}
-
Dominic Battre authored
This reverts commit c13cea62. Reason for revert: Fixed memory problem Original change's description: > Revert "Don't record first filling result for sign-in forms" > > This reverts commit 34d69265. > > Reason for revert: breaks msan > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/14500 > > Original change's description: > > Don't record first filling result for sign-in forms > > > > The new form parser may decide that a form has no current-password element, but > > only new-password / confirmation elements. In this case, the parser sets the > > unique_renderer_id to 'undefined'. The credentials will be sent to the renderer > > for filling via manual fallback but the renderer won't ever fill (as there is > > no password element defined for filling. > > > > This CL ensures that this case does not get recorded as a failure to fill. This > > is important because we record two metrics about the first fill attempt: > > PasswordManager.FirstWaitForUsernameReason and > > PasswordManager.FirstRendererFillingResult For websites that have a sign-up > > form followed by a sign-in form, we don't want to record the failure to fill on > > the sign-up form. > > > > Bug: 918846 > > Change-Id: I79e9a73ae3573a81e121eaa483e0ecef0889184f > > Reviewed-on: https://chromium-review.googlesource.com/c/1422018 > > Commit-Queue: Dominic Battré <battre@chromium.org> > > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#625178} > > TBR=battre@chromium.org,dvadym@chromium.org > > Change-Id: I3c68004b67b5fcc65511c611c2d205297596e782 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 918846 > Reviewed-on: https://chromium-review.googlesource.com/c/1430581 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625227} TBR=dvadym@chromium.org,jam@chromium.org Bug: 918846 Change-Id: I671bc4674f1660920eae0c73d5b1b01b49311383 Reviewed-on: https://chromium-review.googlesource.com/c/1431172Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#625375}
-
Dan Beam authored
In dark mode, the *icon* color differs slightly from the *text* color. Screenshots: https://imgur.com/a/asWpYhY Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g48a476f4a5_2_42 R=dpapad@chromium.org BUG=883049 Change-Id: I67521d7505f1b27f212b4813c853074f88c28971 Reviewed-on: https://chromium-review.googlesource.com/c/1429196 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Kristi Park authored
https://crrev.com/c/1427543 fixed the case where a custom background is set and dark mode is disabled. However, this does not cover the case where both a custom background and theme are not set. Improve dark theme detection by only checking for dark mode if no custom background or theme is set. Otherwise, default to the regular dark theme detection. Bug: 923797 Change-Id: If4f8863cc2a29ed3f8908bbc9d89a7b5ad92a336 Reviewed-on: https://chromium-review.googlesource.com/c/1428440 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#625373}
-
Parastoo Geranmayeh authored
Wait for the OnPersonalDataFinishedProfileTasks, rather than OnPersonalDataChanged. Rename the class accordingly. Bug: 919967 Change-Id: I6e1808f67c384d99cb4f88d33f6d5ffb7d83d972 Reviewed-on: https://chromium-review.googlesource.com/c/1427792 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#625372}
-
Dan Beam authored
This mainly affects section titles and subpage titles in settings. R=dpapad@chromium.org BUG=883049 Change-Id: I614cf44adb70becc5ef00479bd19c5372c4929c4 Reviewed-on: https://chromium-review.googlesource.com/c/1429661 Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Reviewed-by:
-
Steve Kobes authored
These were generating spurious janks on scroll, because the visual rect moves. (The old / new rects are mapped into the viewport's coordinate space, but both of these mappings use the updated scroll offset.) This is a temporary fix until we figure out a better way to detect real layout janks in fixed or sticky elements. Bug: 581518 Change-Id: I405c0933eb3cd52c135e97db55cb72c32dedc1a6 Reviewed-on: https://chromium-review.googlesource.com/c/1430589 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#625370}
-
Anne Lim authored
Intruduced LocalCardMigrationStrikeDatabase and added an AddStrikes and RemoveStrikes functions, which allows multiple strikes to be added at once. Bug: 920385 Change-Id: Ifbfad49c9d67570098b0e71d7a3fda1800563413 Reviewed-on: https://chromium-review.googlesource.com/c/1422701Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#625369}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/08b0b7fd5bd5..114b5af0e8cc git log 08b0b7fd5bd5..114b5af0e8cc --date=short --no-merges --format='%ad %ae %s' 2019-01-23 herb@google.com Fix bookmaker 2019-01-23 michaelludwig@google.com Increase tolerance in rectilinear quad detection 2019-01-23 herb@google.com Add getTypefaceOrDefault and refTypefaceOrDefault Created with: gclient setdep -r src/third_party/skia@114b5af0e8cc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:923946 TBR=djsollen@chromium.org Change-Id: Ie46dc2488dbfaf8cfd2546987c0a1cce374d712d Reviewed-on: https://chromium-review.googlesource.com/c/1431453Reviewed-by:
-
Kristi Park authored
Screenshots: https://screenshot.googleplex.com/FqstoCzbOE2.png https://screenshot.googleplex.com/X0oy2QqeDt9.png https://screenshot.googleplex.com/tH0us5zzBJM.png Bug: 919961, 923988 Change-Id: I00bcf543284fb83a2565e9ff73701a07ac279dca Reviewed-on: https://chromium-review.googlesource.com/c/1428740 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
Bug: 924390 Test: None Change-Id: I2aa1f8dc832bfbc1a7ce8ff1154adedac55a2af1 Reviewed-on: https://chromium-review.googlesource.com/c/1429059Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#625366}
-
Salvador Guerrero authored
Modified the SharedProtoDatabaseClientList::ShouldUseSharedDB function to let us migrate each client to SharedProtoDatabase with a finch experiment Bug: 870813 Change-Id: Ife62d81a719387ec8fc0866191b0db5645707728 Reviewed-on: https://chromium-review.googlesource.com/c/1406296 Commit-Queue: Salvador Guerrero <salg@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#625365}
-
Ben Pastene authored
Bug: 907899 Change-Id: Ic300c8d4120a581e2ea756a88b2498e5f861064c Reviewed-on: https://chromium-review.googlesource.com/c/1428819 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#625364}
-
Jacob Dufault authored
Bug: 908498 Change-Id: I763088c5a8f6eb065c563ae269e6ec24955aa1fc Reviewed-on: https://chromium-review.googlesource.com/c/1351688 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#625363}
-
Lei Zhang authored
Initialize printing on Android the same way as other platforms, instead of in TabAndroid::Print(). By calling printing::InitializePrinting() like other platforms, the PDF compositor will be created as needs. Also implement PrintCrossProcessSubframe() in TabWebContentsDelegateAndroid to redirect the subframe print request, since the Browser class does not exist on Android. BUG=890417 Change-Id: I7195cf2afe2560dd56a56b5a769acf9e51bbb41b Reviewed-on: https://chromium-review.googlesource.com/c/1420302 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#625362}
-
Jordan Demeulenaere authored
Change-Id: I3e9579e7e0fdf3bb90e1a6d806045a6a1207a230 Reviewed-on: https://chromium-review.googlesource.com/c/1430009 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#625361}
-
Kurt Horimoto authored
This CL updates UpdateDisabledCounterForContentHeight()'s implementation in two ways: - Accounts for the case when the FullscreenProvider is disabled and the scroll view may have been resized to a shorter height despite the content being fully visible on screen. - Updates to a <= check so that fullscreen is disabled when the content fits the scroll view exactly. Bug: 914347 Change-Id: I5d2c6e3ce09d25552de0f1071785d29078162377 Reviewed-on: https://chromium-review.googlesource.com/c/1423092 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#625360}
-
Owen Min authored
1) Use raw string to avoid multiple escapes. 2) Add tests for plugins and signed in user data. 3) Add slash and quote in the test data to make sure they can be escaped properly by the report helper. Bug: 924645 Change-Id: I00d6166d967d8ebae82ac8bba5cc698b3eb2e418 Reviewed-on: https://chromium-review.googlesource.com/c/1431335Reviewed-by:
Marc-André Decoste <mad@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625359}
-
Tommy C. Li authored
Currently, when Steady State Elisions is on, and the user unelides the URL, we put the full URL into the user text. This was convenient, but has some unintended consequences. Namely: 1) user_input_in_progress() as a boolean state becomes confusing, as sometimes it means the user has edited the URL, and sometimes it means the the user has merely unelided the URL. 2) Consequently, in many places in the code, we check if user input in progress AND if the user has meaningfully edited the URL away from the full URL text. 3) That's not obvious to non-omnibox owners, so it creates bugs like the one linked below. This CL changes how unelision works so it only updates the View's text and leaves the model's user-text alone. It no longer sets user_input_in_progress to true for mere unelision. This allows us to clean up fair number of callsites and puts the nail in the coffin for the below linked bug too. Bug: 921777 Change-Id: I9d113649f50c0bfafa1d112002add577e05928f7 Reviewed-on: https://chromium-review.googlesource.com/c/1427244Reviewed-by:manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#625358}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/56250c3ee3c0..3dfb55b889fd git log 56250c3ee3c0..3dfb55b889fd --date=short --no-merges --format='%ad %ae %s' 2019-01-23 vmiklos@collabora.co.uk core: use the libjpeg boolean type in the jpeg codec Created with: gclient setdep -r src/third_party/pdfium@3dfb55b889fd The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4ab6bd306e1f15d231dffcc8c6e354ad347f9cd6 Reviewed-on: https://chromium-review.googlesource.com/c/1431492Reviewed-by:
-
Ken Rockot authored
This wipes out the last remaining usage of runtime JSON manifest parsing in favor of using build-time generated C++ manifests. All support code for parsing JSON manifests at runtime is removed as well. Bug: 895616 Change-Id: I35fdc82b719de4fbedb54ba433dda4293fb0f893 Reviewed-on: https://chromium-review.googlesource.com/c/1423354Reviewed-by:
-
chuanl authored
Bug: 882404 Change-Id: Iaa93ed3b96a70ba78fff6bc711eb0404b52f179f Reviewed-on: https://chromium-review.googlesource.com/c/1412397Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: John Lin <chuanl@google.com> Cr-Commit-Position: refs/heads/master@{#625355}
-
Paul Meyer authored
TBR: iclelland@chromium.org Change-Id: I70b78d5d9191ad554363ce26c76ba62469900de6 Reviewed-on: https://chromium-review.googlesource.com/c/1431013Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#625354}
-
Brian White authored
Bug: 923083 Change-Id: I25136857b84832ac896e76f32c182af8eb190e15 Reviewed-on: https://chromium-review.googlesource.com/c/1418517Reviewed-by:
-
