GitLab

Cr-Commit-Position: refs/heads/master@{#318618}

NOTRY=true
R=dgozman
BUG=

Review URL: https://codereview.chromium.org/969573002

Cr-Commit-Position: refs/heads/master@{#318617}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f3e1a64..06742c8

TBR=

Review URL: https://codereview.chromium.org/968663003

Cr-Commit-Position: refs/heads/master@{#318616}

This is causing a huge amounts of renderer crashes because of RESULT_CODE_KILLED_BAD_MESSAGE.  Reverting this from master.

Revert "<webview>: Removed ResolveURL"

This reverts commit c2fc6144.

Cr-Commit-Position: refs/heads/master@{#318615}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/89bf02d..f3e1a64

TBR=

Review URL: https://codereview.chromium.org/964113002

Cr-Commit-Position: refs/heads/master@{#318614}

Revert of Roll Clang 223108:230631 (+revert of r229678) (patchset #5 id:80001 of https://codereview.chromium.org/959443002/)

Reason for revert:
Linux Chrome build is broken: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/56230

Original issue's description:
> Roll Clang 223108:230631 (+revert of r229678)
>
> Also introduce a build number in the package name, stop versioning
> the Blink GC plugin, and remove repackage.sh.
>
> BUG=444089
> TBR=jln, jbauman
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/b8be3a268134f32d667b42ea60a27c0084063873
> Cr-Commit-Position: refs/heads/master@{#318610}

TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444089

Review URL: https://codereview.chromium.org/970623002

Cr-Commit-Position: refs/heads/master@{#318613}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/aa6d619..89bf02d

TBR=

Review URL: https://codereview.chromium.org/964063002

Cr-Commit-Position: refs/heads/master@{#318612}

This required plumbing a flag to enable property tree verification. I've
also had to disable the opacity check for skipping VisibleContentRect
computation.

BUG=386810

Review URL: https://codereview.chromium.org/918633003

Cr-Commit-Position: refs/heads/master@{#318611}

Also introduce a build number in the package name, stop versioning
the Blink GC plugin, and remove repackage.sh.

BUG=444089
TBR=jln, jbauman
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/959443002

Cr-Commit-Position: refs/heads/master@{#318610}

Revert of Make sure the --site-per-process flag is present for subframe process swaps. (patchset #3 id:40001 of https://codereview.chromium.org/959303003/)

Reason for revert:
Somewhat speculative; looks like this might have turned the asan/win bot red. (See comment #17 on the review for links / stack.)

Original issue's description:
> Make sure the --site-per-process flag is present for subframe process swaps.
>
> BUG=461494
> TEST=Crash report should show that --site-per-process flag is present.
>
> Committed: https://crrev.com/159d8ae5ad6c2b45a3c891cef89fe15cdaf46b5e
> Cr-Commit-Position: refs/heads/master@{#318558}

TBR=alexmos@chromium.org,creis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=461494

Review URL: https://codereview.chromium.org/971443003

Cr-Commit-Position: refs/heads/master@{#318609}

NOTRY=true

BUG=462520

Review URL: https://codereview.chromium.org/967513002

Cr-Commit-Position: refs/heads/master@{#318608}

Revert of Revert of Update V8 to version 4.3.10. (patchset #1 id:1 of https://codereview.chromium.org/961143003/)

Reason for revert:
This revert also didn't help. Relanding. Maybe something happened on these bots? The output of one test suggests to reinstall the build deps:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/10450/steps/gfx_unittests/logs/PlatformFontLinuxTest.DefaultFont

It's of course odd that this problem exists on different bots...

Original issue's description:
> Revert of Update V8 to version 4.3.10. (patchset #1 id:1 of https://codereview.chromium.org/965873003/)
>
> Reason for revert:
> Speculative revert to see whether this affects some failing tests on linux:
>
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29
>
> The two other Chromium commits in the narrowed-down range were reverted but that didn't help.
>
> Original issue's description:
> > Update V8 to version 4.3.10.
> >
> > Summary of changes available at:
> > https://chromium.googlesource.com/v8/v8/+log/27a38796..627ffe9a
> >
> > Please follow these instructions for assigning/CC'ing issues:
> > https://code.google.com/p/v8-wiki/wiki/TriagingIssues
> >
> > TBR=machenbach@chromium.org
> >
> > Committed: https://crrev.com/a4c7ab8af2530c04fb32939585d3b021aa7d9363
> > Cr-Commit-Position: refs/heads/master@{#318556}
>
> TBR=machenbach@chromium.org,v8-autoroll@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/816e8760358a24ee2ddf5c748aa310caf4eab730
> Cr-Commit-Position: refs/heads/master@{#318603}

TBR=v8-autoroll@chromium.org,qyearsley@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/969563002

Cr-Commit-Position: refs/heads/master@{#318607}

Cr-Commit-Position: refs/heads/master@{#318606}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e51aa6f..aa6d619

TBR=

Review URL: https://codereview.chromium.org/971483002

Cr-Commit-Position: refs/heads/master@{#318605}

Cr-Commit-Position: refs/heads/master@{#318604}

Revert of Update V8 to version 4.3.10. (patchset #1 id:1 of https://codereview.chromium.org/965873003/)

Reason for revert:
Speculative revert to see whether this affects some failing tests on linux:

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29

The two other Chromium commits in the narrowed-down range were reverted but that didn't help.

Original issue's description:
> Update V8 to version 4.3.10.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/27a38796..627ffe9a
>
> Please follow these instructions for assigning/CC'ing issues:
> https://code.google.com/p/v8-wiki/wiki/TriagingIssues
>
> TBR=machenbach@chromium.org
>
> Committed: https://crrev.com/a4c7ab8af2530c04fb32939585d3b021aa7d9363
> Cr-Commit-Position: refs/heads/master@{#318556}

TBR=machenbach@chromium.org,v8-autoroll@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/961143003

Cr-Commit-Position: refs/heads/master@{#318603}

Revert of Revert of Add a new enable_nonblocking_io field trial param for QUIC (patchset #1 id:1 of https://codereview.chromium.org/970513004/)

Reason for revert:
Revert apparently didn't help, still failing:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/39616

Original issue's description:
> Revert of Add a new enable_nonblocking_io field trial param for QUIC (patchset #6 id:120001 of https://codereview.chromium.org/938003003/)
>
> Reason for revert:
> Speculative revert to see whether this affects some tests that involve loading fonts in gfx_unittests (see failures at http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29).
>
> Original issue's description:
> > Add a new enable_nonblocking_io field trial param for QUIC which enables the new non-blocking IO support on windows.
> >
> > BUG=442392
> >
> > Committed: https://crrev.com/83e8c1477cf5d41928b8c9035f0c4812828752f4
> > Cr-Commit-Position: refs/heads/master@{#318555}
>
> TBR=rtenneti@chromium.org,rch@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=442392
>
> Committed: https://crrev.com/369bca8b735e6275616052b9b9e3755f3305eb1f
> Cr-Commit-Position: refs/heads/master@{#318601}

TBR=rtenneti@chromium.org,rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=442392

Review URL: https://codereview.chromium.org/968573002

Cr-Commit-Position: refs/heads/master@{#318602}

Revert of Add a new enable_nonblocking_io field trial param for QUIC (patchset #6 id:120001 of https://codereview.chromium.org/938003003/)

Reason for revert:
Speculative revert to see whether this affects some tests that involve loading fonts in gfx_unittests (see failures at http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29).

Original issue's description:
> Add a new enable_nonblocking_io field trial param for QUIC which enables the new non-blocking IO support on windows.
>
> BUG=442392
>
> Committed: https://crrev.com/83e8c1477cf5d41928b8c9035f0c4812828752f4
> Cr-Commit-Position: refs/heads/master@{#318555}

TBR=rtenneti@chromium.org,rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=442392

Review URL: https://codereview.chromium.org/970513004

Cr-Commit-Position: refs/heads/master@{#318601}

Revert of Revert of SK_DEBUG when DCHECK_ALWAYS_ON (patchset #1 id:1 of https://codereview.chromium.org/965113002/)

Reason for revert:
Revert did not help, restoring original patch

Original issue's description:
> Revert of SK_DEBUG when DCHECK_ALWAYS_ON (patchset #1 id:1 of https://codereview.chromium.org/966593002/)
>
> Reason for revert:
> May have caused FontRenderParamsTest failures on Linux debug bots.
>
> Original issue's description:
> > SK_DEBUG when DCHECK_ALWAYS_ON
> >
> > BUG=
> >
> > Committed: https://crrev.com/879405ae813ae4a9bcbd7684d3551420d4980383
> > Cr-Commit-Position: refs/heads/master@{#318557}
>
> TBR=jam@chromium.org,mtklein@google.com,mtklein@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://crrev.com/6197d8798bb0282d42b69c535b17bd2cd92c3b38
> Cr-Commit-Position: refs/heads/master@{#318581}

TBR=jam@chromium.org,mtklein@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/963423003

Cr-Commit-Position: refs/heads/master@{#318600}

This change splits out the targets being used to track the gn
migration from  all.gyp into a separate, new file
(gn_migration.gypi), and reworks their structure to

  1) better match the gn_all target in src/BUILD.gn,
  2) identify the targets built by 'all' in gyp that
     are not yet explicitly listed in the gn_all target
     (the new 'add_to_gn_all' target),
  3) identify the targets left to be converted.

The 'add_to_gn_all' targets will simply be moved to gn_all in
a follow-up CL.

Right now these targets will be linux-only, but follow-up CLs
will expand them to the other configurations.

This CL should produce no actual changes in the builds.

R=brettw@chromium.org
BUG=461019
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/962343002

Cr-Commit-Position: refs/heads/master@{#318599}

This CL adds some VLOG to BluetoothMediaClient,
BluetoothMediaTransportClient, BluetoothMediaEndpointServiceProvider
and BluetoothAudioSinkChromeOS.

BUG=429016
TEST=None

Review URL: https://codereview.chromium.org/963983002

Cr-Commit-Position: refs/heads/master@{#318598}

remaining instrumentation of non-janky functions.

BUG=418183,462774,462778,462780,462784,462788,462789
TEST=none
TBR=rvargas,jochen,rpaquay,zea

Review URL: https://codereview.chromium.org/970463002

Cr-Commit-Position: refs/heads/master@{#318597}

This further shifts Data Reduction Proxy code from using Params to using
Config.

BUG=452773

Review URL: https://codereview.chromium.org/958683002

Cr-Commit-Position: refs/heads/master@{#318596}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dd9c584..e51aa6f

TBR=hclam@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/970513003

Cr-Commit-Position: refs/heads/master@{#318595}

Removes a compile-time switch and associated logic that was necessary in
the pre-Aura days where content change signals were not reliable.

Review URL: https://codereview.chromium.org/962503005

Cr-Commit-Position: refs/heads/master@{#318594}

BUG=455423,455469,455942,456327,456331,456373,457517,457525
TEST=none
TBR=jochen,mmenke

Review URL: https://codereview.chromium.org/962423002

Cr-Commit-Position: refs/heads/master@{#318593}

Revert of Test PostMessage to popup window (patchset #7 id:110001 of https://codereview.chromium.org/964753002/)

Reason for revert:
This landed soon after https://crrev.com/65b9392697befefd009dbe73d75dfe66894d814c which changed the signature of setWebEventHandler

As a result, it broke the linux build bot.
http://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/10739

Original issue's description:
> Test PostMessage to popup window
>
> BUG=460998
>
> Committed: https://crrev.com/51c1620185396384cfe6e2f4e3359e57c6431600
> Cr-Commit-Position: refs/heads/master@{#318591}

TBR=sgurun@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460998

Review URL: https://codereview.chromium.org/971433002

Cr-Commit-Position: refs/heads/master@{#318592}

BUG=460998

Review URL: https://codereview.chromium.org/964753002

Cr-Commit-Position: refs/heads/master@{#318591}

It's sometimes hard to tell which test is being retried because
tests are usually run in parallel among many devices. So just print the
name of test of device to make debugging easier.

BUG=

Review URL: https://codereview.chromium.org/965803005

Cr-Commit-Position: refs/heads/master@{#318590}

Provide the mechanism to allow applications to provide their own handler
for receiving postmessages on a thread separate than UI thread.

BUG=393291

Review URL: https://codereview.chromium.org/961393002

Cr-Commit-Position: refs/heads/master@{#318589}

QUIC - use a range-based for loops. Sync'ing with the internal tree.

Merge internal change: 86845495
https://codereview.chromium.org/963333002/

Deprecate FLAGS_quic_record_send_time_before_write.

Merge internal change: 86804950
https://codereview.chromium.org/965873004/

QuicConnection no longer owns the debug visitor. No behavior change.

The visitor_ isn't owned by the connection, this makes the
debug_visitor_ ownership model the same.

Merge internal change: 86801250
https://codereview.chromium.org/961173003/

Cleanup of QUIC's TransmissionInfo constructor to make more fields const
and supply them in the constructor.  No functional change.

Merge internal change: 86734009
https://codereview.chromium.org/968493002/

Fixing a bug in the QUIC prober where if we received a GOAWAY before
stream creation it would result in a crash.

I verified that given our improper client, the prober would crash
as-was, and would fail cleanly with the nullptr check but the client not
ignoring goaways.

Test changes and quic server changes.

Merge internal change: 86703503
https://codereview.chromium.org/965943002/

Remove dead method QuicUnackedPacketMap::RestoreInFlight.

Merge internal change: 86690324
https://codereview.chromium.org/960913004/

Deprecating FLAGS_quic_attach_ack_notifiers_to_packets.

Merge internal change: 86688595
https://codereview.chromium.org/969443002/

Remove RevertRetransmissionTimeout from QUIC's SendAlgorithmInterface
now that it's no longer used by QuicSentPacketManager.

Merge internal change: 86651704
https://codereview.chromium.org/963293002/

Remove stats for recording reno vs cubic mode in internal server's varz.

Removed now that we know how much cubic mode is in play.

Merge internal change: 86629919
https://codereview.chromium.org/964483005/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/968513002

Cr-Commit-Position: refs/heads/master@{#318588}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/748e82f..dd9c584

TBR=hclam@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/967003002

Cr-Commit-Position: refs/heads/master@{#318587}

host_gcc.mk was already honoring this variable, as was
the SO_RULE in nacl_gcc.mk but the LINK_RULE for nacl_gcc.mk
and nacl_llvm.mk was ignoring LDFLAGS.

Review URL: https://codereview.chromium.org/960963003

Cr-Commit-Position: refs/heads/master@{#318586}

The bots still use 'cpu_arch' to set the architecture, and the build
file was keying off of build_cpu_arch to determine whether or not
to enable NaCl, so things were failing. Updating the the code to
'current_cpu' fixes the problem correctly.

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/964003002

Cr-Commit-Position: refs/heads/master@{#318585}

This was inspired by jank in the RDH method that calls the function,
but will almost certainly have no effect on the jank.

Also switch to using a range loop in GetLoadState as well.

BUG=455952

Review URL: https://codereview.chromium.org/966943005

Cr-Commit-Position: refs/heads/master@{#318584}

remaining instrumentation of non-janky functions.

BUG=455884,462811,462812,462813,462815
TEST=none
TBR=mmenke

Review URL: https://codereview.chromium.org/964013002

Cr-Commit-Position: refs/heads/master@{#318583}

TODO: apply the same logic (as well as the suggestion hiding logic) to addresses

BUG=459741

Review URL: https://codereview.chromium.org/964643003

Cr-Commit-Position: refs/heads/master@{#318582}

Revert of SK_DEBUG when DCHECK_ALWAYS_ON (patchset #1 id:1 of https://codereview.chromium.org/966593002/)

Reason for revert:
May have caused FontRenderParamsTest failures on Linux debug bots.

Original issue's description:
> SK_DEBUG when DCHECK_ALWAYS_ON
>
> BUG=
>
> Committed: https://crrev.com/879405ae813ae4a9bcbd7684d3551420d4980383
> Cr-Commit-Position: refs/heads/master@{#318557}

TBR=jam@chromium.org,mtklein@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/965113002

Cr-Commit-Position: refs/heads/master@{#318581}

Sorts sources blocks as part of gn format. This ended up being more
complicated than I expected because of the subtlety of header comments,
and because no other formatting reorders expressions at the moment.
But, there seems to be quite a lot of unsorted lists per below, so I
guess it's a good thing to have.

Application to tree at https://codereview.chromium.org/960413003.

R=brettw@chromium.org
BUG=348474, 456014

Review URL: https://codereview.chromium.org/962003002

Cr-Commit-Position: refs/heads/master@{#318580}

Summary of changes:
1. Fix a bug in identity.js that breaks first run scenario of the v2 app,
   Previously, we are resetting the deferred object (the list of listeners)
   when auth is failed even when interactive is set to false, which always
   happened on first runs.  At a result, when auth is completed, the listeners
   are not notified.
   This CL only clears the deferred object after it has notified its listeners.
2. Fix a missing parameter in session_connector_impl.js that causes It2Me to fail
   to connect.
3. Changes it2me_browser_test.js to match the changes in the identity API.

BUG=462708
TEST=Browser test passes on swarming bots.
https://chromium-swarm.appspot.com/user/task/25e6711d0deacc10
NOTRY=true

Review URL: https://codereview.chromium.org/968463003

Cr-Commit-Position: refs/heads/master@{#318579}