- 05 Nov, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1776a0ea..d3f9d9a2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id39f9d10783280bf091e69369d3a5ba90af7fb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898176Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712422}
-
Megan Jablonski authored
Bug: 1012746 Change-Id: I86a77ff45517796cfd12bff2eef7590b6fd04aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888119Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#712421}
-
Min Qin authored
Bug: 1013759 Change-Id: I089b87ee804dfc7151f332f0d967eccaf3573dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891472 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712420}
-
Glen Robertson authored
Also fixes bug where web app would not be considered installed if replacement_web_app_url did not match start_url specified in the web app's manifest. https://docs.google.com/document/d/18ILBOp7lPP9faAC7mF9hwBC40egzrnGS8GUSkAdG3Lk/edit Bug: 1007860 Change-Id: I6e70d5ae4dda797b4760dad4b4876ff205873dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847609 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#712419}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6bfec1fd1dc3..8a0420a05d13 Created with: gclient setdep -r src-internal@8a0420a05d13 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:984162,chromium:1004848 Change-Id: I3b0216deeeded8d4e2824cf44d477fe15b73b1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898751Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712418}
-
Miguel Casas authored
Some test-only files under media/gpu/test use LOG_ASSERT(), which causes the test binary to crash and leave an unsymbolized callstack when run on the CrOs Tast infra. This CL changes some of those refs to GTest's ASSERT_TRUE(), that is equivalent to EXPECT_TRUE()+return (not all LOG_ASSERT()s are that easy to replace since they are inside functions returning something). Replacing video_decoder_client.cc should fix the VP9.2 not being initialized (since it's disabled temporarily)- the test is expected to fail but not to crash. Bug: 1020776 Change-Id: Iddd6ed9080db4abe62f93730c84e77bfcbc9305f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897358Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#712417}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=ksakamoto@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I5386adf1e71f5cd42566fdb64a6cdf5ba183849f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893537 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#712416}
-
Aaron Colwell authored
Temporary fix that creates an exception for 'no access' URLs like chrome-native://history. These URLs can cause a origin mismatch in the commit code because of slight differences between how url::Origin and blink::SecurityOrigin handle 'no access' URLs. This is intended as a low risk change that can be easily merged to the M79 branch. Bug: 1016711 Change-Id: I20734fe68b6919c06849a1ce1439624d6332898c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896863 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#712415}
-
Hiroki Sato authored
crrev/c/1875853 wired Android's ImportantForAccessibility to chrome's ignored state. This made all WebView nodes ignored as they don't have importance. This CL fixes it by checking whether it's a native web node and it's focusable. Bug: b:143435799 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Change-Id: I01b52b2542d771749c50f44be361572bb30916da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890407 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#712414}
-
Takashi Sakamoto authored
This reverts commit c5f7284b. Reason for revert: suspect causing base_unittests failure on linux-chromeos-google-rel and chromeos-betty-google-rel: - StackTraceTest.OutputToStream Sample build: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/8635 Sample log: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8897671078839178960/+/steps/base_unittests/0/logs/Deterministic_failure:_StackTraceTest.OutputToStream__status_FAILURE_/0 Original change's description: > [base] Cleanup StackTraceTest.OutputToStream #ifdef soup. > > Change-Id: I7e43ea82867177c1aeab089f8f1e35abb802d1a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780074 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712377} TBR=ajwong@chromium.org,wez@chromium.org Change-Id: I082cc38b748df06ce86324b13d2cd45dbdf1c7a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898888Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#712413}
-
Erik Chen authored
There's no need for android kitkat to run lint or errorprone java compiler. These are already run by android_compile_dbg. See discussion at https://bugs.chromium.org/p/chromium/issues/detail?id=1020714#c2. Change-Id: Ibf82c9d46044855b3c25242e30200ae95906d578 Bug: 1020704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896053Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712412}
-
Leon Han authored
As we have NDEFRecord#data now with which users can do whatever they want, so we just remove these helper getters for simplication. The spec change: https://github.com/w3c/web-nfc/pull/384 BUG=520391 Change-Id: I054b521b474433e81b4e8fd93dad0772698ac8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897480Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#712411}
-
Leon Han authored
Makes it use the util function GetBytesOfBufferSource() to retrieve bytes from a BufferSource object. BUG=520391 Change-Id: I31684c36a7a98dc08520f48fcbc4a3618d8b92f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896899 Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by:
-
Leon Han authored
Before, we have both 'opaque' and 'json' NDEFRecord for reading/writing TNF_MIME_MEDIA records, and we just serialize the JSON object provided by users to get the payload bytes for the 'json' NDEFRecord. Now with the goal of making web nfc more of a low level API, this CL unifies them as a new 'mime' type that serves for reading/writing TNF_MIME_MEDIA records. TNF_MIME_MEDIA <---> 'mime' type NDEFRecord The spec change: https://github.com/w3c/web-nfc/pull/373 BUG=520391 Change-Id: If4052c70e48100185e72cb07da8363f5de92b4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896154Reviewed-by:
-
Jinsuk Kim authored
WebContentsObserver.didFinishNavigation that PreviewTab is listening to can come before its views are ready. This CL stops updating caption in such case to prevent NPE reported in the bug. Bug: 1020888 Change-Id: I9240e32015e0df631c3b80546c99d8e9e0a97c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898152Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#712408}
-
Lei Zhang authored
Bug: 925165 Change-Id: Ibf858e7112066876c996fada5b7518ad88c81562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895881Reviewed-by:
Luum Habtemariam <luum@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#712407}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=sdefresne@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: Iccc6ccf09b2e15f52c75ddba0ec63ff3e927efa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894884 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#712406}
-
Taylor Bergquist authored
Also updates the tooltip with the same information. Bug: 999557 Change-Id: Iee27b98e70385e23f7d517622c024d2315a8d491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889945 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#712405}
-
dpapad authored
This is in preparation of turning on web_dev related PRESUBMIT checks for components/. Bug: 1019312 Change-Id: I3226df6b609bc0e16b72d041234084a5615219fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895896 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712404}
-
Jun Mukai authored
I just happened to notice that these two properties don't follow the naming convention. Right now no one is actually using them (though some Tast tests are going to use them), so changing their names should be safe right now. Bug: 1021353 Test: build passes Change-Id: I3f578f1a891fdaa68110b4656006dffe1baaed0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894246 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#712403}
-
Henry Jian authored
Previously, I forgot to apply masking to adaptive icon in the notification bar, making the icon in notification bar inconsistent with other icons. This CL fixes the bug. Bug: 977173 Change-Id: If42d7f59c3d126dd23f53d4547112455add9fca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898634 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712402}
-
Long Cheng authored
Bug: 1013732 Bug: b/34248841 Change-Id: Ia6cf9a39efc6880d3458b8e33af2ef4225f0290f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887748 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#712401}
-
Antonio Gomes authored
The public API is not needed any more now that the WebRTC/Peerconnection implementation resides solely in Blink. Hence, this CL uses RtcAnswerOptionsPlatform directly. Similar to https://crrev.com/c/1884931 . BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I24915fd592e3ebd551717cd5dd8a4faccb525596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890794Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#712400}
-
gogerald authored
Bug: 1020663 Change-Id: Ica6eff7c7bf1e04636b24068a0b966f3cd50dd24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894467 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#712399}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cc836871cb18..4a4f34b76f3a git log cc836871cb18..4a4f34b76f3a --date=short --no-merges --format='%ad %ae %s' 2019-11-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-04 brianosman@google.com Fully embrace skcms types in SkColorSpace API Created with: gclient setdep -r src/third_party/skia@4a4f34b76f3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I44ac76ba7234893811b31d155a6a6a98702eb4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896389Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712398}
-
Xiaohan Wang authored
Instead of creating the Renderer in PipelineController before pipeline start which includes Demuxer initialization, this CL moves Renderer creation to PipelineImpl as a step in PipelineImpl::Start() so that the Renderer is only created after the Demuxer has been initialized. This makes it possible to have more flexible Renderer creation, e.g. create different Renderers based on different stream or CDM. Bug: 1018372, 827990 Test: No functionality change. Change-Id: I7398d90915df7905bd627f4e4cf82fae40252ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895747Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712397}
-
Fabrice de Gans-Riberi authored
Bug: 1016036 Change-Id: I9c2125d7b2fe11c08f7fa7024155ae25f4a0360e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898713Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#712396}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=kmarshall@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I9d65b702148140bab94514de52e0a551f4cb9d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895647 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#712395}
-
Sophie Chang authored
Bug: 969558 Change-Id: I6320efadce91869b6fe13bee8022e581102f0b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896038Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712394}
-
Matt Mueller authored
Change-Id: Ic7c38924c3c1fc441566aa85dd6c99cc75243810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898100Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#712393}
-
https://crrev.com/c/1782247Fergal Daly authored
TBR=yuzus@chromium.org Bug: 1020884 Change-Id: I291230bded9a9d915935f362d60d85589ef722dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898160Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#712392}
-
Klaus Weidner authored
While investigating a flaky test, one of the issues found was that a session 'end' event is triggered directly after issuing the session.end() call, without waiting for device-side session teardown to proceed. As a result, requesting a new session could fail due to the device side thinking there's already an active immersive session. According to https://immersive-web.github.io/webxr/#ended and discussions with Brandon, expected behavior is that the 'end' event and end().then promise resolution should be delayed if needed to ensure that a new session can be started at that time. This CL adds a "ended but not yet shut down" state to XRSession, and adds a new ShutdownSession call to isolated_xr_service's XRRuntime, to enable the expected delay. In case of mojo communication errors, the shutdown happens immediately. Also update WebXrTestFramework's enterSessionWithUserGesture to detect and retry clicks that aren't delivered after session end transitions, and remove sleeps that were previously added to work around flakiness in WebXR VR consent tests. It appears that this flakiness was at least in part caused by prematurely starting a new session while the previous session wasn't fully shut down yet. The test change is included in the same CL since the new shutdown logic by itself left some tests flaky due to clicks not being delivered consistently from the test framework. Change-Id: I6d48b259677c92bac323db0e10803a48718d4a33 Bug: 1014159, 998307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874824 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#712391}
-
Peter Boström authored
Removes ::OnBoundsChanged overrides in AppMenuButton by making ToolbarButton::OnBoundsChanged safe to call even in the WebAppMenuButton. This is likely a prerequisite for hosting extensions in the PWA frame as the buttons are currently being sized too large to fit. Bug: chromium:1006162 Change-Id: I0aa444cd913957feb08f2e9a340269734b0cc76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866874 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#712390}
-
Eric Roman authored
Bug: 1021236 Change-Id: I18e1d63683419beb48f4bbc820946fc9162c9f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898616 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
-
Sarthak Shah authored
This CL enables ScreenWin to retrive and store Pixels Per Inch value for every connected touch monitor to the system. This value will be later utilized to configure animation curve for fling gesture. Bug: 647137 Change-Id: I4184060ff64e800e2d76111e035c7f7bf6eb53b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884752 Commit-Queue: Sarthak Shah <sarsha@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#712388}
-
Rahul Arakeri authored
Native scrollbars on Mac do not have scrollbar arrow buttons. The math for calculating the forward and back track rects assumes that arrow rects are non empty. This leads to the scrollbar hit test missing the track rects. Bug: 1016452 Change-Id: Ie1a25211cb79022286ddf4684cc8d33e04823747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873491 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712387}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/94d6f48ba1b7..f6a2232b48c2 git log 94d6f48ba1b7..f6a2232b48c2 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 ehmaldonado@chromium.org Revert "git-cl: Fix some python3 compatibility errors." 2019-11-04 ehmaldonado@chromium.org owners_finder: Fix flaky tests. Created with: gclient setdep -r src/third_party/depot_tools@f6a2232b48c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002209,chromium:1009814 Change-Id: Ifbfebdcca16dac3de97e016f1c47992d84d32b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898688Reviewed-by:
-
Sorin Jianu authored
* Removes //chrome/updater:updater_constants target * Fixes the dependencies to get a clean run for 'gn check out/default //chrome/updater/*' R=waffles CC=milagreen Bug: 1021336 Change-Id: I50febba965a5d1684ffef0c259dc9bd7e743d34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898776 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712385}
-
Chris Palmer authored
It (sometimes) measurably hurts run-time performance, but we don't have a strong case for its defensive value. The canary check in release mode hurts performance as it requires going completely out of line to compare against a global. Speedometer total Linux: 2.5% Win: 1.4% v8.browsing (metric: blink-gc-total which covers the whole phase) Linux CNN: 11% Linux FB: Noise blink_perf.bindings Linux: Noise Impact: We think the performance impact is noticeable. The canary is only present on 64bit. The canary is only present on Oilpan object and not off-heap objects that are referred to by scoped_refptr<> or regular malloced objects. The canary is not present in V8 which is the first line of attack. The canary is present on all Oilpan objects which means that it is spread across many pages. Any read gadget (e.g. high-performance Spectre gadget) is sufficient to find the value for the current renderer. Impact: The canary can guard against linear overwrites when there's no other info leak present. This mechanism is only enabled on 64-bit. Pointer compression of the Oilpan heap will make the memory overhead of the canary visible. Impact: Similar to not emitting the canary on 32-bit because of memory overhead, we should probably not emit the canary when moving into a future with pointer compression. Change-Id: I6ddb610d0e697fe9407667b72ce4efe4c3720431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879865 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712384}
-
Wez authored
FilteredServiceDirectory is used to create sandboxed directories with subsets of the services available to the caller. For use-cases like integration testing, it is useful to allow specific services to have fake test implementations added, for example, alongside the production services exposed via the directory. Change-Id: I2d751770eb04a138e45f2f019a69323a4cadd3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896535 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
