- 06 Jun, 2018 40 commits
-
-
Peter Boström authored
Instead of using a fully transparent ripple on Mac, this uses the same active-ripple effect as other platforms, but instantly animates to them. This effectively makes use of the active color in the ripple effect but without using the animation (flood-fill effect). This fixes a recent regression where MacViews + Refresh got ink-drop ripples on toolbar and bookmark buttons. It also effectively adds active-state color that was missing on Mac both for toolbar buttons and secondary UI MdTextButtons. Bug: chromium:848767 Change-Id: Ia28d26c128dff12d2181c4dea41a0d4418a9d47c Reviewed-on: https://chromium-review.googlesource.com/1087949Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#564946}
-
Jenny Zhang authored
Bug: 849594 Change-Id: Idcfd987a4e2d3357a81905b1f003ab1e81302298 Reviewed-on: https://chromium-review.googlesource.com/1087749Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#564945}
-
John Budorick authored
Also fix up some ordering issues in those configurations. Bug: 844014 Change-Id: I2a138cfdd1c48246eb96bdc830046f64270b4a2d Reviewed-on: https://chromium-review.googlesource.com/1082833Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#564944}
-
Alex Newcomer authored
Move the LAUNCH_APP_SHORTCUT_FIRST and LAUNCH_APP_SHORTCUT_LAST enums so they overlap properly with it's app list counterparts. The problem was that AppContextMenu::CommandId enums start at 100, and they are recorded using the same enums.xml entry as launcher would be mis-recorded in UMA as AppContextMenu::CommandId's. LauncherContextMenu: :MenuItem. This means that the app shortcuts in the Bug: 848491 Change-Id: I7b1e1d09eda3114842a349eab93a1c91d960ab4f Reviewed-on: https://chromium-review.googlesource.com/1082977 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#564943}
-
Christian Fremerey authored
This had been reverted because of a test failure on webrtc Win10 Tester for a test that uses a real webcam. Patchset 1 is the code as previously reviewed and reverted. Patchset 2 adds a fix for the test failure. Fix description: The test failure revealed a mistake in the new code. Instead of operating the Mojo connection to the jpeg decoder on the main task runner of the video capture service, it would operate it from the thread the delivers the video frames from the camera. On Windows, this thread is not a Chromium thread and as such does not allow base::ThreadTaskRunnerHandle::Get(). The fix is to pass the correct task runner to the factory code, see Patchset 2. Original CL description: * Move/rename class content::VideoCaptureGpuJpegDecoder to media::VideoCaptureJpegDecoderImpl and break dependencies to |content| in order to make it reusable for the video capture service. (I was unable to convince Gerrit that this is a move/rename. Sorry for this making it harder to review.) * Split Gpu memory buffer factory methods from interface ui.mojom.Gpu to new interface ui.mojom.GpuMemoryBufferFactory * Update class ui::ClientGpuMemoryBufferManager to depend on only the new interface ui.mojom.GpuMemoryBufferFactory. * Inject dependencies on ui.mojom.GpuMemoryBufferFactory and viz.mojom.GpuService from Browser into video capture service when starting up the service. * Enable the existing-but-disabled test cases for accelerated jpeg decoding in combination with video capture service Design Doc: https://docs.google.com/document/d/169LS3U0DD7hHpqZSli0gpCaCqE1eWN4QXFSIGoruPwQ/edit?usp=sharing Test: content_browsertests --gtest_filter=VideoCaptureBrowserTest.* Bug: 820608, 720604 Change-Id: I6c77ce570aa8f0c3a54a12e0d3f14648c58005ac TBR=avi@chromium.org,sadrul@chromium.org,jcliang@chromium.org,tsepez@chromium.org,sandersd@chromium.org,emircan@chromium.org,mojahsu@chromium.org,piman@chromium.org,chfremer@chromium.org Change-Id: Id3493742537fa8a016dad391ee12e2869febf080 Reviewed-on: https://chromium-review.googlesource.com/1087867 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#564942}
-
Amy Qiu authored
Move tough_pinch_zoom_cases into the rendering folder and refactor to inherit from RenderingStory Bug: 849392 Change-Id: I6496aacc50aa730843d677e73c89f3025b0799ba Reviewed-on: https://chromium-review.googlesource.com/1087726 Commit-Queue: Amy Qiu <amyqiu@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#564941}
-
Alex Newcomer authored
As per request from ux, anchor touch and mouse menus similarly. Previously touch menus were anchored based on the app icon, and mouse menus were anchored on the click point. Now we will anchor all menus on the app icon. Bug: 846939 Change-Id: I6d2aea28096701c0109081059be40dca5a9ce93c Reviewed-on: https://chromium-review.googlesource.com/1077308 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Alex Clarke authored
Our usage pattern is unfortunate for existing queues such as base::circular_deque. We tend to fill up an empty queue and then drain all those tasks until it's empty. This means the queue yo-yos in size which confuses the memory reclamation schemes of most queues. As an optimisation we introduce a deque specialised for TaskQueueManager's usage patterns. For performance (memory allocation isn't free) we don't automatically reclaim memory when the queue becomes empty. Instead we rely on the surrounding code periodically calling MaybeShrinkQueue, ideally when the queue is empty. We keep track of the maximum recent queue size and rate limit how often MaybeShrinkQueue actually shrinks the buffer to avoid unnecessary churn. This yields a nice win on our microbenchmark: Patch: us/run for 10000 delayed tasks with N queues 1 queue 4 queues 8 queues 32 queues 33448.166666666664 33215.75496688742 33484.34 34018.37414965987 33972.18243243243 33846.91891891892 34489.737931034484 34727.90277777778 33367.90666666667 33167.54304635762 33392.96 33906.89864864865 33392.13333333333 33107.17763157895 33340.18 33718.73825503356 37921.01515151515 39379.06299212598 38851.27906976744 39366.03125 38171.564885496184 37401.72388059701 37640.32330827068 37800.51127819549 34691.2275862069 34359.61643835616 34993.468531468534 35366.795774647886 35981.20863309353 35089.18881118881 38530.230769230766 39280.3515625 39262.8671875 36411.384057971016 33576.10067114094 33939.69594594595 37913.59848484849 38324.076335877864 38061.59848484849 39921.00793650794 Average 35812.1871 35430.24471 35636.02188 36204.63076 ToT: us/run for 10000 delayed tasks with N queues 1 queue 4 queues 8 queues 32 queues 40459.540322580644 40536.04838709677 38994.573643410855 38696.2 39422.149606299216 39299.5 37888.18939393939 37874.74436090225 38419.70229007633 38025.742424242424 37844.41353383459 38020.469696969696 35052.72027972028 38147.80303030303 35504.89361702128 34138.02721088436 37096.77777777778 34942.541666666664 37003.529411764706 37579.60447761194 38818.67441860465 38233.068702290075 37978.628787878784 37867.57142857143 38455.49618320611 37903.05303030303 38106.143939393936 38129.5 40609.33064516129 37721.75187969925 34656.441379310345 34294.33561643836 35273.704225352114 34646.324137931035 34335.643835616436 34311.82876712329 35821.41428571429 35362.035211267605 37522.27611940299 35429.281690140844 Average 37942.951 37481.78685 36983.47337 36634.15632 Percentage improvement 5.61570422 5.473437399 3.643388159 1.172472933 NB the reason the improvement goes down with the number of queues is because we're saving malloc overhead in the queue, but a constant number of tasks are posted across N queues. This means the more queues we have in this test, the less loaded the queues are individually. Change-Id: I75be9c1f266700ac76003ae0191ce0a59539298a Reviewed-on: https://chromium-review.googlesource.com/1080792 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#564939}
-
Tetsui Ohkubo authored
ShelfViewTest's way of triggering overflow button in Shelf sometimes didn't work depending on the width of the StatusArea. It led to test failures with a launching flag which changes Shelf width. Failing tests (with --enable-features=SystemTrayUnified): OverflowButtonActiveInkDropTest.TouchDragOut OverflowButtonActiveInkDropTest.TouchDragOutAndBack OverflowButtonInkDropTest.TouchDragOut OverflowButtonInkDropTest.TouchDragOutAndBack TEST=ash_unittests --enable-features=SystemTrayUnified BUG=847104 Change-Id: I00f64255936ca32daba375832c0b39ccc3e27014 Reviewed-on: https://chromium-review.googlesource.com/1088532 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Ken Rockot authored
This enables browser-initiated requests to be proxied through the WebRequest API when the Network Service is enabled. Note that this only applies to requests made on via a profile's context, not the system context. This mirrors the behavior in the non-Network Service path today. Bug: 841002 Test: see buildbot filter changes Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1830959e1ba089974c546d933b4a6b51fb038779 Reviewed-on: https://chromium-review.googlesource.com/1083952 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#564937}
-
Xing Liu authored
Currently ModalDialogView uses dialog_max_width(600dp) as maximum width. The download location dialog's custom view only wraps a much smaller area, so it looks bad in landscape view. This CL makes width limitation to use type value, which can be dp or fraction of the screen. Bug: 847575 Change-Id: I946423bdda2eb052cb02f72d5ed36447e58bcc6d Reviewed-on: https://chromium-review.googlesource.com/1082930Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#564936}
-
Chris Mumford authored
CreateFilePath was removed in master@{#306402} and FilePathToString is not used in leveldatabase. Bug: none Change-Id: I901d1a67d8d4607ad970ae39ff9898af41fc2ad7 Reviewed-on: https://chromium-review.googlesource.com/1087350Reviewed-by:Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#564935}
-
Jeremy Roman authored
These should not be incredibly hot, and this just moves some of the conversion code out-of-line (but it would still be eligible for LTO inlining on those platforms where we do that, subject to compiler optimization decisions). This saves 24 kB of Android APK size (per the android-binary-size trybot). Old Metadata: apk_size=70144543 New Metadata: apk_size=70119969 Section Sizes (Total=-24.0kb (-24574 bytes)): .other: -4.62kb (-4734 bytes) (19.3%) .text: -19.1kb (-19576 bytes) (79.7%) Change-Id: I7461c81353e3a26fd9bfbfcd99cdc40a078b883f Reviewed-on: https://chromium-review.googlesource.com/1087817Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#564934}
-
Josh Karlin authored
What: If two tasks have the same priority, they should run in posting order. A second thing this CL does is fix a race in the unittests. I meant to block the task runner before queueing up requests but failed to. Fixed here. Why: This can prevent hypothetical task starvation. It's also necessary for the SimpleCachePrioritization control group to ensure that we maintain old behavior. Bug: 850085 Change-Id: I1f259296604bf04ea33ecbee9ad3180f064c4266 Reviewed-on: https://chromium-review.googlesource.com/1088759 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#564933}
-
Xida Chen authored
This CL adds a new layout test to make sure that the following APIs: lineWidth lineDash lineDashOffset works properly with browser zoom. Bug: 849706 Change-Id: I07c07e688203c26b2b2223377da88591a44a4e55 Reviewed-on: https://chromium-review.googlesource.com/1088870Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#564932}
-
Nico Weber authored
Run headless_browsertests, headless_unittests on the the clang tot bots, and on some memory bots. Both suites are very leaky, so they don't run on asan bots, and headless_browsertests is also very racy so it doesn't run under tsan, but headless_unittests runs under tsan. Both run under msan and cfi. They also run under asan/mac, which seems to be happy. This is part of an effort to reduce the number of test configurations. Originally reviewed as part of https://chromium-review.googlesource.com/1061795, which I'm now landing in smaller pieces. TBR=kbr Bug: 843511,843732,843734 Change-Id: I3ba57446830d44f3651100e216f1d546ee7532b6 Reviewed-on: https://chromium-review.googlesource.com/1088754 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#564931}
-
Nico Weber authored
mojo_core_unittests was added to the main waterfall in https://chromium-review.googlesource.com/c/chromium/src/+/978368/11, but not to the main and clang tot waterfalls. Things that run on the main waterfall should run on the memory bots (needed to check correctness), and they must run on the clang tot waterfall to make sure new compilers don't break them. Bug: 843511,822034 Change-Id: I4431298f53d967e4aa3d7fa3b98c3d4a27ffb9bb Reviewed-on: https://chromium-review.googlesource.com/1088761 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#564930}
-
Katie D authored
Bug: 849893 Change-Id: Iaf8c30493e383e754940afbb928994c9ffcd12fd Reviewed-on: https://chromium-review.googlesource.com/1087325 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#564929}
-
Evan Stade authored
Only support native notifications, i.e. those passed over mojo. Some tests are permanently removed on Chrome OS. Some tests are migrated to message_center_unittests. Bug: 578868 Change-Id: Ibd4edcd1968c94af2d24b15ed3c1329ea7bf49b1 Reviewed-on: https://chromium-review.googlesource.com/1083937Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#564928}
-
Alexis Hetu authored
Now that synchronization issues have been fixed on MacOS, most previously disabled layout tests can be re-enabled. TBR=kbr@chromium.org Bug:chromium:726075 chromium:646528 chromium:845267 chromium:614910 chromium:845266 chromium:791941 chromium:847094 chromium:849256 Change-Id: Ifa59c2594c429a94643ea9f19b2e08e974cc6c53 Reviewed-on: https://chromium-review.googlesource.com/1088197Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#564927}
-
Justin Cohen authored
Undefined keychain types are now defined in the iOS12 SDK, and annotated as unavailable on iOS. Remove the types that aren't used by mac or ios, and redefine the ones used by mac so it can be typedef-ed away on ios. Bug: 843234 Change-Id: If94222cde31a89185ce2f9bd6d77af8ac7c41fd7 Reviewed-on: https://chromium-review.googlesource.com/1087927 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564926}
-
Ted Choc authored
In my local testing, the translate infobar was showing up on the webpage because it uses latin placeholder text. This reworks the infobar check to not check for an exact count, but to look for infobars of a particular type. BUG=771103 Change-Id: Ia6544c386e9e8288f7980a2c14e0b0fba0b14e98 Reviewed-on: https://chromium-review.googlesource.com/1087684Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#564925}
-
Tetsui Ohkubo authored
This CL fixes ShowSystemTrayOnPrimaryLoginScreen when UnifiedSystemTray is enabled. A system tray should not SetVisible(true) before UpdateAfterLoginStatusChange is called. TEST=LoginScreenControllerNoSessionTest.ShowSystemTrayOnPrimaryLoginScreen (--enable-features=SystemTrayUnified) BUG=847104 Change-Id: I2ca02dd55def1385e769f00604cd42281413d8b7 Reviewed-on: https://chromium-review.googlesource.com/1088266 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
In the unit test, focusing in status area widget was tested using NotificationTray button and SystemTray button. As they are consolidated in UnifiedSystemTray, the test did not work with the flag enabled. This CL fixes the test to use IME tray button so it keeps working with UnifiedSystemTray. TEST=StatusAreaWidgetFocusTest.FocusOutObserver (--enable-features=SystemTrayUnified) BUG=847104 Change-Id: I8d8d3f274153daeb66ebc594d23b7ce4787a2cac Reviewed-on: https://chromium-review.googlesource.com/1088331Reviewed-by:
-
Keishi Hattori authored
Bug: 849627 Change-Id: I03070180380f739f079ca8e04011a94696ea7a08 Reviewed-on: https://chromium-review.googlesource.com/1088271 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#564922}
-
Peter Kvitek authored
Page.setFontFamilies method overrides default settings for generic font families. Change-Id: I17645126b1d9fd19b07322c521322ed47e9b73d8 Reviewed-on: https://chromium-review.googlesource.com/1086212 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#564921}
-
Maks Orlovich authored
Those were important when how packing streams 0 and 1 together was going to work was being designed, but that's long been done now. Bug: 849518 Change-Id: I41b21bc0b7235725f1650490e64f4cd243ee59ab Reviewed-on: https://chromium-review.googlesource.com/1087581Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#564920}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/74ed554..8ae3209 git log 74ed554..8ae3209 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 tsepez@chromium.org Better error reporting on XFA JS errors Created with: gclient setdep -r src/third_party/pdfium@8ae3209 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I540ea25f51b519916f68e7054dbd6e47f45bdf3f Reviewed-on: https://chromium-review.googlesource.com/1088210Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564919}
-
Joe Downing authored
This CL contains a base class and unittests for generating a keyboard layout map for the KeyboardMap API. It also includes a a Windows implementation which uses the base class. BUG=832811 Change-Id: I7ff20cf8b2a34cf8c7a9bbe9609e40f39bb89634 Reviewed-on: https://chromium-review.googlesource.com/1077596 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#564918}
-
Koji Ishii authored
This patch fixes InsertRunForTesting inserts glyph data in the incorrect order for RTL. Fixing it discovers errors in Next/PreviousSafeToBreakOffset(), and that they are fixed as well. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Idc0d7e6f0e653542a4aa93e1ee53d257848f3342 Reviewed-on: https://chromium-review.googlesource.com/1088718 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#564917}
-
Amy Qiu authored
Due to https://chromium-review.googlesource.com/c/chromium/src/+/1084057, rendering_shared_state needs to be updated to directly call GetSystemInfo(), the way webgl_supported_shared_state does. Bug: 849392 Change-Id: I9c974fb42a52522c203dd4dcdbdb49cc1d95bd5b Reviewed-on: https://chromium-review.googlesource.com/1088209Reviewed-by:
-
David Tseng authored
Bug: 849726 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie758887410ce95bd4650e46c31a3d81c9b450930 Reviewed-on: https://chromium-review.googlesource.com/1087499Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#564915}
-
Adithya Srinivasan authored
This reverts commit 75d3f6c9. Reason for revert: Causes crashes: https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27blink%3A%3ADocument%3A%3ASetFocusedElement%27+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27renderer%27+AND+product.Version%3D%2769.0.3451.0%27 Original change's description: > Crash when SetFocusedElement is called during layout > > I think the crash in https://crbug.com/848212 is caused due to > Document::focused_element_ being cleared out during the > UpdateStyleAndLayoutIgnorePendingStylesheetsForNode call in > Document::SetFocusedElement, but I'm unable to reproduce a situtation > where this happens. This CL adds a CHECK that crashes when > SetFocusedElement is called during UpdateStyleAndLayout, just so I can > get some stack traces in the wild and confirm this theory. > > Bug: 848212 > Change-Id: Ia9293ea155e4ae976592166e7ab4f936f25f3f38 > Reviewed-on: https://chromium-review.googlesource.com/1085607 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564337} TBR=tkent@chromium.org,adithyas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 848212 Change-Id: Ie0ee4b7e3fa8e6dd94a8f8a04e6866743f38440d Reviewed-on: https://chromium-review.googlesource.com/1088950Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#564914}
-
Lukasz Anforowicz authored
Before this CL, the name of the method was ambiguous (i.e. what exactly is meant by "connection") and incorrect (some aspects of connectivity like queueing of IPCs are set up in the constructor of RenderProcessHostImpl, before |is_initialize_| is true and before HasConnection / IsInitializedAndNotDead returns true). After this CL, the name of the method will much closer match the implementation: bool RenderProcessHostImpl::IsInitializedAndNotDead() const { return is_initialized_ && !is_dead_; } Bug: 840409 Change-Id: Id1d7752f7b55a4d139aeba4d56d25c68b804ff8d Tbr: reillyg@chromium.org Tbr: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1083348 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#564913}
-
Chris Hamilton authored
BUG=749785 Change-Id: Ie89ec2c4869851e5734fde94656052e933faac96 Reviewed-on: https://chromium-review.googlesource.com/1088970Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#564912}
-
Anthony Vallee-Dubois authored
Bug: 848859 Change-Id: Ic242ff51351de2de5db6fd80e7f3d045b995eb04 Reviewed-on: https://chromium-review.googlesource.com/1082819 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#564911}
-
Nico Weber authored
- Don't run gin_unittests on the cros asan bot instead of suppressing all test results in the lsan_suppressions file to be consistent with how we suppress the test on the linux asan bot - Do run gin_unittests on ToTLinux and ToTLinuxMSan since the test runs fine on the main waterfall linux and msan bots. Bug: 843511,831667,831667 Change-Id: I224916e5fcf3d41654c2b042524cb896b9702db1 Reviewed-on: https://chromium-review.googlesource.com/1088756Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#564910}
-
Tetsui Ohkubo authored
Browser test requires all focusable views to have appropriate a11y texts. For EnterpriseManagedView, we manually override tooltip text, but it was not properly configured as a11y data. We can fix this by just using Button's SetTooltipText. TEST=SystemTrayClientEnterpriseTest.TrayEnterprise (--enable-features=SystemTrayUnified) BUG=847104 Change-Id: I8eb0e051446e4fcff4be691bf42e7af9fe99b8dd Reviewed-on: https://chromium-review.googlesource.com/1088328Reviewed-by:
-
Justin Cohen authored
Limit to 10.13.4 or 10.13.5. NOTRY=true Bug: 843236 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4319717afc3ad7d8fa64e2276c3b877d5f7b6837 Reviewed-on: https://chromium-review.googlesource.com/1089037 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#564908}
-
Tetsui Ohkubo authored
This CL adds right/left shelf alignment support for UnifiedSystemTray. TEST=PanelLayoutManagerTest.TouchHitTestPanel (--enable-features=SystemTrayUnified) BUG=847104 Change-Id: I69d2755dd18d40508c3183ae08a75eef732dcce8 Reviewed-on: https://chromium-review.googlesource.com/1086900Reviewed-by:
-
