GitLab

This test has been flaky for a couple of weeks now. Disabling on
Windows platform until that can be corrected.

TBR=qiangchen@chromium.org
BUG=644614

Review-Url: https://codereview.chromium.org/2346253003
Cr-Commit-Position: refs/heads/master@{#419472}

Many developers have added utility functions to check if the many Mojo
instances are ready and with the correct version, which seems redundant.
This change adds a function to do that (and log failures).

BUG=647853
TEST=cheets_SettingsBridge

Review-Url: https://codereview.chromium.org/2347293002
Cr-Commit-Position: refs/heads/master@{#419471}

https://chromium.googlesource.com/skia.git/+log/950fc6c6360d..122fac306189

$ git log 950fc6c63..122fac306 --date=short --no-merges --format='%ad %ae %s'
2016-09-19 mtklein GN: remove old Android recipe code.
2016-09-19 reed add 'g' to fatbits
2016-09-19 mtklein Delete unused coverage recipe code.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=borenet@google.com

Review-Url: https://codereview.chromium.org/2348343002
Cr-Commit-Position: refs/heads/master@{#419470}

TBR=falken@chromium.org
BUG=648247

Review-Url: https://codereview.chromium.org/2353513002
Cr-Commit-Position: refs/heads/master@{#419469}

When setting tFoot or using createTFoot the new
element should be inserted at the end.

This patch also changes behavior so we throw a
HierarchyRequestError [1] when setting tFoot with
a new element not of type tfoot.

Behavior matches Safari, Firefox and Edge.

[1] https://html.spec.whatwg.org/#dom-table-tfoot

BUG=641338

Review-Url: https://codereview.chromium.org/2338013007
Cr-Commit-Position: refs/heads/master@{#419468}

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2331053003
Cr-Commit-Position: refs/heads/master@{#419467}

https://pdfium.googlesource.com/pdfium.git/+log/a0ff010a380c..ea3c3be83dae

$ git log a0ff010a3..ea3c3be83 --date=short --no-merges --format='%ad %ae %s'
2016-09-19 npm Remove duplicated charset definitions, and move them to fx_font.h
2016-09-19 stackexploit Fix compare between signed and unsigned values in CPDF_ImageRenderer::StartDIBSource.

BUG=645036

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2349213002
Cr-Commit-Position: refs/heads/master@{#419466}

Setting the title frame to be 14px high clips descenders from the text.
If TabController leaves the title frame at its default size, the text
draws properly and is vertically centered in the tab.

BUG=645755

Review-Url: https://codereview.chromium.org/2346513006
Cr-Commit-Position: refs/heads/master@{#419465}

Delete obsolete references to spellcheck files and a switch.

The files listed in chrome/common/owners have been moved to
components/spellcheck/common and are covered by an owners
file there.

The spellcheck switch in ChromeSwitches.java is not used
anywhere (in fact the flag has been removed in
crrev.com/2284583002).

BUG=629609

Review-Url: https://codereview.chromium.org/2341653004
Cr-Commit-Position: refs/heads/master@{#419464}

Revert of Add tests for trace wrappers (patchset #15 id:280001 of https://codereview.chromium.org/2301213003/ )

Reason for revert:
Sorry for the revert; this patch has (I believe) caused the heap-snapshot-with-detached-dom-tree.html to start failing.

The very first failure in that test was in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/17518 -- immediately after this CL was committed.

Here is the flakiness dashboard result for that test:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fheap-profiler%2Fheap-snapshot-with-detached-dom-tree.html&testType=webkit_tests

The test is failing occasionally with output like this:

    Test that all nodes from the detached DOM tree will get into one group in the heap snapshot. Bug 107819.

     Took heap snapshot
    Parsed snapshot
    SUCCESS: found (Detached DOM trees)
    SUCCESS: found Detached DOM tree / 3 entries
    FAIL: unexpected DIV count: 1

Reverting this CL since it appears to be primarily about the tests.

Original issue's description:
> Add tests for trace wrappers
>
> This cl adds very basic tests for general trace wrappers features. And enables TraceWrappables runtime enabled feature for tests!
>
> LOG=no
> BUG=468240
>
> Committed: https://crrev.com/f7d5d042289c5fbe918348830917b888ec587272
> Cr-Commit-Position: refs/heads/master@{#419298}

TBR=haraken@chromium.org,mlippautz@chromium.org,hlopko@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=468240

Review-Url: https://codereview.chromium.org/2350733002
Cr-Commit-Position: refs/heads/master@{#419463}

Removed annotation from:
* ContentViewStatics
* WebContentsObserverProxy

and stopped hooking up their JNI methods for renderer process.

Moved FileDescriptorInfo.java from browser/ to common/ since
it is actually required in the renderer.

BUG=643489

Review-Url: https://codereview.chromium.org/2316183002
Cr-Commit-Position: refs/heads/master@{#419462}

This patch enables CSS hyphens property on stable.

Following values are valid at this point:
  Android/Mac: manual | none | auto
  Other platforms: manual | none

BUG=605840

Review-Url: https://codereview.chromium.org/2342553003
Cr-Commit-Position: refs/heads/master@{#419461}

This unbreaks the V8 Chromium trybot
v8_linux_chromium_gn_rel, broken by missing target mappings
in https://codereview.chromium.org/2352473002

BUG=555273,648153

Review-Url: https://codereview.chromium.org/2350703002
Cr-Commit-Position: refs/heads/master@{#419460}

BUG=fdoray isn't an OWNER of startup_metric_utils :-O

Review-Url: https://codereview.chromium.org/2352693002
Cr-Commit-Position: refs/heads/master@{#419459}

Notable changes:
* ios/web/webui/crw_web_ui_page_builder.mm has a block that had a
   __block reference to itself. Before ARC __block means "do not retain
   when being captured in a block", but with ARC it is captured. So I
   added an additional variable of __weak __block type instead.

* One WeakNSObject in mojo_facade.h could not be removed because it is
  included from non-ARC code. WeakNSObject is functional in ARC but is
  not preferred. Filed crbug.com/639326 to track future removal of
  this.

BUG=639327
TEST=None

Review-Url: https://codereview.chromium.org/2340343002
Cr-Commit-Position: refs/heads/master@{#419458}

BUG=560525

Committed: https://crrev.com/3558706c1b2a630557929b61fefc74e28975f3a6
Review-Url: https://codereview.chromium.org/2322413003
Cr-Original-Commit-Position: refs/heads/master@{#419369}
Cr-Commit-Position: refs/heads/master@{#419457}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/7de487d..314e336

$ git log 7de487d..314e336 --date=short --no-merges --format=%ad %ae %s
2016-09-19 hbos@webrtc.org RTCTestStats moved into webrtc/stats/test (rtc_stats_test_utils)
2016-09-19 sakal@webrtc.org Enable auto-focus on Camera2.
2016-09-19 danilchap@webrtc.org Deprecate RtpSender::SendPadData with provided timestamps.
2016-09-19 sakal@webrtc.org Events refactor in Android session based capturing.
2016-09-19 sakal@webrtc.org Enable stabilization on Camera2.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2352673002
Cr-Commit-Position: refs/heads/master@{#419456}

https://chromium.googlesource.com/skia.git/+log/bbfe92bc1dd2..950fc6c6360d

$ git log bbfe92bc1..950fc6c63 --date=short --no-merges --format='%ad %ae %s'
2016-09-19 brianosman Add F16 to the list of allowed formats in GaussianBlur
2016-09-19 fmalita [SVGDom] Only apply opacity when needed
2016-09-19 cblume Remove release asserts.

BUG=643845

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=borenet@google.com

Review-Url: https://codereview.chromium.org/2351713002
Cr-Commit-Position: refs/heads/master@{#419455}

BUG=633136

Review-Url: https://codereview.chromium.org/2197113002
Cr-Commit-Position: refs/heads/master@{#419454}

Revert of [sensors] Ambient light sensor bindings implementation (patchset #5 id:80001 of https://codereview.chromium.org/2332323002/ )

Reason for revert:
Sorry for the revert -- two new tests are failing immediately on several Blink bots:
sensor/mock-sensor.html
sensor/ambient-light-sensor.html

See
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=sensor%2Fambient-light-sensor.html%2C%20sensor%2Fmock-sensor.html

First failed build on MacOS 10.10:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/23859

Original issue's description:
> [sensors] Ambient light sensor bindings implementation
>
> This patch implements AmbientLightSensor [1] blink bindings and adds
> LayoutTest helpers for testing sensors that are based on Generic Sensor API.
>
> Following layout tests added to test new functionality:
> IDL tests.
>  - third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensor.html
>  - third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensorReading.html
> AmbientLightSensor tests.
>  - third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
>
> Intent to Implement:
> https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TkfdVqYAYiE/xLGN2b1-AAAJ
>
> [1] ED specification for Ambient Light Sensor http://w3c.github.io/ambient-light/
>
> BUG=606766
>
> Committed: https://crrev.com/c457d06894e8f01b24ae83750203fb5d8819c560
> Cr-Commit-Position: refs/heads/master@{#419438}

TBR=jochen@chromium.org,haraken@chromium.org,mikhail.pozdnyakov@intel.com,rijubrata.bhaumik@intel.com,timvolodine@chromium.org,alexander.shalamov@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=606766

Review-Url: https://codereview.chromium.org/2348333002
Cr-Commit-Position: refs/heads/master@{#419453}

https://pdfium.googlesource.com/pdfium.git/+log/e9988dd65e74..a0ff010a380c

$ git log e9988dd65..a0ff010a3 --date=short --no-merges --format='%ad %ae %s'
2016-09-19 stackexploit Avoid nullptr access in sycc422_to_rgb and sycc420_to_rgb

BUG=648127

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2351703002
Cr-Commit-Position: refs/heads/master@{#419452}

and also in ::FetchSnippets

BUG=647920,648201

Review-Url: https://codereview.chromium.org/2349203002
Cr-Commit-Position: refs/heads/master@{#419451}

The component browsing_data_ui contains code used by the Clear Browsing
Data dialog on all platforms. It was created because there was no other
component fitting that purpose.

However, the browsing_data component has been recently made into a layered
component (https://codereview.chromium.org/2127403002), providing various
browsing data related functionality for all platforms.

Since the two components have basically the same purpose and confusingly
similar names, we merge them into one.

TBR=dbeam@chromium.org
BUG=635873

Review-Url: https://codereview.chromium.org/2238453002
Cr-Commit-Position: refs/heads/master@{#419450}

This change includes the animation and easing (intermediate state
calculation) capabilities developed by mthiesse@, and adds initial unit
tests for animation.

BUG=

Review-Url: https://codereview.chromium.org/2335643002
Cr-Commit-Position: refs/heads/master@{#419449}

https://chromium.googlesource.com/skia.git/+log/e7a7812744c2..bbfe92bc1dd2

$ git log e7a781274..bbfe92bc1 --date=short --no-merges --format='%ad %ae %s'
2016-09-19 caryclark fix fuzzer bugs

BUG=647834,648068

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=borenet@google.com

Review-Url: https://codereview.chromium.org/2343413002
Cr-Commit-Position: refs/heads/master@{#419448}

BUG=555865

Review-Url: https://codereview.chromium.org/2348963002
Cr-Commit-Position: refs/heads/master@{#419447}

One caller on platform_skia was calling it (incidentally), but they can call accessPixels() instead for the same result.

BUG=647756

Review-Url: https://codereview.chromium.org/2340813006
Cr-Commit-Position: refs/heads/master@{#419446}

Should fix build breakage (https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/45952/steps/compile/logs/stdio) caused by modifying the Accessibility model in https://codereview.chromium.org/2322413003/

BUG=

Review-Url: https://codereview.chromium.org/2351693002
Cr-Commit-Position: refs/heads/master@{#419445}

BUG=648222
TBR=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2351683002
Cr-Commit-Position: refs/heads/master@{#419444}

Causing crashes as it makes us create objects of incorrect
type.

BUG=631960
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2352663002
Cr-Commit-Position: refs/heads/master@{#419443}

BUG=647996
TBR=smut

Review-Url: https://codereview.chromium.org/2353453003
Cr-Commit-Position: refs/heads/master@{#419442}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/a2b056bd69e365ff4c2a9bfa961ad8e13565470f Archiving of AppRTC APK in client.webrtc waterfall (ehmaldonado@chromium.org)
  https://crrev.com/2dd50f3f904647f20ed62fdb3561543d5f1f0a73 WebRTC: Add android swarming bots. (ehmaldonado@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=583318,647242

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2354533002
Cr-Commit-Position: refs/heads/master@{#419441}

Protobuf contains a single item.

Review-Url: https://codereview.chromium.org/2241583003
Cr-Commit-Position: refs/heads/master@{#419440}

Fix remote shell version typo causing ARC++ to break
as a result of the deprecated zwp interface being bound
with the wrong version number.

BUG=631960
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2348253002
Cr-Commit-Position: refs/heads/master@{#419439}

This patch implements AmbientLightSensor [1] blink bindings and adds
LayoutTest helpers for testing sensors that are based on Generic Sensor API.

Following layout tests added to test new functionality:
IDL tests.
 - third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensor.html
 - third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensorReading.html
AmbientLightSensor tests.
 - third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TkfdVqYAYiE/xLGN2b1-AAAJ

[1] ED specification for Ambient Light Sensor http://w3c.github.io/ambient-light/

BUG=606766

Review-Url: https://codereview.chromium.org/2332323002
Cr-Commit-Position: refs/heads/master@{#419438}

Before this CL, the computation in UserClassifier::UpdateMetricOnEvent() did not
reflect the math outlined in the same function.

This CL fixes the problem.

BUG=648200

Review-Url: https://codereview.chromium.org/2352633002
Cr-Commit-Position: refs/heads/master@{#419437}

BUG=646938
TBR=nednguyen,yhirano@chromium.org

Review-Url: https://codereview.chromium.org/2347413002
Cr-Commit-Position: refs/heads/master@{#419436}

Review-Url: https://codereview.chromium.org/2344413002
Cr-Commit-Position: refs/heads/master@{#419435}

TBR=thestig@chromium.org
R=cfroussios@chromium.org
BUG=None

Review-Url: https://codereview.chromium.org/2347653003
Cr-Commit-Position: refs/heads/master@{#419434}

Change existing browsing data deletion methods to take a browsing_data::TimePeriod as a parameter.

Keep old methods around until all call sites are changed downstream.

BUG=642334

Review-Url: https://codereview.chromium.org/2270063005
Cr-Commit-Position: refs/heads/master@{#419433}