- 16 Nov, 2019 40 commits
-
-
Jeremy Roman authored
It is also necessary to handle the possibility of the other renderer sending a nonsense reply to the IPC. Bug: 1013389 Change-Id: I745c7bc1de21a5c7f96b5ced52cec3320ed03d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891120 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#716032}
-
Koji Ishii authored
Following bot results are included. 276 278 280 283 284 285 286 287 289 290 291 292 293 294 295 296 297 298 299 300 129 lines were removed and 32 lines were deflaked by consecutive results since 289. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ied00f67eef668ccc906254ef86f73a730c5a1d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914579Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#716031}
-
Michael Crouse authored
This change enables the optimization guide store to load and store host model features from the remote Optimization Guide Service. Bug: 1001194 Change-Id: I9124e106f872d94ab90aa0f6a30e0e29f48ca9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911226Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#716030}
-
David Benjamin authored
Refreshing all the test certificates is tedious, however generate-test-certs.sh cannot be run incrementally right now: 1. Every time it is run, the CA private keys change, so all certificates have to be refreshed. This usually breaks pinning tests, etc., and is an unnecessary complication. 2. Serial numbers must not collide. Despite this, we try to manually run things anyway, with the result that the currently checked in certificates do not match the script output in serial number! I suspect we removed a certificate in the middle of the tower at some point. To make this a bit friendlier: 1. Preserving the root and intermeidate keys if already present. 2. Randomizing the certificate serial numbers rather than counting incrementally. This means that a developer can run the script and only check in the certificate they care about. Bug: 984685 Change-Id: I3c0b0e85654dd62f82fb83f90fd1252ebbaa3135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918385Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#716029}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9ffb485eb01c..c71af3a2659b git log 9ffb485eb01c..c71af3a2659b --date=short --no-merges --format='%ad %ae %s' 2019-11-16 vapier@chromium.org remote_access: have all remote commands use utf-8 encoding by default Created with: gclient setdep -r src/third_party/chromite@c71af3a2659b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4b142d21513bd20add5a21597ce4f853417dd87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919252Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716028}
-
David Benjamin authored
The comparator did not correctly handle the case when left->priority() > right->priority(). std::make_heap and friends will not work correctly with a bad comparator and may arbitrarily misbehave. This was caught by running tests with _LIBCPP_DEBUG=0. Bug: 923166, 1018920 Change-Id: Ie480f669746566cbe045c539e203b3b89564d267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919659 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#716027}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a67b97032ab3..9ffb485eb01c git log a67b97032ab3..9ffb485eb01c --date=short --no-merges --format='%ad %ae %s' 2019-11-16 vapier@chromium.org gs: switch to cros_collections.Collections 2019-11-16 haddowk@chromium.org moblab_vm: change the disk layout for the VM image. 2019-11-16 vapier@chromium.org gerrit_unittest: require gitcookies for tests (and drop netrc) Created with: gclient setdep -r src/third_party/chromite@9ffb485eb01c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iaab32fd709884c4d47e662e6d85c2e226ed413b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920527Reviewed-by:
-
Mikel Astiz authored
If sync encryption keys are missing, the user should be prompted with a convenient button in the profile menu to trigger a reauth flow with Gaia and retrieve the keys. Bug: 1019687 Change-Id: I68181d836c2cd0f110e44dfbe434041b1014780e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895347 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#716025}
-
Minggang Wang authored
Currently, the NavigationImmediateResponse feature is enabled by default through a flag kNavigationImmediateResponseBody. As this feature has been landed for some time, this patch removes this flag and the support for the old behavior. Bug: 1017705 Change-Id: If02d58b28ccaadfa1ca94e080217321521a009fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911148 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#716024}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/extensions This CL was uploaded by git cl split. R=finnur@chromium.org Bug: 1018667 Change-Id: I086571be2512e726282a47d3f957beeb8d6a0dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917761 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#716023}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e0de92d8e44..a67b97032ab3 git log 4e0de92d8e44..a67b97032ab3 --date=short --no-merges --format='%ad %ae %s' 2019-11-16 vapier@chromium.org cros_oobe_autoconfig: rework code for Python 3 2019-11-16 yusukes@google.com StaticKCM: Roll XkbToKcmConverter w/ ARCVM system image Created with: gclient setdep -r src/third_party/chromite@a67b97032ab3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6ec6bb0aafad2ab9ff057e6db681a79f521158dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919477Reviewed-by:
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/client_hints This CL was uploaded by git cl split. R=ryansturm@chromium.org Bug: 1018667 Change-Id: I4d6ccb972fdafd58f33d11cf090fc61560bdb50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916825 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#716021}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ff3290ed. With Chromium commits locally applied on WPT: 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." e83dd93c "Limit backtracking on regexp called from blink." 6e3e930c "Change `sec-fetch-mode` from `no-cors` to `navigate` for <embed> / <object>." c8b6e1ce "Chromedriver] Fix PerformAction to support multi touch points cases" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib4311211fc2040b66a55787b158e4b865859af2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919605Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716020}
-
Martin Robinson authored
When children of dialogs have focus, explicitly assign the active state to the dialog. This will allow Orca to properly announce dialogs. We need to do something special here, because in Chromium dialogs do not have their own toplevel windows. Bug: 1023208 Change-Id: I02a0a89781d88477238728b8b516b7a2606d6af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917224Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#716019}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ae17e6fd3e30..4e0de92d8e44 git log ae17e6fd3e30..4e0de92d8e44 --date=short --no-merges --format='%ad %ae %s' 2019-11-16 vapier@chromium.org binpkg: decode data from gs as utf-8 & switch to io.StringIO 2019-11-16 vapier@chromium.org gob_util/gerrit_unittest: get it working under Python 3 Created with: gclient setdep -r src/third_party/chromite@4e0de92d8e44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic90718fa71bc56600aea1558f8723b03ebab3557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919476Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If80b79d9d4fb737a05ccc970f5926bbf21023a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919475Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/873514fca868..ae17e6fd3e30 git log 873514fca868..ae17e6fd3e30 --date=short --no-merges --format='%ad %ae %s' 2019-11-16 sanikak@chromium.org auto_updater: Updating readability of the auto_updater_transfer classes 2019-11-16 sanikak@chromium.org auto_updater: Adding 'transfer from staging server' functionality to chromite AutoUpdater Created with: gclient setdep -r src/third_party/chromite@ae17e6fd3e30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7bfbf72b7811fce4776fd259dcb3f84494da4c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919474Reviewed-by:
-
Vlad Tsyrklevich authored
Add a link to an in-depth discussion of GWP-ASan and clarify some wording. Change-Id: I3276f12a55e0bbf0ee59fcfdf446f1829e7fd5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906930 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#716015}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/13d39f255a62..873514fca868 git log 13d39f255a62..873514fca868 --date=short --no-merges --format='%ad %ae %s' 2019-11-16 vapier@chromium.org lint: drop redundant pass statements Created with: gclient setdep -r src/third_party/chromite@873514fca868 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8b6bf1586f4685397b78d536c007c018ef7d013e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920193Reviewed-by:
-
Jinsong Fan authored
The GetSelectionStartpoint and GetSelectionEndpoint provide the exact same operations, merging them into one for more better code health. No change to logic. Bug: 1002344 Change-Id: Ifb2eb68aff1e8730babc57fff901f316db01570d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918907Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#716013}
-
Jinsong Fan authored
New member variables are added to SelectionBound, but no update read/write IPC param traits. The CL adds them. Bug: 1015274 Change-Id: I1480741a981fe831e684bdea10752f43682a934d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916180Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#716012}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/77a83af83490..13d39f255a62 git log 77a83af83490..13d39f255a62 --date=short --no-merges --format='%ad %ae %s' 2019-11-16 dburger@chromium.org Remove all remaining remnants of the binhost test. Created with: gclient setdep -r src/third_party/chromite@13d39f255a62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6d52924881254a9b755c650cac67ec70838e4482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919917Reviewed-by:
-
David Schinazi authored
This CL adds support for QUIC-TLS version in ConnectionInfo and makes sure v99 uses the correct draft ALPN when displaying in developer tools. Change-Id: I3cdbd9b488cfb2f7567bb790c9e61be56a3b573b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919526Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#716010}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d021c9f3296d..f86f81aa33da git log d021c9f3296d..f86f81aa33da --date=short --no-merges --format='%ad %ae %s' 2019-11-15 awscreen@chromium.org Add initial tests for SetClip_PathFill() Created with: gclient setdep -r src/third_party/pdfium@f86f81aa33da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:1019026 Change-Id: Ie31dd4f01c1ce6c0d3f2a77293a6a583e9b3357b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919916Reviewed-by:
-
Rob Clark authored
Technically the decision is about the driver, not the hw vendor, which makes the description string a bit funny. But in the end this decision is as much about the driver as the hw. Test: Run ChromeOS on bubs/cheza, and check chrome://gpu Change-Id: Iaf87cedb9809eb15c535e7b4140f6cedf173fddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913061Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#716008}
-
Rayan Kanso authored
This will make it easier to start an origin trial with all of the new features together. Change-Id: If983c733251bcab34ff7e32189d250fb6b6a3538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919347 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Chris Lu authored
Updates the banner text for the change and also handles before and after translate actions. Represents banner when translate reaches after translate step to show "Page Translated" banner. Bug: 1014959 Change-Id: I8044ffffdd24dc1d5eb431f82bf903070caef51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906934 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#716006}
-
Findit authored
This reverts commit 71d76ec9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 715997 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzcxZDc2ZWM5MTFhNDE1ZWM0ZjE5OTE4MzA0NzY2NGY0Yjg4NDgxZWEM Sample Failed Build: https://ci.chromium.org/b/8896663695938427904 Sample Failed Step: unit_tests Original change's description: > Kill the software_reporter_tool process if the browser exits early > > Assign the software_reporter_tool process to a job object with the > KILL_ON_JOB_CLOSE flag, so that the process will automatically be killed > if it's still running when the browser exits. > > R=proberge > > Bug: 1016939 > Change-Id: I87dfc907cc853add1721f80c589051896ed4e857 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918106 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: proberge <proberge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715997} Change-Id: I98cf8ae8502f965ab438b7bfa47fe5be8b31ec48 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920319 Cr-Commit-Position: refs/heads/master@{#716005}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3541af292ea3..77a83af83490 git log 3541af292ea3..77a83af83490 --date=short --no-merges --format='%ad %ae %s' 2019-11-16 vapier@chromium.org parallel: rework file output handling for Python 3 2019-11-16 bpastene@chromium.org terminal: Only enable ANSI color codes by default if stdout is a terminal. Created with: gclient setdep -r src/third_party/chromite@77a83af83490 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iec1645110ab135a482d0757f3e5e0e1c10be5b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919913Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6ce42227610..8ff52d37c080 Created with: gclient setdep -r src-internal@8ff52d37c080 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie125cca22d8626fe414897d3c1a2d8e25c1ef810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919914Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716003}
-
Asanka Herath authored
There was nothing Negotiate specific about the interface and we are about to use it for other schemes. Bug: 991265 Change-Id: Id8aa6e91b5ae723df920a3593d4ec6eb0d3cf32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919741Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#716002}
-
Daniel Cheng authored
Bug: 902789 Change-Id: I7de5133278e3c83517d93fadd9c00103553b7861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919809 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#716001}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I580209d435528a0d887ee66b717bce656d860c7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918954Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716000}
-
Asanka Herath authored
This will be the default. So switch tree to testing with FTP disabled. Bug: 333943 Change-Id: I80848172859a54258180f23cbc303e06a9440774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918105Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#715999}
-
Aaron Gable authored
This CL creates a new builder named "Mac Builder Next" on the FYI waterfall. This builder will always be running the latest Mac OS that we support, and will be used to work out bugs with compiling on new OS versions. When this builder is stable, the OS version of the "chromium.mac:Mac Builder" bot will be updated to match. This CL also creates a new builder named "Mac10.14 Tests" on the FYI waterfall. This builder is configured identically to the existing "Mac10.13 Tests" and friends, except for OS version. When this builder is stable, it will be moved to the main waterfall and triggered by the "chromium.mac:Mac Builder". Finally, this CL also creates a trybot which mirrors these new CI builders named "mac_chromium_10.14_rel_ng", matching the existing OS-specific trybots. When this bot is stable and we have sufficient capacity, the existing "mac-rel" CQ bot will be updated to use OS version 10.14. Bug: 1018846 Change-Id: I0fbd0cbb99cf15bb68b126f10f048cb7ff0cf5c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918162 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#715998}
-
Joe Mason authored
Assign the software_reporter_tool process to a job object with the KILL_ON_JOB_CLOSE flag, so that the process will automatically be killed if it's still running when the browser exits. R=proberge Bug: 1016939 Change-Id: I87dfc907cc853add1721f80c589051896ed4e857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918106 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#715997}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/df1d0b0a33e1..3541af292ea3 git log df1d0b0a33e1..3541af292ea3 --date=short --no-merges --format='%ad %ae %s' 2019-11-16 andrewlamb@chromium.org Turn off hw tests for beaglebone, expresso, jacuzzi, zork release builders. Created with: gclient setdep -r src/third_party/chromite@3541af292ea3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iec341c6cb4ac6419d37c9fd0cf67257a0a26536e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919328Reviewed-by:
-
Jimmy Gong authored
- Previously all file types were shown in the file selector dialog when selecting a ppd for a printer. - This change will only display ppd and ppd.gz file extensions in the dialog. Bug: 1022332 Test: End to end manual Change-Id: Ie4cfeb0c50566eaa4a8c856c2df303af4a457e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904539 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#715995}
-
Brian Sheedy authored
Enables the xr_browser_tests target on Mac bots in addition to the existing Linux and Windows bots. As a result, also splits the target into two source sets so that it can be built with or without the enalbe_vr gn arg specified. This is due to enable_vr being true for Linux and Windows, but not on Mac. Bug: 933606 Change-Id: I4f27f51990d8df3417f5826a911e087dbf530cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480546 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#715994}
-
Avery Musbach authored
The present CL modifies code that was based on a bad assumption: that dragging always begins with one of the kFrom* window dragging states. Test: manual Fixed: 1024513 Change-Id: Id515edfc9344af8a86ca49b14583af244b248652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918034Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#715993}
-
