GitLab

NativeInputMethodEngine can now commit some text and move the cursor
to the beginning of the committed text in the same atomic operation.

Bug: 1155331
Change-Id: I85007fc84af1574f834467a4bc0fd4df2c5fac10
Fixed: 1155331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626680Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843883}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I27785425caddb41455f9007d567cf5e7daebb2e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630589Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843882}

In //ui/file_manager/file_manager/foreground/js/:
- actions_controller.js
- import_controller.js
- import_controller_unittest.js

Conversion of externs:
//ui/file_manager/externs/command_handler_deps.js

Bug: 1133186
Change-Id: I65d231c4c82fe92ac956845ab19b601b1636c8f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629328
Commit-Queue: Jeremie Boulic <jboulic@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843881}

Android ignores AssistData from Chrome that doesn't arrive within 3.0
seconds. The Assistant team reports that this frequently times out
with Chrome or WebView. To maximize the chances results are returned
in time, set a timeout of 2.0 seconds to get the accessibility tree
snapshot. Our underlying assumption here is that some results are
better than no results.

Note that we already had been using a limit of 5000 nodes, but the time
to populate 5000 nodes wasn't very consistent. Using a timeout will be
much more reliable.

Bug: 1161541
Change-Id: I6dfa7c37f5dc11c5a4ccd69de8533b833de00e99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629406Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843880}

Skip decoder check for the ime_spec when it's M17N request.



Bug: 1166064
Change-Id: Ib02db10805d5c222c9767e54c46367b00096587d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626864Reviewed-by: Leo Zhang <googleo@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843879}

This reverts commit bca5f7be.

Reason for revert: Tree is closed because of https://ci.chromium.org/ui/p/chromium/builders/ci/android-marshmallow-arm64-rel/24224/overview

Original change's description:
> Declare T as a base class of the BrowserAssociatedInterface<T> helper.
>
> When a class uses BrowserAssociatedInterface<T>, it should implement the
> mojo interface T. Force that to be the case by making T a suclass of
> BrowserAssociatedInterface<T>.
>
> Change-Id: Ide8ecd46c298ec86de57b229593ec7d6c4b6a3a7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629670
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#843845}

TBR=avi@chromium.org,dcheng@chromium.org,reillyg@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I0dea0f28378f7256bdd09f8196315905b8803da8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631806
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843878}

While Select-to-speak uses the global TTS speech rate by default, it now
allows users to override this rate if they want to use a specific rate
for a specific type of content. This CL records the override speech rate
multiplier used when speaking.

AX-Relnotes: n/a
Bug: 1143814
Change-Id: Ia2a5e8313d17f8abfbffc7b293af19e3b7b65018
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606678
Commit-Queue: Ajit Narayanan <ajitnarayanan@google.com>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843877}

The enum values were all in uppercase. This CL changes them to conform
to the style guide:
https://google.github.io/styleguide/cppguide.html#Enumerator_Names.

Bug: 711332
Change-Id: I4bf4cff76d15509a088df2e022942e2f87b1b5f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626652
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843876}

Also, clear the tray icon when hiding previews (as this cancels any
pending update timers).

BUG=None

Change-Id: I9647ff70b3359bd803a434d39b64d3cd6f1186b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631193Reviewed-by: David Black <dmblack@google.com>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843875}

This fixes multi-slice content. The proper way of doing it is to
aggregate all of the encryption parameters into one buffer for all the
slices and send that. Previously it was sending an encryption parameter
buffer for each slice.

BUG=b:153111783
TEST=Encrypted H264/HEVC work with single and multi-slice

Change-Id: I57abbc839d1c6878da7c6a13b8b6da9889329179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631466
Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#843874}

This is a mechanical change replacing defined(OS_CHROMEOS) with
BUILDFLAG(IS_CHROMEOS_ASH) to ensure that switching lacros' target_os
from linux to chromeos will not affect the lacros binary.

More detail on http://go/lacros-macros.

Bug: 1052397
Change-Id: Id4b8f4ea0605a897cadbf2140201e2b8efe7acd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627653Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843873}

This is a mechanical change replacing defined(OS_CHROMEOS) with
BUILDFLAG(IS_CHROMEOS_ASH) to ensure switching lacros' target_os
from linux to chromeos does not affect the lacros binary.

More detail on http://go/lacros-macros.

Bug: 1052397
Change-Id: I2018adb0173f1c0ec56e1f0228bb73fa343da83c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627199Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843872}

Trace function was calling the wrong superclass.

Bug: 1166921
Change-Id: I477b68c7ba6b39deddd4d32f2f4f092d6c696f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631285
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843871}

This test has been failing intermittently recently. Flake Portal link:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyawsSBUZsYWtlImBjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEFkc1BhZ2VMb2FkTWV0cmljc09ic2VydmVyQnJvd3NlclRlc3QuUGFnZUFkRGVuc2l0eUlnbm9yZURpc3BsYXlOb25lRnJhbWUM

It's already been disabled on Windows, but it's been failing on other
platforms, too.

I've added a few labels to the linked bug to help track.

R=johnidel

Bug: 1121444
Change-Id: I5ab328a6967437203c6390f71e6fe13f5c24eb81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631192
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843870}

Bug: 1166575
Change-Id: I6e1cd55c14234e01eda672dcc720188bb5aec5da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631196Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843869}

This is going to get populated with a JSONFileDeserializer.

Bug: 1154901
Change-Id: I5285b3b24a4d574c311addd44e34572b9e863c8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598004
Commit-Queue: Adam Norberg <norberg@google.com>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843868}

IntentMetadata is a holder for some info on the intent used for
the toolbar in an Activity. This CL moves it from chrome_java
to toolbar/ target to facilitate the modularization. This change
allows a few more classes to be moved to the modularized target:

- HomeButtonCoordinator+test
- ToggleStackButton+test
- TabCountProvider
- TabSwitcherDrawable

Bug: 1127732
Change-Id: Id6280436464fb74d2bde636c6e6e8df783f7ba85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619244Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843867}

https://dawn.googlesource.com/dawn.git/+log/d2fb128052ae..5a6fda1a6fcc

2021-01-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 0f4638b9e499 to 0a68b365ebff (4 revisions)
2021-01-14 bclayton@google.com Convert StorageTextureTests to WGSL

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from 0f4638b9e499 to 0a68b365ebff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: dsinclair@google.com
Change-Id: Ie4a5244610f500c05ab32f9f44ff4f436f4e9cf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631165Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843866}

There was a bug due to which the tutorial manager didn't return the
summary card correctly. This CL fixes that.

Bug: 1166765
Change-Id: I0775f827f5ab96dd209b85c482ce33ef86ff70e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629461
Auto-Submit: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843865}

Fix the path used in test server.

Bug: 1166280
Change-Id: I34fc06dc911c69d00f8dc4d193052d088f99816a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626022Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843864}

Clean up button_bar state by replacing ButtonState.HIDDEN with
undefined.

Bug: 1093185
Change-Id: I24e5562adfc0eb1cc7acd89fe8586e31b5d0371a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630627
Commit-Queue: Gordon Seto <gordonseto@google.com>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843863}

Weblayer seems to be triggering a crash with this config.


BUG=1166748
TEST=none

No-Try: true
Change-Id: I6fa2ae167347a1a72905be846946c6037443fb6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629663Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843862}

Change-Id: I1d2585cd45684f25b3f319e54c9a2b02fb3c0a9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631454Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843861}

GL_RG8_EXT is part of GL_EXT_texture_rg which is an ES2 extension, so we
must follow ES2 semantics like GL_R8_EXT i.e. internal format must match
data format. Just something I noticed while doing some related work,
probably doesn't matter in practice if we're not creating RG8 textures
with glTexImage2D, etc.

Bug: 1116101
Change-Id: If6042f2432eec13df6b2d27602d87674e19cc78d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629665Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843860}

Change-Id: I8283cdbb148fe05335d82fae80485fe443be7e40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631448
Auto-Submit: Leonid Baraz <lbaraz@chromium.org>
Commit-Queue: Zach Trudo <zatrudo@google.com>
Reviewed-by: Zach Trudo <zatrudo@google.com>
Cr-Commit-Position: refs/heads/master@{#843859}

This CL implements desks reordering with drag & drop. The main changes
are listed as below:

- Added response methods for mouse pressed, drag and released events in
  desk preview to trigger drag and drop.
- Added *DragDesk methods in desks bar view to handle drag and drop.
- Added a new class DeskDragProxy to create a proxy of desk being
  dragged.
- Added a method PerformMiniViewReorderAnimation to animate the
  movement of desks while reordering.

Bug: 1154038
Change-Id: I7633970a94d69e1326cf09eaede3929ca0acb811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602859
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843858}

What:
Adds new chrome/ layer embedder controls for the Conversion Measurement
API which proxy to privacy sandbox settings.

Why:
The existing integration only checks for 3P cookie blocking, whereas
the privacy sandbox settings check whether 3Ps are allowed for a given
context.

This also fixes a privacy sandbox settings bug in which the wrong
origin was supplied when checking if a report can be sent for a given
set of origins.

Note: This was previously https://ccrev.com/c/2613686, but that change
was accidentally deleted.

Bug: 1163721
Change-Id: I10aba286ad7c641fe8f19f8ad327cf6eabdc3c33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627093
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#843857}

This CL does two things.

1. The previous CL only checked the value of the content toggle at
initialization, meaning a user wouldn't immediately stop seeing
suggestions after disabling, or start seeing them after reenabling.
This CL moves the check to just before display time instead.

2. This also adds a content toggle check to the local file provider,
rather than just Drive in the previous CL. The UX of having one but
not the other wasn't very good.

Bug: 1034842
Change-Id: I4f408d8d1e40ef44e4a80906aa10ad7333a49eb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628709Reviewed-by: Rachel Wong <wrong@chromium.org>
Reviewed-by: Tony Yeoman <tby@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843856}

https://chromium.googlesource.com/vulkan-deps.git/+log/4c6cbd7a1be7..676d3c095a28

2021-01-14 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 586c46b96b62 to fb2ab876edcd (1 revision)
2021-01-14 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 820179bf4689 to a5eaf2f44a5d (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,timvp@google.com,dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: radial-bots+chrome-roll@google.com,timvp@google.com,dsinclair@google.com
Change-Id: I952a9b110b63f41e9c88b428b01ccb0dc8ad15e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629473Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843855}

Just in case it ever gets called twice, we don't want to move the error
out.

Change-Id: I6d091b2c56fa7e07ce0b1ca08f079d87621d592e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631188Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843854}

THe box-shadow property isn't shown in forced colors mode,
so give the realbox a real border instead.

Bug: 1166383
Change-Id: I8a1aa58d965a0fed1a69b0210273a984c8478a5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628077Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843853}

Make rewrite_raw_ptr_fields/rewrite.sh auto detect when we want to rewrite for the windows platform.

Bug: 1069567
Change-Id: I18044284186555a07f63cdad5a0604e5749df94c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626866Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843852}

Roll Chrome Win64 PGO profile from chrome-win64-master-1610647094-91dde28e2f09f28a39a8ebc52cc90535738b2c08.profdata to chrome-win64-master-1610657917-28dde97bcaff353b91ba180b51342313b1d23453.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I11ab61b630e99c80bd819888f2dc9daaed0745fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630985Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#843851}

Bug: 687225
Change-Id: Ic90fcd65d9e932f3a9916938af7595e121247280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629967
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843850}

This means that words with accents get the correct length of underlining.

Before this fix autocorrect "francais " to "français " would have an underline on the space after the word which this fixes.

Bug: b/176562554
Change-Id: Ic05a46ee351bbd9159b6c197cd3f02f3b3d3a7e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612290
Commit-Queue: John Palmer <jopalmer@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843849}

Bug: angleproject:5543
Change-Id: Ibe3385f636b067ca5629845a059b0b1d7b09b886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627370
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843848}

This is a reland of crrev.com/50ba4848.

The original CL was reverted because a test that runs only on Mac was
broken, but the mac-rel trybot didn't run the browser_tests target
during the original submit.

The failing test was temporary re-enabled to run on all platforms
to verify the fix works. It was also run on an additional Mac trybot
where the browser_tests target was executed. It was then re-disabled.

The only differences between the original CL and this one can be
viewed by diffing patchsets 2 and 3.

Original CL description:

Prior to this CL, the default was that test extensions were loaded
with file access enabled. This is not necessary, and doesn't reflect
the real world, where most APIs work without needing file access.

With this CL, the default is that a test must explicitly request
file access for the extension. To reflect this, some member functions
have been renamed and their behavior modified so that it's clear
that the test is requesting file access.

This also fixes the PermissionsApiTest.OptionalPermissionsFileAccess
test, which had incorrect embedded extension IDs.

Bug: 1163548
Change-Id: Ida61f22504e12a5bef1b70e9f01b0750f8008f76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629468Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843847}

This CL removes the option of setting up migrations for each database
individually, now if the migration experiment is on all databases will
be migrated (except by those in a blocklist).

This makes it simpler to launch the experiment to stable, as we will no
longer need to specify each database name on the experiment params.

Bug: 870813
Change-Id: I00259f5ceeae14790a40546d9fab064eac1aea29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630734Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: Salvador Guerrero <salg@google.com>
Cr-Commit-Position: refs/heads/master@{#843846}

When a class uses BrowserAssociatedInterface<T>, it should implement the
mojo interface T. Force that to be the case by making T a suclass of
BrowserAssociatedInterface<T>.

Change-Id: Ide8ecd46c298ec86de57b229593ec7d6c4b6a3a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629670Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843845}

Bug: 1157981
Change-Id: I94587222da279a93c61136670807423c420ef386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627760
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843844}