- 27 Apr, 2020 40 commits
-
-
Alexander Hendrich authored
TBR=jityao@google.com Bug: 1075511 Change-Id: I6882a9f268492919903bceacd5bcdf78a2bb08e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167853Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#762799}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/65301cad4d44..b0ad61f6ec5d git log 65301cad4d44..b0ad61f6ec5d --date=short --first-parent --format='%ad %ae %s' 2020-04-27 dberris@chromium.org Dashboard: Add timestamps to anomaly metadata Created with: gclient setdep -r src/third_party/catapult@b0ad61f6ec5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064955 Tbr: oysteine@google.com Change-Id: Ia00889896e1df58ad29e9f5b9468a591d39c0300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167782Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762798}
-
Alexander Hendrich authored
This reverts commit 7c281002. Reason for revert: consistent failures on "webkti linux asan" bot Original change's description: > [LayoutNG] Correct IsLastForNode() and IsFirstForNode() in inline item. > > As part of the descendants walk that we perform when adding a box > fragment that establishes an inline formatting context, update the > first/last-for-node bits directly. > > Many thanks to kojii@ for suggesting and helping out with this solution! > > Once we add the last box fragment for a node, finalize the inline items. > In addition to associating with the LayoutObjects, also set the > first/last-for-node bits, if fragment traversal is enabled. > > Since we now require the layout results to be available for anything > that establishes an inline formatting context (to set the first/last > bits), we also need to store the layout results for the column > fragments. Columns are not really associated with a LayoutObject, but > we'll use the legacy LayoutFlowThread for this. Another option would be > to create an anonymous block child of a multicol container that > establishes an inline formatting context, but I decided against that for > now. > > Expanded some NGFragmentItemTest unit tests, and added a new one, to > make sure that we behave in RTL situations. > > This allows for supporting these bits in culled inlines as well. > Enabled fragment traversal in NGFragmentItemTest, so that we can test > it, and removed DCHECKs in IsFirstForNode() and IsLastForNode(). The > culled inlines test there also expects FragmentsVisualRectBoundingBox() > to return something sensible, so remove the skipping we had in PrePaint > for culled inlines, to just make this work. > > Will follow-up with cleaning up the first/last for node stuff added as > part of CL:2111158. This will no longer be needed, but doing it in a > separate CL is probably cleaner. > > Bug: 1043787 > Change-Id: Id9873300e9ac5ec01d68aafd059a4aa3d830528b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152824 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762758} TBR=kojii@chromium.org,mstensho@chromium.org Change-Id: I9c2d4764baa7b3d714221fad9d281529b0195a3a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043787, 1075517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166188Reviewed-by:
-
Omar Morsi authored
This CL extends PlatformKeysService by introducing the following new functions: - RemoveKey This function will be used to remove the key pair corresponding to a given DER-encoded SubjectPublicKeyInfo. - GetAttributeForKey This function retrieves the value of an attribute for a private key corresponding to a provided DER-encoded public key. - SetAttributeForKey This function sets the value of an attribute for a private key corresponding to a provided DER-encoded public key. This is not planned to be exposed as an actual extension API. Instead, the functions are implemented mainly to be used by another component (built-in cert_provisioning). Bug: 1045895 Test: browser_tests --gtest_filter= *PlatformKeys* Change-Id: I8797e690487b866c80377aafce615546afd8f54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151868Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#762796}
-
Pâris Meuleman authored
This CL is a second step towards reorganizing //components/signin java files, this one moves the files from core/browser/android to public/android when relevant. Bug: 934688 Change-Id: I0ac30a3d94fa0a09f645b70c1ddc6c5345b94441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814826Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#762795}
-
My Nguyen authored
These fields are added as requested by ChromeVox's team to tell ChromeVox user the true number of candidates and the current selection's index. Bug: 1074158 Change-Id: I697f96fe955fd5dc151543d47b26c605060f0a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162501 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#762794}
-
Dominik Röttsches authored
Removing the SK_IGNORE_MAC_OPSZ_FORCE flag in Skia's build configuration fixes issue 1057654 but brings back issue 1005969 (incorrect metrics/spacing for the system font). Remove the flag, and retrieve metrics via HarfBuzz OpenType callback functions instead of Skia until skia:10123 is fixed. For system fonts with a trak table, Skia does not consistently return the advances without the trak value computed into them. Switch to using HarfBuzz advance width retrieval functions for those. This passes the mac-system-ui-trak.html test on Mac OS 10.14 and (manually tested) on Mac OS 10.15 and provides correct spacing and optical sizing for this font. The form control resizes in the tests happen due to the AverageCharWidth and other width functions in SimpleFontData metrics are still using the Skia functions. Rebaselining those, as the issue is minor and it is more important to address the bold system font regression. The right fix for this issue would be a fix for skia:10123 - after which this workaround could be removed again. Bug: 1057654 Tbr: bungeman@google.com Change-Id: I4769ce46dfbd71c9dd33132ba9549adaface007d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160916Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#762793}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I1014b57b66fc222eb839010294f2f753062ea0ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164529 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#762792}
-
Rune Lillesveen authored
It's only using the TreeScope to find @keyframes in which case using the originating element for pseudo elements should work. Even better when the originating element is a shadow host, so that we look up :host rules from the shadow tree for :host::before { animation-name: anim }. Bug: 961941 Change-Id: I38edec156eaaa7cfb3680762b135323deae00a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162988Reviewed-by:Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#762791}
-
Rune Lillesveen authored
Enabled in stable M80. Removing flag and dead code. Bug: 972752 Change-Id: I4c90512e80b77d9b0540b80956b81ee89ef46bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165747Reviewed-by:
-
Scott Little authored
Previously, these tests would occasionally flake while waiting for the scroll offset to update. This CL rewrites these tests to remove this dependency on RenderFrameSubmissionObserver::WaitForScrollOffset. This CL also changes these tests to use JavaScript promises to communicate with the page instead of polling the console output in order to improve readability of the tests. Fixed: 1035057 Change-Id: I845d0f821bdc4ee604a9432a90f5e4a100187c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166633 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#762789}
-
Nazerke authored
This CL removes the use of TabModel in UserActivityHandler which was used for getting WebStateList; and uses a browser to get WebStateList from BrowserInterfaceProvider. Change-Id: I2422071eccd7a5429b195e1b21be551f3bf48fce Bug: 1049845, 1045575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153027Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#762788}
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/FAFGq.....357Bm... Created with: gclient setdep -r src/third_party/aemu-linux-x64@357Bm... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: Ie9cfbe2b4a8eb7a2ca21fc07000626913388a8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166727Reviewed-by:
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I7ddc52fb3cc2ecdf730bdac44603760ef885f9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164530 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1b5733274640..bcf6a2430e99 git log 1b5733274640..bcf6a2430e99 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 cepheus@frii.com Move to SPIR-V 1.5 Rev. 3, bump revision, remove a status from README. Created with: gclient setdep -r src/third_party/glslang/src@bcf6a2430e99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I139b9fd45f37631a9e920c0223c6deb249f11b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167779Reviewed-by:
-
Koji Ishii authored
Before moving to |NGInlineCursor|: * |InlineFragmentsFor| returns nothing for culled inlines. * |SelfFragmentsOf| returns relevant fragments for culled inlines. But both were moved to |NGInlineCursor|. This patch reviews all changes and re-distinguish them. Following usages were |SelfFragmentsOf|, changed to use the new function |MoveToIncludingCulledInline|. https://chromium-review.googlesource.com/c/chromium/src/+/1862534 |FirstLineBoxTopLeftInternal| |HitTestCulledInline| |PhysicalLinesBoundingBox| * |CollectLineBoxRects| uses different code path by |LayoutNGFragmentItemEnabled|, so no need to change for now. https://chromium-review.googlesource.com/c/chromium/src/+/1888623 |LinesVisualOverflowBoundingBox| Following usages were |InlineFragmentsFor|, keep using |MoveTo|. It was changed to return empty for culled inlines. https://chromium-review.googlesource.com/c/chromium/src/+/2022447 LayoutInline::NodeAtPoint https://chromium-review.googlesource.com/c/chromium/src/+/1888623 LinesVisualOverflowBoundingBox https://chromium-review.googlesource.com/c/chromium/src/+/1930287 InvalidateDisplayItemClients Bug: 982194 Change-Id: I4ea181606671a18b6337b7e651916be6ff5d1a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166233Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#762784}
-
edchin authored
iOS 13.4 introduces new APIs for mouse cursor support on iPad. Buttons should react to pointer hover. This CL enables the default hover effect on signin_promo_view buttons. signed out. Open bookmarks. Check hover pointer effect on "Sign into Chrome" and close buttons. Test: iPad-only. Enable pointer support flag. Account should be Bug: 1073961 Change-Id: Iece3506e0c98142383d9fa6814f4956c4af43136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166414Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762783}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I39ecaaf0d0770f1048c7f2ce2c43f98ec9212565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164633 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#762782}
-
arthursonzogni authored
[Android Sheriff] Disable ExpandablePaymentHandlerBrowserTest.WindowClientReady This test is recent. It was introduced by: https://chromium-review.googlesource.com/c/chromium/src/+/2037643 It is flaky on (at least) Android. TBR=tedchoc@chromium.org,rouslan@chromium.org,maxlg@chromium.org> Bug: 1075481 Change-Id: I3284b7deeba92946326410539d94c88e5b1c1d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166185Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#762781}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3cb9c4bee9b3..a67630cdfebc git log 3cb9c4bee9b3..a67630cdfebc --date=short --first-parent --format='%ad %ae %s' 2020-04-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader f42c698d784a..60aa34a990fa (1 commits) Created with: gclient setdep -r src/third_party/angle@a67630cdfebc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I206638c12b881c280bee14346ed5e193aee0a7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167777Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1b8ef63876eb..f7f7cc93aa44 git log 1b8ef63876eb..f7f7cc93aa44 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 jonaso@webrtc.org Extend IceControllerFactoryArgs with field trial string 2020-04-26 peah@webrtc.org APM: Add build flag to allow building WebRTC without APM 2020-04-25 mbonadei@webrtc.org Fix the name of the file generated by generate_sslroots.py. 2020-04-24 mbonadei@webrtc.org Update set of known root certificates. Created with: gclient setdep -r src/third_party/webrtc@f7f7cc93aa44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1024965,chromium:978779 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib1f1594b9c051a8919ac7f57c384a168444f4ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167781Reviewed-by:
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/5b91c52083ae..e53c44e3260d $ git log 5b91c5208..e53c44e32 --date=short --no-merges --format='%ad %ae %s' 2020-04-24 qxliu [subset] temporarily revert previous cmap commit Required in https://github.com/harfbuzz/harfbuzz/issues/2356 2020-04-24 ebrahim minor, spacing 2020-04-23 behdad Rename add_class to collect_class 2020-04-23 behdad Rename add_coverage to collect_coverage 2020-04-23 behdad [set] Add << overload for range-sink 2020-04-23 behdad [hashmap] Minor 2020-04-23 corbett.dav Increase the size of the serialization buffer 2020-04-23 ebrahim minor, add an option to skip private APIs use in main.cc 2020-04-23 ebrahim [meson] make 'tests' option enabled by default 2020-04-23 hugo src: meson: Reindent after last changes 2020-04-23 hugo src: Don't build tests when they are disabled 2020-04-23 ebrahim minor, add unlikely around lookup_limit_exceeded checks 2020-04-22 razrfalcon [kern] Refactoring. 2020-04-21 behdad [autotools] C++11 requirement is mandatory 2020-04-22 behdad Reordering fails when GDEF table is absent #2140 2020-04-22 razrfalcon [kern] Test format 3. 2020-04-22 khaledhosny [docs] Fix broken link 2020-04-21 behdad Minor 2020-04-21 ckitagawa Fix bug 2020-04-21 ebrahim minor, update ragel generated hb-number-parser.hh 2020-04-21 ebrahim minor 2020-04-19 n8willis [Docs, usernmanual] Fix with-icu=builtin explanation 2020-04-19 n8willis [Docs, usermanual] Reword hb_ft_font_create_referenced explanation 2020-04-15 n8willis Add detail to hb_ft_font_create inline comments 2020-04-15 n8willis Rewrite hb_ft_font_set_funcs inline explanation 2020-04-15 n8willis Update hb-ft.cc 2020-04-13 n8willis Update usermanual-integration.xml 2020-04-13 n8willis Update usermanual-integration.xml 2020-04-13 n8willis Update usermanual-integration.xml 2020-04-13 n8willis Update docs/usermanual-integration.xml 2020-04-13 n8willis Update hb-ft.cc 2020-04-13 n8willis Update usermanual-integration.xml 2020-04-13 n8willis Update usermanual-integration.xml 2020-04-13 n8willis Update docs/usermanual-integration.xml 2020-04-13 n8willis Update src/hb-glib.cc 2020-04-13 n8willis Update src/hb-graphite2.cc 2020-04-13 n8willis Update src/hb-graphite2.cc 2020-04-13 n8willis Update src/hb-icu.cc 2020-04-13 n8willis Update src/hb-graphite2.h 2019-05-24 nwillis [Docs] Usermanual: integration chapter; add GI-Python section. 2019-05-24 nwillis [Docs] Usermanual: integration chapter; add ICU section. 2019-05-24 nwillis [Docs] Usermanual: integration chapter; add CoreText/Mac section. 2019-05-24 nwillis [Docs] Usermanual: integration chapter; add Uniscribe/Windows section. 2019-05-24 nwillis [Docs] Usermanual: platform integration chapter; add intro, GLib, FreeType sections. Update XML TOCs to match. 2019-05-20 nwillis [Docs] Add gtk-doc comments to hb-graphite2. 2019-05-20 nwillis [Docs] Add gtk-doc comments to hb-icu. 2019-05-20 nwillis [Docs] Add gtk-doc comments to hb-ft. 2019-05-20 nwillis [Docs] Add gtk-doc comments to hb-gobject and hb-glib. 2019-05-20 nwillis [Docs] Add gtk-doc comments to hb-uniscribe. 2019-05-20 nwillis [Docs] Add gtk-doc comments to hb-coretext. Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,jshin@chromium.org Tbr: kojii Bug: 1071958 Change-Id: I0ea5fe3cc89ac009d85d6b1316fd16d1bc1be7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167435Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f2c41c66492c..b59ed7ed88a3 git log f2c41c66492c..b59ed7ed88a3 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 sigurds@chromium.org [issues] Report issue number instead of aggregated issue number Created with: gclient setdep -r src/third_party/devtools-frontend/src@b59ed7ed88a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1057979 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I730cfe370e2834d381fed1337520c8a668413488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167778Reviewed-by:
-
Yao Xiao authored
To address false positives and to align more with the Better Ads Standards. The main changes: - Scope to only pop-ups (i.e. appear after content has loaded) and exclude prestitials (i.e. appear before content has loaded). The content is determined to be loaded *after* the first time detector sees the first-meaningful-paint. - Skip counting if the overlay was created with a user gesture. - Skip counting if the overlay is too small. - Skip counting if at the ad dismissal time, the main frame scrolling position has changed since the ad appearance (to exclude false positive: parallax/scroller ads) Bug: 1032681 Change-Id: Idf767870c45eba914f5169a9452309159a6e8b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148674 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#762776}
-
Arthur Sonzogni authored
This reverts commit cc361a9d. Reason for revert: The test is flaky. See https://bugs.chromium.org/p/chromium/issues/detail?id=1071110#c9 Original change's description: > Re-enable test on Android. > > This test was disabled for flakiness; however, over 500 attempts to > reproduce the sync-related flakes were unsuccessful. > > We suspect that the underlying problem has now been resolved. > > See crrev/c/2150232 to view the attempts and the bug for more details. > > Bug: 1071110 > Change-Id: Ib2364be94c17dc7c70b06950113594254e256287 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165845 > Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762482} TBR=asvitkine@chromium.org,caitlinfischer@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1071110 Change-Id: Ife1f22bc58bee23d1e7664b24538b118e7316ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167754Reviewed-by:
-
Maria Kazinova authored
Setting up unique IDs and using them for FormManager lookup. Bug: 1075444, 986631 Change-Id: Id3ba98a3e498bc22bd456bdf7f89371b14a12616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152590 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#762774}
-
Alexander Hendrich authored
This reverts commit 61ba611f. Reason for revert: SyntheticGestureControllerTest consistently failing on MSan bots Original change's description: > Scope WebInputEvent types to enum namespaces. > > WebInputEvent::Type and WebTouchPoint::State are adjusted in this change. > > This allows us to alias this enumeration to a mojo defined type that > will come in another CL. > > No functional changes in this CL, largely completed via sed. > > Change-Id: I57ad12e89aeba5a0d7e780abe0c627a0e1bc3876 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160859 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762491} TBR=avi@chromium.org,dtapuska@chromium.org Bug: 1075459 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I1d16f5cdc58abcdedbc2e6a00aa14b499069dffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166106Reviewed-by:
-
Wojciech Dzierżanowski authored
Move MediaPositionState updates out of MaybeUpdateBufferSizesForPlayback(), apply them upon more state transitions, and take the current "ready state" into account. This fixes two issues with MediaPositionState updates: 1. In MaybeUpdateBufferSizesForPlayback(), MediaPositionState updates depended on the presence of the multibuffer. But the multibuffer is never used with MSE. 2. In the case of buffer underflow, playback stalls while more data is being fetched. The rate in MediaPositionSatate should be updated accordingly, but it wasn't. Furthermore, when resuming, the rate should be updated again based on |ready_state_|, but MaybeUpdateBufferSizesForPlayback() checks |highest_ready_state_|. Bug: 1072396 Change-Id: Ieebc9ece656ffba2fa67e9dd520fb2f29ad08536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160473Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#762772}
-
Hans Wennborg authored
This is a reland of ba6e417c The revert (crrev.com/c/2165458) was unrelated to this change. Original change's description: > Remove/replace unnecessary logging.h includes in .cc files (ipc) > > CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved > to the much smaller headers check.h, check_op.h, and notreached.h, > respectively. > > This CL updates .cc files to use those headers instead when > possible, with the purpose of saving compile time. > > (Split out from https://crrev.com/c/2164525 which also has > notes on how the change was generated.) > > Bug: 1031540 > Change-Id: I9b41171cc43f427005f9a9d78e5cd61341ebeb40 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164512 > Commit-Queue: Tom Sepez <tsepez@chromium.org> > Auto-Submit: Hans Wennborg <hans@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762412} TBR=tsepez Bug: 1031540 Change-Id: If1f75bd7c8ede51d08b660b3688bf392eceeab7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167437Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#762771}
-
Saurabh Nijhara authored
OnStartSignInScreen() might show update required screen after OOBE is completed and WizardController::LoginScreenStarted() would then call hide on the current screen (update required in this case), which is not what we want. Also, it makes sense, to first reset the current screen and then show the next screen. Bug: 1064271 Change-Id: I37de884c65f3621f057602b4fa1678ebee6efc8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166903 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762770}
-
arthursonzogni authored
Bug 1064676 has been fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/2111170 And tested by: https://chromium-review.googlesource.com/c/chromium/src/+/2144012 The bug was fixed for every CSP checked in the renderer process. However there are still an issue for the one checked in the browser process. It turns out the CSP in the initial empty document weren't properly propagated to the browser process. This patch: 1) Fix the bug by sending the CSP of the initial empty document. 2) Add a regression test (WPT). This patch can potentially also fix: - https://crbug.com/1072719 - https://crbug.com/955350 (I haven't checked. I will do it later after landing this patch) Bug: 1064676, 1072719, 955350 Change-Id: Ie5325035c74d9e2476d6c80af3e5d5c9068ea928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159242 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#762769}
-
Scott Little authored
Other LazyLoad browser tests were having trouble with flakiness caused by RenderFrameSubmissionObserver::WaitForScrollOffset sometimes hanging (see https://crbug.com/1035057), so this CL removes these unneeded dependencies in order to reduce the flakiness of these data savings browser tests. Fixed: 1074594 Change-Id: I2d568fbc77c4c576cc1b912fef54aa413231132b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166635Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#762768}
-
Nohemi Fernandez authored
SceneController calls AddAccountCoordinator from an ApplicationCommand. A user that directly triggers this command, for example by adding an account through accounts.google.com/addsession, will crash the app. This was fixed in patch crrev.com/c/2074504. Bug: 1054861 Change-Id: I9a125ee8cfa539be0396a2e7faab1a638231eb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159440Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#762767}
-
Ce Chen authored
two features used by non-incognito and incognito separately. Tested on iPhone X. Bug: 925072 Change-Id: I753fd676ec58b758e09d22ee35932ece5be2ae3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154441Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#762766}
-
Takuto Ikuta authored
This test is not run by production builder: * https://ci.chromium.org/p/chromium/builders/ci/android-lollipop-arm-rel And it is noisy to have test case in staging that does not exist in prod. This also removes the test from https://luci-milo-dev.appspot.com/p/chromium/builders/ci/android-marshmallow-arm64-rel-swarming/2019 but let me not take care that for configuration simplicity currently. Bug: 1074759 Change-Id: I1a7643ebd9ae8feef972a504e8b14fafa7f412b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166214 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#762765}
-
Aaron Leventhal authored
Bug: None Change-Id: I38d4bbba6a1d1ef731a4c3e8cd897ac8e26083ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167414 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#762764}
-
Kenichi Ishibashi authored
The main motivation of this CL is to modify ServiceWorkerInstalledScriptReader::Client::OnStarted() so that it doesn't depend on HttpResponseInfo. ServiceWorkerResponseReader::ReadResponseHead() is added to move HttpResponseInfo -> URLResponseHead conversion from Client implementations (i.e., ServiceWorkerInstalledScriptLoader and ServiceWorkerInstalledScriptsSender) to ServiceWorkerResponseReader. ReadResponseHead() is added temporary to reduce code changes at one time. ServiceWorkerResponseReader (and Writer) will be replaced with storage::mojom::ServiceWorkerResourceReader in the future. This CL also modifies ResourceResponseHeadAndMetadata to use IOBufferWithSize for metadata instead of std::vector<uint8_t> so that we don't allocate additional memory for metadata when it isn't needed (ServiceWorkerInstalledScriptsSender doesn't need a copy). Bug: 1060076 Change-Id: I177586ced3b2f2b283e81d7134c19f2aeca2fbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162435 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#762763}
-
arthursonzogni authored
[Android sheriff] Disable: QueryTileSectionTest#testFocusOmniboxWithFirstLevelQueryText This test consistently fail. It was added yesterday: https://chromium-review.googlesource.com/c/chromium/src/+/2152228 TBR=shaktisahu@chromium.org,dtrainor@chromium.org Bug: 1075471 Change-Id: I09356bb6e314a556d3508ec8336d8045c3dfc06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166107Reviewed-by:
-
Sylvain Defresne authored
If goma.install was not set in ~/.setup-gn and $GOMA_DIR was not set, then ios/build/tools/setup-gn.py script would disable goma in the generated Xcode project. Bug: none Change-Id: I6c8bf45bee9ae8a21f375d880b2ccb47982a8e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164825 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#762761}
-
Miyoung Shin authored
This is a follow up CL of https://crrev.com/c/2071443 and moves popup.mojom from /popup to /choosers which contains all forms-ui-related mojom and renames ExternalPopup interface to ExternalPopupClient. Bug: 1044268 Change-Id: I76508c1fc2709eabbac3f20f4b2ee2dcf009520d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164425 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#762760}
-
