- 29 May, 2020 40 commits
-
-
Sammie Quon authored
*Destroy old layer when new layer animation is aborted. *Only log histograms once after animation. The old layer is owned by a observer which does not know when the new layer is being aborted. Change this so that the observer observers the new layer and destroys the old layer accordingly. The pass animations reporter will be used for every LayerAnimationElement, for cross fade, we animate opacity in addition to transform when the old bounds is wider than the new bounds. This results in double counting, which skews the smoothness numbers as animating two properties should be slower. Test: manual, ash_unittests WindowAnimationsTest.CrossFadeHistograms Bug: 868170, 1087460 Change-Id: I3bc5b597e8109a3e87f432f6aa352ba94860f8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218557Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#773397}
-
Wei Li authored
Change the title and heading style to follow the same style as specified in "Google developer document style guide" (https://developers.google.com/style/). TBR=pkasting@chromium.org BUG=none Change-Id: I06c38d32b28a2236a032998ebbc361006a84d87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222698Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#773396}
-
Kyle Horimoto authored
Ranking system: (1) Compare SearchResultDefaultRank. (2) If equal, compare relevance score. (3) If equal, compare SearchResultType. (4) If equal, arbitrarily choose the first one. Fixed: 1082251 Change-Id: I3617f2f0454652cd957c5da317c81a77162f3f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220866 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773395}
-
Clark DuVall authored
This class overrides onProvideAutofillVirtualStructure() which was added in O. Bug: 1085294 Change-Id: I29c8876f1340beef65350c2333f7f6ffd6d0540e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222968 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#773394}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cc7ec24ca824..1dbc3b533962 2020-05-29 dmazzoni@chromium.org Tagged PDFs should output an IDTree. 2020-05-29 elliotevans@google.com Add puppeteer perf for performance degredation related to transforming a complex path. Translations 2020-05-29 jvanverth@google.com Fix D3D static buffers and set rendertarget If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:607777 Tbr: westont@google.com Change-Id: I94f8b3e5e514a9864b852a1ca802e57f4a053442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222715Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773393}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/521a1ec91ba2..d0b1c6976238 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nsatragno@google.com,tguilbert@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045256,chromium:1047629,chromium:1078359,chromium:1078815,chromium:944108 Tbr: nsatragno@google.com,tguilbert@google.com Change-Id: I166c7b926bf6b890a312edee3122dfa507b001ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222786Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773392}
-
Brian Sheedy authored
Suppresses a recent failure on CrOS kevin devices in Pixel_CanvasLowLatencyWebGL. TBR=ynovikov@chromium.org Bug: 1088023 Change-Id: I9b376d0e8170f167177f3bddec7e01f714d30e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222861Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#773391}
-
Reilly Grant authored
This flag, set in the DCB structure when configuring the port, tells Windows to abort all I/O operations on the port when an error occurs. Since we track read and write errors separately this causes trouble because it means that every read error also causes a write error (the abort) as well. Bug: 1087699 Change-Id: Ida2aaa0ca2e1f20025c1eec3bc34dc3d26a09bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220621 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#773390}
-
Gavin Williams authored
The updated OnPrinterStatusUpdated function will return a Promise with the newly fetched printer status to the function caller. Bug: 1059607 Change-Id: I9e76cdb6752c3fa030e8d1a17d7f95c5241f1ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216851 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#773389}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/721a721d0875..d5be5daff9f5 2020-05-29 nodir@chromium.org Roll prpc and rdb tools to the latest version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I507e6f2a415ee0c7dc713ad32498eaf49c6cd1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222713Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/25b938b8a38d..f2ea618e6ba4 2020-05-29 anubmat@microsoft.com Update browser_protocol.pdl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6efe43748ca5dae2682b2f00a00d31cd4f4c8e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221430Reviewed-by:
-
Haoyue Wang authored
Also update tests affected by FLAGS_quic_reloadable_flag_quic_advance_ack_timeout_update, which changes the time at which ACK packets are sent. https://quiche.googlesource.com/quiche.git/+log/64863213b10f..d7beb6099c3a $ git log 64863213b..d7beb6099 --date=short --no-merges --format='%ad %ae %s' 2020-05-28 dschinazi Use draft-28 transport parameters in QuicConfig 2020-05-28 dschinazi Introduce draft-28 transport parameters 2020-05-28 renjietang remove an old debugging log. 2020-05-28 nharper Fix QuicSpdyClientSessionTest.IetfZeroRttSetup for upcoming BoringSSL roll 2020-05-28 quiche-dev Add ipv6_only to QuicUdpSocketApi::Create. 2020-05-28 fayang Adjust retransmission credit after PING gets sent in QuicSentPacketManagerTest.ClearLastInflightPacketsSentTime. 2020-05-28 renjietang Establish encryption on IETF QUIC client when 0-RTT key is available. 2020-05-28 fayang Explicitily enable 3 bbr flags in bbr_sender_test to make tests run with art invert_*_flags happy. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I9d1953793807367502e5f553ed1308a8d8028da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222940Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Haoyue Wang <haoyuewang@chromium.org> Auto-Submit: Haoyue Wang <haoyuewang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773386}
-
Xianzhu Wang authored
When we create a synthetic effect for an effect having backdrop effects (backdrop filter or exotic blend mode), to ensure the backdrop effects can access the right backdrop, we move the backdrop effect up to the outermost synthetic effect. Previously we only moved up the backdrop effects themselves, leaving other effects (e.g. opacity) in the same blink effect node in the original cc effect node created for the blink effect node, causing the result of backdrop filters not under control of the other effects. Now move the whole effect node having backdrop effects up. This actually simplifies the backdrop effect moving up logic. Bug: 1084832 Change-Id: Iab88d28eca6b2ea77ac8c8a4992696386af318d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213452Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773385}
-
danakj authored
Provisional frames don't have a name, so the logging is different, but we can print the name of the frame they will be replacing. That name is assigned at swap in, but the tests can get to it before-hand. Avoid sending a DidFailProvisionalLoad() notification during unload of a frame being swapped out. We were sending this unconditionally on unload even if the navigation succeeded, because the frame being unloaded has no idea. The navigation is happening in the provisional frame. This makes the RenderFrameObserver expectations match with site isolation and without. R=dgozman@chromium.org Bug: 765779 Change-Id: I2c160091e06a890470746356b6fcfed3cc977948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219088 Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#773384}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1aa58ae23fd7..7e9f1ed06105 2020-05-29 eseckler@google.com Merge "service: Fix win/mac/nacl build" 2020-05-29 hjd@google.com Merge "ui: Run npm audit --fix" 2020-05-29 eseckler@google.com Merge "service: Capture clock snapshots periodically while tracing" 2020-05-29 lalitm@google.com tp: refactor generation into a global variable 2020-05-29 lalitm@google.com Merge "tp: fix build of metatrace on GCC" 2020-05-29 fmayer@google.com Merge "Use IDs instead of raw rows." 2020-05-29 fmayer@google.com Merge "Use tables rather than HeapGraphWalker for flamegraph." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I07501430fc10045730f455ee52c25ba93311dd87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222788Reviewed-by:
-
Wenyu Fu authored
Add two finch flags to collect synthetic trial data for enable/tracking- only group that users has "seen" the homepage promo. Bug: 1068831, 1084292 Change-Id: Ibf798c0f814c215fd958af2e9463828358b23be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208271 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#773382}
-
Bo Liu authored
Implement surfaceRedrawNeededAsync for SurfaceView. This is meant to ensure that after SurfaceView is resized, a partially drawn surface is not shown to the user. The implementation is roughly copied from CompositorView in chrome. Bug: 1084500 Change-Id: Ic8272f680488222f25c74fda8c82ece144e1c8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222142Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773381}
-
Dan Harrington authored
- Some TODOs no longer applied, others were fixed. - StreamModel now de-dups content - Changed some pointer parameters into references, now that the style guide permits this. Change-Id: I8a246648efa38bb4928e615e9a79b7926da72c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220607Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#773380}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590767663-c9c32cda7f7963eb3f000a0ebfa31cdf13cf0117.profdata to chrome-mac-master-1590782199-5f9cc23c2c468b4d853caca7f19fea68cbc16f21.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I95dc79e686001bc279f02a33e31cb92ad2ee7f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222787Reviewed-by:
-
Ian Kilpatrick authored
Test-only for fixed bug by NG. No behaviour change. Bug: 903224 Change-Id: I268ae2b8a49dd84fdb23fe49e2da551d550976c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223002 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773378}
-
dpapad authored
This script was previously used with Grit, but that is no longer the case since r682948. Bug: None Change-Id: I67446b17949c16493963d307f89e91ec43b06a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222765 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
-
Brian Manthos authored
This change updates chrome/installer (as a whole) to use nullptr rather than NULL consistently. BUG: 1083987 Change-Id: Ic08b41e1356983113d907e719a022c2e1f7b88e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218560 Commit-Queue: Brian Manthos <brianman@microsoft.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#773376}
-
Lei Zhang authored
Move the comment, which adds a break to the sources list, and its associated files into a separate section. As is, the break in the sources list often confuses people, and that leads them to add files to the wrong part of the sources list. Change-Id: I1c969cec45ee678fc2d0c90ab76809d44d98e9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219605Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#773375}
-
Jeremy Roman authored
1. Add having any kind of inner contents that is currently audible as a qualifying condition for a contents being audible. This encompasses portals. 2. Correspondingly, add attaching/detaching an inner contents as a possible reason for the audio state changing. Detachment can happen implicitly during contents destruction (which already deals with this, and would otherwise attempt to access destructed members), so this case is excluded. 3. Currently the timeout that the tab actually observes is the one issued directly by AudioStreamMonitor, but an inner contents AudioStreamMonitor may already be destroyed (along with its owning contents) at the time the 2-second timer expires. It notifies using the navigation state signal. The outer contents RecentlyAudibleHelper is aware of the correct state, but pending the resolution of crbug.com/846374 does not notify the tab strip of this. Until that is resolved, add a notification directly from the helper. This may duplicate the AudioStreamMonitor notification, but this appears to be harmless (we'll just recompute the alert state twice) and in any event will go away when crbug.com/846374 is fixed. 4. Browser tests that watch the tab UI state are included. These tests are high-level integration tests, because tests which merely examined the recently-audible state would not have caught some issues that arose from notification of that state change not being propagated to the chrome. Fixed: 1085862 Change-Id: I9c6c7be64883914fdbfff5bf565718b108113b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213118Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#773374}
-
Thomas Guilbert authored
This reverts commit 92842b6a. Reason for revert: This breaks fuchsia/engine/browser/media_browsertest.cc https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20ARM64/103950 Original change's description: > [Fuchsia] Add WebEngineIntegrationTests.PlayVideo test > > Previously there were tests that play audio and tests that play video, > but no tests were playing a file with both audio and video. Also video > was not played to the end. Added PlayVideo test that plays > bear-vp9-opus.webm to the end. Also updated SetBlockMediaLoading tests > to share play_video.html and reduce amount of duplicated code. > > Bug: b/153914562 > Change-Id: Iba492ec252f692f7aa3f93c319d858a91bb38278 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219404 > Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773338} TBR=kmarshall@chromium.org,sergeyu@chromium.org Change-Id: Ief517228f418509838bb07a1318b4e7a80b1aedd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/153914562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222697Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#773373}
-
Sahel Sharify authored
paymentOptions used to get populated as an string arraylist in intent extras. This cl changes the paymentOptions to a bundle so that native app developers won't need to convert string values to boolean. Bug: 1026667 Change-Id: I6804d8765b9c90da73b8533ca55c7304823858f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219684Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#773372}
-
Shengfa Lin authored
Re-organize code so that when retry after initial setWindowBounds, will trigger setWindowBounds again in hope to trigger window state change. This is an attempt to add on the following fix. [chromedriver] Fix testWindowMinimize flakiness After setting window bounds, could potentially wait for 1 second using retries for window state to reflect. Bug: chromium:1068467 Change-Id: I62ca499879ec1d31e1eabafa8c8dea870e3e03da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222625 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773371}
-
Robert Kroeger authored
conformance2/textures/image_data/tex-2d-srgb8_alpha8-rgba-unsigned_byte.html is flaky on Builder Win10 FYI x64 Exp Release (Intel HD 630). Suppress. TBR=kylechar@chromium.org Bug: 1087993 Change-Id: Icdfa404f6ab1b62fbb97b605cb6b0bb34e7d7a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222881Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Auto-Submit: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#773370}
-
Kyle Horimoto authored
I'll start them out at medium for now, and we'll adjust the rankings accordingly once we get more testing completed. I updated a few ("Mono audio" and "Blue light reduction") to kLow since these have been interfering with "Bluetooth" and "Wi-Fi". Bug: 1082251 Change-Id: Ic45495e2fcb55939fd7a08e38312c875f364805a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222294 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: -
Elly Fong-Jones authored
This test relies on ChromeDriver's SetWindowBounds, which is flaky - it waits 100ms for the command to complete rather than observing an actual event. Bug: 867511 Change-Id: I7b4b759be6f2498b0ff3b46f705d2e2567d07558 Tbr: johnchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222720Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#773368}
-
Xianzhu Wang authored
Inset box shadow doesn't scroll, and it's in the scrolling area above the background below the scrolling contents, so the background must paint in the main graphics layer. Bug: 1086457 Change-Id: I6bf5fc3e7754a29cfa60d72acbe5699594152ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222626Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773367}
-
Chris Harrelson authored
Change-Id: I3bd33fdfb707408809dfa777ce1a0abfcfd7991b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219159Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#773366}
-
Wei Li authored
This update is based on the feedback from estade@. Chromium itself doesn't have a style guide for documentation. For titles and headers, the existing documentation has different styles. To make our document consistent, we can follow "Google developer document style guide" (https://developers.google.com/style/) to use sentence case for titles and headings. BUG=none Change-Id: If9e63e94971b9015e1803c79b9995809ad166783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219302 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#773365}
-
Lei Zhang authored
The CL that triggered their flakiness got reverted. Bug: 1021545 Change-Id: I7d7862f2ee1031fbe402276d0ab62f6fcb13fe6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219349Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#773364}
-
Mounir Lamouri authored
Bug: 929156 Change-Id: Id923970af87c4924a26961a6f70145bffeab3005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460062 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#773363}
-
Thomas Guilbert authored
Add @RetryOnFailure to IncognitoStorageLeakageTest#testStorageDoesNotLeakFromActivityToActivity Although there are talk about removing the RetyOnFailure flag (see crbug.com/797002) for now this should be slightly less expensive than re-running the entire test suite. TBR: tedchoch@chromium.org Bug: 1087796 Change-Id: I2f76509aa7f5aecf9f7554cc3d825149055b428d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222727 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
kdillon authored
These histograms are still in use. Bug: 1072542 Change-Id: I7524ba1fc7f233ca84171ffdb4c11c58c767a8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222630Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#773361}
-
Ben Pastene authored
Same thing that crrev.com/c/2219679 did, but for tests invoked via host-side cmd (eg: telemetry) rather than device-side cmd (eg: gtests). Bug: 1087407 Change-Id: I514a01583bbfea6a4a600d738587d8663ae0adec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222901Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7693b668..772196e5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I13bec7b00a9e05d3e8cba4fb72c105b90d82a9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222207Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773359}
-
Joe Mason authored
Instead of hardcoding a top and bottom border in the graph, add a border around each node's bounding area in boundingForce. This will keep nodes away from the lane markers as well as the graph edges. R=siggi Bug: 1086231 Change-Id: I58b52649aec0e921de5a85d8bd191591bf36f13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222529Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#773358}
-
