- 11 Jan, 2021 40 commits
-
-
Khushal authored
Change-Id: I5eb39f6ddcfbd32492e4ad766d29c2a9bb086061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622891 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#842228}
-
Gavin Williams authored
Screenshot: http://screen/6nEEYaC23tGoJAh Bug: 1059779 Change-Id: Ifb0c27b9131acde53029acc4541349c6c2e41423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618474Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#842227}
-
Matt Menke authored
The DCHECK only triggers if require_network_isolation_key_ is true. Also added logic to only set it to true when all features than can make URLRequests are configured to respect NetworkIsolationKeys, as otherwise, even if all requests coming into the NetworkService have non-empty NIKs, requests created by features within the NetworkService that are not configured to respect NIKs have empty IsolationInfos. Bug: 1082280 Change-Id: I561b2eb6dc90ff588b1d5c74a765a379d50b15e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595829Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#842226}
-
Daniel Cheng authored
Bug: 1013149 Change-Id: I776f91f8fec4623af9735b63060545ab473956e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617354 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#842225}
-
Ian Kilpatrick authored
There is some interesting behaviour within tables, which only consider column percentages for intrinsic min/max sizes for a block container chain. If there are column percentages present, the intrinsic max-size can go infinite, which only really works within block flow layout. Bug: 958381 Change-Id: I50ffc10a82a3432576ec4dcb23c0935def4e389c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597042 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842224}
-
Chris Lu authored
In the kDefaultBrowserFullscreenPromoExperiment experiment, an arm will show a "Remind Me Later" button in the fullscreen promo. In order to properly analyze the results, separate histograms are necessary for the user interactions of the promo with the new button and the interactions in the subsequent impression. This change also adds the string changes for the second arm of the experiment, which swaps the "Learn More" text and the description text in the fullscreen promo. A new string is added for the experiment "Learn More" text because a numbered list is desired instead of inline. Bug: 1155778 Change-Id: Ib1c02ab48f2895cd195d15e37f473ac9c24e805f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587790 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#842223}
-
dpapad authored
The UI passes an index specifying which profile should be imported. Previously there were no checks to ensure that the index is within the bounds of the profiles array. Fixed: 1164816 Change-Id: I01dd1a6d857b5af408d0b04cff429774c02368b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619769 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#842222}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/43761d2e076c..79f0fe5f0ec1 2021-01-11 jbudorick@chromium.org devil: make devil_env_test pass under py3. (reland) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1007101 Tbr: sadrul@google.com Change-Id: I01b3c3794f000fc335f86d4fe89b5fc522886ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622795Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842221}
-
Ben Pastene authored
These are some old builders spun up to test out a then-new recipe feature. But it's unlikely that anyone monitors these builders any longer, so let's get rid of them. Bug: None Change-Id: I1b2744bd351595b25d19f217f266479c262a59dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616728 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#842220}
-
Stephen Chenney authored
We stopped reporting un-suffixed versions of these metrics with https://chromium-review.googlesource.com/c/chromium/src/+/2527581. So mark them as base="true" to reflect their true status. Confirmed that we are not reporting since November. Bug: 1138397 Change-Id: I94d48c9050a37ede90bc57413f166700cea22661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619942 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
siashah authored
When an ItemTag is set on the AutofillBarItem, show an IPH Bubble displaying the ItemTag text with an arrow pointing to the startIcon. The item tag IPH bubble is an educational bubble that explains what the offer icon in a payments chip means. We'd like to show it to the user once(or maybe 3 times at max) and then never show it again. When multiple chips have the item tag set, we want to show the IPH bubble only for the first one. Implementation: https://screenshot.googleplex.com/BhxGYNvfWHBckfV (Note: the Visa icon will be replaced by the offer icon) Bug: 1156916 Change-Id: Ieaa441b1f5474d11b41004b6326e0144dcd272a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600266 Commit-Queue: Siddharth Shah <siashah@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#842218}
-
Yuly Novikov authored
is_component_build is not supported on iOS. We'll need to think for another solution for anglebug.com/4396 there. Luckily it mostly affects SwANGLE. Bug: angleproject:5417 Change-Id: Id94603cada514c697ec7b644113dad051f06fb8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621925Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#842217}
-
ckitagawa authored
FindIt identified this test as being rarely flaky on Linux ASan. As a result, I've expanded the ScopedAllowBlocking to avoid the crash. It looks like if the PostTask didn't run in the scoped block it would sometimes crash. https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjJhNzlmNjFjOWVjMGJmMmRkODQ1Y2RkZjZmYjQ3ZTkyMGIzNTVhNgw Change-Id: I6e6d5252c2c95e3222231442228e4b560a52f0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622321Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#842216}
-
Dominique Fauteux-Chapleau authored
This adds the profile.dmToken and profile.clientId fields on non-CrOS, and also excludes device information from reports when they are profile-specific. Bug: 1159533 Change-Id: I85df025aabfedbea2a295cf02225d0b44ed630a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611546Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#842215}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib9f805eb2ed28dd209d9cb90ce9c1895538a0041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623233Reviewed-by:
-
Jaeyong Bae authored
This patch means adding a comment about itemTag param on addToAutofillSuggestionArray function. Bug: None Change-Id: Ib910310e8a084ede503174969a5d8b3d42ba0c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612258Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#842213}
-
Sven Zheng authored
The job usually get killed after ~80% of all tests. So 2 launcherjobs should get all tests work. Bug: 1164430, 11527703 Change-Id: Ib582a92aafd23cb261561cc772d0842dd63804e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622424 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
Michael Checo authored
Screenshot: http://shortn/_ZUvKuMuDuz Spec: https://carbon.googleplex.com/cros-ux/pages/diagnostics/mvp#db1415fc-6806-4059-958e-459d8da17580 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Iabf38a1d3e4600d9e9d29063d6629e0ed23e5818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567931 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#842211}
-
Miguel Casas authored
ToT V4L2VideoDecoder::Initialize() tries to Open() |device_| with both stateless and stateful formats -- which is fine, but log printouts are confusing, as they read oftentimes like: [v4l2_video_decoder.cc(166)] Initialize(): Found V4L2 device capable of stateless decoding for S264 ... [v4l2_video_decoder.cc(175)] Initialize(): Failed to open device for profile: 3 fourcc: H264 which seems to imply that Initialize() failed, when in reality it worked. Moreover, ToT code checks for |input_format_fourcc_stateful| and |input_format_fourcc_stateless| values and has an else() path that is never reached (l.218 LHS). This CL refactors that code to make evident that the stateful API takes precedence if present and working, sprinkles constexpr names, and takes the chance to improve some loggings using e.g. FourccToString() and GetProfileName(). No new functionality intended. Bug: b/170870476 Change-Id: I6ad00c1ce4d9b8cf2588d7a2751484a743f4225f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616881Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#842210}
-
Clark DuVall authored
There have been no issues on beta, so enabling on stable. duplicated between dex files. Bug: 1105096 Change-Id: I6f586a256c6304612f983e126258ce220b0d6f97 Binary-Size: Increase is unavoidable and comes from symbols being Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572197 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:Richard Coles <torne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#842209}
-
Abigail Klein authored
kLiveCaptionSystemWideOnChromeOS. Introduce a new media switch for the M2 launch of Live Caption. In that launch, Live Caption will run system-wide on ChromeOS, as opposed to just in the browser. Bug: 1055150 Change-Id: I79176e94201edffe541db266422c79e4c264feff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619943Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#842208}
-
Chris Lu authored
There is no need to delay the applicationWillEnterForeground: as part of the main intent logging. Bug: 1161529 Change-Id: Ia5a6226e5ce2547050246410a2b4e3a1a2845e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622851Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#842207}
-
Evan Stade authored
Bug: 1158941 Change-Id: Idcfa8413e11fa8dfaeb9774d7b4451998f137e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612148 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842206}
-
Sophie Chang authored
This uses the suggested mitigation step around retrying until the last file error is not ACCESS_DENIED, as suggested in crbug/1156112#c1 Bug: 1156112 Change-Id: I6e269be3136685cabf029d95d291c71ab2fd0b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622850 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#842205}
-
Danil Chapovalov authored
mutable data() function will be removed to avoid unintended underlying memcpy. Bug: webrtc:12334 Change-Id: Iab9ab9311db2132011b5a21a2b230ed3314aad88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620240 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Auto-Submit: Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#842204}
-
Alex Ilin authored
The label should say "Open [profile name] profile" instead of the less clear "[profile name]". Bug: 1157770 Change-Id: Ief1ceccc1b074b87342cd6b0e19d6ac8d14c7e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621753 Commit-Queue: Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Xiyuan Xia authored
https://crrev.com/c/2590646 fixes the problem by observing Layer directly. It introduces flakiness in ScreenRotationPerf. The screen rotation animates two copied layers and the layers could be destroyed before the reports are received. When that happens, the metric is not recorded. The root cause of the leak problem is AnimationTracker retains LayerAnimator. When underlying Layer is gone, animations are still owned by LayerAnimator and not aborted. Thus, AnimationTracker still thinks it has animations to track. This CL essentially reverts https://crrev.com/c/2590646 and fix the leaking problem by make AnimationTracker not retain LayerAnimator. This allows the animator being destroyed with its layer and the animation callbacks to happen. As a result, HasAnimationsToTrack would correctly return whether there are animations to track when reporter goes away. BUG=1162167, 1158510 Change-Id: Ie2a8191c1abbbc9e57b42090f66014f43fa62bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618518Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842202}
-
Andrey Kosyakov authored
This is a regression test for issue 1164610. Bug: 1164610 Change-Id: I1671fadf581778ddd2d90c310c1574a91ecdd967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621962 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842201}
-
Katie Dektar authored
Change-Id: I282f27a98571606d2ec7d41c186f8a690afffdd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622000Reviewed-by:
Josiah Krutz <josiahk@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#842200}
-
John Abd-El-Malek authored
Poll every 1 second to see if virtual desktops are enabled or not. Since for most users this isn't the case, we can skip calling IsWindowOnCurrentVirtualDesktop altogether. Bug: 1162132 Change-Id: Ib3a89448095186a4b310e88b020dbeb7cd1b6c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602260Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#842199}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f9e9052e7e6f..605183825318 2021-01-11 jophba@chromium.org Set up Receiver and Sender for remoting If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Id2a8d34b8195f0c7c402484ffa076b93a9745d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622788Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bf3659d351a..fff8e7632e28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9f14cf08ff5f233502069bf634934764ac494cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622787Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bdc7f626dbce..026943fd29be 2021-01-11 lalitm@google.com tp: fix include path 2021-01-11 altimin@google.com Merge "[ui] Add support for dynamic tab names" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iedbd62a0b29d86b39a79fe6d9c7f306097642446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622790Reviewed-by:
-
Xinghui Lu authored
Currently there are 10k entries in the high confidence allowlist. It's risky if the allowlist is misconfigured and somehow only a small number of entries are left in the allowlist. In this CL, we check the size of the allowlist. If there is less than 100 entries in the allowlist, we consider it as unavailable and fall back to hash-based check. Bug: 1164555 Change-Id: Ie48bf6197c2255830712b956a886f5deec78fdda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618654 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#842195}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/425c25a8ad2d..002828690efc $ git log 425c25a8a..002828690 --date=short --no-merges --format='%ad %ae %s' 2021-01-11 wub Internal QUICHE change 2021-01-11 bnc Do not use std::string::append(absl::string_view) in QUICHE. 2021-01-08 bnc Implement PRIORITY_UPDATE frame in HTTP/2 decoder. 2021-01-08 quiche-dev Renamed this macro. It's been annoying me for months. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: If8707adfadf1920d5386db50a47f8c2941e7b74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622317 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842194}
-
manukh authored
For |OmniboxFocusType::ON_FOCUS| autocomplete inputs, |SearchProvider::Start()| has a DCHECK to verify that previous requests are done; i.e. |SearchProvider::done_| is true. The omnibox avoids triggering this DCHECK by checking |AutocompleteController::done_| before sending on focus inputs. The realbox previoulsy did not do this; clicking the realbox rapidly resulted in multiple on focus queries and triggered the DCHECK. This CL adds a similar check for the realbox. Bug: 1162870 Change-Id: I8ea8b2102a56cef0ba346c329804664e42cc0fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615663 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842193}
-
Mason Freed authored
Prior to this CL, form restoration could erroneously check the checkbox when the same page was re-opened, but the lines were not wrapped. With this CL, the checkbox will no longer participate in form restoration. This CL also removes word-break:break-word, which is deprecated, and replaces it with overflow-wrap:anywhere. Same effect. Change-Id: I8cfd8014d31376d2fdb7415679666b042ee9dcbc Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612464 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#842192}
-
chinsenj authored
When a user tries to drag a visible on all desks window to a specific desk in overview mode, they are unable to. Currently there is no visual indicator that nothing happened. This CL adds a toast for when this happens and also prevents the desks mini views from highlighting when a user drags a visible on all desks window over the mini views. Test: manual Bug: 1163697 Change-Id: I43acbfb9b90567dbeef294ac97c0e6cc5af33bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616319Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#842191}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610365490-cff9cfe8ee50bd1daf2a4d54676a0415ea568ae4.profdata to chrome-mac-master-1610387594-9644082f15d83cc3788996ee889bd06710e6b3cf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I81bf412b65cae1e4fc80c30718ecea31e8a4634b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622794Reviewed-by:
-
Daniel Libby authored
As not all layouts have been converted to NG, we also need to record painted selection bounds in the non-ng text painting codepaths. This CL adds the ability to compute SelectionState from InlineTextBox, similar to crrev.com/c/2567021 did for NGInlineCursorPosition. This state is then used by SelectionBoundsRecorder along with the selection rect to record the painted selection bounds. Bug: 1065049 Change-Id: I6915783f0c1ffdddd269fe43f729872e1f13e219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597884Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
