GitLab

Fixes sizing when drawing image rep for the target scale - instead of
using the rep's pixel size, use DIP size multiplied by scale (in case
the icon image does not have exact representation for the target scale).

BUG=1018038

Change-Id: Idd184ffa34675816dc7b9a6b9d52eafc6c55c485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888654Reviewed-by: Nic Hollingum <hollingum@google.com>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710865}

Throw an IllegalArgumentException when VisualStateCallback is null. This
will already cause a crash unless calling postVisualStateCallback is the
only method called in the WebView.

This CL effectively reverts http://crrev.com/c/1865155.

Bug: 1014924
Change-Id: I437780f571416e2090591410bc3493a3ffb9ad3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879920Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
Auto-Submit: Laís Minchillo <laisminchillo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710864}

This change encapsulates |addrinfo| in an RAII class and abstracts the
implementation details of invoking |getaddrinfo| from callers. (The callers
still need to know how to use |hints| however).

One helper function moved from host_resolver_proc to the |AddressInfo|
class, and some massaging of error codes from host_resolver_proc was
also moved to address_info.cc.

The actual call to |getaddrinfo| is wrapped in a class with two virtual
calls (eponymously named |getaddrinfo| and |freeaddrinfo|) so that they
can be replaced in unit tests.

Unit tests are added for the code in address_info.cc.

Change-Id: Iada36ebbe0b783cd395f100c4e9d5753b5de2265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760461Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Scott Sheehan <ssheehan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#710863}

This change fixes a bug we had with
AXPlatformNodeTextProviderWin::GetSelection(). When there is no
selection, the range created was always a degenerate range describing
where would be the text insertion point (i.e. the caret) in an editable
text node.
However, according to UIA's documentation, we should only create a
TextRangeProvider and fill the SAFEARRAY with it when the generate range
is on an editable node. Otherwise, the expectations are that the
SAFEARRAY parameter be set to NULL.

Here's a list of what this CL does:
* Fixes the bug in AXPlatformNodeTextProviderWin::GetSelection().
* Adds a test case to GetSelection's unit test.
* Duplicates the implementation of HasVisibleCaretOrSelection() to
TestAXNodeWrapper so we can have the correct result in the unit test.

Bug: 928948
Change-Id: I2577434a5d8ee5ef98eddf1540bfd02df28db380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882298Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#710862}

This is a reland of 099f851f

Original change's description:
> cros: Fix capturing orientation
>
> Instead of setting the rotation as part of the transform on
> ash root window, call viz SetDisplayTransformHint so that
> capturing code as a consumer of viz could get the correct
> orientation.
>
> Bug: 847693
> Change-Id: Id70f91dc84fc9274145d5a160a51b8c7fa50deed
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825892
> Reviewed-by: kylechar <kylechar@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707004}

Bug: 847693, 1016672, 1016980
Change-Id: If609cdaab06874c5b5b4a7fd623ecc00077c0351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876231Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710861}

According to UX, tapping overview background when in split view mode
should be no-op (to go home, the user would have to first exit split
view).

BUG=997885

Change-Id: Ie127e24d61b1741415b989ed85f18853be0c0da4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889313Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710860}

Security UX is experimenting with using a grey triangle warning for
non-secure site connections (crbug.com/997972). When this icon is
shown, DevTools Security panel's security overview should match the
state shown in the omnibox.

crrev.com/c/1857047 swaps out the info icon for a grey triangle
for non-secure connections, so this cl uses the same logic
(factored out into a helper) to determine whether pages with
the NONE and WARNING security states should send Insecure or
Neutral over the DevTools protocol.

crrev.com/c/1881220 (DevTools frontend) should be submitted first.

Bug: 1008218
Change-Id: I524fc43bae2d86bbc5fbe394948c3c29cda21bee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877653Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710859}

In UMA metrics PasswordProtection.RequestOutcome.AnyPasswordEntry, the
Unknown bucket is abnormally high. The reason is that "reason" is not set
when saved password is reused and SBER is disabled.

Bug: 1016540
Change-Id: I382e516f664cbd7b514c0005f4f90e6df607da45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888724Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710858}

Currently we are using StrictMocks in several places which force us to
set several expectations unrelated to what is being tested, making the
code harder to read. This CL updates these cases to use NiceMocks to
solve this issue. Sepcific tests that do care about these mocks can
still use EXPECT_CALL to setup expectations.

This is also consistent with googlemock guidelines [1]:
"""
Our general recommendation is to use nice mocks (not yet the default)
most of the time, use naggy mocks (the current default) when developing
or debugging tests, and use strict mocks only as the last resort.
"""

[1] https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#the-nice-the-strict-and-the-naggy-nicestrictnaggy

Bug: 1018372
Test: Test cleanup only
Change-Id: Ie639f2706f02c9701cb2f4ab2d2ed2658006fb32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879685Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710857}

Bug: 985574
Change-Id: If8722bc3577d245f09c20f814c90e343b800c0fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889300
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: Yun Liu <yliuyliu@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710856}

* I added the pure virtual function HasVisibleCaretOrSelection() on
AXPlatformNodeDelegate so we can use it in AXPlatformNodeTextProviderWin
without a dynamic cast.

* The default value in the AXPlatformNodeDelegateBase is false.

* The implementation is unchanged, but I moved it with other
AXPlatformNodeDelgate overrides.

Bug: 928948
Change-Id: If80c0a441415cb57ea0b4c352132a4d330fb56d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881993Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#710855}

This is to make the name reflect that there aren't just OpenGL tests in
this executable now, there are WebGPU / Dawn tests too.

TBR=zmo@chromium.org

Bug: 1017035
Change-Id: I5f0f04a2082533eda1cd6c474c85214e2195304d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888936Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710854}

This reverts commit 04962c50.

Reason for revert: Test failures, see https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Tablet%20Tester/14131

Original change's description:
> [Android][Signin] Fix bookmark signin promo dismiss tests
> 
> This CL fixes the bookmark signin promo tests when the promo is
> dismissed in different scenarios.
> 
> Bug: 789531
> Change-Id: I852e60cb3e56f9db737cb0e03073d36373908f68
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883628
> Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Commit-Queue: Alice Wang <aliceywang@chromium.org>
> Auto-Submit: Alice Wang <aliceywang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710784}

TBR=twellington@chromium.org,bsazonov@chromium.org,aliceywang@chromium.org

Change-Id: I68d849103de344e495520b8c015edfba75fd6388
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 789531
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890506Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710853}

This patch replaces the remaining custom height accessors in the
BottomSheetContent API with ones that use standard modes. The new
methods remove the need for getCustom* and wrapContentEnabled().
The new methods operate in largely the same way as the existing ones
but consolidate the behavior of other methods and enforce strict
usage via asserts.

Bug: 986310, 1002277
Change-Id: I4bdd594d2270bad849c41721586aa1351daa0c6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885221
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710852}

Fix typo (serivce -> service) in src/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java

This CL doesn't change any behaviors. This just fixes typo.

Bug: N/A
Change-Id: I3d7960bbc5e4d9c04a32e1a7248bfeae6e7d9418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882189Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710851}

This CL resets the configuration for animations (opening and closing)
and for swipe-down-to-dismiss to the defaults. That means ideally:
* the sheet scrolls into view when opened
* the sheet scrolls/fades out when closed
* the sheet is NOT dismissed by swiping down hard enough

In practice, only one parameter has a current effect:
* the sheet scrolls into view

The dismissing is slightly over-sensitive and a closing animation not
visually perceivable.

Bug: 957532
Change-Id: I7a7044ddd98e79518a6e8ffdfd2ac9b276f14722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890040Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710850}

This reverts commit 011e523c.

Reason for revert: Tests are failing, see https://ci.chromium.org/p/chromium/builders/ci/android-pie-arm64-rel/1637

Original change's description:
> AW UMA: integration tests for more metadata fields
> 
> No change to production logic.
> 
> This adds tests for already-implemented UMA proto fields. This
> intentionally skips fields which don't apply to Android OS (ex.
> os.is_jailbroken, os.arc, os.kernel_version).
> 
> Bug: 1011991
> Test: run_webview_instrumentation_test_apk -f AwMetricsMetadataTest.*
> Change-Id: I35fe2b75164a421a9a5dbc80df621f75ec9b5474
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889171
> Auto-Submit: Nate Fischer <ntfschr@chromium.org>
> Reviewed-by: Changwan Ryu <changwan@chromium.org>
> Commit-Queue: Nate Fischer <ntfschr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710655}

TBR=changwan@chromium.org,ntfschr@chromium.org

Change-Id: If3f131a153ccb86497595db98ff9bbe466ee6dd4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1011991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890503Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710849}

WebLayerShellActivity currently serves two purposes.
* As a demo app for weblayer where user can type in a url and expect it
  behave somewhat like a browser.
* As the target activity for instrumentation tests.

Keeping both purposes in the same activity is a maintenance burden and
makes the more complicated than it needs to be. This CL creates a new
InstrumentationActivity (copied from WebLayerShellActivity) and removes
code from both Activity that's needed for their purpose.

Also rename WebLayerShellActivityTestRule to
InstrumentationActivityTestRule.

Change-Id: I306fecb57ed15ee7a59487ced40262094ef7c438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888451
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710848}

It needs to link against Blink to use blink::MainThreadIsolate()

Bug: none
Change-Id: Ib99bebbcb421d566a55dc491603c61c3299639d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890005
Commit-Queue: Evan Stade <estade@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710847}

Follow up cl/1883717

These are nits that were not fixed in the previous CL.

Change-Id: I2cf131c9584af0e1b23049a1b53a3b7268f3d8f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890082Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710846}

base::ProtectedMemory is being deprecated because it's not widely used
enough to make a security impact and justify its maintenance burden.
Replace use of base::ProtectedMemory with raw function pointers and place
thunks.cc in the CFI-icall blacklist as there are too many functions to
individually add NO_SANITIZE attributes for.

Bug: 1018834
Change-Id: I0bd1f25480e7b77fef4898eaeedfd9fa64d3e4e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889511Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710845}

Bug: None
Change-Id: Ie5c9d865aac587f5fb9c6a54489ead2d4c853a5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891030Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Auto-Submit: Lily Chen <chlily@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710844}

I noticed some accessibility tests need to be blacklisted on Linux,
presumably they don't run on the Linux CFI bot by default.

Change-Id: Idd2bffd6dc16a24a64d70d466ffa50fbe106a5e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888716
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710843}

This CL makes it clear for UMA dashboards which data types are
deprecated.

Bug: 1007293
Change-Id: Iff69e9aace9627f288d3ba871a848cb29b32a7e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889978
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710842}

Bug: 1015805
Change-Id: I5aa38c1ca058bb02b1868cd30b4380b0f0fe0615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890335Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710841}

Bug: 1018350
Change-Id: I8c0091f1925d0ddcfba806b1adf09b18c86d5cdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880806
Commit-Queue: Yusuf Sengul <yusufsn@google.com>
Reviewed-by: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710840}

SingleClientUserEventsSyncTest.Encryption and
TwoClientSessionsSyncTest.NoHistoryIfEncryptionEnabled used
EnableEncryption(), which only works with Directory implementation of
Nigori and outdated. They were rewritten to enable custom passphrase
instead.

Bug: 922900
Change-Id: Ia5fedeae5b7c7071c1ecc82063e5742934caf2e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890316
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710839}

Not all services have been rewritten to not require side swipe
detection from cast platform. Re-enable for now.

Bug: internal b/143545462
Test: manual
Change-Id: I35f2493e3f2379f239da1a15de867ed71809e8e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890008Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710838}

Add a redirect chain similar to that being used for ResourceTiming. More
images along with TAO will be added in a followup.

Bug: 1003943
Change-Id: I07a98e6f3b574a1241f33aed60a6bb71e0240a95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880539Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710837}

PageInfoHoverButton repeats some of its parents' Layout operations such
as those from View and LabelButton. But it also tries to skip
HoverButton and LabelButton's custom layout functions by directly
calling into Button's Layout(). Now, HoverButton no longer has a custom
layout function, LabelButton's custom layout is being removed, so we
should get rid of custom layout here too. Additionally, calling
LabelButton's custom layout will still be correct as the label and image
both are empty.

BUG=1005568

Change-Id: I0bba3bcc1c198b2c0ede90dff3894b8acdca1ba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888398Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710836}

Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1890410

Fixed the includes.

Bug: 1018129
Change-Id: Icf2f66ba71bb723bb495ec6ab756fcae5a1f59a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890314
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710835}

VEA unittest fails if VEA cannot produce a bitstream buffer in three seconds
from the previous bitstream buffer. Three seconds seems sufficient but we see
the flakieness on low end devices. This CL lengthens timeout to 10 sec in order
to figure out if it is a real failure or just low performance.

Bug: 1019307
Test: None
Change-Id: I103d8e32fb444dbe2576db0af815714af7def49f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890450
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710834}

It's not used anymore and doesn't even have a corresponding .gn entry.

R=skyostil@chromium.org

Change-Id: Ic069df8a5ab7e58950c269513ac4a2eedc3c11cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890079
Auto-Submit: Alexander Timin <altimin@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710833}

This avoids passing vector* to the function, slightly improves
callsite readability.

Bug: 796395
Change-Id: Ic7e6139d3ea2c9044fc6d7b6b668998c8a370ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869675
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710832}

TEST=run_webview_instrumentation_test_apk --num_retries=0 --repeat=1000 --break-on-failure -f=AwSettingsTest#testJavaScriptPopupsOpenTwice

Bug: 957626
Change-Id: I160f8a816a6190dfb0962c80c2d86d3e5d2410e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875484Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710831}

This will stop TabManagerDelete to call TabActivityWatcher, hence
disable tabdiscarder completely.

Note: we can still do experiment from Finch.

Bug: 1017222
Change-Id: I064004ae6e0e67d2df0133c98626c395db73f6db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888863
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710830}

Bug: 1019655
Tbr: wfh@chromium.org
Change-Id: I8da163839261e087d68d2d958b22dd99967efc34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890816Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710829}

This reverts commit 627a3abc.

Reason for revert: Fails on multiple bots, see crbug.com/906739

Original change's description:
> Removing OVR_multiview2 suppressions
> 
> Bug: chromium:906739
> Change-Id: Ibbd8715c900220242d44ddfef51449b155f81c43
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877610
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Commit-Queue: Mingyu Hu <mihu@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#710516}

TBR=rafael.cintron@microsoft.com,kainino@chromium.org,mihu@microsoft.com

Change-Id: If22b20c4b5dd8fdf6d6368a02db82125d75d055f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:906739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890991Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710828}

This reverts commit 38f657d5.

Reason for revert: https://crbug.com/1019614

Original change's description:
> Convert extensions to use the URLResponseHead mojom types.
> 
> Bug: 984550
> Change-Id: I885fc575b49c4049b83b17cc4c2248daf2525b4e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876974
> Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> Commit-Queue: Lucas Gadani <lfg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709596}

TBR=lazyboy@chromium.org,karandeepb@chromium.org,lfg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 984550, 1019614
Change-Id: Icd7e03b4c65514f49916fbbba57501cc49d400af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890006Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710827}

An inspection shows that these are no longer sent nor handled.

Change-Id: If9b60f55d4dc07bb7a0ad573acb67f7e66609a3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888690Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710826}