GitLab

PEImage and PeImageReader are similar classes with slightly different
behaviors. This change updates the comments to clarify how they differ.

Change-Id: Id09868324b93d5a44731f778fb3f7684ca77736f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336303Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795188}

Test flakes on TSan.

TBR=rogerta@chromium.org

Bug: 1113376
Change-Id: I6f0b868e85c86c7994ae8e3eedb67869cb165c20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340101Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795187}

Use consistent output dir detection from constants. See
build/android/list_java_targets.py as an example.

Bug: 1092528
Change-Id: I6392293a2b036ae419e1dc062e8c6f573fb7640d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339763
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795186}

Using wpt-import in Chromium 2914c6e6.
With Chromium commits locally applied on WPT:
dfdc7fe9 "[WPT] Errors caught/reported for importScripts()"
27a0731b "Origin isolation: add WPTs for contentDocument/frameElement"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=smcgruer@google.com

No-Export: true
Change-Id: I42b165b6e527a04854b0e257043c76a3c7ab3438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339222Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795185}

As part of UX discussions, the filter list is now a list of nodes that
can be used in the filter. Whether a node is actually in the filter or
not is toggled by its checkbox. "Select all" and "Deselect all" buttons
have been added to make checkbox manipulation easier.

A node enters the filter list through the filter input or the node
details panel. It always enters in the checked state. A node exits the
filter list through the user manually clicking the x beside it. Once in
the filter list, the node's filter visibility can be toggled by a
checkbox beside it or through the node details panel.

Checkbox information is also encoded in the URL.

Bug: 1111836
Change-Id: If92d64a9bdcfc93d6b86d1a335b795a5ab628c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333066
Commit-Queue: James Long <yjlong@google.com>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795184}

Many times, high data cache miss rates and data TLB miss rates have
root causes far removed from the function where the miss is actually
occurring. Having callstacks, helps us understand data access
and allocation patterns with poor locality.

To set sampling intervals, I followed the pattern used for cycles flat
vs. callgraph, where the latter has a 4x larger sampling interval.

For DTLB miss cycles, we are currently collecting about 2x more samples
per report than for other events, so I increased the sampling interval
by 2 * 4 = 8.

For LLC misses, we are collecting about 2x less samples per report than
for other events, so I increased the sampling interval by 2.5x, more
than 4 / 2, to be a bit conservative.

Also increased samping interval for iTLB misses by 1.5x, as they are
at the upper end of acceptable samples / report.

BUG=b:162350244

Change-Id: Idd7d29d2e7535f3ddf99470d1980da14fccdcff9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339827Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Gabriel Marin <gmx@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795183}

This defines a handful of MultiToken<> variants (and their mojom traits)
that will be used in renderer code, as well as in renderer to browser IPC.

BUG=1085129, 1096617

Change-Id: I548ecfe2824d2a8e78c0af8a197abebf2ab6fc41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337104
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795182}

Fix a couple instances of "master". As of this CL, the following terms
no longer appear in //ash -- master, slave, white_?list, black_?list.

Bug: 1097644
Change-Id: I02f59e12cf587c97c7c12f88f00fac2a468e3cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339926
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795181}

Suspecting that the test was flaking because of
https://crbug.com/1111525, which is now fixed.

Bug: 1111530
Change-Id: I5e68c2fc23155ad3eac608fa5d1b167720b665c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339814
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795180}

Original patch: crrev.com/c/2319538
First reland: crrev.com/c/2333648

Changes in this patch (https://chromium-review.googlesource.com/c/chromium/src/+/2336301/1..10)
1. Fixed use-after-free of ContainingBlockScope. Similar to the first
   revert, the issue was because it was allocated in
   PaintInvalidatorContext which is in a vector replacing the real stack.
   ContainingBlockScope::outer_ might point to an invalid address if the
   vector was reallocated. Now use std::unique_ptr<ContainingBlockScope>
   in PaintInvalidatorContext. This increases the cost a bit but not much
   because ContainingBlockScope is created for LayoutBlockFlow with
   inline children only.
2. Rebased on crrev.com/c/2335647 which avoids memory regression caused
   by the original CL, and enables LayoutShiftTracker to use more
   accurate previous rects for shifted boxes.
3. Simplify LayoutShiftTracker::ReattachHook[::Scope].

Bug: 1108622
Change-Id: I7b4a85675483f7006ade8925c159a7882f08ec27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336301Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795179}

* The C++ side of the Chrome cleaner child immediately condenses the
  received states to the ones that are relevant for the child. This
  reduces complexity on the JS side and simplifies recording metrics.

Bug: 1087263
Change-Id: I4e2f8400be863c7a7c0c83e35ce2ba4856372c62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328665Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795178}

Bug: 1113367
Change-Id: If85efce44c5b84c41949c80534dc6a40d418016d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339548Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795177}

Roll Chrome Win32 PGO profile from chrome-win32-master-1596635955-2b1d31dacdbaf52cf854414e21cd977f1d32db43.profdata to chrome-win32-master-1596643173-1c5e3b62f80a4dd3f16924cb334ea677bc923f5e.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I13d20081550abb91d26374dded504b023ff97b8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339541Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795176}

In order for the global media controls dialog to display the currently
used audio device in the UI the renderer needs to report what device is
in use. Currently, MediaWebContentsObserver will receive messages when
the output device is switched. However, the device id reported by the
renderer is hashed so that it may be only used on one origin.

This change has the MediaWebContentsObserver translate the device ID
before passing it off to the MediaSessionControllersManager.

Bug: 1111432
Change-Id: I11d161ff5f89525b4c465f01a779bdd30e31c823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331330
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795175}

https://pdfium.googlesource.com/pdfium.git/+log/fa9a15cb008b..fe8e758b920c

2020-08-05 thestig@chromium.org Rewrite OS_LINUX define.
2020-08-05 thestig@chromium.org Rewrite is_linux GN flag.
2020-08-05 tsepez@chromium.org Rename CXFA_NodeHelper to CFXJSE_NodeHelper and move to fxjs/
2020-08-05 thestig@chromium.org Roll tools/clang/ 6cbea33c9..1078c4141 (10 commits)
2020-08-04 thestig@chromium.org Use |kAA| instead of "AA" string.
2020-08-04 thestig@chromium.org Remove some dead CPDF_FormControl code.
2020-08-04 thestig@chromium.org Roll third_party/zlib/ f87c8e288..7492de9a5 (3 commits)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1110266
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I857a1b9d415c8bd425194f933c82e65081afe49e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338923Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795174}

This change makes Trusted Type policy enforcement to Perfect types
(i.e. `require-trusted-types-for 'script'; trusted-types;`) by
default for WebUI (while still keeping report-only).

This means WebUI will not be able to use unsafe APIs by default (e.g.
innerHTML, document.write, etc). However, I have removed Trusted
Types CSP from a pages where it does not support Trusted Types yet
(e.g. Polymer 3).

This change will not make any observable changes, as report-only CSP
would only log console error when it detects Trusted Types violation.

Bug: 41905
Change-Id: Ib9d6eae53b600123c1837d2cdc56269c14a8d00f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234238
Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795173}

The current implemnetation of GetMediaDeviceIDFroHMAC accepts a
blink::mojom::MediaStreamType to distinguish between audio and video
devices. However, it is not able to distinguish between audio input and
output. Currently, this method will assume input.

In order to allow this method to work with audio output devices this
change introduces an overload that accepts a blink::MediaDeviceType
instead of a stream type.

Bug: 1111585
Change-Id: Ie7111665f8cd3d24a360bff28d2da56c7ddfaacb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330741
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795172}

Bug: 1113284
Change-Id: I63092930726af55e45b1878850de540a09d9ad69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339700
Commit-Queue: Dan H <harringtond@chromium.org>
Auto-Submit: Dan H <harringtond@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795171}

See attached bug for rationale and example screenshots.

We went from only making the change on Windows to making it on all
platforms because the difference isn't jarring but makes a positive
change in readability in almost all cases while maintaining the correct
font height for the badge.

Bug: 1111648
Change-Id: Ife6f126238489f11ead564ddf8f123de100a9d59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331296Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795170}

This CL introduces a new Finch flag, SafeBrowsingRemoveCookies, which
controls whether certain communications with Safe Browsing to attach
cookies. This was previously being shared with the
SafeBrowsingSeparateNetworkContexts Finch flag, which was misleading.

Bug: 1049833
Change-Id: If5f375fb146a1afe5669fc22f5b863bcfdd096c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337253Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795169}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: I8cac684b50d2ed3d2ba61cbc75ca2e67c0f3ea2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339938Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795168}

This is so WebLayer can use it to support NoStatePrefetch.

Bug: 1096088
Change-Id: If0986e4e2eb43960bd19c4d43b1272c1803dfd1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336082Reviewed-by: Kevin McNee <mcnee@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795167}

https://docs.google.com/document/d/1SWAM_6e1Tk4UexJ1QuZJUtfXCQEqRfAQT_mfkSqBJqM

Bug: 1112872
Change-Id: I387fb3f0f7d96b0dc92cd5494668b29735d870e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339925
Auto-Submit: Fred Mello <fredmello@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795166}

These will not actually be executed, but should be isolated, which is
useful for the testing team.

Bug: 1106083
Change-Id: Ie9094bf7eaa70dd0a130ccb747c7f64d8f5bdffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339921
Auto-Submit: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795165}

There should be no behaviour change.

Change-Id: I972509c2ce8e28dcd6542b0b9531d1c0a961dd1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244971
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795164}

This reverts commit 77cd5d73.

Reason for revert: pinpoint shows only regressions.

Original change's description:
> heap: Minor marking tweaks
> 
> 1) Traces show that it can take a relatively long time before Oilpan
>    starts flushing v8 references (e.g. ~10 steps spent just on the
>    bailout worklist). This CL moves v8 references flushing before
>    processing of the bailout worklist.
> 2) Traces also show that a shorter duration for the first marking step
>    can suffice.
> 
> Bug: 986235
> Change-Id: If7bad026e91f1fdf1899035bda049834e7bffab5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339356
> Commit-Queue: Omer Katz <omerkatz@chromium.org>
> Commit-Queue: Anton Bikineev <bikineev@chromium.org>
> Auto-Submit: Omer Katz <omerkatz@chromium.org>
> Reviewed-by: Anton Bikineev <bikineev@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#795059}

TBR=bikineev@chromium.org,omerkatz@chromium.org

Change-Id: I36bbadafcfe91a4f725537975ec06b1a9ac10e0a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 986235
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340040Reviewed-by: Omer Katz <omerkatz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795163}

Currently, the identity internals debugging page does not display the
account ID that the token belongs to. This information may be useful to
list for debugging cases where multiple accounts are involved.

This CL adds the account ID for each cached token to the Identity
Internals page.

Bug: None
Change-Id: I704748f2521cb34c96ed7ccade0fdac6e99d01dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333545
Commit-Queue: William Lin <williamlin@google.com>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795162}

Targets the new driver and Windows versions for the GPU Windows 10
Quadro P400 machines in preparation for an upcoming upgrade.

Bug: 1085489
Change-Id: I4dffa9fe085fa96dc3ad3e73bb981314195f98e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340000
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795161}

Design doc go/chrome-sync-merchant-offers.

Start with implementing only the protobuf changes since they are in
kind of a finalized state and this CL can unblock impl on GMSCore.

Bug: 1112095
Change-Id: I27705f467424d614c80b4dd03ae5207e112e4c32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333870
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795160}

This reverts commit 4856b612.

Reason for revert:

New test is failing on windows asan.
https://ci.chromium.org/p/chromium/builders/ci/win-asan/13719

[ RUN      ] All/DumpAccessibilityEventsTest.AccessibilityEventsAriaHiddenDescendantsAlreadyIgnored/win

DevTools listening on ws://127.0.0.1:56078/devtools/browser/cb8ef55e-fd6c-40c9-9bb9-69a6e2f10a39
[3056:12476:0805/095807.582:ERROR:browser_test_utils.cc(712)] No committed entry.
[3056:12476:0805/095810.629:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged
[3056:12476:0805/095810.629:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kLayoutComplete
[3056:12476:0805/095810.629:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kLoadComplete
[3056:12476:0805/095810.693:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged
[3056:12476:0805/095810.694:ERROR:dump_accessibility_events_browsertest.cc(103)] === IsRecordingComplete#1 run_until size=0
[3056:12476:0805/095810.703:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged
[3056:12476:0805/095810.856:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged
[3056:12476:0805/095810.857:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kEndOfTest
[3056:12476:0805/095810.866:INFO:dump_accessibility_test_helper.cc(93)] Testing: C:/b/s/w/ir/content/test/data/accessibility/event/aria-hidden-descendants-already-ignored.html
[3056:12476:0805/095810.867:INFO:dump_accessibility_test_helper.cc(95)] Expected output: C:/b/s/w/ir/content/test/data/accessibility/event/aria-hidden-descendants-already-ignored-expected-win.txt
[3056:12476:0805/095810.867:ERROR:dump_accessibility_test_helper.cc(127)] Diff:
* Line Expected
- ---- --------
     1 EVENT_OBJECT_HIDE on <div#heading-root.a> role=ROLE_SYSTEM_GROUPING name="Heading" INVISIBLE level=2
     2 EVENT_OBJECT_REORDER on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL
*    3 IA2_EVENT_TEXT_INSERTED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL new_text={'<obj>' start=0 end=1}
*    4 IA2_EVENT_TEXT_REMOVED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL old_text={'<obj>' start=0 end=1}

Actual
------
EVENT_OBJECT_HIDE on <div#heading-root.a> role=ROLE_SYSTEM_GROUPING name="Heading" INVISIBLE level=2
EVENT_OBJECT_REORDER on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL
EVENT_OBJECT_REORDER on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL
IA2_EVENT_TEXT_INSERTED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL new_text={'<obj>' start=0 end=1}
IA2_EVENT_TEXT_REMOVED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL old_text={'<obj>' start=0 end=1}
IA2_EVENT_TEXT_REMOVED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL old_text={'<obj>' start=0 end=1}
<-- End-of-file -->



Original change's description:
> Fire WIN HIDE event only on ignored ancestor
> 
> Google drive expand/collapse state is not being announced due to
> excessive HIDE/SHOW/REORDER events flooding NVDA, and NVDA end up
> discarding most events.
> 
> For example, if aria-hidden="true" is set on an ancestor node, which
> would cause that node many of its descendants to be set to IGNORED
> state which triggering too many EVENT_OBJECT_HIDE and causes NVDA
> to drop the events. In reality, we only want EVENT_OBJECT_HIDE to be
> generated on the ancestor node where aria-hidden="true" is set, so
> not to flood and confuse NVDA with excessive events.
> 
> This change fixes the above issue by firing EVENT_OBJECT_HIDE on the
> root should the entire subtree changes to IGNORED state.
> 
> Suppressing excessive SHOW/REORDER events will be addressed in follow up
> patches.
> 
> AX-RelNotes: NVDA can now announce Google drive "My Drive" expand/
> collapse state.
> 
> Bug: 1019420
> Change-Id: I4fdabd6740630a149c1b22cdb3180d2f75807b10
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309450
> Commit-Queue: Victor Fei <vicfei@microsoft.com>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#795017}

TBR=dmazzoni@chromium.org,aleventhal@chromium.org,Adam.Ettenberger@microsoft.com,vicfei@microsoft.com

Change-Id: I4354e1effb7b3fe4a01caef00f696513ecaacbbc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1019420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339828Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795159}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1e0d126c..10ee7644

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie2ff859c44254929e07512ccd23568fbf659e4e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339794Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795158}

Bug: 1015746
Change-Id: I5862995d37ae067664304f57562460c46d51c811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339518Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Thomas Tellier <tellier@google.com>
Cr-Commit-Position: refs/heads/master@{#795157}

The media session controller will now notify the media session of audio
device switching. Upon receiving this message, the media session will
update the MediaSessionInfo to include the device id and notify its
observers.

Because it is possible for a media session's players to be using
different audio devices, a device is only added to the info object if
all of the sessions players are using the same device.

Bug: 1096251
Change-Id: I280387991b333eff60141e38e119eff7444aebb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324406
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795156}

Introduces new metric recording outcome of every Omnibox focus event.
Logged result will allow us to monitor for increase in abandoned
interactions as we introduce new suggestion types.

Bug: 1105156
Change-Id: I0b12e8cfa748e6a33f1d44e96ade77bf0b39cdd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329878
Commit-Queue: Ender 💬 = 🕐 (ping me for faster reviews) <ender@google.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795155}

AndroidBatteryMetrics required an application state change before
switching from UNKNOWN to the current state, which prevents it from
recording metrics on browser startup immediately.

This CL changes the behavior to check the application state on
startup, so that recording can begin immediately.

Change-Id: Iaec5a175ea3f367b30d1fd95414dcc5e67573315
Bug: 1113311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333090
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795154}

Bug: 1059389
Change-Id: Ifcd3c119d779503d4a2f8a9bd8046b6ce7272951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339205Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#795153}

r793989 crrev.com/c/2332083 caused a test in `virtual/
layout_ng_block_frag` to hit DCHECK failure in
|NGInlineCursor|, and probably caused two flakes in
crbug.com/1112237 and crbug.com/1112289.

r795011 crrev.com/c/2313736 supports block fragmentation in
|NGInlineCursor|. This patch removes these DCHECK failiure
expectations.

Bug: 829028, 1112237, 1112289
Change-Id: I637ad65e2143d7506a570c8edf91edb36e26ad47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339697
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795152}

This CL is fixing a crash related to cursor movement (line)
when a single-line RenderText has newline.

The unittest added is crashing without the fix.

The problem is the following:
  1) In single-line, newline codepoints are rewritten
  2) The whole text will be in the same run (same Line).
  3) The cursor movement function are looking at the original
     text to detect a newline.

SEE:
  RenderText::GetAdjacentSelectionModel(...) is calling
  |-> LineSelectionModel(GetLineContainingCaret(current), direction);

But it has an incorrect line number, since:

  RenderTextHarfBuzz::GetLineContainingCaret(...)
  |-> LineIndexForNewline

The function is looking at the original text!

R=msw@chromium.org

Bug: 1108254
Change-Id: I656cd8a4b0a5d5d77e074249425c5821860d3e5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339385Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795151}

This adds a search bar to filter flags. To match the apparent behavior
of chrome://flags, this accepts any flag which contains the query as a
case insensitive substring of either the flag name or description.

If the user has any (non-empty) query, this will also filter out the
warning message, since this is just getting in the user's way.

This imports the material search icon (magnifier glass).

Bug: 1052345
Test: Manual - verify the search bar works as expected
Test: run_webview_instrumentation_test_apk -f DeveloperUiTest.*
Change-Id: I80db4b7325d9c931f622f9f37d969350865115b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330310
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795150}

Implementing a pref so that printing a web page can be disabled.
The print option will not show up in the "share" action sheet if
the policy is disabled.Also will disable any other entry point such as
Javascript window.print().

Also added the unit tests associated with the new pref.

Bug: 1066482
Change-Id: I3167f941bc2f192600d359a75a8bd844ffc2fc84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337715Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Andy Lu <andyhylu@google.com>
Cr-Commit-Position: refs/heads/master@{#795149}