- 27 Jan, 2020 40 commits
-
-
Ian Clelland authored
Bug: 993790 Change-Id: I7d90f98cd3a2b1ef63441a39ed51512b8068c927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015782Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#735412}
-
Xi Han authored
The FeatureUtilities#isAllowToRefetchTabThumbnail() checks ChromeFeatureList and requires initializing native. In this CL, we make this function to check a cached value. Thus, this function can be called before native is initialized. Bug: 1041865 Change-Id: I029f18ffe96eeb8f3d997775c51662363e9aac26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011166 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#735411}
-
Peng Huang authored
In low end device mode, the GLContext is created to be compatible to GLSurfaces with RGB565 format. Right now, SkiaOutputSurfaceDependencyImpl::CreateGLSurface() creates GLSurface with default format which is RGBA8888. It isn't compatible to the GLContext. It causes MakeCurrent fail. Bug: 1033170 Change-Id: Id372e0dee73a01b8e7511bbef6740481b890d742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016338Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#735410}
-
Boris Sazonov authored
Disables StartSurfaceLayoutPerfTest#testTabToGridFromLiveTabWith10TabsWithoutThumbnail on L and before. Reason: flaky. TBR=wychen@chromium.org Bug: 1045938 Change-Id: I4f508e7005d0cc558308a53851b2541d31e9c766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022647Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#735409}
-
chrome://omniboxmanukh authored
The debug page compares response and request inputTexts to prevent async responses for old requests from being shown. This comparison did not consider that responses' inputTexts are trimmed of whitespace. This CL likewise trims the requests' inputTexts when comparing the two. Bug: 1045343 Change-Id: I0e0553fcb2c6d9c21cd5c10194b769120824b6a9 NOTRY=true To skip android-binary-size bot due to a bug (crbug.com/1045024). Other try-bots have passed. Change-Id: I0e0553fcb2c6d9c21cd5c10194b769120824b6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019927 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#735408}
-
Ali Juma authored
This CL builds PingManager and VerdictCacheManager on iOS, and makes the corresponding unit tests run as part of components_unittests on iOS. To make the VerdictCacheManagerTests pass on iOS, this CL also modifies WebsiteSettingsRegistry so that ContentSettingsType::PASSWORD_PROTECTION and ContentSettingsType::SAFE_BROWSING_URL_CHECK_DATA are registered as settings on iOS. Bug: 1028755 Change-Id: Ia364f1c782b6612c7f41f73f87f3f2493ed6ac33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020551 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#735407}
-
Dominik Röttsches authored
When font-optical-sizing: is set to auto (the default) do apply a value to the opsz axis even if font-variation-settings is not explicitly specified. TEST: virtual/text-antialias/mac-system-ui-trak.html Bug: 1005969 Change-Id: I4baf448c6bc465b98eda4cf2538f3ef48e9c5ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020767 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#735406}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0deb202d1620..a3114e177561 Created with: gclient setdep -r src-internal@a3114e177561 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iadd84ab9c8d9c902c9681639cb2294b559fa2140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021972Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735405}
-
Dominik Röttsches authored
Add null check for font-variation-settings, rephrase reconfigured and found axes. TEST: virtual/text-antialias/mac-system-ui-trak.html Bug: 1005969 Change-Id: If235b4518c801fe46bd5a7deb64d102310bc50f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022709 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL adds a missing integration test that checks that wallet data gets properly replaced by sign-out and sign-in to a different account. Technically, the test does not sign in to a different account, only replaces the data on the fake server as the server anyway does not distinguish users. Bug: 972181 Change-Id: I5ac89bf232bddbebd81a831bb405a0d1a2bf0147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012953 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#735403}
-
Miyoung Shin authored
This CL recreates the |permission_service_context_| on-demand in RenderProcessHostImpl::CreatePermissionService to avoid accessing the nullptr. Bug: 1036779 Change-Id: I1f464de70a6e4b281380b9b83fee06e012831236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014720Reviewed-by:
-
Himanshu Jaju authored
Tests flow for adding remote ice candidates received and checks if histogram samples are reported correctly for the scenarios. Bug: 1031147 Change-Id: I35536e4068b7f5b564865cd2d02acb099fb658c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019268Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#735401}
-
Greg Thompson authored
MigrateShortcutsInPathInternal uses the command line within a task bar pin to determine the pin's expected AppId. If the command line in the shortcut contains "--user-data-dir" without a value, Chrome itself ignores the switch and uses the default. This change does the same for the AppId calculation in MigrateShortcutsInPathInternal. BUG=1045019 R=gab@chromium.org Change-Id: Ia337c6d0d30fed1525e97e341b0ae4b0e5edef15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022788Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#735400}
-
Boris Sazonov authored
[Sheriff][Android] Disable PaymentRequestMultiplePaymentInstrumentsTest.testCreditCardSuggestionOrdering TBR=sahel@chromium.org Bug: 1045923 Change-Id: Iba072fd223f984f9be79ae86e9ba3aba4ace3c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020777Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0fb0a21bd999..732248c2f1dc git log 0fb0a21bd999..732248c2f1dc --date=short --first-parent --format='%ad %ae %s' 2020-01-27 nifong@google.com Use html tags instead of markdown for images in debugger user guide Created with: gclient setdep -r src/third_party/skia@732248c2f1dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I1fb78b6cb1a72abe9acad5d5c84299c7d32f90ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021971Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735398}
-
Mohamed Amir Yosef authored
This CL is one of many refactoring CLs that would split the ManagePasswordsBubbleModel into different controllers one per view. Bug: 1044034 Change-Id: Ic4ee0a4bbf79c4a28f2434ebd8dacb1733bc690e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019265Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#735397}
-
Adithya Srinivasan authored
This CL adds a new accessibility role (kPortals) for portals, which is eventually implemented as a button on platform implementations (with the exception of ChromeVox, impl will be in a follow up). This CL also omits a portal's AX tree from the root AX tree. Change-Id: I2b6b27d7c2d04116e7e4cfa23792bbd1188d7628 Bug: 1045608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980898Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#735396}
-
Hiroki Sato authored
CHROMEOS macro is defined in third_party/webrtc. This CL replaces it with more appropriate macro. Bug: None Change-Id: Ib027e5f8c35f5318919f515d97a22d3991607ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022126 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735395}
-
Dominique Fauteux-Chapleau authored
Following discussion in crrev.com/c/1991710 about using dark mode PNGs, the preferred approach is using color_utils::IsDark() instead of GetNativeTheme()->ShouldUseDarkColors(). Change-Id: I821e28edb287715293b3eb8fb4a59b4b15337c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019782 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#735394}
-
Omer Katz authored
This CL simplifies Node tracing logic and avoid manual write barriers without increasing size of neither Node nor NodeRareDate. Note that size of NodeRenderingDate does increase, but isn't prohibited. Bug: 986235 Change-Id: Ifd9795db150346fdf85710c6ce8eeaf5841c8776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019106Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#735393}
-
Jacobo Aragunde Pérez authored
This would be translated to ATK_ROLE_ALERT by the auralinux accessibility code. Assistive technologies are expected to respond to this role by reading the contents of the ALERT container. Bug: 1023822 Change-Id: I763ee4047c8ba4fb09f2e77f9ddc9f6e8eaabbe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010846 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#735392}
-
Dominique Fauteux-Chapleau authored
The added images support dark mode and vary depending on if the data being scanned is "text" (dragged web content or pasted text) or an "upload" (dragged file or file upload via a dialog). Bug: 999145 Change-Id: I7f4e583bedf92a308dcc65b90f9c7714b0c891e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991710Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1dc09c63. With Chromium commits locally applied on WPT: 82459860 "SharedWorker: Add WPT for testing data URL" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1b2d962b40641804a1c56b1a440c79adda27fb31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020844Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735390}
-
Yi Gu authored
AttachCompositorTimeline requires a compositor_animation_ which can only be created during Animation::PreCommit(). Bug: None Change-Id: I8fea8c9f787ad07fe77e3aaebedaa3bcbf9c5098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019470Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735389}
-
Andrew Solovey authored
Extract header ASCII graphic emitting code (WriteAsciiHeader) out of the histogram content drawing method (WriteAsciiImpl) to add more flexibility in style setup. Rename method [WriteAsciiImpl] to [WriteAsciiBody]. Move newline symbols to constants. R=dcheng@chromium.org, sinhak@chromium.org Bug: 1006447 Change-Id: If4af4c82efffaca10a0c34a9bb8abc98000235b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019204 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#735388}
-
Rushan Suleymanov authored
Add switch to fallback to default latency value. Bug: 1034928 Change-Id: I5b4bf1bb5e3d80ab854b1c6b9758c4c06c26152f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022765Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
After the last cleanup, https://chromium-review.googlesource.com/c/chromium/src/+/2007285, syntax check for policy template does not work as the newly related ArgumentParser does not support taking type='string'. Bug: 1032064 Change-Id: I2d0f87781f402bbf3867590ceeed8147743c4d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022025 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#735386}
-
Xida Chen authored
Bug: 1042205 Change-Id: Iac11eb940802a21ef012adc92f33fc880a3d3922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022727Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#735385}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/995992bed045..0deb202d1620 Created with: gclient setdep -r src-internal@0deb202d1620 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042208 Tbr: jbudorick@google.com Change-Id: I24c0c4dab89b1cde5df3eada3ef0dad1f7c0426e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021968Reviewed-by:
-
Andrew Solovey authored
Extract header ASCII graphic emitting code from [WriteAsciiImpl] to add more flexibility in style setup. Rename [WriteAsciiImpl] to [WriteAsciiBody] because the method writes histogram body content only. Extract newline string to constants to avoid multiple initialization. R=sinhak@google.com Bug: 1006447 Change-Id: Ie03ac7d2ee5a6a412f7e0f26f179d81728b5b2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971927Reviewed-by:
-
Nohemi Fernandez authored
Re-enables the 'ClearSyncData' feature reverted in change 2020323. Fixes the DCHECK errors due to incomplete URLs in tests and uses the ScopedFeatureList to enable the experimental flag that is compatible with both EarlGrey 1 and 2. Bug: 1005509 Change-Id: Ib300eb8d89e125e9bfa26045b41f59209228ac85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019362Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#735382}
-
Yi Gu authored
The test is flaky on all platforms. https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVgsSBUZsYWtlIktjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L2FuaW1hdGlvbi13b3JrbGV0L2lkbGhhcm5lc3MuYW55Lmh0bWwM Bug: 1045329 Change-Id: I8b324dcf7585408cd8f9867a07a3a31423606643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021969Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735381}
-
Matt Menke authored
This reverts commit 966cd90b. Reason for revert: Turns out that we are actually starting to listen synchronously, since that call doesn't go over mojo, so this didn't accomplish anything. Original change's description: > network::HttpServer tests: Wait for the HttpServer to start listening. > > The tests use an HttpServer run over a Mojo connection, but they don't > ensure that the HttpServer has started listening for connections before > trying to establish a connection to the server over a client socket > (also used over Mojo). The tests seem to be passing, but it sometimes > times out on Fuchsia, when the HttpServer tries to accept a second > socket. This seems likely due to some other bug (possibly in the > Fuchsia socket layer), but regardless of the underlying cause, having > the test fixture wait for the server to start listening seems to make > the test consistently pass, and is something the tests should be doing > anyways. > > Bug: 1032620 > Change-Id: I48b57e99923189496d4e405f84a22767ca42a68a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992205 > Reviewed-by: Maksim Orlovich <morlovich@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729477} TBR=mmenke@chromium.org,morlovich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032620 Change-Id: I45c8283101306e5627d9b696f176a2d357dfff69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019790Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#735380}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f78f1881..3c2484f8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I99babe02045b7b979c968c3cbb7ef7609131e4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022323Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735379}
-
Andrew Solovey authored
Add tests to check output format of the |WriteAscii| and |WriteHTMLGraph| methods for |SparseHistogram| class. Tests check that all components of the graph graphical representation are on there places: graph header, newline symbols, graph pillars with value description. Bug: 1006447 Test: browser_tests --gtest_filter="SparseHistogramTest" Change-Id: I6ab33d7848a105c1c3353d1c3b5852fbb2456a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980729Reviewed-by:
-
Gauthier Ambard authored
The computation for the edge insets used by the NTP to resize itself was using the fullscreen model which is updated too late to be used here. Instead, use directly the correct values. Fixed: 1044329 Change-Id: Ibfe84cbe9abecd516f222e0e1d12a3fe6f1f7ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019244Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#735377}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/760fd5249488..9c0a83ea4dae git log 760fd5249488..9c0a83ea4dae --date=short --first-parent --format='%ad %ae %s' 2020-01-27 phoglund@webrtc.org Remove strip_absolute_paths_from_debug_symbols from mb. 2020-01-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 812b6f89..08a3245b (735202:735303) 2020-01-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c0451968..812b6f89 (734489:735202) 2020-01-25 steveanton@webrtc.org Validate ICE ufrag/pwd according to the spec 2020-01-24 jamiewalch@chromium.org Include cursor rects in updated_region. 2020-01-24 kron@webrtc.org Revert "Reland "Reland "Distinguish between send and receive codecs""" 2020-01-24 saza@webrtc.org Reland "Change log level of AEC3 buffer info to VERBOSE" 2020-01-24 titovartem@google.com Add ability to set custom adapter type on emulated endpoint 2020-01-24 saza@webrtc.org Add parameterization for three multi channel AEC3 unit tests 2020-01-24 danilchap@webrtc.org Detach LossNotificationController from RtpGenericFrameDescriptor 2020-01-24 ivoc@webrtc.org Improvements for NetEqControllers 2020-01-23 kron@webrtc.org Reland "Reland "Distinguish between send and receive codecs"" Created with: gclient setdep -r src/third_party/webrtc@9c0a83ea4dae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029737,chromium:1043325,chromium:1044521 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I91565c6c4053c0f827bda92f483b96796356085c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021965Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/589b1875f6b6..60a3d848a8ca git log 589b1875f6b6..60a3d848a8ca --date=short --first-parent --format='%ad %ae %s' 2020-01-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 37d3a235af2c..310fb8617946 (1 commits) 2020-01-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src b97057e7f747..1b3441036a8f (6 commits) 2020-01-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 5ef91b82cbed..748ad200897b (6 commits) Created with: gclient setdep -r src/third_party/angle@60a3d848a8ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I1daa7a2bd5b6e7615b6562ecabb039ce2d005e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021963Reviewed-by:
-
Kenichi Ishibashi authored
Currently ServiceWorkeStorage depends on ServiceWorkerContextCore to schedule database error recovery (see the original design doc [1]). This dependency needs to be removed so that ServiceWorkerStorage can be moved to the Storage Service. In other words, we need to move ScheduleDeleteAndStartOver() to ServiceWorkerRegistry (see the related section of the refactoring plan [2]). This CL is the first CL to move scheduling DeleteAndStartOver() to ServiceWorkerRegistry. Specifically, this CL modifies GetUserData{,ByKeyPrefix}() so that we can call ScheduleDeleteAndStartOver() from ServiceWorkerRegistry. Subsequent CLs will do the same for other methods in ServiceWorkerStorage. [1] https://docs.google.com/document/d/1eXdgnAOZC4dDDybmRpXT0t0lOYGhFf7xajOSanEb91Y/edit#heading=h.kboaqpwv2bvf [2] https://docs.google.com/document/d/1PXg_8SKtXqfwcwTfJaPHMyUeZ4el92nU76jDbEMwkt4/edit#heading=h.hrlvq4dn719m Bug: 1039200 Change-Id: Ic91013a244538160a2600af6d9fe201358896003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018625 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#735374}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5f86e050c2e8..8fdda11ff772 git log 5f86e050c2e8..8fdda11ff772 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 tvanderlippe@chromium.org Add presubmit check to prevent checking in large files Created with: gclient setdep -r src/third_party/devtools-frontend/src@8fdda11ff772 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I84c1d276864c3cec2680c78b9b37978f7e2d543d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021966Reviewed-by:
-
