GitLab

This reverts commit 0dbcea96.

Reason for revert: Looking at additional histograms this feature
currently regressions response body read times due to extra thread
hops.  We should wait to launch until we can remove those thread
hops.

Original change's description:
> CacheStorage: Enable the sequence feature by default.
> 
> Bug: 960012
> Change-Id: Ia1c56eedf82376542b2d143692e133a173bd0653
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845856
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Commit-Queue: Ben Kelly <wanderview@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#703738}

TBR=falken@chromium.org,rkaplow@chromium.org,wanderview@chromium.org

Change-Id: I0d3fb9c1ed8eea2e07b18082d5f8e92482d9b89c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 960012
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849214Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704160}

When a suggestion has a keyword hint, we draw a lazy chevron to its
right, and offer the tab key hint. But if the suggestion is an
Answer, we replace this icon with the appropriate Answer icon.

When both of these occur within the same suggestion, it looks strange.
First, the suggestion looks like an answer, not a keyword suggestion.
Second, when the user hits tab, the Answer icon slides over as the
keyword chevron would do.

To fix this, we remove the answer from suggestions with a keyword
hint, reverting it to a normal search.

Bug: 1011876
Change-Id: I1f8cddd1fb1d3bd9e5c59d77edcaf92f776a94a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847851
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704159}

Change-Id: Ida0d1bfa2fd1ff9e2f8f61e2eaf8fd6734f82020
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849549
Commit-Queue: cathie chen <cathiechen@igalia.com>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#704158}

Change-Id: Ifdaf25071458d804cbe2bd1672e0225392309d1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848375
Auto-Submit: David Roger <droger@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704157}

Previously check reputation was when the user clicks on username field.
After removal of the old parser detection of username field is not working
anymore. And having check of username field is not so important, since
check is done on password field anyway. This CL is just a clean-up.

Bug: 949519
Change-Id: I9e5d3fdfffe1db9cfb21aa222f7d6b050d335d90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835505
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704156}

The Node class uses an ephemeron map to record EvenTargetData.
Each node holds a flag stating whether or not it has an entry in
the map. The map itself is only allocated when it is first
accessed and that setting the flag is always accompanied by
adding a corresponding entry to the map.
During tracing, if the flag is set, the map emtry is also traced.

This crash was due to the order of setting the flag and allocating
the map.
Existing implementation first set the flag, then allocated the map
and added an entry to it. However, since the map is GCed, allocating
it can trigger a GC (before performing the actual allocation). If
that happens, while tracing the node we will see that the flag set
try to access the map which was not yet allocated (resuling in the
Null dereference).

This CL fixes the issue by only setting the flag after adding an entry
to the map.

The following two WIP changes are also relevant to this issue:
1) Do not trace the entry when tracing the node. The entries are held in
a persistent map which is traced as a root so tracing the entries when
tracing the node is not required (this change is still WIP as it affects
DevTools heap snapshot).
2) Prohibiting Allocation during atomic phase. This crash manifested
because the map was allocated during the atomic phase. Prohibiting
allocations wouldn't directly solve the issue but, if similar issues
arise in the future, it would make it much easier to debug and resolve
them.

Bug: 993415
Change-Id: I878ee8639ea3ddbc1834ece9a9cae96a27349fea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849672Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704155}

Issue was with Linux MSAN un-initialized memory usage of
is_painting_preview_

Fix: Set a default value of is_painting_preview_ = false.

This is a reland of 2c483e93

Original change's description:
> [Paint Preview] Inject PaintPreviewTracker
>
> Adds the ability to inject paint_preview::PaintPreviewTracker into
> blink::GraphicsContext to act similarly to printing::MetafileSkia.
> This class will track various metadata about the Paint Preview
> capture process.
>
> Design Doc: go/fdt-design (internal)
> Part of Landing: crrev/1786583
>
> Bug: 1008885
> Change-Id: Iba2819491bee7b284de62a1bf888aa9486c788cf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829277
> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#703720}

Bug: 1008885
Change-Id: I6eb1c6ee25954bbbc381851a8bf54b759098ac09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847941Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704154}

# This is reland of crrev.com/c/1775190.
# It has to use floored value instead of rounding to match what kernel expects.

Applies the same restriction in other scenarios (web page/apps).

* Reject iff
 - the buffer is cropped hirozontally, and
 - the cropped bounds' horizontal coordinates (x and width) doesn't
   fall into even pixel boundary

Bug: 997821, b/141202973
Test: manually tested with netflix web/arc apps on eve. GtsYouTubeTestCases:com.google.android.youtube.gts.DecodePerformanceTest passed on octopus
Change-Id: I7ce9e41b55a1f3c87e55ed680e17f9842388db51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847676Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704153}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/50e5ba2d..f63c64e3

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6d934bd49b1bb57d3cdbc1980df20ee8fdc1ca1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849233Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704152}

This CL makes sure we show identity animation even for users that have
selected non-default local Chrome avatars (being only signed-in or
syncing).

To this end, this CL replaces the previous function GetGaiaImage() by
GetUserIdentityImage() which only tries to return the image of the
unconsented primary account (on which success we block showing the
identity animation). The guarding logic whether we actually show the
identity image is moved into GetAvatarImage().

Bug: 967317
Change-Id: Ic16c9a732701bf7e999aecd6b4cb2b2d5013c4b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849371
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704151}

Also remove shelf-padding when virtual keyboard is shown

Bug: 1011757, 1006797
Change-Id: I4d6a2adab2889796062898bd9f93c466f930138d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847335Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704150}

Retrieve either policy_common_defintions, or chrome_device_policy
proto file, which contains the definition of the message for
each of the device policy messages definition, to be able to use
the messages definition of policy_common_definitions inside
chrome_device_policy.

Bug: 552439
Change-Id: I319ac40b157d6fac281f2cd5ad18bed048bbb861
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847336
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704149}

This patch introduces target and debug session tracking for
out-of-process iFrames (OOPIF). The generated devtools bindings require
an additional sessionId arg for that to work.

The approach assumes, that the |Selector| is always originating from the
base frame, hence the first round of "FindElement()" from |WebController|
does not require a session_id or index_offset. The same goes for
|ElementFinder|, the class does not need an initial session_id or
index_offset, as they are both empty initially.

Bug: b/141853667
Change-Id: I7a5d37542908a0841c17c0d030c09f7076cdeb7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837831Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#704148}

https://chromium.googlesource.com/catapult.git/+log/70a8316d8b67..e74b5c944eda

git log 70a8316d8b67..e74b5c944eda --date=short --no-merges --format='%ad %ae %s'
2019-10-09 khokhlov@google.com [Telemetry] Rename artifacts -> outputArtifacts in intermediate results

Created with:
  gclient setdep -r src/third_party/catapult@e74b5c944eda

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC simonhatch@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=simonhatch@google.com

Bug: chromium:1011813
Change-Id: Ia3fa5639fc62431ea71406e0d2a3af001f51417d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849253Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704147}

Updates the expires_after attribute for 322 histograms that show
frequent access in the past 90 days.  These are the 80% most
frequently used histograms over that time that do not already have a date later
than or within 60 days of 2020-04-05.

Change-Id: Idc0e5e0b7713b78934da7a1db40bf2849bded478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847222
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704146}

BUG=762641
TBR=stevenjb@chromium.org

Change-Id: I96cda5d6f21142c72ea28778b6dcbfccf4c12c25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849493Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704145}

A page using the WebUSB API shouldn't be frozen and shouldn't enter the
BackForwardCache.

When navigating away from a page:
 1) The USB connection should be released.
 2) The tab indicator should be removed.

This won't happen if the RenderFrameHost is kept in the back-forward
cache.

Some background on why we sometimes need to disable bfcache:
https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8

Bug: 1001087
Change-Id: I17a860433f353f2371ebb223791492317a6897ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837933Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704144}

This is a reland of b400d6c7

The reason for the revert was that the test failing on the slimnav bot. This
is a legacy bot and runs with the feature off.

After investigating, it turns out it is a bug in Earl Grey where it is waiting
for a view controller to dismiss.

Since slim-navigation is not related to the failure, this CL disables the
test when slim-navigation is off, and relands the fix.

Original change's description:
> [iOS][MF] Fix search in all passwords
>
> If the password view controller was presenting something, it will stay
> around. This is fixed and a test is added.
>
> Bug: 1008421
> Change-Id: I8248cbbf28be94bc4b84c65ccda42129a192db0b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826895
> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#702358}

Bug: 1008421
Change-Id: If336b1cc5b4d6427125921d01b636b0726b860f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844979Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704143}

Ignore a strict mode violation from reading external storage state. We
could do this on a background thread, but since this code path is used for
early startup tracing, we want to minimize how much tracing changes the
normal control flow of the program.

TBR=dtrainor@chromium.org

Bug: 869794
Change-Id: I179a155a2560868839b0610d078e070da3cdfce1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845712Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704142}

Adds clipToPadding="false" to the credential ListView (huge thanks to
fhorschig@ for the tip).

Bug: 1012655
Change-Id: I2a58bb1aee4af3af95cc1bc852f1aa40ff83cd4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848376
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704141}

Bug: 1012180
Test: On device with camera having tap-to-focus support, tap and see if
it focus as expected.

Change-Id: I0be548473af01b68427b3f782351da56a342552f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849550
Auto-Submit: Kuo Jen Wei <inker@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704140}

Changes retrieval of username for default Crostini container from user
(Chrome OS specific concept) instead of profile.

Test: manually
Bug: 996439
Change-Id: Ib87961b2d7211c258766413f3196527671121a3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847299
Commit-Queue: Olya Kalitova <okalitova@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704139}

Opens the checkup url as the primary action. This is done via a New
Tab Command.

Bug: 1008862
Change-Id: I7bd8090050daadc0a0c9bd10aeffe63c63875cb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845003Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704138}

Using wpt-import in Chromium 06347df2.
With Chromium commits locally applied on WPT:
23748e60 "Change text directive to text="
2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Id08a52f91bd539e4a5d628f4a20f9ca477a7a6e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849492Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704137}

Forbid passing empty v8::Local to ScriptValue constructor.
This will make the rules consistent with WorldSafeV8Reference's constructor.

Change-Id: Id0f0302025eb8397a5ebcef78ea91671cda1e453
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847412
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704136}

The navigation that fails is in SetUpOnMainThread, before RunTestOnMainThread.

Bug: 1011765
Change-Id: I23d551e7ccd57aeaf31d6aed2fac2a0c3be73c46
TBR: fdoray
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848377Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704135}

https://github.com/whatwg/html/pull/1782 removed same-origin data URL
flag from request We should follow that. Data URLs should be treated
as same-origin.

This is a follow up of
https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9.

Bug: 1012624
Change-Id: I200d30d9c39a22b7dc395966a7df51426a335b43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849472
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704134}

This change converts InsecureInputService mojom interface client in
blink to use BrowserInterfaceBroker.

Bug: 936482
Change-Id: I29b03ddfadd7fbfb8e026039b751f22ee885b20f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844523
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704133}

page.

Previously, from the site settings page users could only create
first party exception rules. Now added a checkbox to enable users
to add new rules that affect third parties on a given website.
https://screenshot.googleplex.com/VT4Zcb4Cp3Q.png

Bug: 1009408
Change-Id: If7670d6928380d22303a68bfd60fc658136d5571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833586
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704132}

Loading local files from bundled exchanges file is prohibited. So no
need to set FileURLLoaderFactory while loading bundled exchanges files.

Bug: 995177
Change-Id: Ia3ce8a20d331be3a94cad89d3283e6b30b4975fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847604
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704131}

Set appropriate NativeThemeBase colors when color-scheme is dark.

Bug: 939811, 929098
Change-Id: I4bc7db9b5792f3b5bc4c2ca220e3ed61bff5e51d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835495
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704130}

This function never worked.
- It should search the Chrome Apps folder for the bundle to delete.
- Instead, it searched some path inside the profile path.

Change WebAppShortcutCreator::GetApplicationsDirname to be a
global GetChromeAppsFolder method.
- DeleteAllShortcutsForProfile function doesn't have a
  WebAppShortcutCreator object, so it couldn't use the member function
- Many test override the WebAppShortcutCreator::GetApplicationsDirname
  method. Add a SetChromeAppsFolderForTesting method to replicate this
  functionality.

Change tests to explicitly set DIR_USER_DATA.
- Ensure that the app data dir be a sub-path of the user data dir
- This is required for BundleInfoPlist::IsForCurrentUserDataDir,
  called by DeleteAllShortcutsForProfile, to behave correctly.

Bug: 1011951
Change-Id: I512566914ef918c9421cbc4605d1f464ab4dbccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846755
Auto-Submit: ccameron <ccameron@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704129}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6092f6bc..50e5ba2d

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Id2d7714700e11fb120b29d5cbb433965d85163dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849232Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704128}

https://chromium.googlesource.com/catapult.git/+log/713e9ad3279d..70a8316d8b67

git log 713e9ad3279d..70a8316d8b67 --date=short --no-merges --format='%ad %ae %s'
2019-10-09 perezju@chromium.org [Telemetry] Replace Speed>Telemetry with Test>Telemetry

Created with:
  gclient setdep -r src/third_party/catapult@70a8316d8b67

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC simonhatch@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=simonhatch@google.com

Bug: None
Change-Id: Ib7c5be9ec7f268fc6855a76069cc0574fb2bfa26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848898Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704127}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb5338375637..9608b4a1db16


Created with:
  gclient setdep -r src-internal@9608b4a1db16

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I96b5480b11823310cd54afc7b634cd0c74de4e9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848897Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704126}

This CL turns on native handling of all output format for two benchmarks:
power.desktop and startup.mobile. This is an experiment to make sure that
Results Processor is ready to handle output formatting on all platforms.

Bug: 981349
Change-Id: I760f51b8daf2594655cd9a2b4d05bb0fb21e7a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841552
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704125}

- The sync icon is added.
- When there is no description text (e.g. sync is on),
  the sync info is made a hover button.
- The separator at the top is removed.

Screenshots:
https://drive.google.com/open?id=10kaxE5u_m6CgLaHZpf-6iz7LUK_T9Mcm
https://drive.google.com/open?id=1rssB_Q6tRzYosA7p7Nep3JwINEajzaXH
https://drive.google.com/open?id=1PwFOFAs_bAHseCarkAd7yo2f7-12J6ec

Bug: 995720
Change-Id: Ie1eb23e6eb62bd7accfd67a7c522dd0365b995a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847913Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704124}

This reverts commit 6e443093.

Reason for revert: Causes failures on WebKit Linux Leaks and Webkit Linux MSAN, see https://crbug.com/1012652

Original change's description:
> CompressionStream
> 
> Implement compression for "gzip" and "deflate". That implementation is
> hidden behing ExperimentalCompressionStream flag.
> 
> For unit tests, we compress and stream and uncompress it with pako, and
> we make sure its output is the same as our original data.
> 
> Change-Id: I89dde0e06a07b695be93a3b4f81fa6b3ee80d760
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763344
> Commit-Queue: Adam Rice <ricea@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Adam Rice <ricea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#704009}

Bug: 1012652
TBR=kinuko@chromium.org,ricea@chromium.org,yhirano@chromium.org,robertma@chromium.org,acomminos@fb.com,arenevier@fb.com

Change-Id: I3d57975faa0206478048f518b53dcb617192b016
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849376Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704123}

This CL fixes two bugs that caused flaky AA tests involving the bottom sheet:
- First, the tests were waiting for |isDisplayed()| and then immediately calling |perform(click())|. This is flaky, because |isDisplayed()| succeeds with widets that are >= 50% on screen, but |perform(click))| requires >= 90%. During the initial bottom sheet animation, it was possible to click the button before it was completely visible.
- Second, and more importantly, |waitUntilViewMatchesCondition| did not correctly wait for the full duration. Rather, if a matching view exists that did not fulfill the specified condition, it would erroneously return, because the thrown exception in that case was an |AssertionError| rather than a |NoMatchingViewException|.

b/142317318

Bug: 990118
Change-Id: I0c47e92ac8e77ae804eff5f05ac2c80ce9d77082
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848372Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#704122}

This is a followup to crrev.com/c/1844969 and crrev.com/c/1845225.
GetBestMatches now returns the best matches in a vector, instead of in
a map keyed by username.

Bug: 1011399
Change-Id: If539984b1b2538c0bb2c48a34fcd3d998707f7f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844989
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704121}