- 11 Jul, 2019 40 commits
-
-
Yuzu Saijo authored
This CL fixes the incorrect usage of std::map. The lookup in the map is using the [] operator which is creating a default entry when the key is not present. etienne@ first tried to land this fix but had to revert because some tests became flaky (which was supposed to happen when we first associated IPCs with per-frame task runners here https://chromium-review.googlesource.com/c/chromium/src/+/1526067 , but was hidden because of this bug). Test failure example: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/13652 This is a second try to fix the incorrect map usage. -- update -- The flaky tests were because of scheduling experiments that set the background tasks to low priority, and this fix just surfaced the issue because now tasks are posted to per-frame task runners. CL to disable the experiments: https://chromium-review.googlesource.com/c/chromium/src/+/1692577 Now that the experiments are disabled, this memory leak fix should not make the tests flaky any more. Bug: 973200, 980523 Change-Id: I1eaf0af67f1bcbd582a510d70174666251b8b4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686979 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#676283}
-
Yutaka Hirano authored
I'm going to land a change that allows structured cloning for errors. See [1] for the failures. - wpt/animation-worklet/stateful-animator.https.html expects errors are not serializable (see "state_function_returns_not_serializable"). - wpt/html/browsers/history/the-history-interface/001.html and wpt/html/browsers/history/the-history-interface/002.html expect a DataCloneError when calling pushState with an error. - fast/dom/Window/window-postmessage-clone.html expects a DataCloneError when calling postMessage with an error. - fast/events/message-port-multi.html expects a DataCloneError when calling postMessage with an error. - storage/indexeddb/structured-clone.html expects a DataCloneError when putting an error to the storage. All changes are expected, so I suppress all the tests here. After landing the V8 change I will modify and re-enable them. Also, add wpt/html/.../structuredclonse_0.html and structured-cloning-error-stack-optional.sub.window.html because the corresponding test changes will be merged soon. 1: https://ci.chromium.org/p/v8/builders/ci/V8-Blink%20Linux%2064/33036 Bug: 970079 Change-Id: I9b12adc81815996e1dc59b382f70ab83c4901a11 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695541 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#676282}
-
Jeremy Roman authored
Generated by: https://chromium-review.googlesource.com/c/chromium/src/+/1689216 Bug: 981415 Change-Id: I363f81e8c17cabfb6031666ca0846bcfcbf97b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693602 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Chih-Yu Huang authored
After V4L2 surface is decoded, AVD might update the frame context. If AVD stops decoding because of need context update, then we need to resume decoding after that. BUG=chromium:941330 TEST=video_decode_accelerator tests --use_vd on kevin Change-Id: I45aaaf2df1431d0ace4c0fe107096538a03fd14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684788 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#676280}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e34ebb7382bc..8f0eabe40a7c Created with: gclient setdep -r src-internal@8f0eabe40a7c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hcarmona@google.com,hajimehoshi@google.com,jbroman@google.com Change-Id: I3c875f222f03622525f51350334675fe2c437c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696696Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676279}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ie4c9f183ab018c4739a56e699633ca17a88f8775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697102Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#676278}
-
yilkal authored
Bug: 977019 Change-Id: I06b58830bb975be2537b55ac71b63810d4bdd288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684672 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#676277}
-
Giovanni Ortuño Urquidi authored
Admins will be able to specify the install URL for a Web App to pin that Web App to the shelf. Bug: 880125 Test: ChromeLauncherControllerTest.WebApp* Change-Id: I33e31c390f13761e140a68efbce4b0c9d547e2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670732Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#676276}
-
Alex Khouderchah authored
Bug: 975116 Change-Id: I9b2908c60bbf598d6188f085e932161a55fcfb6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696141 Auto-Submit: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org> Cr-Commit-Position: refs/heads/master@{#676275}
-
Ahmed Fakhry authored
The resource reporter system is likely to be removed or migrated to a new implementation (see issue chromium:976423). Until then, we extend the expiry date of these histograms till the end of the year. BUG=975534, 975218 Change-Id: Ie290e3347de9bd41e75cc4c40db2c641e6029463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691870Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#676274}
-
Sammie Quon authored
Modify the overview selection code to include tabbing through desk mini views and new desk button. To accommodate desks and also refactor the current logic, introduce a new class which handles displaying highlights in overview. The new class makes it easier to test and allows us to remove many member variables in OverviewGrid and OverviewSession, which was hard to track at times. Design doc is in the bug. This CL separates the tab highlight with the focus traversal highlight. The two probably will never show up at the same time, but I think its easier to follow this way. Additionally, this CL prevents tab events from moving the highlight while a drag is underway. Removes two tests used to enforce that behaviour. Also, the highlight just disappears if we close the window it was highlighting. Follow ups to this cl: Make sure the UI is what UX wants (no specs yet). Introduce OverviewHighlightControllerTest and move highlight related tests there. See if we should be traversing to the close buttons. Test: manual, with desks enabled and multiple monitors Bug: 978168 Change-Id: I403fc794856cb8747868ea08aa25c5e89473f57d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677482 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#676273}
-
Gabriel Charette authored
Multi-threaded MOCK_TIME advances when either RunLoop::Run() or ScopedTaskEnvironment::FastForward*() is active and the system reaches an idle phase (both main thread and thread pool are out of immediate tasks). It then advances by the minimum time delta necessary to make a task able to run. In a follow-up CL, I'll split MOCK_TIME off of MainThreadType (now that it's no longer main thread specific) and migrate callers. Bug: 946657 Change-Id: Id3da34ac066623291a8fca682fd13c9473e83e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686776Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#676272}
-
Jinsong Fan authored
Safe Browsing is enabled by default, WEBVIEW_ENABLE_SAFEBROWSING_SUPPORT becomes dead. No change to logic. Bug: 799317 Change-Id: I04e0c6d7a62a29940d6fd3f423103bd28ecffee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685019Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#676271}
-
Brian Sheedy authored
Adds the ability to replace or remove arguments for tests generated using generate_buildbot_json.py by specifying a 'replacements' field in test_suite_exceptions.pyl. This is useful in cases where a subset of bots have slightly different args from usual. Previously, this required a duplicate test suite definition with the updated args. With this change, the same definition can be used with the differences listed in the exceptions. Bug: 980631 Change-Id: If3c0c22f2046ce67123ec06dea88a6bf8de9102f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691266Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#676270}
-
Charlie Andrews authored
This is a reland of https://crrev.com/c/1666806, which caused flakiness on the Mac bots and was reverted. Since submitting that CL, I've changed the pointer management in ScopedGetItems so that it no longer relies on the heap. Calling unique_ptr::Reset() was causing deadlock when the target thread was suspended while holding the heap lock. This lays the groundwork for a follow-up patch that keys items in the metadata recorder by a <name hash, integer ID> tuple instead of just the name hash. This will allow us to distinguish between metadata that might coexist with the same name within the same process. For example, if we had a piece of metadata with a lifetime between navigation and FCP, we're currently unable to distinguish between two tabs running in the same process that are both loading. This new key structure will fill up the metadata map much faster because we don't recycle keys once an item slot is allocated for them. This patch gives us some ability to recycle those keys. TBR=gab@chromium.org R=wittman@chromium.org Bug: 976864, 982034 Change-Id: Ie4f0b941c8c9281aae7ab95e54d546ee4c13c8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696347Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#676269}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/807023d1041b..9ec162df61d3 git log 807023d1041b..9ec162df61d3 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 seanabraham@chromium.org cbuildbot: remove set noparent 2019-07-10 bhthompson@google.com Move R76 Android N PFQ to gandof 2019-07-10 bhthompson@google.com Migrate branch N Android PFQ builder from reef to gandof 2019-07-10 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@9ec162df61d3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Id3ebd77858fed04da2a6d5a29ecccafa8e6de7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696749Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676268}
-
Sofiya Semenova authored
Exposes the UKM source ID from WebContentsImpl to WebContents, so it can be used in NavigationPredictor to send metrics to the UKM. Bug: 972128 Change-Id: I7181890ed7977904b8d4dca9db78b7bbbad85b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686633Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Sofiya Semenova <sofiyase@google.com> Cr-Commit-Position: refs/heads/master@{#676267}
-
Liquan(Max) Gu authored
According to the spec (https://w3c.github.io/user-timing/): 1. "If markOptions's startTime is negative, throw a TypeError.", 2. "If mark is negative, throw a TypeError." when "Convert a mark to a timestamp" The CL is to add these two checks accordingly. Bug: 953865 Change-Id: I8475870cc883dc8c3d3d4f3e65a9d5a0a2189a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691871Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#676266}
-
David Staessens authored
The video_decode_accelerator_perf_tests currently only work in import mode. This CL introduces fixes to support running the performance tests in allocate mode. TEST=./video_decode_accelerator_perf_tests on nyan_big BUG=981712 Change-Id: Ic6b4c5315be4bd51b808b124dfc49f5b510adf0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686669 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
Kyle Milka authored
When a background tile is selected don't remove the selected state unless it is clicked again, another tile is selected, or the dialog is closed. http://go/scrcast/NTYzMjU0OTE2NDQxNzAyNHxjYTViNTI3YS1jNw Bug: 937570 Change-Id: I99caf6b5b2afbf2dfcfa9198db042491220c63a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696161 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#676264}
-
Ian Kilpatrick authored
"adjoining" objects are used to indicate that a particular node might need relayout once its BFC block-offset is resolved. Previously we thought that we just needed to know about "adjoining-floats". However inline-level OOF-positioned nodes also needs to know its BFC block-offset as the static-position of these nodes depend on where floats are. Previously as we didn't know that we needed to relayout these nodes we'd get the incorrect static-position. Now these nodes get the correct static-position. Bug: 982403, 980908 Change-Id: I89f18298fd7379358a681b98514891d8d35bc38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692627Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#676263}
-
Dana Fried authored
Update to code was using non-normalized insets to calculate positioning when justifying elements left, right, or center along the main axis. Change-Id: I9892572ab37174fe14c20b2b0a1431377092098e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696453Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#676262}
-
John Abd-El-Malek authored
Bug: 977873 Change-Id: I953a7bbc3a3dcf4442126136cca36812d8a51f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696218 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Minggang Wang authored
This CL changes the typemapping of network.mojom.HttpRequestHeaders for Blink variant. See details below: Before: typemap with blink::HTTPHeaderMap After : typemap with net::HttpRequestHeaders This CL is part of a series of CLs which are targeted to typemap network.mojom.URLRequest with network::ResourceRequest for Blink variant finally. 1. https://chromium-review.googlesource.com/c/chromium/src/+/1669131 2. https://chromium-review.googlesource.com/c/chromium/src/+/1672768 3. This CL 4. https://chromium-review.googlesource.com/c/chromium/src/+/1679984 5. https://chromium-review.googlesource.com/c/chromium/src/+/1683493 BUG=860403 Change-Id: I29111a6ef8a094028c8f7919cca7761f9e1d84a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680505 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#676260}
-
David Staessens authored
When running the new video decoder tests in allocate mode, sometimes the video player will not receive the last frame, making the tests fails. This happens because the WrapVideoFrame method is only supported in import mode, and a workaround is used in allocate mode. To fix this issue logic is added to manually wrap frames in a similar way when using allocate mode. This is also required to run the video decoder performance tests on allocate-only platforms. TEST=./video_decode_accelerator_tests on nyan_big BUG=957808 Change-Id: Ibf29e9f716beef8aaf1a27904e2220399418c209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688773 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
Alex Cooper authored
Also simplifies events_deviceconnect, though because that tests behavior that doesn't appear to be specced, that test is left internal. Bug: 979316 Change-Id: I55cdb925aac9c2317d0a2b9f44f8eb368048aa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693775 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#676258}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cc3264288255..c38cfa99a722 git log cc3264288255..c38cfa99a722 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 bsalomon@google.com Third land of "Restore GL_UNPACK_ROW_LENGTH to 0 between MIP levles" 2019-07-10 egdaniel@google.com Add missing RGB_888x colorType to GL RGBA format. 2019-07-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-10 mtklein@google.com lifetime analysis readability refactor 2019-07-10 brianosman@google.com Remove MSVC 2015 toolchain remnants 2019-07-10 robertphillips@google.com Fix assert 2019-07-10 bsalomon@google.com Try GrGLSizedInternalFormat enum 2019-07-10 senorblanco@chromium.org Add first Dawn dependencies. 2019-07-10 bsalomon@google.com Blacklist ColorTypeBackendAllocationTest on MoltenVK 2019-07-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-10 reed@google.com Move test around in cubic_solver to test function, not delta_t. Created with: gclient setdep -r src/third_party/skia@c38cfa99a722 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:981254,chromium:b/137017906 TBR=fmalita@google.com Change-Id: I2ce56c5148458b932ebbb56c6a5660eefdae4783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696802Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 975222 Change-Id: I8b7f7b1bc67c4b90c9431d6f648d389f8ffbe8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686613Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
Jun Mukai authored
The page transition in ash::PaginationModel is used to provide the animation effect on several views in ash, but currently this is the default gfx::Animation which runs independently from the compositor. It would be plausible to run with the compositor by using AnimationDelegateViews. The use of UnifiedSystemTralModel is still TODO, so the use of the compositor is still optional. Bug: 980722 Test: ash_unittests Change-Id: I34a1cb2f8b179354a99bf5bcaad07249ca252fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692976 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#676255}
-
Katie Dillon authored
The third experiment for prioritizing the compositor building off of this cl: https://chromium-review.googlesource.com/c/chromium/src/+/1626020 This experiment alternates the compositor priority so that compositor tasks are prioritized but mostly does not run compositor tasks back-to-back: + If a compositor task has just run, set the priority to Normal. + If a non-compositor task has just run, set the priority to VeryHigh. + If the priority has been set to Highest, it will be left at Highest, regardless of what kind of task was just run. Bug: 966177 Change-Id: I43b4b67f90acae1c6b8e944160c6c12dfdc472af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647141 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#676254}
-
Andrew Xu authored
This CL is the first part of code to implement the arrow button in the overflow bubble view. See more details from the below doc link: https://docs.google.com/document/d/1dO4H_4T6ttWFc75nCNi2Uh18k-3_M8-eOHcfMTcNwd0/edit?usp=sharing Bug: 918024 Change-Id: I6f8bf2dfe4871e2457947468696834adbd5d264d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686782 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
dpapad authored
These were previously defined within shared/module_metrics_proxy.js, even though they are only used within their respective folders. Moreover module_metrics_proxy.js was working around a Closure compiler bug, which resulted in a weird pattern (having code after cr.define), making it harder to auto-generate a JS Module from this file, which is the motivation for this change. Bug: 965770 Change-Id: I098490ccb82af60fbdc632a91a1fb7b7da13e040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696684Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#676252}
-
Alex Khouderchah authored
Bug: 975239, 975012 Change-Id: Ic82c4e20c610071b0452926b3c662250b0b4fe16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696143 Auto-Submit: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by:
-
Alex Khouderchah authored
Bug: 974979 Change-Id: Ib72755080f7658e8260e26f7c920109a95a2afd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696122 Auto-Submit: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by:
-
John Emau authored
The text is bolded and visually represents the start of a workspace folder mapping so a heading role is appropriate, level 2 was chosen because the tab heading will be level 1 (https://crrev.com/c/1658659). Now screen readers can easily jump to a workspace mapping. NVDA screenshot: https://i.imgur.com/XU8votp.png This change meets success criteria for WCAG 1.3.1 Info and Relationships. See: https://www.w3.org/WAI/WCAG21/quickref/#info-and-relationships Screenshot: https://i.imgur.com/uVZ6xqH.png Bug: 963183 Change-Id: I4871cc7fe9779c523e7c87089a33d1d12b119e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658641 Commit-Queue: John Emau <johnemau@microsoft.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#676249}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2bf119af6d9c..e34ebb7382bc Created with: gclient setdep -r src-internal@e34ebb7382bc The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hcarmona@google.com,hajimehoshi@google.com,jbroman@google.com Change-Id: Ia1cbe096bf8baed1f8d5269786ac4e8e772a5069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696801Reviewed-by:
-
Findit authored
This reverts commit ee11d579. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 676123 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2VlMTFkNTc5ZDRhZWM3YWUzZGIzMmRiOWVlMTBkOWVjMThmMGVkNmYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/13978 Sample Failed Step: chromeos_unittests Original change's description: > PpdProvider non-USB printer log spam fix > > Currently calling ResolveUsbManufacturer for ALL printers that fail ppd > matching; now correctly filtering for usb printers. > > Bug: none > Test: manually confirmed removed log spam > Change-Id: I71b601d496001fc2c1ea14ca1281046f245d1c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696187 > Reviewed-by: Sean Kau <skau@chromium.org> > Commit-Queue: Luum Habtemariam <luum@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676123} Change-Id: If99b945acc97f9d361ab7f888591916781c984ef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696837 Cr-Commit-Position: refs/heads/master@{#676247}
-
Minggang Wang authored
This CL builds typemapping network.mojom.RequestPriority=net::RequestPriority for Blink variant. Because the struct traits exist, we reuse them. This CL is part of a series of CLs which are targeted to typemap network.mojom.URLRequest with network::ResourceRequest for Blink variant finally. 1. https://chromium-review.googlesource.com/c/chromium/src/+/1669131 2. This CL 3. https://chromium-review.googlesource.com/c/chromium/src/+/1680505 4. https://chromium-review.googlesource.com/c/chromium/src/+/1679984 5. https://chromium-review.googlesource.com/c/chromium/src/+/1683493 BUG=860403 Change-Id: Ibc736d0dd671f0057aa5484076effdea5d9c0941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672768 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
evliu authored
This CL moves div with the default route-path outside of the template whose visibility depends on a feature flag. Bug: 980783 Change-Id: I011839bb20efde9435fe007ba270cc6fea9bdd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687567 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#676245}
-
David Staessens authored
This CL adds a new test to the video_decode_accelerator_tests binary, which tests decoding a video in allocate mode. This test is automatically skipped on platforms that only support allocate mode, which already run all tests in allocate mode. TEST=./video_decode_accelerator_tests on eve BUG=953122 Change-Id: I82347bc7230ab9afed26199d43e55954b4a4558b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688750 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
