GitLab

This change allows Switch Access users to navigate the login screen and
enter their password by fixing two bugs.

1. On the login screen, there were two copies of Switch Access running.
2. Pending childrenChanged events were being fired on the DesktopNode
   after it was no longer focused.

AX-Relnotes: n/a.
Bug: 1121260
Change-Id: Ia4ef3791fbf5480003ded0b1de70dd4df1f5b9d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378891Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#802446}

Currently ImageDataBuffer ctor uses PaintImage::GetSkImage which will
be deprecated as we move to enable OOPR for Canvas2D. This CL updates
the ctor to be OOPR/non OOPR agnostic by using new calls to
PaintImage::GetSwSkImage and PaintImage::readPixels which will work in
both modes.

Bug: 1018894
Change-Id: Iaf5a9af5b4384fd040a75c3db3cc6ffe8a68d736
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366036
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802445}

This CL (temporarily) explicitly enable SignedExchanged* for web
tests. Two tests under external/wpt/signed-exchange/subresource are
rebaselined. virtual/sxg-subresource is removed.

This is to sepearte the change of web test expectations from
crrev.com/c/2375886 which will enable the feature for web tests by
adjusting the application order of blink feature status and chromium
feature status.

Bug: 1121839
Change-Id: I240be44a74a72604dcecc4aad34c0ca70a4e76e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378738Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802444}

This is unused, and now that we have an expectations file this should still
be easy enough to audit.

Change-Id: Ic48e76ed4e1b90e351c27a350cf82d3f6b0fea6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380576
Auto-Submit: Sam Maier <smaier@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802443}

On Chrome OS, the new Save to Drive destination opens the file picker
and saves PDFs directly to the local file system like the existing Save
as PDF destination. So in most areas of Print Preview, Save to Drive
needs to be treated the same as Save to PDF.

The two places the destinations diverge are:
 - Icon display
 - Setting printToGoogleDrive on the print ticket

Bug: 1112416
Change-Id: I3debedc4298408a4de0e2286e0227a47ccb3d2e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358691
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802442}

https://android.googlesource.com/platform/external/perfetto.git/+log/cc61e5a98324..ed2e4739280f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I9bac7a6557e7c0e64708a17687473bcc97c6d9c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380584Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#802441}

This change adds a CHECK_LE(pos, size()) in BasicStringPiece::substr.
This attempts to model standard library behavior, since
std::basic_string_view::substr throws an out_of_range exception in this
case.

Reference: https://wg21.link/string.view.ops#itemdecl:2

TBR=dcheng

Bug: 1049498
Change-Id: Ie5c946b8cd1b2cb9d7022bfcd5fa2a89372ec31c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372445
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802440}

Bug: 1121021
Change-Id: If656f90953fcc45f53741974dc44fda5314e465c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376455
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802439}

This CL adds just the feature flag for the Clank language decouple.  Three
more CLs will add the rest of the feature.

The feature flag DETAILED_LANGUAGE_SETTINGS is added to be used for both
the initial language decuple and new Android language settings.

Bug: 1068667
Change-Id: I9e999f44e6f431bb1f13d16f170d626f8819db45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360591Reviewed-by: David Vallet <dvallet@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802438}

This reverts commit 5555c98b.

Reason for revert: Breaks the build https://ci.chromium.org/p/chromium/builders/try/android-pie-arm64-dbg

Culprit v8 CL has also been identified, revert here: https://crrev.com/c/2380613

Original change's description:
> Update V8 to version 8.7.26.
> 
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/1f2195b4..2a00f38a
> 
> Please follow these instructions for assigning/CC'ing issues:
> https://v8.dev/docs/triage-issues
> 
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
> 
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
> 
> TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
> 
> Change-Id: I70ddc2d6f35c8ad166a434367ac411099dcf3aa8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378694
> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#802063}

TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ibc4d3da3f7d73eff6af4ea1de700e640eb09f443
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel
Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380675Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#802437}

BrokerClient::Readlink returns -ENAMETOOLONG if the buffer is too small
for the pathname, but this is inconsistent with POSIX which fills up
the buffer with part of the pathname, and only returns -ENAMETOOLONG
if the actual pathname is longer than PATH_MAX or an individual
pathname component is longer than NAME_MAX.

Change-Id: I282f2ead6814bbd799e286a6e80ed5991ceeb54e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379470
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802436}

This is a reland of 76c5ef2b

Original change's description:
> [Switch Access] Move code out from behind flag
> 
> AX-Relnotes: Launch Switch Access on Chrome OS.
> Bug: 1016200,1121357
> Change-Id: I464abbeaeb50c8c40adbac4ce51d7d9f038430fa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373368
> Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#801947}

Bug: 1016200
Bug: 1121357
Change-Id: Ic1b96aa268768a30ea8b5ace11c0925f62494a63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380415
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802435}

SolidColorQuads use a single color for the entire area, thus the same
color can be precomputed. This avoids transforming the color for each
fragment in the shader pipeline.

Bug: 1072895
Test: All viz, cc, and compositor pixel tests pass
Change-Id: I27a4d88ff480ab351a105e1fc3e53393beb26903
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357852
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802434}

Bug: 1122771
Change-Id: Icd0922c3dc77aaa175dd81cc753033490e2b71cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380815
Auto-Submit: Gregory Guterman <guterman@google.com>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802433}

This CL updates network icon in OS Settings so that they don't show
cellular technology badge when the network is not connected. This
makes it consistent with Quick Settings menu.

Bug: 1122137
Change-Id: Iae972215c456ff884f26761174a5d80b1568864f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380580Reviewed-by: Jon Mann <jonmann@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802432}

This CL updates the tab controls container in the tab strip to remain
fixed while the Tab Search bubble is open.

Keeping the tab controls container fixed is necessary to ensure that
the bubble does not slide around on the screen with the anchoring
button as tabs are removed from the Tab Search UI.

This CL also performs some cleanup and removes unnecessary build
flags.

Bug: 1099917
Change-Id: I28d395f4804175d3ab868d2ea4ae9e3607170571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377550Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802431}

As part of sharing more code between the extensions, move the methods
manipulating rectangles from select_to_speak into the common rect_util
class.

This is a pure refactor with no behavioral change.

AX-Relnotes: n/a.
Bug: None
Change-Id: Ic1b47def1b0bc3306799476d3ea722961429eebc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376665
Auto-Submit: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#802430}

The Mac malloc interceptor relies on internals of macOS.
Update those internals and links to the 10.15 versions.

This relands 994f22b5
with a fix for profiling_client.cc which correctly only
includes a Mac file header on the Mac.

Bug: none
Change-Id: I8132dc1ffeeb0c6b65edb80cc729bcb4836f2121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377983Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802429}

This helper is intended to replace |Post()| while also supporting an
optional reply callback, à la |base::PostTaskWithReply()|.

Q: Why have SequenceBound at all?
A: Performing blocking / slow work on a different task runner is a
   common pattern for improving responsiveness of foreground task
   runners. SequenceBound aims to make it easy to implement this pattern
   by making it natural for code running on different sequences to be
   partitioned on a class boundary.

Q: Isn't this just promises?
A: No. Promises allow arbitrary composition of asynchronous tasks. This
   helper is much less flexible:
   - It only allows one call to be proxied to the managed |T|, and
     optionally, one reply to be proxied back to the owner sequence.
   - It does not allow delayed attach of the 'then' callback.
   - It has no notion of rejection.

Q: Why not simply add a |PostTaskWithReply()| method?
A: Template parameter packs don't work well in a function parameter list
   if they are not at the end of the parameter list:

     sb.PostTaskWithReply(FROM_HERE, &Helper::Method, arg1, arg2,
                          std::move(reply));

    will not work unless the template parameters are explicitly
    specified.

    Inverting the argument order works:

      sb.PostTaskWithReply(FROM_HERE, &Helper::Method, std::move(reply),
                           arg1, arg2);

    but results in code where the arguments are in reverse order.

Q: Why replace |Post()| which worked perfectly fine?
A: Replacing |Post()| allow base::Location to automatically set as a
   default argument. This is a minor quality-of-life improvement from:

     sb.Post(FROM_HERE, &Helper::Method);

   to:

     sb.AsyncCall(&Helper::Method);

   In the future, it's likely the various |PostTask()| APIs will also be
   refactored to not require specifying FROM_HERE, so this keeps a more
   consistent API surface in the long-term.

Q: Why not use |base::BindOnce()|?
A: SequenceBound() does not expose the raw managed pointer value to
   ensure its internal sequence-safety invariants are not violated. This
   makes it impossible to use |base::BindOnce()| if the caller wants to
   bind any arguments.

Change-Id: Ib7c48e216c9f99cc84be10af205b205aafde6556
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242723
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802428}

CrOSComponentManager::Unload() calls into code in MetadataTable that
assumes that system salt is available. This isn't always true when
chrome restarts to apply non-owner flags.

Unfortunately the MetadataTable API is synchronous and non-trivial
to convert to async. Work around the crash by ensuring system salt
is available before attempting to unload the lacros component.

Filed crbug.com/1122753 to track refactoring MetadataTable so it
doesn't depend on data that isn't guaranteed to be available.

  in about:flags, restart and let Lacros download/install. Then
  explicitly set flag to "Disabled" and sign out (not restart).
  Sign in again. No crash.

Test: With non-owner account (secondary user), enable LacrosSupport
Bug: 1122674
Change-Id: Idf25ef8955315e92c6f823a0da8f8b65fd0a40c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380320Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802427}

This CL adds new histogram EphemeralTab.CtrPeek that indicates that user
interacted with the peeked preview tab to open it beyone peeking state,
in contrast to EphemeralTab.Ctr that indicates the preview tab got
fully opened.

Bug: 1025081
Change-Id: I7555ed9b21cc33d7348b4fd60052b49111fbc596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377029Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802426}

Flaky on D3D11 Intel WebGL2.

TBR=bsheedy

Bug: 1122744
Change-Id: Idb03c637582150acc120e2f13818a0914bb58a9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380495Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802425}

In viz, the display compositor owns the context provider, and as the
display compositor is getting destroyed, the context provider should be
destroyed at the same time. Objects created by the GLRendererCopier
has been the only ones keeping the context provider alive longer than
the display compositor. This change will fail copy requests when the
display compositor is getting destroyed.


Bug: 1096487
Change-Id: I3cedd70dff42ed7ef9f946ec4b34017d3560df7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253159
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802424}

Change-Id: I922b80ac8b9b67b0500c69ba764d6e4ef4ae266d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380149
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802423}

crrev.com/c/2252560 separated 'All sites' and 'Storage' settings
categories into their own Fragment, which broke them in WebLayer. This
CL adds support for the new AllSiteSettings Fragment. Note that the new
Intent being created in this CL does get passed to the client in order
for it to start the new Activity, but its contents are transparent to
the client so this is backwards compatible with older client versions.

I'll add tests for every settings page in a followup that should catch
issues like this in the future.

Bug: 1122705
Change-Id: I94f69d1cebfbd19add42e936afccc0a5f2512aec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380575Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802422}

Adds deep links to the Apps Page and the Android Apps subpage.

Bug: 1084154
Change-Id: I613b8ca1fc3074927efdff7820871f4dae3fa6f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378875Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Daniel Classon <dclasson@google.com>
Cr-Commit-Position: refs/heads/master@{#802421}

ExecuteScriptApiTest.ExecuteScriptPermissions was disabled for
flakiness on Windows. Recent changes made to clean this test up
have de-flaked it. It passed 3000 iterations on the bots without
any flakes.

Bug: 174715
Change-Id: I54e231b6dce37edd5cc0cea3df6e021e554cf10c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375012Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802420}

Change-Id: I34548f56ef60ca5ef1fa3cba934ea86f3797677e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376941Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Chloe Pelling <cpelling@google.com>
Cr-Commit-Position: refs/heads/master@{#802419}

Run most of the PDFExtensionJSTests with the PDFViewerUpdate flag
enabled and disabled. Exceptions:
- Run toolbar_manager_test only with the flag disabled. The tests in
this file test toolbar hiding/showing behavior that is not relevant
with the new UI.
- Return early from one annotations_feature_enabled test and one
basic_plugin test with the flag enabled, as there are some issues
(noted with TODOs) that need to be fixed with these tests.

Started from pieces of
https://chromium-review.googlesource.com/c/chromium/src/+/2368821/7
by dpapad@

Bug: 1120279
Change-Id: Idb3445068dd7902e2934a8c8fd4e60b21b431ddb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376871
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802418}

Bug: 865172
Change-Id: I687021367afc08315226049d18302b70856aa595
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366743
Auto-Submit: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802417}

and OnNavigationCompleted.

Content does not allow WebContents to be deleted from
WebContentsObserver::DidFinishNavigation(). Unfortunately we
keep seeing crashes because of this restriction, so I'm
inclined to provide some mitigation.

This patch takes the approach of detecting this scenario
and delaying deletion of the WebContents. All the surrounding
WebLayer classes are deleted/destroyed and ownership of the
WebContents is passed to the Profile and deleted from a
post-task.

Doing this may introduce it's own set of problems. For example,
if a callback/notification is still in flight from content that gets
processed before the deletion, and the code assumes there is a Tab
associated with the WebContents, then there will be problems.

My preference is still to fix this in content, but in the mean
time this should work.

BUG=1111127
TEST=covered by test

Change-Id: I9dbd9f90b88cbdbdfbab9aab81840b986fcdc410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377552
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802416}

Previously during logout, when the notification came in to
SyncedNetworkMetricsLogger that the tether network status changed to
disconnected, the pref service was already destroyed.  When the metrics
logger attempted to check the network's metadata to see if it was
eligible for logging, it caused a crash.  This fix prevents querying the
metadata store for non-wifi or tether networks in the first place, it
also performs a null check on the metadata store before querying for
information about eligible networks in case something changes with the
timing of teardown during logout.

Fixed: 1122678
Change-Id: I8d273b4f7c0d1d0ee5f58fcbc6b946743d28456a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380083
Commit-Queue: Jon Mann <jonmann@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802415}

I2P: https://groups.google.com/a/chromium.org/d/msg/blink-dev/U5Iy4LrcwoI/dIlbC2OhAwAJ
Explainer: https://github.com/bialpio/webxr-depth-api/blob/master/explainer.md

Bug: 1119487
Change-Id: I81dcb8eb2b2fe3f599fcfb5d9b8fc4afe70d7fc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367739Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802414}

In the simplified domains hide-on-interaction field trial, we elide
the URL to the simplified domain (the most security-critical
information) when the user focuses a text form field, which can be a
moment where the user is making a security decision. However, this can
lead to a weird experience when webpages autofocus input fields
without user interaction. Therefore, this CL only elides the URL when
the user specifically clicks a form field to focus it. (Focusing by
keypress will already cause the URL to elide all keypresses trigger
elision via DidGetUserInteraction()).

Bug: 1104280
Change-Id: I016aa5df5ce34bf71ccec86401f9ed192f6d9ef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377322
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802413}

https://chromium.googlesource.com/angle/angle.git/+log/282596778418..1e068e1dbb62

2020-08-27 jonahr@google.com Suppress functional_shaders_indexing_tmp_array_*_const_* on Metal
2020-08-27 tobine@google.com Vulkan:Use roundUpPow2 where possible
2020-08-27 amy.liu@arm.com Disable forceOldRewriteStructSamplers on Mali.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: courtneygo@google.com
Test: Test: dEQP-GLES31.functional.uniform_location.nested_array.*sampler2D_*
Change-Id: I9d871ebf80dcf1db925cee244d438755fff5b55c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380043Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#802412}

https://skia.googlesource.com/skia.git/+log/532a264c141d..ee58da9d6f49

2020-08-27 johnstiles@google.com Remove unused `count_returns` method.
2020-08-27 johnstiles@google.com Prefer unique_ptr<> and make_xxxx over raw pointers and new.
2020-08-27 egdaniel@google.com Add GrInternalSurfaceFlag for vulkan input attachment.
2020-08-27 johnstiles@google.com Replace complex `count_returns` method with a ProgramVisitor.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: mtklein@google.com
Change-Id: I8179c2ce3eeebd14cddde42c3071eabd37ad20e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380206Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#802411}

The test
http/tests/devtools/sources/debugger/source-frame-inline-breakpoint-decorations.js
has been flaking on the WebKit Linux MSAN builder for a while now, so
this CL marks it as flaky.

https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/7280

TBR=szuend@chromium.org

Bug: 1122742
Change-Id: Ifcb0ba10cbb792b04be4c922866a4f02dc54eb68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380436Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802410}

Replace blink::FloatPoint3D by SkV3 and blink::TransformationMatrix by
SkM44.

Bug: 1091095

Change-Id: I4d5c386757365cd2e7dee8d5dcd5cb27c4576131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212226Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Prashant Nevase <prashant.n@samsung.com>
Cr-Commit-Position: refs/heads/master@{#802409}

SwANGLE needs to be told when to lock/unlock the IOSurfaces that
are being rendered to. This is accomplished via wrapping shared
GL image Begin/EndAccess in calls to Bind/ReleaseTexImage.

Bug: swiftshader:154
Change-Id: I9994dd6a2f01682b212175c353c0cb89c5b51d2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378539Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#802408}

This reverts commit 44e43142.

Reason for revert: Lots of builders are failing in gclient runhook.
https://ci.chromium.org/p/chrome/builders/ci/test-wifi-tablet/19099?

Original change's description:
> Reland "Temporary add verify_file_exists to check files downloaded."
> 
> This reverts commit 2b17e053.
> 
> Reason for revert: Reland initial cl after fix the typo
> 
> Original change's description:
> > Revert "Temporary add verify_file_exists to check files downloaded."
> >
> > This reverts commit e69f63a3.
> >
> > Reason for revert: Causing infra failures on chrome/ci/android-internal-chromium-tot, see crbug.com/1122206.
> >
> > Original change's description:
> > > Temporary add verify_file_exists to check files downloaded.
> > >
> > > R=​bsheedy@chromium.org
> > >
> > > Context: to make sure those wprarchive files are downloaded properly.
> > > Bug: 1096656
> > > Change-Id: Id0197c39f1a260bf9356269f41c12a46deecbf17
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378386
> > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> > > Commit-Queue: Arthur Wang <wuwang@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#801957}
> >
> > TBR=dpranke@google.com,bsheedy@chromium.org,wuwang@chromium.org
> >
> > Change-Id: I4d7f023d4e4d8f441d2cbdc33788e17f859377ab
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1096656
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378541
> > Reviewed-by: Brandon Wylie <wylieb@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > Commit-Queue: Brandon Wylie <wylieb@chromium.org>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Cr-Commit-Position: refs/heads/master@{#801977}
> 
> R=​bsheedy@chromium.org
> TBR=dpranke@google.com, wuwang@chromium.org, wylieb@chromium.org
> 
> # Not skipping CQ checks because this is a reland.
> 
> Bug: 1096656
> Change-Id: If288ccd984009baacb9dda60f14aa548ec94a272
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378892
> Commit-Queue: Arthur Wang <wuwang@chromium.org>
> Reviewed-by: Arthur Wang <wuwang@chromium.org>
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#802390}

TBR=dpranke@google.com,bsheedy@chromium.org,wylieb@chromium.org,wuwang@chromium.org

Change-Id: Ia62b89df8121aa6cbf6726a81f8f64a400a49d33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1096656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380742Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802407}