- 04 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/232ba0d848d1..8111268575a4 2020-06-04 laddoc@outlook.com Add Shared/Std140 SSBO process & top-level array elements related (#2231) 2020-06-04 apinheiro@igalia.com spirv: Support initializers on uniforms (#1588) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I1323ec24b3766310d895465b575ed57f5f8e772b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230660Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775037}
-
Ewann authored
This CL adds a mediator that handle Cookies settings for the page info. Bug: 103891 Change-Id: I03934822e4bf9cd3d8f7b57e1c777ed9c0fb934c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204122Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#775036}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4f8e4f934438..292a49b80b32 2020-06-04 szuend@chromium.org Preserve scroll position in 'What's new' when switching drawers 2020-06-04 alexrudenko@chromium.org Reuse contrastRatio and rgbaToHsla 2020-06-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1087452 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2e50c2e9084bbd37da65176753c1801bdd32945e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230698Reviewed-by:
-
Kent Tamura authored
If the selected OPTION label contains characters of which height is taller than the primary font, a shadow element containing the label expanded its line-height, however the SELECT box's height didn't expand. So its baseline was shifted. This CL gives a fixed line-height to the shadow element to fix the issue. Bug: 1085898 Change-Id: I24e2b5836c54550ee2e76537fb52ec6199441189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227947 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#775034}
-
Rakina Zata Amni authored
With crrev.com/c/2121522, some main-frame same-site navigations will result in a new BrowsingInstance, SiteInstance, RenderFrameHost, RenderView, etc. This CL updates expectations of tests under chrome/ and components/ that didn't expect a change of RenderFrameHosts etc. on same-site navigations. This CL does not include fixes to other tests in content/, chrome/, and layout tests (they are fixed in other CLs). For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing Bug: 977562 Change-Id: Ibb9c7e9da1a8d743c57a0a16c36a67e1464cf1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210605 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#775033}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ie6dc1b7e445a3fed73e8b737809c4ff425514899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230659Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/62b08f845fb9..783cd5a79c8a 2020-06-04 natlee@microsoft.com Avoid processing already processed tick If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ic037daca4dc78155ecded1a9a6441c087a05974e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230319Reviewed-by:
-
Alice Wang authored
This CL adds a simple account picker bottom sheet for the web sign-in flow. Its screenshot is in https://crbug.com/1081253#c1. Bug: 1081253 Change-Id: Iacd02020e9c3c203c367f272c9d38b629341870d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153164 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#775030}
-
Saho Kobayashi authored
Move Android focused id computation to a function from NotifyAccessibilityEvent in ax_tree_source_arc.cc. AXTreeSourceArcTest.* AX-Relnotes: n/a. Bug: None Test: ArcAccessibilityHelperBridgeTest.* Change-Id: I767807670548c4668da6c2f4c60cf1fbc8e86092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226330 Commit-Queue: Saho Kobayashi <sahok@chromium.org> Reviewed-by:Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#775029}
-
Vasilii Sukhanov authored
Fixed: 1089228 Change-Id: I4d0ac52cc4a7442851ff7a929b1e6dedf2873529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228496Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#775028}
-
Minoru Chikamune authored
HeapMojo wrappers require ExecutionContext to reset mojo objects when ExecutionContext is detached. Bug: 1049056 Change-Id: Ie496a4c11cedbbb185fa75524ebd7e94c4f7f9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217530Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#775027}
-
Martin Šrámek authored
This reverts commit 2fb9ab54. Reason for revert: Broke the 'isolate tests' step: crbug.com/1091149 Original change's description: > xvfb: Wait for ReparentNotify before executing tests. > > X11 tests can fail because start up of OpenBox is not > synchronous and it is unknown when exactly it starts up. > > That results in a client that uses X11 missing events > and flakiness of tests. > > Thus, to avoid that issue, use a small program that > creates a dummy X11 windows and waits for the > ReparentNotify event. That is, OpenBox decorates > all the windows once it is initialized that results > in that event. Once the event is received, we can > be sure that the WM is up and running, and tests > can be executed. > > Bug: 1078771 > Change-Id: Ic6fae30a706a6b9c32e4670da56457c833b4b7f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214526 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#775001} TBR=thakis@chromium.org,dpranke@chromium.org,thomasanderson@chromium.org,msisov@igalia.com Change-Id: Iadf54b030acc7358e2112212fd2aa6b2ed79e831 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1078771, 1091149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230482Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#775026}
-
dpapad authored
Specifically: - cr_toast_manager_test.js - cr_toast_test.js - cr_toggle_test.js - cr_toolbar_search_field_tests.js Bug: 1000989 Change-Id: I9d745caca24c46945e64faca96d9b87fcecd1af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227238 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#775025}
-
Wojciech Dzierżanowski authored
This makes HTMLME responsible for notifying the player about events affecting the progress of media position. The idea with position updates in Media Session is to minimize resource usage. Instead of firing IPC to the browser every 250 ms to update the position, we transfer the data necessary for the browser to compute the correct current position at any moment (media position, time when media position was determined, playback rate). This allows us to only update the browser at significant events like playback start, pause, seeking, rate change, etc. Previously, WMPI was responsible for knowing all the significant events, which wasn't trivial (see for example issue 1072396). It seems that, inevitably, trying to cover all the significant time-related events in WMPI would mean duplicating parts of the HTMLME logic. Bug: 1075458 Change-Id: I2f4c002fd06168f1225481c9a13b3d6f80013583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194000Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#775024}
-
Martin Šrámek authored
...to the 4th of June. Previously, it was the 3rd of June, but enabling of the experiment got delayed by one more day. Previous CL here: https://chromium-review.googlesource.com/c/chromium/src/+/2214548 Bug: 1032584 Change-Id: Idf4b7022647aaf228b1b3708940f7c51c18982d8 TBR: asvitkine@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230618Reviewed-by:
-
Yoshifumi Inoue authored
This patch Introduces |NGPhysicalFragment::ConvertToLogical()| to avoid common pattern in source code for improving code health. Change-Id: I49924e8698b4fabce09ebc21212da0e177aab78f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228440 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#775022}
-
Roman Sorokin authored
Track reauth reason which lead (or do not lead) to the cryptohome password change. Deprecate Login.ReauthReason metrics Also added browsertests for the metrics and for the token check on session start. Fixed: 1084947 Bug: 975285 Change-Id: Ic55a1bf7df12f6cb5c20cff81b5a9aeab87d59a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164897 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#775021}
-
arthursonzogni authored
Add some basic WPT tests about the COOP access reporting feature. No web browsers actually implement this. As a result, chrome do not pass them yet. The tests aren't complete yet, they will evolve along the specification and the implementations. Bug: 922191 Change-Id: Ie4675e5fb5ec0f839ca1527c15fafbb456925a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228884Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#775020}
-
Ewann authored
based on: https://crrev.com/c/2218308 This CL updates the tests to have them passing with the flag enabled. The feature is renamed but wasn't use, so no impact should be seen. Bug: 1073826 Change-Id: Ic98371c83216c9f2393e0d99cf5caa5df65c8ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226730 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Roman Sorokin authored
not used anymore. Bug: 958905 Change-Id: Ief1d248d19a571283a08320c472cb8f976a4d4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230460 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#775018}
-
Thanh Nguyen authored
This CL adds a normalizer for content extraction: 1. Remove diacritic marks 2. Convert text to lower case 3. Option to remove hyphens. Bug: 1091091 Change-Id: I981be8ac512a6bd9e28ab8418d41495e9cad9338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228633Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#775017}
-
Guido Urdaneta authored
* Mark Media.AudioInputDeviceManager histogram as obsolete * Extend Memory.AudioService histograms Fixed: 1088904, 1084068 Change-Id: I4e035701e0b708ca700b8b7fd1a0a1a055337d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225771Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change extends Password Manager histograms that were about to expire in M85. Fixed: 1089214, 1089215, 1089218, 1089222, 1089225, 1089226, 1089227, 1089231, 1089232, 1089235, 1089239, 1089240 Change-Id: Ie037386e3154ce05f9356acbd4aa421e503f3fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226811Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Changhao Han authored
DevTools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2228522 Bug: chromium:1082963 Change-Id: I805ebf837bc97e3bc75ddef7e405aad2d3555377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230459Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#775014}
-
Benoit Lize authored
Prerender is no more, remove the java tests. Bug: 1014213, 642392 Change-Id: I25bb948ad859b80ffa0610dade4b692b969d3917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228611Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#775013}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/988659151960..989c790d4b8b 2020-06-04 syoussefi@chromium.org Remove workaround for fixed compiler bug 2020-06-04 syoussefi@chromium.org Update and de-duplicate expectations file format comment 2020-06-04 msisov@igalia.com Add EGL_PLATFORM_ANGLE_NATIVE_PLATFORM_TYPE_ANGLE If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1084458,chromium:951458 Tbr: ynovikov@google.com Change-Id: Ia829f5499319f623d51d0b6cb85873be24f6416f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229541Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/722a8080e69d..4f8e4f934438 2020-06-04 alexrudenko@chromium.org Reuse blendColors util If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1078267 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I504b8cba9a46a5741e1d8be84cf98fbd41a08259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230118Reviewed-by:
-
Alexey Baskakov authored
Implement backward compatibility install of Web Apps via shadow Bookmark Apps. On a web app install initiated by user we also must install the shadow bookmark app. All install changes for the extensions registry get propagated to the sync server (syncer::ModelType::APPS) and to all devices where BMO is disabled. Design doc: go/chrome-bmo-migration. This is a partial re-land of https://chromium-review.googlesource.com/c/chromium/src/+/2162507 We do only user-initiated installs. We did shadow bookmark app for system web apps by mistake and it caused flakes and failures in many browser tests. TBR=zmin@chromium.org Bug: 1020037, 1086909 Change-Id: Iba49dce03f9d176ce00fc085d8d40da5328539ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228262Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#775010}
-
chrome://drive-internalsAustin Tankiang authored
These fields will only be enabled when in developer mode. Bug: 1049071 Change-Id: If592cce7569569a37016f7b92eae0f596beefa9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2178484 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#775009}
-
Antonio Sartori authored
In this change I refactored the ProcessResponseImpl function of the FrameAncestorThrottle so that it can process a list of different checks, and I moved into a subfunction the checks for the X-Frame-Options logic. In this way it will be easier to add additional checks to the FrameAncestorThrottle, that will be required for moving Content Security Policy - Embedder Enforcement out of blink. Change-Id: I6b5ff5a7c767e1c1c000d193742059aa47f1cae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218076 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#775008}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/15d5f65efa22..92c6c3ec3b9b 2020-06-04 fancl@chromium.org auto-bisect: Prevent auto-bisection starting on the same alerts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1091079 Tbr: wenbinzhang@google.com Change-Id: I84da92ce8233f79e6d4c1146d587c5204584532c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229547Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/10fb08669daa..d17b61931641 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mxcai@google.com Change-Id: I9f609e8de0cdfbf176273a70ddd72581e352cbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229543Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775006}
-
Julian Watson authored
Bug: None Change-Id: I2e5615ac4888d53a555e890f97e965592d7ce052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210601 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#775005}
-
Ewann authored
Bug: 1051609 Change-Id: Ife252c5ccad7457bd5944ddff93178ab046049b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228158Reviewed-by:
-
My Nguyen authored
In preparation for moving ui/chromeos/ime to chrome/browser/chromeos/input_method/ui, fix presubmit errors. Change-Id: I576ef32b13bd74b18a2e942aa6a5b2f0aaa69884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228016Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#775003}
-
Alex Rudenko authored
This reverts commit 68b09615. Reason for revert: after extensive testing, it seems that the fix makes the problem worse Original change's description: > Propagate color space in DevToolsEyeDropper > > Sets the color space for DevToolsEyeDropper's bitmap > > Bug: 884170, 1066415 > Change-Id: I2436c326f06dd7d68671cac9ae041fa63c93a60d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207370 > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770021} TBR=yangguo@chromium.org,petermarshall@chromium.org,mathias@chromium.org,alexrudenko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 884170, 1066415 Change-Id: I3eb31f9599e01d214a83563888e44c2332e9a995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228849Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#775002}
-
Maksim Sisov authored
X11 tests can fail because start up of OpenBox is not synchronous and it is unknown when exactly it starts up. That results in a client that uses X11 missing events and flakiness of tests. Thus, to avoid that issue, use a small program that creates a dummy X11 windows and waits for the ReparentNotify event. That is, OpenBox decorates all the windows once it is initialized that results in that event. Once the event is received, we can be sure that the WM is up and running, and tests can be executed. Bug: 1078771 Change-Id: Ic6fae30a706a6b9c32e4670da56457c833b4b7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214526Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#775001}
-
Maggie Cai authored
This reverts commit 8400e57d. Reason for revert: There are service worker tests failures on multiple builders, and this CL is the only one that is related to service worker, revert to see if this is the cause. first failure on failed builders: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20Tests%20%28sandboxed%29/67399 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20%281%29/77750 https://ci.chromium.org/p/chromium/builders/ci/win-asan/12523 Original change's description: > Use ServiceWorkerStorageControl::GetNewRegistrationId() > > This CL replaces ServiceWorkerStorage::GetNewRegistrationId() call > with the corresponding mojo method as a preparation for the Storage > Service migration. > > This CL increases the android binary sizes by ~30kb. Most of the > increase (~29kb) comes from mojo generated code and there isn't much we > can do to reduce them. Introducing the mojo interface is necessary for > migrating ServiceWorkerStroage to the storage service. See the design > doc [1] for the motivation of the migration and plans. > > [1] https://docs.google.com/document/d/1hO0WEuoEOgEBlf5nDE3fDjuQY2bV_d5hLtk25iBo0LM/edit?usp=sharing > > Bug: 1055677 > Binary-Size: Size increase is unavoidable (see above) > Change-Id: I33e1e72b1da94ae02dfbe2a929895fc36e216e66 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217935 > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774947} TBR=falken@chromium.org,rockot@google.com,bashi@chromium.org Change-Id: I00de43c78d0e16b6031d4b766d156df6b4352370 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230378Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#775000}
-
Christopher Lam authored
This CL is a speculative fix for a Feedback App crash. Bug: 1010336 Change-Id: Ifc97455fbf942af41dc54417cc7449b888577d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210602Reviewed-by:
-
Wenbin Zhang authored
This CL puts testers mac-10_12_laptop_low_end-perf and mac-10_13_laptop_high_end-perf in lightweight mode with '--skip-perf'. In this case the tests will no longer upload the perf data. Bug: chromium:1045256 Change-Id: I8967790700383d0a86a50e58c2047ac7563247bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229883Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#774998}
-
