GitLab

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/31d539486159..41ff7a035785


git log 31d539486159..41ff7a035785 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@41ff7a035785

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I0fadd83cdcff0d1551d3e6a76967c83d67626280
Reviewed-on: https://chromium-review.googlesource.com/1100118Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567106}

Update navigator.requestMediaKeySystemAccess() to support querying for
encryption scheme support. This is based on
https://github.com/WICG/encrypted-media-encryption-scheme/blob/master/explainer.md.

BUG=657957
TEST=new layout and browser tests pass

Change-Id: I5ba39861bab673a61dd65c12fe82d6ba3bd63ddb
Reviewed-on: https://chromium-review.googlesource.com/959459Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567105}

Method injects a binding object to the target's main frame that
allows communication with browser target.

R=pfeldman, dgozman

Change-Id: Ic36a058c2cba41fccb9419318676a4fdc04a8454
Reviewed-on: https://chromium-review.googlesource.com/1066289
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567104}

In order to update counter-reset correctly, MoveNonResetSiblingsToChildOf
is called, so the non-reset sibling will become the child of this reset
CounterNode. If this reset node is nested inside another CounterNode,
the sibling's nested layer won't be correct. So we should skip calling
MoveNonResetSiblingsToChildOf() in the nested case.

Bug: 849107
Change-Id: I8c59e18785dfec18c4bc2053e9c01041c23e4183
Reviewed-on: https://chromium-review.googlesource.com/1098867Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: cathie chen <cathiechen@tencent.com>
Cr-Commit-Position: refs/heads/master@{#567103}

The file size is very useful for the user and it's in the UI design.

This CL adds the pipeline to show the file size in download location
dialog.

Bug: 846222
Change-Id: I972955571a6dd8b781c784167a4aee697b98d486
Reviewed-on: https://chromium-review.googlesource.com/1097713
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567102}

This CL changes the back button of a detailed view to have custom shape
following the UX spec.

To do this, this CL splits CustomShapeButton from CollapseButton, and
derives CollapseButton and BackButton from CustomShapeButton.

Screenshot: http://screen/Lkuj2DJCYHP
UX spec: http://shortn/_N5oGsw6QZ0

TEST=manual
BUG=850396

Change-Id: I08554db7e78e710e96dd670917d612dbadee5ccb
Reviewed-on: https://chromium-review.googlesource.com/1096813Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567101}

Related CL https://chromium-review.googlesource.com/c/chromium/src/+/1065964
see testing/buildbot/filters/mash.ash_unittests.filter

Bug: None
Change-Id: Ia2f278b23ff20ed6084a9482e2e47c6206489be0
Reviewed-on: https://chromium-review.googlesource.com/1098415
Commit-Queue: Sara Kato <sarakato@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567100}

This CL is desirable today, to avoid the memory leaks associated with
queueing of IPCs that are sent to RenderProcessHosts that are
constructed, but not yet initialized - such RenderProcessHosts
accumulate IPC messages and flush them only after renderer process is
actually launched at a later point / after a call to RPH::Init.
This aspect of the CL is very similar to r562797 which landed earlier.

This CL is desirable for the future - a tentative long-term plan for
https://crbug.com/813045 is to avoid creating an IPC channel before
RPH::Init is called.  This means that in the long-term
RPH::GetChildIdentity will crash (dereferencing a nullptr
|RenderProcessHostImpl::child_connection_|) if called on an
uninitialized RPH.  This CL ensures that this crash won't happen in
ClientSideDetectionService::SendModelToProcess and
SpellcheckService::OnCustomDictionaryChanged by ensuring that these
methods only work with already initialized RPHs.

The changes under //chrome/browser/spellchecker and
//chrome/browser/safe_browsing skip uninitialized RPHs for 2 specific
IPCs/subsystems.  The changes under //content/browser/renderer_host
prevent future IPCs/subsystems from using uninitialized RPHs, by
adding a DCHECK to RenderProcessHostImpl::GetChildIdentity.
The new DCHECK necessitates setting |is_initialized_ = true| much
earlier in RenderProcessHostImpl::Init (because
ChromeContentBrowserClient::RenderProcessWillLaunch needs to call
RPH::GetChildIdentity).

Bug: 813045
Change-Id: I4783de85cb7c199ab360f8361acd54c63287e1df
Reviewed-on: https://chromium-review.googlesource.com/1095433Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567099}

Refresh changes the amount of extra padding added to the left of the
favicon. But when the tab is too small to accommodate this extra
padding, Refresh was failing to remove this padding and calculate
icon visibility correctly.

This also fixes TabTest.LayoutAndVisibilityOfElements when Refresh is
enabled.

Bug: 846410, 822061
Change-Id: I2b77b976d55e314da3e6b5193403eb2a102dd426
Reviewed-on: https://chromium-review.googlesource.com/1098148Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567098}

Existing code was multiplying ints in a context where an intermediate
result could overflow the 32-bit container. Change to explicitly use a
64-bit long long for the intermediate product to avoid undefined
behaviour.

Found by UBSan / clusterfuzz

Bug: 852435
Change-Id: I683eee6eda51f40e7f165c0a55111fba623c2ec9
Reviewed-on: https://chromium-review.googlesource.com/1099756Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567097}

https://pdfium.googlesource.com/pdfium.git/+log/571053a44f87..8e631772e342


git log 571053a44f87..8e631772e342 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 tsepez@chromium.org Collapse some more xfa/non-xfa code in cpdfsdk annots.


Created with:
  gclient setdep -r src/third_party/pdfium@8e631772e342

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I88fc81f18e1b1dd8967c22005c72aac1bbaf81dc
Reviewed-on: https://chromium-review.googlesource.com/1100117Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567096}

- Creates TableViewLoadingView, which is added as a backgroundView of ChromeTableVC.
- HistoryTableVC adds this TableViewLoadingView instead of implementing its own.
- Re-adds searching property to HistoryTableVC.

Screenshot:
https://drive.google.com/open?id=1gXnkLADyKrv3hqtijU7Su9t8gW0hR7el

Bug: 838577
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id494826f4bd522062f7d30bf4c6e7e81ceba6370
Reviewed-on: https://chromium-review.googlesource.com/1041187
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567095}

This reverts commit 4a2a5c4a.

Reason for revert: seems to be a bit too new of a flag for the xcode version of clang: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator-xcode-clang/51865

Original change's description:
> build: Pass -fcomplete-member-pointers when building with clang.
> 
> This prevents member pointers of incomplete base type from being used in
> cases where they might cause problems under the Microsoft ABI.
> 
> Specifically, the Microsoft ABI has different kinds of member pointers with
> different sizes, and the choice of member pointer representation depends on
> the inheritance hierarchy of the member pointer's base type. C++ allows a
> member pointer's base type to be incomplete, so if it is incomplete at the
> point where a variable of that member pointer type is declared, that forces
> the compiler to pick the most general (i.e. largest) one. That can lead to
> ODR violations since the most general representation wouldn't necessarily
> be the one that would be chosen if the base type happened to be complete at
> the point where the variable was declared. It can also be less size efficient
> because the compiler will generally be able to choose a smaller representation
> than the most general one if it were complete at the point where it is needed.
> 
> This flag also enables additional semantic analysis that we'll need in order
> to correctly implement -fsanitize=cfi for member function pointer calls. This
> is because the inheritance hierarchy of the base type must be available in
> order to make the CFI checks as precise as possible.
> 
> Note that the flag is a -f flag rather than a -W flag. This is because
> requiring member pointer base types to be complete is technically a
> non-conforming language extension, as it may, for example, cause templates
> to be instantiated which would otherwise not be, which may be observable
> after code generation in conforming programs that were crafted to observe
> it. However, the effects of this language extension should not be observable
> in most ordinary programs.
> 
> Bug: 847724
> Change-Id: I8d823fd4a6f21dfcadba55eefc0a69ef2e0c3479
> Reviewed-on: https://chromium-review.googlesource.com/1098217
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567086}

TBR=thakis@chromium.org,pcc@chromium.org

Change-Id: Ieb56b1bb4236a874ecc4846eb3ad73a87d9bdf82
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847724
Reviewed-on: https://chromium-review.googlesource.com/1100516Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567094}

Shaderc currently does not build and is used in a Vulkan test.
The upstream version of Shaderc has fixed the issue preventing the
build. However, we may not actually want Shaderc.

Currently, Shaderc is only being used in a unit test. It is possible
that in the future we will want to compiler GLSL at runtime. But there
are no plans for that right now.

BUG=852620

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4edc119b6fe36851901a0b03924613c161db7c7e
Reviewed-on: https://chromium-review.googlesource.com/1100298Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567093}

Following CL:1074989 that fixed inline-level baseline for
flipped-lines (vertical-lr), this patch fixes block-level
baselines.

When NGBlockLayoutAlgorithm propagates baselines from its
child line boxes, line boxes and font metrics are in the
[line-relative] coordinates. This needs to be converted to
[flow-relative] coordinates when adding to box fragments.

[flow-relative]: https://drafts.csswg.org/css-writing-modes-3/#logical-directions
[line-relative]: https://drafts.csswg.org/css-writing-modes-3/#line-directions

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: If4ddc2374cc0351120ae672614a32f38bb1f3bc8
Reviewed-on: https://chromium-review.googlesource.com/1087192Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567092}

This change prepares GamepadSharedMemoryReader for the move to blink
by removing its inheritance from RendererGamepadProvider and moving
listener-related logic to GamepadSharedMemeoryReader.
Since the GamepadSharedMemoryReader instance can no longer be stored
in RendererBlinkPlatformImpl::platform_event_observers_, a separate
variable has been added temporarily that will be moved to
GamepadDispatcher along with the logic when the
GamepadSharedMemoryReader class is moved to blink.

Bug: 612330
Change-Id: I4a6e2dd1af5afb52f7f6a980eb8aace7642426ac
Reviewed-on: https://chromium-review.googlesource.com/1096349
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567091}

When a controller doesn't have fetch event handlers we should not route
requests to ServiceWorkerSubresourceLoader for no fetch optimization.
Bypass ServiceWorkerSubresourceLoader when there is no ControllerServiceWorker.
This works because ControllerServiceWorker is set only when the controller
has fetch event handlers.

Bug: 847322
Change-Id: I6e76a415b5b3c9156bce8676a79312c09307595c
Reviewed-on: https://chromium-review.googlesource.com/1096584
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567090}

Bug: 843891

Change-Id: I7fba61c7a46a8d0b6a3dabdc37b9209510c9cb15
Reviewed-on: https://chromium-review.googlesource.com/1064651Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567089}

Now that we no longer send gesture pinch events to OOPIF renderers,
we can remove the check for the InnerViewportScrollNode before the
snap-to-min page scale animation and have it be a DCHECK instead.

Bug: 787924, 791885
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I834a40ed6df46fa48abb3662a0331cc7bc1365c0
Reviewed-on: https://chromium-review.googlesource.com/1087399
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567088}

https://chromium.googlesource.com/angle/angle.git/+log/9327981248e7..4cc753e01054


git log 9327981248e7..4cc753e01054 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 jmadill@chromium.org Vulkan: Implement sampler arrays.
2018-06-13 jmadill@chromium.org Vulkan: Fix qualifier replacement for sampler arrays.
2018-06-13 jmadill@chromium.org Vulkan: Store Pipeline/DS Layouts in ProgramVk.
2018-06-13 jmadill@chromium.org Vulkan: Add PipelineLayout and DescriptorSetLayout caches.
2018-06-13 tobine@google.com Migrating ANGLE to split LVL repos
2018-06-13 lucferron@chromium.org Vulkan: Clamp the point size range to have a min value of 1.0


Created with:
  gclient setdep -r src/third_party/angle@4cc753e01054

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Ie11e85e6485cbb6dd28fd95bcf19c95e5086746e
Reviewed-on: https://chromium-review.googlesource.com/1100115Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567087}

This prevents member pointers of incomplete base type from being used in
cases where they might cause problems under the Microsoft ABI.

Specifically, the Microsoft ABI has different kinds of member pointers with
different sizes, and the choice of member pointer representation depends on
the inheritance hierarchy of the member pointer's base type. C++ allows a
member pointer's base type to be incomplete, so if it is incomplete at the
point where a variable of that member pointer type is declared, that forces
the compiler to pick the most general (i.e. largest) one. That can lead to
ODR violations since the most general representation wouldn't necessarily
be the one that would be chosen if the base type happened to be complete at
the point where the variable was declared. It can also be less size efficient
because the compiler will generally be able to choose a smaller representation
than the most general one if it were complete at the point where it is needed.

This flag also enables additional semantic analysis that we'll need in order
to correctly implement -fsanitize=cfi for member function pointer calls. This
is because the inheritance hierarchy of the base type must be available in
order to make the CFI checks as precise as possible.

Note that the flag is a -f flag rather than a -W flag. This is because
requiring member pointer base types to be complete is technically a
non-conforming language extension, as it may, for example, cause templates
to be instantiated which would otherwise not be, which may be observable
after code generation in conforming programs that were crafted to observe
it. However, the effects of this language extension should not be observable
in most ordinary programs.

Bug: 847724
Change-Id: I8d823fd4a6f21dfcadba55eefc0a69ef2e0c3479
Reviewed-on: https://chromium-review.googlesource.com/1098217
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567086}

Since Chrome is the only thing that loads these files, there's no need
to force them to use JSON escapes for non-ASCII Unicode codepoints.
Just use native UTF-8 encoding everywhere (especially since all the
files already have Unicode BOM's in them!).

It shouldn't make the readability of the files worse.  If anything, it
should improve it greatly, especially relative to the source grd files
(which use UTF-8), and for native readers.  Example delta for Arabic:
	CHROMEVOX_COLUMN_GRANULARITY
-		"\u0639\u0645\u0648\u062f"
+		"عمود"

On a Pixelbook, converting all the messages.json files in this way
shaves off ~1.4MiB.

Bug: 852585
Change-Id: I1978141717bbd69aec5a72c9d6769c6998419c1b
Reviewed-on: https://chromium-review.googlesource.com/1099881Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567085}

I just realized luci.chromium.ci sets the default value of cores to 8,
however, the mac-code-coverage-generation builder has 24 cores:
https://chromium-swarm.appspot.com/bot?id=build227-m9

Bug: 825362
Change-Id: If017fca1c47b798c2573f50d37e1a7823595181c
Reviewed-on: https://chromium-review.googlesource.com/1098645Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567084}

Implements share discovery for SmbHandler and SmbService using
SmbShareFinder

Bug: 757625
Change-Id: Ib3baa0b307ab95c17f38b47339f264231831752e
Reviewed-on: https://chromium-review.googlesource.com/1089855
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567083}

This CL splits the Autoplay-related code from BAC to AC. It simply
changes the code location without changing logic.

Note that the code around resume() promise resolvers has not been
modified in this CL. The code is not directly related to the auto
play and it needs a bit of rewriting.

Bug: 851608
Test: AudioContextAutoplayTest
Change-Id: I2e0b2b10fc56e86e4724635aba0fe452c73c54da
Reviewed-on: https://chromium-review.googlesource.com/1097988Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567082}

Threat Details had a few odd behaviors. If you had multiple threats,
and opened a new chrome://safe-browsing tab, only the oldest threat
would be shown on the new tab. Also, all threats prior to opening a
close and reopen the tab.

chrome: //safe-browsing tab were logged, so if you open a new
chrome: //safe-browsing tab, you see old threats that disappear if you
Change-Id: Ie2549cbe71fea6b30e013994f20d595df1b2195a
Reviewed-on: https://chromium-review.googlesource.com/1099691
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567081}

This CL plumbs the has_transparent_background bit through RenderFrameMetadata
on android when surface synchronization is enabled. This enables the correct
background color to be displayed when surface sync is on on android.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id8ca61371cbe04a7ea58fbbf255bf80f6208e2b8
Reviewed-on: https://chromium-review.googlesource.com/1100065
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567080}

It's not used.

Change-Id: I8843e987f735af283f69727f86b8cc245ac4cbae
Reviewed-on: https://chromium-review.googlesource.com/1099840Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567079}

Use a descendant combinator CSS selector to query for USB/MTP volumes:
it is shorter and more idiomatic with volume code selectors.

Other clean-up while here: add a comment for load File app step. Where
an argument in a test step function is unused, remove it.

Test: browser_test --gtest_filter="FileDisplay/FilesApp*"
Bug: 836254,851888
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I88b04907ed04b355d8de9412ba748ca1ce0ced21
Reviewed-on: https://chromium-review.googlesource.com/1098907Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567078}

Use a decendant combinator selector to query for the USB volume: it is
shorter and more idiomatic with other volume selector JS test code.

Test: browser_test --gtest_filter="*FilesApp*copyBetweenWindows*"
Bug: 836254,851888
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I70b9ecad9e57db6a2d0028ba329707c5574710e8
Reviewed-on: https://chromium-review.googlesource.com/1098908Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567077}

R=dpranke
BUG=None

Change-Id: I7ca639867a7a31738d8fe1fc9d0db365a92cba88
Reviewed-on: https://chromium-review.googlesource.com/1081555
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567076}

Code search for USB_VOLUME_QUERY suggests many uses of child selectors
from the #directory-tree. Alternative is to use descendant combinator:
#directory-tree [volume-type-icon="xxxxx"] to query for volumes, which
is shorter and more idiomatic with the volume code selectors.

Unless we need to test a child element for [active], or similar, it is
perhaps less confusing to use the descendant combinator [1].

[1] Future changes might clean up the use of child selectors in volume
MTP|USB|ETC_VOLUME_QUERY in the relevant test cases.

No change in behavior, no new tests.

Test: browser_test --gtest_filter="QuickView/FilesApp*"
Bug: 851888
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2f64c624e05d0051750ee49ed6e7fabbef43b512
Reviewed-on: https://chromium-review.googlesource.com/1098905Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567075}

This CL plumbs through additional data when surface synchronization is on on Android for:

1. IME
2. Accessibility
3. OverScrollController
4. view FrameInfo
5. GestureListenerManager

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I812daf08fa00cfba2d92cffaf988604593299c81
Bug: 672962
TBR: yfriedman@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1097937
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567074}

The icon has been on by default since M67, and the updating of the
component is causing bizarre crashes.

Bug: 851983
Change-Id: I41267744e87861fdb889ec4f6bdca67327539a25
Reviewed-on: https://chromium-review.googlesource.com/1099875Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567073}

The externs_list is used by the Closure compiler, to type check imported
terms like 'chrome.fileManagerPrivate.foo', and to ensure that when
minimizing JS code from 'foo.bar.baz()' to 'a.b.c()', well known names
like 'chrome' aren't minimized.

However, the files_manager app does not ship Closure-compiled code in
production. It ships uncompiled code - the .js files as written by the
programmer. Instead, the externs_list is used indirectly by the
js_type_check("closure_compile") rules as a lint-style check.

Prior to this CL, maintaining the externs_list was therefore ad hoc and
indirect. For example, the hand-written and hand-maintained BUILD.gn
files would contain rules like:

js_library("foo") {
  deps = [
    "../../common/js:elephant",
    "../../common/js:giraffe",
  ]
  externs_list = [
    "../../../externs/apple.js",
    "../../../externs/banana.js",
  ]
}

where foo.js might not refer to externs/apple.js any longer, and it
might actually depend on externs/pear.js that is only coincidentally
satisfied because common/js/giraffe.js happens to list externs/pear.js
on its externs_list. This might be true at any particular point in time,
but as new code is added, and as existing code is refactored, the
externs_list entries become stale.

After this CL, each js_type_check("closure_compile") target has an
associated js_library("closure_compile_externs") BUILD.gn target. This
gives exactly one place to list all the external dependencies of every
Closure compilation target.

Future commits may re-organize the very fine grained (only 1 .js file
per js_library BUILD.gn target) js_library targets into larger units,
and in doing so, push duplicated externs_list entries from the leaves of
the BUILD.gn dependency tree towards the root. This could arguably help
us move towards shipping Closure compiled JS instead of hand-written JS.
But the first step is to get a handle on the dependencies (i.e.
externs_list entries) in the first place.

Test: "ninja ui/file_manager:closure_compile" runs without error
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1a3b029b5223db12abd38077d56914ad9d28a396
Reviewed-on: https://chromium-review.googlesource.com/1092399Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567072}

The test_support target should expose //services/network/public/mojom and ../cpp
so we can avoid making embedder test targets to explicitly depend on
//services/network/public/mojom and ../cpp.

See https://chromium-review.googlesource.com/c/chromium/src/+/1095594 for an
example.

TBR:bauerb@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib60c096e1c29f90c08204141a43454944c9934ed
Reviewed-on: https://chromium-review.googlesource.com/1099138
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567071}

Bug: None
Change-Id: I7f4214c2ba46c3e79bed607748e0e3ec045feab8
Reviewed-on: https://chromium-review.googlesource.com/1098745Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567070}

All masks must be PictureLayers, but the type is currently a Layer
regardless. This means the Layer API has to include things for masks
only, which are virtual and overridden only by PictureLayer. Instead
they could just be members of PictureLayer.

This changes the type on cc::Layer to hold a PictureLayer as a mask
instead, and changes callers to work with PictureLayer types directly.
They already had a PictureLayer, because masks must be one, but they
had it upcasted to a cc::Layer.

This makes the GraphicsLayer::CcLayer() return a PictureLayer* instead
of the base class Layer*, which means consumers of GraphicsLayer get to
know about PictureLayer. Since we're moving toward a world with only
content layers, and hopefully no base class, this follows that pattern
of introducing code to the real type sooner rather than later.

R=jbroman@chromium.org, pdr@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7b0fe935c69e9a0f2ee294c722b2372013617dfc
Reviewed-on: https://chromium-review.googlesource.com/1098152Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567069}

This is a reland of e9753daf

Original change's description:
> Supports the new vsh-into-running-container syntax
> 
> It is no longer necessary to use the run_container.sh script every time a
> container shell is needed. If the container is already running, vsh now allows
> "direct access".
> 
> Bug: 848447
> Change-Id: Ia9aeb120befd016386816cdd16fb3336b45426ff
> Reviewed-on: https://chromium-review.googlesource.com/1082055
> Reviewed-by: Timothy Loh <timloh@chromium.org>
> Commit-Queue: Nicholas Verne <nverne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563568}

Bug: 848447
Change-Id: I17c73a37a65a8316e62154556ee94fbc37dd703d
Reviewed-on: https://chromium-review.googlesource.com/1096875Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567068}

https://chromium.googlesource.com/catapult.git/+log/0db1e01e3f4c..78a0b0424642


git log 0db1e01e3f4c..78a0b0424642 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 benjhayden@chromium.org Refactor Anomaly queries.


Created with:
  gclient setdep -r src/third_party/catapult@78a0b0424642

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I45688b16d5b00c2e090bb5f808f33305b0f37d85
Reviewed-on: https://chromium-review.googlesource.com/1099977Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567067}