- 10 Oct, 2019 40 commits
-
-
Dominik Röttsches authored
This reverts commit dcdf3924. Reason for revert: Flaky on linux-chromeos-rel, see https://crbug.com/1013148 Original change's description: > arc: Provide replacement for deprecated PlayStoreShown UMA > > This rolls new set of UMA that replaces derpecated PlayStoreShown UMA > DD: > https://docs.google.com/document/d/1vfJMzoYsXtH-HWYydbb5VJvpT6WeJrfvaO81RHI5v2M/edit > > BUG=b:142251935 > TEST=Locally + unit tests. > > Change-Id: Ie2ec139b41e702dda604d92324b426782ed494ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845935 > Commit-Queue: Yury Khmel <khmel@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704384} TBR=xiyuan@chromium.org,yusukes@chromium.org,isherman@chromium.org,khmel@chromium.org Change-Id: Ie870309e4d2b879679e79d3b468736e51bab096f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:142251935, 1013148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852785Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#704615}
-
Elly Fong-Jones authored
This is now a property of an instance rather than a delegate method. This change introduces one minor behavior change: on Windows, HungRendererDialogView used to use a custom frame when Aero Glass was enabled; it will now use a custom frame when Aero Glass is enabled *or* the dialog is parented. I think the old behavior was a bug - it is not supported to use a custom frame with no parent window. Some reworking of the DialogTest suite was required, because this suite used to override ShouldUseCustomFrame to return true despite not having a parent widget for the test dialogs. This change introduces a parent widget so that these tests continue to get the custom frame they desire. Bug: 1011446 Change-Id: Ib3a8521368e1d7d779c2346fc74c97633fd13f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846317Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#704614}
-
Daniel Nicoara authored
Create a message that will be used by JS message channels to pass data back into the Webview client. Bug: b/141864193 Test: Compiled Change-Id: Iada17bc8f3cf1276f3a59813406f67bc43af8247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850363Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#704613}
-
Lowell Manners authored
This CL addresses a bunch of TODOs to properly set FrameHostMsg_DidCommitProvisionalLoad_Params on BackForwardCache navigations. With this CL, we store the DidCommitProvisionalLoad_Params used for the navigation on RenderFrameHostImpl, so that it can be reused when restoring from the BackForwardCache. This approach should be somewhat more future proof, particlarly when adding new fields to DidCommitProvisionalLoad_Params. In order to prevent any change in memory usage, the parameters are only stored on the RenderFrameHostImpl if BackForwardCache is enabled. Change-Id: Idb72e7366876e59d1dfd046fa83284f6f280422c Bug: 1005718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819251 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#704612}
-
Arthur Hemery authored
Filtering remaining failing tests after increased sharding. Bug: 1007276 Change-Id: I75b67a9a9e60b5aa1741b2a33cdd53c35936f3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852249Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Canon Mukai authored
There were some differences between CompressionStream and DecompressionStream. So I aligned them. Also, I made CompressionStream accept BufferSource. Bug: 999091 Change-Id: Iaf6c3e54804a10ef22d05c5f4da0d5ae07d0e765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847605 Commit-Queue: Canon Mukai <canonmukai@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#704610}
-
Daniel McArdle authored
Bug: 1012848 Change-Id: If0b9c22bcf3d8341d826dfbc718fe47ebb6328ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850432 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#704609}
-
Thomas Tangl authored
- The profile feature buttons are added - Browser tests for the guest profile are re-enabled after crrev.com/c/1848371 - Autofill buttons are not shown in incognito mode - The guest profile is moved to selectable profiles Bug: 995720 Change-Id: I8499848add6fcc06bb984ce79c4bc5f36ac4546a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850155Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#704608}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c89b6cab. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Icac6ce43c8297b2649fc8f13232ecff7ae18e0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852666Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704607}
-
David Roger authored
Only one test is flaky: EndToEndTestServerPush.ServerPushOverLimitNonBlocking However, it's not possible to disable only this test, because it's in a third party repository. This CL excludes the whole file from the build instead. TBR=rch Bug: 1010206 Change-Id: Id897407c56f59e632159c73a8d82f669e7c748ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852207Reviewed-by:
-
Maksim Sisov authored
No functionality changes here, but just moving the code and implementing missing interfaces in PlatformWindow. Bug: 990756 Change-Id: Ia39b15c580ea831a5e31bb6d76a807b3321c4f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844820 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#704605}
-
Antonio Gomes authored
... in favor of its Blink renderer child class, RTCCertificateGenerator. CL also the alias WebRTCCertificateCallback to RTCCertificateCallback. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I05c68fc040cd1842052a639425dcc6654b11c8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814606 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#704604}
-
Thomas Tangl authored
- The sync error description is set to either: "Sync is paused" or "Sync isn't working" - The sync button (no error) is changed to "Sync is on" - The bottom heading is changed to "Other people" Bug: 995720 Change-Id: I0f329462773f76c50d44fd178835474c01757b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849898 Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Francois Doray authored
With this CL, PerformanceManager(Impl)::CallOnGraph can safely be called from any sequence, at any time. The callback does not run if the call is made before creation of after destruction of the Performance Manager. Implementation details: CallOnGraph always posts a task to the Performance Manager sequence. When the task runs on the Performance Manager sequence, it checks if a global pointer to the Performance Manager if set. This is not racy because the pointer is only modified from the Performance Manager sequence. If the pointer is set, the task gets the Graph from it and invokes the callback that was passed to CallOnGraph. Otherwise, the callback does not run. Bug: 980533 Change-Id: I3d640e0ae13d012d76bab1483a5d59afb977c1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849213 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704602}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in services/shape_detection to the recommended methods/types. Bug: 1007831 Change-Id: Ie7ff4256ee62271fc7c3fe2b4acb17b791314090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839954 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#704601}
-
Tim van der Lippe authored
- Also upgrade the refactor script to automatically add the extensionpoint to the BUILD.gn to save myself some typing. Bug: 1006759 Change-Id: I3f789f96122569141194ce26ac288f01af68f6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852209Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#704600}
-
Jan Krcal authored
This CL fixes a glitch with spacing between image and label when the button is shrinking down its label. Before this CL, the preferred size jumped by this spacing _at the end_ of the animation when GetText() becomes empty. This CL makes LabelButton disregard this spacing at the beginning of the animation. Bug: 1002160 Change-Id: I213d2ba50aefde01dba1b2615ef47b38f9e3b94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849388 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#704599}
-
David Roger authored
A lot of GCM tests are flaky. Disabling the worst offenders. Tests disabled: GCMChannelStatusSyncerTest.DisableRestartAndEnable CMDriverFunctionalTest.MessageReceived GCMDriverFunctionalTest.MessageWithCollapseKeyReceived GCMDriverInstanceIDTest.GCMClientNotReadyBeforeInstanceIDData CMDriverFunctionalTest.RegisterAgainWithDifferentSenderIDs GCMDriverFunctionalTest.RegisterAgainWithSameSenderIDs GCMDriverFunctionalTest.RegisterError GCMStatsRecorderImplTest.CheckinTest GCMDriverFunctionalTest.RegisterAfterUnfinishedUnregister TBR=peter Bug: 1010462 Change-Id: Ibb6f80366d356cbd28fffb567095f282fbca12c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852445Reviewed-by:
-
David Roger authored
TBR=tommycli Bug: 1012211 Change-Id: I81816b35680dd3be345e2b699779663cc11bdd74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852784Reviewed-by:
-
Lily Chen authored
This change allows the SameSiteDataRemoverImpl to use the appropriate CookieAccessSemantics value when determining whether a cookie is effectively SameSite=None. Bug: 978172 Change-Id: I214e115b08d9591462f8405d9e7420bda481db48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846316 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#704596}
-
Jan Krcal authored
This CL keeps the user email shown also if parent container is focused or hovered. It introduces a notification from the container towards the avatar button when the highlight state changes. In a follow-up CL the same notification will also be used to hide the border of the button. Bug: 967317 Change-Id: I80866957d7098c675ad20d7fd03d1f45ad5aeec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826678 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
David Roger authored
TBR=meacer Bug: 1010678 Change-Id: Iebd944e30415975bfef89c793a900cb5dfce6339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852250Reviewed-by:
-
Javier Ernesto Flores Robles authored
This is a reland of b400d6c7 Original change's description: > [iOS][MF] Fix search in all passwords > > If the password view controller was presenting something, it will stay > around. This is fixed and a test is added. > > Bug: 1008421 > Change-Id: I8248cbbf28be94bc4b84c65ccda42129a192db0b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826895 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702358} Bug: 1008421 Change-Id: I04c8b6baa91c87884c6b792cb67fa75cc8faed6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852284Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704593}
-
Rayan Kanso authored
TBR=mkwst@chromium.org Bug: 687444 Change-Id: Iaae3fe5443c12982fa10d22c85a0894630a8354d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831774 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#704592}
-
David Roger authored
TBR=jshikaram Bug: 1013094 Change-Id: I9f16d2bf56f1e9de6685a9058a31cf71bf3cd3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852246Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibe15c8703131ecceb5b8be3571b31ec8c99faf4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852569Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704590}
-
Jan Wilken Dörrie authored
This change changes the type of CredentialPair::is_public_suffix_match from bool to a strong bool alias and updates callers. Bug: 945300 Change-Id: Ibea7fda806f07575635e66dce933b0fb218945cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849389Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#704589}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/35d020e5..5fdd5453 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib19cbf70e67f3ead4f906c038cb80e36028d1b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852667Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704588}
-
Matthias Körber authored
Changed |PresubmitError| to |PresubmitPromptWarning| to allow the call. Bug: 1013121 Change-Id: I1e38d8efb7c6bdf21568924e2cd51126a4e50aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852208Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#704587}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/066c2ab92f80..03f4b36bdd9a git log 066c2ab92f80..03f4b36bdd9a --date=short --no-merges --format='%ad %ae %s' 2019-10-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d9b4f45e..651f5a29 (704251:704530) 2019-10-10 danilchap@webrtc.org Replace virtual RtcpPacket::SetSenderSsrc with base member 2019-10-10 aleloi@webrtc.org Revert "Implement rollback for setRemoteDescription" 2019-10-10 nisse@webrtc.org Fix handling of large packets in RtxReceiveStream 2019-10-10 gustaf@webrtc.org Bypass unnecessary resampling. 2019-10-10 mbonadei@webrtc.org Add missing dependencies to the static library. Created with: gclient setdep -r src/third_party/webrtc@03f4b36bdd9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:980875,chromium:b/130016532,chromium:None Change-Id: I1445909db68fb45faa26e6e8d31ecdd65f63d377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852187Reviewed-by:
-
Al Muthanna Athamina authored
This CL attempts to cover ParsedURL.js with Karma tests. Note that some of the code was not covered because the it threw an error when trying to call Root but the coverage ended up being above 90% Change-Id: Iede3cda2a520f0a8a9a3c1378e48caecc11d183d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852287Reviewed-by:
Tim van der Lippe <tvanderlippe@google.com> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@google.com> Cr-Commit-Position: refs/heads/master@{#704585}
-
Thomas Tellier authored
Bug: 1002108 Change-Id: Id4473becaafe6e6d2477dfae0aad1aa2b4fd1669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850512Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#704584}
-
Clemens Arbesser authored
See bug description for more info. Bug: b/142454202 Change-Id: Iadebe24cc579502f32db8503e35e262651464ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852087Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#704583}
-
Miyoung Shin authored
This CL converts IsolatedXRGamepadProviderFactoryPtr and Binding<IsolatedXRGamepadProviderFactory> in chrome and device to the new Mojo type, and uses pending_remote<IsolatedXRGamepadProviderFactory> in isolated_xr_service.mojom. Bug: 955171 Change-Id: I109a2197c8e02bdd7908402837284f9f2c45970c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847233 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#704582}
-
Antonio Gomes authored
This is phase 6.2 on the design document [1]. CL moves RTCCertificateGenerator directly to blink/renderer, once its solely clients all reside in blink/renderer now. The existing base class WebRTCCertificateGenerator, needed to bridge between blink and content will be removed in a follow up step. The CL also removes the existing accessor in blink::Platform, and removes Mock implementations in //content/test/test_blink_web_unit_test_support.cc|h BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I7d065a3d9344d779c65938c174c74d82e71a8716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814604 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
-
David Roger authored
TBR=pfeldman Bug: 1013003 Change-Id: I6b98b0c4698c6c40d323bc996603e6595d3e4340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852291Reviewed-by:
-
Dominik Röttsches authored
Failing builds for example: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/83781 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/83780 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/83779 TBR=rmcilroy@chromium.org,perezju@chromium.org Bug: 1008001 Notry: true Change-Id: I1698c7b3d086d4238cca849c31ccb3ab806e581b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852206 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
David Roger authored
TBR=austinct Bug: 1008880 Change-Id: I9f9987e194fe59cbd8dd239105de76ce680a477f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852091Reviewed-by:
-
Dominik Röttsches authored
virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/update-bytecheck.https.html expectations fails on Win10, too, generalizing TestExpectations line. Bug: 1002377 Tbr: alancutter Notry: true Change-Id: I58fd8486fade53a11217c16010376e352aa40429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852266 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Bence Béky authored
These histograms are logged from third-party library QUICHE at the following places: https://quiche.googlesource.com/quiche/+/refs/heads/master/quic/core/qpack/qpack_encoder.cc#294 https://quiche.googlesource.com/quiche/+/refs/heads/master/quic/core/http/quic_spdy_session.cc#1081 For the definition of QUIC_HISTOGRAM_COUNTS, see https://quiche.googlesource.com/quiche/+/refs/heads/master/quic/platform/api/quic_exported_stats.h#86 https://cs.chromium.org/chromium/src/net/quic/platform/impl/quic_client_stats_impl.h https://cs.chromium.org/chromium/src/net/quic/platform/impl/quic_server_stats_impl.h Change-Id: Icf5a632d9f172cb2c79b53cccec349a2060351b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847797 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#704576}
-
