- 05 Jun, 2019 40 commits
-
-
Caleb Rouleau authored
This reverts commit a02a2de2. Reason for revert: crbug.com/971204. speculative revert. Bug: 971204 Original change's description: > [Perf] Replace the dimension gpu with synthetic_product_name for win-10-perf > > As a followup, the dimension "os" need to be updated once crbug.com/966238 is done > > Bug: 966616 > Change-Id: Ic2da344c93b7f5b656a5002f514cb88a96262659 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637603 > Reviewed-by: Simon Hatch <simonhatch@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665719} TBR=simonhatch@chromium.org,crouleau@chromium.org,jbudorick@chromium.org,hypan@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 966616 Change-Id: I6a3d325b39a6ebad091d35140ae67757481bfdf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645382Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#666400}
-
Karan Bhatia authored
Enforce CSP checks for background fetch in isolated worlds. Since the IsolatedWorldCSP feature is disabled by default, this CL will cause the CSP check to use an empty CSP instead of just bypassing the CSP checks for isolated worlds. In practice, this should cause no behavior change. BUG=896041 Change-Id: Ib869058762fdd321fe279f20533b4e8d3afd9d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633532 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#666399}
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 853360 Change-Id: Ie7efedb61ad517cf880980c8cccc445fba7618e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645481Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666398}
-
Nicolás Peña Moreno authored
This CL allows dispatching text Element Timing entries. The TextElementTiming attribute in TextRecordsManager cannot be set on the constructor of TextPaintTimingDetector because it is constructed too early, upon construction of LocalFrameView. The intersectionRect is not supported yet because TextRecord does not include that information. Bug: 942033 Change-Id: I65001c25d5ba874456a7bdea4cc26df8d059ee63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639107 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#666397}
-
Xida Chen authored
Most of the tests under this bug seems to be skipped. TBR=gayane@chromium.org NOTRY=true Bug: 922951 Change-Id: I7b09e14534e49b487f0dae5d3b9b0dacef408865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645245Reviewed-by:
-
Jun Mukai authored
This CL adds the tests for the animation smoothness of the page transition between the apps grid in the list. I ran this for 5 times on nocturne, here's the result; next-page / clamshell: 73, 80, 73, 46, 46 next-page / tablet: 86, 66, 86, 6, 86 page-jump / clamshell: 40, 80, 26, 26, 40 page-jump / tablet: 73, 40, 66, 6, 86 Bug: 970879 Test: interactive_ui_tests Change-Id: Ibc519b0cf47e3540d9a2c57f521ed64ee981c572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643783Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#666395}
-
Eric Aleshire authored
This was renamed to addFakeSyncServerBookmarkWithURL:title in EG2, so the EG1 function is safe to remove. Bug: 922813 Change-Id: I954abbc123efd6e385acd67c6e629226e7c625c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645146Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#666394}
-
Richard Knoll authored
This implements notification suspension if a site is paused. The SuspensionTracker notifies the new NotificationSuspender of changes. The NotificationPlatformBridge depends on the NotificationSuspender to check if a notification is allowed to be displayed. Bug: 949475 Change-Id: Id66bfd1479a7e77f34f6322d4432c5103d17d9ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628753 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#666393}
-
Andrey Lushnikov authored
DevTools protocol exposes a few protocol methods to create isolated worlds: - `Page.addScriptToEvaluateOnNewDocument` - `Page.createIsolatedWorld` Whenever a same-process navigation happens, these worlds are not desotryed - so instead of re-creating the worlds per se, we should re-create just WindowProxies. This was reported as https://github.com/GoogleChrome/puppeteer/issues/4449 R=caseq Change-Id: I1056f64324a8c4f3c7a9f4a1f443b39a3b48cd29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634416Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#666392}
-
Jan Krcal authored
This CL removes the syncable service for AF profile sync that is not needed any more after the launch. Bug: 836718 Change-Id: Ia4fa8d145810e3bf471aa15472dd9ad86ba2d0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643548Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#666391}
-
Ehsan Karamad authored
The test always passes locally however it fails when the feature MimeHandlerViewInCrossProcessFrame is enabled. This is most likey due to an already known issue with 'loadstop'. Enabling the test and for now returning early when the feature is enabled. Bug: 964364, 840063 Change-Id: I5ff1cb29109e0994767b5dcb6c8d0af5b49158b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630521Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#666390}
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 971354 Change-Id: Iff648b504e157e7acd776aa9cfdc8d28ca30817a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645243Reviewed-by:
-
Kurt Horimoto authored
This CL wraps the decide policy block provided by web// in a safe block that ensures that the web// block is executed before deallocation. This approach is already used for dialogs presented by DialogPresenter. Bug: 961723 Change-Id: I1c1a05e68f5c127ec73e5f926fb551e18f76cb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640785Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Taylor Bergquist authored
Bug: 958173 Change-Id: I99cd5c3ed9e2326db14a8e8d225b565aaac82ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639731 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#666387}
-
Benjamin Shaya authored
Bug: 132820820 Test: cast_audio_backend_unittests Merge-With: eureka-internal/132820820 Change-Id: I94578cef563ff4713ad2e2be86d8ac0ce756dec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621189Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Cr-Commit-Position: refs/heads/master@{#666386}
-
Oleg Davydov authored
There are Chrome OS device policies which can force or disable use of high contrast and spoken feedback (aka Chrome Vox) features. But if policy are set to disable these features, user can still press key combination to activate Chrome Vox/High Contrast. In this case features are not activated (as expected, due to policy), but a message popup is wrongly shown about that features were activated. This commit fixes this: if features are force-disabled by policy, no popup will appear. Bug: 953245 Change-Id: If2e9a1eeb8e893902f9056030425032a171db882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640547Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#666385}
-
David Benjamin authored
The new Win10 dialog is more modern-looking and goes directly to proxy settings, rather than Internet Explorer's settings dialog, which will hopefully reduce confusion. Earlier Windows versions continue to open inetcpl.cpl which continues to be confusing, but I wasn't able to come up with an explanatory string that wasn't extremely awkward. The string changes and improvements relating to policy and extensions overrides will be handled in a separate CL. dialog. Proxy settings are picked up by Chrome (assuming no extensions or admin policy override) Test: In chrome://settings/system, opening proxy settings goes to the Win10 proxy Bug: 927359 Change-Id: I8bd4c854cee6e1eac53a0a6d0a3a984adb8ce6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642818Reviewed-by:Will Harris <wfh@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#666384}
-
Joshua Pawlicki authored
I've written most of the code there anyways. Change-Id: Ia1db5f35483c3e502baf90e1124e4c1cb467ac3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645138 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666383}
-
Peter Kotwicz authored
This CL bundles in old-style and new-style WebAPKs: - The same Java classes - The same resources As a result old-style WebAPKs will bundle resources that they do not use. AndroidManifest.xml stays different between old-style and new-style WebAPKs. BUG=969591 Change-Id: I60ceeb6b282907872165e67f5a23665e53053407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643735Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#666382}
-
Daniel Murphy authored
The IndexedDBDatabase's connection() list can be modified during a call to FinishAllTransactions. The AbortAllTransactions method didn't protect against this, so there was a potential UAF. This patch fixes that. Bug: 969083 Change-Id: I590e3a6c4f978ee6e582394208fb70cbdd9e5347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641625 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#666381}
-
Wei-Yin Chen (陳威尹) authored
Before the Grid Tab Switcher RecyclerView is fully cleared, add an intermediate state where the thumbnails are released, but the Views are kept. Bug: 968822 Change-Id: I0f795773a73949daf7e04c8c6c51e682ed95cfe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643070 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666380}
-
Sean Topping authored
Since all logging is the same across CastWebView::Delegate implementations, we can just provide a log prefix at initialization. Merge-With: eureka-internal/278880 Bug: internal b/77879457 Test: CQ, manually verify console logging appears in logcat. Change-Id: I7d6803699c3d9e2780a4b0fd73b794efd5b15f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642348 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#666379}
-
Hongchan Choi authored
This CL adds two more numbers on the front-end: - Mean callback interval - Standard Deviation of callback interval Also includes some clean up on BaseAudioContext and OfflineAudioContext. Bug: 969758 Change-Id: I1cdc0686ba365f7d38271c23c61e168e88ab6706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641663 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
-
Fernando Serboncini authored
TBR=juanmihd Bug: 970340 Change-Id: I081c7b80551137756908f59842ae80cd23a74fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643669Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#666377}
-
Devlin Cronin authored
Add an end-to-end test for chrome.action.onClicked dispatching. Parameterize the test so we get bonus coverage for page and browser actions as well. Bug: 893373 Change-Id: Ic573d949384646d35bd7b11fd2f2de560555d60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629232 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#666376}
-
Fernando Serboncini authored
This was only used to disable deferral when a canvas gets updated multiple times. We also removed the disable deferral reason. TBR=juanmihd Bug: 970325 Change-Id: I44167fbdd4638bdd9b492a76bed80a283383d0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642813Reviewed-by:
-
Antonio Gomes authored
This CL is the 2 out of N CL that remove redundant enums from Blink's public API, on the mediastream directories. At this time MediaStreamType [1] is replaced by it mojom existing variant in [2]. [1] third_party/blink/public/common/mediastream/media_stream_request.h [2] third_party/blink/public/mojom/mediastream/media_stream.mojom The associated typemap [3] and traits declarations [4][5] are also removed. [3] third_party/blink/public/common/mediastream/media_stream.typemap [4] third_party/blink/common/mediastream/media_stream_mojom_traits.cc [5] third_party/blink/public/common/mediastream/media_stream_mojom_traits.h TBR=haraken@chromium.org BUG=923394,919392 Change-Id: Ie9fce964db55731892662627c1018a00b083740e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642807Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#666374}
-
Etienne Bergeron authored
This CL is adding a test to cover: Font::Font(...) PlatformFont::CreateDefault(...) The default constructor was not covered by any unittests. This was found while doing the migration from PlatformFontWin to PlatformFontSkia. This CL is also restricting the use Font::platform_font(...) to windows. This function will be removed as soon as the migration is completed. R=robliao@chromium.org, asvitkine@chromium.org CC=benck@google.com Bug: 944227 Change-Id: Ib9a77c412966c3ebff81dfbf5340a762f69dc6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642816 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#666373}
-
Alexandre Frechette authored
This is a reland of https://crrev.com/c/1613789, but disabling router notification on page language determination. Bug: 957657 Change-Id: If93f5a594ba634c551dc0fc9251f80c9221bba4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643587Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#666372}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9893f8e15152..95253bd0acff git log 9893f8e15152..95253bd0acff --date=short --no-merges --format='%ad %ae %s' 2019-06-05 brianosman@google.com Fix SkSL standalone compile errors 2019-06-05 michaelludwig@google.com Combine GrPerspQuad and GrQuad 2019-06-05 egdaniel@google.com Move readSurfacePixels and writePixelSurface into GrSurfaceContext. 2019-06-05 mtklein@google.com Revert "print 1/K floats as fractions" 2019-06-05 robertphillips@google.com Revise GrDataUtils to be more self-contained 2019-06-05 jvanverth@google.com Add GrCFResource::reset() to allow Chrome to transition to sk_cf_obj. 2019-06-05 bsalomon@google.com Add API to invalidate GL texture parameters from GrBackendTexture. Created with: gclient setdep -r src/third_party/skia@95253bd0acff The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: I61fa5725388d3e7d9a6cfcab6f5804ec1dc8bcc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645258Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666371}
-
Jacques Newman authored
This is a reland of febfd29f This change was pulled out due to pre-existing bugs allowing ignored nodes to be serialized, this caused a new DCHECK to be hit. For this change, that DCHECK has been removed. Additional changes in this CL: * unignored_index_in_parent is now of type size_t. * ignored nodes now have an unignored_index_in_parent of 0 * calling GetUnignoredIndexInParent on an ignored node is now disallowed Orignal Change: https://chromium-review.googlesource.com/c/chromium/src/+/1535171 Revert of original change: https://chromium-review.googlesource.com/c/chromium/src/+/1610026 Reland: https://chromium-review.googlesource.com/c/chromium/src/+/1609590 Revert of Reland: https://chromium-review.googlesource.com/c/chromium/src/+/1620907 Explanation of change: Today, we have a single concept for ignored elements: AccessibilityIsIgnored This is true for elements that are determined to not be worth adding to the accessibility tree, like: * an empty div * a display:none element * line breaks (br) However, it is useful for browser-side code to have access to these elements. My change allows for us to serialize an ignored node and send it to the browser-side accessibility tree. (Although this change does not actually do so). Nodes that are ignored are marked as such (ax::mojom::State::kIgnored), and then serialized. A similar change was attempted a little over a year ago by Dominic https://chromium-review.googlesource.com/c/chromium/src/+/912136 His change attempted serialize all nodes, even if it is ignored. That change was never merged and was recently abandoned. His recommendation was to only serialize *some* of the ignored nodes, to better scope the change. To enable only serializing some of the ignored nodes, a new concept/API was created: AccessibilityIsIncludedInTree This does not guarantee a node not ignored, only that is should be serialized and included in the browser-side accessibility tree. Subsequent change will add conditions to which AccessibilityIsIncludedInTree is true, allowing for an ignored node to be serialized. Some areas continue to care if a node was ignored, and these areas will continue to call AccessibilityIsIgnored, so the distinction is useful. Eventually, the goal is to serialize all nodes and send them to the browser-side accessibility tree, at this point AccessibilityIsIncludedInTree will be true for all nodes, and could then be removed. AccessibilityIsIgnored will continue to remain the same as it is today. Original change's description: > Reland "Refactor to handle ignored nodes that pass into the browser AX tree" > > > This re-lands this CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1535171 > > Which was reverted here: > https://chromium-review.googlesource.com/c/chromium/src/+/1610026 > > Original Change's description: > > Refactor to handle ignored nodes that pass into the browser AX tree > > > > * Introduces the concept of "in the tree" vs "ignored" in Blink without > > changing the actual behavior. No ignored nodes are sent to the browser > > accessibility tree. > > * Adds new function IsIgnoredPassThrough, for use when an object is > > ignored, but should be passed through to the browser-side anyways. > > This will be used to allow different types of ignored nodes to pass > > through, instead of all at once. > > * Refactors browser-side code to walk only the unignored tree. > > > > Bug: 651614 > > > > Change-Id: Idbd85949a8505f8a03a08e3e002bb893619d6757 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535171 > > Commit-Queue: Jacques Newman <janewman@microsoft.com> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#659089} > > Change additional to original change: > The original change caused a crash because GetUnignoredChildCount was > called on a parent with dangling pointers in its children vector. > This was previously acceptable as child_count only relied on the > length of the vector, not its contents. > This issue has been mitigated by caching the unignored child count, > similar to how the unignored index in parent is cached. > > Bug: 651614 > > Change-Id: I90b09237862d17848113fb084b9b08b60e12999f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609590 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Commit-Queue: Jacques Newman <janewman@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#660987} Bug: 651614 Change-Id: Icb6bfaf2afe7c28805322541aefe0829f26aed0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626690Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#666370}
-
Saman Sami authored
Bug: 963446,960795 Change-Id: I3b50117bfae33aa1f36425d156ee780313937035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645383Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#666369}
-
Steven Bennetts authored
Bug: 862420 Change-Id: Ic2b5b8f08c6399c10e39d495a64543bb497a99cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643422 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#666368}
-
Koji Ishii authored
Following bot results are included. 20802 20807 20821 20833 20851 20857 20881 20886 20894 0 lines were removed and 1 lines were deflaked by consecutive results since 20787. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: Id68fed69a17f37ca6d552c393d8397b5e622e84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642617Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#666367}
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 971326 Change-Id: Icb560851c066e8671d3f509c088855ad282423ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645207Reviewed-by:
-
Ilia Samsonov authored
First, we make sure we reorder all tests in test launcher, we guarantee that "PRE_test" will precede "test" for the delegate. Test shuffeling was moved before re-ordering test for dependent test Finally, content test launcher delegate was simplified. It still has some logic to group dependent together so they run consecutively in parallel launch. Bug: 936248 Change-Id: I7d34e45eee1c2c0c88ded8e5cc054327fe27d7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638139 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666365}
-
Lan Wei authored
In order to remove the timer to send the fake mouse move event to update hover for user scroll case, we will send the fake mouse event as a callback which will be executed when the animation finishes or cancels, because keyboard scroll does not generate any gesture events right now. This CL is working on all the user scrolls, such as keyboard scroll. Bug: 877132 Change-Id: I29859df6bae983ab982bbec87d9d91d17f11126b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638778 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#666364}
-
John Abd-El-Malek authored
SafeBrowsingService::CreateURLLoaderFactoryForIO created a factory directly through NetworkService, which means that if the network process crashed the interface pointer wouldn't work anymore. Instead use SafeBrowsingService::GetURLLoaderFactory(), through CrossThreadSharedURLLoaderFactoryInfo, which correctly handles this case. Bug: 971274 Change-Id: Ia6915e1e7aa4121130ab34b30587827adb54e96f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645456Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#666363}
-
Long Ly authored
Adding offsetRects, clientRects and offsetRects into DOMSnapshot.captureSnapshot using an experimental flags includeDOMRects. Change-Id: Ie2c0af41c94fc1eeb9a6a371193182791a744719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612105 Commit-Queue: Long Ly <loly@microsoft.com> Reviewed-by:
-
Mario Bianucci authored
This change adds two new cursors for auto scrolling, one that shows only vertical directions, and the other that shows only horizontal. (This has the unfortunate side effect of causing cascading small changes to many files, sorry!) These new cursors are then used in autoscrolling so that when a user is on a page that can only scroll vertically, if they middle click it will then show an autoscroll cursor that reflects the available directions, i.e. up and down only. Similar results for horizontal scrolling only pages. This change caches the directions available to scroll when the middle mouse button is clicked and uses those to determine which cursors to show when handling mouse move events. This unfortunately means that if a user middle clicks somewhere that can only scroll vertically, and later that changes to being able to scroll horizontally exclusively without user input, the cursor will still only show vertical directions. However, this matches what Firefox and non-Chromium-based Edge do right now, so this seems fine to me. A file up bug to fix this issue should be filed though. Bug: 11437 Change-Id: I68e083d1e0b9e14071f67f9268e826a40cebd783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638924Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
