- 18 Dec, 2019 40 commits
-
-
Darren Shen authored
<This change is hidden behind a flag> As part of migrating PK rule-based IMEs to native code, this CL migrates reset to native code path. We port RuleBasedController#onCompositionCancelled in chos/pk/rulebasedcontroller.js. Note that we need onReset to call through to the extension, as it has side effects that may affect the extension when it is running (e.g. when VK is up). Note that the JS code has already been guarded by the runtime flag. Bug: 1009903 Change-Id: Ic1efc191fb7c963916b58cea4e8055d1d8ae6743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968776 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726145}
-
Mike Dougherty authored
Add “WebState_” to make it easier to read breadcrumb events. Without this identifier, the WebState's unique_id is ambiguos. Bug: 1003922 Change-Id: Ie223622a6566a1fc7d58a5dafff68937b19f1bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974814 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#726144}
-
Megan Jablonski authored
Change-Id: I914d4af9b1b0999a24a42aac40fc7faacfff10f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974835 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#726143}
-
proberge authored
The underlying issue seems to be related to a sandboxed process failing to open or truncate its log file. All the tests shared the same file, leading to flaky issues despite the tests running with --single-process. To avoid this issue, we now tell the cleaner/reporter process and their spawned sandboxes to log to a temporary folder. Bug: 1030333 Change-Id: If339c623b148b8b458a32e4d974d6a642bc4f12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972494 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#726142}
-
Shakti Sahu authored
Bug: 1035266 Change-Id: Ied9ff05e0bedf2d9c4470d4ed68055e977713ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973551Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726141}
-
Tim Song authored
When the status area overflows and is in the expanded state, we show a gradient background over the shelf. Screenshot: https://screenshot.googleplex.com/5WO6NUnED4m BUG=1026072 Change-Id: Ia90fb50a85694edba8a22d9a029912c7e1ac80a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973355 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#726140}
-
Sophie Chang authored
This CL is deceptively large to ensure that test cases with the same feature flags are somewhat colocated. Bug: 1035004 Change-Id: Ia09794fab81801269920d0e2403adb5a49e97d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974750 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
-
Stephen Roe authored
Bug: 1024086 Change-Id: I9ad0d1d7ab2bb0b65c1c31257b451ecb4b327610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970831Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Auto-Submit: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#726138}
-
Steve Kobes authored
Without this, a shift could hide from LayoutShiftTracker if the layout tree had to be rebuilt due to a change in an ancestor's 'display' property. Bug: 1003459 Change-Id: Ib00772ff7846251533080b29d16f6cbaafc8189b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958191 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726137}
-
Brandon Wylie authored
* Creating a class which handles reparenting the current tab when the theme is swapped. * Hooking that class into ChromeActivity. * Adding plumbing to a few ReparentingTask/TabReparentingParams to facilitate the process. Bug: 944302 Change-Id: I2801eba979b3acafa02856a9053bc474bf2f581c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931763Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#726136}
-
Rayan Kanso authored
I2S: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/wB7mDJqrUZ8/ClecA5-qAgAJ Bug: 1023967 Change-Id: I7f2108dce7e240a050a30fc436391692857062f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949481 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#726135}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/17b3c2f3f8b1..20432bf38dfe git log 17b3c2f3f8b1..20432bf38dfe --date=short --first-parent --format='%ad %ae %s' 2019-12-18 ianelliott@google.com Vulkan: Update GLES 3.1 expectations for now-passing tests. 2019-12-18 courtneygo@google.com Reset binding offset & size when unbinding Created with: gclient setdep -r src/third_party/angle@20432bf38dfe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I4ed3077a305c80bbc4bfc433011656ce36d30fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974637Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726134}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=guidou@chromium.org Bug: 1023677 Change-Id: I31c5dfab9cfb46fa70639b5a1f1f5a04a1bce2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957503 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#726133}
-
Arthur Wang authored
R=bsheedy@chromium.org, harringtond@chromium.org, yliuyliu@chromium.org Bug: 1028976 Change-Id: I08ab250686b7f714488597a3e82bcb529ab541d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974534Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726132}
-
Dan Elphick authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: I7b2f914297110f7c7daa0da4e58f5339f7b9d18a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971915 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#726131}
-
nancy authored
Update the function name from OnWindowVisibilityChanging to OnWindowVisibilityChanged. Update the Chrome app checking, because when the app is an extension, it could be opened in browser, so we should check the browser context in AppService instance to decide whether that is a Chrome app, which is opened in AppWindow. Otherwise, it could crash the browser should manage those apps. Fix the bug found by the new browser test: 1. The AppServiceInstanceRegistryHelper should be shared by browser_status_monitor and AppServiceAppWindowLauncherController, and owned by AppServiceAppWindowLauncherController, because browser_status_monitor updates the record in AppServiceInstanceRegistryHelper, if they use separate one, then AppServiceAppWindowLauncherController can't know which apps are managed by the browser. 2. When switch between the window, the AppServiceInstanceRegistryHelper should update the apps opened in the browser. BUG=1011235 Change-Id: I98080bca6ed6dc80a2c20ab1e9096e455d47187d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973971Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726130}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I0d2560e3b7ef3263b854dc0b43106f320286130c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974491Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#726129}
-
Darren Shen authored
<This change is hidden behind a flag> As part of migrating PK IMEs to native code, this CL migrates key handling to native code path. We port Background#maybeHandleKeyEvent [1] and RuleBasedController#handleEvent [2]. [1] chos/background.js [2] chos/pk/rulebasedcontroller.js Note that the JS code has already been guarded by the runtime flag. Bug: 1009903 Change-Id: I801505f11af95dbc066b12d7bb70f6a9765fea65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921589Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b65f3282baa9..d94b7f19dbf6 Created with: gclient setdep -r src-internal@d94b7f19dbf6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic63c2cb085bc2f2cfeec35a8e31576b2701d532a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974642Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726127}
-
Matthias Körber authored
Change-Id: I651e642bce83df4f8e4679353e002ccfde3da808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971845 Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#726126}
-
Alex Gough authored
Windows only as rule evaluation uses Windows functions. |maxParams| is only 2 as that's what the rules use and I'm trying to exercise code that the rules activate. Change-Id: I41767336858fef82abcd8ddb9d19fb0e620ce41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872560Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#726125}
-
John Budorick authored
Causing WindowServer crashes w/ the reduced filter file. Bug: 899286 Tbr: ellyjones@chromium.org Change-Id: I110e7450681b83548c8e6fc6f35fdf6a33dd73e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974492Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#726124}
-
Yun Liu authored
Most added suites were failing to compile due to compiler issues. We can add them after compiler issues are fixed. (2 fixed upstream but need to roll in chromium, the one I'm working on is under review). Bug: 985574 Change-Id: I612a3197a5b142d8049effb73c45a2fb5c0c1e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973240 Auto-Submit: Yun Liu <yliuyliu@google.com> Commit-Queue: Yun Liu <yliuyliu@google.com> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#726123}
-
Avery Musbach authored
Bug: None Change-Id: I7a48a3a9664d8ce5220284c77d9f0535248f26db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974892Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#726122}
-
Devlin Cronin authored
Introduce WebContentsObserver::OnDidAddMessageToConsole() to (partially) replace WebContentsDelegate::DidAddMessageToConsole(). This is useful for consumers that are interested in monitoring the console messages added, but not changing the behavior of adding the message. It will also be used in the future to enable easier testing, since it won't require modifying the WebContents' existing delegate. Update WebViewGuest<> to use the new method, instead of overriding the WebContentsDelegate version. Bug: 1034150 Change-Id: Ia0d3e9aaf72a57c55244d508b4c49d02644970f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968152Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726121}
-
Sajjad Mirza authored
Paths in `--files-to-instrument` are expected to be normalized OS-native paths, so the input source file has to be converted to match. This is most relevant on Windows, where GN creates build commands that use `/` for filesystem paths, but the canonical form should use `\`. Bug: 990480 Change-Id: If7b5da729f0a98ec7945092b0f228cebd50be3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973360 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#726120}
-
Caleb Rouleau authored
This allows us to provide better runtime estimates for the cycletime spreadsheet that we are autogenerating. Bug: 1030840 Change-Id: I02d50f65f916196f9277ba24a356d5380e07c14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974697 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726119}
-
Yuke Liao authored
The internal linux-code-coverage builder doesn't run fuzzers anymore, so it can be moved to external. This CL revives the external version of linux-code-coverage, and once it accumulates enough reports, will turn down the internal version. Currently there are 4 32-cores ssd bots that are used by code coverage builders, and there are 3 builders: linux-chromeos-code-coverage, android-code-coverage and android-code-coverage-native, and the android-code-coverage usually finishes fast (1h every 6h), therefore, there is room for one more builder: linux-code-coverage. Bug: 1016929 Change-Id: Ifeeb78fba69af0567857e905ced9a29196469528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974576Reviewed-by:
-
Christopher Grant authored
This reverts commit 269e59a8. Reason for revert: Failures on Debug build try jobs: https://ci.chromium.org/p/chromium/builders/try/android-pie-arm64-dbg Original change's description: > Android: Add Monochrome32 and Trichrome32 build targets > > This change adds a pure 32-bit version of Monochrome and Trichrome to > the 64-bit build configuration. Building these targets generates a > product equivalent to building the targets on a 32-bit config. However, > by adding these, we have the option of building all Monochrome and > Trichrome products on a single 64-bit builder, and, we share the > compilation work (as opposed to the obsolete process of "APK merging" > parts from a 32-bit build into 64-bit products). > > The targets added here are the public versions. > > Bug: 1027573 > Change-Id: Id5ffd698721077e8fffb1f8206adc0b7b1fce212 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960575 > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723897} TBR=torne@chromium.org,cjgrant@chromium.org,estevenson@chromium.org Bug: 1027573 Change-Id: I192ff6511e17c745ecadcf4a8ecfdddf40967bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974000Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#726117}
-
Amy Huang authored
Change-Id: Ia1f87b0479a92d9f57d4261379044baa13f574b6 Bug: 1035171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974530Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Amy Huang <akhuang@google.com> Cr-Commit-Position: refs/heads/master@{#726116}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0d7e2f158e9b..f64e958e897a git log 0d7e2f158e9b..f64e958e897a --date=short --first-parent --format='%ad %ae %s' 2019-12-18 kjlubick@google.com Properly free bytes in SkDescriptor fuzzer 2019-12-18 bsalomon@google.com Make sure random unit test processors use an alpha type compatible with 2019-12-18 mtklein@google.com disable warnings in ANGLE 2019-12-18 mtklein@google.com Revert "roll clang_win" Created with: gclient setdep -r src/third_party/skia@f64e958e897a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ia47b6ac174befcef3ac9bfb5038ade27fcc7b58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974635Reviewed-by:
-
dalyk authored
A follow-up cl will pipe this information through to NavigationHandle. Bug: 1016325 Change-Id: Ie82abc6ca072a0354f06dddb5dbf04715599cf21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953511Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#726114}
-
Darren Shen authored
We accidentally broke altgr for rule-based inputs in [1] because we looked at the "altgr" attribute of the keypress info, which is only filled by the VK and not the PK. For the PK, AltRight is always treated as AltGr, so we add that logic back in. We add a test to prevent this from happening again. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1837312 Bug: 1035145 Change-Id: I64d3d56b08c8cd2a82c4617f63a3c6f34444f36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971638Reviewed-by:
-
Connie Wan authored
This allows us to remove some redeclared classes like TabGroupMetadata. It also gives greater flexibility and readability when creating more Tab Group types (such as TabGroupColor in the followup change). Change-Id: I5767f6868c202c37550fa2a9e62e565a87ea5686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967128Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#726112}
-
Antonio Gomes authored
BUG=787254 R=guidou@chromium.org Change-Id: I642e78ab921ab119b9cb6f4643b03aea00ee975f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969691Reviewed-by:
-
Kyle Milka authored
Apply an app:tint to the icons in the sharing hub, so they correctly change color when the system is in dark mode. screenshot: http://screen/zsopm5J1Tg1.png Bug: 1009124 Change-Id: I4fbf93959829ca570aa5c0b33837ab017e5744a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974694Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#726110}
-
Marijn Kruisselbrink authored
The modification timestamp ensures files can't be read after they are modified, so make sure it is actually passed along and used when uploading a file. On its own this change doesn't actually fix anything, since the timestamp that is passed around isn't always set yet, so for nearly most cases this CL will have no immediate effect. Separate CLs will make sure the timestamp is set properly in the first place. Note that even then, we still trust the renderer process to decide if it should be allowed to upload a file after the file was modified; ideally we'd further refactor the network side code to instead check the snapshot state in the browser process, but that is a much more involved change. Bug: 844874, 818327 Change-Id: I838d0b6996857ee691fee5b9162c75f8b2ca99c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968113Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#726109}
-
kylechar authored
|verified_sync_tokens_required| was set false as a performance optimization when the display compositor and browser UI shared a command buffer. This never happens anymore outside of tests so it can be removed. TBR=liberato@chromium.org Bug: 869250 Change-Id: I0d9ae641d3d201061d6326982af04f4fb5262a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972780 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#726108}
-
Ken Rockot authored
This covers removal of deprecated base::Bind, base::Callback, base::Closure, base::Passed across the following components/ subdirectories: - components/sync_sessions/ - components/translate/ - components/update_client/ Fixed: 1007743,1007746,1007748 Change-Id: Ie8d5c8267ac125b903ba04443d031e8134122dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970293Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#726107}
-
Asanka Herath authored
This CL also updates a number of existing tests to re-enable FTP via explicitly enabling the kFtpProtocol feature. Unrelated tests will continue to be run with FTP disabled. Affected tests are exercising FTP specific functionality which will also go away when FTP is deprecated. Bug: 333943 Change-Id: I8dea73bc825011bff1d3fef46194b8ca43e2fc27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966279 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
