GitLab

See discussion in crbug 1155426 for details. Changes:

MediaStreamCaptureIndicator::UIDelegate: Ignore multiple calls to
OnStarted().

TabSharingUIViews: Unconditionally execute clean-up tasks in destructor.

Bug: 1155426
Change-Id: I392fba38118ce51744ba36b4dec19ebfe39f1fbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581028Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835736}

This merges FinishGoToIndex(), FinishReload(), and
FinishLoadURLWithParams() into their respective callers.
These were previously separate methods so that subclasses
of NavigationManagerImpl could provide different implementations,
but there are no longer any such subclasses.

Bug: 738020
Change-Id: I798415144ba48c59f8c892300b23413de9c9ab7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581301Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835735}

In the initial implementation, if color setting information is missing
in getImageData/createImageData, it uses the information of canvas to
initialize the image data. In the spec, it says that it should use the
default setting of {colorSpace: srgb, storageFormat: uint8} instead. In
this cl, I updated the default behavior for the function getImageData
and createImageData.

Bug:1118182

Change-Id: I4fba4284028c060d5ac7ff80a294d95f8436ef62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567750Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835734}

These tests are flaky on android-pie-x86-rel.

TBR: mlamouri@chromium.org
Bug: 1157494
Change-Id: I80ae660c7bbe0e073de2e890bd65d86600ce03e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585126Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835733}

Fix-it week: Fix the "sink" name for Function constructors. The original
implementation tried to keep it simple and disambiguated between "eval" and
"Function" only when the value was available. That wasn't quite sufficient,
so now we pass in the value whenever we determine the sink for script
values. (This follows the spec, as linked in the issue.)

Bug: 1153054
Change-Id: Ie53f9ee30428b6c94140cabf87d7027367b055a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584024
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835732}

On L, before this change (using startActivity()), instead of launching
the Activity, Android launches the Android Settings page for Chrome...
I couldn't figure out why.
Also, with or without these added flags, startActivitySync errors out,
even though it does actually work. I also have no explanation for this.
However, after 50 runs each of the 4 flaky tests I've had zero failures
now on my L device with these changes.

Bug: 1153712
Change-Id: I95b9f8d3e4f2013b25429c6fd6ee3afbb43c5618
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583084
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835731}

According to test coverage report[1], the error handling
branches of PRService#updateWith(), OnConnectionError(),
OnPaymentDetailsNotUpdated() has no test coverage. This
CL adds the tests to cover these cases.

[1] https://analysis.chromium.org/p/chromium/coverage/file?host=chromium.googlesource.com&project=chromium/src&ref=refs/heads/master&revision=5089ddb0638765b738ce9690ee00be44d2e19a9c&path=//components/payments/content/android/java/src/org/chromium/components/payments/PaymentRequestService.java&platform=android-java#1213

Bug: 1093971
Change-Id: I555d46796f1b570a49fb0861328effbb8226bd09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584463
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835730}

Turn's on support for display_override.

To test the change use: chrome
Example installable apps:
 https://mwjacksonmsft.github.io/pwa/display-override/index.html
 (display: fullscreen, display_override == [minimal-ui, standalone])
 https://mwjacksonmsft.github.io/pwa/display-override-custom/index.html
 (display == browser, display_override == [standalone])

Example non-installable apps:
 https://mwjacksonmsft.github.io/pwa/display-override-browser/index.html
 (display: fullscreen, display_override == [browser, standalone])

Explainer: https://github.com/WICG/display-override/blob/master/explainer.md
Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing
I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/MZgYJgS4Lcs/m/NnUxG2_mAAAJ

Bug: 1092667
Change-Id: I8e77b8e38e05e683173f0820fad7006725be24b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536210
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835729}

https://dawn.googlesource.com/dawn.git/+log/29fd62989338..6bcd4aceef10

2020-12-10 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 7a0daa233d8a to 287f6f12eff6 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: rharrison@google.com
Change-Id: Ie86367873b645e9ff5125262e964f94431253093
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584330Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#835728}

Using wpt-import in Chromium 9ae34772.
With Chromium commits locally applied on WPT:
01ceb784 "Fix a crash PaintWorkletImageProvider::GetPaintRecordResult"
2becd034 "[AspectRatio] Don't stretch grid items if they have an aspect ratio"
cc224570 "SXG + reporting: Make WPT tests work with NetworkIsolationKeys."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz@google.com

No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel
Change-Id: Iba616b36035c24ef6c7eec79197b946c26d353f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584406Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#835727}

This CL updates the AccessibilityNodeInfo object actions on Android.

With this CL we partially revert the work done here:

crrev.com/c/2341398

We will no longer add the LONG_CLICK action to all nodes in Android,
however we will continue to process LONG_CLICK's sent to performAction.


AX-Relnotes: Elements may not explicitly announce they are long clickable on Android
Change-Id: I115d29b5288df45de7a800523a9c074237b233b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583142Reviewed-by: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/master@{#835726}

On other platform, when the user manually typed the username into
the login form and then selects a suggestion from the password field,
the typed username is not rewritten. This CL ensures the same behaviour
on iOS.

Bug: 1157460
Change-Id: I7fca9e69256c7efb3cdea3133a9a830b9df1af98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584303
Commit-Queue: Maria Kazinova <kazinova@google.com>
Reviewed-by: Vadym Doroshenko  <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835725}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: Id6bc188e94a56d9d7a3374a2b585b56ef00b7fe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582322
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835724}

https://android.googlesource.com/platform/external/perfetto.git/+log/9f89587dc4fc..c566c247eb76

2020-12-10 lalitm@google.com Merge "tp: fix async slices not finishing properly"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: If60743a38c23dcc0d00bcc00fbf1c5563a8e9bd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584348Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#835723}

Previously we didn't reject the promise when
- the prompt is timeout
- sms does not reach user
- user declines the promot

This patch handles the scenarios and rejects the promise with unified
error message and uses an indistinguishable timeout schedule that does
not reveal user action or sms arrival to protect user's privacy.

This patch also rejects the promise upon kBackendNotAvailable because
it doesn't reveal any user info.

The timer threshold is based on |Blink.Sms.Receive.TimeSuccess|. i.e.
it makes sure that most of the SMSes can reach the user before the
deadline.

Bug: 1138454
Change-Id: I85c4e50778d021c9b580f6a9598fa6e35d6ac63e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569946
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835722}

What happens when table has more columns than cells?
Should the extra columns be discarded, or used to table grid?

If the columns are not discarded, and table has border spacing,
each empty column would make table wider.

Spec, and previous implemntations are not clear on what to do.
Initial table spec had a concept of effective columns,
where multiple columns could be treated as one for purpose of layout.
New spec introduces the concept of track merging.

https://www.w3.org/TR/css-tables-3/#dimensioning-the-row-column-grid--step2

It is a messy subject. I think cells could merge, but not columns. But
then in some implementations (ours), columns could merge too.

I investigated this because two wpt tests were failing in TablesNG:

external/wpt/css/css-tables/html5-table-formatting-1.html
external/wpt/css/css-tables/html5-table-formatting-2.html

They also failed in FF/Legacy, but in different ways.

The initial code trimmed the excess columns.
New code does not trim the columns.

This makes html5-table-formatting-2 pass all tests,
and makes one extra test in html5-table-formatting-1 pass.

The fix exposed a bug in ColumnGeometries sorting, ordering was not
monotonic. Fixed that too.

Bug: 958381
Change-Id: I9bd267f7e7782df7224f5db4611751ca10ff1aaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583157Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835721}

This CL changes the following:
- profile bubbles are automatically focused when shown
- they are announced by screenreaders, using the role="dialog" attribute
- the line separator is ignored when navigating the bubble (this is
  consistent with other line separators, e.g. in settings)

Fixed: 1156103
Change-Id: Icc33d0bc790fffbb1e618a50235d09e99c69fdbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582079
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835720}

Bug: 1059779
Change-Id: Iee421f4a2719abaec71d837c68f26aae88aa255a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582528Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835719}

FullscreenController is tied to the Browser, so when the Browser is
destroyed, any reference to FullscreenController is garbage. Thus,
SadTabCoordinator needs to call [self stop] to break itself down
(and therefore reset its FullscreenDisabler) before the Browser is
completely destroyed in case [self stop] is called by its owning class
after the fact.

Bug: 1154298
Change-Id: Id9ffc055d338972fe360899a14cf596fc7c41a3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572692Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835718}

1. Remove stale TestExpecations line for a test that now passes.
2. Remove 'background: green' from a test that doesn't need it to pass.

Change-Id: I072038045280d3043998b1ad8b4be5d85825bc32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582828
Auto-Submit: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835717}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ed88fdb2f824..671ca647718c

2020-12-10 vapier@chromium.org cros deploy: fix --unmerge
2020-12-10 saklein@chromium.org lib/depgraph.py: Add root info.
2020-12-10 saklein@chromium.org cros_extract_deps: Begin moving functions.
2020-12-10 ryanbeltran@chromium.org api: Added rusage logs to builder's proto
2020-12-09 chrome-bot@chromium.org Update config settings by config-updater.
2020-12-09 jackneus@google.com build api push_image endpoint fix
2020-12-09 engeg@google.com lib/constants.py: re-add IMAGE_TYPE_CR50_FIRMWARE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I28bdc529fd3eca86f3b37ece68251fcecb32411d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584290Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#835716}

This CL addresses a crash when the user submits a password form while
Save Password message is on the screen. The problem is that the previous
message does not get dismissed.

This CL adds a call to dismiss a message before showing the new one. It
ensures that the dismiss callback is called synchronously on the native
side. It also ensures that dismiss callback doesn't get called again
from java when the message is hidden from the screen.

BUG=1153927
R=twellington@chromium.org

Change-Id: I2dd48e501d1eb3eb859784c429eaa6cbc5f8d610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583113Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835715}

https://android.googlesource.com/platform/external/perfetto.git/+log/0443332fe2b9..59df85b5457e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I212a79b96dbad15bd5069ad576cb7f4e40149981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584663Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#835714}

On Windows, check if the WindowTreeHost of the window being dropped on
is occluded, and if so, don't allow the drop.

This also enables occlusion calculation during window moving, if the
window being moved is a root window. And it ignores the dragged window
when determining if a window under it is occluded.

Bug: 820998
Change-Id: I8fd95ec3f9c9d1b40a848c697cce91125eff21c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879606
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835713}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5aee2a07..73cdeec6

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ifcdcad06546e74311b1c3922053641d21039299b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584662Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#835712}

This CL refactors the animations frame rate graph
simplifying data acquisition.

Bug: 1075612
Change-Id: Icc0ed230f08cc561423e0b49881cebe67f7b7a11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538702Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835711}

Make sure LayerTreeHost accessor is not on the public scope.
Remove stale TODO.

BUG=1097816

Change-Id: Icaa829177ff29683747a50ec2f82137e9f7a5080
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570994
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835710}

Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012100600_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/154azMdJKklKh70adk32WF1u0WMDhj8zp2h72tYtSJgC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/174321021
Tbr: help-app@grotations.appspotmail.com
Change-Id: I0b43536e851f236bd3e2f25223d030021199bb05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584346Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#835709}

This CL adds OTRProfileId to DownloadInfo to be able to reach non
primary OTR profiles. Also, this CL passes OTRProfileId from native
download manager service to the DownloadInfo.

Bug: 1099577, 1145502
Change-Id: I68ff6768fc9ee6810bfbd1f5015b57f6a3df8be2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541863Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835708}

Bug: 1156791
Change-Id: I563fd1965ab9f2fb57cd011522c2d9e3e44f2da9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584030Reviewed-by: Edward Jung (EMEA) <edwardjung@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#835707}

https://skia.googlesource.com/skia.git/+log/2e9a03ec1170..53f69f15398a

2020-12-10 jmbetancourt@google.com Reland "Revert "Initial land of SkSL DSL.""
2020-12-10 johnstiles@google.com Add SPIR-V support for modf intrinsic.
2020-12-10 ethannicholas@google.com Revert "Revert "Initial land of SkSL DSL.""
2020-12-10 reed@google.com Use explicit sampling param
2020-12-10 reed@google.com Remove cons_moveTo() complexity

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jmbetancourt@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jmbetancourt@google.com
Change-Id: I2f607e533c17a2b921b2b4b96b3e39cc175e410c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584291Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#835706}

Instead of passing it in the constructor of InfoBarAndroid, we can
pass it later, from the InfoBarContainer, where the Java object is
created. This allows us to simplify construction of the C++ object
and allows creating infobars from outside of embedders (e.g. from
within //components).

Bug: 1147276
Change-Id: I2caec3625d7379522b2635f906a553587a2b5040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572902Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835705}

Bug: 1146573
Change-Id: Ieee397d611c904144020d037a2bb5ad339608eb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581716
Auto-Submit: Fergal Daly <fergal@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835704}

Change-Id: Ic75e3fb353430dd6d7028cb71a86f239ec0b516b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582831
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835703}

These arguments are unnecessary as they were only needed when milestones
were bucket-based to prevent filling the per-builder group consoles with
the branched versions of builders.

Change-Id: I114d30e197f8eaf2620ee18b3954e074cb200f15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583153
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835702}

Behavioural changes:
This CL adds the logic of logging the number of available apps to
WebLayer.

Changes:
* Moved setNumberOfSuggestionsShown() from PaymentUiService to
  PRService. The new call site is just after the original call site
  in execution sequence so the original behaviour in CPRService is
  preserved.
* Plumbed hasAnyCompleteAppSuggestion() from UI to PRService to provide
  the logging data. The plumbing is necessary because PaymentUiService
  is responsible for the payment apps management.

Bug: 1152498
Change-Id: Iec48ebac896ad82c025cb884b117385bb1d1745f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581230
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835701}

WebFrameWidgetImpl is a GC'd object and owned by the WebLocalFrameImpl
exclusively, it does not need a SelfKeepAlive reference.

BUG=1097816

Change-Id: Ic6c6ec91214e7ab51e879d6aa6fdbe56d06954e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571421
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835700}

This reverts commit 8555baec.

Reason for revert: Still seeing the CHECK in performance_manager::WorkerWatcher::RemoveChildWorker.

Original change's description:
> Reland "PM: Enable service worker relationships."
>
> This is a reland of 7fb78e28
> The crashes and DCHECKs should be fixed with
> https://crrev.com/c/2581939.
>
> Original change's description:
> > PM: Enable service worker relationships.
> >
> > This change is to get some DCHECK crashes on Albatross. It will be
> > reverted after it's been on Canary for a day or so.
> >
> > Bug: 1143281
> > Change-Id: I6d125dfbae9699e7292a9aa0336070b005bd03c3
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571638
> > Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
> > Reviewed-by: Patrick Monette <pmonette@chromium.org>
> > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#833405}
>
> Bug: 1143281
> Change-Id: I52a8332dcd151cd42d6e85f5bbaf4dc094e7d995
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582726
> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
> Commit-Queue: Joe Mason <joenotcharles@chromium.org>
> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
> Reviewed-by: Joe Mason <joenotcharles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#835338}

TBR=joenotcharles@chromium.org,siggi@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I98ecff2b9d75be2ac914e923f7674387d45774ac
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1143281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584704Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835699}

This change fixes two small issues found by the recently proposed
bugprone clang-tidy checks [1].

[1] https://groups.google.com/a/chromium.org/g/cxx/c/hDDUlz1OMUw

Bug: None
Change-Id: I885cd1e019684f27a36265d9a11f65d554dc29f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582123Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835698}

constructor is private.

This is part of a larger cleanup effort to make CanonicalCookie's
constructor private.

This CL was verified by building/running the unit test suite when
CanonicalCookie's constructor was locally changed to have a private
constructor.

Bug: 1102874
Change-Id: I1faa1b63e96091642c1a92ac8142b9de22c7d310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569941Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#835697}