GitLab

Bug: 990561
Change-Id: I0df8d84b450a644d979c1f9c8764f9d2de4c1d9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755283
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691006}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: Ia891d4988299e76925beb57bc69c22e19187eaa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700872Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691005}

TBR=shuchen@chromium.org

Bug: 997888
Change-Id: Ic7dfb8088ec76028c2c1daabdcd582c210c7560b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772931Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691004}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: I0037f36b9da556a802e14d452be1b582b7357179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700844
Commit-Queue: Eric Foo <efoo@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691003}

In iOS13, the minimum duration for the long press gesture recognizer
was increased to 0.75s in order to mitigate interactions between this
feature and iOS's built in drag-and-drop functionality.  However,
web::WebViewLongPressElementForContextMenu() was still using 0.7 as the
action's press duration, which caused our context menu tests to fail.

This CL updates the duration for this helper to 0.75s and re-enables
disabled tests.

Bug: 989550
Change-Id: I02cb1208ba0b27d9d70722f1da381f57c0aa1e54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769082Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691002}

Use the custom menu order functions to set the order of the buttons in
the menu panel init function. The ability to set the button order is not
user facing but can be done in remote debugging using the updatePositionAttributes_
function.

Tested using emulated Chrome on Linux with flags
--enable-experimental-accessibility-switch-access and
--enable-experimental-accessibility-switch-access-text.
Use of updateButtonOrder function does not impact the order or function of the menu.
Button order can be manipulated manually using the updatePositionAttributes function.

Bug: 994256
Change-Id: If76d9a48d74e738129d9e0788e03c599d6cf6e32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770432Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: Rose Garcia <rosalindag@google.com>
Cr-Commit-Position: refs/heads/master@{#691001}

Remove History.InMemoryTypedUrlVisitCount, which we don't need

The others are still useful.  Make them all non-expired and extend
their expiration to 2020-02-16.  Also make sky@ and mpearson@ the owners,
transferring from away from gab@.

Bug: 969934
Change-Id: I9a9707502f438cf6804070dd49ec079305761f01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773205Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691000}

macOS Mojave does not recognize .bundle directories as valid candidates
for accessibility permissions. Now that Chrome disclaims responsibility
for native messaging hosts it launches (crbug.com/945969), Chrome Remote
Desktop's Remote Support mode no longer works because its top-level
directory ends in .bundle.

This CL renames it to .app instead and maintains a symlink with the old
.bundle suffix. The main purpose of the symlink is to allow the launchd
script for Remote Access to be unchanged, as changing it causes the
previously-granted accessibility permissions to be lost. It also has a
lesser benefit of not breaking any third-party dependencies that may
exist.

Bug: 996993
Change-Id: Ifac617c819540152253cdcf2d2344f1022a87cdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773861
Auto-Submit: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690999}

This does two things:
1. Cleans up the language switching code to use consistent terms. Most
notably, it changes all instances of "inner-node switching" to
"sub-node switching".
2. Cleans up the language switching test infrastructure. A test
naming scheme was implemented to easily communicate the purpose of
each test. Also, tests were added to cover the two language switching
behaviors: node-level and sub-node-level switching. Each document
in the test databank is tested using node-level and sub-node-level
switching.

Bug: 923068
Change-Id: Ia16b785381966d97e089aae5dc08e23173876d08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754703
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Chris Hall <chrishall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690998}

This CL adds haptic feedback to basic back/forward gesture navigation
UI when edge swipe is made to the point where the action will be
triggered.

Bug: 992997
Change-Id: I5af8ac7513091afc5ea667727d376214fd39fb22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772780Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690997}

When a tooltip is hidden the widget is hidden, rather than closed, which
results in the old information showing briefly when it is shown again.
This happens because Show() runs before OnPaint() when the information
gets updated. This change closes the widget in Hide() which results in
the information getting repopulated properly.

Bug: 985472
Change-Id: Ib007067e952b6f0b8532cdf82f52742b7ac3316c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709635
Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690996}

This reverts commit 78fac991.

Reason for revert: Breaking some internal builders. Will reland once they are no longer building these targets.

Original change's description:
> Enable dist fusing for all feature modules. (reland)
> 
> Fixed: I have disabled building of the system image in next-* builds
> so there should no longer be an issue. next-* builds can be re-enabled
> when bundletool is updated.
> 
> This reverts commit 7c77403d.
> 
> Original change's description:
> > Revert "Enable dist fusing for all feature modules."
> > 
> > This reverts commit 27ca1df7.
> > 
> > Reason for revert: This CL causes an official build failure
> > https://crbug.com/996658
> > 
> > Original change's description:
> > > Enable dist fusing for all feature modules.
> > > 
> > > Change-Id: I66848fec159450a6d531e0af3f867988aa8b148f
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763431
> > > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> > > Commit-Queue: Ben Mason <benmason@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#689075}
> > 
> > TBR=tiborg@chromium.org,benmason@chromium.org
> > 
> > Change-Id: Ib696df42847a54c1257fae41ecb544df40f47e75
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764159
> > Reviewed-by: Alex Ilin <alexilin@chromium.org>
> > Commit-Queue: Alex Ilin <alexilin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#689454}
> 
> TBR=alexilin@chromium.org,tiborg@chromium.org,benmason@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: Id4687e7980b238cdbea04a1c8921b57a974f7cd0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768946
> Reviewed-by: Ben Mason <benmason@chromium.org>
> Commit-Queue: Ben Mason <benmason@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689947}

TBR=alexilin@chromium.org,tiborg@chromium.org,benmason@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ib1558378a9b2a12b7f0260a04eeb1fbe4d1330b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773836Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690995}

Extend the AllSitesAction metrics expiry day.

BUG=None

Change-Id: I84ebdb8d51e2ff0033e3b8afd726331d7e877850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771487Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690994}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: I265ac56aa1e95426b15ce94ab4d536ff4af37fad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700881
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690993}

To test the behaviors with ATS, let me add these builders.

Bug: 981433
Change-Id: I1883a4b0c16ec242564a6c29894dea32db51eb04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771230Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690992}

- Changed LoadIcons API to taking IconBundle as input.
- Completed loading icons in DisplayNotification.
- Handle empty input case.
- Added unit test for DisplayNotification with icons.

Bug: 963290
Change-Id: Iaaf9318a594ab0ac42a344692536daccc1f0c76d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772370
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690991}

https://skia.googlesource.com/skia.git/+log/674ee74e88d7..fd849a537a4b

git log 674ee74e88d7..fd849a537a4b --date=short --no-merges --format='%ad %ae %s'
2019-08-27 michaelludwig@google.com Revert "Combine snapBackImage and snapSpecial"
2019-08-27 michaelludwig@google.com Add Color4f variant for DrawEdgeAAQuad
2019-08-27 michaelludwig@google.com Revert "Calculate draw bounds in drawEdgeAAImageSet"
2019-08-27 fmalita@chromium.org [skottie] Disable text baseline snapping
2019-08-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-08-27 michaelludwig@google.com Combine snapBackImage and snapSpecial
2019-08-27 senorblanco@chromium.org gn format third_party/dawn/BUILD.gn.
2019-08-27 halcanary@google.com SkPlainTextEditor: from experimental to modules
2019-08-27 herb@google.com Check RemoteStrike pointer is still valid to send
2019-08-27 bungeman@google.com Add a way to disable baseline snapping.
2019-08-27 egdaniel@google.com Have visitProxies take a GrTexutreProxy instead of GrSurfaceProxy.
2019-08-27 michaelludwig@google.com Calculate draw bounds in drawEdgeAAImageSet
2019-08-27 csmartdalton@google.com Add renderTasks to the DAG before calling addDependency

Created with:
  gclient setdep -r src/third_party/skia@fd849a537a4b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@google.com

Bug: chromium:795132,chromium:985500
Change-Id: Id141237d624d36800fc4aad03e7a24e20f7a7e68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774036Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690990}

TBR=cammie@chromium.org

Bug: 997808,997732
Change-Id: I641f087328102947802a565dc0cf3475f011fb9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772779
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690989}

Updated life_of_a_resource docs to include the new inheritance structure
for R.java files. Also removed ResourceRewriter references as
ResourceRewriter is removed, and onResourcesLoaded is used instead for
rewriting webview resources.

Change-Id: I2b6babd4ca070a211e063c4ba181d457dde329c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746948
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690988}

Previously, BrowserPlugin was going to the main frame RenderWidget. This assumes
that the main frame RenderWidget exists, which in the future will not exist for
remote main frames.

Bug: 995981
Change-Id: I25b76e4ee9f99c7c0ca60a57088ecf95c99fe2c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772485
Commit-Queue: Erik Chen <erikchen@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690987}

This is a small amendment to https://crrev.com/c/1763375. The null check
added there should go before the DCHECK.

Bug: 997430
Change-Id: Iabdef43de616b6207516b7efff1c6ecd8e81de81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771621
Auto-Submit: David Bokan <bokan@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690986}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/f79bd7c2ef34..2002bac5500d

git log f79bd7c2ef34..2002bac5500d --date=short --no-merges --format='%ad %ae %s'
2019-08-28 haddowk@chromium.org [moblab] Enlarge the size of the moblab vm disk.
2019-08-27 saklein@chromium.org Package/GetBestVisible: Add chroot and build target handling.

Created with:
  gclient setdep -r src/third_party/chromite@2002bac5500d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: If34424d8cd2c1f58e5d76edec0f2a9280d901dc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774037Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690985}

Bug: 896775
Change-Id: I93c45f7a35e9293d52a7014d4033f25b6364fe96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772059Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690984}

Navigating to some websites with DeferAllScript enabled for that site
could cause a client redirect loop. A previous CL
(https://chromium-review.googlesource.com/c/chromium/src/+/1739493)
implemented this in a different way but that CL is not
mergeable back.

This CL alternates it in a different way which also fixes the problem
and can be merged back.

All the logic is behind a finch parameter and so can be easil turned off
using finch.

Tested by commenting out the older code. This will also
be tested by beta builders using browser tests.

Change-Id: Icb1075580d12890fe0ee9e902925eaf212744d37
Bug: 987062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760667
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Auto-Submit: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690983}

This CL adds either DCHECKs or conditionals to all non-test callsites of
WebView::MainFrameWidget. This is in preparation for remote main frame WebViews
returning nullptr.

Bug: 995981
Change-Id: I15b20a3a06da341c8e32c7585da190ac6c685012
TBR: tommycli@chromium.org, thestig@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769688
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690982}

Now special scroll/clip hierarchy is fully handled in property trees
after launch of BlinkGenPropertyTrees. Previously special properties on
cc::Layers were set for special scroll/clip hierarchy, and
cc::PropertyTreeBuilder built property trees according to the special
properties. Now cc::PropertyTreeBuilder is only for ui compositor which
doesn't have special scroll/clip hierarchy.

Bug: 994361
Change-Id: I2579fe0ba0dafff6f3640d69ca12540df4c78685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768910
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690981}

Remove the UseCounter associated with kLinkHeaderStylesheet, as we have
sufficient data on the feature. See https://crrev.com/c/1710505.

Bug: 19237
Change-Id: I95876d4ef4a4b4f8af96c0d1413b3f891c289bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772927Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690980}

The old message "reset complete" will be replaced with "Reset acknowledged". The old message could have been interpreted
as the changes were already applied, when they will be applied only after restart.

Also, the message was announced on page load. This PR will fix that.

Bug: 997353
Change-Id: I090eb15c71e8af0bfc442327d5bbda5ebb4600e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769676Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Andrii Sagaidak <ansagaid@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#690979}

TBR=guidou@chromium.org

Bug: 998305,998304
Change-Id: I8cbef0a94f5c339c1dceb332b2a81caad233d050
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773996Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690978}

This cl migrates kAssistantContextEnabled preference from arc_prefs to
assistant_prefs.

Also updated usages in Assistant Service and ash, removed obsolete
methods.

Detailed design doc: https://goto.google.com/assistant-prefs

Bug: b/110211045
Test: Run AssistantPrefsControllerTest.* in ash_unittests
Change-Id: Id1d2bf85be27b1db7af9f94f68566185e69c0b21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719830Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690977}

To be consistent with tablet splitview behavior, we decided to do the
same when in overview dragging an overview window to snap to a position
that already has a snapped window in place: the previous snapped window
will be put back into overview.

Bug:991695
TEST: SplitViewOverviewSessionInClamshellTest.BasicFunctionalitiesTest

Change-Id: I3411fff3257146bdcd6b4344206a7bbb1fbd6340
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765444
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690976}

Bug: 997759
Change-Id: Ib8130b4c5b606095e98c4eacf1d419e1e1656cc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771946
Commit-Queue: Andrew Luo <aluo@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690975}

Bug: N/A
Test: N/A
Change-Id: I389186132907a4ceb2bfbfe800113bd393517c20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773422
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Yves Arrouye <drcrash@chromium.org>
Auto-Submit: Yves Arrouye <drcrash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690974}

Previously it was by design that we don't end overview when opening
app list while splitview + overview are both active. But after the
discussion in Issue 991390, we decided to follow the current existing
behavior and let app list end splitview+overview in this case.

Bug: 996869
Change-Id: I15689b5cf61872110254446bdecce3bc3103aca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766090
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690973}

This also does other cleanup around the browser tests.
The HintsFetcher test within OGKSBrowserTest is covered by the existing
HintsFetcherBrowserTest and the hint cache UMA is now logged only once
per code path.

Bug: 969558
Change-Id: I989c648ead0106a3527de877f9c069e5050d8fbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773957Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690972}

Bug: 990454
Change-Id: Id2051e013bc1727ce320f1b5c2c6f0c9d83628b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772388
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690971}

They were set by blink before BlinkGenPropertyTrees when
cc:PropertyTreeBuilder used them to generate property trees at
cc side. Now blink generate property trees directly, so remove them.

Bug: 994361, 754339, 993936
Change-Id: I98559a49778ef6f14f96de61f1f6f54ad16631b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767492
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690970}

This is a simple consistency cleanup that makes it
easier to read through all the functions.

Bug: 998273
Change-Id: I2c45fe1befcf4bc72a3c92f63854e65e13d7aa97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773215Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690969}

RenderWidget holds onto a WebWidget. It has two methods GetFrameWidget() and
GetWebWidget() which should both just reference the WebWidget. Instead,
RenderWidget will [inappropriately] call out to its delegate to get the
FrameWebWidget, which the WebWidget should already be. This induces confusion.

This CL fixes the RenderWidget's webwidget_internal_ to always be a
WebFrameWidget when the RenderWidget is associated with a RenderView. This
changes the semantics, as we will never pass a WebViewImpl as a
RenderWidget's webwidget_internal_. This has one main side effect -- a remote
main frame's RenderWidget will now have a null WebWidget.

Change-Id: I930a9c91a88ac05882289df795ed1c4008e146fd
Bug: 995981, 419087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766889Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690968}

This changes RPHI::Cleanup to tear down the corresponding
IOThreadHostImpl, preventing further IO-thread tasks from being handled
by the object. This ensures that no further incoming interface requests
will be handled on the IO thread for the RPHI.

Specifically the purpose of this CL is to avoid any potential interface
binders referencing the host's ResourceContext, which may be destroyed
after Cleanup is run.

Bug: 997634
Change-Id: I25fb96daebd5b2801bb95189e5715986dc4af88c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773403
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690967}