GitLab

Anything less than 1/4 second and I was getting flakes locally.

Bug: 885252
Change-Id: Ia61a99abb4ef57686af01a34264b252096e10b36
Reviewed-on: https://chromium-review.googlesource.com/1242683Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594070}

TBR=sky@chromium.org, bokan@chromium.org
BUG=867063

Change-Id: I3f05f571b2d45e0f4cb4b04c401ae83cc63bd214
Reviewed-on: https://chromium-review.googlesource.com/1243574Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594069}

https://skia.googlesource.com/skia.git/+log/d37570b325e2..8d6aa1a2a00d


git log d37570b325e2..8d6aa1a2a00d --date=short --no-merges --format='%ad %ae %s'
2018-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9a20cc9744b3..1aae88c1e046 (1 commits)
2018-09-25 egdaniel@google.com Add support for RGB config to Vulkan.


Created with:
  gclient setdep -r src/third_party/skia@8d6aa1a2a00d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=bsalomon@chromium.org

Change-Id: Id2e130af165aad7d787f88a3eb0abfec68306988
Reviewed-on: https://chromium-review.googlesource.com/1244376Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594068}

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I196ed40d3d9d452373a2ad7217b1c2ab75147d2b
Reviewed-on: https://chromium-review.googlesource.com/1244357Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594067}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e64369342f2..c4a7356a469b


git log 8e64369342f2..c4a7356a469b --date=short --no-merges --format='%ad %ae %s'
2018-09-25 tandrii@chromium.org git cl: cache also LABELS data on a change.


Created with:
  gclient setdep -r src/third_party/depot_tools@c4a7356a469b

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I9b1c545a29a53356bd55613935296c253d6bd0bd
Reviewed-on: https://chromium-review.googlesource.com/1244117Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594066}

Fix: Plumb through IME state change use to notify of caret change

Bug: 887534
Change-Id: If472661b199afcbc8b30b7cb99e6d83b15114942
Reviewed-on: https://chromium-review.googlesource.com/1236735Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594065}

blink::EventHandler::ScheduleCursorUpdate crashes because we schedule
the cursor update on the current frame not the local frame root. The
mouse cursor update should be scheduled based on the timer of the page
not each frame, because we only have one mouse cursor.

Bug: 888905
Change-Id: Ia764985f489f68ab91eda38f5aae3d8014e55632
Reviewed-on: https://chromium-review.googlesource.com/1243568Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594064}

These are generic containers which make sense in WTF.

Bug: none
Change-Id: I7966ba923871fab7481c832eae5a16ecfa03c13c
Reviewed-on: https://chromium-review.googlesource.com/1237383Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594063}

Change-Id: I57817c7790153d3838f4d9039f62f04261b48390
Reviewed-on: https://chromium-review.googlesource.com/1243289
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594062}

BUG=827658

Change-Id: Id7981b607b150f8b471c0c67a581c9c2f6c1003c
Reviewed-on: https://chromium-review.googlesource.com/1243047Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594061}

Bug: internal b/116252835
Change-Id: I33854f87c93df1be26c4d61adaf8d894ac680af0
Reviewed-on: https://chromium-review.googlesource.com/1237408Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594060}

This is a pre-requisite for the USS migration of Wallet data/metadata.
This CL adds a struct that allows manipulation of the metadata
independently from the data.

Change-Id: Iad50c7f659fc1bda13a3eab47b746194fd316eb4
Reviewed-on: https://chromium-review.googlesource.com/1241754
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594059}

The SetBackgroundColor IPC has been recently moved from RenderView
to RenderWidget, but the RenderWidget still delegates handling of it
back to the RenderView. The RenderView then sets the background color
on its |frame_widget_| which is a WebFrameWidget attached to it in
RenderViewImpl::Initialize() via RenderFrameImpl::CreateMainFrame().

All RenderViewImpls do have a frame_widget_, since RenderViewImpl
ends up setting that. So RenderWidget::GetWebWidget() will always
return that frame_widget_ once RenderViewImpl::Initialize() has
completed. There is a space of time after RenderWidget::Init()
but inside RenderViewImpl::Initialize() where it would return
a different WebWidget (the WebWidget on the WebViewImpl directly),
but SetBackgroundOpaque IPC will not be received and handled during
that time.

So it is safe to use the frame_widget_ from the RenderViewImpl via
RenderWidget::GetWebWidget() directly. And thus RenderWidget can
set the background opaque on its WebFrameWidget without going
through RenderViewImpl (other than to get the WebWidget).

R=avi@chromium.org

Bug: 419087
Change-Id: I65bf680a24a6312f1c1d569d2023666cbc53e8f6
Reviewed-on: https://chromium-review.googlesource.com/1239169Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594058}

Bug: 806868
Change-Id: I446d7008c0cd560457d977842c4c155ce6ca9a4b
Reviewed-on: https://chromium-review.googlesource.com/1236264Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594057}

The previous patch delayed all frame sink manager set up while we
are backgrounded. This left us with a null |host_frame_sink_manager|
after a disconnect. This could lead to crashes. Instead, we now just
delay the actual connection to the GPU process, other set up, such as
BindAndSetManager which ensures a non-null |host_frame_sink_manager|,
is called immediately.

Bug: 888790, 866631
Change-Id: I5ad93df4b9aa7e7048faf8f51197ff1cf779c452
Reviewed-on: https://chromium-review.googlesource.com/1243603Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594056}

This CL creates a codepath that utilizes the WKWebView snapshotting
API when IsWKWebViewSnapshotsEnabled() is true. This CL intentionally
keeps the original codepath intact so as to minimize the risk of
refactoring errors.

Bug: 739840, 869256, 711455
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I80324e82573851b1a62cda75242679cf59008c3e
Reviewed-on: https://chromium-review.googlesource.com/1235714
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594055}

This reverts commit f52ee5d6.

Reason for revert: FindIt likely root cause for paint/invalidation/svg/image-animation-with-zoom.html flakes.

Original change's description:
> bitmap.getColor can be expensive (unmpremul, etc.), so don't call if not needed
> 
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Id97f574f12deffbfe28e943a7735823be1533db9
> Reviewed-on: https://chromium-review.googlesource.com/1233941
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Mike Reed <reed@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592508}

TBR=fmalita@chromium.org,reed@chromium.org,mtklein@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel

Bug: chromium:887076
Change-Id: I0aacc1a0d27bc2de676da2cfe7214ebb7cb5ba8c
Reviewed-on: https://chromium-review.googlesource.com/1243575Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594054}

Since the CommandBufferStub is passed as a raw pointer, we need to make
sure that if the underlying object is deleted, we are informed and do
not segfault when destroying D3D11VideoDecoderImpl afterwards.

Bug: 887822
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8ef13084d1d860ecf48aa580546808017e6590b9
Reviewed-on: https://chromium-review.googlesource.com/1239357Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594053}

This change adds the beginnings of the Serial API[1] to Blink. The
functions on navigator.serial and SerialPort are unimplemented.

[1]: https://wicg.github.io/serial

Bug: 884928
Change-Id: I76b26337570b07ecf9b265c2876c516058e90ee8
Reviewed-on: https://chromium-review.googlesource.com/1238486Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594052}

The LayoutSVGResourceFilter and LayoutSVGResourceMasker versions was
taking const LayoutObject* while the one on LayoutSVGResourceClipper
took a const FloatRect&. Align the two former with the later - thus
eliminating unnecessary dependencies on the client.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I26dcfb5ba9d164e4c5f97b9063cac8b6281cd6e6
Reviewed-on: https://chromium-review.googlesource.com/1243193
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594051}

https://webrtc.googlesource.com/src.git/+log/f3119ef66d5c..a7af0218826c


git log f3119ef66d5c..a7af0218826c --date=short --no-merges --format='%ad %ae %s'
2018-09-25 emircan@webrtc.org Disable ulpfec when field trial flag is present
2018-09-25 Peter) Slatala Add video support to media transport interface.
2018-09-25 buildbot@webrtc.org Roll chromium_revision 06f028f7..5198eaca (593823:593926)
2018-09-25 yvesg@webrtc.org Support e.g. --workers=2x to use two workers per core.
2018-09-25 sakal@webrtc.org Also disable AudioDeviceTest constructor for TSAN.
2018-09-25 henrika@webrtc.org Fixes issue where WebRTC.Audio.RecordSampleRateOffsetInPercent can report 100% (part II)


Created with:
  gclient setdep -r src/third_party/webrtc@a7af0218826c

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:b/113648245
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I931208280ee598eaedfce87380f3b433195b9930
Reviewed-on: https://chromium-review.googlesource.com/1243605Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594050}

Currently OfflineAudioContext does not do the clean up when rendering
is finished. This CL adds the clean up process when `oncomplete` event
is fired.

with --repeat-each=50 option.

Bug: 856317
Test: webaudio/Analyser/realtimeanalyser-float-data.html passes
Change-Id: Ia0556f666bc49ddb92666beab4171cfcf5c385ba
Reviewed-on: https://chromium-review.googlesource.com/1237384
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594049}

R=jochen@chromium.org

Bug: v8:7281
Change-Id: Icacc1c60f4b0c9c3646f1ea310435ee2f90f0a05
Reviewed-on: https://chromium-review.googlesource.com/1238534
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594048}

This CL merges the two metrics because of their similarity. Apart from
that, MainThreadScrollingReason does not collect metrics when a scroller
is composited but still blocked on main thread due to event handlers.

We really care about the reasons that make scrolling slow, so we should
also collect composited but blocking cases and the two similar metrics
can be merged.

Bug: 861754
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I295d94f7ca3892dbfde34e4c61db0d95af92b1fe
Reviewed-on: https://chromium-review.googlesource.com/1226828Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594047}

After crrev.com/c/1233174, failures/time outs in the associated
bugs are gone. Enable more tests in single process mash.

Bug: 877496, 884389, 884393
Change-Id: I35a96699fbee450e0522ff84267842e96fb7c29c
Reviewed-on: https://chromium-review.googlesource.com/1243194Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594046}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/90a12b3d4d1d..903514f95445


git log 90a12b3d4d1d..903514f95445 --date=short --no-merges --format='%ad %ae %s'
2018-09-25 dj2@everburning.com Roll DEPS for spirv-headers (#1920)
2018-09-25 stevenperron@google.com Get KillNameAndDecorates to handle group decorations. (#1919)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@903514f95445

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ie14884f18ca4f72d143854865b69dc49dbf71426
Reviewed-on: https://chromium-review.googlesource.com/1243608Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594045}

Bug: 832676
Change-Id: I3d5d3db47c3a1e1ba3f8604ac6ab4ca7857887cf
Reviewed-on: https://chromium-review.googlesource.com/1243728
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594044}

Bug: 705605
Change-Id: I7a056679917692e3ce326ac1553b2be110c9fdc5
Reviewed-on: https://chromium-review.googlesource.com/1239159Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594043}

We didn't set output clip for some effect nodes because the effect may
interleave with the current clip. This causes PaintChunksToCcLayer and
PaintPropertyManager go through the complex code path to deal with
interleaving effects and clips even if they don't interleave.

Now set output clip except when there are non-contained fixed-position
descendants which may escape the current clip.

The benefits are:
1. PaintChunksToCcLayer and PaintPropertyManager will go through the
   more optimized path if they see output clip for an effect, and
   will generate more efficient paint operations and cc paint
   property tree and layers.
2. In BGPT, this avoids bugs of PaintPropertyManager in the code
   path handling interleaving effects and clips in cases that clips
   and effect don't actually interleave. Thus the scope of the bugs
   will be much smaller, and we will just focus on the real cases
   of the bugs.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4a767b78ccb13a3672dfb6397d888208f3c3b960
Reviewed-on: https://chromium-review.googlesource.com/1239418
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594042}

This method is never called for a LayoutObject which has a "linked"
resource (<pattern>), so remove the handling of |linked_resource_|.

Change-Id: I8c57804ecb58f4b7e286e427f0b7de84909286b8
Reviewed-on: https://chromium-review.googlesource.com/1243807Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#594041}

This uninlines MaskUnits() and MaskContentUnits() in
LayoutSVGResourceMasker as well as ClipPathUnits() in
LayoutSVGResourceClipper - reducing unnecessary includes/dependencies.
Also streamline LayoutSVGResourceFilter::ResourceBoundingBox a bit by
using the FilterUnits() accessor, and remove the redundant null-check on
the element.

Change-Id: I658b7626627ac38fc8b43bfd54630adb778233e8
Reviewed-on: https://chromium-review.googlesource.com/1243117Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#594040}

The opt-in on DownloadFeedbackDialogView is very low, so remove it. At
the same time, refactor logic for reporting. The safe browsing
preferences are now checked within the DownloadProtectionService.

Bug: 827567
Change-Id: I1bed2d912b53504246f21a803f0095cd15ead125
Reviewed-on: https://chromium-review.googlesource.com/1238563Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594039}

This patch re-uses NGPaintFragment when corresponding
LayoutObject is the same.

Because paint system uses the address of DisplayItemClient
as the identifier, doing so not only reduces 2 alloc/free for
each NGPaintFragment (one for itself and another for children
vector) but also allows paint system to identify changes in
NGPaintFragment. Before this patch, all changes are handled
as "disappear" + "appear" pairs.

[blink_perf.paint] are mostly positive, up to 18.8%. Not all
tests are positive though, probably because the overhead to
compare LayoutObject is visible when no re-use is possible.

This patch is also the foundation to optimize paint
invalidation further. Still a good amount of invalidations
are done by subtree. By identifying NGPaintFragment for the
same node, we can tune the invalidation types to smaller ones.

[blink_perf.paint]: https://pinpoint-dot-chromeperf.appspot.com/job/13b534a7640000

Bug: 714962
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3079a7baefda7730521ec58715a7571669c9bfb4
Reviewed-on: https://chromium-review.googlesource.com/1237697
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594038}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/media_galleries.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=reillyg@chromium.org

Bug: 874080
Change-Id: I517572321e5fd315216e74d83ecf541a8fc57667
Reviewed-on: https://chromium-review.googlesource.com/1191415Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594037}

In Blink, select (default action verb) often equates with 'click'.

A page author can quite reasonably have a node with role menuitem and add a click listener. In this instances, Blink gives us default action verb select.

ChromeVox calls do default and triggers undesirable side effects.

Bug: 889018
Test: manually on Gmail.
Change-Id: I774001aa355ecaa64dd45878f40828f63feecd1a
Reviewed-on: https://chromium-review.googlesource.com/1241843
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594036}

https://skia.googlesource.com/skia.git/+log/297caafc5805..d37570b325e2


git log 297caafc5805..d37570b325e2 --date=short --no-merges --format='%ad %ae %s'
2018-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c5e68abdea9e..9a20cc9744b3 (1 commits)
2018-09-25 mtklein@google.com FuzzPath -> FuzzNicePath


Created with:
  gclient setdep -r src/third_party/skia@d37570b325e2

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=bsalomon@chromium.org

Change-Id: I57f83780b3f999db86e832f6a78d892d4e415d2d
Reviewed-on: https://chromium-review.googlesource.com/1243607Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594035}

Bug: 888704
Change-Id: I9167e623424c48de14dd1b5eeddf4ffd966d7d12
Reviewed-on: https://chromium-review.googlesource.com/1244077Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594034}

Bug: 832676
Change-Id: I5ea07707d3603cbe5ef88d098d96cdd41be05d0d
Reviewed-on: https://chromium-review.googlesource.com/1243976Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594033}

This implements the basics for a layout algorithm for the FIELDSET
element. It doesn't yet contain min/max calculation, legend inline
alignment, or block fragmentation support. Nor do we attempt to
paint/hit-test/etc anything correctly. Painting is likely to require
some rather persuasive code on the legacy side, especially if we want to
get paint layers right (for scrolling or e.g. relatively positioned
legends).

This new implementation is not enabled by default, but can be enabled
via the (new) LayoutNGFieldset runtime flag.

There has been some recent spec work for FIELDSET / LEGEND [1], and we
aim to accommodate for all of that. Among other things it's been decided
that a fieldset may be a flex or grid container. We are also expected to
support multicol and scrollable containers. None of these things are
supported by legacy layout.

The NG implementation is designed to handle all of that (although, with
this CL, it handles none of them). This is the reason why we need an
anonymous fieldset content wrapper child, which contains all the
fieldset contents. The rendered legend is placed on the outside of that.
This is both for convenience reasons and pure necessity.

Necessity: The legend is expected NOT to scroll together with the
contents if the fieldset is scrollable. That'd obviously look silly.

Conveniece: Taking the legend out from the fieldset contents means that
none of the other layout algorithms (block layout, multicol, flex, grid)
need to support legends in their own peculiar ways.

A fieldset element generates a fragment with up to two child fragments;
first the rendered legend (if any), then the fieldset content (if any).

Given this markup:

<fieldset>
  <legend>leder</legend>
  <div>hosen</div>
</fieldset

The fragment tree will look like this:

                     +--------------------+
                     | Fieldset container |
                     | (FIELDSET DOM node)|
                     +--------------------+
                       /                \
                      /                  \
   +--------------------------+   +-------------------+
   | Fieldset content wrapper |   | Rendered legend   |
   |         (anonymous)      |   | (LEGEND DOM node) |
   +--------------------------+   +-------------------+
                |                          |
                |                          |
             +-----+                   +-------+
             | DIV |                   | leder |
             +++++++                   +-------+
                |
                |
            +-------+
            | hosen |
            +-------+

The fieldset content wrapper can be a regular block container, or,
eventually, a scrollable container, a multicol container, a flex
container, or a grid container. Fieldset padding is applied on the
anonymous wrapper, NOT on the fieldset container. The reason for this is
that padding is on the inside of the scrollport (if any), so since the
wrapper establishes the scrollport (in order to exclude the legend; we
don't want it to scroll with the rest), the padding needs to go there as
well. At the same time, the legend needs to take fieldset padding into
consideration, so some extra code is required for this.

[1] https://github.com/whatwg/html/pull/3934

Bug: 875235
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: If952215459016e8528b2d94b74bca1c76e2fb4d6
Reviewed-on: https://chromium-review.googlesource.com/1236221Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594032}

Reocrd content area sizes when a new browser window is opened and when
the user resizes a browser window.

This is part of preliminary metrics collection for vision-based
phishing protection.

Bug: 882942
Change-Id: Ib6db98bf13193784b89029f467906ed4e0b3ffc4
Reviewed-on: https://chromium-review.googlesource.com/1228957
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594031}