GitLab

Record metrics for interactions with notifications. Stop exposing
openUrl() to native code, but keep it around; we use our own intent for
notification taps to track metrics now.

There are at three problems exposed by the metrics in their current
state:

  * At (first?) startup, we get multiple consecutive fetches for some
    reason. This results in two impressions, although the notifications
    have the same data, and Android only shows one. (In practice, users
    aren’t likely to frantically tap away on startup, the way I do, so
    these notifications would be suppressed by the frontmost-checking,
    which I’m trying to avoid)

  * None of the “HIDE” actions are conditional on the notification still
    being visible, so we record a HIDE_DEADLINE for each notification,
    even if the user tapped or swiped it away, and we record
    HIDE_FRONTMOST every time Chrome becomes frontmost, even if there’s
    no notification.

Broadly speaking, we want the “Actions” histogram to match the units of
the “Impressions” histogram, so that we can infer the fraction of
displayed notifications that received each action. To do that, we should
keep a list of which notifications we believe are being shown in prefs
(to support Android L, which doesn’t have the getActiveNotifications()
API) …in the next CL.

BUG=675561

Review-Url: https://codereview.chromium.org/2626643002
Cr-Commit-Position: refs/heads/master@{#443550}

BUG=675660
TBR=jam@chromium.org,eugenebut@chromium.org

Review-Url: https://codereview.chromium.org/2629583003
Cr-Commit-Position: refs/heads/master@{#443549}

BUG=gab needs to reduce ownership load

Review-Url: https://codereview.chromium.org/2622413003
Cr-Commit-Position: refs/heads/master@{#443548}

It ties SessionManager, AuthPolicy, Cryptohome

BUG=677497
TEST=manual

Review-Url: https://codereview.chromium.org/2601283002
Cr-Commit-Position: refs/heads/master@{#443547}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: SKIP_ON_SHUTDOWN (default)
  Tasks posted with this mode that have not started executing at
  shutdown will never run. However, any task that has already begun
  executing when shutdown is invoked will be allowed to continue and
  will block shutdown until completion.

  Note: Previously, the task was posted to the blocking pool with
  BLOCK_SHUTDOWN (default in SequencedWorkerPool).

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=667892

Review-Url: https://codereview.chromium.org/2627093004
Cr-Commit-Position: refs/heads/master@{#443546}

Implement check against overriding provisional saved forms when the origin is the same but the scheme is insecure. Adds logging to understand how often this occurs.

BUG=571580

Review-Url: https://codereview.chromium.org/2607413003
Cr-Commit-Position: refs/heads/master@{#443545}

HTML's parsing mechanism will automatically close form controls at the
end of a file. This is fine from a parsing perspective, but the behavior
does enable dangling markup attacks, such as those described in
http://www.thespanner.co.uk/2011/12/21/html-scriptless-attacks/ and
section 2 of http://lcamtuf.coredump.cx/postxss/.

Based on some discussion at https://github.com/whatwg/html/issues/2253,
this patch adds metrics to measure how often this happens in the wild
for `<textarea>` and `<select>` elements, and an experimental flag which
prevents form submission in the presence of those elements if they're
closed by reaching the end-of-file.

BUG=680462

Review-Url: https://codereview.chromium.org/2628723004
Cr-Commit-Position: refs/heads/master@{#443544}

This patch is to check if the mismatching EmbeddedWorker was launched on a new
process. If it's true, OnSetHostedVersionId IPC might be reached after
restarting the EmbeddedWorker.

BUG=668633

Review-Url: https://codereview.chromium.org/2627723004
Cr-Commit-Position: refs/heads/master@{#443543}

Now that the per-thread heaps have been shipped, HeapCompact no longer needs to
support multiple threads. This CL removes that code.

BUG=671856

Review-Url: https://codereview.chromium.org/2633463006
Cr-Commit-Position: refs/heads/master@{#443542}

ApplicationCache is a per-DOMWindow thing instead of a per-ExecutionContext thing.
It should use DOMWindowClient instead of ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2631653002
Cr-Commit-Position: refs/heads/master@{#443541}

This CL updates the ShareExtensionView, allowing the URL to be displayed on 3
lines and changes the animation of the screenshot view to have it expanding
from the right instead of sliding in from the left.

BUG=680912

Review-Url: https://codereview.chromium.org/2629853003
Cr-Commit-Position: refs/heads/master@{#443540}

ScopedIPCSupport has two separate and subtly different implementations:
mojo::edk::test::ScopedIPCSupport for test-only use, and
mojo::edk::ScopedIPCSupport for general-purpose use.

This unifies them into a much simpler general-purpose ScopedIPCSupport
implementation suitable for all practical environments.

Also removes mojo::edk::ProcessDelegate, as it is abstraction overkill.
Instead of InitIPCSupport taking a ProcessDelegate which goes unused
until shutdown, ShutdownIPCSupport now simply takes a callback to be run
upon completion.

BUG=None
R=jam@chromium.org
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2620633004
Cr-Commit-Position: refs/heads/master@{#443539}

This also modifies HeadlessDevToolsManagerDelegate to send error
responses if required parameters are missing.

BUG=679343,546953

Review-Url: https://codereview.chromium.org/2626823003
Cr-Commit-Position: refs/heads/master@{#443538}

BUG=603396
TBR=kinuko@chromium.org

Review-Url: https://codereview.chromium.org/2612903008
Cr-Commit-Position: refs/heads/master@{#443537}

In a real browser process, threads are started as BrowserThreadImpl
objects are created. TestBrowserThreadBundle should do the same.

This is a pre-requisite to add the option to create a real TaskScheduler
in TestBrowserThreadBundle, because TaskScheduler has to be created and
started at the same time.

BUG=659191

Review-Url: https://codereview.chromium.org/2628903002
Cr-Commit-Position: refs/heads/master@{#443536}

This patch adds flag "enable_ios_bitcode" to the build configuration
for iOS applications, frameworks, and libraries. It triggers adding
the "-fembed-bitcode" option when compiling and linking parts of the
projects for production builds (is_debug = false), and it triggers
adding the "-fembed-bitcode-marker" option in the case of debug builds.
That is along the lines of how Xcode does it, since the introduction
of the bitcode support and corresponding options.

The option only makes sense for Xcode build tools now and for iOS SDK
compatible builds (iOS, watchOS, tvOS). Thus, it the options is only
applicable when building for iOS with use_xcode_clang = true. And only
when building for real devices (with ARM CPUs). The latter limitation
is due to the usage of Intel assembly syntax and the Yasm tool when
building for iOS simulator (Yasm cannot emit bitcode sections now).
But it does not affect the workflow for the generated applications,
frameworks and libraries at the moment of submitting this patch:
For now, Xcode only cares about the availability of bitcode sections
in _all_ the pre-compiled parts of bitcode-enabled projects when
building those projects for ARM-based devices. Building for iOS
simulator, it handles the projects just fine, with or without bitcode
sections available in the linked libraries. That may change in the
future, of course, but currently it should be fine.

BUG=680711

Review-Url: https://codereview.chromium.org/2631573002
Cr-Commit-Position: refs/heads/master@{#443535}

extracts the ice candidate type (host, srflx or relay) from
the onicecandidate event and addIceCandidate call and shows
it as part of the type.

BUG=678292

Review-Url: https://codereview.chromium.org/2612063002
Cr-Commit-Position: refs/heads/master@{#443534}

This is the first step to get rid of deprecated CryptoModule methods in
NSSCertDatabase class and then later get rid of CryptoModule
abstraction.

BUG=None
TEST=net_unittests
R=mattm@chromium.org,jochen@chromium.org,armansito@chromium.org
TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2600053002
Cr-Commit-Position: refs/heads/master@{#443533}

This code is mostly permissions related, and most changes related to the
handling of permissions and content settings.

BUG=None

Review-Url: https://codereview.chromium.org/2627323004
Cr-Commit-Position: refs/heads/master@{#443532}

The original implementation of GCM Connection tracking had a DCHECK in
ConnectionLoginFailed to validate that ConnectionAttemptSucceeded had
been called first to validate the expected ordering of the calls.

That was removed as a result of crbug.com/673706 because it was failing.

After investigating, the reason for the failures is that the entry check
for calling ConnectionLoginFailed was checking the logging_in_ member on
the ConnectionFactoryImpl. However, that member tracks whether the
initial connection is established, not whether the login handshake has
been completed.

The correct check for when to call ConnectionLoginFailed is if the
result passed to SignalConnectionReset is LOGIN_FAILURE, since that
indicates that the MCSClient was unable to complete the login.

BUG=673706

Review-Url: https://codereview.chromium.org/2624653003
Cr-Commit-Position: refs/heads/master@{#443531}

Upon initialization, have {Device,User}ActiveDirectoryPolicyManager
request a policy fetch.

BUG=677511

Review-Url: https://codereview.chromium.org/2623203005
Cr-Commit-Position: refs/heads/master@{#443530}

It looks strange that NavigatorContentUtils is a supplement of LocalFrame.
It should be a supplement of Navigator.

BUG=610176

Review-Url: https://codereview.chromium.org/2627413003
Cr-Commit-Position: refs/heads/master@{#443529}

Supplement::host() is confusing with FrameHost since it's sometimes used
as host()->frame() etc. Hence this CL renames it to something clearer.

BUG=610176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2630703002
Cr-Commit-Position: refs/heads/master@{#443528}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ad889a60..e638a5a6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2630593003
Cr-Commit-Position: refs/heads/master@{#443527}

In recent discussion about adding a password generation setting in Password Manager settings it was mentioned that Auto sign-in text should have the same capitalization as on passwords.google.com. This CL fixes that.

BUG=400674

Review-Url: https://codereview.chromium.org/2632453002
Cr-Commit-Position: refs/heads/master@{#443526}

R=adamk@chromium.org,littledan@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2626003002
Cr-Commit-Position: refs/heads/master@{#443525}

BUG=671559

Review-Url: https://codereview.chromium.org/2625423003
Cr-Commit-Position: refs/heads/master@{#443524}

Highlights both ICE failure (iceconnectionstatechange -> failed)
and any error callbacks (indicated by ...OnFailure) so that they
are more visible.

BUG=678292

Review-Url: https://codereview.chromium.org/2621493002
Cr-Commit-Position: refs/heads/master@{#443523}

This CL improves the performance of the test by converting it to testharness.js.

With macOS debug: 7.3 sec -> 2.4 sec

BUG=658318

Review-Url: https://codereview.chromium.org/2631483002
Cr-Commit-Position: refs/heads/master@{#443522}

Predictor needs time to learn about user favorites pages. Special age metric is
introduced to show that the predictor database is large enough. Metric is
"large" when most users have learned about most of their pages, and "small"
otherwise.

BUG=680049

Review-Url: https://codereview.chromium.org/2625063002
Cr-Commit-Position: refs/heads/master@{#443521}

WindowPaintWorklet doesn't need to inherit from DOMWindowProperty
since it can retrieve a window object via Supplement<>.

BUG=610176

Review-Url: https://codereview.chromium.org/2628323002
Cr-Commit-Position: refs/heads/master@{#443520}

The class is generic and will be used also for output recording.

Also rename its implementation AudioInputDebugWriter -> AudioDebugFileWriter.

BUG=531883
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2620373005
Cr-Commit-Position: refs/heads/master@{#443519}

To use FrameMsg_Navigate_Type::RELOAD_MAIN_RESOURCE consistently
instead of FrameMsg_Navigate_Type::RELOAD in content, rename
RELOAD_MAIN_RESOURCE to RELOAD and override old behavior.

This change introduces two functional changes:

 1. RELOAD_ORIGINAL_REQUEST_URL is changed to revalidate
    only main resource instead of revalidating all.
    (in render_frame_impl.cc ReloadFrameLoadTypeFor)

 2. In LoadDataURL(), replace flag is set for usual reload
    operations. This was the original behavior, but unexpectedly
    changed in newly introduced ReloadMainResource cases.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2583123002
Cr-Commit-Position: refs/heads/master@{#443518}

Changing to a method that works even when the app permission is not "allowed".

For KitKat and later using getInt with LOCATION_MODE to get the location mode.
Versions pre KitKat do not have this. So for those versions using getString
with LOCATION_PROVIDER_ALLOWED to get the same information.

BUG=668923

Review-Url: https://codereview.chromium.org/2621223002
Cr-Commit-Position: refs/heads/master@{#443517}

Cr-Commit-Position: refs/heads/master@{#443516}

Since V8 now supports internal fields for the global proxy objects,
let's change the mappings among global proxy object / global object /
C++ instance in Blink.

With this CL, a global proxy object and C++ instance point to each
other, and a global object points to the C++ instance (without
reverse pointer).

BUG=675872

Review-Url: https://codereview.chromium.org/2620493002
Cr-Commit-Position: refs/heads/master@{#443515}

Now that we've shipped a per-thread heap, a Dead state should not happen.
This CL adds an assert to check the fact.

BUG=

Review-Url: https://codereview.chromium.org/2629853002
Cr-Commit-Position: refs/heads/master@{#443514}

For pages where there was a FrameOwnerElement with a null
ContentDocument CSS.getLayoutTreeAndStyles would crash.  This patch
fixes that.

BUG=680497, 546953

Review-Url: https://codereview.chromium.org/2623273006
Cr-Commit-Position: refs/heads/master@{#443513}

This change is a small refactor that pushes the details of whether
custom property values are stored in StyleInheritedVariables or
StyleNonInheritedVariables down into ComputedStyle. This is in preparation
for animations on registered custom properties and avoids duplicated
logic.

BUG=671904

Review-Url: https://codereview.chromium.org/2630683002
Cr-Commit-Position: refs/heads/master@{#443512}

These objects should be a per-DOMWindow thing instead of a per-ExecutionContext thing.
They should DOMWindowClient instead of ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2626423003
Cr-Commit-Position: refs/heads/master@{#443511}