GitLab

This patch enables AnimatableValues to be created from registered
custom property CSSValues. This does not enable interpolation of
the registered custom properties via AnimatableValues, this is only
required because AnimatableValues are still used by CSSTransitions
as a way of testing equality between animation keyframes and
computed style values.

This patch is a refactor and does not change behaviour.

BUG=671904

Review-Url: https://codereview.chromium.org/2723883005
Cr-Commit-Position: refs/heads/master@{#456023}

BUG=None

Review-Url: https://codereview.chromium.org/2736233002
Cr-Commit-Position: refs/heads/master@{#456022}

CryptString is intended for secret data, such as passwords, and the
memory is cleared on deallocation. However, where it is used in
libjingle_xmpp, the password is copied to other objects without any
magic clearing, so the security benefit is questionable.

In addition, CryptString is yet another string class, it's unused
within webrtc, and essentially unmaintained. If we can replace its use
in Chrome, it will be deleted.

BUG=webrtc:6424

Review-Url: https://codereview.chromium.org/2738973004
Cr-Commit-Position: refs/heads/master@{#456021}

This patch replaces
 FrameSeleciton::computeVisibleSelectionInDOMTree().isDirectional()
to
 FrameSeleciton::selectionInDOMTree().isDirectional()
since visible position normalization does not affect selection directional,
to simplify source code for improving code health.

BUG=698633
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2740893003
Cr-Commit-Position: refs/heads/master@{#456020}

Revert of Update DevTools animation timeline to handle TransitionKeyframeEffectModels (patchset #3 id:40001 of https://codereview.chromium.org/2732223002/ )

Reason for revert:
Looks like the test still keeps failing on Mac10.11.  Could look into this?

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/7814

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/7815

Original issue's description:
> Update DevTools animation timeline to handle TransitionKeyframeEffectModels
>
> CSS Transitions was refactored to use TransitionKeyframes instead of
> AnimatableValueKeyframes in https://codereview.chromium.org/2680923005.
> This patch updates the DevTools animation timeline to handle the new
> data type for transitions.
>
> BUG=698669
>
> Review-Url: https://codereview.chromium.org/2732223002
> Cr-Original-Commit-Position: refs/heads/master@{#455333}
> Committed: https://chromium.googlesource.com/chromium/src/+/a7a57ecd7c36b7bd579d45e0f199f7679edc5197
> Review-Url: https://codereview.chromium.org/2732223002
> Cr-Commit-Position: refs/heads/master@{#455995}
> Committed: https://chromium.googlesource.com/chromium/src/+/d20b39ee5745592e03e549d4576783ae03f5d3a9

TBR=dgozman@chromium.org,samli@chromium.org,alancutter@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698669

Review-Url: https://codereview.chromium.org/2738983005
Cr-Commit-Position: refs/heads/master@{#456019}

Headers generated by IDL compiler bring a lot of binding headers. We should avoid
to include such headers in popular base classes such as EventTarget and Node.

Review-Url: https://codereview.chromium.org/2742573005
Cr-Commit-Position: refs/heads/master@{#456018}

Our implementation checked childTypeAllowed() beforehand.  However, this is not
defined by the DOM standard, and caused some test failures. This CL removes it.

Also, this CL corrects the order of step 3 and step 4 because the above removal
regressed some passing tests, and the order correction recovers them.

BUG=700266

Review-Url: https://codereview.chromium.org/2745533004
Cr-Commit-Position: refs/heads/master@{#456017}

This changes the DCHECKs in disposeContext() to CHECKs and adds a new
CHECK in setGlobal(). This should help catch situations where:
- an already initialized global proxy object is overwritten but not
  reinitialized: this can happen during WebFrame::swap() if the
  embedder tries to access other script contexts, leading to out of sync
  state.
- the global proxy object that WindowProxy retains and the global proxy
  object retained by the v8::Context differ, also leading to out of sync
  state.

BUG=700077

Review-Url: https://codereview.chromium.org/2741923002
Cr-Commit-Position: refs/heads/master@{#456016}

Reland of Added HardwareAccelerationEnabled() function (patchset #1 id:1 of https://codereview.chromium.org/2745733002/ )

Reason for revert:
Ok, looks like this was the wrong one.

Original issue's description:
> Revert of Added HardwareAccelerationEnabled() function (patchset #1 id:1 of https://codereview.chromium.org/2737273003/ )
>
> Reason for revert:
> Speculative revert (will re-revert if false alarm)
>
> To see if reverting this fixes CloudPolicyManagerTest breakage
>
> Original issue's description:
> > Added HardwareAccelerationEnabled() function
> >
> > Added a new utility function to clarify and simplify checking whether
> > hardware acceleration is currently being used.
> >
> > R=emaxx@chromium.org, piman@chromium.org, jbauman@chromium.org
> > BUG=630728
> >
> > Review-Url: https://codereview.chromium.org/2737273003
> > Cr-Commit-Position: refs/heads/master@{#455947}
> > Committed: https://chromium.googlesource.com/chromium/src/+/c0d9fe79fd4582f8170cef92d1e3ad211b5f8518
>
> TBR=emaxx@chromium.org,jbauman@chromium.org,piman@chromium.org,sugoi@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=630728
>
> Review-Url: https://codereview.chromium.org/2745733002
> Cr-Commit-Position: refs/heads/master@{#456006}
> Committed: https://chromium.googlesource.com/chromium/src/+/7fc3177eec8f28989f48e1f45d4cdaec4566890a

TBR=emaxx@chromium.org,jbauman@chromium.org,piman@chromium.org,sugoi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630728

Review-Url: https://codereview.chromium.org/2743563005
Cr-Commit-Position: refs/heads/master@{#456015}

The feature has been disabled in M57
(https://codereview.chromium.org/2719473002). Therefore, now we add
fieldtrial_testing_config for the experiment.

BUG=646841

Review-Url: https://codereview.chromium.org/2746453002
Cr-Commit-Position: refs/heads/master@{#456014}

Revert of Statically link libprotobuf_lite on Linux (patchset #2 id:20001 of https://codereview.chromium.org/2746493002/ )

Reason for revert:
Not sure why, but it looks this starts to cause CloudPolicyManagerTest failures.

(Confirmed that locally reverting this CL fixed them)

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/39213

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/39214

CloudPolicyManagerTest.Register
CloudPolicyManagerTest.RegisterWithRetry
failed to process gtest output JSON
CloudPolicyProtoTest.VerifyProtobufEquivalence

Original issue's description:
> Statically link libprotobuf_lite on Linux
>
> Chrome has a direct dependency on a custom libprotobuf_lite in
> third_party, but Xenial and Yakkety add a dependency on the system
> libprotobuf-lite via Mir (which gets loaded from Gtk).
>
> Our third_party protobuf is not compatible with the upstream protobuf.
> Combine this with the fact that Xenial uses version 2 while Yakkety
> uses version 3, and it's basically impossible to make our third_party
> protobuf cooperate with the system one.  The solution is to always
> statically link protobuf on Linux.
>
> BUG=79722,700120
> R=pkasting@chromium.org
> TBR=bengr@chromium.org
> CC=dpranke@chromium.org,rsimha@chromium.org
>
> Review-Url: https://codereview.chromium.org/2746493002
> Cr-Commit-Position: refs/heads/master@{#455936}
> Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3782f62eee69a

TBR=pkasting@chromium.org,bengr@chromium.org,thomasanderson@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=79722,700120

Review-Url: https://codereview.chromium.org/2739203004
Cr-Commit-Position: refs/heads/master@{#456013}

This fixes artifacts in copied textures caused by insufficient precision in
"mediump" floats when used for sampling textures. On a Pixel XL, a mediump
only has 10 bits precision in fragment shaders, that apparently only works
fully for texture dimensions < 1024 pixels. Use "highp" if both GL_ES
and GL_FRAGMENT_PRECISION_HIGH are set for the shader.

(See the bug for more discussion and a proposed alternative patch.)

BUG=700031
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2744793002
Cr-Commit-Position: refs/heads/master@{#456012}

In particular, changes return values from FloatClipRect to const FloatClipRect&,
to avoid extra data structure copies.

In local testing, this CL produces up to a 10% improvement on the
rasterize_and_record_micro.partial_invalidation benchmark.

BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2745563004
Cr-Commit-Position: refs/heads/master@{#456011}

Make TopDocumentRootScrollerController store a Member<Page> instead of
a WeakMember<Page>. TopDocumentRootScrollerController and Page should
live and die at the same time, so this can just be a Member<Page>.

BUG=NONE

Review-Url: https://codereview.chromium.org/2742583002
Cr-Commit-Position: refs/heads/master@{#456010}

A MessageEvent's data value will in some cases hold on to significant
amounts of off-heap memory, so we take care of registering that
external allocation with v8, so that it can be taken into consideration
by the GC triggering logic.

However, when posting a message to another context, we must arrange for
its total 'external allocation' to be associated with the target context.
Including the sizes of any transferables (array buffers), so balance the
books more accurately by also transferring the external allocation cost
of those transferables.

R=
BUG=698981

Review-Url: https://codereview.chromium.org/2734173002
Cr-Commit-Position: refs/heads/master@{#456009}

Also some redundant code is removed.

BUG=698986

Review-Url: https://codereview.chromium.org/2734933006
Cr-Commit-Position: refs/heads/master@{#456008}

TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2740273002
Cr-Commit-Position: refs/heads/master@{#456007}

Revert of Added HardwareAccelerationEnabled() function (patchset #1 id:1 of https://codereview.chromium.org/2737273003/ )

Reason for revert:
Speculative revert (will re-revert if false alarm)

To see if reverting this fixes CloudPolicyManagerTest breakage

Original issue's description:
> Added HardwareAccelerationEnabled() function
>
> Added a new utility function to clarify and simplify checking whether
> hardware acceleration is currently being used.
>
> R=emaxx@chromium.org, piman@chromium.org, jbauman@chromium.org
> BUG=630728
>
> Review-Url: https://codereview.chromium.org/2737273003
> Cr-Commit-Position: refs/heads/master@{#455947}
> Committed: https://chromium.googlesource.com/chromium/src/+/c0d9fe79fd4582f8170cef92d1e3ad211b5f8518

TBR=emaxx@chromium.org,jbauman@chromium.org,piman@chromium.org,sugoi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630728

Review-Url: https://codereview.chromium.org/2745733002
Cr-Commit-Position: refs/heads/master@{#456006}

BUG=698853
R=mcasas@chromium.org

Change-Id: I5d9b9e4f1dc7e985fe48a2392afb24eedae45b59
Reviewed-on: https://chromium-review.googlesource.com/452138Reviewed-by: Miguel Casas-Sanchez <mcasas@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#456005}

Add a new callback from native CompositorImpl that corresponds to all
swap buffers. Then plumb it up to CompositorView and use it to implement
the draw completion imlementation for the SurfaceView.

Reland: fix bug causing crash when argument is evaluated out of order.

BUG=512636

Review-Url: https://codereview.chromium.org/2716193002
Cr-Original-Commit-Position: refs/heads/master@{#453965}
Committed: https://chromium.googlesource.com/chromium/src/+/eddd0d4f361b16d62eae38b198d6cedde1626186
Review-Url: https://codereview.chromium.org/2716193002
Cr-Commit-Position: refs/heads/master@{#456004}

In some situations origins may have geolocation permission, but the user
will see prompts, or geolocation won't work. In these cases, the
permissions API should indicate this, with either ASK or DENIED.

The situations are as follows:
1. When the device has location turned off
2. When Chrome does not have geolocation permission at the Androd level.

In both of these cases, Chrome may be able to prompt the user to rectify
the problem and if possible will do so when permission is requested.

This patch does not correctly model the second situation, as the plumbing
required to see if Chrome is allowed to prompt is not implemented. In
this case prompt is always return ASK, even if Chrome cannot prompt and
requests will fail. This is better than returning GRANTED however, as
it is closer to the truth.

BUG=672301

Review-Url: https://codereview.chromium.org/2743603002
Cr-Commit-Position: refs/heads/master@{#456003}

- Fix the implementation bug.
- Remove obsolete test in the legacy DOM conformance tests.
- Add tests for DocumentType node to WPT.

BUG=699812

Review-Url: https://codereview.chromium.org/2737273002
Cr-Commit-Position: refs/heads/master@{#456002}

This CL enables user to select the suggested page section header.
Details:
- Long press enables selection mode. Tap during selection will toggle the
  selection, but doesn't expand/collapse the items.
- Selecting the header internally selects all the related items.
- If all the items are selected manually, the header gets selected automatically.
- Deselecting any item will deselect the corresponding header if previously selected.
- The badging at the top reflects the number of items currently selected excluding the headers.
- When selected, the chrome logo on the header turns into tick mark similar to rest of the items.
- In presence of search text, headers are not displayed (no grouping),
  but once the text is cleared out, the headers will be back in.
  TODO: Hide the date headers when there is an active search.

BUG=689801

Review-Url: https://codereview.chromium.org/2701253006
Cr-Commit-Position: refs/heads/master@{#456001}

The CSS property UseCounter records which CSS properties are used on
each page. Custom CSS properties were not included. This patch adds a
call to the CSS property UseCounter::count method to the parsing code
for custom properties.

Note that
- all custom CSS properties are grouped together with the ID
  CSSPropertyVariable, and
- the BitVector used by the UseCounter is already large enough to
  include this data; the DCHECK in the count method just needs to be
  extended to allow the CSSPropertyVariable ID value.

BUG=458925

Review-Url: https://codereview.chromium.org/2702183002
Cr-Commit-Position: refs/heads/master@{#456000}

ContentLayer::ComputeSize() could return the wrong value when
can_use_live_layer is false because the live layer would be hidden by
detaching it from the parent layer.  That's not observable by
the early-returns in GetDrawsContentLeaf, so a full live layer size
could be returned, resulting in insufficient padding.  Switching to
HideLayerAndSubtree instead makes it observed by one early-return.

BUG=696977,699478

Review-Url: https://codereview.chromium.org/2739103004
Cr-Commit-Position: refs/heads/master@{#455999}

The MiniDumpWithFullMemoryInfo dump type tells MiniDumpWriteDump() to
include a MemoryInfoListStream, which produces a
MINIDUMP_MEMORY_INFO_LIST structure. This contains information about a
process' memory map.

Crashpad always includes this stream when writing minidumps for Windows
processes, but the fallback handler, which monitors the Crashpad
handler, uses MiniDumpWriteDump() instead of Crashpad’s minidump writer
implementation, and needs to be instructed to include this data.

Note that MiniDumpWithFullMemoryInfo is distinct from
MiniDumpWithFullMemory. The former just includes the memory map, while
the latter captures a full memory dump (large and undesirable).

Review-Url: https://codereview.chromium.org/2741773002
Cr-Commit-Position: refs/heads/master@{#455998}

When you expand things inside, popover can change size which is unexpected.
Regressed with crrev.com/72b6d797

BUG=none

Review-Url: https://codereview.chromium.org/2744773002
Cr-Commit-Position: refs/heads/master@{#455997}

R=dpapad@chromium.org
TBR=grt@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2743683003
Cr-Commit-Position: refs/heads/master@{#455996}

CSS Transitions was refactored to use TransitionKeyframes instead of
AnimatableValueKeyframes in https://codereview.chromium.org/2680923005.
This patch updates the DevTools animation timeline to handle the new
data type for transitions.

BUG=698669

Review-Url: https://codereview.chromium.org/2732223002
Cr-Original-Commit-Position: refs/heads/master@{#455333}
Committed: https://chromium.googlesource.com/chromium/src/+/a7a57ecd7c36b7bd579d45e0f199f7679edc5197
Review-Url: https://codereview.chromium.org/2732223002
Cr-Commit-Position: refs/heads/master@{#455995}

BUG=79722
R=inferno@chromium.org
TBR=avi@chromium.org

Review-Url: https://codereview.chromium.org/2741103004
Cr-Commit-Position: refs/heads/master@{#455994}

The addExtensions command gets sent on front-end relatively early,
when the onload event gets triggered.

However, in case of hosted mode, the load event happens before actual
InspectorFrontendHost initialization, since Runtime.js starts loading
and evaling all the dependencies by itself.

This patch protects from this race so that there's no annoying exception
thrown.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2744573002
Cr-Commit-Position: refs/heads/master@{#455993}

This patch introduces changes network waterfall canvas to use Path2D to
draw it's canvas items. This is in preporation to move it to use full
layers. (Followup patch will move the code to use the same path
for artifacts that are the same style)

R=caseq
BUG=697668

Review-Url: https://codereview.chromium.org/2731633002
Cr-Commit-Position: refs/heads/master@{#455992}

The gold plugin is needed only for linux official builds. However, since
it's only 17MB, it's better to always download it rather than having it
depend on GYP_DEFINES.

BUG=570091, 699210

Review-Url: https://codereview.chromium.org/2733043002
Cr-Commit-Position: refs/heads/master@{#455991}

BUG=631822,670539

Review-Url: https://codereview.chromium.org/2732203002
Cr-Commit-Position: refs/heads/master@{#455990}

f8fad4fa lossless incremental decoding: fix missing eos_ test

use if (br->eos_) break; as this snapshot does not contain:
16be192f VP8LSetBitPos: remove the eos_ setting

original commit message:

The patch  21735e0 introduced a bug where a goto path was not testing
the eos_ state.  If this happened just before a row_sync, a SaveState()
would be called that would store the eos_ state as '1' till the end
of the loop.  This usually was not a problem, except for the very last
chunk where we disable the incremental decoding altogether (we have all
the data). The termination tests were then going wrong.
The fix is to add a proper eos_ test and avoid falling in this inconsistent
state.

(https://chromium.googlesource.com/webm/libwebp/+/21735e06f7c1cb35562754e7f54365f24124ef15)

BUG=webp:332

Review-Url: https://codereview.chromium.org/2729473002
Cr-Commit-Position: refs/heads/master@{#455989}

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added CSSPropertyAPIFontFamily.cpp, which implements CSSPropertyAPI.h
- added parseSingleValue method to the CSSPropertyAPIFontFamily API
- removed CSSPropertyFontFamily from the switch
  statement in parseSingleValue, and calls the API instead.
- added api implementation details to CSSProperties.json5, indicating
  that CSSPropertyAPIFontFamily.h is generated.

A function pointer to the parseSingleValue function from the API for
the font-family property is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

Originally authored in patch 2641123002 by sashab@chromium.org

BUG=668012

Review-Url: https://codereview.chromium.org/2731953004
Cr-Commit-Position: refs/heads/master@{#455988}

This is part of the work to remove FrameHost.

BUG=691794

Review-Url: https://codereview.chromium.org/2727563004
Cr-Commit-Position: refs/heads/master@{#455987}

* Added Enable/Disable button in network blocking drawer.
* Persists the network blocking entries between devtools reloads.
* Changed code to use setBlockedURLs instead of add/remove counterparts.
* Moved icon notifier from main to network module.

see: http://imgur.com/a/G0VFI

R=pfeldman
BUG=691164

Review-Url: https://codereview.chromium.org/2692653003
Cr-Commit-Position: refs/heads/master@{#455986}

Remove FrameHost::eventHandlerRegistry(), and redirect all calls to
Page::eventHandlerRegistry().

BUG=691794

Review-Url: https://codereview.chromium.org/2741633002
Cr-Commit-Position: refs/heads/master@{#455985}

Cr-Commit-Position: refs/heads/master@{#455984}