- 11 May, 2018 40 commits
-
-
Sunny Sachanandani authored
This reverts commit 3e2200fa. Reason for revert: Caused some regressions. piman@ and I have been rethinking how throttling works. Might make sense to hold this off until we have a solid plan. Original change's description: > Do not throttle BeginMainFrame on SubmitCompositorFrameAck > > The original motivation for this code was to workaround early swap ack > on freon, but since freon isn't a thing anymore and we have a display > compositor that actually performs the swap, it should be ok to get rid > of it. This should improve throughput similar to main frame before > activation. > > R=brianderson > BUG=311213 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I5108c74a57ba201d25999989de8da4c7f81a5176 > Reviewed-on: https://chromium-review.googlesource.com/1031892 > Reviewed-by: Brian Anderson <brianderson@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554547} TBR=brianderson@chromium.org,sunnyps@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 311213,838469,838462,838461,838460,838458 Change-Id: I600b48b3b24a213954b563347dc3dc87dd143ad2 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1054987 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#557791}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e70d1621. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17271 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cvazac@akamai.com, igrigorik@chromium.org: external/wpt/server-timing TBR=markdittmer No-Export: true Change-Id: I512b92a5b8f073c4d4d768493b2e1a500caa2cb6 Reviewed-on: https://chromium-review.googlesource.com/1055087 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557790}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c6ea2dabfc8..8c77a6a1be7d $ git log 6c6ea2dab..8c77a6a1b --date=short --no-merges --format='%ad %ae %s' 2018-05-11 angle-skia-autoroll Roll third_party/externals/angle2/ 6110763fe..2fc0806f5 (2 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I4028b2b06396ca0e2125dcc207a1716e3c2d2ca0 Reviewed-on: https://chromium-review.googlesource.com/1054359 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557789}
-
Alex Moshchuk authored
Bug: 728219, 805705 Change-Id: Ia9a6d81a00376e2437b14357b1db4b97dd7dc8ef Reviewed-on: https://chromium-review.googlesource.com/1054833 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#557788}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5d1262780b26..0db9f061b85f $ git log 5d1262780..0db9f061b --date=short --no-merges --format='%ad %ae %s' 2018-05-04 cmtice cros_fuzz_test_env: Copy libs for llvm-symbolizer to sysroot. Created with: roll-dep src/third_party/chromite BUG=chromium:839939 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0fe7472ccb0e8c6074468661c314b6b224aedafa Reviewed-on: https://chromium-review.googlesource.com/1055108Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557787}
-
Yuichiro Hanada authored
Bug: 841694 Test: Manual testing on device. Change-Id: Ic9fe8a6dcf6c4063838070fb5cccfadfbf355f55 Reviewed-on: https://chromium-review.googlesource.com/1053622Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#557786}
-
Xiaochu Liu authored
Add a table to track cross-profile component usage. The table is a protobuf that has entries recording component usage for each component installed. When a user signs in: Component updater adds component usage entry when Load is called AND a component is loaded(succeed or fail). Component updater deletes component usage entry when Unload is called. When no user signs in: No entry is added or deleted. BUG=chromium:811431 TEST=unittest platform_AddPrinter.epson e2e test: Load/Unload when multiple users sign in/sign out. Manually check persistent metadata/component existence is corrrect after each operation. TODO: have an autotest to cover the e2e test. crbug.com/839542 Change-Id: I5e72ee8734adf6c6f1d8e885f4a41ebd33822af2 Reviewed-on: https://chromium-review.googlesource.com/946559 Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#557785}
-
Theresa authored
Add a new TextViewCompoundDrawables widget that supports explicitly sizing and tinting compound drawables. Update the "Simplified NTP" bookmarks and downloads buttons to use the new widget. BUG=836308 Change-Id: I7705135153cee9b053fb031bb69b6dbc636caee4 Reviewed-on: https://chromium-review.googlesource.com/1054556Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#557784}
-
dpapad authored
Specifically: - iron-a11y-announcer - 2.1.0 - iron-a11y-keys-behavior - 2.1.1 - iron-validatable-behavior - 2.1.0 Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iad7ccbf1022cdc394d01272bd9cb75c8f41265e3 Reviewed-on: https://chromium-review.googlesource.com/1052911 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#557783}
-
Kyle Horimoto authored
This class performs the low-level work to bootstrap a connection to a remote device; each specific connection type (e.g., BLE listener) must implement its own derived type. Bug: 824568, 752273 Change-Id: I74d5244ac3ad79aac6fa89c6e1f39513d72431de Reviewed-on: https://chromium-review.googlesource.com/1053392 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#557782}
-
rodmartin authored
Change-Id: I6d3f41c71f1e481da5bc0a67964e22828eca70dd Reviewed-on: https://chromium-review.googlesource.com/1050972 Commit-Queue: Martin Rodriguez <rodmartin@google.com> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#557781}
-
Xiaocheng Hu authored
The above two functions are the same if the RenderedPosition is always located in the InlineBox with a higher bidi level. With crrev.com/c/1052988, the condition is already satisfied. Hence, this patch merges the two functions into one. Bug: 811502 Change-Id: I0040af1d33d5105cb4504cbbdab2723041505d66 Reviewed-on: https://chromium-review.googlesource.com/1054583Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#557780}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I42b52ed7b128fa4ab7fcced81b32804e7438d5ed Reviewed-on: https://chromium-review.googlesource.com/1054049Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#557779}
-
Trent Apted authored
When scrolling with layers, flip the viewport with layer transforms under RTL. This is necessary because the layer-backed scrolling machinery is not privy to the automatic UI flipping done in toolkit-views. ScrollOffsets must be positive, so scrolling horizontally in RTL currently moves the contents to the left. Flipping the viewport layer resolves this and scrolls to the right but reverses the text, so flip the contents to compensate. Testing exposed a quirk of View::ScrollRectToVisible() under RTL on all platforms. It seems only Views::TreeView uses ScrollRectToVisible() to affect horizontal scrolling, but it's currently broken (see http://crbug.com/840236). Fix it so we can use it in the test. Bug: 840236, 828361 Change-Id: Ib16724ff73829a6383be82e7bd11893b3a7e2ffc Reviewed-on: https://chromium-review.googlesource.com/999076Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#557778}
-
https://pdfium.googlesource.com/pdfium.git/+log/5ad45e2f68bb..5e0b271b6935 $ git log 5ad45e2f6..5e0b271b6 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 dsinclair Fixup ASSERT in Bidi handling; Add bidi fuzzer. Created with: roll-dep src/third_party/pdfium BUG=chromium:839695 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8dd271c6d77f96e369f68a2be87e978a7211f9c4 Reviewed-on: https://chromium-review.googlesource.com/1054623Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557777}
-
John Abd-El-Malek authored
Instead use a NetworkContext, which runs in the network process when network service is enabled. Bug: 825242, 789640 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1f1244fbc71968a78bbb8ad1235e69f9935658fa Reviewed-on: https://chromium-review.googlesource.com/1008839Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#557776}
-
Timothy Loh authored
This reverts commit f1c154fd. Reason for revert: "org.chromium.chrome.browser.offlinepages.OfflinePageBridgeTest#testSavePageNoOrigin" is flaky https://bugs.chromium.org/p/chromium/issues/detail?id=842035 Original change's description: > Finch code for OfflinePagesSharing > > Ensures that test bots cover OfflinePagesSharing flag scenarios. > > Bug: 758733 > Change-Id: Id73eebc0e9592318ed4d33b95dc169574bc0efc3 > Reviewed-on: https://chromium-review.googlesource.com/1043349 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Jian Li <jianli@chromium.org> > Commit-Queue: Peter Williamson <petewil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557636} TBR=petewil@chromium.org,asvitkine@chromium.org,dtrainor@chromium.org,jianli@chromium.org Change-Id: Ib44d68b435936b2e0f943073fc458c5c7a6a44a9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 758733, 842035 Reviewed-on: https://chromium-review.googlesource.com/1055167Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#557775}
-
Xiaohan Wang authored
- Fix GpuVideoDecoder::Initialize() so that even if the stream is clear we still pass down the CDM ID. This is needed for handling future encrypted streams since GpuVideoDecoder doesn't do full-fledged reinitialization. - Fix AndroidVideoDecodeAccelerator so that even if the stream is clear we still requrest MediaCrypto, for the same reason. Bug: 840586 Test: Manually tested Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I99c4a86001aa75924f93d8ee634fd5136a85e2c1 Reviewed-on: https://chromium-review.googlesource.com/1050434 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#557774}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3c311c15709b..5d1262780b26 $ git log 3c311c157..5d1262780 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 lannm Reland "generic_stages: temporarily ignore all target prebuilts." 2018-05-10 lannm Revert "generic_stages: temporarily ignore all target prebuilts." Created with: roll-dep src/third_party/chromite BUG=chromium:826418,chromium:826418 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifce9ea2a650b6955231efa2bda325b4eb2f11357 Reviewed-on: https://chromium-review.googlesource.com/1054856Reviewed-by:
-
Fergal Daly authored
Nothing reads this field. Change-Id: I8b4af3655bf9fc89827ef992d0dc3fc0fc5be3fe Reviewed-on: https://chromium-review.googlesource.com/1053673Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#557772}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b6297b2b. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17270 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes TBR=markdittmer No-Export: true Change-Id: I870de391d8ec9e311bcd82dd386b176f27b369a1 Reviewed-on: https://chromium-review.googlesource.com/1054927 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2191308678e4..3d894aa45e08 $ git log 219130867..3d894aa45 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 ehmaldonado bot_update: Fix manifest creation. Created with: roll-dep src/third_party/depot_tools BUG=chromium:841936 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iacfd5922774e48e10d9829e21f2b75138803b6d2 Reviewed-on: https://chromium-review.googlesource.com/1054853 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557770}
-
Bo Liu authored
and use the implementation type directly. Bug: 813232 Change-Id: I53aaaf47a9f05a29930430c764bf87118c8c940e Reviewed-on: https://chromium-review.googlesource.com/1054640Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557769}
-
Xiaocheng Hu authored
RenderedPosition defines an "equivalence" relationship that, when we have two adjacent inline boxes, the following two RPs are considered equivalent: - RP at the rightmost offset in the left-hand-side box - RP at the leftmost offset in the right-hand-side box However, with RenderedPosition being used only in SelectionController for bidi adjustment, such general operation isn't needed: - There's no need to check equivalence for RPs that are not at bidi boundaries - For RPs at bidi boundaries, we can move the RP to the box with higher bidi level, and then compare the RPs directly Therefore, this patch changes RP's constructor that, if an RP is created at bidi boundary, make sure it's in the box with higher bidi level. In this way, there's no need to define equivalence, and existing call sites can simply check equality. This is a preparation patch for implementing same bidi adjustment in layout NG. Bug: 811502 Change-Id: Ic4171e60efb47a31a9f1916a185953c1fc660bb7 Reviewed-on: https://chromium-review.googlesource.com/1052988 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Lei Zhang authored
Add a note at the bottom of the file to let developers know where to put entries. Change-Id: I4201fb4526a6f9bb8354043b05ccd425aa0e8b1d Reviewed-on: https://chromium-review.googlesource.com/1054442 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#557767}
-
https://webrtc.googlesource.com/src.git/+log/7f0a06955092..73b36b582fcf $ git log 7f0a06955..73b36b582 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I28437c2c9d24d2166ae77e00bdeeb7947ed4f8e4 Reviewed-on: https://chromium-review.googlesource.com/1054769Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557766}
-
Kenneth Russell authored
The app was fixed and it's no longer necessary. Bug: 838970, 841604 Change-Id: I1bafa500ca3ad2845b15110e3e7bd0effc9fe471 Tbr: nodir@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1054357Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557765}
-
Sergei Datsenko authored
Add parameter to allow setting custom mount options for Mount() D-Bus call (e.g. for network or FUSE mounts). BUG=chromium:832507 Change-Id: Ie645bdddd3331fa14185a7691f548b9edb36562f Reviewed-on: https://chromium-review.googlesource.com/1053029 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557764}
-
Carlos IL authored
(Rebase of crrev.com/c/827676) This adapts remaining SSL interstitial tests in policy_browsertest.cc, captive_portal_blocking_page_browsertest.cc, and security_state_tab_helper_browsertest.cc to run with committed interstitials enabled. There is a small handful of other relevant tests scattered throughout the codebase, but those should be straightforward to adapt when we turn on committed interstitials by default. Bug: 752372 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic83cd3be0c2f4f95876d0bafbe8922932fa60f3c Reviewed-on: https://chromium-review.googlesource.com/1041126 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#557763}
-
David Black authored
This includes: - Changing gravity to BOTTOM_CENTER. - Increasing width to 640 dip. - Modifying DialogPlate appearance. See bug for details. Bug: b:78138093 Change-Id: I5ed05d27e8c71328700139926b2e0faae1360ff2 Reviewed-on: https://chromium-review.googlesource.com/1048270 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/native_client/src/native_client.git/+log/ab8b219c8b55..f9564e9d1b15 $ git log ab8b219c8..f9564e9d1 --date=short --no-merges --format='%ad %ae %s' 2018-05-09 hans nacl_switch_32.S: Add comment about alignment on Windows Created with: roll-dep src/native_client BUG=chromium:837667 The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mseaborn@chromium.org Change-Id: I9696bb7f656b4b299a22d36c00952c6665cd4ba5 Reviewed-on: https://chromium-review.googlesource.com/1054373Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557761}
-
Timothy Loh authored
This reverts commit 4a7db45d. Reason for revert: DraggableButtonTest.ActsOnMouseDownIgnoredForCommandClick fails on Mac10.12 bot, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/12756 (test times out) Original change's description: > Mac: Don't trigger mouse down events on bookmark buttons if command key is down > > Currently, all clicks on a bookmark folder button trigger their action on > mouse down, so that the folder menu can open on mouse down as expected. > > This also includes command click, which, rather than opening the folder menu, > opens all the bookmarks in the folder as new tabs. This isn't desirable since: > - The expected behavior is that button clicks trigger on mouse up. > - Triggering this on mouse down interacts poorly with the nested run loop > created by the confirmation dialog we display when the folder has many links. > > This change causes the action to no longer fire on mouse down if the user > is command-clicking the folder button. > > Bug: 840387 > Change-Id: Ic1364160cf26f2f3ea6e67d7dd0d6cf5079082eb > Reviewed-on: https://chromium-review.googlesource.com/1053947 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557676} TBR=rsesek@chromium.org,lgrey@chromium.org Change-Id: Iafb3cc8af01be9ba50a5e944b44750c62ee1df84 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840387 Reviewed-on: https://chromium-review.googlesource.com/1055027Reviewed-by:
-
Xing Liu authored
Chrome uses file URL to access file on disk. The path needs to be in a directory white list. This CL adds the external SD card directory to the white list, so file can be accessed through file URL. Also moves the core function getAllDownloadDirectories to PathUtils for easier access in native code. Bug: 838419,792775 Change-Id: If52202d6a62f89106b1e8533f8c1884b17cc9e0b Reviewed-on: https://chromium-review.googlesource.com/1050394 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#557759}
-
Kenneth Russell authored
This was a difficult bug to track down and is worth mentioning as a reason to prioritize stamping out flakiness on the waterfall. Bug: 840988 Change-Id: If2c56a80b02178ddc28efd44d73ec440a2aa2e0c Tbr: rjkroege@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1054585Reviewed-by:
-
Jinho Bang authored
The related spec was changed: https://github.com/w3c/payment-handler/pull/301 Bug: 840041 Change-Id: Ic76fffe0b974210edc3888378ded197d06e035b7 Reviewed-on: https://chromium-review.googlesource.com/1045705Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#557757}
-
Scott Chen authored
Bug: 836117 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I933a083f489d24c5ba4ff65636906b36f80f66dd Reviewed-on: https://chromium-review.googlesource.com/1054706Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557756}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/959fc245a92a..6c6ea2dabfc8 $ git log 959fc245a..6c6ea2dab --date=short --no-merges --format='%ad %ae %s' 2018-05-10 bungeman Non-normal blur styles to work with non-a8. 2018-05-10 skcms-skia-autoroll Roll skia/third_party/skcms 5b9549a..28e8b32 (1 commits) 2018-05-10 fmalita Fix unchecked allocation in kImageFilter::Common::unflatten() 2018-05-10 egdaniel Revert "Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter." 2018-05-10 brianosman Revert "Remove GrBackendObject and all related functions from Skia." 2018-05-10 mtklein Revert "strip down SkICC.cpp" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I62c06d06784d97df02150ac59ea14cf39c7e495e Reviewed-on: https://chromium-review.googlesource.com/1054828 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Lambros Lambrou authored
This fixes a warning on the official Linux builders. When building the remoting Debian package, don't strip output binaries in-place, as this confuses the build system into thinking that .stamp files are outdated. Instead, copy the binaries into the package staging area before running eu-strip on the copied binaries. Bug: 828970 Change-Id: I47f5ee43ecb3bf29bb7bc27844e2dd2dc171a190 Reviewed-on: https://chromium-review.googlesource.com/1054827Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#557754}
-
David Black authored
Now using a mojom struct containing: - text - icon URL (optional) - action URL (optional) Icon URL will be used to fetch an icon for a suggestion chip view. Action URL, when specified, dictates a different action to be taken on suggestion tap/click. Handling of icon/action URLs will come in follow up CL. Bug: b:78236856 Change-Id: I04c489285250ccb395cfe54c465a696c8539f619 Reviewed-on: https://chromium-review.googlesource.com/1050906 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Qiyu Hu authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/930c8c9de139..ce8067becb65 $ git log 930c8c9de..ce8067bec --date=short --no-merges --format='%ad %ae %s' 2018-05-07 qiyuh Add new device kMTUProperty and remove deprecated kGattServicesProperty 2018-05-09 jkardatzke Add GetContainerSshKeys call to vm_concierge 2018-05-07 sonnysasaka bluetooth: Add constants for NewBlue 2018-05-04 jkardatzke Add D-Bus service constants for CrosDNS service. Created with: roll-dep src/third_party/cros_system_api Bug: b:78593133 Test: CQ will verify this Change-Id: I313188e899d4549d476335b35696339d881a4256 Reviewed-on: https://chromium-review.googlesource.com/1054621Reviewed-by:
Ben Chan <benchan@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#557752}
-
