- 23 May, 2018 6 commits
 - 
- 
Becky Zhou authored
It was broken before because the toast was end aligned to the midpoint of the anchored view, and if the view is on the very left side of the screen, the toast can end up in the right side of the screen. Adding a fix to left aligned the toast if the anchored view is in the left half of the screen, and right aligned the toast if the anchored view is on the right half of the screen. Bug: 813746 Change-Id: I64f7f3c089eaf4665395d5fd56523c2b74206f68 Reviewed-on: https://chromium-review.googlesource.com/1066818Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#560848}
 - 
Achuith Bhandarkar authored
ChromeOSMemoryPressureMonitorTest.CheckMemoryPressure fails in the ChromeOS VM. BUG=844102 TEST=This is the test TBR=skuhne@chromium.org Change-Id: I58cef93ff9df4cd12b103a0bc5f99b576aab542f Reviewed-on: https://chromium-review.googlesource.com/1066466 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#560847}
 - 
Daniel Murphy authored
The flag is present so we can finch this feature on stable to mitigate risk for first-party customers like Docs Offline. Bug: 829141 Change-Id: Ibfed20dfe45c4a96445001f721a499e08e2bcb7e Reviewed-on: https://chromium-review.googlesource.com/1069601Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#560846}
 - 
Lukasz Anforowicz authored
Bug: 843775 Change-Id: I3a3f8689369bd9b447e0254396a0326e0d0db88b Reviewed-on: https://chromium-review.googlesource.com/1069566Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#560845}
 - 
Aaron Leventhal authored
Chrome places restrictions on the use of aria-activedescandant other browsers do not have and can sometimes lead to issues unique to Chrome. In this case, ARIA activedescendant required an ARIA role. Bug: 845651 Change-Id: I3e5743e253db377e00bd4538ec076c1b907bdce6 Reviewed-on: https://chromium-review.googlesource.com/1069608Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#560844}
 - 
Will Harris authored
This removes the system level precondition and will now only run the test if the file is actually meant to be read-only. BUG=843211 Change-Id: I55abddd4f250732f815875dd626a80bda999f205 Reviewed-on: https://chromium-review.googlesource.com/1060172 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#560843}
 
 - 
 - 22 May, 2018 34 commits
 - 
- 
Roger McFarlane authored
The test has an inherent race between triggering the showing of suggestions and starting the loop to wait for notification that the suggestions have been shown. The test was asserting that the loop had been started before quiting. Removed this (racily invalid) insertion. Also switched over to use base::RunLoop instead of using content::MessageLoopRunner (per crbug.com/668707), to remove additional flakiness. Bug: 843935, 668707 Change-Id: I3084b64697983b64c34fedd26e690d419807f2a8 Reviewed-on: https://chromium-review.googlesource.com/1069531 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#560842}
 - 
Dmitry Gozman authored
- Use operator SkPoint() instead. - Wrap values with FloatToSkScalar to handle infinite values. - Removed dependency from platform/geometry to platform/graphics. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iac69e353e46d48744a80a9c845bf1aedda80c209 Reviewed-on: https://chromium-review.googlesource.com/1067733Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#560841}
 - 
Christian Biesinger authored
Provide a helper function in ng_length_utils that calls node.ComputeMinMaxContentSizes for you. R=eae@chromium.org,mstensho@chromium.org Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id5e559aa1d9991f1e39d74fd84578ca2b7641883 Reviewed-on: https://chromium-review.googlesource.com/1069628 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#560840}
 - 
Sam McNally authored
Bug: 676224 Change-Id: I101d138ac8ca72815cc6aa0a1b5ad4218b3c3001 Reviewed-on: https://chromium-review.googlesource.com/1065753Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#560839}
 - 
Matthew Jones authored
This patch removes an unused bottom shadow from the bottom sheet's toolbar. Modern design does not require one by default, existing sheet contents provide their own shadow when needed, and the existing one caused issues on Android J devices. Bug: 829454 Change-Id: I4cf9a36e6efbf107499516181f97c57c556632cf Reviewed-on: https://chromium-review.googlesource.com/1068653Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#560838}
 - 
Alexandr Ilin authored
base::MappedReadOnlyRegion is a struct containing both a mapping and a region. It was not always clear what the best way to check for error. This CL adds a IsValid() method to this struct that allows to easily perform the check. Also this CL makes it explicit that base::MappedReadOnlyRegion has a mapping and a region that are either both valid or invalid. TBR=sky@chromium.org Bug: 845086 Change-Id: Ia61b12816167592798fc6fcb8e49f09e0198ef48 Reviewed-on: https://chromium-review.googlesource.com/1068930 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#560837}
 - 
Trent Apted authored
These fell off the waterfall in r549698. Re-Enable: - browser_action_button_interactive_uitest.mm Keep Disabled (tests obsolete secondary UI): - translate_bubble_test_utils_views_cocoa.mm Mostly Re-enable: - permission_bubble_cocoa_interactive_uitest.mm * PermissionBubbleInteractiveUITest.SwitchTabs regressed. Bug: 845389 Change-Id: If4c9efe9541786f5cf114c6a2c22d7400d92d30b Reviewed-on: https://chromium-review.googlesource.com/1068631Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#560836}
 - 
Amin Hassani authored
Add enum value kErrorCodeFirstActiveOmahaPingSentPersistenceError to enum UpdateEngineErrorCode. Bug: 833980 Change-Id: I092149a7ceb608898587a37e3aaab5c520db95ff Reviewed-on: https://chromium-review.googlesource.com/1062659Reviewed-by:
Xiaochu Liu <xiaochu@chromium.org> Commit-Queue: Amin Hassani <ahassani@chromium.org> Cr-Commit-Position: refs/heads/master@{#560835}
 - 
Bo Liu authored
Change-Id: I58caeb3e09744cd1dbf66fd7e5734899dd9eaa10 Reviewed-on: https://chromium-review.googlesource.com/1069343Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#560834}
 - 
David Jacobo authored
c/b/cros/apps/intent_helper makes use of content::WebContents a lot, it should be nice if we have a uniform name for objects of this type in the whole class. Renaming |tab| to |web_contents| here and there, also adding a comment to chrome::SetIntentPickerViewVisibility(). Bug: None Test: Build Change-Id: I4d6252fa4a1baf03fd48e60e7fb7a8ddcb46529b Reviewed-on: https://chromium-review.googlesource.com/1069453Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#560833}
 - 
Dominic Mazzoni authored
We make frequent mechanical changes to this directory and it doesn't make sense to give the third_party README warning each on presubmit each time. Bug: none Change-Id: I1e9cb9189f2c1c628e89eeb12bac713d6ddbca66 Reviewed-on: https://chromium-review.googlesource.com/1062080Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#560832}
 - 
Kevin McNee authored
Since this test uses chrome.gpuBenchmarking.pinchBy, we need to have it run with a compositor. As part of issue 787924, we will no longer handle gesture pinch events on the main thread. Bug: 787924 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0127028f246ae72a772ef8c9f163b4403b6c3036 Reviewed-on: https://chromium-review.googlesource.com/1068625 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#560831}
 - 
Mounir Lamouri authored
Before this change, the logic was in //chrome but would only rely on //content concepts. Keeping it in //content reduces the level of plumbing. It's also moving from frame.mojom to the media IPCs to be around the other PIP calls. Bug: None Change-Id: I401126871b48feaf551001ebdfc2f0f319ec75e0 Reviewed-on: https://chromium-review.googlesource.com/1065823Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#560830}
 - 
Fady Samuel authored
This CL removes content_source_id in VisualProperties which is no longer used. It also renames |local_surface_id_| to |local_surface_id_from_parent_| in RenderWidget to clarify where the viz::LocalSurfaceId is coming from. Bug: 672962 Change-Id: I11763addeef9d84eab93be624bacedc40757b616 Reviewed-on: https://chromium-review.googlesource.com/1055470 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#560829}
 - 
Fabrice de Gans-Riberi authored
This is a reland of 90f86c11 Original change's description: > Fuchsia: Stop setting OS_POSIX > > Bug: 836416 > Change-Id: Ib59796358ff2109ec0b55686974a84980e18254e > Reviewed-on: https://chromium-review.googlesource.com/1020375 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Reviewed-by: Matt Mueller <mattm@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560013} Bug: 836416 Change-Id: I43f34aa644e51d231c7c131b4be364b6ccee2d38 Reviewed-on: https://chromium-review.googlesource.com/1066711Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#560828}
 - 
Henrique Grandinetti authored
Add the BaseTimeLimitProcessor class, needed to implement the BaseTimeLimit policy. This does not implement the methods logic, but provides the interface needed to unblock the UI development. Bug: 823536 Change-Id: Ie8adecaea3bb0de8c20396959a6b37fd08cbca47 Reviewed-on: https://chromium-review.googlesource.com/1066830 Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#560827}
 - 
Lei Zhang authored
Change-Id: I87f1c473460388606947762060b3c40697f18065 Reviewed-on: https://chromium-review.googlesource.com/1069592Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#560826}
 - 
Malay Keshav authored
The best resolution for FHD(1080p) devices are not the ones where the ui scale is 1 rather its the mode where the ui scale is 0.8 and the device scale factor is 1.25. Bug: 845208 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If3ec352d3edbfb85216f5ee1dd125857d13d1abb Component: Display settings Reviewed-on: https://chromium-review.googlesource.com/1067592Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#560825}
 - 
danakj authored
Before https://chromium-review.googlesource.com/c/chromium/src/+/1038565 these layers would change their contents-opaque state when the GraphicsLayer did, even though the image layer has its contents-opaque set when setting the image. Disallowing that to change created a memory regression, as it must be that some images are not opaque, but the GraphicsLayer becomes opaque later and the image layer should be marked as such too. R=pdr@chromium.org Bug: 838693, 841252 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I97c007b46d0bafcb9ecf19fad77327053e978aa2 Reviewed-on: https://chromium-review.googlesource.com/1069194Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#560824}
 - 
Scott Violet authored
This way it can be used with other tests. BUG=837684 TEST=covered by test Change-Id: Iac388d27fa5be1bcd2b6d7f937dabdc4949dec34 Reviewed-on: https://chromium-review.googlesource.com/1069303 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#560823}
 - 
Joey Scarr authored
The net effect of this change is to explicitly run update.py using sys.executable rather than running os.popen directly on the script. Bug: 396230 Change-Id: Ie896303ed084f254ab7a7b1da201d108c8718ac5 Reviewed-on: https://chromium-review.googlesource.com/1068530 Commit-Queue: Joey Scarr <jsca@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#560822}
 - 
Bill Orr authored
In anticipation of making VRDevice a mojo interface, this change starts to trim back where VRDevice is used. VRShellDelegate can, for now, still use GvrDevice, which can maintain current functionality. BUG=795510 Change-Id: I37b4c9b8c914c5f271464ee7488d0002ffa208ac Reviewed-on: https://chromium-review.googlesource.com/1068025 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#560821}
 - 
Morten Stenshorne authored
Better detection of "legitimate" reasons to use many columns. Let the allowance be based on the amount of "content". The more content (lines or boxes) inside a multicol container, the more columns will be allowed. We used to base it on the column height, but it turned out that it wasn't good enough. Also, there are legitimate reasons to use more than 500 columns in some cases, so increase the limit to 2000. With the current implementation, this may get very slow, because of quadratic performance complexity, presumably somewhere in paint code. One multicol regressed in LayoutNG. Not sure why. It shouldn't have passed in the first place. This CL was previously landed as https://chromium-review.googlesource.com/c/chromium/src/+/1057629 and then reverted because of test flakiness. This new CL has reduced the number of columns in those tests, so that the tests don't occasionally time out on slow bots. Bug: 808189,845155 Change-Id: I55d560faba73128518a689ae38f628ee89e58568 Reviewed-on: https://chromium-review.googlesource.com/1068929 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#560820}
 - 
Koji Ishii authored
These tests: * fast/css/resize-corner-tracking.html * fast/forms/textarea/textarea-align.html use quirks mode, and relies on non-interoperable behavior of [line height quirks]. This patch changes it to standard mode as the difference does not look worth to fix in LayoutNG. <textarea></textarea><br> <textarea></textarea><br> <textarea></textarea><br> <textarea></textarea> <div><textarea></textarea></div> If this test is changed to standard mode, all browsers except Edge create [strut] for all lines. On the other hand, in quirks mode: * <textarea> is a replaced element that it should not create a [strut] as per [line height quirks] spec. Blink/LayoutNG follows this, while Gecko creates [strut]. Changing this in Blink causes ~320 tests to fail. * Not defined, but Blink/WebKit comment says, <br> should create [strut] only when it is on the line by itself. Blink mistakenly applies this rule in this case, and that the first 3 lines have [strut], while LayoutNG does not. Changing this in Blink causes ~80 tests to fail. * Edge does not create [strut] in either mode. [line height quirks]: https://quirks.spec.whatwg.org/#the-blocks-ignore-line-height-quirk [strut]: https://drafts.csswg.org/css2/visudet.html#strut Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I010a6f1a003d6c30edaa2318d092f0828d9ce6b7 Reviewed-on: https://chromium-review.googlesource.com/1065832 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#560819}
 - 
dpapad authored
Bug: 843770,843348 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifb8517c90cecd569b6600b896329d713a96c82e7 Reviewed-on: https://chromium-review.googlesource.com/1068074Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#560818}
 - 
Jordy Greenblatt authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I16199932c7aaafd07f99fa134c6be77b30e29926 Reviewed-on: https://chromium-review.googlesource.com/1068057 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#560817}
 - 
Ryan Landay authored
This CL makes two changes to the scrolling for the new Android non-overlapping tab switcher: - Lowers the friction - Changes the scrolling logic so scrolls always end with a tab centered This is acccomplished by adding some methods on StackScroller to allow changing the friction and setting a snap distance, and calling them in NonOverlappingStack when we construct the StackScroller. Bug: 828224 Change-Id: I996c6b728dd6805add001be1f294ec65467f9252 Reviewed-on: https://chromium-review.googlesource.com/1066280 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#560816}
 - 
Stephen McGruer authored
When in print mode, we don't do 'normal' visual output; painting is done explicitly to a special output canvas. As such, there is little point in doing composited animation updates, as we will not be showing the result. This also fixes a DCHECK in BlinkGenPropertyTrees/SPv2 mode, where paint was skipped but DocumentAnimations::UpdateAnimations wasn't - this caused UpdateAnimations to fail its DCHECK for the expected lifecycle state. Bug: 842937 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If8a0e11bd25e931dd02434e18ec90a02c4e8f9e1 Reviewed-on: https://chromium-review.googlesource.com/1066405Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#560815}
 - 
Theresa authored
If any of the currently enabled services can perform gestures, consider accessibility to be enabled. This changes AccessibilityUtil#isAccessibilityEnabled to return true if Switch Access is enabled. Since the necessary capabilities APIs are only available on N+, on L & M we look specifically for Switch Access to be enabled by checking the ResolveInfo of enabled accessibility services. BUG=839598 Change-Id: I30eceb33d6092c7000371e2733a63f35a9b7d4bb Reviewed-on: https://chromium-review.googlesource.com/1054131Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#560814}
 - 
Justin Novosad authored
Async destruction of Canvas2DLayerBridge was removed from the code a long time ago. There still some traces of it in the code. This CL is just a cleanup. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I86fd0424503be99e2a0310751e3867217d3b315e Reviewed-on: https://chromium-review.googlesource.com/1066741 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#560813}
 - 
edchin authored
Currently, the image data source must be set before the mediator starts updating its consumer. The mediator will start updating its consumer as soon as it starts observing sync state, which starts before the view controller has been presented. Therefore, the imageDataSource will DCHECK since it is being accessed before it is set. The order of setting the imageDataSource should not matter. So a bug was filed for this: crbug.com/845636. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9893493c1f0e2927b9bc6b69bfdea0142f03adab Reviewed-on: https://chromium-review.googlesource.com/1069590Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560812}
 - 
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5b58b7c14c44..91dfa3b571f1 $ git log 5b58b7c14..91dfa3b57 --date=short --no-merges --format='%ad %ae %s' 2018-05-22 egdaniel Reland "Move gn setup for vulkan library/headers into their own third_party directory." 2018-05-22 bungeman Remove include/gpu/gl from include paths. 2018-05-22 bsalomon Use layered templates for optional vertex attributes in GrTextureOp. 2018-05-22 mtklein start cleaning up non-skcms SkColorSpaceXforms 2018-05-22 egdaniel Add more blacklists for intel 405 vulkan perf bot. 2018-05-22 herb Remove SkTextBox 2018-05-22 bungeman Revert "Revert "IWYU for tests starting with 'D'."" 2018-05-22 senorblanco GrTessellator: fix crash on merging a dead edge. 2018-05-22 benjaminwagner Rename SwiftShader bots from CPU to GPU. 2018-05-22 bungeman Update SampleLua and lua files. 2018-05-22 jcgregorio Revert "Update docs preview URL in presubmit" 2018-05-22 bsalomon GrTextureOp: Rename template params "V" instead of "Vertex". 2018-05-22 angle-skia-autoroll Roll third_party/externals/angle2/ 787338f9b..534b00dbd (1 commit) Created with: roll-dep src/third_party/skia BUG=chromium:844873 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: I3f8ecf7422051adac07c78fe2bac5a8e3a118d2f Reviewed-on: https://chromium-review.googlesource.com/1069416 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560811}
 - 
Aleks Totic authored
Container adds inline_end padding to inline children Bug: 728378 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I43008ae9ec0b201eff0197fe457bc3a7483e4566 Reviewed-on: https://chromium-review.googlesource.com/1068139 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#560810}
 - 
James Darpinian authored
Change-Id: I4513ce566269daddeb2da39ef9d658038616612d Reviewed-on: https://chromium-review.googlesource.com/1069554 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#560809}
 
 -